pull request commentant-design/ant-design

Fix className prop issue when using Tooltip

What confuse me is why you want to add classname to tooltip, I am not sure if it will work.

swillis12

comment created time in 5 days

issue commentant-design/ant-design

Transfer组件onChange参数可否添加一个参数确定当前操作的是哪个Transfer组件

你可以生成一个函数数组啊,你map的时候把函数也映射进去

zhangyanf

comment created time in 6 days

issue commentant-design/ant-design

create a react hooks version without class component

No such plan now, but it should be in the future.

leeseean

comment created time in 6 days

issue commentant-design/ant-design

Drawer getContainer设置为htmlElement导致前几次无法打开

A hack way. https://codesandbox.io/s/xlrr7552mw

gonenoob

comment created time in 6 days

issue commentant-design/ant-design

Cascader - loadData prop - automatic state update

Actually you have set it yourself. image

MFoksik

comment created time in 6 days

push eventztplz/ant-design

ztplz

commit sha c12bfccc8fc3985b2b1d9762f2c1b4d652eb5a36

Update

view details

push time in 7 days

push eventztplz/ant-design

ztplz

commit sha 519a53e3d407168c64fde62076154df5cd5a3020

Update

view details

push time in 7 days

push eventztplz/ant-design

ztplz

commit sha 0fc3201d3b8d6a59b63b826d1bc74086732c8730

Update

view details

push time in 7 days

push eventztplz/ant-design

ztplz

commit sha a8f4696fc6c79cf1bd0055ba9dc67fed91765e7d

Update

view details

push time in 7 days

push eventztplz/ant-design

ztplz

commit sha f1d6c1f6ca4c4726da8c6331cc141dca697d0a2b

test

view details

push time in 7 days

pull request commentant-design/ant-design

Fix Modal's open animation

感觉要换个方法 放外面ssr会挂

ztplz

comment created time in 7 days

push eventztplz/ant-design

ztplz

commit sha 73652564ec0fcd147da60d0ff4390c92a76f0f04

Fix incorrect event type

view details

push time in 7 days

Pull request review commentant-design/ant-design

Fix Modal's open animation

 export default class Modal extends React.Component<ModalProps, {}> {     }   }; -  componentDidMount() {-    if (mousePositionEventBinded) {-      return;-    }-    // 只有点击事件支持从鼠标位置动画展开-    addEventListener(document.documentElement, 'click', (e: MouseEvent) => {-      mousePosition = {-        x: e.pageX,-        y: e.pageY,-      };-      // 100ms 内发生过点击事件,则从点击位置动画展示-      // 否则直接 zoom 展示-      // 这样可以兼容非点击方式展开-      setTimeout(() => (mousePosition = null), 100);-    });-    mousePositionEventBinded = true;+  componentWillUnmount() {+    window.removeEventListener('scroll', getClickPosition);

手抖了 写错了 click 写成 scroll 了

ztplz

comment created time in 7 days

pull request commentant-design/ant-design

Fix Modal's open animation

https://github.com/ant-design/ant-design/blob/master/components/modal/Modal.tsx#L166 这个问题的原因是点击事件是在didmount里注册的 所以第一次点击的时候 mousePosition是null的 所以我把它移出来了

ztplz

comment created time in 8 days

PR opened ant-design/ant-design

Fix Modal's open animation

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [x] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [ ] TypeScript definition update
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

<!--

  1. Describe the source of requirement, like related issue link. ref: https://github.com/ant-design/ant-design/issues/15795
  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

  • English Changelog: Fix Modal's open animation doesn't start at the click point when rendering for the first time
  • Chinese Changelog (optional):

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+17 -17

0 comment

1 changed file

pr created time in 8 days

create barnchztplz/ant-design

branch : modal

created branch time in 8 days

Pull request review commentant-design/ant-design

fix: Affix支持多元素children

 import * as React from 'react'; import { polyfill } from 'react-lifecycles-compat'; import classNames from 'classnames'; import omit from 'omit.js';+import Bind from 'lodash/bind';

为什么要用lodash的bind

bianlin

comment created time in 8 days

pull request commentant-design/ant-design

fix: form typescript definition

等他把repo弄出来再看啊 现在都不知道问题在哪里

zombieJ

comment created time in 9 days

Pull request review commentant-design/ant-design

docs: Add FAQ of Affix window scroll

 Please note that Affix should not cover other content on the page, especially wh   ... </Affix> ```++## FAQ++### Why Affix of Container not ping when window scroll?++We don't listen window scroll by performance consideration. You can add listener if you still want: <https://codesandbox.io/s/2xyj5zr85p>

by => for

zombieJ

comment created time in 9 days

issue commentant-design/ant-design

Collect current api standard

What's this for?

zombieJ

comment created time in 9 days

issue commentant-design/ant-design

Form.create() break defaultProps in typescript.

image Any repo ?

fwh1990

comment created time in 9 days

issue commentant-design/ant-design

AutoComplete - Lookup Patterns: Uncertain Category Demo BUG

I don't think this is a bug. @afc163

wangdaners

comment created time in 9 days

Pull request review commentant-design/ant-design

fix: PageHeader which tags should use ReactNode

 export interface PageHeaderProps {   subTitle?: React.ReactNode;   style?: React.CSSProperties;   breadcrumb?: BreadcrumbProps;-  tags?: Tag[];+  tags?: React.ReactNode;

要不要更严格一点 你这样 你写个 string number 什么结点它都是接受的 React.ReactElement<TagProps>会不会更好一点 限制使用Tag组件

zombieJ

comment created time in 9 days

issue commentant-design/ant-design

OnPressEnter, OnKeyPress for InputNumber and Autocomplete

image Seems your demo broken.

genc6541

comment created time in 9 days

issue commentant-design/ant-design

PageHeader tags property throw errors in typescript

As your codeandbox demo doesn't reproduce the problem, can you build a mini repo?

wenchao24

comment created time in 9 days

pull request commentant-design/ant-design

fix: Should Pagination of List default work

这个问题好像是我上个月遇到的问题 你把它弄成受控就行了

zombieJ

comment created time in 9 days

Pull request review commentant-design/ant-design

docs: Add responsive polyfill of Grid FAQ

 If the Ant Design grid layout component does not meet your needs, you can use th | xxl | `≥1600px`, could be a `span` value or an object containing above props | number\|object | - |  The breakpoints of responsive grid follow [BootStrap 4 media queries rules](https://getbootstrap.com/docs/4.0/layout/overview/#responsive-breakpoints)(not including `occasionally part`).++## FAQ++### How to support IE9 when using responsive?++You can use [matchMedia polyfill](https://github.com/paulirish/matchMedia.js/) to handle this.

这个属性好像 ts3.1后才支持的 要不要加 好几个issue有这个问题

zombieJ

comment created time in 10 days

fork ztplz/tokio

A runtime for writing reliable, asynchronous, and slim applications with the Rust programming language.

https://tokio.rs

fork in 10 days

startedtokio-rs/tokio

started time in 10 days

fork ztplz/javascript-algorithms

📝 Algorithms and data structures implemented in JavaScript with explanations and links to further readings

fork in 14 days

push eventztplz/ant-design

ztplz

commit sha 351cf5960c045ea6cc9c854126d259f43f3430a8

Update

view details

push time in 15 days

issue commentant-design/ant-design

Radio and checkboxes components doesn't print correctly in Firefox using window.print() method

https://github.com/gregnb/react-to-print/issues/93

ibanjb

comment created time in 15 days

pull request commentant-design/ant-design

Add static tags

@afc163 默认移除点击效果 那用户要点击效果怎么办?

ztplz

comment created time in 16 days

push eventztplz/ant-design

afc163

commit sha 89351babc2be94121c3d52390da133eb1915fea8

fix(Progress): :bug: fix progress success UI when status is undefined close #15950

view details

afc163

commit sha 463ac0eccb17d1942ea89304ef0caeb290fa3d7a

:lipstick: chore progress demo

view details

afc163

commit sha fbcc884b5b9eed0608a94c388587f89a00f91530

🐛 fix progress success UI when status is invalid

view details

afc163

commit sha ace93f1b427343ca47f4dbc4aba9337da0cd9ed8

:art: refactor some code

view details

偏右

commit sha 6bd76140a411b975412e704dffde6d56a58c905c

Merge pull request #15951 from ant-design/fix-progress-status fix(Progress): 🐛 fix progress success UI when status is undefined

view details

zombieJ

commit sha bef491ecc95f5931fcb6e3fab5040d8d645e56ad

fix: Menu defaultOpenKeys not work as expect (#15970) * Remove animation on first render * update test cas

view details

zombieJ

commit sha d1e58d058f7345db5feeeabcae4c1a2bbc33f266

update wave style (#15978)

view details

ztplz

commit sha 0183bbe4fba2f7283df564a65f6c6783dc2fe43b

Remove Wave on Tag

view details

push time in 16 days

push eventztplz/ant-design

zombiej

commit sha a87cfc2d927d4253b2f1b064f27f4cb07c289594

use babel ast tree

view details

zombiej

commit sha ee14f8e5d5825c0c9ecd25ebbc53e6cdc36159d4

add skip test

view details

afc163

commit sha 427543009451758875f2060ceeaf84dfdfc51251

:bug: Keep same content color of List like previous version close #15296

view details

afc163

commit sha 56570aa539cd5e6739524c114e837c6f1181d2ba

:lipstick: Add `@pagination-item-bg-active` close #14739

view details

Dan Minshew

commit sha 9197db244541ba6081be63191bc2a5b67f83739a

add 'code' to list of Typography props

view details

偏右

commit sha 038001b642c975cc68f47be0f88912dc7076632f

Merge pull request #15302 from ant-design/add-active-item-variable Add `@pagination-item-bg-active`

view details

偏右

commit sha 369a3cdd605917695d686e033455090cf8e1bea6

Merge pull request #15308 from newswim/patch-1 Add 'code' to list of Typography props

view details

偏右

commit sha c4473e3389d2ca6bb7d4e711ca67e978db5d0fcc

Merge pull request #15301 from ant-design/fix-list-content-color Keep same content color of List like previous version

view details

zombiej

commit sha 05564e00ff647981eb14cf9130f5a8f83073eb08

add style dep lint ignore

view details

zombiej

commit sha d17a67175de50bfe22f804b9a8298f7d7f9814b3

add pattern match

view details

tangjinzhou

commit sha 0cea934cacab14d9d7541617002af42a6ae95d31

add ecosystem menu

view details

zombiej

commit sha 96a95e65d36e8ab4c2a4c94f5ca0104240514877

update deps lint

view details

ycjcl868

commit sha f607872e51798c6b8ebb12834526c9fb7f761d97

:lipstick: scroll smooth

view details

偏右

commit sha 9f4546897bdb5be3fc9896f89f3ace01dede983c

Merge pull request #15317 from ant-design/tweak-site-scroll-style tweak site body scroll smooth

view details

afc163

commit sha 0590c056c1ec549b9325d802096ac7d8ce060da5

:bug: Reserve ant-typography className

view details

afc163

commit sha a8ad9ecce55a210118876459088cf19178c44a25

:bug: Fix Typography editable inconsist style close #15249

view details

afc163

commit sha f694a1bbb801f11b37c0c6537547452788db22c0

:zap: Opatimize badge code

view details

afc163

commit sha d9ca0d838186af07e6983e83010059fde7573638

:zap: Optimize badge code again

view details

afc163

commit sha d5a1f58bbaf07f5e63e4a8e356df7c8a1d142161

:up: upgrade jsdom

view details

vthinkxie

commit sha 057d58ebce1dbccf8fc3bf5bdcfd58f16c51b273

style(module:input): add disabled selector style in ant input

view details

push time in 16 days

CommitCommentEvent

pull request commentant-design/ant-design

Change progress to Progress

小写吧 不影响什么

ztplz

comment created time in 17 days

delete branch ztplz/ant-design

delete branch : progress

delete time in 17 days

PR closed ant-design/ant-design

Reviewers
Change progress to Progress

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [ ] TypeScript definition update
  • [ ] Refactoring
  • [x] Code style optimization
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

<!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

  • English Changelog:
  • Chinese Changelog (optional):

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+4 -4

1 comment

3 changed files

ztplz

pr closed time in 17 days

pull request commentant-design/ant-design

Change progress to Progress

image 大写

ztplz

comment created time in 17 days

PR opened ant-design/ant-design

Change progress to Progress

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [ ] TypeScript definition update
  • [ ] Refactoring
  • [x] Code style optimization
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

<!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

  • English Changelog:
  • Chinese Changelog (optional):

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+4 -4

0 comment

3 changed files

pr created time in 17 days

create barnchztplz/ant-design

branch : progress

created branch time in 17 days

Pull request review commentant-design/ant-design

fix(Progress): 🐛 fix progress success UI when status is undefined

 export default class Progress extends React.Component<ProgressProps> {     default: PropTypes.oneOf(['default', 'small']),   }; +  getProgressStatus() {+    const { successPercent, percent = 0, status } = this.props;+    const percentNumber = parseInt(+      successPercent !== undefined ? successPercent.toString() : percent.toString(),+      10,+    );+    if (percentNumber >= 100 && status === undefined) {

要是用户输错了 还是会这样的 image https://github.com/ant-design/ant-design/blob/master/components/progress/progress.tsx#L13 再判断下是不是正确的status? ProgressStatuses.includes(status) , 不是要求的的status都返回success

afc163

comment created time in 17 days

Pull request review commentant-design/ant-design

fix: Menu arrow not display in old version of IE

           position: absolute;           width: 6px;           height: 1.5px;+          // background + background-image to makes before & after cross have same color.+          // Since `linear-gradient` not work on IE9, we should hack it.+          // ref: https://github.com/ant-design/ant-design/issues/15910           background: @menu-bg;+          background: ~'@{menu-item-color} \9';           background-image: linear-gradient(to right, @menu-item-color, @menu-item-color);+          background-image: ~'none \9';

这个单独为ie9的hack 经常把正常用户也给挂了

zombieJ

comment created time in 17 days

issue commentant-design/ant-design

所有页面的代码都打不开了

@zombieJ win10 试下

XianZhengquan

comment created time in 17 days

IssuesEvent

issue closedant-design/ant-design

所有页面的代码都打不开了

  • [ ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

https://ant.design/components/button-cn/

Steps to reproduce

打开官网,点击组件下面的展开代码按钮,不能展开代码

What is expected?

能够展开代码

What is actually happening?

不能展开代码

Environment Info
antd 3.16.2
React 16.8.4
System windows10
Browser chrome73

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->

closed time in 17 days

XianZhengquan

issue commentant-design/ant-design

所有页面的代码都打不开了

image 可以啊 Mac chrome

XianZhengquan

comment created time in 17 days

issue commentant-design/ant-design

Module not found: Error: Can't resolve 'antd/lib/list'

@zhaijiamei Could you provide a mini git repo? It's so hard to look into without reproduce.

zhaiqiang1987

comment created time in 18 days

PR closed ant-design/ant-design

Reviewers
chore: Remove deprecated prop

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [x] TypeScript definition update
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

<!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

  • English Changelog:
  • Chinese Changelog (optional):

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+0 -1

12 comments

1 changed file

ztplz

pr closed time in 18 days

pull request commentant-design/ant-design

chore: Remove deprecated prop

image 早就break change了 一个移了5个 我觉得当时可能遗漏了这个

ztplz

comment created time in 18 days

pull request commentant-design/ant-design

Remove deprecated prop

image

ztplz

comment created time in 18 days

pull request commentant-design/ant-design

Remove deprecated prop

https://github.com/react-component/table/blob/fe68e445e639f696495de3e569339c09e2d46254/src/Table.js#L88 rc-table 里有

ztplz

comment created time in 18 days

pull request commentant-design/ant-design

Remove deprecated prop

https://github.com/ant-design/ant-design/blob/d839135ad066151c9527bc90457f3a0147b8bd2a/CHANGELOG.zh-CN.md 2.x就已经移除了这个属性

ztplz

comment created time in 18 days

PR opened ant-design/ant-design

Remove deprecated prop

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [x] TypeScript definition update
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

<!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

  • English Changelog:
  • Chinese Changelog (optional):

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+0 -1

0 comment

1 changed file

pr created time in 18 days

create barnchztplz/ant-design

branch : table

created branch time in 18 days

issue commentant-design/ant-design

When set trigger: 'onBlur' in the options object of getFieldDecorator() the Input doesn't respond and antd doesn't collect the value on 'onBlur'

Do not use both trigger and validateTrigger. image If your form has serious performance issues, you can split the form or validate it during input blur.

rhap5ody

comment created time in 18 days

pull request commentant-design/ant-design

fix: Table align right not work on title

@zombieJ https://github.com/ant-design/ant-design/issues/15846#issuecomment-480466142

zombieJ

comment created time in 18 days

issue closedant-design/ant-design

expandRowByClick is getting ignored if onRow => onClick(...) present

  • [x] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. Add expandRowByClick prop to <Table /> component.
  2. Add onRow prop to <Table /> component, inside the onRow, add onClick event listener.
  3. If click on row, the expender won't get expend.
  4. Remove onRow prop.
  5. Click on row, the expender will get expend.

What is expected?

Expect when both expandRowByClick and onRow(with onClick inside) props present, click on anywhere on row will still expand the expander.

What is actually happening?

If both expandRowByClick and onRow(with onClick inside) props present, the expandRowByClick got ignored. Thus when you click anywhere on row, the expander won't expand.

Environment Info
antd 3.16.1
React React: 16.8.6
System MAC OS X: 10.14.3
Browser Google Chrome: 73.0.3683.86

The onClick listener is doing the logging stuff by calling some endPoint. expandRowByClick I assume is also using onRow prop (with onClick inside) internally.

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->

closed time in 18 days

Jiahao01121

issue commentant-design/ant-design

expandRowByClick is getting ignored if onRow => onClick(...) present

This is not a bug. If you set click on onRow, we will let you control the open of the row.

Jiahao01121

comment created time in 18 days

issue commentant-design/ant-design

Drawer jumping if css > body{ overflow-y: scroll; }

What confuse me is why you want to set overflow-y: scroll in body? Any situation?

crazyx13th

comment created time in 18 days

Pull request review commentant-design/ant-design

New component Descriptions

+// matchMedia polyfill for+// https://github.com/WickyNilliams/enquire.js/issues/82+export let enquire: any;++if (typeof window !== 'undefined') {+  const matchMediaPolyfill = (mediaQuery: string) => {+    return {+      media: mediaQuery,+      matches: false,+      addListener() {},+      removeListener() {},+    };+  };+  window.matchMedia = window.matchMedia || matchMediaPolyfill;+  enquire = require('enquire.js');+}++export type Breakpoint = 'xxl' | 'xl' | 'lg' | 'md' | 'sm' | 'xs';+export type BreakpointMap = Partial<Record<Breakpoint, string>>;++export const responsiveArray: Breakpoint[] = ['xxl', 'xl', 'lg', 'md', 'sm', 'xs'];++export const responsiveMap: BreakpointMap = {+  xs: '(max-width: 575px)',+  sm: '(min-width: 576px)',+  md: '(min-width: 768px)',+  lg: '(min-width: 992px)',+  xl: '(min-width: 1200px)',+  xxl: '(min-width: 1600px)',+};++type SubscribeFunc = (screens: BreakpointMap) => void;++const ResponsiveObserve = () => {

这里写成class不好吗 更OOP

class ResponsiveObserve implements ResponsiveObserveInterface { }
chenshuai2144

comment created time in 19 days

issue commentant-design/ant-design

InputNumber bug: 初始为禁用时值的状态错误

image 我的codesandboxzen怎么一直是这个

junhwong

comment created time in 19 days

issue commentant-design/ant-design

QQ browser and Android origin browser can't scroll on Drawer component.

I am afraid we can't help anything. Antd focuses on the desktop, some components are not very well supported on mobile devices.

ryanyu104

comment created time in 19 days

Pull request review commentant-design/ant-design

feat: Wrap List in `ul` for accessibility

 export default class Item extends React.Component<ListItemProps, any> {         ))}       </ul>     );+    const Tag = grid ? 'div' : 'li';     const itemChildren = (-      <div-        {...others}+      <Tag+        {...others as any} // `li` element don't have `onCopy` prop. Cast to any.

你 omit 掉onCopy 再自己加个 ClipboardEvent 属性

zombieJ

comment created time in 19 days

issue commentant-design/ant-design

Export Table as CSV

@LucasBSC Sorry, there are no examples at present as we don’t think it’s what Antd should do. It is beyond the scope of the Antd. Perhaps you can do it by the way that @zachguo said.

sureshhustle

comment created time in 19 days

Pull request review commentant-design/ant-design

feat: Wrap List in `ul` for accessibility

 export default class Item extends React.Component<ListItemProps, any> {         ))}       </ul>     );+    const Tag = grid ? 'div' : 'li';     const itemChildren = (-      <div-        {...others}+      <Tag+        {...others as any} // `li` element don't have `onCopy` prop. Cast to any.

用的时候直接React. ClipboardEventHandler就行了 总比any好啊

zombieJ

comment created time in 19 days

fork ztplz/v8

The official mirror of the V8 Git repository

https://chromium.googlesource.com/v8/v8.git

fork in 20 days

startedv8/v8

started time in 20 days

Pull request review commentant-design/ant-design

feat: Wrap List in `ul` for accessibility

 export default class Item extends React.Component<ListItemProps, any> {         ))}       </ul>     );+    const Tag = grid ? 'div' : 'li';     const itemChildren = (-      <div-        {...others}+      <Tag+        {...others as any} // `li` element don't have `onCopy` prop. Cast to any.

onCopy 是标准dom属性 怎么会没有呢? 被我们占用了?

zombieJ

comment created time in 20 days

Pull request review commentant-design/ant-design

New component Descriptions

+// matchMedia polyfill for+// https://github.com/WickyNilliams/enquire.js/issues/82+export let enquire: any;++if (typeof window !== 'undefined') {+  const matchMediaPolyfill = (mediaQuery: string) => {+    return {+      media: mediaQuery,+      matches: false,+      addListener() {},+      removeListener() {},+    };+  };+  window.matchMedia = window.matchMedia || matchMediaPolyfill;+  enquire = require('enquire.js');+}++export type Breakpoint = 'xxl' | 'xl' | 'lg' | 'md' | 'sm' | 'xs';+export type BreakpointMap = Partial<Record<Breakpoint, string>>;++export const responsiveArray: Breakpoint[] = ['xxl', 'xl', 'lg', 'md', 'sm', 'xs'];++export const responsiveMap: BreakpointMap = {+  xs: '(max-width: 575px)',+  sm: '(min-width: 576px)',+  md: '(min-width: 768px)',+  lg: '(min-width: 992px)',+  xl: '(min-width: 1200px)',+  xxl: '(min-width: 1600px)',+};++type SubscribeFunc = (screens: BreakpointMap) => void;++const ResponsiveObserve = () => {+  let subscribers: Array<{+    token: string;+    func: SubscribeFunc;+  }> = [];+  let subUid = -1;+  return {+    screens: {},+    dispatch(screens: BreakpointMap) {+      this.screens = screens;+      if (subscribers.length < 1) {+        return false;+      }++      //performance+      let len = subscribers ? subscribers.length : 0;++      while (len--) {+        subscribers[len].func(screens);+      }+      return true;+    },+    subscribe(func: SubscribeFunc) {+      if (subscribers.length === 0) {+        this.register();+      }+      const token = (++subUid).toString();+      subscribers.push({+        token: token,+        func: func,+      });+      func(this.screens);+      return token;+    },+    unsubscribe(token: string) {+      subscribers = subscribers.filter(item => item.token !== token);+      if (subscribers.length === 0) {+        this.unregister();+      }+    },+    unregister() {+      Object.keys(responsiveMap).map((screen: Breakpoint) =>+        enquire.unregister(responsiveMap[screen]),+      );+    },+    register() {+      Object.keys(responsiveMap).map((screen: Breakpoint) =>+        enquire.register(responsiveMap[screen], {+          match: () => {+            const screens = {+              ...this.screens,+              [screen]: true,+            };+            this.dispatch(screens);+          },+          unmatch: () => {+            const screens = {+              ...this.screens,+              [screen]: false,+            };+            this.dispatch(screens);+          },+          // Keep a empty destory to avoid triggering unmatch when unregister+          destroy() {},+        }),+      );+    },+  };+};++const responsiveObserve = ResponsiveObserve();

看起来有rx的感觉

chenshuai2144

comment created time in 20 days

pull request commentant-design/ant-design

fix: Refactor Menu related components life cycle methods

有必要用context吗 用props传不好吗

zombieJ

comment created time in 21 days

issue commentant-design/ant-design

Add a height attribute to progress component

https://codesandbox.io/s/m9qyq5qrny strokeWidth work for me.

megawac

comment created time in 21 days

pull request commentant-design/ant-design

fix: use mock function for DirectoryTree test

这不是一个问题吧 它node没装成功

zombieJ

comment created time in 21 days

issue commentant-design/ant-design

Menu render problems in 3.15 & 3.16

mode的判断都乱掉了 menu revert to 3.14.1 ?

afc163

comment created time in 21 days

issue commentant-design/ant-design

Collapsed Menu/MenuItem when selected does not consistently display the selected blue border on right

ref: https://github.com/ant-design/ant-design/issues/15801

kapso

comment created time in 21 days

issue commentant-design/ant-design

Tree test cases fail occasionally

https://github.com/facebook/jest/issues/3465

afc163

comment created time in 21 days

create barnchztplz/ant-design

branch : menu

created branch time in 22 days

delete branch ztplz/ant-design

delete branch : menu

delete time in 22 days

pull request commentant-design/ant-design

fix: badge should accept negative number

Untitled7

zombieJ

comment created time in 23 days

pull request commentant-design/ant-design

fix: badge should accept negative number

https://github.com/ant-design/ant-design/blob/master/components/badge/ScrollNumber.tsx#L106 改这里怎么样

isNaN(position) ? "-" : i % 10
zombieJ

comment created time in 23 days

Pull request review commentant-design/ant-design

fix: badge should accept negative number

 class ScrollNumber extends Component<ScrollNumberProps, ScrollNumberState> {    renderNumberElement(prefixCls: string) {     const { count } = this.state;-    if (count && Number(count) % 1 === 0) {+    const numVal = Number(count);+    if (count && numVal % 1 === 0 && numVal >= 0) {

那不是把负数当字符处理了吗 滚动动画没了

zombieJ

comment created time in 23 days

PullRequestEvent

pull request commentant-design/ant-design

Update dynamic-form-item.md

好像Icon确实没有disabled属性 我的锅

liaoyinglong

comment created time in 23 days

PR closed ant-design/ant-design

Update dynamic-form-item.md

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [x] Site / document update
  • [ ] Component style update
  • [ ] TypeScript definition update
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

in tsx file, people to copy that code will get error <!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

delete unnecessary props <!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

  • English Changelog: delete unnecessary props
  • Chinese Changelog (optional):

☑️ Self Check before Merge

  • [x] Doc is updated/provided or not needed
  • [x] TypeScript definition is updated/provided or not needed
  • [x] Demo is updated/provided or not needed
  • [x] Changelog is provided or not needed
+0 -1

3 comments

1 changed file

liaoyinglong

pr closed time in 23 days

pull request commentant-design/ant-design

Update dynamic-form-item.md

demo本来就是用js写的 你自己原样copy过去当然容易出错 自己改下ts

liaoyinglong

comment created time in 23 days

pull request commentreact-component/calendar

Close calendar picker on blur

Sorry for the delay, I will take a look at it.

onlyann

comment created time in 23 days

issue closedant-design/ant-design

Slider onAfterChange is not triggered, when moving slider with arrows

  • [ ] I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Move slider with mouse to verify that onAfterChange is triggered Move slider with arrow keys to verify that onAfterChange is not triggered

What is expected?

onAfterChange should be triggered not only on mouseup, but also on arrow change (keyup)

What is actually happening?

onAfterChange is only triggered on mouseup

Environment Info
antd 3.15.2
React React
System os x
Browser Chrome

Maybe is is possible to trigger change on blur somehow? This possibly could be a solution

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->

closed time in 23 days

tylik1

pull request commentreact-component/slider

Support onAfterChange when key pressed

Done!

ztplz

comment created time in 24 days

push eventztplz/slider

ztplz

commit sha 40f652940ef9ad901cca7a0b4656c3e0faa8c246

Update

view details

push time in 24 days

issue commentant-design/ant-design

Can not find antd/dist/antd.less

Could you create a mini repo?

HsuTing

comment created time in 24 days

issue commentant-design/ant-design

RangePicker does not support typing in start/end dates when in form

@SaladFork I downgraded the react to 16.3.0 and it's work for me. See this demo. But I am not sure if it is related to react,

SaladFork

comment created time in 24 days

pull request commentdenoland/deno

[WIP] Web API: EventTarget

I will consider taking over if I have enough time.

acconrad

comment created time in 24 days

pull request commentdenoland/deno

Upgrade to TypeScript 2.4

Hmm, 2.4 => 3.4.

kitsonk

comment created time in 24 days

more