profile
viewpoint
ztplz GuangZhou, China https://leetcode.com/ztplz/ 技术再好又有什么屁用

pull request commentmicrosoft/TypeScript

Assertions in control flow analysis

Great work~

ahejlsberg

comment created time in a day

push eventztplz/deno

Kevin (Kun) "Kassimo" Qian

commit sha 52c13fb3ed94e41d90bbe08d1bc299ca90505755

Enforce env permission on homeDir() and execPath (#2714)

view details

Bartek Iwańczuk

commit sha aaa7a3eac4df0de9a93dc8fc4717d38212a3de5b

use BTreeMap for ResourceTable (#2721)

view details

Kevin (Kun) "Kassimo" Qian

commit sha ddee2dff14772ade16e282ad18eda6f5054ce94e

Provide option to delete Deno namespace in worker (#2717)

view details

Ryan Dahl

commit sha a517513182221aa351528cf15d28c449b49fea13

Remove Deno.build.args feature (#2728) This is a minor feature which complicates the build signifigantly. Removing to ease refactoring the build system: https://github.com/denoland/deno/issues/2608

view details

Ryan Dahl

commit sha 046cccfe1768837fcd5b4c1fd7d52fb2d98c0b11

Remove dispatch optimization (#2732) Deno.core.dispatch() used to push the "control" buf onto the shared array buffer before calling into V8, with the idea that it was one less argument to parse. Turns out there is no more overhead passing the control ArrayBuffer directly over. Furthermore this optimization was making the refactors outlined in #2730 more complex. Therefore it is being removed.

view details

Nayeem Rahman

commit sha 11c850af423f07769f054c494a76cbd9efb8806c

Enforce permissions on kill(), homeDir() and execPath (#2723)

view details

Kevin (Kun) "Kassimo" Qian

commit sha ccee2f01ba2f6304720ab17e99dee17bf6687bd8

Implement Blob url support for worker (#2729)

view details

Kevin (Kun) "Kassimo" Qian

commit sha 4519f9a50db8852c5b70ff47481f0fc9d0fbe2f2

Make Deno.execPath a function (#2743) And throws without allow-env

view details

Kevin (Kun) "Kassimo" Qian

commit sha 77d0d1e45ccfd33a8a98e2f5fa4ba618759b5dd3

Fix small execPath issues (#2744)

view details

Ryan Dahl

commit sha 43d099c0275878f6c6358eb0e9a0094d076d7c29

Fix incremental 'cargo build' (#2740) Tip: RUSTC_WRAPPER should be unset for incremental builds to work.

view details

Bartek Iwańczuk

commit sha 5350abbc7ffdba6d17166fa00ad89e86979a43f7

manual: Edit note about V8 profiling (#2742)

view details

Ryan Dahl

commit sha e438ac2c74c823882dc9c9ecde2a9e9ed7bcfb4b

Add op_id throughout op API (#2734) Removes the magic number hack to switch between flatbuffers and the minimal dispatcher. Adds machinery to pass the op_id through the shared_queue.

view details

Daniel Buckmaster

commit sha 520bdb6c31dd08b6f4e52de5116fd23d6d57fdda

Fix repl crash when deno dir doesn't exist (#2727)

view details

andy finch

commit sha 56a82e72d9867a9b5f8a10bc8e4b81b86cd815c9

Resolve worker specifiers relative to main module of host. (#2751)

view details

Bert Belder

commit sha 6fbf2e96243e6b79c1fb03c17b376b028e442694

Dynamic import (#2516)

view details

Bert Belder

commit sha 83d5362f1d7d8589b862de57912135067a8278c7

v0.14.0

view details

Kevin (Kun) "Kassimo" Qian

commit sha 286ee1d8b68b54d39e698f3b78e3ce9e257fa674

Fix dynamic import base path problem for REPL and eval (#2757)

view details

Bartek Iwańczuk

commit sha 54982e948e882fbf413e06319f711d85b232026b

fix: cache paths on Windows are broken (#2760)

view details

Bartek Iwańczuk

commit sha 9bd473d8ac9228e483bd26028dbe7ba88e971c08

feat: print cache location when no arg in deno info (#2752)

view details

Bert Belder

commit sha c3afa557515c64610b23ee460f8c6251de421f1a

Propagate Url::to_file_path() errors instead of panicking (#2771) * Propagate Url::to_file_path() errors instead of panicking

view details

push time in 4 days

Pull request review commentant-design/ant-design

chore: 💄 eslint for all files!

 const responsiveObserve = {     }     const token = (++subUid).toString();     subscribers.push({-      token: token,-      func: func,+      token,

直接 token: String(++subUid) 感觉更简洁, 上面那个token参数多余的

afc163

comment created time in 11 days

push eventztplz/collapse

ztplz

commit sha deaecc9dc51913448727c4953ea6e8fee50348b1

add number key tests

view details

push time in 12 days

Pull request review commentant-design/ant-design

[WIP] feat: Tree support virtual scroll

 export default class Tree extends React.Component<TreeProps, any> {     blockNode: false,   }; -  tree: any;+  public tree: any;

这是要暴露 ref? 可以不any的吧

zombieJ

comment created time in 14 days

Pull request review commentant-design/ant-design

[WIP] feat: Tree support virtual scroll

 function getIcon(props: AntdTreeNodeAttribute): React.ReactNode {   return <Icon type={expanded ? 'folder-open' : 'folder'} />; } +function getTreeData({ treeData, children }: DirectoryTreeProps) {+  return treeData ? treeData : convertTreeToData(children);

你直接短路不就行了吗 return treeData || convertTreeToData(children);

zombieJ

comment created time in 14 days

pull request commentreact-component/collapse

Supress incorrect warning

Done. react会把用户的number类型的key都变成字符串,但是我们设置activekey的逻辑是比的是用户的key和react元素的key 我把用户的key再内部也变成字符串了

ztplz

comment created time in 15 days

push eventztplz/collapse

zt

commit sha c08ef71cf1e7ef8829547fc79f7a6dbacaf82190

Support number key

view details

push time in 15 days

pull request commentreact-component/collapse

Supress incorrect warning

那这是另外一个bug

ztplz

comment created time in 17 days

pull request commentreact-component/collapse

Supress incorrect warning

@afc163 @zombieJ

ztplz

comment created time in 17 days

PR opened react-component/collapse

Supress incorrect warning

https://github.com/ant-design/ant-design/issues/18166

+10 -2

0 comment

1 changed file

pr created time in 17 days

create barnchztplz/collapse

branch : warning

created branch time in 17 days

push eventztplz/collapse

ztplz

commit sha 363916e664df4bd43a0ae651d282bb06544334fd

Support React Fragment

view details

ztplz

commit sha 69572342239e81ea8699e484a199773f8622d6e4

Add comment

view details

afc163

commit sha 4a0855ca93fc86aca25ef517e3cd2a0c7aa1fed3

1.10.2

view details

Bertho

commit sha 6d623fc4c080f348eb0e9381a842584899a8bf58

reusable functions

view details

dependabot[bot]

commit sha b97ed0d850657d7dc092181ac14e31a2870073c5

Update coveralls requirement from ^2.13.1 to ^3.0.2 Updates the requirements on [coveralls](https://github.com/nickmerwin/node-coveralls) to permit the latest version. - [Release notes](https://github.com/nickmerwin/node-coveralls/releases) - [Commits](https://github.com/nickmerwin/node-coveralls/commits/3.0.2) Signed-off-by: dependabot[bot] <support@dependabot.com>

view details

郭延豪(708674)

commit sha c2f5d741bf8304633f35838b08263b13de4f0569

fix inherited bug

view details

Kévin Berthommier

commit sha c243e042cdc2296dc648b04618fe313c646a9d7c

Optimization (#106) * reusable functions * do not bind parameter in render * use shallowEqual instead of PureComponent * fix propTypes * arrow functions instead of binding

view details

afc163

commit sha 5be013a844313f8dd36bf71b88ae1a6491248ee0

:tada: 1.10.3

view details

Harlan

commit sha b24959389a20d0ea3f801ebcb29e63dc1420e3a4

add prop `extra` (#103)

view details

afc163

commit sha 5320a0b39a399345cbbd40b2b7d3bb4fc9415b26

1.11.0

view details

afc163

commit sha 14845bb040d84959f5126c344a8ae1314ec9b5ce

Merge branch 'master' of github.com:react-component/collapse * 'master' of github.com:react-component/collapse: add prop `extra` (#103)

view details

afc163

commit sha 1fb598d04b88243f5098229a315a5d225b9fc85f

1.11.1

view details

zombiej

commit sha c4320cdf8200a947a3a9c452e90a9a6d23c063fc

fix render logic of icon fix ant-design/ant-design#16757

view details

zombiej

commit sha 60b958b58e5302596df463a2880dfd2d31d18a10

bump 1.11.2

view details

zombiej

commit sha c1c956bb3e59b0cdafb87a4c03825fef55975c36

collapse icon should support null

view details

push time in 17 days

issue commentant-design/ant-design

webpack4.0production模式下打包 antd组件TreeSelect报错

贴配置没多大用 最好有复现的git repo

HoroXu

comment created time in 17 days

pull request commentant-design/ant-design

fix: fix react warning React does not recognize the `noStyle` prop on…

https://github.com/ant-design/ant-design/commit/9630410b4e955316f890521ecb80f3a44d21a53e 已经修复了

fatelei

comment created time in 17 days

Pull request review commentant-design/ant-design

fix: fix react warning React does not recognize the `noStyle` prop on…

 export default class Table<T> extends React.Component<TableProps<T>, TableState<                 onExpand(record, event);               }}               aria-label={expanded ? locale.collapse : locale.expand}-              noStyle+              noStyle={true}

你这么改还是会错的 table里是把属性都传下去了 但是dom没有nostyle这个属性

fatelei

comment created time in 17 days

Pull request review commentant-design/ant-design

Drawer get container

+---+order: 2+title:+  zh-CN: 自定义挂载+  en-US: Custom Container+---++## zh-CN++自定义挂载,点击触发按钮抽屉从相应的位置滑出,点击遮罩区关闭++## en-US++Custom Container.++```jsx+import { Drawer, Button, Radio } from 'antd';++class App extends React.Component {+  state = { visible: false, value: '.main-wrapper', };

一行会有lint错误吗 用户都是直接copy的

jljsj33

comment created time in 17 days

issue commentant-design/ant-design

Collapse doesn't work for prop `activeKey` of type number and shows a warning of invalid prop in react hooks

https://github.com/react-component/collapse/blob/master/src/Collapse.jsx#L142 It is actually supported, it is wrong here.

kushalmahajan

comment created time in 17 days

issue commentant-design/ant-design

menu中含有fragment会失去作用

以前有提过 被关了 有时间重构吧 还有个item固定的问题

Fled8617

comment created time in 20 days

Pull request review commentant-design/ant-design

fix: better typescript code, use svg components

+import * as React from 'react';++export default () => (+  <svg width="184" height="152" viewBox="0 0 184 152" xmlns="http://www.w3.org/2000/svg">

9102了 memo

chenshuai2144

comment created time in 21 days

push eventztplz/deno

迷渡

commit sha 8c770c5a90d4c0c48256f17371a5de6604270031

remove `isTrusted`'s setter (#2006)

view details

Ryan Dahl

commit sha d0b6152f11800b0baac1ae68d2eef7bfcea13cb5

Fix error when JS is executed with --recompile (#2007) test case from @afinch7

view details

Bartek Iwańczuk

commit sha 597ee38ef28d040cbf4d629cf3d2bd3e89a70a11

Rewrite readFile and writeFile (#2000) Using open/read/write

view details

ztplz

commit sha 8ac36d8db421864604a835c50a68411b3f69d62a

Fix typo (#2010)

view details

迷渡

commit sha 1fec34b4632521068c31815c1d9f92286b6d0297

Check `CustomEvent` constructor params (#2011)

view details

Bert Belder

commit sha da1b98b690e39ce4becf314910d046b9850f650f

Clippy fixes (#2009)

view details

Ryan Dahl

commit sha 51abcd614731bdb47a79f9f0c0fed81ddb7a474a

Make sharedQueue overflow warning quieter (#2008)

view details

Ryan Dahl

commit sha c25e262b04c15d4de7107cc131de467882e7dcec

Merge the --recompile and --reload flags (#2003)

view details

Bartek Iwańczuk

commit sha bdc455dd25b4c0d14fd30bc32c07206b2b93a007

Add Process.stderrOutput() (#1828)

view details

Ryan Dahl

commit sha b965c7ab367a417fb7bdde2eaf38312179e5c183

v0.3.5

view details

Bert Belder

commit sha 3d6c033369a75b7eea7b4fa6be36696b613b1606

third_party: upgrade rust crates

view details

迷渡

commit sha 51c6f33f64c7e805b789aec9a28f62d09b91a3a4

Avoid search prototype chain (#2019)

view details

迷渡

commit sha ad3cbc50fb255f287a890a28f158f6842d335538

check `EventTarget` params (#2018)

view details

Ryan Dahl

commit sha c9614d86c190b98bd8f0df9e17272387c3bad1d5

Move //libdeno to //core/libdeno (#2015) Fixes some sed errors introduced in c43cfe. Unfortunately moving libdeno required splitting build.rs into two parts, one for cli and one for core. I've also removed the arm64 build - it's complicating things at this re-org and we're not even testing it. I need to swing back to it and get tools/test.py running for it.

view details

Ryan Dahl

commit sha 6744bb8d750b9ab11d2ec9448334732b98feb58a

Call ninja directly from build.rs (#2020)

view details

Ryan Dahl

commit sha e9910d8ae510fcef54ae2f0a83199daa81c15df1

Rename crate deno_core to deno (#2022)

view details

Ryan Dahl

commit sha 3ba4c3c2b08f9827af67b208f276e95082b625bd

Remove deno_core_http_bench from core/Cargo.toml (#2023) So we don't have to have an optional tokio dependency. We build deno_core_http_bench using GN anyway.

view details

Bert Belder

commit sha 97265895baaf7e90180f10f7ef741e9bbf1dcfd0

Publish rust crate on crates.io (#2024)

view details

Bert Belder

commit sha ff1c80d6d896a3c1cb45d767a6c667ce99eb000b

third_party: add rust crate 'clap'

view details

迷渡

commit sha c855d0edd2ef5098b806ac6368eb7b0a85d0d0c9

Update `deno -h` output in manual (#2030)

view details

push time in 22 days

push eventztplz/ant-design

偏右

commit sha 2950219864a45b38a36a0e465ba47eb178638e60

Merge pull request #15923 from ant-design/fix-label-switch fix(Form): switch should be trigger by form label

view details

zombieJ

commit sha 9190245b521c5c68eaff2358361478b4d5b342ef

update ts def (#15938)

view details

zombieJ

commit sha 97d6f79ce465f93ae171d90b44983b250cc272b1

fix: Menu arrow not display in old version of IE (#15932)

view details

zombieJ

commit sha fa47d9ca60ee4e7cf13253415e664e893b1ad5a7

feat: TreeSelect support `showSearch` in multiple mode (#15933) * update rc-tree-select * typo * update desc & snapshot * update desc & snapshot * check default showSearch

view details

zombieJ

commit sha ff23ce72e67fb91e393916e34216589785622b03

Revert "feat: TreeSelect support `showSearch` in multiple mode (#15933)" (#15946) This reverts commit fa47d9ca60ee4e7cf13253415e664e893b1ad5a7.

view details

zombieJ

commit sha 369cb69e7faab2857c138afb40b064c198943d83

feat: TreeSelect support `showSearch` in multiple mode (#15933) * update rc-tree-select * typo * update desc & snapshot * update desc & snapshot * check default showSearch

view details

zombiej

commit sha f7df66b97c67bed888ebc5466553ea06d9add0a0

fix tooltip not works

view details

zombiej

commit sha 79028827760fb533303074a7b884c22178b956d8

Merge remote-tracking branch 'origin/master' into merge-master

view details

偏右

commit sha b3093dea8876323f284ea8eb7be041420db32d0b

Merge pull request #15949 from ant-design/merge-master chore: Feature merge master

view details

Juan Carlos Lloret H

commit sha 1e6405eae9d6099a646463d018d3bbdbad103d19

Added missing showLessItems prop to pagination component

view details

afc163

commit sha 89351babc2be94121c3d52390da133eb1915fea8

fix(Progress): :bug: fix progress success UI when status is undefined close #15950

view details

afc163

commit sha 463ac0eccb17d1942ea89304ef0caeb290fa3d7a

:lipstick: chore progress demo

view details

偏右

commit sha 25eec9ab9f2da95a7d4260945d5e64286bc4e2b1

Merge pull request #15952 from JuanCarlosllh/pagination-showLessItems-prop fix: Added missing showLessItems from prop type from rc-pagination to PaginationProps

view details

zombiej

commit sha 9f3c3570533099c69a34a199e8c344a1b7ff5644

add test case

view details

zombiej

commit sha 58768b90f6eec76f576f4fe774b832057c80137a

Merge branch 'feature' into tree-select-showSearch

view details

afc163

commit sha fbcc884b5b9eed0608a94c388587f89a00f91530

🐛 fix progress success UI when status is invalid

view details

afc163

commit sha ace93f1b427343ca47f4dbc4aba9337da0cd9ed8

:art: refactor some code

view details

偏右

commit sha a26397843c97b17d16a33e91de0b58898ff980fe

Merge pull request #15948 from ant-design/menu-tooltips fix: Tooltips show work when Menu collapsed

view details

陈帅

commit sha 30a0011a1b720267b39b66729a4d5659a134e139

Merge pull request #15947 from ant-design/tree-select-showSearch feat: TreeSelect support `showSearch` in multiple mode (#15933)

view details

信鑫-King

commit sha 4c3a351bc7bff6489d23cc4602aadaa5a967d575

tweak: export Skeleton avatar name (#15965)

view details

push time in 25 days

issue commentant-design/ant-design

`current` for `Steps` should be optional in documentation

I noticed this, and some inconsistent descriptions of apis have caused confusion for users. But this may be the work of 4.0. In fact, not only the documentation of this component needs to be clear.

opiation

comment created time in 25 days

issue commentant-design/ant-design

`current` for `Steps` should be optional in documentation

First of all, sorry to make you confused. Most of API of antd are optional, so we have no special indication. The default value also has this meaning, if you don't set it, use the default value. @afc163 Maybe we can add the required flag to the antd@4.0 document to make the document clearer.

opiation

comment created time in a month

issue commentant-design/ant-design

💥 Ant Design 4.0 is in progress!

Keep it as an English channel, thanks~

zombieJ

comment created time in a month

Pull request review commentant-design/ant-design

[Types] [Form] improve def setFieldsValue

 export type WrappedFormUtils<V = any> = {   /** 获取一个输入控件的值 */   getFieldValue(fieldName: string): any;   /** 设置一组输入控件的值 */-  setFieldsValue(obj: Object, callback?: Function): void;+  setFieldsValue(obj: Partial<V> | any, callback?: Function): void;

@pierre-H
image any here doesn't seem to be necessary because it has a defaulted any. image

pierre-H

comment created time in a month

Pull request review commentant-design/ant-design

feat(Anchor): add targetOffset prop

 export interface AnchorProps {     e: React.MouseEvent<HTMLElement>,     link: { title: React.ReactNode; href: string },   ) => void;+  /** Scroll to target offset value, if none, it's offsetTop prop value or 0. */

其实不止加这些 @afc163 @zombieJ 现在的提示很不规范,也很简陋 还有这种中文 image 4.0 应该提升下ide的体验 image

shaodahong

comment created time in a month

Pull request review commentant-design/ant-design

[Types] [Form] improve def setFieldsValue

 export type WrappedFormUtils<V = any> = {   /** 获取一个输入控件的值 */   getFieldValue(fieldName: string): any;   /** 设置一组输入控件的值 */-  setFieldsValue(obj: Object, callback?: Function): void;+  setFieldsValue(obj: Partial<V> | any, callback?: Function): void;

A little strange, just for auto completion?

pierre-H

comment created time in a month

issue commentant-design/ant-design

Typescript error

@Jarvvski My node version is 11.9. image

HsuTing

comment created time in a month

issue commentant-design/ant-design

Input组件无法直接改变内部input标签的样式

flex好啊 我flex一把梭

andyyxw

comment created time in a month

Pull request review commentant-design/ant-design

feat(Anchor): add getCurrentAnchor prop

 export interface AnchorProps {   affix?: boolean;   showInkInFixed?: boolean;   getContainer?: () => AnchorContainer;+  getCurrentAnchor?: () => string;

加个jsdoc

shaodahong

comment created time in a month

issue commentant-design/ant-design

💥 Ant Design 4.0 is in progress!

@rafaelodassi There is no confirmed date yet, but probably in Q4.

zombieJ

comment created time in a month

issue commentant-design/ant-design

Typescript error

image @JackieLs I did what you said but did not produce an error.

HsuTing

comment created time in a month

issue commentant-design/ant-design

antd 3.20.3 版本 Cascader 组件对option选项的children的判断异常,以前支持children为null的现在只会判断undfined,导致组件异常

https://github.com/ant-design/ant-design/commit/4a1d68c87f3cc034a2edcea85ae4468ce5764a36#diff-3141ae7cf791cd0b5edcad2c51dd6ddd 你可以看我这个pr 原来用null不会报错是因为 null会短路 然后给 options赋予一个空数组 我改成参数默认赋值后 null是不会被赋予空数组的 所以它报错了 但是我考虑过 如果有打算支持null的话 image这里应该是 CascaderOptionType[] | null 还有文档里也没写支持null 所以我改了

ooxx87

comment created time in a month

issue commentant-design/ant-design

antd 3.20.3 版本 Cascader 组件对option选项的children的判断异常,以前支持children为null的现在只会判断undfined,导致组件异常

这就很尴尬了 原来的代码逻辑是支持null的 但是。。。 类型还有文档里没有说支持null 然后你们又都传了null进去 它以前是不会报错的

ooxx87

comment created time in a month

issue commentant-design/ant-design

antd 3.20.3 版本 Cascader 组件对option选项的children的判断异常,以前支持children为null的现在只会判断undfined,导致组件异常

@wyaihy 因为为null的时候 它不会设置默认值 image 因为文档上没允许null 所以改了那个

ooxx87

comment created time in a month

issue commentant-design/ant-design

antd 3.20.3 版本 Cascader 组件 当option选项的children字段为null时,组件异常

https://github.com/ant-design/ant-design/commit/a614b54c286d34ec2e74b3450195705157b6b3ed#commitcomment-34335862 @zombieJ 或者加个null类型?

wyaihy

comment created time in a month

issue commentant-design/ant-design

Can't call setState on a component that is not yet mounted

@marciopamplona Totally agree, this looks like he is not using react correctly, but a repo will be more helpful. @alanhg Any repo for debugging?

alanhg

comment created time in a month

CommitCommentEvent

issue commentant-design/ant-design

Namespace 'React' has no exported member 'AriaAttributes'

@smizel If you still running into it, please create a repo for your question.

TonyRyze

comment created time in a month

Pull request review commentant-design/ant-design

feat(Empty): description prop support false value to remove description node

 const OriginEmpty: React.SFC<EmptyProps> = (props: EmptyProps) => (         <LocaleReceiver componentName="Empty">           {(locale: TransferLocale) => {             const prefixCls = getPrefixCls('empty', customizePrefixCls);-            const des = description || locale.description;+            const des = typeof description === 'boolean' ? description : (description || locale.description);

问题是 如果是false 它应该显示默认的 还是什么都不显示。。。 image 这是react默认的behavior

billfeller

comment created time in a month

Pull request review commentant-design/ant-design

feat(Empty): description prop support false value to remove description node

 export interface EmptyProps {    */   imageStyle?: React.CSSProperties;   image?: React.ReactNode;-  description?: React.ReactNode;+  description?: React.ReactNode | boolean;

boolean其实也算节点的

billfeller

comment created time in a month

PR opened ant-design/ant-design

Correct renderTabBar type

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [x] TypeScript definition update
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Test Case
  • [ ] Branch merge
  • [ ] Other (about what?)

🔗 Related issue link

https://github.com/ant-design/ant-design/issues/17544 <!--

  1. Describe the source of requirement, like related issue link. -->

💡 Background and solution

<!--

  1. Describe the problem and the scenario.
  2. GIF or snapshot should be provided if includes UI/interactive modification.
  3. How to fix the problem, and list final API implementation and usage sample if that is an new feature. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+6 -3

0 comment

3 changed files

pr created time in a month

create barnchztplz/ant-design

branch : tabbar

created branch time in a month

delete branch ztplz/ant-design

delete branch : tabbar

delete time in a month

pull request commentant-design/ant-design

Correct rendertabbar type

我还以为合了 我再开一个

ztplz

comment created time in a month

startedacdlite/react-fiber-architecture

started time in a month

issue commentant-design/ant-design

Input组件作为登录输入框会暴露用户输入的信息

@dyyliao123 https://github.com/facebook/react/milestone/40 millstone in react 17.

Mathround

comment created time in a month

pull request commentant-design/ant-design

update modal and drawer protal

16那么多好用的都不能用

jljsj33

comment created time in a month

startedsherlock-project/sherlock

started time in a month

pull request commentant-design/ant-design

fix: Table miss border-raidus in Firefox

https://www.endyourif.com/css3s-border-radius-property-and-border-collapsecollapse-dont-mix/ 这两个东西不能混合

zombieJ

comment created time in a month

push eventztplz/ant-design

dependabot-preview[bot]

commit sha 9fb6e78279b3454f51048d6d35643afc51157c33

Update @babel/plugin-transform-typescript requirement Updates the requirements on [@babel/plugin-transform-typescript](https://github.com/babel/babel) to permit the latest version. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](https://github.com/babel/babel/compare/v7.4.5...v7.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Sanghyeon Lee

commit sha 559682df23d398ff8c8c0ce7c4e3af825ee15d9c

docs: fix tag name in the API example

view details

Sanghyeon Lee

commit sha 430117288dc4c9a13dc94c238964276009d490c6

docs: fix tag name in the API example

view details

偏右

commit sha 3ed4128fa71f62a804f0e5fe3dc8f42a708ade1e

Merge pull request #17589 from yongdamsh/patch-1 Update the markup example in API section of menu.md

view details

偏右

commit sha a46eb8ea3068424135eddf3e927ecd062530bd15

Update package.json

view details

pengtikui

commit sha e17e3253a0b5f536e64a8d635e13d6db4f4be693

docs: fix typo

view details

riho

commit sha 001384a65bd2cfa3716b8130a8dee78d861113b6

fix: button loading style(#17569)

view details

偏右

commit sha ade577a9f9926bb15a0497665d948379ed3e096b

Merge pull request #17596 from LilyWakana/issue17569 fix: button loading style(#17569)

view details

偏右

commit sha 44aa1bd15fa390ad4d2c28c8a57de8851e892769

Merge pull request #17592 from pengtikui/master docs: fix typo

view details

偏右

commit sha aa70ae0dcc87a18562561d81d77cbe14c20a56da

Merge pull request #17525 from ant-design/dependabot/npm_and_yarn/babel/plugin-transform-typescript-approx-7.5.1 Update @babel/plugin-transform-typescript requirement from ~7.4.5 to ~7.5.1

view details

Piotr Monwid-Olechnowicz

commit sha e49707c0aa1debc7d5aaf142509ce529371a813e

Update responsive.md (#17586) Fix prop typo. `border` -> `bordered`

view details

push time in a month

PR closed ant-design/ant-design

Reviewers
Correct rendertabbar type PR: unreviewed

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [x] TypeScript definition update
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Test Case
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

https://github.com/ant-design/ant-design/issues/17544

<!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed

View rendered components/tabs/index.en-US.md View rendered components/tabs/index.zh-CN.md

+0 -0

4 comments

0 changed file

ztplz

pr closed time in a month

push eventztplz/ant-design

ztplz

commit sha 05d3023b09e53af3f6f2b800148e16eda72c39d5

Fix typo

view details

push time in a month

pull request commentant-design/ant-design

update modal and drawer protal

别搞15了 又没啥人用 都快17了

jljsj33

comment created time in a month

issue commentant-design/ant-design

Unresponsive Slider when setting trigger to onAfterChange

@rubenski050 It will be solved in v4.

jshailes

comment created time in a month

issue commentant-design/ant-design

经过antdFrom 包裹的组件,原本继承父类的方法全部丢失

3.0前的升级啊 而且以前的都不再维护了

chico-malo

comment created time in a month

PR opened ant-design/ant-design

Correct rendertabbar type

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [x] TypeScript definition update
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Test Case
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

https://github.com/ant-design/ant-design/issues/17544

<!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+6 -3

0 comment

3 changed files

pr created time in a month

create barnchztplz/ant-design

branch : tabbar

created branch time in a month

pull request commentreact-component/dialog

Adjust scrollbar logic

@afc163 @zombieJ

ztplz

comment created time in a month

PR opened react-component/dialog

Adjust scrollbar logic

Fix https://github.com/ant-design/ant-design/issues/17491

+5 -9

0 comment

1 changed file

pr created time in a month

push eventztplz/dialog

zombiej

commit sha b4dc00b8ba7f8e988a8f58b0ebca51b2e22915fb

Prevent close if user mouseDown trigger on the dialog fix ant-design/ant-design#15891

view details

zombiej

commit sha c2e380bf8224f9002be9cdf74d8a670ec05d0525

remove useless content of aria

view details

zombiej

commit sha 522061a9a57332611bfea128d3e2e558178ef648

bump 7.4.0

view details

afc163

commit sha 7a0f8a1e33251f9f2c11e2288b7f86814db5893f

:bug: Fix close button auto submit when press enter in IE close ant-design/ant-design#17027 solution: https://stackoverflow.com/a/13532017/3040605

view details

偏右

commit sha 13657b9ecc1fc07279337666c3483be239a42e98

Merge pull request #120 from react-component/fix-button-submit fix: 🐛 Fix close button auto submit when press enter in IE

view details

afc163

commit sha 281ee35edae4646e3ec9f318679fdb4ad08c5670

:sparkles: 7.4.1

view details

ztplz

commit sha 718aed6bfbc0edbdce39a949236c27356b2c32f3

Adjust scrollbar logic

view details

push time in a month

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

我意思是你想要发个pr吗

Sayid1

comment created time in a month

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

@Sayid1 Wanna send a fix?

Sayid1

comment created time in 2 months

startedgohugoio/hugo

started time in 2 months

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

image 同样的道理 官网那个例子改成ts版本后也会挂的

Sayid1

comment created time in 2 months

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

image 问题就在这里 它用了clonelement 你传个reactnode进去就类型推导错误了 因为reactlementreactnode的子集 反过来就错了

Sayid1

comment created time in 2 months

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

其实是里面导出的定义不对
image tabbar不会是string number这些东西的 ReactNode 是 ReactElement 的超集

Sayid1

comment created time in 2 months

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

for example

你写react的时候, 定义了一个组件
class A extends React.Component<any, any> {
    render() {
        return <div>Hello {this.props.value}</div>;
    }
}

你用它的时候
<A value="world" />

但是。。。
如果这个A是一个实例 
你这么用
<A value="world" /> 它就报错了 
Sayid1

comment created time in 2 months

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

image dan但是改成这样又很不美观

Sayid1

comment created time in 2 months

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

我明白了 image 这是个实例 但是你拿它当构造函数在用

Sayid1

comment created time in 2 months

issue commentant-design/ant-design

在typescript中,使用Tabs组件的renderTabBar时出错

image 你这个DefaultTabbar哪来的

Sayid1

comment created time in 2 months

Pull request review commentreact-component/drawer

V2.0

 /* eslint-disable no-console,react/no-multi-comp */-import Drawer from 'rc-drawer';-import React from 'react';-import ReactDom from 'react-dom';-import { Menu, Icon } from 'antd';+import { Icon, Menu } from 'antd';+import * as React from 'react';+import * as ReactDom from 'react-dom';++import Drawer from '../src/'; -import 'antd/lib/style'; import 'antd/lib/menu/style';+import 'antd/lib/style'; -import 'rc-drawer/assets/index.less';+import '../assets/index.less'; import './assets/index.less';  const SubMenu = Menu.SubMenu; const MenuItemGroup = Menu.ItemGroup; class Demo extends React.Component {-  state = {+  public state = {     open: true,   }-  componentDidMount() {+  public componentDidMount() {     setTimeout(() => {       this.setState({         open: false,       });     }, 2000);   }-  onChange = (bool) => {+  public onChange = (bool: boolean) => {

私有方法不需要public的,又不是给用户用的

jljsj33

comment created time in 2 months

pull request commentreact-component/drawer

V2.0

react >= 17

jljsj33

comment created time in 2 months

Pull request review commentant-design/ant-design

fix(Cascader): Should show not found content when options.length is 0

 class Cascader extends React.Component<CascaderProps, CascaderState> {     ]);      let options = props.options;-    if (state.inputValue) {-      options = this.generateFilteredOptions(prefixCls, renderEmpty);+    if (options.length > 0) {+      if (state.inputValue) {+        options = this.generateFilteredOptions(prefixCls, renderEmpty);+      }+    } else {+      const names: FilledFieldNamesType = getFilledFieldNames(this.props);

已经返回这个类型了 不需要再指定了

dengfuping

comment created time in 2 months

delete branch ztplz/ant-design

delete branch : cas

delete time in 2 months

issue commentant-design/ant-design

how to use React.createElement(Button , { } )

Please refer to the react documentation for use.

yupeilin123

comment created time in 2 months

PR opened ant-design/ant-design

Improve code style

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [ ] TypeScript definition update
  • [ ] Refactoring
  • [x] Code style optimization
  • [ ] Test Case
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

<!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+2 -2

0 comment

1 changed file

pr created time in 2 months

create barnchztplz/ant-design

branch : cas

created branch time in 2 months

pull request commentant-design/ant-design

Add missing French translation

@Clafouti Don't worry about it. We just merged the feature into the master and then released a new version on the weekend.

Clafouti

comment created time in 2 months

Pull request review commentant-design/ant-design

Cascader value type change to string[] | number[]

 import LocaleReceiver from '../locale-provider/LocaleReceiver'; import warning from '../_util/warning';  export interface CascaderOptionType {-  value?: string;+  value?: any;

先加吧 原来太仓促了 以后我有时间用ts重写下组件

hengkx

comment created time in 2 months

issue commentant-design/ant-design

A lot of repeating helper functions

就几个工具函数哪来的2k。。。

SweetsXob

comment created time in 2 months

issue commentant-design/ant-design

A lot of repeating helper functions

babel默认就是这样啊 。。。会给很多编译后的代码加很多模板函数 让这些函数只在当前模块内生效 可以用external-helpers减少模板编译代码 但是没必要的

SweetsXob

comment created time in 2 months

issue closedant-design/ant-design

A lot of repeating helper functions

  • [ ] I have searched the issues of this repository and believe that this is not a duplicate.

随便打开2个文件,比如:es\checkbox\Checkbox.js,es\checkbox\Group.js

2个文件的头部,都有好几个helpers函数,比如:

function _extends() { ... }
function _defineProperties(target, props) { ... }
...等等

当然,别的文件,也有类似重复的helpers函数,无形中,就造成了冗余代码

希望把helpers函数,都提取出来,让用户自己处理,比如:

import _defineProperty from '@babel/runtime/helpers/esm/defineProperty'

这样,所有的helpers都从同一个地方引用,节省代码体积

<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->

closed time in 2 months

SweetsXob

issue commentant-design/ant-design

A lot of repeating helper functions

你看编译后的代码干什么。。。 编译符合ES6模块规范的代码放在es这个文件夹里

SweetsXob

comment created time in 2 months

issue commentant-design/ant-design

Datepicker locale issue

那些地方我们都是用的moment的 但是moment有很多的环境问题 他们issue还有回答说了

leegang79

comment created time in 2 months

pull request commentant-design/ant-design

style: add extra parentheses to the arguments of the ceil function

=> strictMath: false

kenve

comment created time in 2 months

issue commentant-design/ant-design

Select Placeholder shrinks when using Form inline layout

@snirp Seems working for me. Try to open it again? image

francisconeves97

comment created time in 2 months

PR opened ant-design/ant-design

fix changelog

<!-- First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch. Pull request will be merged after one of collaborators approve. Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template] -->

🤔 This is a ...

  • [ ] New feature
  • [ ] Bug fix
  • [ ] Site / document update
  • [ ] Component style update
  • [ ] TypeScript definition update
  • [ ] Refactoring
  • [ ] Code style optimization
  • [ ] Test Case
  • [ ] Branch merge
  • [ ] Other (about what?)

👻 What's the background?

<!--

  1. Describe the source of requirement, like related issue link.

  2. Describe the problem and the scenario. -->

💡 Solution

<!--

  1. How to fix the problem, and list final API implementation and usage sample if that is an new feature.

  2. GIF or snapshot should be provided if includes UI/interactive modification. -->

📝 Changelog

<!-- Describe changes from userside, and list all potential break changes or other risks. --->

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

  • [ ] Doc is updated/provided or not needed
  • [ ] Demo is updated/provided or not needed
  • [ ] TypeScript definition is updated/provided or not needed
  • [ ] Changelog is provided or not needed
+1 -1

0 comment

1 changed file

pr created time in 2 months

create barnchztplz/ant-design

branch : changelog

created branch time in 2 months

delete branch ztplz/ant-design

delete branch : changelog

delete time in 2 months

create barnchztplz/ant-design

branch : changelog

created branch time in 2 months

fork ztplz/libuv

Cross-platform asynchronous I/O

https://libuv.org/

fork in 2 months

fork ztplz/xray

xray 安全评估工具

https://chaitin.github.io/xray/

fork in 2 months

pull request commentant-design/ant-design

fix typo

LGTM, thanks.

eldarAkay

comment created time in 2 months

Pull request review commentant-design/ant-design

add 3.20.0 changelog

 timeline: true  --- +## 3.20.0++- 🔥 Descriptions Support vertical layout. [#17330](https://github.com/ant-design/ant-design/pull/17330) [@hengkx](https://github.com/hengkx)+- 🔥 Optimize PageHeader className naming. [#17321](https://github.com/ant-design/ant-design/pull/17321)+- 🔥 Progress.Circle support gradient line color. [#17315](https://github.com/ant-design/ant-design/pull/17315) [@hengkx](https://github.com/hengkx)+- 🐞 Drawer fixes `maskCloseble` to false, keyboard ESC closes invalid. [#17316](https://github.com/ant-design/ant-design/pull/17316)+- 🐞 Fixed an issue where Drawer closes not calling `afterVisibleChange` in Edge. [#17311](https://github.com/ant-design/ant-design/pull/17311)+- 🌟 Drawer adds `keyboard` to allow opening and closing of responses to keyboard events. [#17316](https://github.com/ant-design/ant-design/pull/17316)+- 🌟 Popconfirm adds the `disable` parameter to control whether the click child element pops up. [#16985](https://github.com/ant-design/ant-design/pull/16985) [@lhyt](https://github.com/lhyt)+- ⌨️ Improve TimePicker accessibility. [#17099](https://github.com/ant-design/ant-design/pull/17099)+- 💄 Fix Tooltip arrow shadow style. [#17264](https://github.com/ant-design/ant-design/pull/17264)+- 🐞 Fix Desciptions.Item not support `className`. [#17280](https://github.com/ant-design/ant-design/pull/17280)

Desciptions => Descriptions

chenshuai2144

comment created time in 2 months

more