profile
viewpoint

Azure/azure-functions-docker-python-sample 27

A sample of using docker to deploy a Python based app

python/cpython-bin-deps 12

Binaries that the cpython build process depends on

python/cpython-source-deps 12

Source for packages that the cpython build process depends on

zooba/deck 7

The Python deck collection

zooba/cpython 4

The Python programming language

zooba/botframework-python 1

A Python library to help writing bots for botframework.com

ItalyPaleAle/pycon2018-labs 0

Hands-on labs for PyCon 2018

zooba/angularjs-realworld-example-app 0

Exemplary real world application built with Angular 1.5 + ES6

push eventzooba/vscode-azureappservice

unknown

commit sha c5da005a2bb0edc22119eac303eae30baba2a613

Remove unnecessary function Simplify failureMoreInfoSurvey function Remove unused popup button property

view details

push time in 4 hours

Pull request review commentmicrosoft/vscode-azureappservice

Add survey prompt on certain deployment failures

 export async function deploy(actionContext: IActionContext, arg1?: vscode.Uri |     // tslint:disable-next-line: no-floating-promises     runPostDeployTask(node, correlationId, tokenSource); }++async function runDeployTask(context: IDeployContext, client: appservice.SiteClient, siteConfig: WebSiteModels.SiteConfigResource, deployPath: string): Promise<void> {

First time I tried to just keep it in the same function I hit a linting limit on complexity, but it seems to fit under the limit now.

zooba

comment created time in 6 hours

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-azureappservice

Add survey prompt on certain deployment failures

+/*---------------------------------------------------------------------------------------------+ *  Copyright (c) Microsoft Corporation. All rights reserved.+ *  Licensed under the MIT License. See License.txt in the project root for license information.+ *--------------------------------------------------------------------------------------------*/++'use strict';++import { env, ExtensionContext, Uri, window } from 'vscode';+import { localize } from "../../localize";++const SURVEY_URL = 'https://aka.ms/AppServiceExtDeploymentFeedback';++const NEVER_AGAIN_KEY = 'failureMoreInfoSurvey/neverAgain';++export function failureMoreInfoSurvey({ globalState }: ExtensionContext, failureKey: string): void {+    (async () => {+        if (env.language !== 'en' && !env.language.startsWith('en-')) {+            return;+        }++        const skip = globalState.get(NEVER_AGAIN_KEY, false);+        if (skip !== false) {+            return;+        }++        const take = {

Got any examples I can copy? I'm not a TypeScript developer, just pretending to be one since the team is overburdened ;)

zooba

comment created time in 6 hours

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-azureappservice

Add survey prompt on certain deployment failures

+/*---------------------------------------------------------------------------------------------+ *  Copyright (c) Microsoft Corporation. All rights reserved.+ *  Licensed under the MIT License. See License.txt in the project root for license information.+ *--------------------------------------------------------------------------------------------*/++'use strict';++import { env, ExtensionContext, Uri, window } from 'vscode';+import { localize } from "../../localize";++const SURVEY_URL = 'https://aka.ms/AppServiceExtDeploymentFeedback';++const NEVER_AGAIN_KEY = 'failureMoreInfoSurvey/neverAgain';++export function failureMoreInfoSurvey({ globalState }: ExtensionContext, failureKey: string): void {+    (async () => {+        if (env.language !== 'en' && !env.language.startsWith('en-')) {+            return;+        }++        const skip = globalState.get(NEVER_AGAIN_KEY, false);+        if (skip !== false) {+            return;+        }++        const take = {+            title: localize("provideFeedback", "Provide feedback"),+            run: async () => {+                env.openExternal(Uri.parse(`${SURVEY_URL}?k=${encodeURIComponent(failureKey)}&m=${encodeURIComponent(env.machineId)}`));+            }+        };+        const never = {+            title: localize('neverAgain', "Don't Show Again"),+            isSecondary: true,

No idea, I copied it from another survey. I'll try and dig into it.

zooba

comment created time in 6 hours

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-azureappservice

Add survey prompt on certain deployment failures

+/*---------------------------------------------------------------------------------------------+ *  Copyright (c) Microsoft Corporation. All rights reserved.+ *  Licensed under the MIT License. See License.txt in the project root for license information.+ *--------------------------------------------------------------------------------------------*/++'use strict';++import { env, ExtensionContext, Uri, window } from 'vscode';+import { localize } from "../../localize";++const SURVEY_URL = 'https://aka.ms/AppServiceExtDeploymentFeedback';++const NEVER_AGAIN_KEY = 'failureMoreInfoSurvey/neverAgain';++export function failureMoreInfoSurvey({ globalState }: ExtensionContext, failureKey: string): void {+    (async () => {+        if (env.language !== 'en' && !env.language.startsWith('en-')) {+            return;+        }++        const skip = globalState.get(NEVER_AGAIN_KEY, false);+        if (skip !== false) {+            return;+        }++        const take = {+            title: localize("provideFeedback", "Provide feedback"),+            run: async () => {+                env.openExternal(Uri.parse(`${SURVEY_URL}?k=${encodeURIComponent(failureKey)}&m=${encodeURIComponent(env.machineId)}`));+            }+        };+        const never = {+            title: localize('neverAgain', "Don't Show Again"),+            isSecondary: true,+            run: async () => {+                await globalState.update(NEVER_AGAIN_KEY, true);+            }+        };+        const button = await window.showInformationMessage(

Bring this to the email thread too. This is already limited to "people who have hit a known but undiagnosed deployment issue", so we definitely don't want a random sample.

I understand the survey is going to ask about the project that's being deployed so we can figure out if there is anything in common, so perhaps limiting it to once-per-site-per-week will do?

zooba

comment created time in 6 hours

PullRequestReviewEvent

Pull request review commentmicrosoft/vscode-azureappservice

Add survey prompt on certain deployment failures

 export async function deploy(actionContext: IActionContext, arg1?: vscode.Uri |     // tslint:disable-next-line: no-floating-promises     runPostDeployTask(node, correlationId, tokenSource); }++async function runDeployTask(context: IDeployContext, client: appservice.SiteClient, siteConfig: WebSiteModels.SiteConfigResource, deployPath: string): Promise<void> {+    try {+        await appservice.deploy(client, <string>deployPath, context);+    } catch (error) {+        const key = shouldPromptForSurvey(parseError(error), siteConfig);+        if (key) {+            failureMoreInfoSurvey(ext.context, key);+        }+        throw error;+    }+}++function shouldPromptForSurvey(error: IParsedError, siteConfig: WebSiteModels.SiteConfigResource): string | null {+    if (siteConfig.linuxFxVersion && siteConfig.linuxFxVersion.toLowerCase().startsWith(appservice.LinuxRuntimes.python)) {+        if (error.errorType === 'Error' && error.message.toLowerCase().startsWith("the service is unavailable")) {

Follow up on the email thread for this one.

zooba

comment created time in 6 hours

PullRequestReviewEvent

issue commentmicahmo/obs-progress

Crash on shutdown

Had a look at the PR and spotted one thing that may cause this, so hopefully that's it.

Sorry I forgot to check back in until OBS crashed on me again :D I think this can also occur when you remove a video source while it's playing, but it seems likely to be the same issue (removing the source decrements its reference count to zero so it gets released, even though obs-progress still has an uncounted reference).

zooba

comment created time in 11 hours

Pull request review commentmicahmo/obs-progress

zooba's idea

 void updateSceneInfo() { 	try 	{-		obs_source_t* currentSceneSource = obs_frontend_get_current_scene(); // This is the only call that increments the count, so we have to release it-		const char* name = obs_source_get_name(currentSceneSource);+		// Clean up the previous source/scenes+		_sources.clear();+		obs_source_release(_currentSceneSource);+		_progressDockWidget->clearProgressBars(); -		obs_scene_t* currentScene = obs_scene_from_source(currentSceneSource);-		obs_source_release(currentSceneSource);+		// Retrieve the current scene+		_currentSceneSource = obs_frontend_get_current_scene(); // This is the only call that increments the count, so we have to release it+		const char* name = obs_source_get_name(_currentSceneSource); +		obs_scene_t* currentScene = obs_scene_from_source(_currentSceneSource);+		obs_source_release(_currentSceneSource);

You shouldn't need to do this here anymore, because we'll do it when we next update the scene info (or stop our timer).

micahmo

comment created time in 11 hours

PullRequestReviewEvent

issue openedzooba/pymsbuild

Source directory should always be include dir

Because generated files end up elsewhere, we need to point IncludeDir back at the source

created time in a day

pull request commentpython/cpython

bpo-39107: Updated Tcl and Tk to 8.6.10 in Windows installer

@serhiy-storchaka Looks like we're waiting on you - any further comment?

zooba

comment created time in a day

create barnchpython/cpython-bin-deps

branch : tcltk-8.6.10.0

created branch time in 5 days

create barnchpython/cpython

branch : bpo-39107

created branch time in 5 days

created tagpython/cpython-source-deps

tagtk-8.6.10.0

Source for packages that the cpython build process depends on

created time in 5 days

created tagpython/cpython-source-deps

tagtcl-core-8.6.10.0

Source for packages that the cpython build process depends on

created time in 5 days

created tagpython/cpython-source-deps

tagtk-8.6.10

Source for packages that the cpython build process depends on

created time in 5 days

push eventpython/cpython-source-deps

Steve Dower

commit sha 3bb8e3e0868e46f3ba210ca8b23b232044197667

Import Tcl 8.6.10

view details

push time in 5 days

push eventpython/cpython-source-deps

Steve Dower

commit sha 42c69189d97c2cbf55d863b30a3444260037b34e

Import Tk 8.6.10

view details

push time in 5 days

PR opened microsoft/vscode-azureappservice

Add survey prompt on certain deployment failures

Right now we want to prompt on certain deployment failures for Python apps, but it should be fairly easy to extend for more cases.

+77 -2

0 comment

2 changed files

pr created time in 5 days

push eventzooba/vscode-azureappservice

Steve Dower

commit sha 7caacf4f244846829d902b9fa61927511ee9311e

Update URL and message.

view details

push time in 5 days

Pull request review commentmicrosoft/artifacts-keyring

If system dotnet version is higher than dotnetcore2 runtime one, use that.

 def __init__(self):             self.exe = [tool_path]         else:             try:-                from dotnetcore2.runtime import get_runtime_path+                sys_version = tuple(int(i) for i in+                    subprocess.check_output(["dotnet", "--version"]).decode().strip().partition("-")[0].split("."))

@aasim If anything, this is the opposite of coding by exception because we're handling too broad a base class. We could have replaced except Exception below with except (subprocess.CalledProcessError, OSError, TypeError, ValueError, OverflowError, UnicodeDecodeError) to handle all the possibilities, but there's really nothing gained by that.

Also, exception handling in general is not an anti-pattern in Python. It's often more efficient than look-before-you-leap style (unlike say, .NET, which is wildly inefficient).

temporaer

comment created time in 5 days

PullRequestReviewEvent

push eventzooba/vscode-azureappservice

Steve Dower

commit sha cea590b5ae56b6c9e32303bedeb5cb3d06c5083b

Remove explicit test

view details

push time in 8 days

push eventzooba/vscode-azureappservice

Steve Dower

commit sha 4c3cf28cad4814d92b9828df0b4932c4b376400f

[WIP] Add survey prompt on certain deployment failures

view details

push time in 8 days

create barnchzooba/vscode-azureappservice

branch : failsurvey

created branch time in 8 days

issue openedmicahmo/obs-progress

Crash on shutdown

Hi, I saw your "known issue" in the README about the crash on shutdown, and I think I know what at least one cause is. Didn't see anything open here to comment on, so I opened a new one.

At https://github.com/micahmo/obs-progress/blob/master/src/obs-progress.cpp#L148 you're releasing the object keeping the current scene alive, which means that now OBS itself has the only active handle to it (possibly other plugins too, but let's assume they're handling this properly already). During shutdown, this handle is released, and so the memory backing it all is freed.

However, because your timer is still firing, it comes in and assumes that the pointers in _sources are still valid. Since this isn't true, it crashes.

I assume the same thing could happen if you change scene collection while running, though maybe you'll get the notification of the new scene before the deallocation happens and will get away with it ;)

If this were my codebase, I'd stick the currentSceneSource value into a variable alongside _sources and only release it after you are clearing _sources. Then you'll want to stop the timer and clear everything during obs_module_unload. I'm 99% sure the timer can't trigger after modules are unloaded, but if _sources is empty then it shouldn't matter if it does.

Hopefully that's helpful! I'm not set up for developing OBS or plugins or I'd throw together a PR for you, but if you need me to I can try and get set up for it. My outside-of-work contribution time is pretty slim these days though, but I do appreciate your plugin!

created time in 11 days

delete branch zooba/peps

delete branch : pep-632

delete time in 12 days

push eventpython/peps

Steve Dower

commit sha 32ab5ae2cfd5fdd6a4a9397d491cc806c82fd780

PEP 632: Allow fixes during deprecation period and add migration and rejected ideas. (#1600)

view details

push time in 12 days

push eventzooba/zooba.github.io

Steve Dower

commit sha bf4972dbaf018739b61d866747d855806a001af1

Remove dead link and replace with reference to other recording

view details

push time in 13 days

issue commentpypa/warehouse

Publish a list of malicious packages that have been taken down

If we're going to wait for a complete API redesign and potential technology change, can we just manually dump the list of banned names into a public text file somewhere until that's ready?

di

comment created time in 13 days

issue commentpypa/warehouse

Publish a list of malicious packages that have been taken down

For anyone interested, my PR in #8533 works but is probably stalled on having a good path for the API. All the existing JSON APIs are under /pypi/<project-name>, which doesn't leave an obvious place to add this one (short of claiming the project name matching the API). Ernest already rejected putting it under /admin because that path is exclude from CDN.

Happy to receive any suggestions either here or there. I don't have near enough insight into PyPI's routing design to make a confident decision myself.

di

comment created time in 13 days

create barnchzooba/peps

branch : pep-632

created branch time in 14 days

push eventzooba/warehouse

dependabot-preview[bot]

commit sha c9bf42ecc5567e9b11f76199ef3c54b03f4aa341

Bump setuptools from 49.2.0 to 50.3.0 (#8524) Bumps [setuptools](https://github.com/pypa/setuptools) from 49.2.0 to 50.3.0. - [Release notes](https://github.com/pypa/setuptools/releases) - [Changelog](https://github.com/pypa/setuptools/blob/master/CHANGES.rst) - [Commits](https://github.com/pypa/setuptools/compare/v49.2.0...v50.3.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 487f97d8b0ec0b0e34665eb4933ea8536fab57c4

Bump isort from 5.5.1 to 5.5.2 (#8537) Bumps [isort](https://github.com/pycqa/isort) from 5.5.1 to 5.5.2. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/develop/CHANGELOG.md) - [Commits](https://github.com/pycqa/isort/compare/5.5.1...5.5.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 42cca6639172b7b2dea7c67639e97f8490bb0be9

Bump sentry-sdk from 0.17.3 to 0.17.4 (#8535) Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 0.17.3 to 0.17.4. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGES.md) - [Commits](https://github.com/getsentry/sentry-python/compare/0.17.3...0.17.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

Neel Patel

commit sha bd2b3a22f4f84072eb03abb771a88ddab1489e7a

Invite collaborators to project (#8182) * fix-5790: when adding owner / maintainer invite instead of auto adding collaborator invitations: add coverage for feature Update migration Fix linting Update templates Use correct value for initiator_username Fix repr for Role Add enum for role invitation status types s/Add/Invite/g Change remove button depending on invitation status Co-authored-by: Dustin Ingram <di@users.noreply.github.com> Co-authored-by: Ernest W. Durbin III <ewdurbin@gmail.com> * Modify project roles route handler to send invite emails when a role is assigned Send invitation email when a role is assigned Add tests and update migrations * Handle invitation response and add user role to project Add invitation accept handler, store submitter info in token * Create revoke invitation handler * Run a celery task to check on pending invitations * Add translations * Make sure to check the user who verifies the email * Update warehouse/accounts/views.py Co-authored-by: Dustin Ingram <di@users.noreply.github.com> * Update warehouse/templates/email/verify-project-role/body.html Co-authored-by: Dustin Ingram <di@users.noreply.github.com> * Record user/project events when accepting invites * Refactor the manage roles service * Update migration revises id * Change acceptance message and redirect to project page * Handle invite status edge case * Remove invites from db when it invite is accepted/revoked * Add translations to session flashes * Add confirmation page when clicking acceptance link * Fix merge issues * Catch specific exceptions * Make requested changes * Add pending invitations to project page * Fix test and linter issues * Fix code formatting issues * Update warehouse/templates/accounts/invite-confirmation.html Co-authored-by: Dustin Ingram <di@users.noreply.github.com> * Update warehouse/templates/manage/projects.html Co-authored-by: Dustin Ingram <di@users.noreply.github.com> * Merge * Update translations Co-authored-by: David Bordeynik <david@zebra-med.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com> Co-authored-by: Ernest W. Durbin III <ewdurbin@gmail.com>

view details

Dustin Ingram

commit sha fb550767791e40f0435dcc83b6885516b970ea5f

Fixed yanked_reason attribute of JSON release (#8550)

view details

Joachim Jablon

commit sha af442618d95fd6e952c686ecaa5ffdb068a55a87

GitHub token scanning api view (#7124) * Add IGitHubTokenScanningPayloadVerifyService * Add GitHubTokenScanningPayloadVerifyService Also add NullGitHubTokenScanningPayloadVerifyService * Register GitHubTokenScanningPayloadVerifyService * Add TokenLeakAnalyzer and supporting code * Add github_disclose_token view at /account/disclose-token/github * Add send_password_compromised_email_leak * Implement cryptographic signature checking * Fix existing test * Add tests for GitHubTokenScanningPayloadVerifyService * FAQ * Check macaroon signature too * Test NullGitHubTokenScanningPayloadVerifyService * Fix and test TokenLeakAnalyzer * Test and rename email.send_token_compromised_email_leak * Harmonize GitHub spelling * Add TokenLeakAnalyzer.analyze_disclosures * Fix and test github_disclose_token view * Add GitHub token to avoid IP-based rate limiting * Simplify tests using Counter rather than defaultdict * Add raw_macaroon fixture to simplify tests * Add HeadersPredicate * Use the new predicate * Create a dedicated github submodule * email is not translated * GitHubTokenScanningPayloadVerifier is not a service anymore * Add an in-memory cache for github public key * Update URL for github meta API * Moved HeadersPredicate and rename it require_headers * Replace attr.s with a simple class * GitHub API token is now mandatory * Move the TokenLeakAnalyzer at the bottom of the file for readability * Simplify the view * Remove the part regarding the python-security documentation * Remove TODO logs * Add all missing imports * fix flake8 * Analyze disclosures within a celery task * Fix tests * Add missing __init__.py & licence blurb * Fix predicate * Misc fixes * Translations * Lint * Improve cache system * Fix wrong merge * Translations again * Merge problems again. * Merge issues * Reformat * Make api token optional * Translations, again

view details

Rafael Fontenelle

commit sha e514fd046a974927b6914d9dbac17f02dae15002

help: typo in privte (#8551)

view details

Steve Dower

commit sha b9da9cb49f9fd62aab34d9aad94226427aff3488

Merge remote-tracking branch 'upstream/master' into banned_name_api

view details

push time in 15 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

push eventpython/cpython

Václav Slavík

commit sha 7c11a9accabe3720940f334eb1226bb7bb9179c7

bpo-41744: Package python.props with correct name in NuGet package (GH-22154) NuGet automatically includes .props file from the build directory in the target using the package, but only if the .props file has the correct name: it must be $(id).props Rename python.props correspondingly in all the nuspec variants. Also keep python.props as it were for backward compatibility.

view details

push time in 15 days

PR merged python/cpython

bpo-41744: Package NuGet python.props with correct name to be used CLA signed awaiting review needs backport to 3.8 needs backport to 3.9

NuGet automatically includes .props file from the build directory in the target using the package, but only if the file has the correct name: it must be $(id).props. This means that Python's support for this only works correctly in the python nuget packages, but not in pythonx86 and others, because the file is copied as python.props there too.

This PR fixes the problem by renaming the props file appropriately.

<!-- issue-number: bpo-41744 --> https://bugs.python.org/issue41744 <!-- /issue-number -->

+8 -4

1 comment

5 changed files

vslavik

pr closed time in 15 days

push eventpython/cpython

Zackery Spytz

commit sha 8f2b991eef062c22c429a96983c78be007180b66

bpo-41646: Mention path-like objects support in the docs for shutil.copy() (GH-22208)

view details

push time in 15 days

PR merged python/cpython

bpo-41646: Mention path-like objects support in the docs for shutil.copy() CLA signed awaiting review needs backport to 3.8 needs backport to 3.9 skip news type-documentation

<!-- issue-number: bpo-41646 --> https://bugs.python.org/issue41646 <!-- /issue-number -->

+3 -3

0 comment

1 changed file

ZackerySpytz

pr closed time in 15 days

issue openedzooba/pymsbuild

Link to metadata spec

Add links to https://packaging.python.org/specifications/core-metadata/ in convenient places

created time in 16 days

pull request commentmicrosoft/xlang

Send unraisable Python exceptions to the proper handler

From what you're describing, would E_UNEXPECTED be appropriate?

Maybe? My understanding was always that E_UNEXPECTED was a "this should never happen" kind of error code, while this situation is more of a generic failure that has nowhere to propagate.

zooba

comment created time in 18 days

pull request commentpython/cpython

bpo-41744: Package NuGet python.props with correct name to be used

Thanks! Just need a NEWS file (click Details next to the failed check for the helper app). Something like "Fixes automatic import of props file when using the Nuget package" would be good.

vslavik

comment created time in 19 days

push eventzooba/warehouse

Steve Dower

commit sha 3702749767fbb9b885a42dab7c21a4e1f63c4fe3

Wrap line

view details

push time in 19 days

PullRequestReviewEvent

Pull request review commentmicrosoft/artifacts-keyring

Update readme to make connection to cred-provider more clear

+## NOTE+'artifacts-keyring' is a relatively thin wrapper around [artifacts-credprovider](https://github.com/microsoft/artifacts-credprovider).  Make sure to also look at that repository for more information about different scenarios. For example:++* [Environment variable to explicitly override tokens](https://github.com/microsoft/artifacts-credprovider)
* [Environment variable to explicitly override tokens](https://github.com/microsoft/artifacts-credprovider#environment-variables)
johnterickson

comment created time in 19 days

push eventzooba/warehouse

Steve Dower

commit sha a71c3930520aef014a1f28ace38652126ca44c98

Add docs

view details

push time in 19 days

push eventzooba/warehouse

Steve Dower

commit sha ebd2f5cefd5ab96270a52b1bec3ec9eea21d071a

Remove untestable Content-Type check

view details

push time in 20 days

push eventzooba/warehouse

Steve Dower

commit sha f12e7d6fd3e882e738761d1fc6d7ae30c23010fb

Check correct values

view details

push time in 20 days

push eventzooba/warehouse

Steve Dower

commit sha 315a8693579a83ec2d07481a5856d8273630409b

Fix CORS and check the body format

view details

push time in 20 days

push eventzooba/warehouse

Steve Dower

commit sha 09d8fcaad172daf7dbd84b244b8857bd23bddf88

Fix one unit test and add a new one that probably breaks

view details

push time in 20 days

push eventzooba/warehouse

Steve Dower

commit sha 64ec908d9b774b690fd257097b3af4841474d89f

Moves API back to /pypi/prohibited_project_names/json/

view details

push time in 20 days

pull request commentpypa/warehouse

Fixes #4703 Implement API for obtaining prohibited names

Also, any suggestions/preferences for where to route it? Under /api/{project_name} can't work (unless we go ahead and ban the package name matching the API... 👀) None of the other existing paths looked like good options.

zooba

comment created time in 20 days

pull request commentpypa/warehouse

Fixes #4703 Implement API for obtaining prohibited names

If we move it under a route that Fastly will cache, will they respect expiry headers? This is an information API, so there's really no harm in it being up to a day behind.

zooba

comment created time in 20 days

push eventzooba/warehouse

Steve Dower

commit sha b59d805de42e30834f89b75f70724d093b309a15

Add API to test

view details

push time in 20 days

push eventzooba/warehouse

Steve Dower

commit sha 7af2a281d7d19b8713079bc804e5681d6d56e4ba

Move API under /admin but leave it unauthenticated

view details

push time in 20 days

pull request commentpypa/warehouse

Fixes #4703 Implement API for obtaining prohibited names

Going to move it under the admin section where the existing route is, but leave it unauthenticated and just return the list as JSON.

zooba

comment created time in 20 days

push eventzooba/warehouse

Dustin Ingram

commit sha b803521c2ddfb1b60f8f4c8d8ada975835978a71

Upgrade to gulp-brotli==3.0.0 (#8532)

view details

dependabot-preview[bot]

commit sha 2f91cb164738455d69e7474897e188e101863d78

Bump pbr from 5.4.5 to 5.5.0 (#8502) Bumps [pbr](https://docs.openstack.org/pbr/latest/) from 5.4.5 to 5.5.0. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 22a1cf77e89299cd56a9785aa2da0639a6f2f1b6

Bump stevedore from 3.2.0 to 3.2.1 (#8503) Bumps [stevedore](https://docs.openstack.org/stevedore/latest/) from 3.2.0 to 3.2.1. Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 599adef4c3a2cd0ae63669e73393c0130a1e69e8

Bump sentry-sdk from 0.16.2 to 0.17.3 (#8504) Bumps [sentry-sdk](https://github.com/getsentry/sentry-python) from 0.16.2 to 0.17.3. - [Release notes](https://github.com/getsentry/sentry-python/releases) - [Changelog](https://github.com/getsentry/sentry-python/blob/master/CHANGES.md) - [Commits](https://github.com/getsentry/sentry-python/compare/0.16.2...0.17.3) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 965850bd2c257e59de6e581a730b521e5b7af52f

Bump google-auth from 1.19.2 to 1.21.1 (#8511) Bumps [google-auth](https://github.com/googleapis/google-auth-library-python) from 1.19.2 to 1.21.1. - [Release notes](https://github.com/googleapis/google-auth-library-python/releases) - [Changelog](https://github.com/googleapis/google-auth-library-python/blob/master/CHANGELOG.md) - [Commits](https://github.com/googleapis/google-auth-library-python/compare/v1.19.2...v1.21.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 8595a595aa5742b54b005680f16e4eff922dbb88

Bump black from 19.10b0 to 20.8b1 (#8476) * Bump black from 19.10b0 to 20.8b1 Bumps [black](https://github.com/psf/black) from 19.10b0 to 20.8b1. - [Release notes](https://github.com/psf/black/releases) - [Changelog](https://github.com/psf/black/blob/master/CHANGES.md) - [Commits](https://github.com/psf/black/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Formatting updates Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 325b0523e2af01465e4cc06f2bc323aaff778d28

Bump isort from 5.2.2 to 5.5.1 (#8519) Bumps [isort](https://github.com/pycqa/isort) from 5.2.2 to 5.5.1. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/develop/CHANGELOG.md) - [Commits](https://github.com/pycqa/isort/compare/5.2.2...5.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha e1853629959adc8f09f60d348d59ce5954ee1ae4

Bump attrs from 20.1.0 to 20.2.0 (#8522) Bumps [attrs](https://github.com/python-attrs/attrs) from 20.1.0 to 20.2.0. - [Release notes](https://github.com/python-attrs/attrs/releases) - [Changelog](https://github.com/python-attrs/attrs/blob/master/CHANGELOG.rst) - [Commits](https://github.com/python-attrs/attrs/compare/20.1.0...20.2.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha e0abbe671b9f65f371bb64b8c36b810875387338

Bump google-api-core from 1.22.0 to 1.22.2 (#8512) Bumps [google-api-core](https://github.com/googleapis/python-api-core) from 1.22.0 to 1.22.2. - [Release notes](https://github.com/googleapis/python-api-core/releases) - [Changelog](https://github.com/googleapis/python-api-core/blob/master/CHANGELOG.md) - [Commits](https://github.com/googleapis/python-api-core/compare/v1.22.0...v1.22.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha b5a245060c22f78a1f28beb1742113397b8d2c08

Bump freezegun from 0.3.15 to 1.0.0 (#8523) Bumps [freezegun](https://github.com/spulec/freezegun) from 0.3.15 to 1.0.0. - [Release notes](https://github.com/spulec/freezegun/releases) - [Changelog](https://github.com/spulec/freezegun/blob/master/CHANGELOG) - [Commits](https://github.com/spulec/freezegun/compare/0.3.15...1.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha ad7209142b4b0a9893fa844e8fa2f40c98e07a87

Bump psycopg2 from 2.8.5 to 2.8.6 (#8525) Bumps [psycopg2](https://github.com/psycopg/psycopg2) from 2.8.5 to 2.8.6. - [Release notes](https://github.com/psycopg/psycopg2/releases) - [Changelog](https://github.com/psycopg/psycopg2/blob/master/NEWS) - [Commits](https://github.com/psycopg/psycopg2/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Dustin Ingram <di@users.noreply.github.com>

view details

Steve Dower

commit sha 1b0d552f620ffbbc62312090179e650bd3eed676

Merge remote-tracking branch 'upstream/master' into banned_name_api

view details

push time in 20 days

pull request commentpypa/warehouse

Fixes #4703 Implement API for obtaining prohibited names

Ping @di

zooba

comment created time in 20 days

PR opened pypa/warehouse

Fixes #4703 Implement API for obtaining prohibited names

This is very much a work in progress for implementing #4703, but I wanted to get feedback on the direction as I go.

In particular, the API route can't (trivially) go under /api/prohibited_project_name because that's a lookup for a package by that name. I replaced the slash with an underscore so I could test it, but open to other ideas on where to put it.

At least in my dev environment, putting it at /admin/prohibited_project_name/json seems to work okay. But totally open to other suggestions.

+25 -1

0 comment

2 changed files

pr created time in 20 days

create barnchzooba/warehouse

branch : banned_name_api

created branch time in 20 days

Pull request review commentpython/cpython

bpo-40747: Make py_version_nodot 3_10 not 310

     ))</Field3Value>     <Field3Value Condition="$(UseTestMarker) == 'true'">$([msbuild]::Add($(Field3Value), 9000))</Field3Value>     -    <!-- The name of the resulting pythonXY.dll (without the extension) -->-    <PyDllName>python$(MajorVersionNumber)$(MinorVersionNumber)$(PyDebugExt)</PyDllName>+    <!-- The name of the resulting pythonX_Y.dll (without the extension) -->+    <PyDllName>python$(MajorVersionNumber)_$(MinorVersionNumber)$(PyDebugExt)</PyDllName>

Likely some under Tools/nuget as well, though they may all be under Tools/msi or PC/layout.

mattip

comment created time in 20 days

Pull request review commentpython/cpython

bpo-40747: Make py_version_nodot 3_10 not 310

 SelectPythonDlgProc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)                                          &py_major, &py_minor);                         if (result == 2) { #ifdef _DEBUG-                            wsprintf(pythondll, "python%d%d_d.dll",+                            wsprintf(pythondll, "python%d_%d_d.dll",                                      py_major, py_minor); #else-                            wsprintf(pythondll, "python%d%d.dll",+                            wsprintf(pythondll, "python%d_%d.dll",

This will cause us to have to manually rebuild and commit wininst-...exe in Lib/distutils/command, and just glancing at the code I can see in the PR this appears to have a list of Python installs, so we may need logic here to only insert the underscore for 3.10 and later (or we can get PEP 632 approved and then ignore this file completely)

mattip

comment created time in 20 days

Pull request review commentpython/cpython

bpo-40747: Make py_version_nodot 3_10 not 310

     ))</Field3Value>     <Field3Value Condition="$(UseTestMarker) == 'true'">$([msbuild]::Add($(Field3Value), 9000))</Field3Value>     -    <!-- The name of the resulting pythonXY.dll (without the extension) -->-    <PyDllName>python$(MajorVersionNumber)$(MinorVersionNumber)$(PyDebugExt)</PyDllName>+    <!-- The name of the resulting pythonX_Y.dll (without the extension) -->+    <PyDllName>python$(MajorVersionNumber)_$(MinorVersionNumber)$(PyDebugExt)</PyDllName>

There are going to be a number of similar changes in Tools/msi

mattip

comment created time in 20 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentmicrosoft/xlang

Send unraisable Python exceptions to the proper handler

I bet we could throw a better exception than hresult_invalid_argument but I don't know what it would be... E_FAIL? Make up our own HRESULT?

zooba

comment created time in 22 days

PR opened microsoft/xlang

Send unraisable Python exceptions to the proper handler

Exceptions raised during event handlers are practically never going to reappear in Python code (the exceptions are those directly triggered by other Python code, such as StringMap.map_changed, but we don't have a great way to identify those).

Instead, PyErr_WriteUnraisable will format an "Exception ignored in ..." message by default, and can be hooked by developers to handle it specially. It also clears the error state after reporting, which prevents superfluous errors if we happen to end up back in a Python thread.

+1 -1

0 comment

1 changed file

pr created time in 22 days

create barnchzooba/xlang

branch : pyeventexc

created branch time in 22 days

push eventzooba/xlang

Steve Dower

commit sha 6af844aedb957ed5a4fcdd79a69a4329cf3337e0

Update complete_winml_tutorial.py (#354) * Update complete_winml_tutorial.py * Fixes search for content

view details

Scott Jones

commit sha 5a0f9abd224f8aec840b769c7c1e38ed5680a3fc

fixed unclosed import element (#357)

view details

Harry Pierson

commit sha 83c96ed8d46aa7051bc8717ade679a9eed4b7d2a

squash merge devhawk/buildtest into a new branch for code review purposes (#356) merge branch master brought in a minor change unrelated to python projection

view details

Harry Pierson

commit sha 94933b6684c7ea0d9ce1dd375110047210433754

Initial readme improvements for python projection (#364) * readme work * name feedback

view details

Harry Pierson

commit sha 0d44b377d156fbfec60cff68863098e06b68581f

pint c++/WinRT nuget to 2.0.190417.3 (#365)

view details

Ryan Shepherd

commit sha 6903bccec82a2e411c1ce732bf05a6c0253ab1b1

Convert IInspectable to IXlangObject (#359) Default implementations for Equals and GetObjectInfo

view details

Harry Pierson

commit sha e089d7ab65ee197decc527937654f5dd563f7752

fix links (#367)

view details

Manodasan Wignarajah

commit sha d2cff46d73a2b5f320f8a101e0c39413f069d849

Implementaton of error handling for xlang (#361) * Implementaton of error handling for xlang * Fixing cmake spacing. * Addressing PR feedback on pascal casing vs snake casing and using xlang_type_load to indiciate class not found scenarios. * Revert "Addressing PR feedback on pascal casing vs snake casing and using xlang_type_load to indiciate class not found scenarios." This reverts commit 3a42c3d4520872ba8af91dafa8105ad60d707d6b. * Addressing feedback on error when class isn't available. * Removing xlang prefix from c++ error codes in enum. * Adding missed file.

view details

Ryan Shepherd

commit sha 00f5ed8812dece8ce512d56d0e31220371e2982f

Add foundation + collection types to xlang (#360) * Generate xlang_foundation.xmeta * Clean up xlang namespace in xlang_foundation. Don't use install on xlang_foundation target * cppx test should consume xmeta * Use new GuidAttribute * Fix CMake typo * Get collections projecting, building, and testing * More partially working tests * Remove leftover references to async with progress * Clean up some foundation build dependencies

view details

Harry Pierson

commit sha d13ada734585f2f2fdb61e3c3bf783c34c3dae74

Devhawk/release winml sample (#369) * remove generated pywinrt code * update complete_winml_tutorial * update readmes

view details

Scott Jones

commit sha ae7de43eee28c037f263a9e10e2cfa1308882980

make is_sta assertion a bit more diagnostic (#374) * make is_sta assertion a bit more diagnostic * spaces -> tabs * remove en_us tag, per Steve

view details

Kenny Kerr

commit sha e8e2bbd0a3c83d7b4536953b6756589b24a9567e

More efficient GUID comparisons in C++/WinRT (#372)

view details

Scott Jones

commit sha 90cd93272507b4c6cf5eb6e1d9000a88b4223ab3

opt out of heap enforcement for existing xaml apps (#376)

view details

Scott Jones

commit sha 3a3772b93d55e988b4209feb805f9cf5b584f486

Support for SDK override builds (#378) * address a few regressions when building outside msbuild * more SDK override conditions * assign path properties in targets (late)

view details

Kenny Kerr

commit sha 7af3938da747c4837a248930563b3fef8ee0646f

Workaround for C++ compiler code gen bug (#379)

view details

Raymond Chen

commit sha d2ff6bdd9ef26bb3862c74973e3af71db1dbc1b3

xlang::call propagates return value of std::visit (#385) Makes it easier to visit things and return a value.

view details

Kenny Kerr

commit sha 7b3d1eb6f50056aa9ca35279754b6954dab22f26

Generate C++/WinRT fast ABI base calls automatically for implementations (#386)

view details

Kenny Kerr

commit sha 69fb907ef95fa943da8c37421045e0255ab6e591

Disambiguate get_abi use in C++/WinRT implementation (#390)

view details

Kenny Kerr

commit sha 7176cb7dfd76ac1dd26c430095f63516c91f2822

Improved diagnostics for detecting direct allocations in C++/WinRT (#391)

view details

Harry Pierson

commit sha cda5bde04c43c8ac992209f26d257d1e221b9a71

Improve Python/WinRT Readme (#375) * fix links and typos * more docs for Python/winrt * remove en-us tag from microsoft URLs

view details

push time in 22 days

delete branch zooba/cpython

delete branch : bpo-41627

delete time in 25 days

push eventpython/cpython

Steve Dower

commit sha dd18001c308fb3bb65006c91d95f6639583a3420

bpo-41627: Distinguish 32 and 64-bit user site packages on Windows (GH-22098) Also fixes the error message returned when sysconfig fails to interpolate a variable correctly.

view details

push time in 25 days

PR merged python/cpython

bpo-41627: Distinguish 32 and 64-bit user site packages on Windows CLA signed OS-windows awaiting core review

<!-- Thanks for your contribution! Please read this comment in its entirety. It's quite important.

Pull Request title

It should be in the following format:

bpo-NNNN: Summary of the changes made

Where: bpo-NNNN refers to the issue number in the https://bugs.python.org.

Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.

Backport Pull Request title

If this is a backport PR (PR made against branches other than master), please ensure that the PR title is in the following format:

[X.Y] <title from the original PR> (GH-NNNN)

Where: [X.Y] is the branch name, e.g. [3.6].

GH-NNNN refers to the PR number from master.

-->

<!-- issue-number: bpo-41627 --> https://bugs.python.org/issue41627 <!-- /issue-number -->

+17 -10

0 comment

3 changed files

zooba

pr closed time in 25 days

push eventpython/peps

Steve Dower

commit sha d0f62aaf0cd64b2b1cc898d30a15ed8097536c9e

PEP 632: Update metadata (#1583)

view details

push time in 25 days

delete branch zooba/peps

delete branch : pep-632

delete time in 25 days

PR merged python/peps

PEP 632: Update metadata CLA signed

<!--

Please include the PEP number in the pull request title, example:

PEP NNN: Summary of the changes made

In addition, please sign the CLA.

For more information, please read our Contributing Guidelines (CONTRIBUTING.rst)

-->

+3 -1

0 comment

1 changed file

zooba

pr closed time in 25 days

push eventzooba/cpython

Steve Dower

commit sha 21823ba56e9c1d0d269a22113e997ed23df18187

Ensure py_version_nodot_plat is always defined

view details

push time in 25 days

create barnchzooba/peps

branch : pep-632

created branch time in 25 days

PR opened python/peps

PEP 632: Update metadata

<!--

Please include the PEP number in the pull request title, example:

PEP NNN: Summary of the changes made

In addition, please sign the CLA.

For more information, please read our Contributing Guidelines (CONTRIBUTING.rst)

-->

+3 -1

0 comment

1 changed file

pr created time in 25 days

delete branch zooba/peps

delete branch : pep-632

delete time in 25 days

push eventpython/peps

Steve Dower

commit sha 43a02f73a33a470ea2723707e2e58fef17035309

PEP 632: Updates from day 1 of reviews (#1582) * Clarified some text * Add link to setuptools's migration page

view details

push time in 25 days

PR merged python/peps

PEP 632: Review updates CLA signed in-progress
+37 -19

0 comment

1 changed file

zooba

pr closed time in 25 days

push eventzooba/peps

Steve Dower

commit sha 588cc537815ea1a206b5d16daef7c6b3ca723251

Add link to setuptools's migration page

view details

push time in 25 days

push eventzooba/cpython

Steve Dower

commit sha bdc676c922d43601a4e9aab17bf4dea299922d0e

Fix incorrect error message (fix for the bug coming next)

view details

push time in 25 days

PR opened python/cpython

bpo-41627: Distinguish 32 and 64-bit user site packages on Windows OS-windows

<!-- Thanks for your contribution! Please read this comment in its entirety. It's quite important.

Pull Request title

It should be in the following format:

bpo-NNNN: Summary of the changes made

Where: bpo-NNNN refers to the issue number in the https://bugs.python.org.

Most PRs will require an issue number. Trivial changes, like fixing a typo, do not need an issue.

Backport Pull Request title

If this is a backport PR (PR made against branches other than master), please ensure that the PR title is in the following format:

[X.Y] <title from the original PR> (GH-NNNN)

Where: [X.Y] is the branch name, e.g. [3.6].

GH-NNNN refers to the PR number from master.

-->

+12 -8

0 comment

3 changed files

pr created time in 25 days

create barnchzooba/cpython

branch : bpo-41627

created branch time in 25 days

create barnchzooba/peps

branch : pep-632

created branch time in 25 days

PR opened python/peps

PEP 632: Review updates in-progress
+30 -15

0 comment

1 changed file

pr created time in 25 days

delete branch zooba/peps

delete branch : pep-632

delete time in 25 days

push eventpython/peps

Steve Dower

commit sha 5d5c68517cf9087e104673f7f8322311e31a4e0a

PEP 0632: Deprecate distutils module (#1581)

view details

push time in 25 days

more