profile
viewpoint
Vincent LE GOFF zekth Genesys Brest, France https://zekth.github.io/ I'm Vincent, I solve problems. Software Engineer @genesysengage

reef-pi/reef-pi 210

An opensource reef tank controller based on Raspberry Pi

zekth/Keyset-Catalog 14

Just a simple app to browse available keysets and find the best matches for a color

keycap-archivist/database 7

Keycap Archivist Database

mkbdfr/website 6

Entry point for the Mechanical Keyboards France community

zekth/deno_easypath 5

Filesystem helper for Deno

zekth/keycap-ruler 5

Measure the size of your keycaps!

keycap-archivist/app 4

Keycap Archivist application

zekth/gulp-image-process 4

Gulp task for processing images

zekth/deno_tiny_templates 3

A template parser for deno

Kawamashi/LetsTwist_keyboard 1

Ergonomic split mechanical keyboard

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 53e9499f2f2c82b10e985b3b3bed942f677f342f

update-website

view details

push time in 36 minutes

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 6c647255121cfdeee56111579630d081ee6efb47

Update catalog

view details

push time in 39 minutes

push eventkeycap-archivist/database

Database Bot

commit sha 5957595b8fa61e1e994559ba7d0fbaaa1856168d

[skip-ci] Database Synchronization

view details

push time in 40 minutes

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 586dd2c324586d1fe472dff6c38dce3922d299e3

update-website

view details

push time in 2 hours

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 2cafc73fbdc98c2ef4df0e23980ca5345f861692

Update catalog

view details

push time in 3 hours

push eventkeycap-archivist/database

Database Bot

commit sha a157f50ca3d0db07b1ad57a8e4a3a7e3a12dd098

[skip-ci] Database Synchronization

view details

push time in 3 hours

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha a1975d7590ede24441339e9d468e502942ef4220

update-website

view details

push time in 5 hours

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha f19a8569744363845796e4ce9e2bb26e8d7ee8fc

Update catalog

view details

push time in 5 hours

push eventkeycap-archivist/database

Database Bot

commit sha 6323476a9baee3425e89f24b2163ddd3f48ddab4

[skip-ci] Database Synchronization

view details

push time in 5 hours

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 6fc71869f789418e915694d849154cb42cfd95d1

update-website

view details

push time in 9 hours

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 6edf40d707abaffc54f33f9455674851151aa756

Update catalog

view details

push time in 9 hours

push eventkeycap-archivist/database

Database Bot

commit sha 43f44b8fe90d5f2e2bca64d0c1da867d1a1e8b33

[skip-ci] Database Synchronization

view details

push time in 9 hours

issue commentfastify/help

Question: npm assets

I have no strong opinion on this, just sharing previous issue.

zekth

comment created time in 11 hours

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 436e1f480601ba071f5735e214744e889d3fefed

update-website

view details

push time in 11 hours

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha f192b6438fd1471987c164a868e77faa4e94c987

Update catalog

view details

push time in 11 hours

push eventkeycap-archivist/database

Database Bot

commit sha a3d7368de92419c0d154f62267d559528f6b4012

[skip-ci] Database Synchronization

view details

push time in 11 hours

issue commentfastify/help

Question: npm assets

extract of the report:

	"compliances": [
				{
					"title": "Private keys stored in image",
					"severity": "high",
					"cause": "Found: /server/node_modules/fastify/test/https/fastify.key"
				}
			],
zekth

comment created time in 11 hours

delete branch zekth/fastify

delete branch : add_discord_badge

delete time in 13 hours

delete branch zekth/fastify

delete branch : clean_ci

delete time in 13 hours

delete branch zekth/fastify

delete branch : cleanup_npmignore

delete time in 14 hours

PR opened fastify/fastify

feat: delete non existent files references

As mentionned in https://github.com/fastify/help/issues/243

Deleting azure pipelines references in npmignore

Checklist

+0 -3

0 comment

1 changed file

pr created time in 15 hours

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 600f9d52fab7a458cde1f980f82bc2e7d98d8fe4

update-website

view details

push time in 15 hours

create barnchzekth/fastify

branch : cleanup_npmignore

created branch time in 15 hours

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 25edbd94f19d5a04b978bb80e3987e06d4a2d4e6

Update catalog

view details

push time in 15 hours

push eventkeycap-archivist/database

Database Bot

commit sha 80cdad6ad853b7295f1eb861bb04fa983e2ccca8

[skip-ci] Database Synchronization

view details

push time in 15 hours

issue openedfastify/help

Question: npm assets

using npm i fastify it downloads the packages fitting the specs in .npmrc and .npmignore:

.editorconfig
.gitattributes
.git
.DS_Store
.gitignore
.github
.nyc_output
coverage/
tools/
azure-pipelines-npm-template.yml // Seem those can be deleted
azure-pipelines-yarn-template.yml // Seem those can be deleted
azure-pipelines.yml // Seem those can be deleted
CODE_OF_CONDUCT.md
CONTRIBUTING.md
.dependabot

Question is, is there a real benefit of shipping tests with the npm package? If so why not consider a fastify@light package? I'm asking this because of some security scanners i was forced to introduce step like so in the build process of one docker image (and i guess i'm not the only one):

rm -rf ./node_modules/fastify/test/https/fastify.key

Reference:

  • Security scanne: https://www.twistlock.com/use-cases/docker-security-platform/

created time in 15 hours

Pull request review commentfastify/fastify

ci: avoid unnecessary runs

 name: ci -on: [push, pull_request]+on:+  push:+    paths-ignore:+      - docs/**+      - examples/**

Looking at the git history of examples it looks useless complexity addition to me. Keeping the paths-ignore like this is ok.

zekth

comment created time in 16 hours

Pull request review commentfastify/fastify

ci: avoid unnecessary runs

 name: ci -on: [push, pull_request]+on:+  push:+    paths-ignore:+      - docs/**+      - examples/**

I'll setup this in another PR.

zekth

comment created time in 17 hours

push eventzekth/fastify

Vincent LE GOFF

commit sha dec209d80d5c7522efdded4ed57f0fc339ce32f7

ci: avoid unnecessary runs

view details

push time in 17 hours

push eventzekth/fastify

Vincent LE GOFF

commit sha 0edf7ec32e8fb34c6b4fa360881bc1e11014c910

ci: avoid unnecessary runs

view details

push time in 17 hours

Pull request review commentfastify/fastify

ci: avoid unnecessary runs

 name: ci -on: [push, pull_request]+on:+  push:+    paths-ignore:+      - docs/**+      - examples/**

Wouldn't it be better to separate the lint workflow in another file? Because having the whole matrix running on just change on examples isn't really necessary.

zekth

comment created time in 17 hours

PR opened fastify/fastify

ci: avoid unnecessary runs

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md

By making a contribution to this project, I certify that:

  • (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

  • (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

  • (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

  • (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

Avoid using unnecessary use of the CI for non used ressources.

Checklist

+11 -1

0 comment

1 changed file

pr created time in 17 hours

create barnchzekth/fastify

branch : clean_ci

created branch time in 17 hours

PR closed zekth/go_qmk

Add docker-compose deployment and go_qmk_base_container

Just a bootstrap ATM. Needs way more work.

+2065 -2

0 comment

10 changed files

zekth

pr closed time in 17 hours

PR opened fastify/fastify

doc: add discord badge

<!-- Thank you for your pull request. Please provide a description above and review the requirements below.

Bug fixes and new features should include tests and possibly benchmarks.

Contributors guide: https://github.com/fastify/fastify/blob/master/CONTRIBUTING.md

By making a contribution to this project, I certify that:

  • (a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

  • (b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

  • (c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

  • (d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved. -->

fix #2488

To make this badge works, this procedure need to be done : https://vimeo.com/364220040

Checklist

+1 -0

0 comment

1 changed file

pr created time in 17 hours

create barnchzekth/fastify

branch : add_discord_badge

created branch time in 17 hours

issue commentfastify/fastify

Wildcard route does not parse semicolon correctly

Look at this workaround so: https://github.com/fastify/fastify/issues/2287#issuecomment-630421865

adityapatadia

comment created time in 18 hours

issue commentfastify/fastify

inject() returns undefined if called before ready()

Seems like this issue can be closed now?

m-ronchi

comment created time in 18 hours

issue commentfastify/fastify

Wildcard route does not parse semicolon correctly

In the current state of art you can't as the routing is the first part of the lifecycle of the request. Your client need to encode the filename before sending the request. eg:

const encoded = encodeURIComponent('57950_gcvhjmk,l.;dfrfh.png');
// 57950_gcvhjmk%2Cl.%3Bdfrfh.png
adityapatadia

comment created time in 18 hours

issue openedfastify/fastify

doc: Add discord badge

<!-- Before you submit an issue we recommend you visit Fastify Help and ask any questions you have or mention any problems you've had getting started with Fastify.

Please read this entire template before posting any issue. If you ignore these instructions and post an issue here that does not follow the instructions, your issue might be closed, locked, and assigned the missing discussion label. -->

🚀 Feature Proposal

To promote the use of discord to make the community grow, the addition of a badge within the others on the README can be a plus. Here is how to setup it : https://shields.io/category/chat (needs admin permission to allow it on discord side)

Motivation

Promote the discord server

created time in 18 hours

push eventzekth/fastify

Vincent LE GOFF

commit sha c8eb3d47fe0294554e60e1d5ae643612da8f9a2b

fix: typings for hooks (#2485) * fix: typings for hooks * fix: typings for hooks

view details

push time in 18 hours

delete branch zekth/fastify

delete branch : fix_2439

delete time in 18 hours

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 4b0d5ae43082495ce32d052a570f0796c999ab75

update-website

view details

push time in 20 hours

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 5a8122723f5b8e158fb748584aac08a17f24b8c7

Update catalog

view details

push time in 21 hours

push eventkeycap-archivist/database

Database Bot

commit sha 49029648bb7409b6959939ef4cec086d7a941ee8

[skip-ci] Database Synchronization

view details

push time in 21 hours

issue commentfastify/fastify

Fastify must not mutate passed in options

It should be a deep clone so that Fastify can retain a clean copy. But I think someone had arguments against that at some point; I'm not sure, though.

indeed Object.assign won't work with versionning for example.

What about rewriting this: https://github.com/fastify/fastify/blob/master/fastify.js#L94-L100 and make an inner option object and using spread operator when needed like suggested @stalniy ?

stalniy

comment created time in a day

push eventzekth/fastify

Vincent LE GOFF

commit sha 43e512dac5b1fe396de66cf03f09b65a036cbec7

fix: typings for hooks

view details

push time in a day

PR opened fastify/fastify

fix: typings for hooks

This fixes #2439

Also moved DoneFuncWithErrOrRes to type and at top of file to be in line with HookHandlerDoneFunction

Checklist

+5 -8

0 comment

2 changed files

pr created time in a day

create barnchzekth/fastify

branch : fix_2439

created branch time in a day

issue commentfastify/fastify

Fastify must not mutate passed in options

What if instead of: https://github.com/fastify/fastify/blob/master/fastify.js#L51-L53 we do this:

function fastify (_options) {
  // Options validations
  let options = Object.assign({}, _options)
stalniy

comment created time in a day

push eventzekth/fastify

batuxd

commit sha fb5f56d051370cc10bad9c929b34df6e4d23d64e

Update Server.md (#2482) I was pulling my hairs because I was getting only one error from multiple invalid query parameters even though in docs it is explicitly said default config for ajv option allErrors is true. After spending some time decided to debug and found out https://github.com/fastify/fastify/blob/627096fbf9062e6fd9850df05834190966b5011a/lib/schema-compilers.js#L36 it's set to false in default setting to prevent dos attacks.

view details

Vincent LE GOFF

commit sha 955314d4b51175952f2e62167075cfa349e33434

fix: test slowness on windows (#2481) * fix: test slowness on windows * feat: switch to undici * feat: switch test to undici * fix: lint * fix: cleanup * feat: review * fix: bring back autocannon

view details

push time in a day

delete branch zekth/fastify

delete branch : fix_test

delete time in a day

push eventzekth/fastify

Vincent LE GOFF

commit sha 5d7a5239f199262faeda16dca0ad29303303ae9e

fix: bring back autocannon

view details

push time in a day

Pull request review commentfastify/fastify

fix: test slowness on windows

     "ajv-i18n": "^3.5.0",     "ajv-merge-patch": "^4.1.0",     "ajv-pack": "^0.3.1",-    "autocannon": "^6.0.0",

Sorry i only looked in tests. Will add.

zekth

comment created time in a day

push eventzekth/fastify

Vincent LE GOFF

commit sha 8dfcfe72ea1b2bc83a95ceb609f69439f5f2a9dc

feat: review

view details

push time in 2 days

Pull request review commentfastify/fastify

fix: test slowness on windows

 const t = require('tap') const test = t.test const Fastify = require('..')-const autocannon = require('autocannon')--// this tests on windows takes an unusually large amount of time.-// https://github.com/fastify/fastify/issues/2470-t.setTimeout(45000)+const { Client } = require('undici')  test('Should return 503 while closing - pipelining', t => {-  const fastify = Fastify()+  const fastify = Fastify({+    return503OnClosing: true+  })    fastify.get('/', (req, reply) => {     fastify.close()     reply.send({ hello: 'world' })   }) -  fastify.listen(0, err => {+  fastify.listen(0, async err => {     t.error(err) -    const instance = autocannon({-      url: 'http://localhost:' + fastify.server.address().port,-      pipelining: 1,-      connections: 1,-      amount: 10+    const instance = new Client('http://localhost:' + fastify.server.address().port, {+      pipelining: 1     })      const codes = [200, 503]-    instance.on('response', (client, statusCode) => {-      t.strictEqual(statusCode, codes.shift())-    })--    instance.on('done', () => {+    // eslint-disable-next-line no-unused-vars+    for (const _ of Array(codes.length)) {

fair point. Just this will be deleted:

      t.strictEqual(codes.length, 0)

Because the code array is not mutated anymore

zekth

comment created time in 2 days

pull request commentfastify/fastify

fix: test slowness on windows

I've pushed the implementation using undici.

zekth

comment created time in 2 days

push eventzekth/fastify

Vincent LE GOFF

commit sha 527a9d0ca3d6b3960b4e3a5f8c80cd327ab4033d

fix: cleanup

view details

push time in 2 days

push eventzekth/fastify

Vincent LE GOFF

commit sha f4bfd0a4ff24b25c12c227bea75bc53ad7e41e71

fix: lint

view details

push time in 2 days

push eventzekth/fastify

Vincent LE GOFF

commit sha 9e095ca9a6a82d60ecabac91ba451b367437dd01

feat: switch to undici

view details

Vincent LE GOFF

commit sha 1755d5e8196150fc0c8af975017bc9b28e203a55

feat: switch test to undici

view details

push time in 2 days

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 37066d4740447ddb4e34b4726c6d5600db31d36e

update-website

view details

push time in 2 days

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha f8cb3bebcaec1a77d759495d4330bd0b5a05fd87

Update catalog

view details

push time in 2 days

push eventkeycap-archivist/database

Database Bot

commit sha 736b4ee61f359472d72702979de718cd657d6312

[skip-ci] Database Synchronization

view details

push time in 2 days

pull request commentfastify/fastify

fix: test slowness on windows

I think the problem for this are not threads, but rather an I/O difference that cause a socket to stay alive and the test to not complete.

Indeed, after investigations i find on TCP viewer those behaviours: No Jobs: https://imgur.com/bFXnVty With Jobs: https://imgur.com/UkITwbX

So what we can observe is a slow TCP connection release. Isn't it an issue with concurrent autocannon ?

zekth

comment created time in 2 days

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 658c6eab4fa7c5f78416f236264d1e310abc7be7

update-website

view details

push time in 2 days

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha b9b1d0815176a4fbb28f17c49d24a685bb8159d9

Update catalog

view details

push time in 2 days

push eventkeycap-archivist/database

Database Bot

commit sha 7e7d8a253d648487a36953de36f1d0781679d84a

[skip-ci] Database Synchronization

view details

push time in 2 days

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 557b792ef7adf54c863b3f97c2f321e86a57c960

update-website

view details

push time in 2 days

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 882ac2bdc8c857ebe07988238027014c21af8bb6

Update catalog

view details

push time in 2 days

push eventkeycap-archivist/database

Database Bot

commit sha 9232788217bf7e08e2f6d2708461df967cb94f91

[skip-ci] Database Synchronization

view details

push time in 2 days

pull request commentfastify/fastify

fix: test slowness on windows

I don't know if the parallel tests are the solution here

Tests are parallel for the whole suite but not within a single file that's just it. Because here the arg -J is used on the tap command it ends up using all the CPUs available for the suite but allowing only one per file. Here we allow 2 for this specific file for this reason.

Doc:

The default jobs value for the command line runner is equal to the number of CPUs on your system,

Regarding the I/O waiting issue, we faced some problems like this on Deno on windows in another context.

zekth

comment created time in 2 days

pull request commentfastify/fastify

fix: test slowness on windows

The -J option is already in place:

https://github.com/fastify/fastify/blob/e4d8773421a00ff16290b8f83d7270e931c40513/package.json#L11

And it should mean that we are using all the core at disposal

Yes but based on the doc

Within a single test file, the default jobs value is 1, because you rarely want to run the functions within a given suite in parallel.

So regarding the comment of @jsumners we can do:

t.jobs = require('os').cpus().length
zekth

comment created time in 2 days

PR opened fastify/fastify

fix: test slowness on windows

fix: #2470

$ npx tap -J test/close-*.test.js
 PASS  test/close-pipelining.test.js 24 OK 15s

Looking at the doc, specifying jobs property seems to fix the issue : https://node-tap.org/docs/api/parallel-tests/#parallel-tests-from-the-api

Validated on my machine on W10

Checklist

+1 -3

0 comment

1 changed file

pr created time in 2 days

create barnchzekth/fastify

branch : fix_test

created branch time in 2 days

push eventzekth/fastify

Matteo Collina

commit sha 6493dbe90bebd2ce6a6a8d75e13c91b6e57fa55b

Fix broken tests due to fastify-plugin@2.1.0 (#2461)

view details

dependabot-preview[bot]

commit sha caa9cb5e3d698358043d393ea6307c127bf286b7

Bump x-xss-protection from 1.3.0 to 2.0.0 (#2459) Bumps [x-xss-protection](https://github.com/helmetjs/helmet) from 1.3.0 to 2.0.0. - [Release notes](https://github.com/helmetjs/helmet/releases) - [Changelog](https://github.com/helmetjs/helmet/blob/master/CHANGELOG.md) - [Commits](https://github.com/helmetjs/helmet/compare/v1.3.0...v2.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

dependabot-preview[bot]

commit sha 615fb9b0ef040df5bd872c1ba8e2595f2cb3a88b

Bump helmet from 3.23.3 to 4.0.0 (#2460) Bumps [helmet](https://github.com/helmetjs/helmet) from 3.23.3 to 4.0.0. - [Release notes](https://github.com/helmetjs/helmet/releases) - [Changelog](https://github.com/helmetjs/helmet/blob/master/CHANGELOG.md) - [Commits](https://github.com/helmetjs/helmet/compare/v3.23.3...v4.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

zhangwinning

commit sha ff886c7c54d9de1afed4e215d174279f3ad72385

add missing kSchemaVisited symbol var (#2456) * add missing kSchemaVisited symbol var * avoid repeated normalize schema test case * Update lib/symbols.js Co-authored-by: Manuel Spigolon <behemoth89@gmail.com> Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>

view details

Manuel Spigolon

commit sha dbfbb310cd03f46b734f8069e80181dc414942c2

fix schema lock in (#2463) * fix schema validator lock in * fix schema serializer lock in

view details

Kanitkorn Sujautra

commit sha 21578f56dea6bfd3de1c9a4df497fd535d174221

docs: add logger option in async/await example (#2465) The first example has this option and I think the async/await example should have it as well.

view details

Vincent LE GOFF

commit sha 8e2d008c450b29b39aff8aa127e0ed7a10775988

feat: add hook onTimeout (#2457)

view details

delvedor

commit sha f7a1ed3c892466c5bae7000eb1cbbfa3868d2e3b

Bumped v3.2.0

view details

dependabot-preview[bot]

commit sha 7f9b1b498e38ea8746990c2f7a45886841e3b4ab

Bump autocannon from 5.1.0 to 6.0.0 Bumps [autocannon](https://github.com/mcollina/autocannon) from 5.1.0 to 6.0.0. - [Release notes](https://github.com/mcollina/autocannon/releases) - [Commits](https://github.com/mcollina/autocannon/compare/v5.1.0...v6.0.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Rafael Gonzaga

commit sha caa15ae7affc224b1211b0ce7d4d273c01454eb0

update(package.json): add rafaelgss as member (#2464) * update(package.json): add rafaelgss as member * update(package): adjust contribuitors order by surname * update(README): add Rafael Gonzaga to core team

view details

Matteo Collina

commit sha 78594bfb8a94dcb34d21434a3a5b5b99899168cc

We have a discord! (#2473)

view details

Matteo Collina

commit sha 9be74e4cee9da45697fa073406d417dfd89ba6d4

docs: what to do to became a collaborator (#2468)

view details

Dustin Deus

commit sha eee6c8dac6959310703699ddee6fb512cab285c3

increase timeout (#2477) * increase timeout * fix require path

view details

zhangwinning

commit sha e02c80f95e13d2030aab8de03863212cc9a1f4cc

support unWritable props in the logger option (#2474) * support unWritable props in the logger option * Update lib/logger.js Co-authored-by: James Sumners <james@sumners.email> * Update lib/logger.js Co-authored-by: James Sumners <james@sumners.email> * optimise decide object logic Co-authored-by: James Sumners <james@sumners.email>

view details

Hans Klunder

commit sha 86e13640d00b81ae606f24f79af6e09215fafad2

fix hasContentTypeParser to include native types (#2450) * fix hasContentTypeParser include native types * minimal fix

view details

Giovanni Cardamone

commit sha e4d8773421a00ff16290b8f83d7270e931c40513

Update Ecosystem.md (#2479) * Update Ecosystem.md Hello, i create a simple extension that allow user to map some directory to automatic handle hierarchy and map it to urls. Currently I'm working on improve doc, but you can check it out here: https://github.com/GiovanniCardamone/fastify-autoroutes * Update Ecosystem.md Fixed name order, improving description and close sentence with .

view details

push time in 2 days

push eventkeycap-archivist/app

Vincent LE GOFF

commit sha c531384e055fc66038df07e819351466b47a189d

fix: tablemark

view details

push time in 2 days

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha fdb506ca6fb8bfc08481497a553c72158264261c

update-website

view details

push time in 2 days

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 9afab0427d777513ca547e61a6f54adf58c35997

Update catalog

view details

push time in 2 days

push eventkeycap-archivist/database

Database Bot

commit sha fa9f172348c70b36441f2f3db268df4078ebc2b5

[skip-ci] Database Synchronization

view details

push time in 2 days

push eventkeycap-archivist/app

Vincent LE GOFF

commit sha 29261183328e9d20af43b912cc3f85f4bafa147a

fix: operation Name

view details

push time in 2 days

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 9d2fc70fd6ffb9fc73ba1789a6dfe05a4abb5303

update-website

view details

push time in 2 days

push eventkeycap-archivist/website

mariodandrea

commit sha 41edd90d1b81306804cfb09397bdff7064bf3be4

Submit new cw 2 (#57) * fixed merge errors * Added upload file button in submit cw modal, submiting form broken * On submit form now posts formData to endpoint, added success/error alerts * Changed the sculpt name to a header * Modified submission fetch request * Fixed typo in src/layouts/sculpt.js Co-authored-by: Vincent LE GOFF <vince.legoff@gmail.com> Co-authored-by: Vincent LE GOFF <vince.legoff@gmail.com>

view details

push time in 2 days

PR merged keycap-archivist/website

Submit new cw 2

Added submit new colorway button to sculpt component. When pressed a modal opens allowing the user to upload a file and submit a colorway name.

Created a new branch because in first submit new cw branch old commits were mixed in.

+136 -3

0 comment

2 changed files

mariodandrea

pr closed time in 2 days

issue commentdenolib/awesome-deno

replace the modules listing with dynamic listings

This proposal could fit. What do you think @kevinkassimo @kt3k ?

balupton

comment created time in 2 days

Pull request review commentkeycap-archivist/website

Submit new cw 2

 const Maker = (props) => {     setStateWishlist(getWishlist());   }, []);   const cwList = selfOrder === true ? sculpt.colorways : sortBy(sculpt.colorways, (x) => x.name);++  const [showModal, setShowModal] = useState(false);++  const [showSuccessAlert, setShowSuccessAlert] = useState(false);+  const [showErrorAlert, setShowErrorAlert] = useState(false);+   return (     <Layout>+      {showSuccessAlert && (+        <Alert color="green" alertMessage="Colorway Successfully Submited" setAlert={setShowSuccessAlert} />
        <Alert color="green" alertMessage="Colorway Successfully Submitted" setAlert={setShowSuccessAlert} />
mariodandrea

comment created time in 3 days

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha e65ca5315de420744e0783e298669ab61c20357d

update-website

view details

push time in 3 days

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 9cd5f25c2191120399746f44243ffeeeab3f796a

Update catalog

view details

push time in 3 days

push eventkeycap-archivist/database

Database Bot

commit sha 60142c7d9d8f3991e4c0e4d9203e9fda5b9fbe05

[skip-ci] Database Synchronization

view details

push time in 3 days

Pull request review commentkeycap-archivist/website

Submit new cw 2

+import React, { useState, useRef } from 'react';+import Modal from '../modal';++const SubmitNewCwModal = (props) => {+  const [cwName, setCwName] = useState('');+  const [fileUploaded, setFileUploaded] = useState(false);+  const [uploadedPhoto, setUploadedPhoto] = useState(null);++  const hiddenFileInput = useRef(null);++  const handleClick = () => {+    hiddenFileInput.current.click();+  };++  const handleChange = (event) => {+    setFileUploaded(true);+    setUploadedPhoto(event.target.files[0]);+  };++  const submitForm = (maker, sculpt, cw, photo) => {+    const formData = new FormData();+    formData.append('file', photo);+    formData.append('maker', maker);+    formData.append('sculpt', sculpt);+    formData.append('colorway', cw);++    fetch('https://app.keycap-archivist.com/api/v2/submission', {+      method: 'POST',+      body: formData,+    }).catch((error) => {+      console.error('Error:', error);+      props.setErrorAlert(true);+    });++    props.setSuccessAlert(true);
    props.setSuccessAlert(true);
    fetch('https://app.keycap-archivist.com/api/v2/submission', {
      method: 'POST',
      body: formData,
    }).then(()=> { props.setSuccessAlert(true); }).catch((error) => {
      console.error('Error:', error);
      props.setErrorAlert(true);
    })
mariodandrea

comment created time in 3 days

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha 743dbc03308047372b0b6ab870eba25eb56b35c8

update-website

view details

push time in 4 days

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha d1b40a1cf2c84a3cf2b849e44bd62c1c881e5d80

Update catalog

view details

push time in 4 days

push eventkeycap-archivist/database

Database Bot

commit sha 5a674b61ec2757c651c50fc8cd55ebfcddafbc8e

[skip-ci] Database Synchronization

view details

push time in 4 days

issue commentfastify/fastify-cors

100% code coverage

I think this issue can be closed:

Suites:   2 passed, 2 of 2 completed
Asserts:  121 passed, of 121
Time:     1s
----------|----------|----------|----------|----------|-------------------|
File      |  % Stmts | % Branch |  % Funcs |  % Lines | Uncovered Line #s |
----------|----------|----------|----------|----------|-------------------|
All files |      100 |      100 |      100 |      100 |                   |
 index.js |      100 |      100 |      100 |      100 |                   |
 vary.js  |      100 |      100 |      100 |      100 |                   |
----------|----------|----------|----------|----------|-------------------|
mcollina

comment created time in 5 days

issue commentdenolib/awesome-deno

replace the modules listing with dynamic listings

This list is curated, examined, and categorized by hand

sorting by stars/downloads is not really a good way to promote really good resources

That's the point.

balupton

comment created time in 5 days

push eventkeycap-archivist/website-bin

Keycap Archivist Bot

commit sha ad6f4d4612a53162906ae5ee80d02a944e2ff515

update-website

view details

push time in 5 days

push eventkeycap-archivist/website

Keycap Archivist Bot

commit sha 55954e84ec0e9fe2a64fe661808f883c856279df

Update catalog

view details

push time in 5 days

push eventkeycap-archivist/database

Database Bot

commit sha abf27c88a50ea7cf17dc8c04347acbd6a2ced212

[skip-ci] Database Synchronization

view details

push time in 5 days

PR closed denolib/marked

add CI

Adding Github CI

+23 -2

1 comment

2 changed files

zekth

pr closed time in 5 days

Pull request review commentkeycap-archivist/website

Submit new cw

 const Maker = (props) => {           {maker.name}         </Link>       </div>-      <h2 className="text-3xl my-6">+      <h2 className="flex text-3xl my-6 justify-between">

This is not good because the h2 is meant to be descriptive for a title not embedding a button. You need to do a placehold for the title and the button tho

mariodandrea

comment created time in 5 days

more