profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/yvaucher/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Yannick Vaucher yvaucher @camptocamp Lausanne, CH

camptocamp/cubiscan 1

Cubiscan library

guewen/odoo 1

Odoo (formerly OpenERP). Open Source Business Apps.

camptocamp/docker-odoo-project-lasso 0

docker-odoo-project built with lasso lib

damdam-s/bank-statement-reconcile 0

Odoo Bank Statements Tasks (reconciliation, completion,...)

damdam-s/pyews 0

Open Sourced Python Wrapper for Microsoft Exchange Web Services (EWS)

Pull request review commentodoo/odoo

[FIX] stock: Fixed the singleton error

 def _compute_nbr_reordering_rules(self):      @api.onchange('tracking')     def onchange_tracking(self):-        if self.tracking != "none" and self.qty_available > 0:-            return {-                'warning': {-                    'title': _('Warning!'),-                    'message': _("You have product(s) in stock that have no lot/serial number. You can assign lot/serial numbers by doing an inventory adjustment.")}}+        for product in self:+            if product.tracking != "none" and product.qty_available > 0:+                return {+                    'warning': {+                        'title': _('Warning!'),+                        'message': _("You have product(s) in stock that have no lot/serial number. You can assign lot/serial numbers by doing an inventory adjustment.")}}

You probably want to display which products in the warning message to be user friendly.

vst-odoo

comment created time in 17 days

PullRequestReviewEvent

push eventyvaucher/l10n-switzerland

Maksym Yankin

commit sha cd69b47f1dd5affee52e8e5a2f34f3366f7386c8

[IMP] Add QR-IBAN search to get propper bank account during import

view details

Yannick Vaucher

commit sha 34275c39b625bcca5ea23a006fc2934d29ea9975

Merge pull request #10 from yankinmax/10.0_imp_l10n_ch_qr_bill_scan [IMP] Add QR-IBAN search to get proper bank account during import

view details

push time in 18 days

PR merged yvaucher/l10n-switzerland

[IMP] Add QR-IBAN search to get proper bank account during import

Suppose we have l10n_ch_qr_iban field (QR-IBAN) on res.partner.bank model. Then during Importing Vendor bill with passing Invoice scan data we are searching only on existing Account/IBAN Numbers, which are unique. This is correct. But, we also can have QR-IBAN's with the same IBAN and they are not handled at the moment, so we get on Invoice not correct Bank account. This improvement is aimed to do:

  • first search on existing QR-IBAN's
  • if found use that Bank account to prepare Invoice data
  • if found several (as QR-IBAN isn't unique field) post message in chatter informing user about that fact
  • if not found super function will be called to proceed on existing implementation
+58 -5

0 comment

4 changed files

yankinmax

pr closed time in 18 days

PullRequestReviewEvent

push eventcamptocamp/web

Yannick Vaucher

commit sha 1278bde5aa586f8bf683c75e9ee1016b83f79a7e

Merge commit 'refs/pull/1357/head' of github.com:OCA/web into merge-branch-2543-test-pip-7be930c8

view details

Yannick Vaucher

commit sha aa81169747b37c4444ca86a4f7862cd4f318b875

Travis: exclude new branch from build

view details

Yannick Vaucher

commit sha cf1e40c8800906f5309ffccecd1f21651b0e992b

Add setup.py

view details

push time in 18 days

pull request commentOCA/l10n-switzerland

[12.0][BACKPORT] l10n_ch_qriban

/ocabot merge nobump

Let's try it

yvaucher

comment created time in 18 days

pull request commentOCA/edi

[FIX] Remove partner_bank_id after play_onchanges

Usually you want the "Create bank if not found" option activated.

But in case it's not (it's not by default IIRC), this change seems safer when bank account changes.

What do you think @alexis-via ?

yankinmax

comment created time in 18 days

PullRequestReviewEvent

Pull request review commentyvaucher/l10n-switzerland

[IMP] Add QR-IBAN search to get proper bank account during import

 # -*- coding: utf-8 -*--# Copyright 2020 Camptocamp+# Copyright 2021 Camptocamp
# Copyright 2020-2021 Camptocamp
yankinmax

comment created time in 18 days

Pull request review commentyvaucher/l10n-switzerland

[IMP] Add QR-IBAN search to get proper bank account during import

 # -*- coding: utf-8 -*--# Copyright 2020 Camptocamp+# Copyright 2021 Camptocamp # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl).-from odoo import api, models++from odoo import _, api, models++from odoo.addons.base_iban.models.res_partner_bank import (+    normalize_iban, pretty_iban+)   class BusinessDocumentImport(models.AbstractModel):-    _name = "business.document.import"-    _description = "Common methods to import business documents"+    _inherit = "business.document.import"      @api.model     def _hook_match_partner(         self, partner_dict, chatter_msg, domain, partner_type_label     ):         # TODO search by iban         return False++    @api.model+    def _match_partner_bank(+            self, partner, iban, bic, chatter_msg, create_if_not_found=False):+        '''Bank accounts with provided QR-IBAN+           should be found before Account/IBAN Number+        '''+        assert iban, 'iban is a required arg'+        assert partner, 'partner is a required arg'+        rpbo = self.env['res.partner.bank']+        partner = partner.commercial_partner_id+        iban = iban.replace(' ', '').upper()+        try:+            rpbo._validate_qr_iban(iban)+        except:+            chatter_msg.append(_(+                "IBAN <b>%s</b> is not valid, so it has been ignored.") % iban)+            return False+        company_id = self._context.get('force_company') or\

Please use parenthesis and not \.

yankinmax

comment created time in 18 days

PullRequestReviewEvent
MemberEvent

created repositorycamptocamp/quickpack-client

Python Client for Quickpac API generated client (Swagger codegen)

created time in 18 days

push eventcamptocamp/web

Yannick Vaucher

commit sha 62e8e8e8abb86137fb424bc07f93dba8ca8bb5ba

Merge commit 'refs/pull/1357/head' of github.com:OCA/web into merge-branch-2543-bssmwb-41-ref_revision_exporter-fc1fbf12

view details

Yannick Vaucher

commit sha 7920523b0534d4eae4633b14936d0aea92b1f38f

Travis: exclude new branch from build

view details

push time in 18 days

push eventcamptocamp/web

Yannick Vaucher

commit sha 0172c3934d40ff4f62f5109d36c604885fa61e06

Merge commit 'refs/pull/1357/head' of github.com:OCA/web into merge-branch-2543-bssmwb-41-ref_revision_exporter-fc1fbf12

view details

Yannick Vaucher

commit sha 3e226b88f17173aa6b86e4017d0bceffdd03213a

Travis: exclude new branch from build

view details

push time in 18 days

create barnchcamptocamp/web

branch : merge-branch-2543-test-pip-7be930c8

created branch time in 18 days

create barnchcamptocamp/sale-workflow

branch : merge-branch-1305-test-pip-1fcf4055

created branch time in 18 days

issue closedcamptocamp/docker-odoo-project

Question: best way to run Odoo 12.0 on Python 3.6 or 3.7, Debian Strech aging...

Hello,

The current Docker image for Odoo 12.0 run Python 3.5.3 on Debian 9 - Strech.

But:

  • Python 3.5 has reached end of life (https://www.python.org/downloads/release/python-353/)
  • Security updates have been discontinued on Debian Stretch as of July 6th, 2020 (https://www.debian.org/releases/stretch/) May be not so much of an issue considering it still has LTS support (https://wiki.debian.org/LTS) and it is containerized so few things are exposed.

And also, I have a requirement to run Odoo 12 on Python 3.6 or 3.7 to use Data Classes (available on 3.6 via backport).

Considering all this what would you recommend?

  1. Run Odoo 12.0 on the Odoo 13.0 Docker image? (does it work well?)
  2. Upgrade the current Odoo 12.0 Image to Debian Buster?
  3. Other like compile Python 3.7 on Debian Strech (this is easy but this would probably mean fork the image instead of reusing it)

closed time in 18 days

rvalyi

push eventcamptocamp/docker-odoo-project

Yannick Vaucher

commit sha 83fa230a654c8e2a0510cf29fac53c63cba5a9d1

Bump Odoo requirements * Bump jinja2 to fix security issue * Bump lxml to fix security issue * Bump Pillow to fix security issue * Bump PyYAML to fix security issue

view details

Yannick Vaucher

commit sha 78e502a18bf1cc5de834bc7c2daf66d61d1a4588

[12.0-buster] Update Marabunta to 0.10.5

view details

Yannick Vaucher

commit sha 9ef394d6eb4083d6c3190b10b0c140ca8f98796c

Merge pull request #158 from yvaucher/20210408-bump-dependencies bump dependencies

view details

push time in 18 days

PR merged camptocamp/docker-odoo-project

bump dependencies

This includes security patches.

+173 -92

0 comment

12 changed files

yvaucher

pr closed time in 18 days

issue commentOCA/social

Migration to version 14.0

Updated with what has been migrated til now.

OCA-git-bot

comment created time in 18 days

Pull request review commentOCA/multi-company

[14.0] add stock_intercompany module

+from odoo import api, fields, models++class StockPicking(models.Model):+    _inherit = "stock.picking"+++    #override of method from stock module+    def button_validate(self):

Better to move this part in a dedicated method + override _action_done insead of button_validate

ajaniszewska-dev

comment created time in 19 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentOCA/multi-company

[14.0] add stock_intercompany module

+from odoo import api, fields, models++class StockPicking(models.Model):+    _inherit = "stock.picking"+++    #override of method from stock module+    def button_validate(self):+        companies = self.env['res.company'].sudo().search([])+        partners = {cp.partner_id: cp for cp in companies}++        for picking in self:+            if picking.partner_id in partners.keys():+                company = partners[picking.partner_id]+                warehouse = self.env["stock.warehouse"].sudo().search([('company_id','=',company.id)], limit=1)+                vals = {+                    'company_id': company.id,+                    'picking_type_id': company.intercompany_in_type_id.id  or warehouse.in_type_id.id,+                    'state':'draft',+                    'location_id': self.env['stock.location'].sudo().search([('name','=','Vendors')]).id,+                    'location_dest_id': self.env['stock.location'].sudo().search([('name','=','Stock'),('company_id','=',company.id)]).id,+                }++                new_picking_vals = picking.sudo().copy_data(default=vals)+                reception_picking = self.env['stock.picking'].sudo().create(new_picking_vals)+                reception_picking.action_confirm()+        return super(StockPicking,self).button_validate()

Would make more sense to move the super prior to the creation of the reception picking.

ajaniszewska-dev

comment created time in 19 days

PullRequestReviewEvent

Pull request review commentOCA/multi-company

[14.0] add stock_intercompany module

+from odoo import api, fields, models++class StockPicking(models.Model):+    _inherit = "stock.picking"+++    #override of method from stock module+    def button_validate(self):+        companies = self.env['res.company'].sudo().search([])+        partners = {cp.partner_id: cp for cp in companies}++        for picking in self:+            if picking.partner_id in partners.keys():+                company = partners[picking.partner_id]+                warehouse = self.env["stock.warehouse"].sudo().search([('company_id','=',company.id)], limit=1)+                vals = {+                    'company_id': company.id,+                    'picking_type_id': company.intercompany_in_type_id.id  or warehouse.in_type_id.id,+                    'state':'draft',+                    'location_id': self.env['stock.location'].sudo().search([('name','=','Vendors')]).id,+                    'location_dest_id': self.env['stock.location'].sudo().search([('name','=','Stock'),('company_id','=',company.id)]).id,+                }++                new_picking_vals = picking.sudo().copy_data(default=vals)+                reception_picking = self.env['stock.picking'].sudo().create(new_picking_vals)+                reception_picking.action_confirm()

Probably better to keep the reception picking in draft so the destination company user can handle in with more options.

ajaniszewska-dev

comment created time in 19 days

PullRequestReviewEvent