profile
viewpoint
Yorkie Liu yorkie Learning & exploring

alibaba/pipcook 812

Front-End Algorithm Engineering Platform based on Tensorflow.js

Southern/node-x509 94

Simple X509 certificate parser.

cocos-creator/firedoc 70

API Doc generator based on YUIDoc

koajs/koa-range 40

range request implementation for koa, see http://tools.ietf.org/html/rfc7233

macacajs/macaca-puppeteer 36

Macaca puppeteer driver

rvagg/archived-servertest 31

A simple HTTP server testing tool

cocos-creator-packages/ui-kit 30

The UI kit used in Editor Framework

cocos-creator-packages/ui-grid 7

A grid scale widget implemented by pixi graphcis module (WebGL)

weflex/react-touchable-tabular 4

A React Component to used to view tabular data based on facebook/fixed-data-table

cocos-creator/firedoc-theme-notab 3

A new theme without tab in navigation sidebar

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

   },   "publishConfig": {     "access": "public"+  },+  "pipcook": {+    "category": "modelDefine",+    "datatype": "image",+    "method": "detect"+  },+  "conda": {+    "python": "3.7",+    "dependencies": {+      "torch": "*",+      "torchvision": "*"

Supported at https://github.com/alibaba/pipcook/commit/775b1c496f0b658f50152f32f98fce3fcd12bd04#diff-32df0838fb24296b5d38739a7cf1b1fdR40 :)

yorkie

comment created time in 4 hours

push eventalibaba/pipcook

yorkie

commit sha 775b1c496f0b658f50152f32f98fce3fcd12bd04

support git+http url for installing python package

view details

push time in 4 hours

push eventalibaba/pipcook

yorkie

commit sha a974a5680ca1d09fb04d2d941125d498e177e016

optimize the costa client

view details

push time in 4 hours

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

   },   "publishConfig": {     "access": "public"+  },+  "pipcook": {+    "category": "modelDefine",+    "datatype": "image",+    "method": "detect"+  },+  "conda": {+    "python": "3.7",+    "dependencies": {+      "torch": "*",+      "torchvision": "*"

Will support :)

yorkie

comment created time in 4 hours

push eventalibaba/pipcook

yorkie

commit sha ea1d0f6e1c69db0daa2a091f6bc9a80d812e6af8

should destroy the runnable after failure

view details

push time in 12 hours

push eventalibaba/pipcook

yorkie

commit sha 640b9f2945b866c0567efab4d7d1acbd94720841

remove unused logs

view details

push time in 12 hours

push eventalibaba/pipcook

yorkie

commit sha 2c2f05562a99a79f09d86416ec982b6d123740a0

fixup

view details

push time in 12 hours

push eventalibaba/pipcook

yorkie

commit sha 33ba09a7a1f3f38dc394e51fd51b8ff6dd3f7f24

handle dataProcess in client

view details

push time in 13 hours

push eventalibaba/pipcook

yorkie

commit sha cb028d3e2c5a67d7c1f01d43d424182a47adb444

update other plugin package configs

view details

push time in 15 hours

push eventalibaba/pipcook

yorkie

commit sha e7784ede53070f211f61bbf4b7de7b002285c977

fixup

view details

push time in 17 hours

push eventalibaba/pipcook

yorkie

commit sha e33a95b0ecf8f68a65a8d9ede053af9c905ef0b1

support --tuna for plugin installation and run pipelines

view details

push time in 18 hours

push eventalibaba/pipcook

yorkie

commit sha 8c9991ac6f1ad195fb6da0053ad2333d504a070d

fixup

view details

push time in 19 hours

push eventalibaba/pipcook

yorkie

commit sha 6945cf01f4ebadf9e1bd5d25e37a6570d17959ac

fix style nits

view details

push time in 19 hours

push eventalibaba/pipcook

yorkie

commit sha a51cbbc34c439ff8d324395d378609cb1eb64935

fixup

view details

push time in 20 hours

push eventalibaba/pipcook

yorkie

commit sha ab86ebb749ff62d708c08caeb24afefb9a1c4356

reduce the ci jobs

view details

yorkie

commit sha ef2735da0175bd8daf669e6d3c96bd561cce7cff

fixup

view details

push time in 21 hours

push eventalibaba/pipcook

yorkie

commit sha 2f8989e2b25bca1a4be6658005292b76f31346a7

fix cwd

view details

push time in a day

push eventalibaba/pipcook

yorkie

commit sha 61bda286483d83bf946391ad8a5f9d56ed698d53

fix ci jobs

view details

push time in a day

push eventalibaba/pipcook

yorkie

commit sha a01881800250f8afa06e344b32406a2feac15f85

cli: pipcook daemon is working, remove egg-scripts

view details

push time in a day

push eventalibaba/pipcook

yorkie

commit sha 4f54dfdd3ec8cc3708da4f56c8247385483b93f4

update

view details

push time in a day

push eventalibaba/pipcook

yorkie

commit sha 3aba1dc4847de3833b4714955087bdec0227da6f

daemon: use single mode to speedup bootstrap and shutdown

view details

push time in a day

push eventalibaba/pipcook

yorkie

commit sha f057d7f59389f2a7a8bf944146ddc1b449cf3e65

remove unused commands

view details

push time in a day

push eventalibaba/pipcook

yorkie

commit sha 5ad67aef0de901fa2cc9b8a29968c00e1c766f52

fix scripts

view details

push time in a day

push eventalibaba/pipcook

yorkie

commit sha 1e34b220f9157441997a879fe775f776a22b7416

catch plugin error

view details

push time in 2 days

push eventalibaba/pipcook

yorkie

commit sha c665c3269449eca14c4211f0716409f7ff758a4a

cleanup

view details

push time in 2 days

push eventalibaba/pipcook

yorkie

commit sha 7a30bdff5d9f5fb214adc6be77fc4b6aab7178c3

fixup

view details

push time in 2 days

push eventalibaba/pipcook

yorkie

commit sha a5640ad6a533ee75793ba56815db7b16c9d77807

fix nits

view details

push time in 2 days

push eventalibaba/pipcook

yorkie

commit sha dc411d77db54a74ac5e13c510ec6fe44aff2d45b

fixup

view details

push time in 2 days

push eventalibaba/pipcook

yorkie

commit sha 84ba3dc88a8b87b91e66cfccb87deaf61ae6d6fe

cleanup

view details

push time in 2 days

push eventalibaba/pipcook

yorkie

commit sha 928b7cd568bc13a82f58437bbde9fcf5e28f1b20

add constants

view details

push time in 2 days

push eventalibaba/pipcook

yorkie

commit sha d5bf3b11f231130640fe7e285febd55c65860002

support plugin list

view details

push time in 2 days

push eventalibaba/pipcook

yorkie

commit sha b9160d406a020818887224ccf45ffe66ace1dd1d

support persisted plugins

view details

push time in 2 days

delete branch yorkie/midway

delete branch : patch-2

delete time in 2 days

push eventalibaba/pipcook

yorkie

commit sha af7d7035c60dac1dca87db797e903f86c7b5600f

deploy: e4249b495ccd62cb83451db4528c0612e569e3c7

view details

push time in 2 days

pull request commentalibaba/pipcook

Boa: 将模块名称由硬编码修改为 NODE_GYP_MODULE_NAME 宏

@jabez128 Thanks for your contribution, merged :p

jabez128

comment created time in 2 days

push eventalibaba/pipcook

haoran

commit sha e4249b495ccd62cb83451db4528c0612e569e3c7

boa: use recommended NODE_GYP_MODULE_NAME as module name (#197) When building addons with node-gyp, using the macro NODE_GYP_MODULE_NAME as the first parameter of NODE_MODULE() will ensure that the name of the final binary will be passed to NODE_MODULE().

view details

push time in 2 days

PR merged alibaba/pipcook

Boa: 将模块名称由硬编码修改为 NODE_GYP_MODULE_NAME 宏 boa

将模块名称由硬编码修改为NODE_GYP_MODULE_NAME宏,确保会将最终二进制文件的名称传给 NODE_MODULE()

+1 -1

3 comments

1 changed file

jabez128

pr closed time in 2 days

pull request commentalibaba/pipcook

将模块名称由硬编码修改为NODE_GYP_MODULE_NAME宏

When building addons with node-gyp, using the macro NODE_GYP_MODULE_NAME as the first parameter of NODE_MODULE() will ensure that the name of the final binary will be passed to NODE_MODULE().

Thank you @jabez128, may I ask you to sign our CLA?

谢谢, 可以签一下我们的 CLA 吗?

jabez128

comment created time in 2 days

startedanse1/sqlsmith

started time in 2 days

push eventalibaba/pipcook

yorkie

commit sha c1e6e1bfc2e2696cc3943267d94659fe85089a8c

fixup

view details

push time in 2 days

pull request commentalibaba/pipcook

core: add costa and integrate to daemon

SSE is really such fit with our needs, it's lightweight and standardized, which is supported both on Web and Node.js, so I think we will moved our updates to SSE in this PR later:

  1. daemon logs includes.
  2. daemon state updates from a request.
yorkie

comment created time in 2 days

push eventalibaba/pipcook

yorkie

commit sha 87f2562d7861808241b51512fd66a5d7fc932eb1

fixup

view details

push time in 3 days

pull request commentalibaba/pipcook

core: add costa and integrate to daemon

Supported the server-sent events via this library: https://github.com/EventSource/eventsource. And our implementations are:

  • client(cli): https://github.com/alibaba/pipcook/blob/create/plugin-runtime/packages/cli/src/actions/start.ts#L37-L56
  • server(daemon): https://github.com/alibaba/pipcook/blob/create/plugin-runtime/packages/daemon/src/app/controller/job.ts#L48-L68

And note that SSE on server-side requires the method to be GET only.

yorkie

comment created time in 3 days

push eventalibaba/pipcook

yorkie

commit sha b386daaa39fc4a82b3bb86a27159df59e01ede40

fixup

view details

push time in 3 days

push eventalibaba/pipcook

yorkie

commit sha 0a986172424769f74a94d1034a1a2b8d8ac49b2a

add sse and eventsource for serving updates

view details

push time in 3 days

pull request commentalibaba/pipcook

core: add costa and integrate to daemon

It seems that only package.json for text-classifaction has 'pipcook' field. And costa will check this filed existence.

Yes, this is just for reviewing only, I will update other plugins when we are ready to land :)

yorkie

comment created time in 3 days

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

+import path from 'path';+import { execSync as exec } from 'child_process';+import fse from 'fs-extra';+import ora from 'ora';+import { prompt } from 'inquirer';+import { sync } from 'command-exists';+import * as os from 'os';++import { InitCommandHandler } from '../types';+import { optionalNpmClients, daemonPackage, boardPackage } from '../config';++const spinner = ora();+const NPM_PUBLIC_REGISTRY = 'https://registry.npmjs.org/';++function npmInstall(npmClient: string, name: string, beta: boolean, cwd: string, env: NodeJS.ProcessEnv) {+  if (beta) {+    name += '@beta';+  }+  const command = `${npmClient} install ${name} --registry ${NPM_PUBLIC_REGISTRY}`;+  console.info(`exec ${command}`);+  return exec(command, { cwd, env, stdio: 'inherit' });+}++/**+ * install all dependencies of pipcook into working dir+ */+const init: InitCommandHandler = async ({ client, beta, tuna }) => {+  let npmClient = 'npm';+  const npmInstallEnvs = Object.assign({}, process.env);+  if (tuna) {+    npmInstallEnvs.BOA_CONDA_INDEX = 'https://pypi.tuna.tsinghua.edu.cn/simple';+    npmInstallEnvs.BOA_CONDA_MIRROR = 'https://mirrors.tuna.tsinghua.edu.cn/anaconda/miniconda';+  }+  if (client) {+    npmClient = client;+    if (!optionalNpmClients.includes(npmClient)) {+      spinner.fail(`invalid npm client: ${npmClient}.`);+      return process.exit(1);+    }+  } else {+    const clientChoices = [];+    for (const npmClient of optionalNpmClients) {+      if (sync(npmClient)) {+        clientChoices.push(npmClient);+      }+    }++    if (clientChoices.length === 1) {+      npmClient = clientChoices[0];+    } else if (clientChoices.length > 1) {+      const answer = await prompt([+        {+          type: 'list',+          name: 'client',+          message: 'which client do you want to use?',+          choices: clientChoices+        }+      ]);+      npmClient = answer.client;+    } else {+      spinner.fail(`no npm client detected`);+      return process.exit(1);+    }+  }++  // Install the daemon and pipboard.+  // use ~/.pipcook as PIPCOOK_DIR+  const PIPCOOK_DIR = path.join(os.homedir(), '.pipcook');+  const DAEMON_DIR = path.join(PIPCOOK_DIR, 'server');+  const BOARD_DIR = path.join(PIPCOOK_DIR, 'pipboard');++  try {+    await fse.ensureDir(DAEMON_DIR);+    await fse.ensureDir(BOARD_DIR);+    npmInstall(npmClient, daemonPackage, beta, DAEMON_DIR, npmInstallEnvs);

Ok, we should remove the tnpm on our community edition :)

yorkie

comment created time in 3 days

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

+import path from 'path';+import { execSync as exec } from 'child_process';+import fse from 'fs-extra';+import ora from 'ora';+import { prompt } from 'inquirer';+import { sync } from 'command-exists';+import * as os from 'os';++import { InitCommandHandler } from '../types';+import { optionalNpmClients, daemonPackage, boardPackage } from '../config';++const spinner = ora();+const NPM_PUBLIC_REGISTRY = 'https://registry.npmjs.org/';++function npmInstall(npmClient: string, name: string, beta: boolean, cwd: string, env: NodeJS.ProcessEnv) {+  if (beta) {+    name += '@beta';+  }+  const command = `${npmClient} install ${name} --registry ${NPM_PUBLIC_REGISTRY}`;+  console.info(`exec ${command}`);+  return exec(command, { cwd, env, stdio: 'inherit' });+}++/**+ * install all dependencies of pipcook into working dir+ */+const init: InitCommandHandler = async ({ client, beta, tuna }) => {+  let npmClient = 'npm';+  const npmInstallEnvs = Object.assign({}, process.env);+  if (tuna) {+    npmInstallEnvs.BOA_CONDA_INDEX = 'https://pypi.tuna.tsinghua.edu.cn/simple';+    npmInstallEnvs.BOA_CONDA_MIRROR = 'https://mirrors.tuna.tsinghua.edu.cn/anaconda/miniconda';+  }+  if (client) {+    npmClient = client;+    if (!optionalNpmClients.includes(npmClient)) {+      spinner.fail(`invalid npm client: ${npmClient}.`);+      return process.exit(1);+    }+  } else {+    const clientChoices = [];+    for (const npmClient of optionalNpmClients) {+      if (sync(npmClient)) {+        clientChoices.push(npmClient);+      }+    }++    if (clientChoices.length === 1) {+      npmClient = clientChoices[0];+    } else if (clientChoices.length > 1) {+      const answer = await prompt([+        {+          type: 'list',+          name: 'client',+          message: 'which client do you want to use?',+          choices: clientChoices+        }+      ]);+      npmClient = answer.client;+    } else {+      spinner.fail(`no npm client detected`);+      return process.exit(1);+    }+  }++  // Install the daemon and pipboard.+  // use ~/.pipcook as PIPCOOK_DIR+  const PIPCOOK_DIR = path.join(os.homedir(), '.pipcook');+  const DAEMON_DIR = path.join(PIPCOOK_DIR, 'server');+  const BOARD_DIR = path.join(PIPCOOK_DIR, 'pipboard');++  try {+    await fse.ensureDir(DAEMON_DIR);+    await fse.ensureDir(BOARD_DIR);+    npmInstall(npmClient, daemonPackage, beta, DAEMON_DIR, npmInstallEnvs);

Do we need to avoid tnpm?

yorkie

comment created time in 3 days

push eventalibaba/pipcook

yorkie

commit sha 4101f6644d0ce4d5e1bd8479599528bab42f08ba

fix deps

view details

push time in 3 days

push eventalibaba/pipcook

yorkie

commit sha 08eaf7309a56cc158b140efdcea3e403cd73696a

fixup

view details

push time in 3 days

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

 export const processPredictData = function (data: any, all_words_list_path: stri };  export const save_all_words_list = function(feature_words: any, filepath: string) {-  pickle.dump(feature_words, open(filepath, 'wb'));-};--export const getBayesModel = function() {-  return MultinomialNB();+  return boa.with(open(filepath, 'wb'), (f: any) => {+    return pickle.dump(feature_words, f);+  }); }; -export const saveBayesModel = function(classifier: any, filepath: string) {-  pickle.dump(classifier, open(filepath, 'wb'));+export const saveBayesModel = async function(classifier: any, filepath: string) {

boa.with returns a Promise object, so it might be reasonable as async, or specify the returned value as Promise.

yorkie

comment created time in 3 days

push eventalibaba/pipcook

yorkie

commit sha 0de288456dba6a37964e8ded4470207a190f594f

cli: complete pipcook subcommands

view details

push time in 4 days

pull request commentalibaba/pipcook

core: add costa and integrate to daemon

I marked this as ready for review, and this implements the following functions finally:

  • add a new module "@pipcook/costa" as the plugin plugin, which provide the runtime and managing packages.
  • support plugin management in daemon.
  • support plugin management in cli.
yorkie

comment created time in 4 days

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

 numpy==1.17.4 jieba==0.42.1-sklearn==0.0\ No newline at end of file+sklearn==0.0

Okay, changed to scikit-learn@0.23.1.

yorkie

comment created time in 4 days

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

 function getIdOrName(id: string): QueryParams {   return validate(id) as boolean ? { id } : { name: id }; } +function execAsync(cmd: string, opts: ExecOptions): Promise<string> {+  return new Promise((resolve, reject): void => {+    exec(cmd, opts, (err: ExecException, stdout: string, stderr: string) => {+      err == null ? resolve(stdout) : reject(err);

Resolved, thank you :)

yorkie

comment created time in 4 days

push eventalibaba/pipcook

yorkie

commit sha fe75ba638dcba7dc8dd1d04f97889c3a4235f2d4

add support for model load

view details

push time in 4 days

push eventalibaba/pipcook

yorkie

commit sha c39140185b85db36abdb5b21856abd093de4a685

remove unused variable

view details

push time in 5 days

push eventalibaba/pipcook

yorkie

commit sha 91a8dbb717408b958879a4f3be7ab68a954c88ee

fix nits

view details

push time in 5 days

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

 function getIdOrName(id: string): QueryParams {   return validate(id) as boolean ? { id } : { name: id }; } +function execAsync(cmd: string, opts: ExecOptions): Promise<string> {+  return new Promise((resolve, reject): void => {+    exec(cmd, opts, (err: ExecException, stdout: string, stderr: string) => {+      err == null ? resolve(stdout) : reject(err);

I don't think it is necessary, you can explain what is wrong with the current way.

yorkie

comment created time in 5 days

Pull request review commentalibaba/pipcook

core: add costa and integrate to daemon

 function getIdOrName(id: string): QueryParams {   return validate(id) as boolean ? { id } : { name: id }; } +function execAsync(cmd: string, opts: ExecOptions): Promise<string> {+  return new Promise((resolve, reject): void => {+    exec(cmd, opts, (err: ExecException, stdout: string, stderr: string) => {+      err == null ? resolve(stdout) : reject(err);

This is an incorrect expression, we should not resolve when there is no errors.

yorkie

comment created time in 5 days

push eventalibaba/pipcook

yorkie

commit sha aee68995fb35c8f4e0e80b3dc32e44659a7e9816

fix lint errors

view details

push time in 6 days

push eventalibaba/pipcook

yorkie

commit sha d777767bb4fe7c0191758ddf9a8cd2622c3490af

fix run_pipeline.sh

view details

push time in 6 days

push eventalibaba/pipcook

yorkie

commit sha ecac366dcff327fc36ac4bf08093076deecd3d96

add logs into generated project

view details

push time in 6 days

push eventalibaba/pipcook

yorkie

commit sha 2da8706f6681b1db9628a6a6530f50c39b0177ed

cleanup

view details

push time in 6 days

push eventalibaba/pipcook

yorkie

commit sha 9899eb778f1469f72b17806d121ea469d958fb14

remove unused code

view details

push time in 6 days

push eventalibaba/pipcook

yorkie

commit sha 757702695dc0b82f5c97c2169d5df10968e4ad1f

fix promise turn

view details

push time in 6 days

push eventalibaba/pipcook

yorkie

commit sha 92eac4fe29a80256ba23e48d8054059fdb5fd366

deploy is working

view details

push time in 6 days

pull request commentalibaba/pipcook

meta: remove sync function.

See https://github.com/alibaba/pipcook/pull/194/checks?check_run_id=699694385, it's:

##[error]src/commands/devPlugin.ts(31,34): error TS2554: Expected 2 arguments, but got 1.
##[error]src/commands/start.ts(19,29): error TS2554: Expected 2 arguments, but got 1.
##[error]src/commands/index.ts(69,19): error TS2322: Type 'Promise<{ stdout: string; stderr: string; }>' is not assignable to type 'void | Promise<void>'.
  Type 'Promise<{ stdout: string; stderr: string; }>' is not assignable to type 'Promise<void>'.
    Type '{ stdout: string; stderr: string; }' is not assignable to type 'void'.
Txiaozhe

comment created time in 6 days

push eventalibaba/pipcook

yorkie

commit sha c885fa9a0d4bafe6a16840aea657d7ea4a7d8d11

pipeline is working

view details

push time in 6 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

 import Fastify from 'fastify'; import path from 'path'; import ora from 'ora'; import childProcess from 'child_process';-import { constants } from '@pipcook/pipcook-core';+import { PIPCOOK_LOGS } from '@pipcook/pipcook-utils';

As I have thought at https://github.com/alibaba/pipcook/pull/195#discussion_r429023922, if the core is used internally, it depends on if we need to provide these paths to plugin developers.

utkobe

comment created time in 6 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

     "fs-extra": "^8.1.0",     "glob": "^7.1.6",     "glob-promise": "^3.4.0",-    "uuid": "^7.0.2"+    "uuid": "^7.0.2",+    "@pipcook/pipcook-utils": "^0.5.0"

IMO, the core will be our internal lib, and we need to keep fucking simple for plugin developers.

utkobe

comment created time in 6 days

push eventalibaba/pipcook

yorkie

commit sha 652e9963e2a5b283b9e89d482f4030db1a313972

deploy: ba10f3403753016ecad6b4e484a82c163959e9b7

view details

push time in 7 days

push eventalibaba/pipcook

Ives 泽阳

commit sha ba10f3403753016ecad6b4e484a82c163959e9b7

boa: modify the Python path protocol to "py:" (#196)

view details

push time in 7 days

PR merged alibaba/pipcook

boa: Modify the Python path protocol to py: boa

With simple py: protocol to transfer between hook.

+3 -4

2 comments

1 changed file

rickyes

pr closed time in 7 days

pull request commentalibaba/pipcook

boa: Modify the Python path protocol to py:

I remember that Node.js will check the protocol in node and file?

rickyes

comment created time in 7 days

push eventalibaba/pipcook

yorkie

commit sha 4a05fde6af3572afb9f2e50d67174ba140e48f7a

fixup

view details

push time in 7 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

+{+  "name": "@pipcook/pipcook-utils",
  "name": "@pipcook/utils",
utkobe

comment created time in 7 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

     "fs-extra": "^8.1.0",     "glob": "^7.1.6",     "glob-promise": "^3.4.0",-    "uuid": "^7.0.2"+    "uuid": "^7.0.2",+    "@pipcook/pipcook-utils": "^0.5.0"

IMO the plugin won't depend on core.

utkobe

comment created time in 7 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

     "uuid": "^8.0.0",     "uuid-validate": "^0.0.3",     "@pipcook/pipcook-core": "^0.5.16",+    "@pipcook/pipcook-utils": "^0.5.0",
    "@pipcook/utils": "^0.5.0",
utkobe

comment created time in 7 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

+import * as path from "path";+import * as os from 'os';

Ditto.

utkobe

comment created time in 7 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

+import * as path from "path";

Never used.

utkobe

comment created time in 7 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

 import Fastify from 'fastify'; import path from 'path'; import ora from 'ora'; import childProcess from 'child_process';-import { constants } from '@pipcook/pipcook-core';+import { PIPCOOK_LOGS } from '@pipcook/pipcook-utils';

Constants should be in core?

utkobe

comment created time in 7 days

Pull request review commentalibaba/pipcook

move utils from pipcook-core to single package

     "request": "^2.88.2",     "semver": "^6.3.0",     "ts-node": "^8.9.1",-    "yaml": "^1.7.2"+    "yaml": "^1.7.2",+    "@pipcook/pipcook-utils": "^0.5.0"

Sort the list in alphabeta :)

utkobe

comment created time in 7 days

push eventalibaba/pipcook

Yorkie Liu

commit sha 585652e15ab3c0b100f07774ef83b3f3559a44b0

fix nits

view details

push time in 7 days

push eventyorkie/egg-scripts

Yorkie Liu

commit sha 96b603faf9fdc669187b329871a93269fbd8594a

remove production setup

view details

push time in 7 days

fork yorkie/egg-scripts

deploy tool for egg projects

fork in 7 days

push eventalibaba/pipcook

Yorkie Liu

commit sha 00ace8f87ccb55205b512bed4ef561aeed63b35b

fixup

view details

push time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha c4c0c0a82434e943226738571c5a8385178403ee

fixup

view details

push time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha 5236619aaab4998f4f8cb959df7d00af0f4669a1

update pipcook-plugin

view details

push time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha adb95219bb3680a0004ab0670c936f7734e0b76b

use subcommands

view details

push time in 8 days

Pull request review commentalibaba/pipcook

meta: remove sync function.

 export const start: StartHandler = async (filename: string, verbose: boolean) =>   }    filename = path.isAbsolute(filename) ? filename : path.join(process.cwd(), filename);--  if (!existsSync(filename)) {+  const isFileExist = await promisify(exists)(filename);

promisify should be called statically.

Txiaozhe

comment created time in 8 days

Pull request review commentalibaba/pipcook

meta: remove sync function.

 export const initCommander = () => {   program     .command('bip')     .description('boa packages installer')-    .action(() => {-      execSync(`./node_modules/.bin/bip ${process.argv.slice(3).join(' ')}`, {-        cwd: process.cwd()-      });-    });+    .action(() => new Promise((resolve, reject) => exec(`./node_modules/.bin/bip ${process.argv.slice(3).join(' ')}`, {

Promisify this function

Txiaozhe

comment created time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha 16942829486b39069615a4e62a06318906e5e7d8

fix function names

view details

push time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha b98316aff3a803ea9fa4a2940b47ca998f0073bb

fix versions

view details

push time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha 98e99b5a143d2e53a89b0da2d89f856dca4e4efd

rename run to job

view details

push time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha bd44990765dceff977675b92cd9ce06f46ef18e7

fix models

view details

push time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha 8cec8203e013ae4ef1738a24ac1f00531a52a930

add await for model.sync()

view details

push time in 8 days

push eventalibaba/pipcook

Yorkie Liu

commit sha a09a7905a7e269423d812153d92b52492a2ce256

fixup

view details

push time in 8 days

MemberEvent

issue closedalibaba/pipcook

meta: nominate Jory Liang as outside collaborator

@liangzr contributed some specific TypeScript related commits, and helped us review PR in TypeScript perspective.

Therefore I'm going to nominate him as one of outside collaborator & TypeScript reviewer. We need the approvals from the following collaborators: @utkobe @wordcount @Txiaozhe.

closed time in 8 days

yorkie

issue commentalibaba/pipcook

meta: nominate Jory Liang as outside collaborator

Done!

yorkie

comment created time in 8 days

more