profile
viewpoint
yihuang yihuang crypto.com Shenzhen, China http://yi-programmer.com c/c++/python/haskell/rust, postgresql/redis/kafka,

crypto-com/chain 129

Alpha version prototype of Crypto.com Chain⛓

safeada/python-cardano 31

Python implementation of cardano project.

cryptorelay/redis-aggregation 12

Continuous Aggregation in Redis

cryptorelay/cryptorelay.io 4

Next generation crypto exchange system.

yihuang/cabal-install 4

patched cabal-install, can be built with ghc-7.4

yihuang/android-zbar-qrcode 2

Qrcode detector using zbar/kivy/pyjnius, for android.

yihuang/aeson 1

A fast Haskell JSON library

yihuang/Angel 1

Process Monitoring/Management, Like Daemontools

yihuang/attoparsec 1

A fast Haskell library for parsing ByteStrings

yihuang/berp 1

An implementation of Python 3

fork yihuang/niv

Easy dependency management for Nix projects

https://github.com/nmattia/niv

fork in a day

PR closed tendermint/starport

Reviewers
fix directory names
  • [ ] Updated changelog.
+5 -2

0 comment

2 changed files

yihuang

pr closed time in 3 days

Pull request review commenttendermint/starport

fix directory names

 func (p *stargatePlugin) PostInit() error { 	if err != nil { 		return err 	}-	path := filepath.Join(home, p.app.nd(), "config/app.toml")+	path := filepath.Join(home, fmt.Sprintf(".%s/config/app.toml", p.app.nd()))

oh, I find that it's we changed the directory ourself, I tried with a new test project, no issue exists, I'll close this.

yihuang

comment created time in 3 days

PullRequestReviewEvent

create barnchyihuang/vgo2nix

branch : fix-go-module

created branch time in 4 days

pull request commentnix-community/vgo2nix

Completely support modern go.mod

diff --git a/main.go b/main.go
index 10176c9..b4bac00 100644
--- a/main.go
+++ b/main.go
@@ -44,13 +44,14 @@ const depNixFormat = `  {
     };
   }`

+var versionNumber = regexp.MustCompile(`^v\d+`)
+
 func getModules() ([]*modEntry, error) {
 	var entries []*modEntry

 	commitShaRev := regexp.MustCompile(`^v\d+\.\d+\.\d+-(?:rc\d+\.)?(?:\d+\.)?[0-9]{14}-(.*?)(?:\+incompatible)?$`)
 	commitRevV2 := regexp.MustCompile("^v.*-(.{12})\\+incompatible$")
 	commitRevV3 := regexp.MustCompile(`^(v\d+\.\d+\.\d+)\+incompatible$`)
-	versionNumber := regexp.MustCompile(`^v\d+`)

 	var stderr bytes.Buffer
 	cmd := exec.Command("go", "list", "-mod", "mod", "-json", "-m", "all")
@@ -162,6 +163,9 @@ func getPackages(keepGoing bool, numJobs int, prevDeps map[string]*Package) ([]*
 			return nil, wrapError(err)
 		}
 		goPackagePath := importRoot.Root
+		if versionNumber.MatchString(strings.TrimPrefix(entry.importPath, importRoot.Root+"/")) {
+			goPackagePath = entry.importPath
+		}

 		if prevPkg, ok := prevDeps[goPackagePath]; ok {
 			if prevPkg.Rev == entry.rev {

This patch works for the above failed test case.

SuperSandro2000

comment created time in 4 days

pull request commentnix-community/vgo2nix

Completely support modern go.mod

A small test case that fails:

cat > go.mod << EOF
module test-mod

go 1.15

require github.com/cespare/xxhash/v2 v2.1.1

require github.com/cespare/xxhash v1.1.0
EOF
cat > main.go << EOF
package main

import (
	"fmt"

	xxhash "github.com/cespare/xxhash"
	xxhash_v2 "github.com/cespare/xxhash/v2"
)

func main() {
	fmt.Printf("trace %s %s", xxhash.Digest{}, xxhash_v2.Digest{})
}
EOF
cat > default.nix << EOF
{ pkgs ? import <nixpkgs> {} }:
pkgs.buildGoPackage rec {
  pname = "test-mod";
  version = "0.0.1";
  goPackagePath = "test-mod";
  goDeps = ./deps.nix;
  src = ./.;
}
EOF

Run:

vgo2nix
nix-build

Error output:

building
go/src/test-mod/main.go:7:2: cannot find package "github.com/cespare/xxhash/v2" in any of:
        /nix/store/chaz1p7zgj57qm8z55gw3a1aj1c64v4r-go-1.14.6/share/go/src/github.com/cespare/xxhash/v2 (from $GOROOT)
        /private/var/folders/4p/d9t4y4tn1xzdw_bdjbbdv_m40000gq/T/nix-build-test-mod-0.0.1.drv-0/go/src/github.com/cespare/xxhash/v2 (from $GOPATH)
builder for '/nix/store/5afbfgism9dq1ir998c3k7mcz4d0syij-test-mod-0.0.1.drv' failed with exit code 1
SuperSandro2000

comment created time in 5 days

pull request commentnix-community/vgo2nix

Completely support modern go.mod

With the regex modification, vgo2nix works for https://github.com/cosmos/cosmos-sdk, but build still failed:

go/src/github.com/cosmos/cosmos-sdk/cosmovisor/upgrade.go:14:2: cannot find package "github.com/hashicorp/go-getter" in any of:
        /nix/store/chaz1p7zgj57qm8z55gw3a1aj1c64v4r-go-1.14.6/share/go/src/github.com/hashicorp/go-getter (from $GOROOT)
        /private/var/folders/4p/d9t4y4tn1xzdw_bdjbbdv_m40000gq/T/nix-build-cosmos-sdk-0.0.1.drv-0/go/src/github.com/hashicorp/go-getter (from $GOPATH)
builder for '/nix/store/hzazf24c78ng122z1pxam7n447w84s08-cosmos-sdk-0.0.1.drv' failed with exit code 1
error: build of '/nix/store/hzazf24c78ng122z1pxam7n447w84s08-cosmos-sdk-0.0.1.drv' failed

Not sure if it's an issue of vgo2nix though, still new to nix. The default.nix I used:

pkgs.buildGoPackage rec {
  pname = "cosmos-sdk";
  version = "0.0.1";
  goPackagePath = "github.com/cosmos/cosmos-sdk";
  src = pkgs.fetchFromGitHub {
    owner = "cosmos";
    repo = "cosmos-sdk";
    rev = "9cb27fb171aafbadc32257f96fec2cac94649b96";
    sha256 = "1c86ya2b3605zxhy3fnlx9qysf2r3phfmphhvvfr9wm6play8icq";
  };
  goDeps = ./deps.nix;
}
SuperSandro2000

comment created time in 5 days

Pull request review commentnix-community/vgo2nix

Completely support modern go.mod

 const depNixFormat = `  { func getModules() ([]*modEntry, error) { 	var entries []*modEntry -	commitShaRev := regexp.MustCompile(`^v\d+\.\d+\.\d+-(?:\d+\.)?[0-9]{14}-(.*?)$`)+	commitShaRev := regexp.MustCompile(`^v\d+\.\d+\.\d+-(?:\d+\.)?[0-9]{14}-(.*?)(?:\+incompatible)?$`)

the modified regex above works for me.

SuperSandro2000

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentnix-community/vgo2nix

Completely support modern go.mod

 func getModules() ([]*modEntry, error) {  	for _, mod := range mods { 		rev := mod.Version+		url, err := vcs.RepoRootForImportPath(mod.Path, false)+		if err != nil {+			return nil, err+		}+ 		if commitShaRev.MatchString(rev) { 			rev = commitShaRev.FindAllStringSubmatch(rev, -1)[0][1] 		} else if commitRevV2.MatchString(rev) { 			rev = commitRevV2.FindAllStringSubmatch(rev, -1)[0][1] 		} else if commitRevV3.MatchString(rev) { 			rev = commitRevV3.FindAllStringSubmatch(rev, -1)[0][1]+		} else if mod.Path != url.Root {+			subPath := strings.Split(mod.Path, url.Root+"/")[1]+			if !versionNumber.MatchString(subPath) {

The subPath might be like v2/modulePath, in this case the rev should be prepended with modulePath? Also, if the subPath is v2modulePath, the rev should also be prepended with v2modulePath?

SuperSandro2000

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentnix-community/vgo2nix

Completely support modern go.mod

 func getModules() ([]*modEntry, error) {  	for _, mod := range mods { 		rev := mod.Version+		url, err := vcs.RepoRootForImportPath(mod.Path, false)+		if err != nil {+			return nil, err+		}+ 		if commitShaRev.MatchString(rev) { 			rev = commitShaRev.FindAllStringSubmatch(rev, -1)[0][1] 		} else if commitRevV2.MatchString(rev) { 			rev = commitRevV2.FindAllStringSubmatch(rev, -1)[0][1] 		} else if commitRevV3.MatchString(rev) { 			rev = commitRevV3.FindAllStringSubmatch(rev, -1)[0][1]+		} else if mod.Path != url.Root {+			subPath := strings.Split(mod.Path, url.Root+"/")[1]+			if !versionNumber.MatchString(subPath) {+				rev = subPath + "/" + rev

This handles dependencies like github.com/Azure/go-autorest/autorest/azure/auth v0.5.1. If you have a nicer way please suggest it.

Does the rev in case commitRevV3 need to prepend module path like this?

SuperSandro2000

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentnix-community/vgo2nix

Completely support modern go.mod

 const depNixFormat = `  { func getModules() ([]*modEntry, error) { 	var entries []*modEntry -	commitShaRev := regexp.MustCompile(`^v\d+\.\d+\.\d+-(?:\d+\.)?[0-9]{14}-(.*?)$`)+	commitShaRev := regexp.MustCompile(`^v\d+\.\d+\.\d+-(?:\d+\.)?[0-9]{14}-(.*?)(?:\+incompatible)?$`)

Which project has such version numbers?

https://github.com/cosmos/cosmos-sdk/blob/master/go.mod#L43

SuperSandro2000

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentnix-community/vgo2nix

Completely support modern go.mod

 func getModules() ([]*modEntry, error) {  	for _, mod := range mods { 		rev := mod.Version+		url, err := vcs.RepoRootForImportPath(mod.Path, false)+		if err != nil {+			return nil, err+		}+ 		if commitShaRev.MatchString(rev) { 			rev = commitShaRev.FindAllStringSubmatch(rev, -1)[0][1] 		} else if commitRevV2.MatchString(rev) { 			rev = commitRevV2.FindAllStringSubmatch(rev, -1)[0][1] 		} else if commitRevV3.MatchString(rev) { 			rev = commitRevV3.FindAllStringSubmatch(rev, -1)[0][1]+		} else if mod.Path != url.Root {+			subPath := strings.Split(mod.Path, url.Root+"/")[1]+			if !versionNumber.MatchString(subPath) {+				rev = subPath + "/" + rev

Why module path prefix is in else if branch? I think we should handle it as long as the version string is not git sha style?

SuperSandro2000

comment created time in 5 days

PullRequestReviewEvent

Pull request review commentnix-community/vgo2nix

Completely support modern go.mod

 const depNixFormat = `  { func getModules() ([]*modEntry, error) { 	var entries []*modEntry -	commitShaRev := regexp.MustCompile(`^v\d+\.\d+\.\d+-(?:\d+\.)?[0-9]{14}-(.*?)$`)+	commitShaRev := regexp.MustCompile(`^v\d+\.\d+\.\d+-(?:\d+\.)?[0-9]{14}-(.*?)(?:\+incompatible)?$`)

In my case, I have this version string which don't match with this regex: v0.34.0-rc3.0.20200907055413-3359e0bf2f84.

SuperSandro2000

comment created time in 5 days

PullRequestReviewEvent

push eventyihuang/vgo2nix

yihuang

commit sha 3a7c72be69ae642c1a7fc251c8421da04d0b13e7

fix package version processing - convert repo tag(https://golang.org/ref/mod#vcs-find) - fix sha version regex

view details

push time in 5 days

push eventyihuang/vgo2nix

yihuang

commit sha be300d311b6b1770a8544854653cf3f06b2efb7c

fix commitShaRev regex

view details

push time in 5 days

PR opened nix-community/vgo2nix

fix commitShaRev regex
+1 -1

0 comment

1 changed file

pr created time in 5 days

create barnchyihuang/vgo2nix

branch : fix-rev-regex

created branch time in 5 days

fork yihuang/vgo2nix

Convert go.mod files to nixpkgs buildGoPackage compatible deps.nix files [maintainer=@adisbladis]

fork in 5 days

push eventyihuang/starport

yihuang

commit sha c685ca78411197f7d73c14a1cfcac752a113bfba

remove data directory before serve

view details

push time in 8 days

push eventyihuang/starport

yihuang

commit sha 507346b6d60f2930b4e99a0b3302c33cea087758

fix directory names

view details

push time in 8 days

PR opened tendermint/starport

Reviewers
fix directory names and remove patching cli code
  • [ ] Updated changelog.
+2 -24

0 comment

2 changed files

pr created time in 8 days

create barnchyihuang/starport

branch : feature/stargate

created branch time in 8 days

issue commentdiesel-rs/diesel

No support for txid_snapshot data type of postgresql

Closed because issue does not contain any information that could be used to reproduce it.

Added exact script to reproduce it now.

yihuang

comment created time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedpixel-point/web3js-tracker-example

Don't handle chain-reorg

I'm looking for some open source projects which monitor transactions (like centralized exchange) properly. But I think your method don't handle chain reorg situation? in which case the transaction maybe rolled back, but still get confirmed?

created time in 14 days

PR opened crypto-com/chain

Reviewers
Problem: devnet genesis.json app hash don't match

Solution:

  • update keypackage and apphash
+4 -4

0 comment

2 changed files

pr created time in 15 days

push eventyihuang/chain

yihuang

commit sha 960aa7912996ffc925782b61000a95f4257adae8

Problem: devnet genesis.json app hash don't match Solution: - update keypackage and apphash

view details

push time in 15 days

push eventyihuang/chain

bors[bot]

commit sha 481a399ab2d75aa9f7771cd089eb7d6d7e1236f1

Merge #1944 1944: Problem (Fix #1942): running integration-tests/run.sh manually failed r=tomtau a=yihuang Solution: - fix the virtual env directory. Co-authored-by: yihuang <yi.codeplayer@gmail.com>

view details

Tomas Tauber

commit sha d7c70ebae961606f4ba13c03a10a9b060c38c172

Problem: kcov fails on nightly (fixes #1946) Solution: added NETWORK_ID environment variable to travis ci

view details

bors[bot]

commit sha b7aa89b26609e58ac6347bbf1afbe5b72c668b23

Merge #1947 1947: Problem: kcov fails on nightly (fixes #1946) r=tomtau a=tomtau Solution: added NETWORK_ID environment variable to travis ci Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

view details

Tomas Tauber

commit sha cb5a1d96f32826aade39bc7b5e0a4248a6c731f6

Problem: rust-secp256k1 fork diverged from upstream (fixes #757) Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag)

view details

bors[bot]

commit sha 0a104efe57520e875e27bd6d0e6bd711114e8dbb

Merge #1937 1937: Problem: rust-secp256k1 fork diverged from upstream (fixes #757) r=tomtau a=tomtau Solution: - created a branch off upstream rust-secp256k1 https://github.com/crypto-com/rust-secp256k1-zkp/tree/upstream-catchup - use the vendor script to update the secp256k1 library from PR to upstream with changes to Schnorr signatures (the vendor script applies custom patches to have mem allocation in Rust etc.) - updated the code against the upstream changes (one notable change is that signing uses "synthentic nonces" -- https://moderncrypto.org/mail-archive/curves/2017/000925.html -- so needs some fresh randomness) NOTE: MuSig hasn't been ported up to the latest upstream changes yet, so its related functionality is currently disabled (when required, it can later be fixed and enabled via "experimental" feature flag) Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

view details

linfeng

commit sha 1e324651cffde60c6182ac6a5d6fc8427bad22fe

Problem: (fix #1868) no integration tests for cross-wallet operations solution: add integration test of deposit/withdraw/transfer between two wallets

view details

jongwhan lee

commit sha 9f90b3203aa6f3e26e33e354a863a1a25811dd5a

Problem: Ambiguous message while importing an existing transaction (fix #1801) Solution: when tx already exists, display error and return tidy up tidy up tidy up simplify the source

view details

bors[bot]

commit sha 7d881c0d13cb561358da27350a30e618b50ddab9

Merge #1948 1948: Problem: Ambiguous message while importing an existing transaction (f… r=tomtau a=leejw51crypto If the tx is already imported, showed message "This transaction is already imported/in your wallet" Co-authored-by: jongwhan lee <jonghwan@crypto.com>

view details

bors[bot]

commit sha 7e9bcd53b08f1e910373b8bf9cecd04e848de940

Merge #1945 1945: Problem: (fix #1868) no integration tests for cross-wallet operations r=tomtau a=linfeng-crypto solution: add integration test of deposit/withdraw/transfer between two wallets Co-authored-by: linfeng <linfeng@crypto.com>

view details

yihuang

commit sha 5e91d42838c57c75935ea645d8a7d293d02362b1

Problem (Fix #1800): hkdf 0.9 fails to compile Solution: - upgrade related dependencies - Fix #1751 - Fix #1749 - Fix #1757 - Fix #1736 - Fix #1722 - Fix #1720 - Fix #1729 - Fix #1735 - Fix #1733 - Fix #1932 Bump blake3 from 0.3.4 to 0.3.5 Bumps [blake3](https://github.com/BLAKE3-team/BLAKE3) from 0.3.4 to 0.3.5. - [Release notes](https://github.com/BLAKE3-team/BLAKE3/releases) - [Commits](https://github.com/BLAKE3-team/BLAKE3/compare/0.3.4...0.3.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> fix sha2 build

view details

bors[bot]

commit sha a1a76720b8e3faff9b16fc94ea26da13ec50d8ca

Merge #1863 1863: Problem (Fix #1800): hkdf 0.9 fails to compile r=tomtau a=yihuang Solution: - upgrade related dependencies - Fix #1751 - Fix #1749 - Fix #1757 - Fix #1736 - Fix #1722 - Fix #1720 - Fix #1729 - Fix #1735 - Fix #1733 - Fix #1932 Co-authored-by: yihuang <yi.codeplayer@gmail.com>

view details

dependabot-preview[bot]

commit sha eb360ed540905cbb064920837a679ad59ebe8d87

Bump sled from 0.31.0 to 0.33.0 Bumps [sled](https://github.com/spacejam/sled) from 0.31.0 to 0.33.0. - [Release notes](https://github.com/spacejam/sled/releases) - [Changelog](https://github.com/spacejam/sled/blob/master/CHANGELOG.md) - [Commits](https://github.com/spacejam/sled/compare/v0.31...v0.33) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

allthatjazzleo

commit sha 02665d4961efcbaa3157d3a33aca5a5e36dd8845

Problem: (fix #1952) Fortanix is not supporting the latest SGX DCAP deriver: "SGX device was not found, Is a directory" Solution: 1. Add remove dcap sgx driver target in makefile to help user easily to remove if it is pre-installed in azure machine. 2. Fix install-isgx-driver target source link 3. Add alert if user is using dcap sgx driver

view details

dependabot-preview[bot]

commit sha e7cf5ce057e9c88c4f5d300f095e8afe838b9e7c

Bump log from 0.4.8 to 0.4.11 Bumps [log](https://github.com/rust-lang/log) from 0.4.8 to 0.4.11. - [Release notes](https://github.com/rust-lang/log/releases) - [Changelog](https://github.com/rust-lang/log/blob/master/CHANGELOG.md) - [Commits](https://github.com/rust-lang/log/compare/0.4.8...0.4.11) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

bors[bot]

commit sha 886ff492ea9349035760f430118109da3da281e9

Merge #1955 1955: Bump log from 0.4.8 to 0.4.11 r=devashishdxt a=dependabot-preview[bot] Bumps [log](https://github.com/rust-lang/log) from 0.4.8 to 0.4.11. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/log/blob/master/CHANGELOG.md">log's changelog</a>.</em></p> <blockquote> <h2>[0.4.11] - 2020-07-09</h2> <h3>New</h3> <ul> <li>Support coercing structured values into concrete types.</li> <li>Reference the <code>win_dbg_logger</code> in the readme.</li> </ul> <h3>Fixed</h3> <ul> <li>Updates a few deprecated items used internally.</li> <li>Fixed issues in docs and expands sections.</li> <li>Show the correct build badge in the readme.</li> <li>Fix up a possible inference breakage with structured value errors.</li> <li>Respect formatting flags in structured value formatting.</li> </ul> <h2>[0.4.10] - 2019-12-16 (yanked)</h2> <h3>Fixed</h3> <ul> <li>Fixed the <code>log!</code> macros so they work in expression context (this regressed in <code>0.4.9</code>, which has been yanked).</li> </ul> <h2>[0.4.9] - 2019-12-12 (yanked)</h2> <h3>Minimum Supported Rust Version</h3> <p>This release bumps the minimum compiler version to <code>1.31.0</code>. This was mainly needed for <code>cfg-if</code>, but between <code>1.16.0</code> and <code>1.31.0</code> there are a lot of language and library improvements we now take advantage of.</p> <h3>New</h3> <ul> <li>Unstable support for capturing key-value pairs in a record using the <code>log!</code> macros</li> </ul> <h3>Improved</h3> <ul> <li>Better documentation for max level filters.</li> <li>Internal updates to line up with bumped MSRV</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/rust-lang/log/commit/aa4c0375cd94ed4d1b5de7ce0bb3369262dae7e2"><code>aa4c037</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rust-lang/log/issues/404">#404</a> from KodrAus/cargo/0.4.11</li> <li><a href="https://github.com/rust-lang/log/commit/21715ba7eede0138e828e14f9d8f34bcf90235cb"><code>21715ba</code></a> just don't do self updates in ci</li> <li><a href="https://github.com/rust-lang/log/commit/ee4bc806801f29c329b73ae2d9cfc8b8b9e5349f"><code>ee4bc80</code></a> prepare for 0.4.11 release</li> <li><a href="https://github.com/rust-lang/log/commit/813b6ce4793b50d4a60aa28c057f79902c8dfbe0"><code>813b6ce</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rust-lang/log/issues/401">#401</a> from brettcannon/patch-1</li> <li><a href="https://github.com/rust-lang/log/commit/5821b8a338b080e233e2cd1cc9a860a1b6ed0c0c"><code>5821b8a</code></a> Fix a grammatical mistake</li> <li><a href="https://github.com/rust-lang/log/commit/9ae6778bd28abbbd4f96f1c7186967f83f0e0c4d"><code>9ae6778</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rust-lang/log/issues/400">#400</a> from KodrAus/fix/value-fmt</li> <li><a href="https://github.com/rust-lang/log/commit/c89a4a10b6630e45d55d9e839ad1eac2cab1200b"><code>c89a4a1</code></a> bump sval to 0.5.2 for fmt fixes</li> <li><a href="https://github.com/rust-lang/log/commit/43d69c196e6de64ee410970b6c0a9338e838c83e"><code>43d69c1</code></a> remove unneeded io::Error From impl</li> <li><a href="https://github.com/rust-lang/log/commit/ee8c6cd4265f85d94ca2d146dbad377430be9d3f"><code>ee8c6cd</code></a> respect fmt trait and flags in Value</li> <li><a href="https://github.com/rust-lang/log/commit/c5c8e48f358fbc2a62af8c9169dd72202f5376ad"><code>c5c8e48</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/rust-lang/log/issues/398">#398</a> from dtolnay/ra_hir_def</li> <li>Additional commits viewable in <a href="https://github.com/rust-lang/log/compare/0.4.8...0.4.11">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=log&package-manager=cargo&previous-version=0.4.8&new-version=0.4.11)](https://dependabot.com/compatibility-score/?dependency-name=log&package-manager=cargo&previous-version=0.4.8&new-version=0.4.11) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

linfeng

commit sha 7b37031f8589c72cf7c8d993b59a7404f62d9a1e

Problem: (fix #1956) CRYPTO_GENESIS_FINGERPRINT need fixed in Makefile for devnet

view details

bors[bot]

commit sha 56f60b7ee45019a7254c535aca4fafb50161fb98

Merge #1953 1953: Bump sled from 0.31.0 to 0.33.0 r=devashishdxt a=dependabot-preview[bot] Bumps [sled](https://github.com/spacejam/sled) from 0.31.0 to 0.33.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spacejam/sled/releases">sled's releases</a>.</em></p> <blockquote> <h2>0.33.0</h2> <h2>Breaking Changes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1125">#1125</a> the backtrace crate has been made optional, which cuts several seconds off compilation time, but may cause breakage if you interacted with the backtrace field of corruption-related errors.</li> </ul> <h2>Bug Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1128">#1128</a> <code>Tree::pop_min</code> and <code>Tree::pop_max</code> had a bug where they were not atomic.</li> </ul> <h2>0.32.1</h2> <h2>New Features</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1116">#1116</a> <code>IVec::subslice</code> has been added to facilitate creating zero-copy subsliced <code>IVec</code>s that are backed by the same data.</li> </ul> <h2>Bug Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1120">#1120</a> Fixed a use-after-free caused by missing <code>ref</code> keyword on a <code>Copy</code> type in a pattern match in <code>IVec::as_mut</code>.</li> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1108">#1108</a> conversions from <code>Box&lt;[u8]&gt;</code> to <code>IVec</code> are fixed.</li> </ul> <h2>0.32</h2> <h2>New Features</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1079">#1079</a> <code>Transactional</code> is now implemented for <code>[&amp;Tree]</code> and <code>[Tree]</code> so you can avoid the previous friction of using tuples, as was necessary previously.</li> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1058">#1058</a> The minimum supported Rust version (MSRV) is now 1.39.0.</li> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1037">#1037</a> <code>Subscriber</code> now implements <code>Future</code> (non-fused) so prefix watching may now be iterated over via <code>while let Some(event) = (&amp;mut subscriber).await {}</code></li> </ul> <h2>Improvements</h2> <ul> <li>A large number of crash consistency issues have been discovered during intensive testing and fixed.</li> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/965">#965</a> concurrency control is now dynamically enabled for atomic point operations, so that it may be avoided unless transactional functionality is being used in the system. This significantly increases performance for workloads that do not use transactions.</li> <li>A number of memory optimizations have been implemented.</li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/spacejam/sled/blob/master/CHANGELOG.md">sled's changelog</a>.</em></p> <blockquote> <h1>0.33</h1> <h2>Breaking Changes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1125">#1125</a> the backtrace crate has been made optional, which cuts several seconds off compilation time, but may cause breakage if you interacted with the backtrace field of corruption-related errors.</li> </ul> <h2>Bug Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1128">#1128</a> <code>Tree::pop_min</code> and <code>Tree::pop_max</code> had a bug where they were not atomic.</li> </ul> <h1>0.32.1</h1> <h2>New Features</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1116">#1116</a> <code>IVec::subslice</code> has been added to facilitate creating zero-copy subsliced <code>IVec</code>s that are backed by the same data.</li> </ul> <h2>Bug Fixes</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1120">#1120</a> Fixed a use-after-free caused by missing <code>ref</code> keyword on a <code>Copy</code> type in a pattern match in <code>IVec::as_mut</code>.</li> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1108">#1108</a> conversions from <code>Box&lt;[u8]&gt;</code> to <code>IVec</code> are fixed.</li> </ul> <h1>0.32</h1> <h2>New Features</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1079">#1079</a> <code>Transactional</code> is now implemented for <code>[&amp;Tree]</code> and <code>[Tree]</code> so you can avoid the previous friction of using tuples, as was necessary previously.</li> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1058">#1058</a> The minimum supported Rust version (MSRV) is now 1.39.0.</li> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1037">#1037</a> <code>Subscriber</code> now implements <code>Future</code> (non-fused) so prefix watching may now be iterated over via <code>while let Some(event) = (&amp;mut subscriber).await {}</code></li> </ul> <h2>Improvements</h2> <ul> <li><a href="https://github-redirect.dependabot.com/spacejam/sled/issues/965">#965</a> concurrency control is now dynamically enabled for atomic point operations, so that it may be avoided unless transactional functionality is being used in the system. This significantly increases performance for workloads that do not use transactions.</li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/spacejam/sled/commit/8bfa87e49b24b827f708ef2d1664e06e7957e47c"><code>8bfa87e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1128">#1128</a> from spacejam/tyler_0.33</li> <li><a href="https://github.com/spacejam/sled/commit/9cc2d10b0a2903ec6f05491cf2dc8e5ce0ac1a33"><code>9cc2d10</code></a> Fix concurrent pop test</li> <li><a href="https://github.com/spacejam/sled/commit/f62ab32a9cd60cf7851d70f250643572e0292e77"><code>f62ab32</code></a> Check-in concurrent tree pop test</li> <li><a href="https://github.com/spacejam/sled/commit/f6b939aa3cde82e9ed6d0505eb82c3e898f49454"><code>f6b939a</code></a> Add issue numbers to the changelog</li> <li><a href="https://github.com/spacejam/sled/commit/ee33b1db41b59110d41e0502fa965b4347ee113d"><code>ee33b1d</code></a> Cut 0.33. Fix atomicity bug in Tree::pop_min and Tree::pop_max</li> <li><a href="https://github.com/spacejam/sled/commit/21975b89af7283a09c2886b32e1adbc926f2ab89"><code>21975b8</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1126">#1126</a> from ernestas-poskus/fix/metrics_log_reservation_att...</li> <li><a href="https://github.com/spacejam/sled/commit/50790eb822f5752a56d4ad8dbd99263dd845389f"><code>50790eb</code></a> metrics: fix log_reservation_attempts subtract overflow</li> <li><a href="https://github.com/spacejam/sled/commit/fd9f61e4a7f8f80f552c6ea712fc7dd5c4112aaa"><code>fd9f61e</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/spacejam/sled/issues/1125">#1125</a> from spacejam/tyler_optional_backtrace</li> <li><a href="https://github.com/spacejam/sled/commit/7e3dc1b1444baa86d8363a8bd827a4b8e65aad86"><code>7e3dc1b</code></a> Make the backtrace crate optional for faster compile times</li> <li><a href="https://github.com/spacejam/sled/commit/1e5bbfc66ec85ddddc312005018ec6c8ed8a4062"><code>1e5bbfc</code></a> Update CHANGELOG.md</li> <li>Additional commits viewable in <a href="https://github.com/spacejam/sled/compare/v0.31...v0.33">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=sled&package-manager=cargo&previous-version=0.31.0&new-version=0.33.0)](https://dependabot.com/compatibility-score/?dependency-name=sled&package-manager=cargo&previous-version=0.31.0&new-version=0.33.0) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

bors[bot]

commit sha 49f24e49732e71b331c45a40dae7b74cb5a56506

Merge #1957 1957: Problem: (fix #1956) CRYPTO_GENESIS_FINGERPRINT need fixed in Makefile for devnet r=tomtau a=linfeng-crypto change CRYPTO_GENESIS_FINGERPRINT to `8DC8F782F15A6481E4485D146A1ED2E005A7A6BE183BE06204EA0F0C55671F02` for devnet in Makefile Co-authored-by: linfeng <linfeng@crypto.com>

view details

bors[bot]

commit sha 068d5a0c690ca26dc0d2426c3ef78c373aadc5a6

Merge #1954 1954: Problem: (fix #1952) Fortanix is not supporting the latest SGX DCAP d… r=tomtau a=allthatjazzleo Solution: 1. Add remove dcap sgx driver target in makefile to help user easily to remove if it is pre-installed in azure machine. 2. Fix install-isgx-driver target source link 3. Add alert if user is using dcap sgx driver Co-authored-by: allthatjazzleo <pangleo1994@gmail.com>

view details

Jimmy Yip

commit sha f893fc42e5220b0a63f7a0a97e81025b8cfefeb6

Problem: Attestation report is not transmitted and validated properly (fixes #1941) Solution: 1. URL decode the RA report signing certificate 2. Return error when missing signing certificate in TLS server certificate 3. Fix signing certificate verification logic 4. Fix attestation report report data verification logic 5. Add test cases

view details

push time in 15 days

pull request commentcrypto-com/chain

Problem (Fix #2207): mls implementation is not up to date

devnet genesis.json / config may also need an update: https://travis-ci.org/github/crypto-com/chain/jobs/724797789#L1468

I open another pr for this.

yihuang

comment created time in 15 days

push eventyihuang/chain

yihuang

commit sha 6e7fcdbf53852b4246b7297c34b1a55fc801c13c

Problem (Fix #2207): mls implementation is not up to date https://github.com/mlswg/mls-protocol/compare/d1d5f56a5d83781042d19c830497ab5aa104907f...1d5e14d79435834bc5cab6c7aa9e2fcdd6afeabc Solution: - updated deriviation of tree node secrets and keys - unified KeySecret/NodeSecret to SecretValue - other minor changes

view details

push time in 15 days

push eventyihuang/chain

yihuang

commit sha d5be94fa20dbe6e23aa24803a19eb20e5d5a6222

Problem (Fix #2207): mls implementation is not up to date https://github.com/mlswg/mls-protocol/compare/d1d5f56a5d83781042d19c830497ab5aa104907f...1d5e14d79435834bc5cab6c7aa9e2fcdd6afeabc Solution: - updated deriviation of tree node secrets and keys - unified KeySecret/NodeSecret to SecretValue - other minor changes

view details

push time in 15 days

pull request commentcrypto-com/chain

Problem: mls implementation is not up to date

I quickly went through changes in mlswg/mls-protocol@d1d5f56...1d5e14d and it seems ok / that it captures them.

the test vector unit test breaks: https://travis-ci.org/github/crypto-com/chain/jobs/724615023#L1409 maybe it can be annotated with #[ignore], as it may be breaking often now given recent changes

I just updated one test vector, it seems work fine now.

yihuang

comment created time in 15 days

push eventyihuang/chain

yihuang

commit sha 22d1ec65e34374bf5943f72be05cb7b91a380f69

Problem: mls implementation is not up to date https://github.com/mlswg/mls-protocol/compare/d1d5f56a5d83781042d19c830497ab5aa104907f...1d5e14d79435834bc5cab6c7aa9e2fcdd6afeabc Solution: - updated deriviation of tree node secrets and keys - unified KeySecret/NodeSecret to SecretValue - other minor changes

view details

push time in 15 days

issue openedcrypto-com/chain

Problem: mls implementation is not up to date

https://github.com/mlswg/mls-protocol/compare/d1d5f56a5d83781042d19c830497ab5aa104907f...1d5e14d79435834bc5cab6c7aa9e2fcdd6afeabc

created time in 15 days

PR opened crypto-com/chain

Reviewers
Problem: mls implementation is not up to date

https://github.com/mlswg/mls-protocol/compare/d1d5f56a5d83781042d19c830497ab5aa104907f...1d5e14d79435834bc5cab6c7aa9e2fcdd6afeabc Solution:

  • updated deriviation of tree node secrets and keys
  • unified KeySecret/NodeSecret to SecretValue
  • other minor changes
+302 -326

0 comment

13 changed files

pr created time in 16 days

create barnchyihuang/chain

branch : update-mls

created branch time in 16 days

PR closed andymccurdy/redis-py

speedup 50% with pack_command rewritten in cython. Stale

This c extension module is totally optional, and don't got build as default, so don't have any downside for normal user who don't need speedup. And if you wants speedup, you need to install cython 0.19 (which is the only cython version i tested), and run cython redis/_pack.pyx, before python setup.py install. I also included a socket mockup module which support packet recording and replay, and a profile script. Below is the timeit and profile result run on my mba laptop:

> cd benchmark
> export PYTHONPATH=..
> python benchmark.py

Original pack_command:

10000 loops, best of 3: 57.2 usec per loop
         620002 function calls in 1.106 seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    0.283    0.000    0.579    0.000 connection.py:45(_pack_command)
   180000    0.147    0.000    0.147    0.000 {method 'write' of 'cStringIO.StringO' objects}
    10000    0.083    0.000    0.987    0.000 client.py:387(execute_command)
    10000    0.073    0.000    0.129    0.000 connection.py:206(read_response)
    30000    0.066    0.000    0.101    0.000 connection.py:33(_encode)
    80000    0.048    0.000    0.048    0.000 {isinstance}
    10000    0.038    0.000    0.240    0.000 client.py:402(parse_response)
    10000    0.034    0.000    0.654    0.000 connection.py:333(send_command)
    10000    0.030    0.000    1.017    0.000 client.py:777(set)
    10000    0.028    0.000    0.166    0.000 connection.py:337(read_response)
    10000    0.025    0.000    0.041    0.000 connection.py:314(send_packed_command)
    10000    0.024    0.000    0.024    0.000 patch_socket.py:17(start_replay)
    10000    0.024    0.000    1.087    0.000 benchmark.py:38(run_with_replay)
    10000    0.022    0.000    1.039    0.000 benchmark.py:28(bench)
        1    0.019    0.019    1.106    1.106 <string>:1(<module>)
    10000    0.019    0.000    0.035    0.000 client.py:261(<lambda>)
    40000    0.019    0.000    0.019    0.000 _compat.py:21(<lambda>)
    10000    0.016    0.000    0.022    0.000 patch_socket.py:40(recv)
    50000    0.015    0.000    0.015    0.000 {len}
    10000    0.013    0.000    0.016    0.000 patch_socket.py:34(sendall)
    20000    0.013    0.000    0.013    0.000 {method 'gets' of 'hiredis.Reader' objects}
    10000    0.013    0.000    0.016    0.000 _compat.py:18(<lambda>)
    10000    0.011    0.000    0.011    0.000 {method 'endswith' of 'str' objects}
    10000    0.010    0.000    0.010    0.000 {cStringIO.StringIO}
    10000    0.009    0.000    0.009    0.000 {method 'feed' of 'hiredis.Reader' objects}
    10000    0.008    0.000    0.008    0.000 {method 'getvalue' of 'cStringIO.StringO' objects}
    10000    0.006    0.000    0.006    0.000 {method 'pop' of 'list' objects}
    10000    0.005    0.000    0.005    0.000 benchmark.py:11(get_connection)
    10000    0.005    0.000    0.005    0.000 benchmark.py:14(release)
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}

Optimized pure python pack_command:

10000 loops, best of 3: 46.1 usec per loop
         580002 function calls in 0.983 seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    0.247    0.000    0.450    0.000 connection.py:45(_pack_command)
    10000    0.080    0.000    0.864    0.000 client.py:387(execute_command)
    10000    0.074    0.000    0.132    0.000 connection.py:203(read_response)
    30000    0.065    0.000    0.098    0.000 connection.py:33(_encode)
   150000    0.050    0.000    0.050    0.000 {method 'append' of 'list' objects}
    80000    0.047    0.000    0.047    0.000 {isinstance}
    10000    0.038    0.000    0.243    0.000 client.py:402(parse_response)
    10000    0.036    0.000    0.530    0.000 connection.py:330(send_command)
    10000    0.031    0.000    0.895    0.000 client.py:777(set)
    10000    0.028    0.000    0.044    0.000 connection.py:311(send_packed_command)
    10000    0.028    0.000    0.170    0.000 connection.py:334(read_response)
    10000    0.024    0.000    0.964    0.000 benchmark.py:38(run_with_replay)
    10000    0.024    0.000    0.024    0.000 {method 'join' of 'str' objects}
    10000    0.024    0.000    0.024    0.000 patch_socket.py:17(start_replay)
    10000    0.021    0.000    0.916    0.000 benchmark.py:28(bench)
    10000    0.019    0.000    0.036    0.000 client.py:261(<lambda>)
        1    0.019    0.019    0.983    0.983 <string>:1(<module>)
    40000    0.018    0.000    0.018    0.000 _compat.py:21(<lambda>)
    50000    0.016    0.000    0.016    0.000 {len}
    10000    0.016    0.000    0.023    0.000 patch_socket.py:40(recv)
    20000    0.014    0.000    0.014    0.000 {method 'gets' of 'hiredis.Reader' objects}
    10000    0.013    0.000    0.016    0.000 patch_socket.py:34(sendall)
    10000    0.013    0.000    0.016    0.000 _compat.py:18(<lambda>)
    10000    0.011    0.000    0.011    0.000 {method 'endswith' of 'str' objects}
    10000    0.010    0.000    0.010    0.000 {method 'feed' of 'hiredis.Reader' objects}
    10000    0.007    0.000    0.007    0.000 {method 'pop' of 'list' objects}
    10000    0.005    0.000    0.005    0.000 benchmark.py:14(release)
    10000    0.005    0.000    0.005    0.000 benchmark.py:11(get_connection)
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}

Use redis._pack c extension:

10000 loops, best of 3: 31.3 usec per loop
         250002 function calls in 0.547 seconds

   Ordered by: internal time

   ncalls  tottime  percall  cumtime  percall filename:lineno(function)
    10000    0.075    0.000    0.437    0.000 client.py:387(execute_command)
    10000    0.069    0.000    0.122    0.000 connection.py:203(read_response)
    10000    0.059    0.000    0.059    0.000 {redis._pack._pack_command}
    10000    0.036    0.000    0.229    0.000 client.py:402(parse_response)
    10000    0.028    0.000    0.465    0.000 client.py:777(set)
    10000    0.026    0.000    0.159    0.000 connection.py:334(read_response)
    10000    0.026    0.000    0.124    0.000 connection.py:330(send_command)
    10000    0.023    0.000    0.039    0.000 connection.py:311(send_packed_command)
    10000    0.023    0.000    0.023    0.000 patch_socket.py:17(start_replay)
    10000    0.023    0.000    0.531    0.000 benchmark.py:38(run_with_replay)
    10000    0.020    0.000    0.485    0.000 benchmark.py:28(bench)
    10000    0.018    0.000    0.034    0.000 client.py:261(<lambda>)
        1    0.017    0.017    0.547    0.547 <string>:1(<module>)
    10000    0.015    0.000    0.022    0.000 patch_socket.py:40(recv)
    20000    0.014    0.000    0.014    0.000 {isinstance}
    10000    0.014    0.000    0.016    0.000 patch_socket.py:34(sendall)
    20000    0.013    0.000    0.013    0.000 {method 'gets' of 'hiredis.Reader' objects}
    10000    0.012    0.000    0.016    0.000 _compat.py:18(<lambda>)
    10000    0.010    0.000    0.010    0.000 {method 'endswith' of 'str' objects}
    10000    0.009    0.000    0.009    0.000 {method 'feed' of 'hiredis.Reader' objects}
    10000    0.007    0.000    0.007    0.000 {method 'pop' of 'list' objects}
    10000    0.005    0.000    0.005    0.000 benchmark.py:11(get_connection)
    10000    0.004    0.000    0.004    0.000 benchmark.py:14(release)
    10000    0.003    0.000    0.003    0.000 {len}
        1    0.000    0.000    0.000    0.000 {method 'disable' of '_lsprof.Profiler' objects}
+310 -50

17 comments

5 changed files

yihuang

pr closed time in 16 days

push eventyihuang/chain

yihuang

commit sha 06f717f1b91a68bb27446a030d96f04170b91624

Problem (Fix #2203): validator crash after re-joined with different validator key Solution: - deduplicate staking address when doing cleanup - index used_validator_addresses when initialize after load from storage

view details

push time in 18 days

PR opened crypto-com/chain

Reviewers
Problem (Fix #2203): validator crash after re-joined with different validator key

Solution:

  • deduplicate staking address when doing cleanup
  • index used_validator_addresses when initialize after load from storage
+117 -69

0 comment

6 changed files

pr created time in 18 days

create barnchyihuang/chain

branch : hotfix-crash

created branch time in 18 days

PR opened tendermint/starport

Reviewers
Fix appd directory name
  • [ ] Updated changelog.
+1 -1

0 comment

1 changed file

pr created time in 19 days

push eventyihuang/starport

yihuang

commit sha 6ad947c36af6a9b6318fddeab9e8f185ce2852be

Fix appd directory name

view details

push time in 19 days

fork yihuang/starport

The easiest way to build a blockchain.

https://cosmos.network

fork in 19 days

issue openedPistonDevelopers/graphics

Support 9-slicing sprites

Is it good to implement in this crate, or one should implement in other crates?

created time in 21 days

PR opened PistonDevelopers/sprite

Use mem::take to replace clone+clear
+2 -2

0 comment

1 changed file

pr created time in 21 days

push eventyihuang/sprite

yihuang

commit sha cd28568a787f10e404b3571d9f2a5a82e0e36faf

Use mem::take to replace clone+clear

view details

push time in 21 days

pull request commentservo/euclid

Fix perspective projection transform

my two cents on this(after discussed with @lezzokafka):

  • the only effect of the m44 = 1 is accumulate the w component contained in the point.
  • if the point start with w=0, and the transformations before applying perspective don't affect the w component, then the m44 has no effect. so normally the matrix is correct as long as the point start with w=0.
  • and one potential use-case for m44 = 1 is that, one can set the w component in previous custom transformation matrix, which will not get erased by the perspective matrix.
hannobraun

comment created time in 22 days

issue openedPistonDevelopers/sprite

Support perspective and rotation by x/y axis

https://drafts.csswg.org/css-transforms-2/#PerspectiveDefined

created time in 22 days

issue openedPistonDevelopers/sprite

Generalize animation with composable keyframe animation

probably implement with https://crates.io/crates/keyframe

created time in 22 days

fork yihuang/sprite

A library for sprite hierarchy and scene management

fork in 22 days

Pull request review commentcrypto-com/chain

Problem (WIP #1996): no support for genesis build procedure involving TDBE

 use std::sync::Arc;  /// FIXME: genesis app hash etc.? pub const NETWORK_HEX_ID: u8 = get_network_id!();+pub const TDBE_MRENCLAVE: &[u8; 32] = include_bytes!("tdbe.mrenclave");

done

yihuang

comment created time in a month

PullRequestReviewEvent

push eventyihuang/chain

dependabot-preview[bot]

commit sha 48ad62a42443da1c2560d312aa2119f7e87aa8c9

Bump reqwest from 0.10.7 to 0.10.8 Bumps [reqwest](https://github.com/seanmonstar/reqwest) from 0.10.7 to 0.10.8. - [Release notes](https://github.com/seanmonstar/reqwest/releases) - [Changelog](https://github.com/seanmonstar/reqwest/blob/master/CHANGELOG.md) - [Commits](https://github.com/seanmonstar/reqwest/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 98e63132014f49a6fec6ca55030d6d43b3469664

Bump structopt from 0.3.16 to 0.3.17 Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.16 to 0.3.17. - [Release notes](https://github.com/TeXitoi/structopt/releases) - [Changelog](https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md) - [Commits](https://github.com/TeXitoi/structopt/compare/v0.3.16...v0.3.17) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

bors[bot]

commit sha e2a8ebfa6fc1fa40a07a6b1ff3a718406f33d1d1

Merge #2186 2186: Bump reqwest from 0.10.7 to 0.10.8 r=tomtau a=dependabot-preview[bot] Bumps [reqwest](https://github.com/seanmonstar/reqwest) from 0.10.7 to 0.10.8. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/seanmonstar/reqwest/commits">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=reqwest&package-manager=cargo&previous-version=0.10.7&new-version=0.10.8)](https://dependabot.com/compatibility-score/?dependency-name=reqwest&package-manager=cargo&previous-version=0.10.7&new-version=0.10.8) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

Tomas Tauber

commit sha 5d5d59353d959078535d9184ace4fcfc7763c7cd

Problem: no tx-validation enclave attested TLS listener for receiving secrets from TDBE (fixes #1994) Solution: made parts of TDBE helpers reusable + a simple listening for mock key being pushed by incomplete TDBE enclave code (launched in chain-abci) + build modifications

view details

bors[bot]

commit sha af8ca28809dff50b8807d48c3a6b22d1b33fd588

Merge #2187 2187: Bump structopt from 0.3.16 to 0.3.17 r=tomtau a=dependabot-preview[bot] Bumps [structopt](https://github.com/TeXitoi/structopt) from 0.3.16 to 0.3.17. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/TeXitoi/structopt/blob/master/CHANGELOG.md">structopt's changelog</a>.</em></p> <blockquote> <h1>v0.3.17 (2020-08-25)</h1> <ul> <li>Fixed <a href="https://github-redirect.dependabot.com/TeXitoi/structopt/issues/424">a breakage</a> with resent rustc versions due to <code>quote_spanned</code> misuse.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/TeXitoi/structopt/commit/6a7d1802c172f9973bb86f684ab7447247db066f"><code>6a7d180</code></a> v0.3.17</li> <li><a href="https://github.com/TeXitoi/structopt/commit/f7fcda26f4945f35adabf6b67738e4bfcd53d61a"><code>f7fcda2</code></a> Fix wrong span</li> <li>See full diff in <a href="https://github.com/TeXitoi/structopt/compare/v0.3.16...v0.3.17">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://api.dependabot.com/badges/compatibility_score?dependency-name=structopt&package-manager=cargo&previous-version=0.3.16&new-version=0.3.17)](https://dependabot.com/compatibility-score/?dependency-name=structopt&package-manager=cargo&previous-version=0.3.16&new-version=0.3.17) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired) </details> Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>

view details

bors[bot]

commit sha 442743159268b823cfa7ab5c8a1cb49d57135ef0

Merge #2189 2189: Problem: no tx-validation enclave attested TLS listener for receiving secrets from TDBE (fixes #1994) r=tomtau a=tomtau Solution: made parts of TDBE helpers reusable + a simple listening for mock key being pushed by incomplete TDBE enclave code (launched in chain-abci) + build modifications Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

view details

yihuang

commit sha d9e512dfb78724a3fa8289295741ae0ec176ffc1

Problem (WIP #1996): no support for genesis build procedure involving TDBE Solution: - preliminary try implemented in build.sh

view details

push time in a month

push eventyihuang/chain

yihuang

commit sha b5c23e01a7ef4fcbf86d5d36ba64332a11bbbf57

Problem (WIP #1996): no support for genesis build procedure involving TDBE Solution: - preliminary try implemented in build.sh

view details

push time in a month

Pull request review commentcrypto-com/chain

Problem (Fix #1996): no support for genesis build procedure involving TDBE

 pub struct TdbeConfig {     /// Transaction IDs to fetch from another TDBE server     pub transaction_ids: Vec<TxId>, }++const LIGHT_GENESIS: &str = env!("LIGHT_GENESIS");

done

yihuang

comment created time in a month

PullRequestReviewEvent

push eventyihuang/chain

yihuang

commit sha f512588e265db3e87d2efffddd60799e27d3e687

Problem (Fix #1996): no support for genesis build procedure involving TDBE Solution: - preliminary try implemented in build.sh

view details

push time in a month

push eventyihuang/chain

yihuang

commit sha 8430d891c0ab70e405eaf4ebf874913867a3a91f

Update chain-tx-enclave-next/tx-validation-next/src/sgx_module.rs Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>

view details

push time in a month

push eventyihuang/chain

yihuang

commit sha d0eefb7906e9244b801881be76fa1a3ea5121187

Problem (Fix #1996): no support for genesis build procedure involving TDBE Solution: - preliminary try implemented in build.sh

view details

push time in a month

push eventyihuang/chain

Devashish

commit sha 4b98470b6aab14aa73d4e824b6d913e8cb657841

Problem: Missing runner for TDBE + No persistence of TDBE fetched transactions Solution: Added TDBE runner and persistence stream for transactions fetched by TDBE. Fixes #1995. Note: There are still few things missing in the TDBE runner: - Fetching remote TDBE details from RPC - Fetching transaction IDs using light client - Attested TVE <-> TDBE stream

view details

bors[bot]

commit sha 52cdc223f016664f04571ef1d3ec4bcb3163b31a

Merge #2177 2177: Problem: Missing runner for TDBE + No persistence of TDBE fetched transactions r=tomtau a=devashishdxt Solution: Added TDBE runner and persistence stream for transactions fetched by TDBE. Fixes #1995. Note: There are still few things missing in the TDBE runner: - Fetching remote TDBE details from RPC - Fetching transaction IDs using light client - Attested TVE <-> TDBE stream Co-authored-by: Devashish <devashish@crypto.com>

view details

yihuang

commit sha 0c9c94b07e9df8f7d81c88603a2116471274ddac

Problem (Fix #1996): no support for genesis build procedure involving TDBE Solution: - preliminary try implemented in build.sh

view details

push time in a month

push eventyihuang/chain

yihuang

commit sha 2c9a124299bca947527f7463321fccd3ecdf93b4

Problem (Fix #1996): no support for genesis build procedure involving TDBE Solution: - preliminary try implemented in build.sh

view details

push time in a month

PR opened crypto-com/chain

Reviewers
Problem (Fix #1996): no support for genesis build procedure involving TDBE

Solution:

  • preliminary try implemented in build.sh
+74 -3

0 comment

7 changed files

pr created time in a month

create barnchyihuang/chain

branch : issue1996

created branch time in a month

issue openedcrypto-com/chain

Problem: chain-tx-enclave-next is not renamed back to chain-tx-enclave

Since enclaves have all been migrated to edp, we can rename chain-tx-enclave-next back to chain-tx-enclave now. https://github.com/crypto-com/chain/blob/master/architecture-docs/adr-002.md#decision

created time in a month

issue commentcrypto-com/chain

Problem: client-cli wallet sync in integration test fail occasionally

it seems only happen in client-cli, maybe worth check out the differences between cli and rpc.

yihuang

comment created time in a month

pull request commentcrypto-com/chain-docs

Problem: enclave light-client trusted anchor basis is not clear

but you won't know the app_hash, as there's a cycle: in order to compute the app hash, you need the full validator state (i.e. generate initial keypackages with TDBE)

yes, i changed to compile validator voting power map into enclave.

yihuang

comment created time in a month

push eventyihuang/chain-docs

yihuang

commit sha 81007179d1b2c6ef5022ea2f2d773fabc8448547

Problem: enclave light-client trusted anchor basis is not clear Solution: - only need to compile genesis hash into enclave, verify fetched genesis against it

view details

push time in a month

PR opened crypto-com/chain-docs

Reviewers
Problem: enclave light-client trusted anchor basic is not clear

Solution:

  • only need to compile genesis hash into enclave, verify fetched genesis against it
+12 -2

0 comment

1 changed file

pr created time in a month

push eventyihuang/chain-docs

yihuang

commit sha 2244bf0d6318583860ff8a243514fe77c7bd7963

Problem: nonce increment in add reward is not correct (#126)

view details

Leslie Cheung

commit sha 12049eaad5259d7c57699d8055efaee53270fa92

Problem: Pending status is not explanined (#127) Solution: Added description to Pending status in wallet balance; Updated the default setting for websocket endpoint for tendermint; Redirected some links in the docs.

view details

Leslie Cheung

commit sha 269247f420ca4ca24eb6c24f81f7facf9c276ef8

Problem: Outdated data structure #128 Part of #121 : getting-started/staking.md : Updated the StakedState and CouncilNode data structure after #1426 and #1292; getting-started/node-joining.md Fixed some links.

view details

Calvin Lau

commit sha 3eee29d33a34fbf4079dd21c9e2eaa9819cf301f

Problem: Missing make prepare step (#129) Solution: Add the step back in the documentation

view details

Leslie Cheung

commit sha b23e1c4b77b7574e22e6082dfe943c6aff7fc333

update of reward docs Updated the "Reward distribution" section in getting-started/reward-and-punishments.md based on the latest revised reward module ; Updated the reward distribution period parameters from distribution_period => reward_period_seconds ( See issue 874 in chain-core); Fixed broken links.

view details

Calvin Lau

commit sha 8da21e72fe11c56eb22de424fa7cb4326dfbfb65

Problem: (Fix #134) minimist dependency has vulnerability (#135) Solution: Update minimist to fix the vulnerability

view details

Leslie Cheung

commit sha 8e62f1decea50a3f3998e6189265e2cef7569618

Testnet v0.5 docs update (#133)

view details

Leslie Cheung

commit sha 50fe8fca2f2c3f1da920a3ce1cc0a6e39c87ce88

v0.5.2_update (#136)

view details

Tomas Tauber

commit sha 2c1f9dbd045356aabae951fa51250d94fd07d4c9

Problem: no test vectors for different transaction types (fixes #68) (#137) Solution: generated a few test vectors with modified dev-utils and documented them

view details

Tomas Tauber

commit sha 5bd00a940f173816e1328a33492edb0a573cd751

Problem: some hex payloads are longer than the page width (#138) Solution: modified them to use the wrapping code block

view details

Leslie Cheung

commit sha 58364a7300419c1a8215ce04d0f4999837782847

Problem:(Fix#123) No documentation for multisig in client-cli (#139) Solution: Added documentation for multisig in client-cli under Wallet Management.

view details

Leslie Cheung

commit sha 2e9e9a0bf465fd6a79435a94bcaa23453d10f0d3

Problem: Testnet fullnode address is outdated. #140 Solution: Updated fullnode ip address; Added Note for environment variables setting.

view details

Leslie Cheung

commit sha 4b87e3e618ce7ec9cba822953ed6136040c93807

Problem:(Fix#143) genesis page is not up to date (#145) Solution: getting-started/genesis.md Added section Fields in genesis, described all the fields in the genesis file; Added section Genesis hash for light client verification and how the hash it's calculated. technical_glossary.md and thaler-testnet.md Typos fixed

view details

Leslie Cheung

commit sha 86df9512d6e1610313a03a164fd3623344696eeb

Problem:(Fix#143) genesis page is not up to date - Final Solution: fixed genesis.md

view details

dependabot[bot]

commit sha 91a3858b20a04063498662842ed6851a0ef2702d

Bump websocket-extensions from 0.1.3 to 0.1.4 (#148) Bumps [websocket-extensions](https://github.com/faye/websocket-extensions-node) from 0.1.3 to 0.1.4. - [Release notes](https://github.com/faye/websocket-extensions-node/releases) - [Changelog](https://github.com/faye/websocket-extensions-node/blob/master/CHANGELOG.md) - [Commits](https://github.com/faye/websocket-extensions-node/compare/0.1.3...0.1.4) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

view details

Cerulean Hu

commit sha 0079f3937643ff6135fdfe245f6d5ca83606ffc0

Fix broken url links due to polkadot rename and folder reorg (#149) Co-authored-by: ceruleanhu <hulandan123@gmail.com>

view details

Cerulean Hu

commit sha 6a31f06b85c4244211e26cc39389e5881c54c299

Fix typos (#151) * Fix broken url links due to polkadot rename and folder reorg * fix typos in whole repository * clearer text and fix duplicated word Co-authored-by: ceruleanhu <hulandan123@gmail.com>

view details

juno-yu

commit sha f2a7e50284436132eca6b299526ea5aa72328e09

fixed a broken TM image flow link (#153)

view details

Leslie Cheung

commit sha 5e3b66614cb3f5a5c8dcd8bad9d5088d09482b8c

Problem: (fix#143) genesis page is not up to date (#154) Solution: getting-started/genesis.md : Updated and change "genesis hash" to "genesis fingerprint", align with the changes in #1759. Extra: Some small fix/links redirecting for better communication.

view details

Tomas Tauber

commit sha c4fb65c11229ae999097e2fc425a6b35a214b302

Problem: MLS member leaving/joining interaction with council nodes not documented (WIP #141 fixes #142) (#152) Solution: sketched out a doc containing more details beyond the original implementation plan (it still lacks some parts, so still WIP) + some parts -- e.g. new transaction types -- can be moved to other modules when it's agreed on and detailed/polished later -- also, as the MLS protocol draft changed since the original implementantion plan, key rotation procedure was simplified to make use of MLS exporter functionality

view details

push time in a month

PullRequestReviewEvent
PullRequestReviewEvent

issue openedcrypto-com/chain

Problem: non-reproducible Python dependencies in integration tests

partial fixed before #1934 with pip freezed requirement file. now it seems poetry works well with nix now, maybe good to upgrade integration tests env setup to nix.

created time in a month

pull request commentcrypto-com/chain

Problem (Fix #2145): incorrect confirmed_transcript_hash calculation in mls

Build failed (retrying...):

#2093 again

yihuang

comment created time in a month

pull request commentcrypto-com/chain-docs

Problem (Fix #192): keypackage expiration handling not described in detail

looks ok -- it'd be good to add the new "keypakcage_update_secs" parameter to https://github.com/crypto-com/chain-docs/pull/204/files#diff-d4f1ae2b8a855e88f80fea911f20aea1 too

done

yihuang

comment created time in a month

push eventyihuang/chain-docs

yihuang

commit sha af4edcb8f7a4dcad1b112dd6f32a64c783205812

Problem (Fix #192): keypackage expiration handling not described in detail Solution: - add the details

view details

push time in a month

PullRequestReviewEvent

Pull request review commentcrypto-com/chain-docs

Problem (Fix #192): keypackage expiration handling not described in detail

 the next node's TDBE (next non-empty leaf) should generate and broadcast `Commit and include Remove proposals as with the "commit timeout" case.  ###### Updates-After 1/3 of keypackage's lifetime is over, TDBE is allowed to generate and broadcast `SelfUpdateProposal`+When `keypackage.create_time + keypackage_expiration_secs > block_time >= keypackage.create_time + keypackage_update_secs`, TDBE is allowed to generate and broadcast `SelfUpdateProposal`. --- it may happen that there's another committed `SelfUpdateProposal` (from a different sender) or `CommitRemoveTx`,-which makes TDBE's original `SelfUpdateProposal` -- in which case, it should re-generate and retry.+When there are concurrently pending mls commits, the operation will fail, so the operator should monitor the operation result, and retry when it failed.

done

yihuang

comment created time in a month

push eventyihuang/chain-docs

yihuang

commit sha b2a97c96270be8bd2e8a692e3cacf5ee86cc9e92

Problem (Fix #192): keypackage expiration handling not described in detail Solution: - add the details

view details

push time in a month

PullRequestReviewEvent

Pull request review commentcrypto-com/chain

Problem (Fix #2145): incorrect confirmed_transcript_hash calculation in mls

 impl<CS: CipherSuite + Ord> GroupAux<CS> {         })     } -    fn get_init_confirmed_transcript_hash(-        &self,-        sender: Sender,-        commit: &Commit<CS>,-    ) -> HashValue<CS> {-        let interim_transcript_hash = b"".to_vec(); // TODO+    /// spec: draft-ietf-mls-protocol.md#group-state+    fn new_confirmed_transcript_hash(&self, sender: Sender, commit: &Commit<CS>) -> HashValue<CS> {         let content_to_commit = message::MLSPlaintextCommitContent::new(             self.context.group_id.clone(),             self.context.epoch,             sender,             commit.clone(),         )         .get_encoding();-        let to_hash = [interim_transcript_hash, content_to_commit].concat();+        let to_hash = [+            self.interim_transcript_hash+                .as_ref()+                .map(|h| h.as_ref())+                .unwrap_or_default(),

yes, changed to more explicit unwrap_or(b""), and copied the spec as comment.

yihuang

comment created time in a month

push eventyihuang/chain

yihuang

commit sha 848aae4db296c24e24fb5a5153b4a10cb7d47a82

Problem (Fix #2145): incorrect confirmed_transcript_hash calculation in mls Solution: - update implementation according to spec

view details

push time in a month

Pull request review commentcrypto-com/chain-docs

Problem (Fix #192): keypackage expiration handling not described in detail

 the next node's TDBE (next non-empty leaf) should generate and broadcast `Commit and include Remove proposals as with the "commit timeout" case.  ###### Updates-After 1/3 of keypackage's lifetime is over, TDBE is allowed to generate and broadcast `SelfUpdateProposal`+When `keypackage.create_time + keypackage_expiration_secs > block_time >= keypackage.create_time + keypackage_update_secs`, TDBE is allowed to generate and broadcast `SelfUpdateProposal`. --- it may happen that there's another committed `SelfUpdateProposal` (from a different sender) or `CommitRemoveTx`,-which makes TDBE's original `SelfUpdateProposal` -- in which case, it should re-generate and retry.+When there are concurrently pending mls commits, the operation will fail, so the operator should monitor the operation result, and retry when it failed.

should the TDBE always wait for confirm(buried in block) of previous commit before sending next commit?

yihuang

comment created time in a month

PullRequestReviewEvent

PR opened crypto-com/chain

Reviewers
Problem (Fix #2145): incorrect confirmed_transcript_hash calculation in mls

Solution:

  • update implementation according to spec
+21 -16

0 comment

1 changed file

pr created time in a month

create barnchyihuang/chain

branch : issue2145

created branch time in a month

issue openedcrypto-com/chain

Problem: unnecessary memory copies in mls implementation

There are temporary structures (used to compute hash or serialization) can be changed to reference to avoid memory copies.

created time in a month

issue commentcrypto-com/chain

Problem: incorrect confirmed_transcript_hash calculation in mls

working on.

tomtau

comment created time in a month

PullRequestReviewEvent

PR opened crypto-com/chain-docs

Reviewers
Problem (Fix #192): keypackage expiration handling not described in detail

Solution:

  • add the details
+16 -5

0 comment

1 changed file

pr created time in a month

more