Describe the bug When attempting to send an amount larger than the wallet's current balance, grin-wallet will panick and exit ungracefully.

To Reproduce `nthrow@debian:~$ grin-wallet info Password: 20210126 18:08:18.953 WARN grin_wallet_libwallet::api_impl::owner_updater - Scanning - 0% complete 20210126 18:08:19.183 WARN grin_wallet_libwallet::api_impl::owner_updater - Scanning - 99% complete 20210126 18:08:19.198 WARN grin_wallet_libwallet::api_impl::owner_updater - Scanning - 99% complete 20210126 18:08:19.199 WARN grin_wallet_libwallet::api_impl::owner_updater - Scanning Complete

____ Wallet Summary Info - Account 'default' as of height 1063713 ____

Confirmed Total | 220.059956334 Awaiting Confirmation (< 10) | 0.000000000 Awaiting Finalization | 0.000000000

Command 'info' completed successfully nthrow@debian:~$ gwal send -e -m 220 Password:

Estimation for sending 220.000000000:

+--------------------+-------------+----------------+ | Selection strategy | Fee | Will be locked | +====================+=============+================+ | smallest | 0.023000000 | 220.059956334 | +--------------------+-------------+----------------+ | all | 0.023000000 | 220.059956334 | +--------------------+-------------+----------------+

Command 'send' completed successfully nthrow@debian:~$ grin-wallet send -e -m 220.5
Password: 20210126 18:08:33.539 ERROR grin_util::logger - thread 'main' panicked at 'called Result::unwrap() on an Err value: Error { inner:

Not enough funds. Required: 220.512500000, Available: 220.059956334 }': /home/vsts/work/1/s/controller/src/command.rs:294 0: grin_util::logger::send_panic_to_log::{{closure}} 1: std::panicking::rust_panic_with_hook at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/panicking.rs:597 2: std::panicking::begin_panic_handler::{{closure}} at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/panicking.rs:499 3: std::sys_common::backtrace::__rust_end_short_backtrace at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/sys_common/backtrace.rs:141 4: rust_begin_unwind at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/panicking.rs:495 5: core::panicking::panic_fmt at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/core/src/panicking.rs:92 6: core::option::expect_none_failed at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/core/src/option.rs:1268 7: grin_wallet_controller::command::send::{{closure}}::{{closure}} 8: <core::iter::adapters::Map<I,F> as core::iter::traits::iterator::Iterator>::fold 9: grin_wallet_controller::command::send::{{closure}} 10: grin_wallet_controller::controller::owner_single_use 11: grin_wallet_controller::command::send 12: grin_wallet::cmd::wallet_args::parse_and_execute 13: grin_wallet::cmd::wallet_args::wallet_command 14: grin_wallet::cmd::wallet::wallet_command 15: grin_wallet::real_main 16: grin_wallet::main 17: std::sys_common::backtrace::__rust_begin_short_backtrace 18: std::rt::lang_start::{{closure}} 19: core::ops::function::impls::<impl core::ops::function::FnOnce<A> for &F>::call_once at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/core/src/ops/function.rs:259 std::panicking::try::do_call at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/panicking.rs:381 std::panicking::try at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/panicking.rs:345 std::panic::catch_unwind at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/panic.rs:396 std::rt::lang_start_internal at /rustc/e1884a8e3c3e813aada8254edfa120e85bf5ffca/library/std/src/rt.rs:51 20: main 21: __libc_start_main 22: _start

Thread 'main' panicked with message: "called Result::unwrap() on an Err value: Error { inner:

Not enough funds. Required: 220.512500000, Available: 220.059956334 }" See /home/nthrow/.grin/main/grin-wallet.log for further details. `

Expected behavior A graceful response, such as a message saying "Not enough funds!" or whatever. Also, the ability to "send all" or "send max" with auto-calculation of fees would be amazing, as I found this bug in trying to do as much manually.

Desktop (please complete the following information): $ cat /etc/os-release PRETTY_NAME="Debian GNU/Linux 10 (buster)" NAME="Debian GNU/Linux" VERSION_ID="10" VERSION="10 (buster)" VERSION_CODENAME=buster ID=debian HOME_URL="https://www.debian.org/" SUPPORT_URL="https://www.debian.org/support" BUG_REPORT_URL="https://bugs.debian.org/"

Link to rendered text

Typo but --> by

Linked text doesn't show the fixed version

https://github.com/mimblewimble/grin-wallet/blob/master/api/src/owner.rs#L1941 To generate new slatepack addresses, you can iterate through the indexes on the derivation path designated for slatepack addresses.

We will likely have to introduce a new api type that solely exposes an endpoint to build a coinbase output. In the meanwhile it is recommended to use a reverse proxy in front of the wallet.

I think the fix is to include the tor executable in the grin snap

@jaspervdm No, this is not enhancement. This is a regression. It worked in previous releases.

@slavikus As a workaround you can edit the source code and fix with something like this: sed -i 's/127.0.0.1:{}/0.0.0.0:{}/' config/src/types.rs

Known issue. @jaspervdm Please comment - what is the plan?

Here is an additional possible/likely cause: https://github.com/mimblewimble/grin/issues/3550

@jyap808 Have you solve this problem? The error happens on my node.

20210121 06:46:34.054 DEBUG grin_store::lmdb - DB Mapsize for /root/.grin/main/wallet_data/db/lmdb is 549755813888
20210121 06:46:34.056 DEBUG grin_wallet_impls::lifecycle::seed - Using wallet seed file at: /root/.grin/main/wallet_data/wallet.seed
20210121 06:46:36.005 DEBUG grin_wallet_libwallet::api_impl::owner_updater - Updating outputs from node
20210121 06:46:36.006 ERROR grin_util::logger - 
thread 'unnamed' panicked at 'called `Result::unwrap()` on an `Err` value: "PoisonError { inner: .. }"': impls/src/client_utils/client.rs:349   0: grin_util::logger::send_panic_to_log::{{closure}}
   1: std::panicking::rust_panic_with_hook
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:581
   2: std::panicking::begin_panic_handler::{{closure}}
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:484
   3: std::sys_common::backtrace::__rust_end_short_backtrace
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/sys_common/backtrace.rs:153
   4: rust_begin_unwind
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:483
   5: core::panicking::panic_fmt
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/panicking.rs:85
   6: core::option::expect_none_failed
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/option.rs:1234
   7: std::sys_common::backtrace::__rust_begin_short_backtrace
   8: core::ops::function::FnOnce::call_once{{vtable.shim}}
   9: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/alloc/src/boxed.rs:1042
      <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/alloc/src/boxed.rs:1042
      std::sys::unix::thread::Thread::new::thread_start
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/sys/unix/thread.rs:87
  10: start_thread
  11: __clone

20210121 06:46:36.007 ERROR grin_util::logger - 
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Any': impls/src/client_utils/client.rs:351   0: grin_util::logger::send_panic_to_log::{{closure}}
   1: std::panicking::rust_panic_with_hook
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:581
   2: std::panicking::begin_panic_handler::{{closure}}
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:484
   3: std::sys_common::backtrace::__rust_end_short_backtrace
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/sys_common/backtrace.rs:153
   4: rust_begin_unwind
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:483
   5: core::panicking::panic_fmt
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/panicking.rs:85
   6: core::option::expect_none_failed
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/option.rs:1234
   7: grin_wallet_impls::client_utils::client::Client::send_request
   8: grin_wallet_impls::client_utils::client::Client::post
   9: <grin_wallet_impls::node_clients::http::HTTPNodeClient as grin_wallet_libwallet::types::NodeClient>::get_chain_tip
  10: grin_wallet_libwallet::internal::updater::refresh_outputs
  11: grin_wallet_libwallet::api_impl::owner::update_outputs
  12: grin_wallet_libwallet::api_impl::owner::update_wallet_state
  13: grin_wallet_libwallet::api_impl::owner::retrieve_summary_info
  14: grin_wallet_api::owner::Owner<L,C,K>::retrieve_summary_info
  15: <grin_wallet_api::owner::Owner<L,C,K> as grin_wallet_api::owner_rpc::OwnerRpc>::retrieve_summary_info
  16: <dyn grin_wallet_api::owner_rpc::OwnerRpc as easy_jsonrpc_mw::Handler>::handle
  17: easy_jsonrpc_mw::handle_call
  18: easy_jsonrpc_mw::handle_parsed_request
  19: easy_jsonrpc_mw::Handler::handle_request
  20: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll
  21: <hyper::proto::h1::dispatch::Server<S,hyper::body::body::Body> as hyper::proto::h1::dispatch::Dispatch>::poll_msg
  22: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_catch
  23: <hyper::server::conn::upgrades::UpgradeableConnection<I,S,E> as core::future::future::Future>::poll
  24: <hyper::server::conn::spawn_all::NewSvcTask<I,N,S,E,W> as core::future::future::Future>::poll
  25: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
  26: tokio::runtime::task::raw::poll
  27: std::thread::local::LocalKey<T>::with
  28: tokio::runtime::thread_pool::worker::Context::run_task
  29: tokio::runtime::thread_pool::worker::Context::run
  30: tokio::macros::scoped_tls::ScopedKey<T>::set
  31: tokio::runtime::thread_pool::worker::run
  32: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut
  33: tokio::runtime::task::core::Core<T,S>::poll
  34: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
  35: tokio::runtime::task::harness::Harness<T,S>::poll
  36: tokio::runtime::blocking::pool::Inner::run
  37: tokio::runtime::context::enter
  38: std::sys_common::backtrace::__rust_begin_short_backtrace
  39: core::ops::function::FnOnce::call_once{{vtable.shim}}
  40: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/alloc/src/boxed.rs:1042
      <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/alloc/src/boxed.rs:1042
      std::sys::unix::thread::Thread::new::thread_start
             at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/sys/unix/thread.rs:87
  41: start_thread
  42: __clone

It panicked when I invoke retrieveSummaryInfo or getRetrieveTxsByTxId.

Describe the bug The recent PR breaks the ability to mine on a node that runs on a remote machine.

ERROR grin_servers::mining::mine_block - Failed to get coinbase from http:/x.x.x.x:3415. Is the wallet listening? Request error: Cannot make request: error trying to connect: tcp connect error: Connection refused (os error 111) ERROR grin_servers::mining::mine_block - Error building new block: Can't connect to wallet listener at "http://x.x.x.x:3415"; will retry

"Method" is no longer supported to the best of my knowledge. https://github.com/mimblewimble/grin-wallet/blob/429db61bb7ef42f009abb8886fd90221301dfc74/src/bin/grin-wallet.yml#L59-L67

Keybase adapter still exists and should be removed: https://github.com/mimblewimble/grin-wallet/blob/7f5c010fed2f9177e0e24cc3eaa7b79be112390f/impls/src/adapters/keybase.rs

Wiki doesn't cover slatepacks: https://github.com/mimblewimble/docs/wiki/How-to-use-the-Grin-wallet

I'm wallet developer and I encountered a situation: How to generate an independent Slatepack address for each user, so that I can distinguish who made that transfer when someone send some GRINs? Thanks.

finalize_invoice_tx no longer exists.

Describe the bug

During the grinnode.live Winter 2020 Bug Bash Challenge a tester @mojitoo discovered a problem with the wallet. He was able to cause v5 wallet to 'tokio-runtime-worker' panic by initiating scan via Owner API. It was discovered while working on test case https://github.com/Grinnode-live/2020-grin-bug-bash-challenge/issues/37. His detailed info is provided in gist and I managed to reproduce the problem on my own

To Reproduce

Steps to reproduce the behavior:

1. Prepare a v5 wallet and put it in Owner API listener mode.
2. Make an API call to run a scan method.
3. You should see 'tokio-runtime-worker' panic in wallet v5 logs.

Bug will be reproduced if you follow steps from https://github.com/Grinnode-live/2020-grin-bug-bash-challenge/issues/37 test case.

Expected behavior

We would expect the 'tokio-runtime-worker' panic to not occur.

Screenshots

N/A

Desktop (please complete the following information):

Tester environment

Darwin MacBook-Pro-de-Workstation.local 19.5.0 Darwin Kernel Version 19.5.0: Tue May 26 20:41:44 PDT 2020; root:xnu-6153.121.2~2/RELEASE_X86_64 x86_64

Reproduction environment

Linux 4.19.0-12-amd64 #1 SMP Debian 4.19.152-1 (2020-10-18) x86_64 unknown unknown GNU/Linux

Additional context

Tester report and my report on reproducing the bug

I see the node become unresponsive also. I think its several different causes.

One cause for sure is when the node goes into a "rewind" loop it becomes unresponsive to the APIs (and everything else too). ex: 20210114 19:16:33.528 WARN grin_chain::txhashset::txhashset - rewind_single_block: 1 output_pos entries missing for: 000317af4605 at 860660

bdoyle@crypto:~$ grin-wallet address | grep grin
grin1XXXXX
bdoyle@crypto:~$ grin-wallet send -d grin1hXXXXX 1
20201229 18:55:18.278 WARN grin_wallet_api::owner - Attempting to send transaction via TOR
Wallet command failed: LibWallet Error: Payment Proof generation error: Original proof info not stored in tx

see also: https://github.com/Grinnode-live/2020-grin-bug-bash-challenge/issues/59

I noticed this also - snap is in some kind of sandbox/container. This may help: https://askubuntu.com/questions/1228899/accessing-files-outside-of-home-in-snap-apps

I think this has to do with the fact that packages in snap are confined somehow, they modify the path: https://snapcraft.io/docs/environment-variables

This environment variable is re-written by snapd so that it is consistent with the view of the filesystem presented to snap applications.

Not entirely sure yet what would be the best way for us to fix it.

using latest v5.0.2, commands sent to /v3/owner with encrypted_request_v3 cause a panic message and no data is returned. node_height request causes this:

20210112 21:02:45.303 ERROR grin_util::logger - thread 'unnamed' panicked at 'called Result::unwrap() on an Err value: "PoisonError { inner: .. }"': impls/src/client_utils/client.rs:349 0: grin_util::logger::send_panic_to_log::{{closure}} 1: std::panicking::rust_panic_with_hook at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:581 2: std::panicking::begin_panic_handler::{{closure}} at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:484 3: std::sys_common::backtrace::__rust_end_short_backtrace at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/sys_common/backtrace.rs:153 4: rust_begin_unwind at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:483 5: core::panicking::panic_fmt at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/panicking.rs:85 6: core::option::expect_none_failed at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/option.rs:1234 7: std::sys_common::backtrace::__rust_begin_short_backtrace 8: core::ops::function::FnOnce::call_once{{vtable.shim}} 9: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/alloc/src/boxed.rs:1042 <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/alloc/src/boxed.rs:1042 std::sys::unix::thread::Thread::new::thread_start at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/sys/unix/thread.rs:87 10: start_thread 11: __clone

Thread 'unnamed' panicked with message: "called Result::unwrap() on an Err value: "PoisonError { inner: .. }"" 20210112 21:02:45.323 ERROR grin_util::logger - thread 'tokio-runtime-worker' panicked at 'called Result::unwrap() on an Err value: Any': impls/src/client_utils/client.rs:351 0: grin_util::logger::send_panic_to_log::{{closure}} 1: std::panicking::rust_panic_with_hook at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:581 2: std::panicking::begin_panic_handler::{{closure}} at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:484 3: std::sys_common::backtrace::__rust_end_short_backtrace at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/sys_common/backtrace.rs:153 4: rust_begin_unwind at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/panicking.rs:483 5: core::panicking::panic_fmt at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/panicking.rs:85 6: core::option::expect_none_failed at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/option.rs:1234 7: grin_wallet_impls::client_utils::client::Client::send_request 8: grin_wallet_impls::client_utils::client::Client::post 9: <grin_wallet_impls::node_clients::http::HTTPNodeClient as grin_wallet_libwallet::types::NodeClient>::get_chain_tip 10: grin_wallet_libwallet::api_impl::owner::node_height 11: grin_wallet_api::owner::Owner<L,C,K>::node_height 12: <grin_wallet_api::owner::Owner<L,C,K> as grin_wallet_api::owner_rpc::OwnerRpc>::node_height 13: <dyn grin_wallet_api::owner_rpc::OwnerRpc as easy_jsonrpc_mw::Handler>::handle 14: easy_jsonrpc_mw::handle_call 15: easy_jsonrpc_mw::handle_parsed_request 16: easy_jsonrpc_mw::Handler::handle_request 17: <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll 18: <hyper::proto::h1::dispatch::Server<S,hyper::body::body::Body> as hyper::proto::h1::dispatch::Dispatch>::poll_msg 19: hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_catch 20: <hyper::server::conn::upgrades::UpgradeableConnection<I,S,E> as core::future::future::Future>::poll 21: <hyper::server::conn::spawn_all::NewSvcTask<I,N,S,E,W> as core::future::future::Future>::poll 22: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once 23: tokio::runtime::task::raw::poll 24: std::thread::local::LocalKey<T>::with 25: tokio::runtime::thread_pool::worker::Context::run_task 26: tokio::runtime::thread_pool::worker::Context::run 27: tokio::macros::scoped_tls::ScopedKey<T>::set 28: tokio::runtime::thread_pool::worker::run 29: tokio::loom::std::unsafe_cell::UnsafeCell<T>::with_mut 30: tokio::runtime::task::core::Core<T,S>::poll 31: <std::panic::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once 32: tokio::runtime::task::harness::Harness<T,S>::poll 33: tokio::runtime::blocking::pool::Inner::run 34: tokio::runtime::context::enter 35: std::sys_common::backtrace::__rust_begin_short_backtrace 36: core::ops::function::FnOnce::call_once{{vtable.shim}} 37: <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/alloc/src/boxed.rs:1042 <alloc::boxed::Box<F> as core::ops::function::FnOnce<A>>::call_once at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/alloc/src/boxed.rs:1042 std::sys::unix::thread::Thread::new::thread_start at /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/std/src/sys/unix/thread.rs:87 38: start_thread 39: __clone

Thread 'tokio-runtime-worker' panicked with message: "called Result::unwrap() on an Err value: Any"