profile
viewpoint
Alex Brausewetter xoob @bluecanvas Berlin 👾On a mission to make low-code developers more productive.

xoob/macvim-config 2

My MacVim and Janus configuration folder

xoob/DoctrineORMModule 1

Zend Framework 2 Module for Doctrine ORM

xoob/homebrew 1

The missing package manager for OS X.

xoob/macvim 1

Vim - the text editor - for Mac OS X

xoob/ace 0

Ace (Ajax.org Cloud9 Editor)

xoob/appengine-java-vm-guestbook 0

App Engine Java Managed VMs example

xoob/auth0-delegated-administration-extension 0

This extension allows non-dashboard administrators to manage (a subset of) users.

xoob/bootstrap-ajax 0

a library for adding declarative ajax functionality to your website

xoob/chrome-cpu-profiler 0

View Top down, Bottom up and flamecharts of your node app in Google Chrome

xoob/docker-gitlab 0

Dockerized GitLab

issue commentsalesforce/design-system-react

Generate Typescript and Flow type definitions from existing prop-types.

I'm currently waiting for a number of pull requests to land before we continue on this.

girishla

comment created time in a day

pull request commentsalesforce/design-system-react

Teach 'npm start' to start foreground processes

Also you would need an issue logged for this. I actually logged one but I couldn't link them.

I've linked them and added #2527 to the description @kmmkwong

xoob

comment created time in a day

pull request commentsalesforce/design-system-react

Teach 'npm start' to start foreground processes

@kmmkwong How do we proceed from here, who needs to approve this change so it can get merged?

xoob

comment created time in a day

pull request commentsalesforce/design-system-react

Remove any use of `javascript:` URLs

@garygong, any more feedback about these changes? I'd like to get them merged before continuing on TypeScript compatibility...

xoob

comment created time in a day

startedAutodesk/continuous-threat-modeling

started time in 2 days

startedizar/pytm

started time in 2 days

startedtiangolo/fastapi

started time in 20 days

startedandrewvasilchuk/vue-accessible-modal

started time in a month

startediandol/scrivomatic

started time in a month

push eventbluecanvas/node-bluecanvas-sdk

Alex Brausewetter

commit sha 75b60c72d87fafe3098bf852df64d34569549a53

Create SECURITY.md

view details

push time in a month

push eventbluecanvas/example-node-eventhandler

Alex Brausewetter

commit sha 024e858aa423b0883f93218b2e9797bc07e2d2ac

Tweak demo messages

view details

push time in a month

push eventbluecanvas/node-bluecanvas-sdk

Alex Brausewetter

commit sha 0e700f6ad42404425a8ef51c1169d3887f4cec39

Do not log token exchange requests

view details

push time in a month

push eventbluecanvas/example-node-eventhandler

Alex Brausewetter

commit sha 667a6e9e1a0ae4cec566a5caed0ac85ac5a4ce9a

Initial commit

view details

push time in a month

push eventbluecanvas/example-node-eventhandler

Alex Brausewetter

commit sha f754c1b329d74afcf6a52de16139abdc7fbeb5e0

Initial commit

view details

push time in a month

create barnchbluecanvas/example-node-eventhandler

branch : master

created branch time in a month

push eventbluecanvas/node-bluecanvas-sdk

Alex Brausewetter

commit sha 7bea4329268785dabbf155c81ed201ae268ec162

Add LICENSE

view details

push time in a month

startedsalesforce/policy_sentry

started time in a month

create barnchbluecanvas/node-bluecanvas-sdk

branch : master

created branch time in a month

created repositorybluecanvas/node-events-example

A simple example of responding to Blue Canvas event notifications in Node.js

created time in a month

created repositorybluecanvas/node-bluecanvas-sdk

Official library for using the Blue Canvas API

created time in a month

startedjaredpalmer/formik

started time in 2 months

pull request commentsalesforce/design-system-react

Remove any use of `javascript:` URLs

Snapshot tests are failing. Is it okay to just refresh the snapshots? Anything I should look out for?

xoob

comment created time in 2 months

startedcorona-warn-app/cwa-documentation

started time in 2 months

PR opened salesforce/design-system-react

Teach 'npm start' to start foreground processes

This change tells 'npm start' to run the two servers with 'concurrently', to avoid the background process not exiting correctly. We noticed that node tests/browser-tests-app stays alive if npm start is killed with Ctrl-C.


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • [ ] First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • [ ] npm run lint:fix has been run and linting passes.
  • [ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • [ ] Tests have been added for new props to prevent regressions in the future. See readme.
  • [ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
  • [ ] Review tests are passing in the browser. Open http://localhost:8001/.
  • [ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • [ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • [ ] Tests have been added for new props to prevent regressions in the future. See readme.
  • [ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
  • [ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • [ ] Review tests are passing in the browser. Open http://localhost:8001/.
  • [ ] Review markup conforms to SLDS by looking at DOM snapshot strings.
+3 -1

0 comment

1 changed file

pr created time in 2 months

create barnchbluecanvas/design-system-react

branch : start-concurrently

created branch time in 2 months

issue commentsalesforce/design-system-react

Generate Typescript and Flow type definitions from existing prop-types.

We are adding .d.ts files for the existing library. Our work utilizes tsc with allowJs and checkJs, and KnisterPeter/react-to-typescript-definitions. The goal is to be able to import the library into TypeScript projects and get code completion, strict validation, and no import errors, while trying to keep the changes to the library as minimal as possible.

girishla

comment created time in 2 months

push eventbluecanvas/design-system-react

Alex Brausewetter

commit sha cc770a862820b1fec8ae15b4a926b14242472d1f

Run 'npm lint:fix'

view details

push time in 2 months

push eventbluecanvas/design-system-react

Alex Brausewetter

commit sha 50f9185c130bf39b7674d850ba06c12e4688d7cf

Remove eslint `no-script-url` annotations

view details

push time in 2 months

push eventbluecanvas/design-system-react

Alex Brausewetter

commit sha 42680730849817dacaaadc864cfca550c0834db4

Fix linter errors

view details

push time in 2 months

PR opened salesforce/design-system-react

Remove any use of `javascript:` URLs

Fixes #2384 and #2493

Additional description

This maintenance change provides compatibility with React DOM 16.9, which introduced a deprecation warning for javascript: URLs in facebook/react#15047:

Warning: A future version of React will block javascript: URLs as
a security precaution. Use event handlers instead if you can. If you need
to generate unsafe HTML try using dangerouslySetInnerHTML instead.

Changes have been smoke tested but require more detailed testing before they can be merged.

To-Do

  • [ ] Test that all changed components are working as expected. We need instructions from the maintainer where to start and what to look for.
  • [ ] Discuss a11y warnings with maintainer. npm run lint now throws these warnings:
[lint:quality] components/alert/index.jsx
[lint:quality]   190:7  error  Anchor used as a button. Anchors are primarily expected to navigate. Use the button element instead. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid
[lint:quality] components/builder-header/__examples__/failed-save.jsx
[lint:quality]   73:11  error  The href attribute requires a valid value to be accessible. Provide a valid, navigable address as the href value. If you cannot provide a valid href, but still need the element to resemble a link, use a button and change it with appropriate styles. Learn more: https://github.com/evcohen/eslint-plugin-jsx-a11y/blob/master/docs/rules/anchor-is-valid.md  jsx-a11y/anchor-is-valid

CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • [ ] First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • [ ] npm run lint:fix has been run and linting passes.
  • [ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • [ ] Tests have been added for new props to prevent regressions in the future. See readme.
  • [ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
  • [ ] Review tests are passing in the browser. Open http://localhost:8001/.
  • [ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • [ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • [ ] Tests have been added for new props to prevent regressions in the future. See readme.
  • [ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
  • [ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • [ ] Review tests are passing in the browser. Open http://localhost:8001/.
  • [ ] Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • [ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • [ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • [ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • [ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.
+308 -226

0 comment

84 changed files

pr created time in 2 months

create barnchbluecanvas/design-system-react

branch : no-javascript-links

created branch time in 2 months

PR opened bluecanvas/design-system-react

Compatibility with React 16.13

This maintenance change introduces compatibility with the current stable releases of React, React DOM, and a number of other smaller libraries. We upgrade the libraries and provide bugfixes for several warnings and library behavior changes that were found during testing.

  • Fixes #2386, #2385, #2463
  • Might fix #2384
  • Might fix #2493

After the initial upgrade the observed test failures were as follows:

SLDSAlert: [javascript URLs]
    Dismiss alert
        "before each" hook: mountComponentInside for "calls onRequestClose handler"

    Error: Warning: A future version of React will block javascript: URLs as
    a security precaution. Use event handlers instead if you can. If you need
    to generate unsafe HTML try using dangerouslySetInnerHTML instead.

SLDS APP LAUNCHER TILE: [componentWillUpdate]
    App Launcher Tile (truncated)
        "before each" hook for "renders more link"

    Error: Warning: componentWillUpdate has been renamed, and is not
    recommended for use. See https://fb.me/react-unsafe-component-lifecycles
    for details.

     * Move data fetching code or side effects to componentDidUpdate.
     * Rename componentWillUpdate to UNSAFE_componentWillUpdate to suppress this
       warning in non-strict mode. In React 17.x, only the UNSAFE_ name will
       work. To rename all deprecated lifecycles to their new names, you can
       run `npx react-codemod rename-unsafe-lifecycles` in your project
       source folder.

SLDSColorPicker: [componentWillMount]
    Swatch toggle button
        opens popover when clicked and expects onRequestOpen and onOpen to be fired once

    Error: Warning: componentWillMount has been renamed, and is not
    recommended for use. See https://fb.me/react-unsafe-component-lifecycles
    for details.

    * Move code with side effects to componentDidMount, and set initial state in the constructor.
    * Rename componentWillMount to UNSAFE_componentWillMount to suppress this
      warning in non-strict mode. In React 17.x, only the UNSAFE_ name will
      work. To rename all deprecated lifecycles to their new names, you can
      run `npx react-codemod rename-unsafe-lifecycles` in your project source
      folder.

SLDSCombobox: [componentWillUpdate]
    Assistive technology and keyboard interactions
        has aria-haspopup, aria-expanded is false when closed, aria-expanded is true when open‣

    Error: Warning: componentWillUpdate has been renamed, and is not
    recommended for use. See https://fb.me/react-unsafe-component-lifecycles
    for details.

SLDSMenuPicklist: [componentWillMount]
    in modal mode
        "before each" hook for "expands/contracts the dropdown on click"‣

    Error: Warning: componentWillMount has been renamed, and is not
    recommended for use. See https://fb.me/react-unsafe-component-lifecycles
    for details.

SLDSTimepicker: [React.createFactory()]
    Timepicker Value Prop Change
        displays a modified state upon changing props‣

    Error: Warning: React.createFactory() is deprecated and will be removed
    in a future major release. Consider using JSX or use
    React.createElement() directly instead.

Tree: [onScroll timeout?]
    Scrolling calls onScroll
        scrolling calls onScroll‣

    Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure
    "done()" is called; if returning a Promise, ensure it resolves.

SLDS Visual Picker: [componentWillMount]
    radio switching works correctly‣

    Error: Warning: componentWillMount has been renamed, and is not
    recommended for use. See https://fb.me/react-unsafe-component-lifecycles
    for details.

SLDSWelcomeMat: [componentWillMount]
    Steps Variant
        "before each" hook for "renders welcome mat"‣

    Error: Warning: componentWillMount has been renamed, and is not
    recommended for use. See https://fb.me/react-unsafe-component-lifecycles
    for details.

    Trailhead Variant
        "before each" hook for "renders welcome mat"‣

    Error: Warning: componentWillMount has been renamed, and is not
    recommended for use. See https://fb.me/react-unsafe-component-lifecycles
    for details.

React DOM: Upgrade from 16.8.6 to 16.13

At the time of this pull request, the master branch of design-system-react is locked in package-lock.json to react-dom@16.8.6 and react@16.9.0. Unit tests are succeeding in master.

React DOM version 16.9 introduces two deprecation warnings that cause the design-system-react test suite to fail after the react-dom dependency is upgraded:

React DOM

  • Deprecate old names for the UNSAFE_* lifecycle methods. (facebook/react#15186 and facebook/react#16103)
  • Deprecate javascript: URLs as a common attack surface. (facebook/react#15047)

React: Upgrade from 16.9.0 to 16.13

To keep up-to-date with new React releases, this pull request bumps to the latest stable version. Notable changes between the old and new version are:

React

  • Deprecate React.createFactory() (facebook/react#17878)

Other Upgrades

We use this opportunity to upgrade a few other dependencies that include small bug fixes and other seemingly useful improvements.

prop-types: Upgrade from 15.6.0 to 15.7.2

https://github.com/facebook/prop-types/blob/master/CHANGELOG.md

react-contenteditable: Upgrade from 3.3.1 to 3.3.4

  • Trivial fixes

https://github.com/lovasoa/react-contenteditable/compare/3.3.1...v3.3.4

shortid: Upgrade from 2.2.14 to 2.2.15

  • Generate smaller IDs

https://github.com/dylang/shortid/compare/2.2.14...2.2.15


CONTRIBUTOR checklist (do not remove)

Please complete for every pull request

  • [ ] First-time contributors should sign the Contributor License Agreement. It's a fancy way of saying that you are giving away your contribution to this project. If you haven't before, wait a few minutes and a bot will comment on this pull request with instructions.
  • [ ] npm run lint:fix has been run and linting passes.
  • [ ] Mocha, Jest (Storyshots), and components/component-docs.json CI tests pass (npm test).
  • [ ] Tests have been added for new props to prevent regressions in the future. See readme.
  • [ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
  • [ ] Review tests are passing in the browser. Open http://localhost:8001/.
  • [ ] Review markup conforms to SLDS by looking at DOM snapshot strings.

REVIEWER checklist (do not remove)

  • [ ] TravisCI tests pass. This includes linting, Mocha, Jest, Storyshots, and components/component-docs.json tests.
  • [ ] Tests have been added for new props to prevent regressions in the future. See readme.
  • [ ] Review the appropriate Storybook stories. Open http://localhost:9001/.
  • [ ] The Accessibility panel of each Storybook story has 0 violations (aXe). Open http://localhost:9001/.
  • [ ] Review tests are passing in the browser. Open http://localhost:8001/.
  • [ ] Review markup conforms to SLDS by looking at DOM snapshot strings.
Required only if there are markup / UX changes
  • [ ] Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • [ ] Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • [ ] Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • [ ] While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.
+45 -95

0 comment

2 changed files

pr created time in 2 months

issue commentsalesforce/design-system-react

Generate Typescript and Flow type definitions from existing prop-types.

Hey everyone, we are currently working on adding TypeScript compatibility for design-system-react and will provide a pull request that will add strict type definitions for every component and their prop types.

girishla

comment created time in 2 months

create barnchbluecanvas/design-system-react

branch : react-16.13

created branch time in 2 months

issue commentsalesforce/design-system-react

Prevent javascript URLs warning in React 16.9

Just a heads-up, this is causing npm run test:unit to fail hard.

  SLDSAlert:
    Dismiss alert
      ✗ "before each" hook: mountComponentInside for "calls onRequestClose handler"
	Error: Warning: A future version of React will block javascript: URLs as a security precaution. Use event handlers instead if you can. If you need to generate unsafe HTML try using dangerouslySetInnerHTML instead. React was passed %s.%s
hannes-o-brunner

comment created time in 2 months

more