profile
viewpoint

startedigniterealtime/openfire-monitoring-plugin

started time in 8 hours

startedigniterealtime/openfire-hazelcast-plugin

started time in 8 hours

startedigniterealtime/openfire-search-plugin

started time in 8 hours

startedigniterealtime/openfire-justmarried-plugin

started time in 8 hours

startedigniterealtime/openfire-broadcast-plugin

started time in 8 hours

startedigniterealtime/openfire-threaddump-plugin

started time in 8 hours

startedigniterealtime/openfire-passwordreset-plugin

started time in 8 hours

startedigniterealtime/openfire-blacklistSpam-plugin

started time in 8 hours

startedigniterealtime/openfire-httpFileUpload-plugin

started time in 8 hours

startedigniterealtime/openfire-restAPI-plugin

started time in 8 hours

startedigniterealtime/openfire-ofmeet-plugin

started time in 8 hours

startedigniterealtime/openfire-pushnotification-plugin

started time in 8 hours

startedigniterealtime/openfire-bookmarks-plugin

started time in 8 hours

startedigniterealtime/openfire-inverse-plugin

started time in 8 hours

startedigniterealtime/openfire-certificateManager-plugin

started time in 8 hours

startedigniterealtime/openfire-pade-plugin

started time in 8 hours

startedigniterealtime/pade

started time in 8 hours

startedigniterealtime/Smack

started time in 8 hours

pull request commentigniterealtime/openfire-broadcast-plugin

Update BroadcastPlugin.java

Usually we would also update readme.html (add new properties with explanation) and changelog.html (add next version with TBD instead of a release date and add the link to the ticket).

Created https://github.com/igniterealtime/openfire-broadcast-plugin/issues/7

Triskele69

comment created time in 2 days

issue openedigniterealtime/openfire-broadcast-plugin

Add prefix options for groups

Add options to prefix group name in broadcast message

created time in 2 days

push eventigniterealtime/Spark

wroot

commit sha 98ae3adb4967127b81aab05aa2d7c9f95e16d6ea

Fix typo

view details

push time in 3 days

push eventigniterealtime/Spark

arthur

commit sha 93c1c784fb6105c233f4a3997026a202767bf4a5

Replace usage of deprecated method with alternative. Deprecated method: org.jivesoftware.smack.packet.Stanza.setFrom(java.lang.String) Alternative method: org.jivesoftware.smack.packet.Stanza.setFrom(org.jxmpp.jid.Jid)

view details

arthur

commit sha 297993d69ae8c083951a507fd60e563cdcd1d544

Delete usage of deprecated method. Deprecated method: org.jxmpp.util.XmppStringUtils.parseBareAddress

view details

arthur

commit sha 954bf85178266affb8f66e418e7aac10e89672a0

Replace usage of deprecated method with alternative and delete redundant methods. 1. Deprecated method: org.jivesoftware.smackx.muc.MultiUserChatManager.getHostedRooms Alternative method: org.jivesoftware.smackx.muc.MultiUserChatManager.getRoomsHostedBy

view details

arthur

commit sha 77d5dd77140ab28aeddecbd354cc871b7bd8d6b0

Replace usage of deprecated method with alternative. Deprecated method: javax.swing.JList.getSelectedValues Alternative method: javax.swing.JList.getSelectedValuesList

view details

arthur

commit sha 5bd221e188a02f98211009f418d58bcca5001650

Replace usage of deprecated method with alternative. Deprecated method: java.io.File.toURL Alternative method: java.io.File.toURI and java.net.URI.toURL

view details

arthur

commit sha e6b72dd587a3b52378fcff997d91707c050201ae

Replace usage of deprecated method with alternative. Deprecated method: org.jivesoftware.smack.AbstractXMPPConnection.addPacketInterceptor Alternative method: org.jivesoftware.smack.AbstractXMPPConnection.addStanzaInterceptor

view details

wroot

commit sha 52bf82ce5364b639e9c826e1a26fad2677929fb7

Merge pull request #549 from R87A/SPARK-1160 SPARK-1160: Still getting rid of deprecated methods usage

view details

push time in 4 days

push eventigniterealtime/Spark

wroot

commit sha 97f5653da6bba7a79c9b72f4f33cd4ed68dfb544

SPARK-2181 Update JTattoo to 1.6.13

view details

wroot

commit sha 96a7b0ffa372f6e77d2081147190a4a2e7b49f53

Merge pull request #548 from wrooot/master SPARK-2181 Update JTattoo to 1.6.13

view details

push time in 4 days

PR merged igniterealtime/Spark

SPARK-2181 Update JTattoo to 1.6.13
+1 -1

0 comment

1 changed file

wrooot

pr closed time in 4 days

PR opened igniterealtime/Spark

SPARK-2181 Update JTattoo to 1.6.13
+1 -1

0 comment

1 changed file

pr created time in 4 days

push eventwrooot/Spark

wroot

commit sha 97f5653da6bba7a79c9b72f4f33cd4ed68dfb544

SPARK-2181 Update JTattoo to 1.6.13

view details

push time in 4 days

fork wrooot/Spark

Cross-platform real-time collaboration client optimized for business and organizations.

https://www.igniterealtime.org/projects/spark/

fork in 4 days

pull request commentigniterealtime/Spark

SPARK-1160: Continue getting rid of deprecated methods

I knew not to close that ticket yet :D

R87A

comment created time in 5 days

push eventigniterealtime/Spark

arthur

commit sha dde7115b7b97a01b2bae903baf51b9607de85d5c

Delete unused deprecated method. Deprecated method: org.jivesoftware.spark.ui.ContactItem.getFullyQualifiedJID

view details

arthur

commit sha a47077269d2701e7c3aa835d4ccc823e16b084e3

Delete unnecessary setters and make ContactList class members representing UI components final.

view details

arthur

commit sha 943e355eabfe6a527d7b165392c35dfb47dae024

Delete unused deprecated method. Deprecated method: org.jivesoftware.spark.ChatManager.createConferenceRoom(java.lang.String, java.lang.String)

view details

arthur

commit sha 4f22cf7e6462ae572e34244a7f6082245bcbc93a

Delete unused deprecated method. Deprecated method: org.jivesoftware.spark.PresenceManager.isAvailable(java.lang.String)

view details

arthur

commit sha b106d1f8fef472ddc722f9c7a39e8480f9822075

Replace usage of deprecated method with alternative and delete method itself. Deprecated method: org.jivesoftware.spark.PresenceManager.getPresence(java.lang.String) Alternative method: org.jivesoftware.spark.PresenceManager.getPresence(org.jxmpp.jid.BareJid)

view details

wroot

commit sha 7414669bdf0bd55659e256a5d1199d201e48a205

Merge pull request #547 from R87A/SPARK-1160 SPARK-1160: Continue getting rid of deprecated methods

view details

push time in 5 days

push eventigniterealtime/Spark

wroot

commit sha f974654ac9d7ded9fb733668d57db0470dddae45

Typo - has instead of have

view details

push time in 5 days

push eventigniterealtime/Spark

arthur

commit sha fb4799a6aa0994e182126ded9e0e24a24e79c388

Fix renamed method call

view details

arthur

commit sha ff3099aeadfc815a4c6b5837c8833d5c3fde37bd

Replace usage of deprecated method with alternative and remove method itself. Deprecated method: org.jivesoftware.spark.ui.ChatRoom.getRoomname(). Alternative method: org.jivesoftware.spark.ui.ChatRoom.getBareJid().

view details

arthur

commit sha 8eb2cec285936fb6c868126d9d6ca2d5033be79d

Replace usage of deprecated method with alternative. Deprecated method: org.jivesoftware.smack.roster.RosterEntry.getUser(). Alternative method: org.jivesoftware.smack.roster.RosterEntry.getJid().

view details

arthur

commit sha 48708bdb07d2a71099312a705c5fdacda2bad95d

Replace usage of deprecated method with alternative. Deprecated method: ``` public void org.jivesoftware.smack.packet.setTo(String) ``` Alternative method: ``` public void org.jivesoftware.smack.packet.setTo(Jid) ```

view details

arthur

commit sha f450301048c06657bb0e2cc2400f6a190c9d1aa4

Replace usage of deprecated method with alternative. Deprecated method: ``` org.jivesoftware.smack.SmackException.NoResponseException.newWith(org.jivesoftware.smack.XMPPConnection, org.jivesoftware.smack.filter.StanzaFilter) ``` Alternative method: ``` org.jivesoftware.smack.SmackException.NoResponseException.newWith(org.jivesoftware.smack.XMPPConnection, org.jivesoftware.smack.filter.StanzaFilter) ```

view details

arthur

commit sha 52f4d7ab05e75f5c2c62d5e343f416cc7bbf9408

Replace usage of deprecated method with alternative and remove method itself. Deprecated method: ``` org.jivesoftware.spark.SessionManager.getBareAddress ``` Alternative method: ``` org.jivesoftware.spark.SessionManager.getUserBareAddress ``` Alternative method renamed from getBareUserAddress() to getUserBareAddress().

view details

arthur

commit sha c59bb5f0575df9dcf3811b9cf454cf111aa55947

Replace usage of deprecated methods with alternatives and remove methods themselves. 1. Deprecated method: org.jivesoftware.sparkimpl.plugin.privacy.list.PrivacyPresenceHandler.sendUnavailableTo(java.lang.String) Alternative method: org.jivesoftware.sparkimpl.plugin.privacy.list.PrivacyPresenceHandler.sendUnavailableTo(org.jxmpp.jid.Jid) 2. Deprecated method: org.jivesoftware.sparkimpl.plugin.privacy.list.PrivacyPresenceHandler.sendRealPresenceTo(java.lang.String) Alternative method: org.jivesoftware.sparkimpl.plugin.privacy.list.PrivacyPresenceHandler.sendRealPresenceTo(org.jxmpp.jid.Jid) 3. Some refactor and dead code removal.

view details

arthur

commit sha e59dffbcd89ddf5e3af124b58d69703c4595a07a

Replace usage of deprecated method with alternative and remove method itself. Deprecated method: org.jivesoftware.spark.UserManager.getUserNicknameFromJID(java.lang.CharSequence) Alternative method: org.jivesoftware.spark.UserManager.getUserNicknameFromJID(org.jxmpp.jid.BareJid)

view details

arthur

commit sha c99446860ba4f32abb142c0011135ad7aa5d6fd5

Delete unused deprecated method. Deprecated method: org.jivesoftware.spark.ui.rooms.ChatRoomImpl.setparticipantJID(java.lang.String) Alternative method: org.jivesoftware.spark.ui.rooms.ChatRoomImpl.setParticipantJID Method org.jivesoftware.spark.ui.rooms.ChatRoomImpl#setparticipantJID renamed to: org.jivesoftware.spark.ui.rooms.ChatRoomImpl#setParticipantJID

view details

arthur

commit sha 0907a9af877ff102efc169bdb6e2dc1dfdb71b2c

Replace usage of deprecated method with alternative and delete method itself. Deprecated method: org.jivesoftware.sparkimpl.plugin.gateways.transports.TransportUtils.getTransport(java.lang.String) Alternative method: org.jivesoftware.sparkimpl.plugin.gateways.transports.TransportUtils.getTransport(org.jxmpp.jid.DomainBareJid)

view details

arthur

commit sha 28cdae1ea15298468cf232c35a7872bd9a5c878f

Delete unused deprecated method. Deprecated method: org.jivesoftware.sparkimpl.plugin.gateways.transports.TransportUtils.addTransport(java.lang.String, org.jivesoftware.sparkimpl.plugin.gateways.transports.Transport)

view details

arthur

commit sha 8d614399bbc8232f01af869ac64f0c2bbfa4f2b0

Replace usage of deprecated method with alternative and delete method itself. Deprecated method: org.jivesoftware.spark.ChatManager.getChatRoom(java.lang.String) Alternative method: org.jivesoftware.spark.ChatManager.getChatRoom(org.jxmpp.jid.EntityBareJid)

view details

arthur

commit sha 4163b80e2ef3cc9608edd70e9b06d0cac3672310

Replace usage of deprecated method with alternative and delete method itself. Deprecated method: org.jivesoftware.spark.ui.ContactItem.getJID Alternative method: org.jivesoftware.spark.ui.ContactItem.getJid

view details

wroot

commit sha 0af135086ab211f35e616677cb523ae9808a30db

Merge pull request #546 from R87A/SPARK-1160 SPARK-1160: Replace usage of deprecated methods with alternatives and delete methods themselves

view details

push time in 6 days

PR merged igniterealtime/Spark

SPARK-1160: Replace usage of deprecated methods with alternatives and delete methods themselves

Most of the bugs that I had to work on were related, among other things, to the use of deprecated methods. Also the condition of some parts of Spark's code is depressing :). So I think it's worth doing a little code cleanup and refactor. Let's start with getting rid of deprecated methods and dead code. SPARK-1160: Remove deprecated methods usage

+178 -356

0 comment

51 changed files

R87A

pr closed time in 6 days

push eventigniterealtime/Spark

akrherz

commit sha 24dce9789ba6aff9ce5b276ebcaa9926678dd28a

Denote Spark 2.9.3 Release

view details

wroot

commit sha f6f919148e7dde4eec8cd2f4bd35a003a3bb8a7d

Merge pull request #545 from akrherz/293 Denote Spark 2.9.3 Release

view details

push time in 7 days

PR merged igniterealtime/Spark

Denote Spark 2.9.3 Release
+65 -23

0 comment

24 changed files

akrherz

pr closed time in 7 days

pull request commentigniterealtime/Spark

SPARK-2064: Fix reconnection to group chat rooms.

Thanks! Now we are ready for 2.9.3 release :)

R87A

comment created time in 7 days

push eventigniterealtime/Spark

arthur

commit sha f7f29871e4a0f22657aa73f1ea2d51f8d262589a

Move reconnection handling code and remove redundant method

view details

R87A

commit sha f8a4c0e3f92b42bf5a46a17add70e5ae76778aad

SPARK-2064: Fix reconnection to group chat rooms

view details

wroot

commit sha e5425962ffb9f8650912352f579eb256e51b8e46

Merge pull request #544 from R87A/SPARK-2064 SPARK-2064: Fix reconnection to group chat rooms.

view details

push time in 7 days

issue commentigniterealtime/openfire-search-plugin

Deal better with case-sensitivity, accents and special characters.

https://issues.igniterealtime.org/browse/SPARK-2048 was filed because of that. Closing it now as Not a bug in Spark.

guusdk

comment created time in 8 days

push eventigniterealtime/Spark

arthur

commit sha 45ad39d07c1c9d916450a1d66713b02b255c540a

Reformat the BuzzPlugin.java code.

view details

arthur

commit sha 1146b4da90c15ae260c70cd377e72f7e12583a0c

SPARK-2179: Fix escaping in the incoming buzz notification message.

view details

wroot

commit sha f3c5be7cf908763fd81d1709fb32931b6a21d941

Merge pull request #543 from R87A/SPARK-2179 SPARK-2179: Fix escaping in the incoming buzz notification message.

view details

push time in 8 days

issue commentigniterealtime/spark-jxbrowser

Which version of jxbrowser?

Actually, we decided to go away from JxBrowser in Spark. So, not sure if this project will see any updates.

fgroupindonesia

comment created time in 11 days

push eventigniterealtime/Spark

dependabot[bot]

commit sha 1beadf33c3984c85cf824637a11dbfdcc6f581a1

Bump junit from 4.12 to 4.13.1 in /plugins/translator Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

wroot

commit sha c0c746f544310f84bd33d08cc3ba44e0880fe279

Merge pull request #542 from igniterealtime/dependabot/maven/plugins/translator/junit-junit-4.13.1 Bump junit from 4.12 to 4.13.1 in /plugins/translator SPARK-2178

view details

push time in 18 days

PR merged igniterealtime/Spark

Bump junit from 4.12 to 4.13.1 in /plugins/translator dependencies

Bumps junit from 4.12 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> <h2>JUnit 4.13</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p> <h2>JUnit 4.13 RC 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 RC 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.12...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 18 days

push eventigniterealtime/Spark

dependabot[bot]

commit sha 6b71674414c62b0b396bc002282fb6c110d5c63e

Bump junit from 4.8.2 to 4.13.1 in /core Bumps [junit](https://github.com/junit-team/junit4) from 4.8.2 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](https://github.com/junit-team/junit4/compare/r4.8.2...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com>

view details

wroot

commit sha f5795bb0e38a57bb777ccc8e879410f97f4377a4

Merge pull request #541 from igniterealtime/dependabot/maven/core/junit-junit-4.13.1 Bump junit from 4.8.2 to 4.13.1 in /core SPARK-2178

view details

push time in 19 days

PR merged igniterealtime/Spark

Bump junit from 4.8.2 to 4.13.1 in /core dependencies

Bumps junit from 4.8.2 to 4.13.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/releases">junit's releases</a>.</em></p> <blockquote> <h2>JUnit 4.13.1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.1.md">release notes</a> for details.</p> <h2>JUnit 4.13</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.13.md">release notes</a> for details.</p> <h2>JUnit 4.13 RC 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 RC 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 2</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.13 Beta 1</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit4/wiki/4.13-Release-Notes">release notes</a> for details.</p> <h2>JUnit 4.12</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.12.md">release notes</a> for details.</p> <h2>JUnit 4.12 Beta 3</h2> <p>Please refer to the <a href="https://github.com/junit-team/junit/blob/HEAD/doc/ReleaseNotes4.12.md">release notes</a> for details.</p> <h2>JUnit 4.12 Beta 2</h2> <p>No release notes provided.</p> <h2>JUnit 4.12 Beta 1</h2> <p>No release notes provided.</p> <h2>JUnit 4.11</h2> <p>No release notes provided.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md">junit's changelog</a>.</em></p> <blockquote> <h2>Summary of changes in version 4.13.1</h2> <h1>Rules</h1> <h3>Security fix: <code>TemporaryFolder</code> now limits access to temporary folders on Java 1.7 or later</h3> <p>A local information disclosure vulnerability in <code>TemporaryFolder</code> has been fixed. See the published <a href="https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp">security advisory</a> for details.</p> <h1>Test Runners</h1> <h3>[Pull request <a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1669">#1669</a>:](<a href="https://github-redirect.dependabot.com/junit-team/junit/pull/1669">junit-team/junit#1669</a>) Make <code>FrameworkField</code> constructor public</h3> <p>Prior to this change, custom runners could make <code>FrameworkMethod</code> instances, but not <code>FrameworkField</code> instances. This small change allows for both now, because <code>FrameworkField</code>'s constructor has been promoted from package-private to public.</p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/junit-team/junit4/commit/1b683f4ec07bcfa40149f086d32240f805487e66"><code>1b683f4</code></a> [maven-release-plugin] prepare release r4.13.1</li> <li><a href="https://github.com/junit-team/junit4/commit/ce6ce3aadc070db2902698fe0d3dc6729cd631f2"><code>ce6ce3a</code></a> Draft 4.13.1 release notes</li> <li><a href="https://github.com/junit-team/junit4/commit/c29dd8239d6b353e699397eb090a1fd27411fa24"><code>c29dd82</code></a> Change version to 4.13.1-SNAPSHOT</li> <li><a href="https://github.com/junit-team/junit4/commit/1d174861f0b64f97ab0722bb324a760bfb02f567"><code>1d17486</code></a> Add a link to assertThrows in exception testing</li> <li><a href="https://github.com/junit-team/junit4/commit/543905df72ff10364b94dda27552efebf3dd04e9"><code>543905d</code></a> Use separate line for annotation in Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/510e906b391e7e46a346e1c852416dc7be934944"><code>510e906</code></a> Add sub headlines to class Javadoc</li> <li><a href="https://github.com/junit-team/junit4/commit/610155b8c22138329f0723eec22521627dbc52ae"><code>610155b</code></a> Merge pull request from GHSA-269g-pwp5-87pp</li> <li><a href="https://github.com/junit-team/junit4/commit/b6cfd1e3d736cc2106242a8be799615b472c7fec"><code>b6cfd1e</code></a> Explicitly wrap float parameter for consistency (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1671">#1671</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/a5d205c7956dbed302b3bb5ecde5ba4299f0b646"><code>a5d205c</code></a> Fix GitHub link in FAQ (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1672">#1672</a>)</li> <li><a href="https://github.com/junit-team/junit4/commit/3a5c6b4d08f408c8ca6a8e0bae71a9bc5a8f97e8"><code>3a5c6b4</code></a> Deprecated since jdk9 replacing constructor instance of Double and Float (<a href="https://github-redirect.dependabot.com/junit-team/junit4/issues/1660">#1660</a>)</li> <li>Additional commits viewable in <a href="https://github.com/junit-team/junit4/compare/r4.8.2...r4.13.1">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 19 days

push eventigniterealtime/Spark

R87A

commit sha c40aeb19efc45359a186b2ee607da2604738f1d2

SPARK-2177: Prevent automatic status change to away or offline during reconnection.

view details

R87A

commit sha 13275a9bb430c962e6e88b87930f83327208aa11

SPARK-2177: Disable manual status change during reconnection.

view details

R87A

commit sha 48fabeee61189bbe30711bf17fa1af5f0c3298d6

SPARK-2177: Add offline status text to the status panel.

view details

wroot

commit sha 1d6a9fd51c2dbed0b3906815f81821e946a40e1e

Merge pull request #540 from R87A/SPARK-2177 SPARK-2177: Fix own presence state during and after a reconnection

view details

push time in 19 days

PR merged igniterealtime/Spark

SPARK-2177: Fix own presence state during and after a reconnection
  • Prevent automatic status change to away/offline during reconnection
  • Disable manual status change during reconnection
  • Add offline status text to the status panel

Issue ticket: SPARK-2177

+16 -1

0 comment

3 changed files

R87A

pr closed time in 19 days

push eventigniterealtime/Spark

R87A

commit sha 9ac4cfd92ace0c9f673e91df4eb27784effb8e39

Do not handle offline messages in ChatRoomImpl class. Offline messages are handling by Workspace class only. So it's prevent offline messages duplicate.

view details

R87A

commit sha d2c3ba957b18b80eda1a26fa3b7de011302be3eb

Merge remote-tracking branch 'upstream/master' into SPARK-2175

view details

wroot

commit sha 7f5c371f6619d488a581fe736233bb3bf0e25923

Merge pull request #539 from R87A/SPARK-2175 SPARK-2175: Fix "only the first offline message comes" bug.

view details

push time in 20 days

push eventigniterealtime/Spark

R87A

commit sha 015970e3d72aac395fd588a4f940182b0d52dd49

Fix chat room existence check and chat room creation. Existence check should take into account the actual type of the parameter passed to the method. There it is important to distinguish JID (EntityJid type) and bare JID (EntityBareJid type) since both are used: bare JIDs - within one-on-one chats; full JIDs - within private chats of group chat members.

view details

R87A

commit sha 88845242ba2b9b4e43b62099b7842c9e91d79f3b

Don't handle offline messages if the corresponding chat room has already been created. This eliminates duplicate messages in the transcript window when the user reconnects while the chat room is open.

view details

wroot

commit sha 918c15adba9ffe457da1274f99024a91e9728378

Merge pull request #538 from R87A/SPARK-2175 SPARK-2175: Fix offline message handling after a reconnect

view details

push time in 20 days

PR merged igniterealtime/Spark

SPARK-2175: Fix offline message handling after a reconnect

This prevents new tab creation for chat room that has already been opened. SPARK-2175

+38 -43

0 comment

3 changed files

R87A

pr closed time in 20 days

push eventigniterealtime/Spark

R87A

commit sha 3e70662ba738e81184e47dedd5e3d1dd32ea6c5a

SPARK-2143: Add reconnection event handling to one-on-one chat room. This fixes the issue with roster always on top and disabled controls in chat room dialog after reconnection.

view details

R87A

commit sha 4071638db29f5602b977f789ca69cc091a9c84f4

SPARK-2174: Change tab icons of chat rooms to "unavailable" when disconnected.

view details

R87A

commit sha a9f5edf03d198f70f9ae90c535a4f60d05aee999

SPARK-2174: Import the forgotten class.

view details

wroot

commit sha 9aee1afe246608fb3478c0b1b28cdaa3014d4545

Merge pull request #537 from R87A/SPARK-2143 SPARK-2143, SPARK-2174

view details

push time in 21 days

PR merged igniterealtime/Spark

SPARK-2143, SPARK-2174

SPARK-2143: Added reconnection event handling to one-on-one chat room. SPARK-2174: Changing tab icons of chat rooms to "unavailable" when disconnected.

+12 -6

0 comment

3 changed files

R87A

pr closed time in 21 days

pull request commentigniterealtime/Spark

SPARK-2143: Fix behavior of contact list during reconnection

Thanks. I have created https://issues.igniterealtime.org/browse/SPARK-2174 for the presence status in tabs. And will ask Ilya to clarify the 4. :)

R87A

comment created time in 22 days

push eventigniterealtime/Spark

R87A

commit sha 31abf18ca4f8d2c42421a48d5e79999eec88e1c5

Refactor: rename getRoomJid() to getBareJid() in ChatRoom class and its derived classes for more clarity.

view details

R87A

commit sha 0a101c05eecc60a7c78502eb63c34a680309341c

Add an overloaded getChatRoom () method that requires a parameter of type EntityBareJid. This fixes the issue with duplicate dialog tabs.

view details

R87A

commit sha 9288c9098ca764fdc5f320bf813a4bcfbce5f5d5

Fix behavior of contact list during reconnection.

view details

R87A

commit sha 1eec1b5b5073ed1a5e5eb46b2a93b0009e14e63e

Merge remote-tracking branch 'upstream/master' into SPARK-2143

view details

wroot

commit sha d48e222733d8b9eac280dc9749119a27f3c28ecd

Merge pull request #536 from R87A/SPARK-2143 SPARK-2143: Fix behavior of contact list during reconnection

view details

push time in 22 days

PR merged igniterealtime/Spark

SPARK-2143: Fix behavior of contact list during reconnection

Contact list behavior corrected according to items no. 2, 3 and 5 of ilyaHlevnoy feedback. No change of contact's status to offline in the dialog box when the user lost the connection (item no. 1 of feedback) seems to be another issue, that shoud be reported. Item no. 4 of feedback - I could not understand what it was about :). Also fixed one-on-one chats broken during SPARK-2153 fix.

+49 -38

0 comment

14 changed files

R87A

pr closed time in 22 days

issue commentxsf/xmpp.org

Font is too small on Windows systems

Thanks you. Just received new newsletter notification and the font is much better now :)

wrooot

comment created time in 24 days

pull request commentigniterealtime/Spark

SPARK-2143: Fix contacts duplication after reconnect

Ilya also provided some feedback. Side effect with duplicating tabs if you try sending messages to a tab that was open before reconnection, etc. https://discourse.igniterealtime.org/t/spark-2-9-0-after-reconnecting-some-users-change-their-status-to-red/88485/12

R87A

comment created time in 25 days

pull request commentigniterealtime/Spark

SPARK-2143: Fix contacts duplication after reconnect

Thanks. I wonder is it possible for contacts to turn not red after a few seconds during reconnecting. Now they stay red until you reconnect. Not a huge problem. After a reconnect all now offline contacts are not red, so this is good. I have asked Ilya to test new build. The only side effect i have noticed, that it doesn't switch back to Online after reconnect and is stuck in Away status and you have to switch it to Online manually.

R87A

comment created time in 25 days

push eventigniterealtime/Spark

ostre

commit sha 99a7a1994b99b132f101af5d74e2a2911d235c22

Reformat code of ContactGroup.java

view details

ostre

commit sha d499b2b205cb5e90dd91106f1b633e996276ff92

Reformat code of ContactList.java

view details

ostre

commit sha 0c11a9dd93db6cd0f41bd350e631342edc9a56f0

Prevent duplication of contacts after reconnect. Add a method to recursively update the presence of contact list items (in groups, subgroups and so on). Replace building of "Initial contact list" with it's updating after recconnect .

view details

wroot

commit sha a9b1d29d40ec149f1196755ad0b945d473c122ad

Merge pull request #535 from R87A/SPARK-2143 SPARK-2143: Fix contacts duplication after reconnect

view details

push time in 25 days

PR merged igniterealtime/Spark

SPARK-2143: Fix contacts duplication after reconnect

I hope one active forum user will be happy. SPARK-2143

+915 -1064

0 comment

2 changed files

R87A

pr closed time in 25 days

push eventigniterealtime/Spark

arthur

commit sha d01de10e418baf52deeb5e33be4c29f2b86b510d

Disable automatic activation of the new private chat room created when the first message arrived.

view details

wroot

commit sha f978ff830c633932b14c23d35bfdeae42dbc765b

Merge pull request #534 from R87A/SPARK-2172 SPARK-2172: Disable automatic activation of the new private chat room created when the first message arrived

view details

push time in a month

issue commentolsh/Feedly-Notifier

Donate button doesn't work

I see. Thanks for providing this useful tool. Hope it will live on and keep improving.

wrooot

comment created time in a month

issue commentolsh/Feedly-Notifier

Donate button doesn't work

So, i see you have removed the donate button. Is https://www.paypal.me/feedlynotifier still valid for donations? :)

wrooot

comment created time in a month

pull request commentigniterealtime/Spark

SPARK-2153: Fix private messaging in group chat.

Thanks again :100:

R87A

comment created time in a month

push eventigniterealtime/Spark

arthur

commit sha faaeb35864b44a7a5c0dbad6cb3e1c46bb0c54cb

Fix private messaging in group chat. To address private rooms in a group chat, you need to use EntityJid instead of EntityBareJid. [See section 7.5 of XEP-0045: Multi-User Chat](https://xmpp.org/extensions/xep-0045.html#privatemessage)

view details

wroot

commit sha 4a1241e57549d3b676333a0fbbacbc3ffced617e

Merge pull request #533 from R87A/SPARK-2153 SPARK-2153: Fix private messaging in group chat.

view details

push time in a month

PR merged igniterealtime/Spark

SPARK-2153: Fix private messaging in group chat.

To address private rooms in a group chat, you need to use full JID instead of bare JID. See section 7.5 of XEP-0045: Multi-User Chat

+27 -16

0 comment

5 changed files

R87A

pr closed time in a month

pull request commentigniterealtime/Spark

SPARK-2162: Fix history issues for contacts with spaces in usernames

Fixed. Thanks a lot, again! :+1:

R87A

comment created time in a month

push eventigniterealtime/Spark

arthur

commit sha 040beea9a89932c759c7aec43e3d96e48d751a58

Fix history issues for contacts with spaces in usernames

view details

arthur

commit sha fe6526c31fc37e93127c762d92eb77641a163743

Merge branch 'master' into SPARK-2162

view details

wroot

commit sha a76cc1bdc16c3e193b5329182d479d607d08b04e

Merge pull request #532 from R87A/SPARK-2162 SPARK-2162: Fix history issues for contacts with spaces in usernames

view details

push time in a month

PR merged igniterealtime/Spark

SPARK-2162: Fix history issues for contacts with spaces in usernames

Use unescaped JID to prevent creating files with backslashes in the name.

+3 -3

0 comment

3 changed files

R87A

pr closed time in a month

pull request commentigniterealtime/Spark

SPARK-2170: Fix converting emote expressions to icons

Thanks, this fixed it.

R87A

comment created time in a month

push eventigniterealtime/Spark

arthur

commit sha 3d890fc3f56872c6db4f7c622596f56ec6f000ce

Fix converting emote expressions to icons

view details

wroot

commit sha b3eac15fd2536fb663e936391789f19ccf985e10

Merge pull request #531 from R87A/SPARK-2170 SPARK-2170: Fix converting emote expressions to icons

view details

push time in a month

PR merged igniterealtime/Spark

SPARK-2170: Fix converting emote expressions to icons

It was a minor algorithmic error.

+3 -3

0 comment

1 changed file

R87A

pr closed time in a month

issue commentxsf/xmpp.org

Font is too small on Windows systems

Yes, it is using Arial on Windows. Which i don't mind that much, although Arial looks worse. But it also then becomes much smaller. image

wrooot

comment created time in a month

issue commentxsf/xmpp.org

Font is too small on Windows systems

I don't have dual boot to test on the same machine. But i have Windows and Ubuntu VMs, which both use 1024x768 resolution, 100% zoom in both browsers. Both using Firefox (though on Windows same is with Chromium Edge). image

wrooot

comment created time in a month

issue commentxsf/xmpp.org

Font is too small on Windows systems

I see the same in Firefox Inspector (Merriweather, serif and 16px font-size).

wrooot

comment created time in a month

pull request commentigniterealtime/Spark

SPARK-2169: Rendering messages in chat area

Of course, our https://discourse.igniterealtime.org forums is also a place to discuss things. Especially with users.

R87A

comment created time in a month

pull request commentigniterealtime/Spark

SPARK-2169: Rendering messages in chat area

Thanks again. I have noticed a small side effect https://issues.igniterealtime.org/browse/SPARK-2170

Btw, do you join our group chat at http://www.igniterealtime.org/support/group_chat.jsp ? We can create a user for you and then you can use any XMPP client to join, if you don't want to use the anonymous web browser version. @akrherz can arrange you an account there.

Or do you prefer some other way of communication? There are groups in GitHub, and i tried to create one in the past, but it never took off. I have invited you into Spark Developers team here. If you accept if, you can go to https://github.com/orgs/igniterealtime/teams/spark-developers/discussions and we can discuss anything there. Maybe you can tell about what other issues you are planning to work on, etc. I was going to ask if you would be willing to take a look at a few major bugs since 2.9.0. fixing one or few of them would warrant the release of 2.9.3.

https://issues.igniterealtime.org/browse/SPARK-2143 https://issues.igniterealtime.org/browse/SPARK-2153 https://issues.igniterealtime.org/browse/SPARK-2162

Anyway, thanks for working on Spark. Any even small fix or just a cleanup is appreciated :+1:

R87A

comment created time in a month

push eventigniterealtime/Spark

arthur

commit sha d6d4d0d76137290a8c5a9a4a2eb81862e8e8c243

Optimize messages rendering in chat area. Make it possible to correctly handle network addresses containing spaces when enclosed in quotes.

view details

wroot

commit sha 543fbd1439a0cdf537594b1e2688a40c4195600b

Merge pull request #530 from R87A/SPARK-2169 SPARK-2169: Rendering messages in chat area

view details

push time in a month

PR merged igniterealtime/Spark

SPARK-2169: Rendering messages in chat area

Optimize messages rendering in chat area. Make it possible to correctly handle network addresses containing spaces when enclosed in quotes.

+65 -61

0 comment

1 changed file

R87A

pr closed time in a month

push eventigniterealtime/Spark

arthur

commit sha 273fb77989bba24af1b3f99f69091fa72b8d4305

Add missed string constants (static final fields) for default properties to Default class. - ADD_CONTACT_GROUP_DISABLED - CHANGE_COLORS_DISABLED - DISABLE_AVATAR_TAB - DISABLE_BROADCAST_MENU_ITEM - DISABLE_EDIT_PROFILE - DISABLE_EXIT - DISABLE_FILE_XFER - DISABLE_MOVE_AND_COPY - DISABLE_PLUGINS_MENU_ITEM - DISABLE_PREFERENCES_MENU_ITEM - DISABLE_PRESENCE_STATUS_CHANGE - DISABLE_REMOVALS - DISABLE_RENAMES - DISABLE_VIEW_NOTES - DISABLE_VIEW_TASK_LIST - HELP_FORUM - HELP_FORUM_DISABLED - HELP_FORUM_TEXT - HELP_USER_GUIDE_DISABLED - PLUGIN_BLACKLIST - PLUGIN_BLACKLIST_CLASS - PLUGIN_REPOSITORY - PLUGIN_REPOSITORY_USE_PROXY - PROXY_PROTOCOL

view details

arthur

commit sha d9f297a1cf746e5905496c31da5794969372b0ba

Replace string literals with constants from Default class.

view details

arthur

commit sha 7444cd9d4390a8eadf1b71339e4a95983430cf3c

Clean up grammar and typos, refactor some unobvious property names and remove trailing whitespace.

view details

wroot

commit sha fe2f6067613de534293ee37605d2fd8734afab79

Merge pull request #529 from R87A/default-properties Add more consistency to default properties usage Can be part of SPARK-2167

view details

push time in a month

PR merged igniterealtime/Spark

Add more consistency to default properties usage
  1. Add missed string constants (static final fields) for default properties to Default class.
  2. Replace string literals with constants from Default class.
  3. Clean up grammar and typos, refactor some unobvious property names and remove trailing white space.
+157 -133

0 comment

29 changed files

R87A

pr closed time in a month

push eventigniterealtime/Spark

Dele Olajide

commit sha cf6b319ffd87d4c9f704d0615d757635334e7d0a

Disable ofmeet spark plugin See https://issues.igniterealtime.org/browse/SPARK-2161 See https://issues.igniterealtime.org/browse/SPARK-2166

view details

wroot

commit sha 3bc27dcf605dcafaa4b4e7733d15af115fd1dccc

Merge pull request #528 from igniterealtime/deleolajide-patch-1 Disable ofmeet spark plugin

view details

push time in a month

PR merged igniterealtime/Spark

Disable ofmeet spark plugin

See https://issues.igniterealtime.org/browse/SPARK-2161 See https://issues.igniterealtime.org/browse/SPARK-2166

+1 -1

0 comment

1 changed file

deleolajide

pr closed time in a month

push eventigniterealtime/Spark

arthur

commit sha 16ea21113f2d1d83540e47d7bb9651872c636685

Add file transfer events saving to chat history.

view details

arthur

commit sha 6705a7b4c359d5ff8551a6a1c19268e9eddc32bc

Fix misspelling and typos, reformat code.

view details

wroot

commit sha b5ca39a52f62727f9b8e2b308ba34b7d5719ba6b

Merge pull request #527 from R87A/SPARK-2168 SPARK-2168: Add file transfer events saving to chat history

view details

push time in a month

PR merged igniterealtime/Spark

SPARK-2168: Add file transfer events saving to chat history

Add file transfer events saving as messages to chat history.

Handled events on sender side:

  • sending request for file transfer;
  • rejecting request by recipient;
  • file sending completion;
  • file sending error;
  • file sending canceling.

Handled events on recipient side:

  • receiving request for file transfer;
  • rejecting request;
  • accepting request;
  • file receiving completion;
  • file receiving error;
  • file receiving canceling.

Some properties, corresponding to messages for these events, where added to i18n resources for default and ru_RU locales.

Also: fix misspelling and typos, reformat code.

+318 -316

0 comment

5 changed files

R87A

pr closed time in a month

push eventigniterealtime/Spark

arthur

commit sha 09a977d866fabb2038543195f1d04f70f7ef6680

Reformat code and remove some whitespace.

view details

arthur

commit sha e1ff5555a024f5862735da56283a6bbbef2a11ef

Fix behavior of the login dialog related to handling the default property "HOST_NAME_CHANGE_DISABLED".

view details

arthur

commit sha 06ac959bc63a87ba8ec141c65c8edac4d835d591

Replace some string literals with constants.

view details

wroot

commit sha 7299465bed718d90ba831e7921f47cb73e5dc4ec

Merge pull request #526 from R87A/SPARK-2167 SPARK-2167 Fix handling the default property "HOST_NAME_CHANGE_DISABLED".

view details

push time in a month

PR merged igniterealtime/Spark

SPARK-2167 Fix handling the default property "HOST_NAME_CHANGE_DISABLED".

Reformat code and remove some white space. Fix behavior of the login dialog related to handling the default property "HOST_NAME_CHANGE_DISABLED". Replace some string literals with constants.

+446 -556

1 comment

2 changed files

R87A

pr closed time in a month

pull request commentigniterealtime/Spark

SPARK-2167: Fix login dialog behavior.

For sure, not a problem. It often happens when i submit a PR and later see an error or typo. I can just do new commit in my fork and it goes as a new commit to the existing PR automagically :)

R87A

comment created time in a month

pull request commentigniterealtime/Spark

SPARK-2167: Fix login dialog behavior.

I agree with akrherz. It will be hard to look for regressions later or just to create another PR by looking at this one as an example. Maybe you can redo this.

R87A

comment created time in 2 months

pull request commentigniterealtime/Spark

Fix typos and refactor duplicated property in i18n resources

I have assigned you to spark-developers group in Jira and assigned this ticket to you ;)

R87A

comment created time in 2 months

push eventigniterealtime/Spark

arthur

commit sha 5fc7707841de84ca911df1d8cdb2cb9b4a90b5a7

Fix typos and refactor duplicated property in i18n resources.

view details

wroot

commit sha a38c7ecde0b5db92652147e7d234eed768e820ea

Merge pull request #524 from R87A/improve-i18n Fix typos and refactor duplicated property in i18n resources

view details

push time in 2 months

PR merged igniterealtime/Spark

Fix typos and refactor duplicated property in i18n resources

Fix typos in identifiers and duplicated property in internationalization resources by refactor. Also remove some trailing spaces. p.s. This is my first contribution to a project on GitHub, so I decided to start with less significant and more fail safe things than I wanted to. If this will take success then I would like to contribute much more to this project.

+144 -142

1 comment

29 changed files

R87A

pr closed time in 2 months

pull request commentigniterealtime/Spark

Fix typos and refactor duplicated property in i18n resources

Thanks! I have created https://issues.igniterealtime.org/browse/SPARK-2165 for this. If you have account in our JIRA, i can assign it as completed by you. Looking forward to more patches ;)

R87A

comment created time in 2 months

push eventigniterealtime/Spark

wroot

commit sha 9e6526626edf941abdaa1587740a77d4b2587955

Fix typo

view details

push time in 2 months

more