profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/whiskeysierra/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Willi Schönborn whiskeysierra Zalando SE Berlin, Germany http://codereligion.com

ioggstream/draft-polli-ratelimit-headers 23

Standardizing RateLimit headers

jhorstmann/zuchini 6

A reimplementation of gherkin and cucumber for java based on antlr4 and junit

whiskeysierra/jackson-module-unknown-property 6

Jackson extension module that adds standardized logging of unknown properties

whiskeysierra/impaired-vision 5

A Simulator for Impaired Vision using Augmented Reality

whiskeysierra/archer 3

Architectural Enforcement

whiskeysierra/gesture-remote 3

VLC Gesture Remote Control for Android

whiskeysierra/banshie 1

A benchmarking framework to evaluate information extraction quality

whiskeysierra/compass 1

Config Management Service

whiskeysierra/git-dispatcher 1

A git command to manage git-hooks

whiskeysierra/git-hooks 1

A small dispatcher for git hooks

startedmaxwellhertz/gin-casbin

started time in 4 hours

startedmicrosoft/TypeScript-Node-Starter

started time in 5 hours

startedarrow-py/arrow

started time in 5 hours

issue commentzalando/logbook

Logbook Netty: Unable to log HTTP/2 trafic

O.k. this is definitely a feature request. logbook-netty does not support http2.

Here is an minimal way to reproduce this behavior:

<project xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
    xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <groupId>org.test</groupId>
    <artifactId>logbook-netty-http2</artifactId>
    <version>0.0.1-SNAPSHOT</version>
    <parent>
        <groupId>org.springframework.boot</groupId>
        <artifactId>spring-boot-starter-parent</artifactId>
        <version>2.4.3</version>
        <relativePath /> <!-- lookup parent from repository -->
    </parent>
    <properties>
        <java.version>11</java.version>
    </properties>
    <dependencies>
        <dependency>
            <groupId>org.springframework.boot</groupId>
            <artifactId>spring-boot-starter-webflux</artifactId>
        </dependency>
        <dependency>
            <groupId>org.zalando</groupId>
            <artifactId>logbook-core</artifactId>
            <version>2.5.0</version>
        </dependency>
        <dependency>
            <groupId>org.zalando</groupId>
            <artifactId>logbook-netty</artifactId>
            <version>2.5.0</version>
        </dependency>
    </dependencies>
</project>
public class Main {

    public static void main(String[] args) throws Exception {
        HttpClient httpClient = HttpClient.create()
                .protocol(HttpProtocol.H2).secure()
                .doOnConnected(connection -> connection.addHandlerLast(new LogbookClientHandler(Logbook.create())));
        WebClient webClient = WebClient.builder().clientConnector(new ReactorClientHttpConnector(httpClient))
                .build();

        webClient.get()
                .uri("https://www.google.com")
                .retrieve()
                .bodyToMono(String.class)
                .block(Duration.ofSeconds(5));
    }
}
PascalSchumacher

comment created time in 14 hours

push eventhashicorp/consul-helm

Luke Kysow

commit sha b4f167ecb769288f69b663d9f492745b3d63f811

Disable nightly OpenShift acc. tests (#847) OpenShift 4.4 seems to have a lot of issues with flakiness due to pod scheduling occasionally failing. Disabling these tests until we can use a more up-to-date version that hopefully fixes the issues.

view details

push time in 15 hours

delete branch hashicorp/consul-helm

delete branch : disable-openshift-accept

delete time in 15 hours

PR merged hashicorp/consul-helm

Disable nightly OpenShift acc. tests

OpenShift 4.4 seems to have a lot of issues with flakiness due to pod scheduling occasionally failing. Disabling these tests until we can use a more up-to-date version that hopefully fixes the issues.

+1 -1

0 comment

1 changed file

lkysow

pr closed time in 15 hours

PR opened hashicorp/consul-helm

Disable nightly OpenShift acc. tests

OpenShift 4.4 seems to have a lot of issues with flakiness due to pod scheduling occasionally failing. Disabling these tests until we can use a more up-to-date version that hopefully fixes the issues.

+1 -1

0 comment

1 changed file

pr created time in 16 hours

create barnchhashicorp/consul-helm

branch : disable-openshift-accept

created branch time in 16 hours

startedhummingbard/dendrite

started time in 16 hours

Pull request review commenthashicorp/consul-helm

Add acceptance test for metrics merging

 func TestMetrics(t *testing.T) { 	assertGatewayMetricsEnabled(t, ctx, ns, "mesh-gateway", `envoy_cluster_assignment_stale{local_cluster="mesh-gateway",consul_source_service="mesh-gateway",consul_source_namespace="default",consul_source_datacenter="dc1",envoy_cluster_name="local_agent"} 0`) } +// Test that merged service and envoy metrics are accessible from the+// endpoints that have been exposed on the service.+func TestAppMetrics(t *testing.T) {+	env := suite.Environment()+	cfg := suite.Config()+	ctx := env.DefaultContext(t)+	ns := ctx.KubectlOptions(t).Namespace++	helmValues := map[string]string{+		"global.datacenter":                 "dc1",+		"global.metrics.enabled":            "true",+		"global.metrics.enableAgentMetrics": "true",++		// These are images that are required until https://github.com/hashicorp/consul/pull/9768 and https://github.com/hashicorp/consul-k8s/pull/443+		"global.imageK8S": "gcr.io/nitya-293720/consul-k8s-dev:metrics30",+		"global.image":    "gcr.io/nitya-293720/consul-dev:metrics10",++		"connectInject.enabled":                      "true",+		"connectInject.metrics.defaultEnableMerging": "true",++		"controller.enabled": "true",+	}++	releaseName := helpers.RandomName()++	// Install the consul cluster in the default kubernetes ctx.+	consulCluster := consul.NewHelmCluster(t, helmValues, ctx, cfg, releaseName)+	consulCluster.Create(t)++	// Deploy service that will emit app and envoy metrics at merged metrics endpoint+	logger.Log(t, "creating static-metrics-app")+	k8s.Deploy(t, ctx.KubectlOptions(t), cfg.NoCleanupOnFailure, cfg.DebugDirectory, "../fixtures/bases/static-metrics-app/deployment.yaml")++	// Create the static-client deployment so we can use it for in-cluster calls to metrics endpoints.+	// This simulates queries that would be made by a prometheus server that runs externally to the consul+	// components in the cluster.+	logger.Log(t, "creating static-client")+	k8s.DeployKustomize(t, ctx.KubectlOptions(t), cfg.NoCleanupOnFailure, cfg.DebugDirectory, "../fixtures/cases/static-client-inject")++	// Merged App Metrics+	podList, err := ctx.KubernetesClient(t).CoreV1().Pods(ns).List(context.Background(), metav1.ListOptions{LabelSelector: "app=static-metrics-app"})+	require.NoError(t, err)+	require.Len(t, podList.Items, 1)+	podIP := podList.Items[0].Status.PodIP+	metricsOutput, err := k8s.RunKubectlAndGetOutputE(t, ctx.KubectlOptions(t), "exec", "deploy/"+staticClientName, "--", "curl", fmt.Sprintf("http://%s:20200/metrics", podIP))+	require.NoError(t, err)+	require.Contains(t, metricsOutput, `envoy_cluster_assignment_stale{local_cluster="server",consul_source_service="server",consul_source_namespace="default",consul_source_datacenter="dc1",envoy_cluster_name="local_agent"} 0`)+	require.Contains(t, metricsOutput, `service_started_total 1`)

could we add a comment here that this is the metric emitted by the app?

thisisnotashwin

comment created time in 17 hours

Pull request review commenthashicorp/consul-helm

Add acceptance test for metrics merging

 func TestMetrics(t *testing.T) { 	assertGatewayMetricsEnabled(t, ctx, ns, "mesh-gateway", `envoy_cluster_assignment_stale{local_cluster="mesh-gateway",consul_source_service="mesh-gateway",consul_source_namespace="default",consul_source_datacenter="dc1",envoy_cluster_name="local_agent"} 0`) } +// Test that merged service and envoy metrics are accessible from the+// endpoints that have been exposed on the service.+func TestAppMetrics(t *testing.T) {+	env := suite.Environment()+	cfg := suite.Config()+	ctx := env.DefaultContext(t)+	ns := ctx.KubectlOptions(t).Namespace++	helmValues := map[string]string{+		"global.datacenter":                 "dc1",+		"global.metrics.enabled":            "true",+		"global.metrics.enableAgentMetrics": "true",

do we need agent metrics for this test?

thisisnotashwin

comment created time in 17 hours

Pull request review commenthashicorp/consul-helm

Add acceptance test for metrics merging

 func TestMetrics(t *testing.T) { 	assertGatewayMetricsEnabled(t, ctx, ns, "mesh-gateway", `envoy_cluster_assignment_stale{local_cluster="mesh-gateway",consul_source_service="mesh-gateway",consul_source_namespace="default",consul_source_datacenter="dc1",envoy_cluster_name="local_agent"} 0`) } +// Test that merged service and envoy metrics are accessible from the+// endpoints that have been exposed on the service.+func TestAppMetrics(t *testing.T) {+	env := suite.Environment()+	cfg := suite.Config()+	ctx := env.DefaultContext(t)+	ns := ctx.KubectlOptions(t).Namespace++	helmValues := map[string]string{+		"global.datacenter":                 "dc1",+		"global.metrics.enabled":            "true",+		"global.metrics.enableAgentMetrics": "true",++		// These are images that are required until https://github.com/hashicorp/consul/pull/9768 and https://github.com/hashicorp/consul-k8s/pull/443+		"global.imageK8S": "gcr.io/nitya-293720/consul-k8s-dev:metrics30",+		"global.image":    "gcr.io/nitya-293720/consul-dev:metrics10",++		"connectInject.enabled":                      "true",+		"connectInject.metrics.defaultEnableMerging": "true",++		"controller.enabled": "true",

do we need controller?

thisisnotashwin

comment created time in 17 hours

issue commenthashicorp/consul-helm

Upgrade "consul" failed: post-upgrade hooks failed: timed out waiting for the condition

Hi, can you give more explicit instructions for a cluster starting from scratch?

e.g. do I follow this first? https://toolkit.fluxcd.io/get-started/

mrad-bilel

comment created time in 19 hours

startedappleboy/gin-jwt

started time in 20 hours

startedFoundry376/Mailspring

started time in a day

issue commentzalando/logbook

RestTemplate returns NULL data while using LogbookClientHttpRequestInterceptor

It seems, this bug is fixed in scope of Fix empty response... #948 changes in v2.4.2.

sergkunz

comment created time in a day

pull request commentzalando/opentracing-toolbox

DefaultTracer#writeTo now tolerates NoopTracer

In #522 I've mentioned three possible ways of solving this (and there might be others). This implements the one I find most reasonable.

Feel free to reject this if you think it should be done differently.

Thanks a lot for the help :smile:

ePaul

comment created time in a day

Pull request review commentzalando/opentracing-toolbox

DefaultTracer#writeTo now tolerates NoopTracer

 public String currentId() {      @Override     public void writeTo(final BiConsumer<String, String> writer) {-        writer.accept(Header.FLOW_ID, currentId());+        extractor.extract(activeSpan())

would it make sense to change the other writeTo method in the same way?

ePaul

comment created time in a day

Pull request review commentzalando/opentracing-toolbox

DefaultTracer#writeTo now tolerates NoopTracer

     void shouldThrowNoActiveSpanFoundException() {

Not throwing exceptions is the right direction here - can we also make this test now throw?

ePaul

comment created time in a day

delete branch zalando/opentracing-toolbox

delete branch : dependabot/maven/kotlin.version-1.4.31

delete time in a day

push eventzalando/opentracing-toolbox

dependabot-preview[bot]

commit sha 57aaa601560225963d13af7aedcc757eb56cdc75

Bump kotlin.version from 1.4.30 to 1.4.31 Bumps `kotlin.version` from 1.4.30 to 1.4.31. Updates `kotlin-stdlib` from 1.4.30 to 1.4.31 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](https://github.com/JetBrains/kotlin/commits) Updates `kotlin-stdlib-common` from 1.4.30 to 1.4.31 - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md) - [Commits](https://github.com/JetBrains/kotlin/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

Gregor Zeitlinger

commit sha 17468fe4e13b6429edba9b2b28a546d812d89150

Merge pull request #525 from zalando/dependabot/maven/kotlin.version-1.4.31 Bump kotlin.version from 1.4.30 to 1.4.31

view details

push time in a day

PR merged zalando/opentracing-toolbox

Reviewers
Bump kotlin.version from 1.4.30 to 1.4.31 dependencies

Bumps kotlin.version from 1.4.30 to 1.4.31. Updates kotlin-stdlib from 1.4.30 to 1.4.31 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md">kotlin-stdlib's changelog</a>.</em></p> <blockquote> <h1>CHANGELOG</h1> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/JetBrains/kotlin/commits">compare view</a></li> </ul> </details> <br />

Updates kotlin-stdlib-common from 1.4.30 to 1.4.31 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md">kotlin-stdlib-common's changelog</a>.</em></p> <blockquote> <h1>CHANGELOG</h1> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/JetBrains/kotlin/commits">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

1 comment

1 changed file

dependabot-preview[bot]

pr closed time in a day

startedmittwald/kubernetes-replicator

started time in a day

PR opened zalando/opentracing-toolbox

Bump kotlin.version from 1.4.30 to 1.4.31

Bumps kotlin.version from 1.4.30 to 1.4.31. Updates kotlin-stdlib from 1.4.30 to 1.4.31 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md">kotlin-stdlib's changelog</a>.</em></p> <blockquote> <h1>CHANGELOG</h1> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/JetBrains/kotlin/commits">compare view</a></li> </ul> </details> <br />

Updates kotlin-stdlib-common from 1.4.30 to 1.4.31 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md">kotlin-stdlib-common's changelog</a>.</em></p> <blockquote> <h1>CHANGELOG</h1> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/JetBrains/kotlin/commits">compare view</a></li> </ul> </details> <br />

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

pr created time in a day

PR opened zalando/logbook

Bump kotlin-stdlib from 1.4.30 to 1.4.31

Bumps kotlin-stdlib from 1.4.30 to 1.4.31. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/JetBrains/kotlin/blob/master/ChangeLog.md">kotlin-stdlib's changelog</a>.</em></p> <blockquote> <h1>CHANGELOG</h1> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/JetBrains/kotlin/commits">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

pr created time in a day

push eventhashicorp/consul-helm

Ashwin Venkatesh

commit sha 0b8873b3446b253addb5b25be3223e11a91ba317

Add acceptance test for metrics merging

view details

push time in 2 days