profile
viewpoint
Andre Weinand weinand Microsoft Zurich, Switzerland http://code.visualstudio.com

microsoft/vscode-node-debug 193

A VS Code debug adapter for node

microsoft/vscode-debugadapter-node 146

Debug adapter protocol and implementation for VS Code.

microsoft/vscode-mock-debug 127

Starter sample for developing debug adapters for VSCode.

microsoft/vscode-mono-debug 110

A simple VS Code debug adapter for mono

weinand/vscode-processes 106

Provide access to all VS Code child processes

weinand/vscode-auto-attach 3

Automatically attach to node.js processes launched from VS Code

weinand/golang-vscode 1

docker image with golang and vscode

weinand/server-ready 1

Open uri if server under debugging is ready

weinand/applescript-json 0

AppleScript JSON encoder

push eventmicrosoft/vscode

Andre Weinand

commit sha 7551598e6eac7713657e2fa60021ee2e656765fb

node-debug@1.44.9

view details

push time in 16 hours

push eventmicrosoft/vscode-node-debug

Andre Weinand

commit sha cdec5dccaf1266fb3caa412bef7ef79f5c6c1ee8

use kind-of@6.0.3

view details

push time in 17 hours

push eventmicrosoft/vscode-node-debug

dependabot[bot]

commit sha 4d2c1a1197e7bd6067dc0bdf3b5b65a3c8d12668

Bump elliptic from 6.5.0 to 6.5.3 Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.0 to 6.5.3. - [Release notes](https://github.com/indutny/elliptic/releases) - [Commits](https://github.com/indutny/elliptic/compare/v6.5.0...v6.5.3) Signed-off-by: dependabot[bot] <support@github.com>

view details

Andre Weinand

commit sha 38b59c727ca6c9c3b6a118dc1e3de74a60aee81a

Merge pull request #210 from microsoft/dependabot/npm_and_yarn/elliptic-6.5.3 Bump elliptic from 6.5.0 to 6.5.3

view details

push time in 17 hours

PR merged microsoft/vscode-node-debug

Bump elliptic from 6.5.0 to 6.5.3 dependencies

Bumps elliptic from 6.5.0 to 6.5.3. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/indutny/elliptic/commit/8647803dc3d90506aa03021737f7b061ba959ae1"><code>8647803</code></a> 6.5.3</li> <li><a href="https://github.com/indutny/elliptic/commit/856fe4d99fe7b6200556e6400b3bf585b1721bec"><code>856fe4d</code></a> signature: prevent malleability and overflows</li> <li><a href="https://github.com/indutny/elliptic/commit/60489415e545efdfd3010ae74b9726facbf08ca8"><code>6048941</code></a> 6.5.2</li> <li><a href="https://github.com/indutny/elliptic/commit/9984964457c9f8a63b91b01ea103260417eca237"><code>9984964</code></a> package: bump dependencies</li> <li><a href="https://github.com/indutny/elliptic/commit/ec735edde187a43693197f6fa3667ceade751a3a"><code>ec735ed</code></a> utils: leak less information in <code>getNAF()</code></li> <li><a href="https://github.com/indutny/elliptic/commit/71e4e8e2f5b8f0bdbfbe106c72cc9fbc746d3d60"><code>71e4e8e</code></a> 6.5.1</li> <li><a href="https://github.com/indutny/elliptic/commit/7ec66ffa255079260126d87b1762a59ea10de5ea"><code>7ec66ff</code></a> short: add infinity check before multiplying</li> <li><a href="https://github.com/indutny/elliptic/commit/ee7970b92f388e981d694be0436c4c8036b5d36c"><code>ee7970b</code></a> travis: really move on</li> <li><a href="https://github.com/indutny/elliptic/commit/637d0216b58de7edee4f3eb5641295ac323acadb"><code>637d021</code></a> travis: move on</li> <li><a href="https://github.com/indutny/elliptic/commit/5ed0babb6467cd8575a9218265473fda926d9d42"><code>5ed0bab</code></a> package: update deps</li> <li>See full diff in <a href="https://github.com/indutny/elliptic/compare/v6.5.0...v6.5.3">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+6 -6

0 comment

1 changed file

dependabot[bot]

pr closed time in 17 hours

push eventmicrosoft/vscode-node-debug

dependabot[bot]

commit sha 687a928b25535bdf2807c315ca6dea953008bb64

Bump lodash from 4.17.15 to 4.17.19 Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.19. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](https://github.com/lodash/lodash/compare/4.17.15...4.17.19) Signed-off-by: dependabot[bot] <support@github.com>

view details

Andre Weinand

commit sha 3a3563bc992f1c89896d4825585da44a3f221600

Merge pull request #209 from microsoft/dependabot/npm_and_yarn/lodash-4.17.19 Bump lodash from 4.17.15 to 4.17.19

view details

push time in 17 hours

PR merged microsoft/vscode-node-debug

Bump lodash from 4.17.15 to 4.17.19 dependencies

Bumps lodash from 4.17.15 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.15...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -3

0 comment

1 changed file

dependabot[bot]

pr closed time in 17 hours

push eventmicrosoft/vscode-node-debug

Andre Weinand

commit sha 0f8f189d631c96dc75a1cbfed09655477cf94adc

downgrade gulp-sourcemaps

view details

push time in 17 hours

issue commentmicrosoft/vscode

timeout after 1000 ms

If extensions have difficulties to respond to the disconnect request is time, then we should relax that requirement on the VS Code side.

ati0ns

comment created time in 21 hours

issue commentmicrosoft/vscode

"Focus Window On Break" setting does not work as expected

You said that "Focus Window On Break" works fine with other debuggers. From this I conclude that there is an issue with the specific extension.

xaviergmail

comment created time in a day

issue commentmicrosoft/vscode

`Unknown file extension ".ts"` error debugging typescript app in Node app when upgrading from 1.46.1 to 1.47.2

@connor4312 in node-debug we were accepting an *.ts entry point as long as we could find a generated *.js file in "outFiles" that would map back to it via a source map. Is using js-debug the same approach?

nynj

comment created time in 3 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 07d0d64321715cfa4dc18b826c2bc5ffd18a6ca1

tweaking debug items...

view details

push time in 3 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 5138aa2d9efdadba70ae68d0a92f359aa792e0eb

add stopDebugging API

view details

push time in 4 days

issue commentmicrosoft/vscode

setting breakpoint crashes debug session

/extCpp

andisfar

comment created time in 4 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha d757ba881129124388657ad7265ac32ba8a4eebb

add vscode-recipes PR thank yous

view details

push time in 4 days

push eventmicrosoft/vscode-recipes

Tas Devani

commit sha 86f4014a8abd3ad7819fc0162dd5f05930c778e2

Update readme to include latest cli commands and improve debugging

view details

Andre Weinand

commit sha 5d65f2c3e071cfb2e1d87e029d85a73541ab3838

Merge branch 'master' into vuejs-update

view details

Andre Weinand

commit sha e9574e9b211400f321a2188485dab86b8e10f423

Merge pull request #263 from tasdevani21/vuejs-update Update Vuejs readme to include latest cli commands and improve debugging

view details

push time in 4 days

PR merged microsoft/vscode-recipes

Update Vuejs readme to include latest cli commands and improve debugging
  • Update the Vue CLI Commands to be the latest
  • Improving debugging
  • Add additional resources for Vue Debugging
+59 -52

0 comment

1 changed file

tasdevani21

pr closed time in 4 days

push eventtasdevani21/vscode-recipes

Ellis Kenyő

commit sha 7ea0af74db4abea853c27fef24810803c60f26ef

Update README.md Add a section for demonstrating how to run a task with a debug configuration

view details

Andre Weinand

commit sha c31ba7a0f66316ee98804b76accd692036c13ff4

add a paragraph that the recipe is obsolete

view details

Andre Weinand

commit sha b435e1a453ccce95ecb79efdc043e45cbb4e46f9

Add something about TypeScript development.

view details

Andre Weinand

commit sha fc84ccc87a2f6248f7bc1a367d56045b8b1ed738

fix typo

view details

Andre Weinand

commit sha 387cb44f153cca236f40939be0b01043c8ff649b

Merge pull request #252 from elken/patch-1 Update README.md

view details

Andre Weinand

commit sha 5d65f2c3e071cfb2e1d87e029d85a73541ab3838

Merge branch 'master' into vuejs-update

view details

push time in 4 days

pull request commentmicrosoft/vscode-recipes

Update README.md

Thanks for the PR

elken

comment created time in 4 days

push eventmicrosoft/vscode-recipes

Ellis Kenyő

commit sha 7ea0af74db4abea853c27fef24810803c60f26ef

Update README.md Add a section for demonstrating how to run a task with a debug configuration

view details

Andre Weinand

commit sha 387cb44f153cca236f40939be0b01043c8ff649b

Merge pull request #252 from elken/patch-1 Update README.md

view details

push time in 4 days

PR merged microsoft/vscode-recipes

Update README.md

Add a section for demonstrating how to run a task with a debug configuration

+39 -0

1 comment

1 changed file

elken

pr closed time in 4 days

push eventmicrosoft/vscode-docs

Andre Weinand

commit sha 6cb934b69773fe63aebdc945dd38d3a16c2ab123

add DAP PR thank yous

view details

push time in 4 days

pull request commentmicrosoft/debug-adapter-protocol

Add Lua Debug Adapter

Thanks for the PR

actboy168

comment created time in 4 days

push eventmicrosoft/debug-adapter-protocol

actboy168

commit sha 726c573a072c755df8d1cba0cf14260421853afb

Add Lua Debug Adapter

view details

Andre Weinand

commit sha 91a388d71f91b59842a58d3b6270ce67ba252b47

Merge pull request #131 from actboy168/patch-1 Add Lua Debug Adapter

view details

push time in 4 days

pull request commentmicrosoft/debug-adapter-protocol

Add link to JCIDE which support DAP

Thanks for the PR

kuafuwang

comment created time in 4 days

push eventmicrosoft/debug-adapter-protocol

kuafuwang

commit sha 2db7bcf44af1acbab4a8788b610d62be2141d5a0

Add link to JCIDE which support DAP Add link to JCIDE which implement DAP as a client.

view details

Andre Weinand

commit sha 76255cafbefd702916741f602c0a84bd592d8725

Merge pull request #129 from kuafuwang/gh-pages Add link to JCIDE which support DAP

view details

push time in 4 days

PR merged microsoft/debug-adapter-protocol

Add link to JCIDE which support DAP

Add link to JCIDE which implement DAP as a client.

+2 -1

0 comment

1 changed file

kuafuwang

pr closed time in 4 days

issue commentmicrosoft/vscode

skipFiles not working for the latest nightly build

If you use "<node_internals>/**/*.js" does it make a difference?

queston02

comment created time in 4 days

issue commentmicrosoft/vscode

Debug: Compound - Python / Attach C Process doesn't work

The easiest way to get the process ID from the python process is to make the debuggee print its process ID to stdout in some recognisable format (e.g. a URL). VS Code has a feature serverReadyAction that can be used to open a URL in a browser as soon as a server ready message appears in the debug console (see https://code.visualstudio.com/updates/v1_32#_automatically-open-a-uri-when-debugging-a-server-program).

The problem is that in your case you don't want to open a URL in a browser, but you want to start another debug session and pass along the process ID.

The existing syntax of the serverReadyAction could be easily extended to support such a feature. The feature is implemented in VS Code as a built-in "debug-server-ready" extension (https://github.com/microsoft/vscode/tree/master/extensions/debug-server-ready). Hack it and give us a PR!

Or clone the serverReadyAction extension and adapt it to your needs.

jay-pee

comment created time in 5 days

issue commentmicrosoft/vscode

Debug: Compound - Python / Attach C Process doesn't work

I assume that the "pickProcess" command used in the C++ launch config is provided by the C++ extension. Please file the issue against the C++ extension.

jay-pee

comment created time in 5 days

push eventmicrosoft/vscode

Andre Weinand

commit sha 8efa78dcdee072bcb7ad455603b24e1cbb8f5916

remove jsdoc for "void" return value; fixes #103925

view details

push time in 5 days

issue closedmicrosoft/vscode

stopDebugging return value and jsdoc

Testing #103857

From stopDebugging jsdoc

@return A thenable that resolves when the sessions could be stopped successfully.

I do not like this wording, since it feels like the promise will never be resolved if we could not stop the debug session. Can we somehow make this clearer?

If the session is stopped successfuly maybe for consistence we shuold be returing a Thenable<boolean> like the startDebugging does. Though in practice I think stopDebugging should not fail, so I does not make a lot of sense to return a boolean.

closed time in 5 days

isidorn

issue commentmicrosoft/vscode

stopDebugging return value and jsdoc

I checked other places in vscode.d.ts where a Promise<void> is returned and noticed that they do not even have a jsdoc for the return value. This makes sense because return void means to have no return value.

isidorn

comment created time in 5 days

issue closedmicrosoft/vscode

User visible error messages should be localized

Testing #103857

Code pointer https://github.com/microsoft/vscode/blob/6dd9bda34d96cd6cf442dcc177c7961ebb393d91/src/vs/workbench/api/browser/mainThreadDebugService.ts#L264

There are more examples of non localized error messages in that file.

closed time in 5 days

isidorn

issue commentmicrosoft/vscode

User visible error messages should be localized

Extension API errors are non localized.

isidorn

comment created time in 5 days

push eventmicrosoft/vscode

Andre Weinand

commit sha 95dcdf2c58d3f3e3fd2521203e5cd70aae0c8873

make session arg optional; fixes #103934

view details

push time in 5 days

issue closedmicrosoft/vscode

StopDebugging should have the session optional

Testing #103857

Current signiture

		export function stopDebugging(session: DebugSession | undefined): Thenable<void>;

I propose the following

		export function stopDebugging(session?: DebugSession): Thenable<void>;

This makes the caller vscode.debug.stopDebugging() more nice compared to vscode.debug.stopDebugging(undefined)

I think it will also align well with some existing editor API. Also I did not find any current debug api which has this semantic of undefined = all

closed time in 5 days

isidorn

issue commentmicrosoft/vscode

StopDebugging should have the session optional

Yes, I agree.

isidorn

comment created time in 5 days

issue commentmicrosoft/debug-adapter-protocol

[Clarify] Optional property behaviour: omit vs null

@puremourning yes, you are right. undefined is a JS thing...

So I should have said: null is only a valid value if explicitly specified in a type definition; it can not be used as a value for an omitted property.

puremourning

comment created time in 5 days

issue commentmicrosoft/debug-adapter-protocol

Support for indicating custom debug focus change

No, today there is no explicit request or event in the protocol to change focus in the client or to make the client refresh its views.

Let's start a discussion about a new DAP feature (most likely a new event). But we should avoid to use the term "focus" because a DA should never drive the UI directly in order to trigger some side effect (e.g. refresh some values).

eltonwells

comment created time in 5 days

issue commentmicrosoft/debug-adapter-protocol

[Clarify] Optional property behaviour: omit vs null

null is only a valid value if explicitly specified in a type definition. To the contrary undefined is a valid value for an optional property even if it is not explicitly specified in a type definition.

E.g. with the type definition sourceReference?: number the property may be either omitted or set to a value of undefined.

puremourning

comment created time in 5 days

issue commentmicrosoft/debug-adapter-protocol

Clarify documentation for ErrorResponse Message ids

Yes, error codes are private to each implementation. So the "Unique identifier for the message" means "unique within a DAP implementation". The purpose of these error IDs is to help those extension authors that have the requirement that every error message needs a corresponding error number, so that users or customer support can find information about the specific error more easily. It is not used by VS Code.

I will update the documentation with this.

polinasok

comment created time in 5 days

issue commentmicrosoft/vscode

JavaScript debugging: run to cursor can skip to next statement if cusor is after semicolon

IMO this works as designed. @isidorn but I think we could try @connor's suggestion and see whether this improves the feature.

mjbvz

comment created time in 5 days

issue closedmicrosoft/vscode

Please Please Please Make more generic debuggin examples than python,node, and .netcore

<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. -->

<!-- Describe the feature you'd like. --> The beauty of docker is that you can run essentially anything. There needs to be a simple example to run any type of service in a container then attach the debugger to that. For example compiling cpp and fortran on a ubuntu container. Or an alpine container.

closed time in 5 days

LeeRuns

issue commentmicrosoft/vscode

Please Please Please Make more generic debuggin examples than python,node, and .netcore

@LeeRuns please see https://code.visualstudio.com/docs/remote/containers

LeeRuns

comment created time in 5 days

issue commentmicrosoft/vscode

Disabling/Enabling extension that requires reload does not full sync automatically

@sandy081 yes, exactly what you explain. Users probably expect that settings sync takes care of everything and assume that an enabled or disabled extension will be enabled or disabled in the other VS Code instance automatically. But this is not the case.

weinand

comment created time in 5 days

issue commentmicrosoft/vscode

Debugging extensionhost tests fail in latest Insiders

@connor great find.

connor4312

comment created time in 5 days

issue closedmicrosoft/vscode

Stopping an already stopped session does not throw

Testing #103857

If an extension author call stopDebugging and passes an already stopped session there is no error message or any notification in any way. If our stopDebugging would return a boolean, we could for example return false here. Or at least we could throw an error.

If you would like an error to be thrown you can simple pass false here to not include inactive sessions https://github.com/microsoft/vscode/blob/6dd9bda34d96cd6cf442dcc177c7961ebb393d91/src/vs/workbench/api/browser/mainThreadDebugService.ts#L269

closed time in 6 days

isidorn

issue commentmicrosoft/vscode

Stopping an already stopped session does not throw

Yes, methods like this must be idempotent because otherwise they would be painful to use: either by verifying upfront that the debug session is not already stopped, or by putting a try/catch block around them just to ignore the exception...

isidorn

comment created time in 6 days

issue closedmicrosoft/vscode

Sanity Test Settings Sync

  • [x] windows @RMacfarlane
  • [x] mac @connor4312
  • [x] linux @weinand

Complexity: 5

Create Issue


Set Up

You can use two insiders opened with different user data directory (--user-data-dir) and extension directory (--extensions-dir) for test syncing across machines.

Testing

We are planning to enable Settings Sync for stable users in this release. So, I would ask the assignees to do an exploratory end to end testing of following settings sync features.

  • Make sure you get a preview confirmation dialog when you turn on sync for the very fist time. Even though we are enabling for stable users this feature will be still in preview mode.
  • Make sure Settings Sync term is used in the product to represent this feature
  • Test settings, keybindings, snippets, extensions and UI state are syncing across devices flawlessly.
    • Test machine and machine-overridable scoped settings are ignored by default. These are typically settings that has local paths as values.
    • Test enablement state of extensions is synced
    • Test advanced features like ignoring settings, extensions and syncing keybindings across platforms
    • Test you can able to handle and resolve conflicts if they occur
  • Make sure you can track and monitor sync activity and discover all necessary sync features.
    • Test Sync Activity & Machines view using the command Settings Sync: Show Synced Data
    • Test the actions available in these views (Restoring, editing machine name & turning off sync on a machine)
  • Test turning off Settings Sync either on current machine or on all machines.

Authors: @sandy081 @Tyriar

closed time in 6 days

sandy081

issue commentmicrosoft/vscode

Sanity Test Settings Sync

After testing Settings Sync for a day, I must say that it works "smooth as silk". Great job!

sandy081

comment created time in 6 days

issue openedmicrosoft/vscode

Disabling/Enabling extension that requires reload does not full sync automatically

Testing #103613

  • enable settings sync (including extension sync)
  • enable/disable an extension that requires a reload
  • reload
  • go to other VS Code instance and force settings sync manually

Observe: extension is not in the same state as on the first VS Code instance because a reload is required.

It would be be nice if a notification would pop up in this case.

created time in 6 days

issue openedmicrosoft/vscode

Improve naming of diff view's right hand side

Testing #103613

After turning on Settings Sync on a second system, I got a merge conflict and opened the diff editor.

2020-08-05_15-20-38

In the diff editor the right hand side's label "settings.json (Merges)" is confusing because it says "Merges" but there is nothing merged initially. The right hand side show the "local" settings. Only after editing they become the "Merged local settings".

created time in 6 days

issue openedmicrosoft/vscode-docs

Settings Sync documentation still uses "Preferences Sync"

Testing microsoft/vscode#103613

Settings Sync documentation still uses "Preferences Sync": 2020-08-05_13-04-58

created time in 6 days

issue closedmicrosoft/vscode

Make Settings Sync account independent from account use elsewhere

Testing #103613

When being logged into GitHub, "Settings Sync" automatically uses GitHub for syncing. But for various reasons I would like to sync my settings via Microsoft. This does not seem to be possible.

2020-08-05_13-20-35

closed time in 6 days

weinand

issue commentmicrosoft/vscode

Make Settings Sync account independent from account use elsewhere

Aha, it is possible to use a different account for syncing.

Closing issue.

weinand

comment created time in 6 days

issue openedmicrosoft/vscode

Make Settings Sync account independent from account use elsewhere

Testing #103613

When being logged into GitHub, "Settings Sync" automatically uses GitHub for syncing. But for various reasons I would like to sync my settings via Microsoft. This does not seem to be possible.

2020-08-05_13-20-35

created time in 6 days

issue openedmicrosoft/vscode

Settings Sync notification wording

Testing #103613

After turning on Settings sync, I get this notification:

2020-08-05_13-11-52

Two issues:

  • the embedded link "(details)" does not show details (e.g. what is being synched), but it shows the sync log. I suggest to rename the link to what it actually does, e.g. "show sync log" or "show sync status".
  • don't break the flow of the notification message by placing "(details)" in side the message. Place the link at the end: "Settings Sync is turned on (show sync log)."

created time in 6 days

issue openedmicrosoft/vscode

Settings Sync documentation still uses "Preferences Sync"

Testing #103613

Settings Sync documentation still uses "Preferences Sync": 2020-08-05_13-04-58

created time in 6 days

issue commentmicrosoft/vscode

Debugging extensionhost tests fail in latest Insiders

@connor4312 I cannot reproduce on macOS and Windows. Does problem reproduce after reboot?

connor4312

comment created time in 6 days

issue commentmicrosoft/vscode

Debugging extensionhost tests fail in latest Insiders

I cannot reproduce this on macOS...

connor4312

comment created time in 6 days

issue commentmicrosoft/vscode

Debugging extensionhost tests fail in latest Insiders

@isidorn Other than adding the stopDebugging API I haven't changed anything in VS Code. Could you please do a bisect for finding the regression. Thanks.

connor4312

comment created time in 6 days

issue commentmicrosoft/vscode

Test taskDefinition when property

I was not able to get the task provider sample to work on linux (mostly because setting up a Rake project was not as straightforward as I thought).

But VS Code's builtin npm task provider was working fine.

alexr00

comment created time in 7 days

issue openedmicrosoft/vscode

TaskDefinition's "when" clause description wording

Testing #103835

Hovering over the taskDefinition's "when" property shows this description:

2020-08-04_16-17-52

IMO the "Condition when the task definition is valid" is not as clear as other "when" descriptions, e.g. for views:

2020-08-04_16-19-46

Making a taskDefinition "invalid" in order to disable it, sounds somewhat strange...

I suggest to use "Condition which must be true to enable this task".

created time in 7 days

issue commentmicrosoft/vscode

Exception in Console upon launch

@sandy081 is this something in your area?

jtsom

comment created time in 7 days

issue commentmicrosoft/vscode

Support Named Pipe & Unix Domain Sockets as debug adapter entry point

Ok, I will move this issue and the corresponding PR to August...

TylerLeonhardt

comment created time in 7 days

issue openedmicrosoft/vscode

Test new `stopDebugging` API

Refs: #101883

  • [ ] anyOS: @isidorn
  • [ ] anyOS: @connor4312

Complexity: 3


Similar to the already existing vscode.debug.startDebugging we've introduced a new function vscode.debug.stopDebugging:

	export namespace debug {

		/**
		 * Stop the given debug session or if no session is given stop all sessions.
		 */
		export function stopDebugging(session?: DebugSession): Thenable<void>;
	}

Create an extension that creates one or more debugging sessions with startDebugging and use stopDebugging to stop the sessions. Verify that stopDebugging works as specified.

created time in 7 days

issue commentmicrosoft/vscode

Expose a `stopDebugging` API to extensions

Testing of the proposed API will be done in July, finalization will take place in August.

connor4312

comment created time in 7 days

issue commentmicrosoft/vscode

Support Named Pipe & Unix Domain Sockets as debug adapter entry point

@TylerLeonhardt was this API addition discussed in the API sync call? If yes, what was the outcome?

TylerLeonhardt

comment created time in 7 days

issue commentmicrosoft/vscode

error

/needsMoreInfo including what language are you debugging, a set of clear repro steps, and what exact error are you seeing (screenshot)

sunny7903814947

comment created time in 9 days

issue commentmicrosoft/vscode

Debugger does not display values of C++ STL Containers within an object

Please file this issue against the C++ extension. VS Code has no builtin C++ functionality. So we cannot help you.

bcaddy

comment created time in 10 days

issue commentmicrosoft/vscode

Launch preLaunchTask should complete before resolveDebugConfiguration

... and we would not run the second hook if preLaunchTask fails.

gustavomassa

comment created time in 10 days

issue commentmicrosoft/vscode

Launch preLaunchTask should complete before resolveDebugConfiguration

Please note that there are two resolveDebugConfiguration hooks: one before variables have been substituted, one (resolveDebugConfigurationWithSubstitutedVariables) after the substitution. If I understand the current logic correctly the preLaunchTask is run after both hooks. Would it help (and would it be possible) to run the preLaunchTask after the first hook but before the second?

gustavomassa

comment created time in 11 days

issue commentmicrosoft/vscode

Java 11 or more recent required: JAVA DEBUGGER

/extJava

PriyankeshRaj

comment created time in 11 days

issue commentmicrosoft/vscode

Node debug console does not use the full terminal width

@Tyriar do you have an idea why output does not cover the full width?

AlCalzone

comment created time in 12 days

issue commentmicrosoft/vscode

DebugConfiguration is an empty object when no launch config is present

yes, I'm aware of that. But what's about the case when no file is open in the editor?

ChaseMor

comment created time in 12 days

issue commentmicrosoft/vscode

DebugConfiguration is an empty object when no launch config is present

@connor4312 The scenario is: no launch config exists and user presses F5. We wanted to give a debug extension a chance to figure out what to do (before we got dynamic launch configs).

Node-debug uses this code: https://github.com/microsoft/vscode-node-debug/blob/4b2d2ca0dbe3bec12649a90c40bd0e2c904c0ca0/src/node/extension/configurationProvider.ts#L62-L70 and https://github.com/microsoft/vscode-node-debug/blob/4b2d2ca0dbe3bec12649a90c40bd0e2c904c0ca0/src/node/extension/configurationProvider.ts#L317-L322

As you can see we fill in all properties of the DebugConfiguration (but the debug type was preselected by some VS Code heuristic). @isidorn could you please fill in here the details of how we determine what debug extension to use (which determines the debug type).

ChaseMor

comment created time in 13 days

issue commentmicrosoft/vscode

DebugConfiguration is an empty object when no launch config is present

This is a trick issue. Yes, we should really change the signature of resolveDebugConfiguration(...) to use something like debugConfiguration: DebugConfiguration | {}, but this will break extensions at compile time. On the other hand they are already broken at runtime because with the current signature they do not have to cope with empty debug configs, but they might receive one.

ChaseMor

comment created time in 13 days

issue commentmicrosoft/vscode

Node process freezes when initiating Webpack Hot Reload for React App in VS Code Debugger for more than 3 times

Does it make a difference if you add a "console": "integratedTerminal" to your launch config?

sceee

comment created time in 13 days

issue commentmicrosoft/vscode

Debug Node Auto Attach is not working

I just tried this on macOS in VS Code 1.47.3 but it works fine:

2020-07-28_17-28-46 (1)

Just make sure to have a breakpoint otherwise the one liner runs to completion immediately and your session ends.

Gribesh

comment created time in 14 days

issue commentmicrosoft/vscode

Node debug console does not use the full terminal width

I remember another instance of this problem where the problem only showed up on one system. In that case a ssh session was used.

In the issue's title you said "debug console", but the screenshot shows an "integrated terminal". That's the reason why I mentioned terminology.

I tried to reproduce by using "git bash" too, so that does not seem to be the source of the problem.

AlCalzone

comment created time in 14 days

issue commentmicrosoft/vscode-recipes

Docker-TypeScript unbound breakpoint

If you use a multi-folder workspace setup for the different services, you can debug them in different debug sessions within one window.

rotemironsrc

comment created time in 14 days

IssuesEvent

issue commentmicrosoft/vscode

Node debug console does not use the full terminal width

Sorry, for some strange reason my question and even my screencast is missing... So here is it again:

Your screenshot does not show the "debug console" but the integrated terminal. With it I could not reproduce the problem on Windows:

2020-07-21_12-43-37 (1)

Are you running a remote session in the terminal?

AlCalzone

comment created time in 14 days

push eventmicrosoft/vscode-recipes

Andre Weinand

commit sha b435e1a453ccce95ecb79efdc043e45cbb4e46f9

Add something about TypeScript development.

view details

Andre Weinand

commit sha fc84ccc87a2f6248f7bc1a367d56045b8b1ed738

fix typo

view details

push time in 14 days

issue commentmicrosoft/vscode-recipes

Docker-TypeScript unbound breakpoint

Yes, make sure to only open the Docker-TypeScript folder in VS Code and not the enclosing recipes folder.

BTW, the Docker-TypeScript is outdated (and obsolete). It was created in a time when VS Code did not have universal remote development capabilities and only its Node.js debugger was able to debug remotely. Today we recommend to use VS Code's excellent container development support. With this, TypeScript development in a Docker container is not different than TypeScript development in a local setup.

rotemironsrc

comment created time in 14 days

issue commentmicrosoft/vscode

"your 131072x1 screen size is bogus, expect trouble"

@Alirezanet thanks. That debugger is a separate extension (C#). Please file an issue against that.

We have fixed a similar problem with the Node.js debugger (which is built into VS Code). But that fix does not cover the C# debugger.

nukoyluoglu

comment created time in 14 days

push eventmicrosoft/vscode-recipes

Andre Weinand

commit sha c31ba7a0f66316ee98804b76accd692036c13ff4

add a paragraph that the recipe is obsolete

view details

push time in 14 days

issue commentmicrosoft/vscode-recipes

Docker-TypeScript unbound breakpoint

Does it make a difference if you disable our new js-debugger by adding a "debug.javascript.usePreview": false to your settings?

rotemironsrc

comment created time in 14 days

push eventmicrosoft/vscode

Andre Weinand

commit sha 1e3378e3a755a9cb6fae7bff9427bd65addef2df

explain why an eslint rule is disabled; see #101978

view details

push time in 14 days

issue commentmicrosoft/vscode

"your 131072x1 screen size is bogus, expect trouble"

@Alirezanet what debugger are you using?

nukoyluoglu

comment created time in 14 days

issue commentmicrosoft/vscode

Debug Node Auto Attach is not working

@connor node-debug based autoattach never worked for "--inspect=0" because the mechanism looks at the command line and does not do any output scraping or port sniffing. So this is expected.

I was under the assumption that you would make js-debug based auto-attach behave like node-debug based auto-attach by only enabling it when the node process has a command line argument that indicates debugging. I wasn't aware that you are now completely relying on node-debug. This of course will result in idiosyncrasies like this.

Gribesh

comment created time in 14 days

issue commentmicrosoft/vscode

Python debugger - if exception detected in collapsed code in a *.py does not expand

If the editorService doesn't do it, then we should do it. But I think they should do it (or have an option on the method to do it).

ianfinlay-csiro-au

comment created time in 15 days

issue commentmicrosoft/vscode

Why are multiple debugging threads being started in integrated Python-debugging of VS Code?

VS Code only shows what is being requested by the Python debugger. So you'll have to ask over there...

AndreasLuckert

comment created time in 15 days

issue commentmicrosoft/vscode

Breakpoints View Panel is Missing with no clear way to restore it

@isidorn yes, the original issue is about restoring a view and that can be considered a duplicate of #101016.

But the other issues of moving views to other containers are equally important. If users have deliberately moved a view somewhere else, they expect them to work there too.

So I suggest to close this as a duplicate and create a new issue for the necessary tasks that we have to do for debug:

  • We may want some new icons for each debug view instead of only relying on the debug viewlet icon.
  • badging must be done for the correct container
  • we have to activate the correct debug viewlet when a breakpoint is hit or a debug sessions has started.
n8sabes

comment created time in 15 days

issue commentmicrosoft/vscode

Debugger: debug.inlineValues support for case insensitive variable names

@isidorn yes, that's exactly what my protoyping tries to find out: do we need a new abstraction or could we just use a variant for the EvaluatableExpressionProvider. Since the EvaluatableExpressionProvider uses the mouse position, it is not a very efficient way to find all inline expressions by probing for each character position in a line of source. In addition there is now way to figure out whether an evaluatable expression for one position is the same as for the next position...

chrisdp

comment created time in 15 days

issue commentmicrosoft/vscode

Debugger: debug.inlineValues support for case insensitive variable names

IMO the debug adapter is not in a good position to know about case sensitivity because it has no syntax knowledge of the source language because it doesn't take transpilation into account (e.g. CoffeeScript, TypeScript -> JavaScript).

I'm currently looking into this problem in a broader way: similar to what we did for debug hovers with the EvaluatableExpressionProvider, I'm trying to do design an InlineValueProvider that can be contributed by a language extension.

chrisdp

comment created time in 15 days

issue commentmicrosoft/vscode

Pending breakpoint not saved across restarts

@isidorn this might be related to https://github.com/microsoft/vscode/issues/103111. There is some risk losing breakpoints from persistent storage if a DA doesn't "behave well".

ivanhernandez13

comment created time in 15 days

more