profile
viewpoint
Sviatoslav Sydorenko webknjaz @Ansible Core @RedHatOfficial Brovary/Kyiv, UA ↝ Brno, CZ https://webknjaz.me 🇺🇦💭🛫✈🛬🛂🛃🛄🏙🚡⛴🏰🏔 * 🐍 3 enthusiast * Gentoo 🐧 jedi * @ansible Core Dev @ Red 🎩 * @aio-libs CI guy * maintainer @ @CherryPy * @open-craft-guild

ansible-community/molecule 2883

Molecule aids in the development and testing of Ansible roles

ansible/ansible-lint 2226

Best practices checker for Ansible

cherrypy/cherrypy 1274

CherryPy is a pythonic, object-oriented HTTP framework. https://docs.cherrypy.org/

aio-libs/async_lru 203

Simple lru cache for asyncio

aio-libs/multidict 200

The multidict implementation

ansible/ansibullbot 174

Bot for management of Ansible issues and PRs on GitHub.

aio-libs/aioelasticsearch 122

aioelasticsearch-py wrapper for asyncio

ansible/ansible-lint-action 87

GitHub Action for running ansible-lint as part of your workflows! [ https://github.com/marketplace/actions/ansible-lint ]

aio-libs/aiocassandra 84

Simple threaded cassandra wrapper for asyncio

aio-libs/aiohttp-remotes 65

A set of useful tools for aiohttp.web server

fork webknjaz/antsibull

Tooling for building various things related to ansible

fork in 36 minutes

push eventwebknjaz/ansible-gentoo-laptop

Sviatoslav Sydorenko

commit sha ca91eb0a6c8a92fbbaa60e2c77b85281ed63389c

Sync ansible-community/antsibull

view details

push time in 40 minutes

startedGenymobile/scrcpy

started time in 5 hours

issue commentpypa/warehouse

[BUG] Italic font gets a fallback in Cyrillic texts

@pradyunsg FWIW this looks like a good candidate for "good first issue" and "Hacktoberfest" labels...

webknjaz

comment created time in 5 hours

startedsecuritytxt/security-txt

started time in 5 hours

issue commentpypa/warehouse

[BUG] Italic font gets a fallback in Cyrillic texts

Bonus thoughts: it's probably a good idea to have some e2e tests verifying if the glyphs that get selected for the render are taken from the same font. :thinking: Would something like Puppeteer expose this info?

webknjaz

comment created time in 5 hours

issue commentpypa/warehouse

[BUG] Italic font gets a fallback in Cyrillic texts

Yeah, I think that using system font stack is a good idea regardless. Also, have you considered system-ui?

Also, I've tweaked CSS with

body {
  font-family: -apple-system, BlinkMacSystemFont, avenir next, avenir, helvetica neue, helvetica, Ubuntu, roboto, noto, segoe ui, arial, sans-serif;
}

and DevTools now shows "DejaVu Sans" in Rendered Fonts. It looks consistent with such setup: pypi org--systemfontstack--demo

webknjaz

comment created time in 5 hours

issue openedpypa/warehouse

[BUG] Italic font gets a fallback in Cyrillic texts

Describe the bug <!-- A clear and concise description the bug --> TL;DR normal and bold text gets rendered with "Source Sans Pro" but italics gets some locally-available Arial-based fallback. This makes the paragraph in the example below look inconsistent. I suppose "Source Sans Pro" does not contain any Cyrillic glyphs in italics.

pypi org--weird--italics

Expected behavior <!-- A clear and concise description of what you expected to happen --> The same font used for all text content consistently.

To Reproduce <!-- Steps to reproduce the bug, or a link to PyPI where the bug is visible -->

  1. Switch PyPI to Ukrainian
  2. Go to https://pypi.org/help/#project-size-limit
  3. Look closer at the word in italics ("меншого")
  4. Check the font that got used for this word compared to the surrounding text. It is visible in DevTools if you highlight the corresponding <em> tag, then go to the "Computed" tab in the sidebar and scroll all the way down to the "Rendered Fonts" section.

My Platform

Google Chrome on Gentoo Linux (two of my laptops choose different fonts; because of the present fallbacks one system it is DejaVu Sans and the other it's Arial) I've also tested it on a Chromebook (ChromeOS is technically Gentoo under the hood but it shouldn't matter) — it uses Arimo. I'm pretty sure that this behavior will happen on any system that is able to download that main " Source Sans Pro" from the Internet so that it'll get used in some places but not the others.

Additional context <!-- Add any other context, links, etc. about the feature here. --> N/A

created time in 10 hours

PR opened pypa/warehouse

Fix a typo (s/an/a/) in the malware issue template
+1 -1

0 comment

1 changed file

pr created time in 10 hours

push eventwebknjaz/warehouse

Sviatoslav Sydorenko

commit sha 1b5a0fe72f76def09f83a4736b20f43a337c55d9

Fix a typo (s/an/a/) in the malware issue template

view details

push time in 10 hours

issue commentpypa/packaging.python.org

GitHub Actions tutorial: Warn about filling up test pypi package limit if you publish every commit as suggested

If anyone is to submit the PR, I think it's worth using an "attention" box and pointing to https://pypi.org/help/#project-size-limit from the text.

bhazelton

comment created time in 11 hours

issue commentpypa/packaging.python.org

GitHub Actions tutorial: Warn about filling up test pypi package limit if you publish every commit as suggested

@di @pradyunsg could you please mark this as "good first issue" / "Hacktoberfest"?

bhazelton

comment created time in 11 hours

startedevdenis/adb_root

started time in 16 hours

startedomnirom/android_bootable_recovery

started time in 18 hours

startedkoush/vysor.io

started time in 18 hours

startedossec/ossec-hids

started time in 21 hours

issue commentansible/ansible

Wheel support for linux aarch64/x86

@odidev I'd like to add to @sivel's answer that Ansible does not have any platform-specific code and so the only wheel type that might've been appropriate would be a universal wheel. There is zero incompatibility with aarch64.

odidev

comment created time in a day

startedstrawberry-graphql/strawberry

started time in a day

issue closedpypa/gh-action-pypi-publish

how to push multiple packages

Hello, I am wondering how we can push two packages... We have a package lets say PL which is running a standard release cycle eventually with some release candidates (which is working fine now), then we have created another package PL-nightly which we want to push every day, for that reasons I have in this nightly action change of version to YYYYMMDD and rename a package in setup.py to PL-nightly before creating package so the outputs in dist are:

-rw-r--r-- 1 runner docker 1.8M Sep 28 00:58 pytorch-lightning-nightly-20200928.tar.gz
-rw-r--r-- 1 runner docker 426K Sep 28 00:58 pytorch_lightning_nightly-20200928-py3-none-any.whl

but then I am getting a server error

Checking dist/pytorch_lightning_nightly-20200928-py3-none-any.whl: PASSED
Checking dist/pytorch-lightning-nightly-20200928.tar.gz: PASSED
Uploading distributions to https://test.pypi.org/legacy/
Uploading pytorch_lightning_nightly-20200928-py3-none-any.whl

  0%|          | 0.00/458k [00:00<?, ?B/s]
  2%|▏         | 8.00k/458k [00:00<00:06, 74.6kB/s]
100%|██████████| 458k/458k [00:00<00:00, 653kB/s]  
NOTE: Try --verbose to see response content.
HTTPError: 403 Forbidden from https://test.pypi.org/legacy/
Invalid API Token: InvalidMacaroon('invalid macaroon signature')

does it mean that I have to somehow create and multiple tokens?

The build is here: https://github.com/PyTorchLightning/pytorch-lightning/runs/1174122197

closed time in a day

Borda

issue commentpypa/pip

Add email link on pip's documentation

@jdittrich #8848 is blocked by you

nlhkabu

comment created time in 2 days

push eventsanitizers/patchback-github-app

Sviatoslav Sydorenko

commit sha a393fbb122a215aa7f375256e456fd2abf250e83

📝 Post instructions on manual backporting Resolves #4

view details

push time in 2 days

push eventsanitizers/patchback-github-app

Sviatoslav Sydorenko

commit sha 3cb3890d3ea8bdcc46a63144b5ce27fc91ba7ae9

🚑 Add a missing branch prefix to post-merge flow

view details

push time in 2 days

startedansible-collections/community.network

started time in 2 days

PR opened ansible-collections/community.general

🤖 Add initial Patchback config
SUMMARY

<!--- Describe the change below, including rationale and design decisions --> This change adds an explicit config for the Patchback robot.

ISSUE TYPE

<!--- Pick one below and delete the rest -->

  • Maintenance Pull Request
COMPONENT NAME

<!--- Write the short name of the module, plugin, task or feature below --> N/A

ADDITIONAL INFORMATION

<!--- Include additional information to help people understand the change here --> <!--- A step-by-step reproduction of the problem is helpful if there is no related issue --> Merging this config must be coupled with renaming backport-stable-1 label to backport-1.

+5 -0

0 comment

1 changed file

pr created time in 2 days

create barnchwebknjaz/community.general

branch : maintenance/patchback-config-init

created branch time in 2 days

push eventwebknjaz/ansible-gentoo-laptop

Sviatoslav Sydorenko

commit sha 33d449ac0450991d322d12720528eadad027c749

Sync ansible-collections/community.general

view details

push time in 2 days

startedansible-collections/community.general

started time in 2 days

push eventaio-libs/aiohttp

Gabriel Sroka

commit sha 90acab1c42eed1984bdd4201bd082c5983213ffc

Fix a few minor bugs/typos in http_request_lifecycle.rst PR #4978 by @gabrielsroka

view details

push time in 2 days

PR merged aio-libs/aiohttp

Reviewers
Fix a few minor bugs/typos in http_request_lifecycle.rst

fix a few minor bugs/typos

+9 -9

1 comment

1 changed file

gabrielsroka

pr closed time in 2 days

PullRequestReviewEvent

push eventaio-libs/aiohttp

Gabriel Sroka

commit sha c4678672b628832d490fa2639911c62273bed472

Fix minor typo in README.rst PR #4977 by @gabrielsroka

view details

push time in 2 days

PR merged aio-libs/aiohttp

Reviewers
Fix minor typo in README.rst

fix minor typo

+1 -1

1 comment

1 changed file

gabrielsroka

pr closed time in 2 days

PullRequestReviewEvent

issue commentsphereio/docker-predictionio

How to call url http://0.0.0.0:8000 after deploying?

Localhost (should work) http://127.0.0.1:8000

FYI this won't work under Windows: https://superuser.com/a/536198/182499

piavgh

comment created time in 2 days

push eventaio-libs/yarl

Sviatoslav Sydorenko

commit sha 7add4d416d51b47a43cab7c67a71c6a0d52b3186

Disable the suggestion to use a blank issue tmpl (#523)

view details

push time in 2 days

delete branch aio-libs/yarl

delete branch : maintenance/forbid-empty-issue-template

delete time in 2 days

PR opened aio-libs/yarl

Disable the suggestion to use a blank issue tmpl enhancement
+1 -1

0 comment

1 changed file

pr created time in 2 days

create barnchaio-libs/yarl

branch : maintenance/forbid-empty-issue-template

created branch time in 2 days

push eventaio-libs/yarl

Sviatoslav Sydorenko

commit sha 87e683af96089c9b5e4a128c36e906a97db94c23

Migrate issue templates from aiohttp and link discussions (#522)

view details

push time in 2 days

delete branch aio-libs/yarl

delete branch : maintenance/issue-templates

delete time in 2 days

PR opened aio-libs/yarl

Migrate issue templates from aiohttp and link discussions enhancement
+98 -1

0 comment

3 changed files

pr created time in 2 days

create barnchaio-libs/yarl

branch : maintenance/issue-templates

created branch time in 2 days

push eventaio-libs/yarl

Sviatoslav Sydorenko

commit sha a0dae161fc089b5969f8973c89084e1d2c803dd8

Add an issue template chooser config (#518)

view details

push time in 3 days

delete branch aio-libs/yarl

delete branch : maintenance/issue-template-chooser-config

delete time in 3 days

PR opened aio-libs/yarl

Add an issue template chooser config enhancement
+29 -0

0 comment

1 changed file

pr created time in 3 days

create barnchaio-libs/yarl

branch : maintenance/issue-template-chooser-config

created branch time in 3 days

push eventwebknjaz/ansible-gentoo-laptop

Sviatoslav Sydorenko

commit sha 3b41c4706b15379ef1557e7644ee09e12a9797ba

Sync aio-libs/yarl repo

view details

push time in 3 days

push eventsanitizers/chronographer-github-app

Sviatoslav Sydorenko

commit sha 11e0ef93775815cb1feb307e2a242150abc0b04f

Upgrade dependency pins for Python 3.8 runtime

view details

push time in 3 days

push eventsanitizers/patchback-github-app

Sviatoslav Sydorenko

commit sha f5ef5b964da3e4159f4f7989c7f5aa4aca43c5b7

Bump CPython runtime to v3.8.6

view details

push time in 3 days

push eventsanitizers/chronographer-github-app

Sviatoslav Sydorenko

commit sha 5a7925eda4fc7bbb23b850ae6121a18733976fb6

Bump octomachinery to v0.3.2

view details

Sviatoslav Sydorenko

commit sha 48665a1e5a7ab8d8157f6791cc15c880ec21db4d

Switch CPython runtime to v3.8.6

view details

push time in 3 days

push eventsanitizers/patchback-github-app

Sviatoslav Sydorenko

commit sha a243960c53769866863297942091ee4110a95afc

Bump octomachinery to v0.3.2

view details

push time in 3 days

created tagsanitizers/octomachinery

tagv0.3.2

🤖 Invisible engine driving octobot machines. Simple, yet powerful. [DEMO BOT @ https://github.com/sanitizers/chronographer-github-app] | [tutorial @ https://tutorial.octomachinery.dev] | [docs @ https://docs.octomachinery.dev] | official web-site is at -->

created time in 3 days

push eventsanitizers/octomachinery

Sviatoslav Sydorenko

commit sha 348e505603cbe7b82ebcafce5acdb3ead1d80ee4

Add a default for `single_file` in install token

view details

push time in 3 days

push eventsanitizers/chronographer-github-app

Sviatoslav Sydorenko

commit sha 347b144a52254a20500e8873b4f0fc1f356dc7d4

Bump octomachinery to v0.3.1

view details

push time in 3 days

push eventsanitizers/patchback-github-app

Sviatoslav Sydorenko

commit sha e8bd9068c8a8197493af7c40840e1c9fb047f0e8

Bump octomachinery to v0.3.1

view details

push time in 3 days

push eventsanitizers/octomachinery

Sviatoslav Sydorenko

commit sha d1174772738522f38640c1fe7d81847b09d8d849

Add optional `single_file` attr to install token

view details

push time in 3 days

created tagsanitizers/octomachinery

tagv0.3.1

🤖 Invisible engine driving octobot machines. Simple, yet powerful. [DEMO BOT @ https://github.com/sanitizers/chronographer-github-app] | [tutorial @ https://tutorial.octomachinery.dev] | [docs @ https://docs.octomachinery.dev] | official web-site is at -->

created time in 3 days

startedkpi-web-guild/devspace

started time in 3 days

issue closedaio-libs/aiohttp

The HTTP server runs on localhost:8080 instead of http://0.0.0.0:8080

🐞 Describe the bug Both tutorial and terminal says:

======== Running on http://0.0.0.0:8080 ======== (Press CTRL+C to quit)

But if you open this exact URL, both Firefox and Edge browsers will say "Connection attempt failed". Nonetheless I've accidentally opened http://localhost:8080. And that's exactly where the server was running.

💡 To Reproduce

  1. I am using the last version of PyCharm Community Edition on Windows 10
  2. I was trying to reproduce some code from the polls example
from aiohttp import web

app = web.Application()
web.run_app(app)

💡 Expected behavior If you open http://0.0.0.0:8080, both Firefox and Edge browsers will say "Connection attempt failed".

📋 Your version of the Python Python 3.8

📋 Your version of the aiohttp/yarl/multidict distributions aiohttp 3.6.2 multidict 4.7.6 yarl 1.6.0

closed time in 3 days

DablSi

issue closedpypa/gh-action-pypi-publish

example usage

I am a bit unsure if I understand what this does. So I am going to give an example for a workflow and explain what I expect this is doing. If this is correct you could include this example in your readme (I can create a pull request if you want). If this is false please correct me:

name: publish
on:
  push:
    branches:
        - master
    # the following would create a release on any tag creation not necessarily a tag
    # referring to a commit on master (i.e. tagged commits in branches would cause
    # releases)
    # tags:
    #   - 'v*'

jobs:
  pypi:
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - name: Set up Python 3.8
        uses: actions/setup-python@v1
        with:
          python-version: 3.8
      - name: build package
        run: python setup.py sdist bdist_wheel
      - name: publish to PyPI
        # only create relases from tagged commits to master:
        if: startsWith(github.ref, 'refs/tags')
        uses: pypa/gh-action-pypi-publish@v1.4.1
        with:
          user: __token__ # use pypi token instead of username/password
          password: ${{ secrets.pypi_token }} # use secret from github secrets

and another question: can I somehow restrict tagnames to v* ?

closed time in 3 days

FelixBenning

push eventaio-libs/yarl

Serhiy Storchaka

commit sha f12b4d044274497c505d328c781439c14669ed5c

Fix `URL.human_repr()` to always return URLs equivalent to the source PR #512 Co-authored-by: Sviatoslav Sydorenko <webknjaz@redhat.com>

view details

push time in 3 days

PR merged aio-libs/yarl

Reviewers
Fix `URL.human_repr()` to always return URLs equivalent to the source bot:chronographer:provided bug

It now %-encodes delimiters and non-printable characters and works correctly with IPv6 addresses.

Closes #511.

+94 -11

2 comments

3 changed files

serhiy-storchaka

pr closed time in 3 days

issue closedaio-libs/yarl

Sometimes `URL.human_repr()` produces inequivalent URLs

For example:

>>> u = URL('http://bob:%40malware.com%2F@example.org/path')
>>> str(u)
'http://bob:%40malware.com%2F@example.org/path'
>>> u.host
'example.org'
>>> u.human_repr()
'http://bob:@malware.com/@example.org/path'
>>> URL(u.human_repr()).host
'malware.com'

There are similar problems with user, path and query.

I think that human_repr() should produce a string which will produce the equivalent URL when passed to the URL constructor. It means that all corresponding delimiters and % should be %-encoded. It is worth to encode also non-printable characters.

closed time in 3 days

serhiy-storchaka
PullRequestReviewEvent
PullRequestReviewEvent

push eventsanitizers/patchback-github-app

Sviatoslav Sydorenko

commit sha 87971e44049caeb557f1ac23c8a6b49be9c43ec3

✨ Implement per-repo 🤖 configuration This change implements a `config.get_patchback_config()` helper for retrieving the App configs from the repos where Patchback is installed. It adds a `config.PatchbackConfig()` dataclass holding all the settings with the defaults that are overridden if a given repo has some settings changed in their `.github/patchback.yml`. Resolves: #5 The settings added are: * backport_branch_prefix -- backport PR branch prefix, makes it easier to identify patchback-created branches (default: 'patchback/backports/') Resolves: #8 * backport_label_prefix -- prefix for labels triggering the backport workflow that needs to be cut off from the label to get the "version" part (default: 'backport-') Resolves: #6 * target_branch_prefix -- prefix that the older or stable version branch has that needs to be prependend to the "version" part of the label (default: '') Resolves: #6

view details

push time in 3 days

issue closedsanitizers/patchback-github-app

[TODO] Make cutting branch prefixes configurable

Currently, backporting into stable-1.0 requires using backport-stable-1.0 label... But it'd be cleaner if we could support backport-1.0 instead.

This would require a config option stating that stable- is a target prefix and we'd just add it when figuring out the target branch. Similarly, we could also make backport- label prefix configurable (the thing we cut off from the label).

Depends on: https://github.com/sanitizers/patchback-github-app/issues/5

closed time in 3 days

webknjaz

push eventsanitizers/patchback-github-app

Sviatoslav Sydorenko

commit sha 48b8b552d1596d389daa88d69c5dae57e0d8003a

✨ Implement per-repo 🤖 configuration This change implements a `config.get_patchback_config()` helper for retrieving the App configs from the repos where Patchback is installed. It adds a `config.PatchbackConfig()` dataclass holding all the settings with the defaults that are overridden if a given repo has some settings changed in their `.github/patchback.yml`. Resolves: #5 The settings added are: * backport_branch_prefix -- backport PR branch prefix, makes it easier to identify patchback-created branches (default: 'patchback/backports/') Resolves: #8 * backport_label_prefix -- prefix for labels triggering the backport workflow that needs to be cut off from the label to get the "version" part (default: 'backport-') Resolves: #8 * target_branch_prefix -- prefix that the older or stable version branch has that needs to be prependend to the "version" part of the label (default: '') Resolves: #8

view details

push time in 3 days

issue closedsanitizers/patchback-github-app

[TODO] Make backport branch naming pattern configurable

Not sure if the whole pattern needs to be changeable but specifying a branch prefix would be a good idea.

Depends on: https://github.com/sanitizers/patchback-github-app/issues/5

closed time in 3 days

webknjaz

issue closedsanitizers/patchback-github-app

[TODO] Implement GitHub App per-repo configurability

Example: https://github.com/sanitizers/chronographer-github-app/blob/e9c353a/chronographer/file_utils.py#L42-L48 (maybe pass config_name='patchback.yml' instead)

closed time in 3 days

webknjaz

push eventsanitizers/patchback-github-app

Sviatoslav Sydorenko

commit sha ef49c7d11472393654e4efbd92633a785edad91b

✨ Implement per-repo 🤖 configuration This change implements a `config.get_patchback_config()` helper for retrieving the App configs from the repos where Patchback is installed. It adds a `config.PatchbackConfig()` dataclass holding all the settings with the defaults that are overridden if a given repo has some settings changed in their `.github/patchback.yml`. The settings added are: * backport_branch_prefix -- backport PR branch prefix, makes it easier to identify patchback-created branches (default: 'patchback/backports/') * backport_label_prefix -- prefix for labels triggering the backport workflow that needs to be cut off from the label to get the "version" part (default: 'backport-') * target_branch_prefix -- prefix that the older or stable version branch has that needs to be prependend to the "version" part of the label (default: '')

view details

push time in 3 days

issue commentkislyuk/yq

[2.11.0 regression] The CLI explodes with jq help output on stdin

I confirm that this fixes the issue.

webknjaz

comment created time in 4 days

CommitCommentEvent

push eventaio-libs/night-watch

Sviatoslav Sydorenko

commit sha 4ba47e99e4d78733abea03947265200406bf4f80

Use yq v2.11.1 Ref: https://github.com/kislyuk/yq/issues/103#issuecomment-699557072

view details

push time in 4 days

issue commentaio-libs/yarl

yarl==1.6.0 causing problems with Python 3.6

Nobody else provided anything actionable, no demos, no proofs, no STRs, not even an explanation for what they meant under "something doesn't work". I have a proof in CI that everything supported works.

YashTatkondawar

comment created time in 4 days

CommitCommentEvent
CommitCommentEvent

issue commentkislyuk/yq

[2.11.0 regression] The CLI explodes with jq help output on stdin

P.S. Since the env is Travis CI, you may be right that it's because of TTY. Is there a flag to enforce the old behavior?

webknjaz

comment created time in 4 days

issue commentkislyuk/yq

[2.11.0 regression] The CLI explodes with jq help output on stdin

@kislyuk it's that repo that does not work. But I've reverted the version to 2.10 (https://github.com/aio-libs/night-watch/commit/2720096e2c941429cb2f37e4e2a550996b6ad793) in master. You can clone it and check out something like HEAD~2 which does not restrict the version in pip install.

webknjaz

comment created time in 4 days

issue commentaio-libs/yarl

yarl==1.6.0 causing problems with Python 3.6

Just upgrade then, we don't support old releases anyway.

YashTatkondawar

comment created time in 4 days

issue commentaio-libs/yarl

Is it possible to not treat semicolons as query delimiter?

Neither WHATWG nor W3C influence how HTTP works: it's defined by RFCs. WHATWG/W3C show us one of the ways of writing high-level applications not top of HTTP which by itself is lower level. YARL is used in HTTP frameworks and thus it must follow RFCs, because higher-level users may interpret things according to their app needs while HTTP-level interactions should remain intact.

playpauseandstop

comment created time in 4 days

Pull request review commentaio-libs/yarl

Fix `URL.human_repr()` to always return URLs equivalent to the source

 def join(self, url):      def human_repr(self):         """Return decoded human readable string for URL representation."""-+        user = _human_quote(self.user, "#/:?@")+        password = _human_quote(self.password, "#/:?@")+        host = self.host+        if host:+            host = self._encode_host(self.host, human=True)+        path = _human_quote(self.path, "#?")+        query_string = "&".join(+            f'{_human_quote(k, "#&+;=")}={_human_quote(v, "#&+;=")}'+            for k, v in self.query.items()

I have a hunch that this may break backward compatibility with the old ; subdelimiter (https://github.com/cherrypy/cherrypy/issues/1860#issuecomment-640246780). Could you please ensure that it's explicitly covered with tests?

serhiy-storchaka

comment created time in 4 days

PullRequestReviewEvent

issue closedaio-libs/yarl

yarl==1.6.0 causing problems with Python 3.6

Using latest yarl==1.6.0 is causing multiple issues with the Python 3.6

closed time in 4 days

YashTatkondawar

issue commentaio-libs/yarl

yarl==1.6.0 causing problems with Python 3.6

Your build-ci.sh breaks your installation with sed -i "s/, requote=False//g" /home/nemo/bluepill/build/lib/python3.8/site-packages/yarl/_url.py by removing requote=False from _make_netloc() method declaration here https://github.com/aio-libs/yarl/blob/663a3c7/yarl/_url.py#L759. And so when other parts of code legitimately call it with the arg, Python tells you that there's no arg (which is expected).

When you patch your env, you don't get what we ship. What you get is unsupported and you're solely responsible for breaking your own env, this has nothing to do with yarl.

Looks like this case is closed.

YashTatkondawar

comment created time in 4 days

push eventaio-libs/yarl

Serhiy Storchaka

commit sha 663a3c7f2f050849daa782381934d823fd247097

Make black compatible with Python 3.5 (#513)

view details

push time in 4 days

PR merged aio-libs/yarl

Make black compatible with Python 3.5

black 20.8b1 adds by default a trailing comma in a function definition (actually this feature is not stable). This syntax is not compatible with Python 3.5.

+2 -2

1 comment

1 changed file

serhiy-storchaka

pr closed time in 4 days

PullRequestReviewEvent

Pull request review commentaio-libs/yarl

Fix human_repr().

+``human_repr()`` now always produce valid representation equivalent to the original URL (if the original URL is valid).
``human_repr()`` now always produces valid representation equivalent to the original URL (if the original URL is valid).
serhiy-storchaka

comment created time in 4 days

PullRequestReviewEvent

issue openedkislyuk/yq

[2.11.0 regression] The CLI explodes with jq help output on stdin

2.10 works: https://travis-ci.com/github/aio-libs/night-watch/builds/186810067

2.11 does not:

  • https://travis-ci.com/github/aio-libs/night-watch/builds/186809522#L258
  • https://travis-ci.com/github/aio-libs/night-watch/builds/186809919#L258

created time in 4 days

push eventaio-libs/night-watch

Sviatoslav Sydorenko

commit sha f63e4911dfcd38f4ff0cd03a0a4e0f54c42a68c5

Revert runpy

view details

push time in 4 days

push eventaio-libs/night-watch

Sviatoslav Sydorenko

commit sha 2720096e2c941429cb2f37e4e2a550996b6ad793

Use older yq

view details

push time in 4 days

push eventaio-libs/night-watch

Sviatoslav Sydorenko

commit sha 13ca226835f12033e25eb9d83fedc4abe9f0c6c9

Use runpy with yq

view details

push time in 4 days

issue commentsanitizers/octomachinery

[TODO] Implement a mechanism for synthetic events

Possible extra use case: https://github.com/thoth-station/qeb-hwt/blob/19d3d3f/app.py#L156-L157

webknjaz

comment created time in 4 days

more