profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/vthapar/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

vthapar/odl-openstack 7

This repository contains multiple local.conf files to have an OpenDaylight integrated Devstack setup

shague/odltools 1

A tool to troubleshoot the NetVirt OpenDaylight OpenStack integration.

vthapar/admiral 0

Admiral is the submariner API for integration with federation systems

vthapar/cloud-prepare 0

Go library to prepare your cloud infrastructure via API for submariner to work on top

vthapar/console 0

The user interface for the cluster management portion of open-cluster-management.

vthapar/deploy 0

Deploy Development Builds of Open Cluster Management (OCM) on RedHat Openshift Container Platform

vthapar/lighthouse 0

Controller to facilitate DNS discovery between clusters (proof of concept state)

vthapar/odltools 0

A tool to troubleshoot the NetVirt OpenDaylight OpenStack integration.

PR opened submariner-io/submariner-charts

Add endpontslices/restricted to lighthouse-agent

Fixes: submariner-io/lighthouse#627

Signed-off-by: Vishal Thapar 5137689+vthapar@users.noreply.github.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+1 -0

0 comment

1 changed file

pr created time in 3 days

create barnchvthapar/submariner-charts

branch : endpointslices-restricted

created branch time in 3 days

PullRequestReviewEvent
PullRequestReviewEvent

issue commentsubmariner-io/lighthouse

Running E2E tests with k8s 1.22 failed

@maayanf24 Can you share the gather logs output? Want to check if this error shows up only on cluster where we're running broker or all data clusters.

maayanf24

comment created time in 4 days

PullRequestReviewEvent

push eventvthapar/console

James Talton

commit sha cb42e5700356e33560433182ba7b9759cd670b81

Webpack (#824) * initial webpack support Signed-off-by: James Talton <jtalton@redhat.com> * webpack work Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * cleanup Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * cleanup Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * fixes Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * hot module replacement Signed-off-by: James Talton <jtalton@redhat.com> * proxies Signed-off-by: James Talton <jtalton@redhat.com> * types Signed-off-by: James Talton <jtalton@redhat.com> * tsconfig Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * hot reload fix Signed-off-by: James Talton <jtalton@redhat.com> * update packages Signed-off-by: James Talton <jtalton@redhat.com> * fixes Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * updates Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * webpack working Signed-off-by: James Talton <jtalton@redhat.com> * fix output directory Signed-off-by: James Talton <jtalton@redhat.com> * eslint fix Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * fixes Signed-off-by: James Talton <jtalton@redhat.com> * fix file serve Signed-off-by: James Talton <jtalton@redhat.com> * fix test Signed-off-by: James Talton <jtalton@redhat.com> * fix production paths Signed-off-by: James Talton <jtalton@redhat.com> * cleanup Signed-off-by: James Talton <jtalton@redhat.com>

view details

James Talton

commit sha ae9a6fa0294dc62f08a5e65a0e9bdb17392ed684

Move back to using npm (#825) * initial webpack support Signed-off-by: James Talton <jtalton@redhat.com> * webpack work Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * cleanup Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * cleanup Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * fixes Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * hot module replacement Signed-off-by: James Talton <jtalton@redhat.com> * proxies Signed-off-by: James Talton <jtalton@redhat.com> * types Signed-off-by: James Talton <jtalton@redhat.com> * tsconfig Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * hot reload fix Signed-off-by: James Talton <jtalton@redhat.com> * update packages Signed-off-by: James Talton <jtalton@redhat.com> * fixes Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * updates Signed-off-by: James Talton <jtalton@redhat.com> * work Signed-off-by: James Talton <jtalton@redhat.com> * webpack working Signed-off-by: James Talton <jtalton@redhat.com> * fix output directory Signed-off-by: James Talton <jtalton@redhat.com> * eslint fix Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * fixes Signed-off-by: James Talton <jtalton@redhat.com> * fix file serve Signed-off-by: James Talton <jtalton@redhat.com> * fix test Signed-off-by: James Talton <jtalton@redhat.com> * fix production paths Signed-off-by: James Talton <jtalton@redhat.com> * cleanup Signed-off-by: James Talton <jtalton@redhat.com> * npm Signed-off-by: James Talton <jtalton@redhat.com> * tests Signed-off-by: James Talton <jtalton@redhat.com> * tweak Signed-off-by: James Talton <jtalton@redhat.com> * formatting Signed-off-by: James Talton <jtalton@redhat.com> * update backend packages Signed-off-by: James Talton <jtalton@redhat.com> * update scripts Signed-off-by: James Talton <jtalton@redhat.com> * resources Signed-off-by: James Talton <jtalton@redhat.com> * update packages Signed-off-by: James Talton <jtalton@redhat.com> * fix Signed-off-by: James Talton <jtalton@redhat.com> * fix dockerfile Signed-off-by: James Talton <jtalton@redhat.com> * dockerfile fix Signed-off-by: James Talton <jtalton@redhat.com> * prow fix Signed-off-by: James Talton <jtalton@redhat.com>

view details

Vishal Thapar

commit sha 7e3a47f0487fc94e09e59ac02a7982919fea55d1

Add nattEnable flag for submariner-addon Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>

view details

push time in 2 months

push eventvthapar/submariner-addon

Vishal Thapar

commit sha 8baaccbbc1d6688d25178472ac41f69d6217c957

Add NATTDiscoveryPort to submarinerconfig spec Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>

view details

push time in 2 months

push eventvthapar/submariner-addon

Vishal Thapar

commit sha e42ea77a6a845c11589664e362e95cd1f1881be0

Add NATTDiscoveryPort to submarinerconfig spec Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>

view details

push time in 2 months

push eventvthapar/submariner-addon

Vishal Thapar

commit sha 563760606bdd0dd248b8bb657959ffa64333f1a7

Add NATTDiscoveryPort to submarinerconfig spec Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>

view details

push time in 2 months

Pull request review commentopen-cluster-management/submariner-addon

Add NATTDiscoveryPort to submarinerconfig spec

 type machineSetConfig struct { }  type awsProvider struct {-	workClinet    workclient.Interface-	awsClinet     client.Interface-	eventRecorder events.Recorder-	region        string-	infraId       string-	ikePort       int64-	nattPort      int64-	clusterName   string-	instanceType  string-	gateways      int-	cloudPrepare  cpapi.Cloud+	workClinet        workclient.Interface

@mangelajo This is used in about 20 different places in code. IMO this change should be done in a separate PR to avoid cluttering this one. thoughts?

vthapar

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentopen-cluster-management/submariner-addon

Add NATTDiscoveryPort to submarinerconfig spec

 spec:             IPSecNATTPort:               description: IPSecNATTPort represents IPsec NAT-T port (default 4500).               type: integer+            NATTDiscoveryPort:+              description: NATTDiscoveryPort represents NAT-T Discovery port (default UDP/4900).+              type: integer

Yeah, I wasn't sure of this either, but this change was already done in fix for VxLan and NattEnable. Should we remove those from 0.3.0 too?

vthapar

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentopen-cluster-management/submariner-addon

Add NATTDiscoveryPort to submarinerconfig spec

 spec:                 default: 4500                 description: IPSecNATTPort represents IPsec NAT-T port (default 4500).                 type: integer+              NATTDiscoveryPort:+                default: 4900+                description: NATTDiscoveryPort represents NAT-T Discovery port (default UDP/4900).

There is a way we can make it work without needing it to be a list. For multiple gateways we can treat configured port as base port and increment by 1 for every extra gateway. e.g. in config we only have 4500 for IPSEC, but if user configures 3 gateways we can use 4500, 4501 and 4502. Such a change can be easily implemented on submariner code without needing changes anywhere else.

If above doesn't work, we can always make it a user configured list later.

vthapar

comment created time in 2 months

PullRequestReviewEvent

push eventvthapar/submariner-addon

Daniel Farrell

commit sha f6c4728bd3ea1ee0b5820e2b28c49cfb6766a6e6

Add golangci-lint make target, linter config Add a make target for running Go linting via golangci-lint. Add configuration for golangci-lint, copied from the main Submariner repo. Disable all currently-failing tests. This will be consumed by Prow to run CI. The tool install will be handled by Prow. To use locally, golangci-lint and go >1.15 are required. Signed-off-by: Daniel Farrell <dfarrell@redhat.com>

view details

OpenShift Merge Robot

commit sha fbc52d3409c63e38decda460927b4d07a334e69e

Merge pull request #120 from dfarrell07/make_golint Add golangci-lint make target, linter config

view details

Janki Chhatbar

commit sha dba3188d1c6ca600039ab169a9c5e50ec0eab40f

Enable PR dependency check jobs This job marks a PR `dependent` whenever a dependent PR is mentioned via `Depends on/ depends on` keyword. The job fails until the dependent PR is not merged. This helps in properly managing merging of dependent PRs. Signed-off-by: Janki Chhatbar <jchhatba@redhat.com>

view details

OpenShift Merge Robot

commit sha 339da656263f2b6c7c1f3181c1a9e8acd6ccbb75

Merge pull request #110 from Jaanki/dependent-pr Enable PR dependency check jobs

view details

Vishal Thapar

commit sha a5a51d0e3efa34f6cca94402eb195ed813c60f1d

Add NATTDiscoveryPort to submarinerconfig spec Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>

view details

push time in 2 months

Pull request review commentopen-cluster-management/submariner-addon

Add NATTDiscoveryPort to submarinerconfig spec

 func NewGCPProvider( // 1. create the inbound and outbound firewall rules for submariner, below ports will be opened //    - IPsec IKE port (by default 500/UDP) //    - NAT traversal port (by default 4500/UDP)+//    - NAT traversal discovery port (by default 4900/UDP) //    - 4800/UDP port to encapsulate Pod traffic from worker and master nodes to the Submariner Gateway nodes // 2. create the inbound and outbound firewall rules to open 8080/TCP port to export metrics service from the Submariner gateway func (g *gcpProvider) PrepareSubmarinerClusterEnv() error {-	// open IPsec IKE port (by default 500/UDP), NAT traversal port (by default 4500/UDP) and route port (4800/UDP)-	ports := []string{g.ikePort, g.nattPort, g.routePort}+	// open IPsec IKE port (by default 500/UDP), NAT traversal port (by default 4500/UDP),+	// NAT Traversal discovery port (be default 4900/udp) and route port (4800/UDP)

It uses the term route port in code too, so I'd prefer to retain it to avoid confusion.

vthapar

comment created time in 2 months

PullRequestReviewEvent

Pull request review commentopen-cluster-management/submariner-addon

Add NATTDiscoveryPort to submarinerconfig spec

 EOF {"op":"add","path":"/spec/imagePullSpecs/submarinerImagePullSpec","value":"'${submrepo}'/submariner-gateway:'${submver}'"}, {"op":"add","path":"/spec/imagePullSpecs/submarinerRouteAgentImagePullSpec","value":"'${submrepo}'/submariner-route-agent:'${submver}'"}, {"op":"add","path":"/spec/imagePullSpecs/lighthouseAgentImagePullSpec","value":"'${submrepo}'/lighthouse-agent:'${submver}'"},-{"op":"add","path":"/spec/imagePullSpecs/lighthouseCoreDNSImagePullSpec","value":"'${submrepo}'/lighthouse-coredns:'${submver}'"}]'+{"op":"add","path":"/spec/imagePullSpecs/lighthouseCoreDNSImagePullSpec","value":"'${submrepo}'/lighthouse-coredns:'${submver}'"},+{"op":"add","path":"/spec/NATTEnable","value":false}]'

With NAT Enable as default true, local kind installation fails. I had split off deploy fixes in kind into a separate PR, but since it was merged before NATEnable, had to remove this line from that PR. Instead of creating another new PR decided to add in here.

vthapar

comment created time in 2 months

PullRequestReviewEvent

push eventvthapar/console

Vishal Thapar

commit sha af9c0dd87d15d22d4733f0e65c57384e95da2631

Add nattEnable flag for submariner-addon Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>

view details

push time in 2 months

push eventvthapar/submariner-addon

Vishal Thapar

commit sha 0d9789558cd3d523a152ed7be34d7a23537bd24b

Add NATTDiscoveryPort to submarinerconfig spec Signed-off-by: Vishal Thapar <5137689+vthapar@users.noreply.github.com>

view details

push time in 2 months

pull request commentopen-cluster-management/submariner-addon

Add NATTDiscoveryPort to submarinerconfig spec

/cc @mangelajo @sridhargaddam @skitt

vthapar

comment created time in 2 months

PullRequestReviewEvent

create barnchvthapar/submariner-addon

branch : natt-discovery

created branch time in 2 months

create barnchvthapar/console

branch : natt-enable

created branch time in 2 months

pull request commentopen-cluster-management/submariner-addon

Add NATTEnable flag to SubmarinerConfigSpec

/cc @qiujian16 @zhiweiyin318 @skeeey @skitt

vthapar

comment created time in 2 months