profile
viewpoint

jbirchevans/tabletop-api 1

Create an open source API that can be used to manage campaigns, PC's and NPC's

vreemt/bornhack-hottub 0

a simbple web serving hot tub temperature thingy

vreemt/git 0

Git Source Code Mirror - This is a publish-only repository and all pull requests are ignored. Please follow Documentation/SubmittingPatches procedure for any of your improvements.

vreemt/git-scm.com 0

Current version of the http://git-scm.com site

vreemt/haphpy-birthday 0

Website for PHP 20th anniversary video

vreemt/J2M 0

Convert from JIRA text formatting to GitHub Flavored MarkDown and back again

vreemt/MailHog 0

Web and API based SMTP testing

vreemt/mytest 0

test

vreemt/ng-cordova-oauth 0

AngularJS oauth library for use with Apache Cordova projects

vreemt/Parse-SDK-JS 0

Parse SDK for JavaScript

pull request commentparse-community/parse-server

Attempt to remove the schemaCache

Do we need to add Postgres support with the PR already, or can this come at a later stage? @cbaker6 would you want to look into replicating this feature for Postgres?

SebC99

comment created time in 5 minutes

issue commentumbraco/Umbraco-CMS

Save then Preview can lead to loss of content

I had a look through all issues related to preview and don't see any relevant fixes, most likely present in later versions of Umbraco though not explictly tested by me. The button rename in #7621 will go some way to avoiding this issue from being triggered by editors

agrath

comment created time in 13 minutes

issue commentumbraco/Umbraco-CMS

Save then Preview can lead to controls not reinitialising in admin

https://github.com/umbraco/Umbraco-CMS/issues/6423 mentions preventing the save step of preview if the page is not dirty This would also prevent the issue as the second save (triggered by the preview flow) would not attempt the save (which saves incomplete/unloaded data) as the node would not be marked dirty at this time

agrath

comment created time in 23 minutes

issue commentumbraco/Umbraco-CMS

Preview button should it be renamed Save & Preview?

This issue that i've just raised https://github.com/umbraco/Umbraco-CMS/issues/9457 is indirectly caused by this editor behaviour of pressing save then preview (because the label doesn't make it clear that preview also does a save)

Matthew-Wise

comment created time in 27 minutes

issue commentumbraco/Umbraco-CMS

Save then Preview can lead to controls not reinitialising in admin

This is a screen recording demonstrating the issue (I have described/annotated with audio explaining what i'm doing and what to look for)

https://www.dropbox.com/s/ken1zxghg38fu3p/ice_video_20201127-112041.mp4?dl=0

I think the correct fix is to disable the buttons following a click until the current action is complete, including the reload. If a validation or other error occurs, re-enable the buttons.

agrath

comment created time in 32 minutes

issue commentumbraco/Umbraco-CMS

Lucene.Net.Store.AlreadyClosedException: this IndexReader is closed

Update: I found out that these exceptions occur when bots are crawling the site. I guess the amount of requests just bring the index to the knees, when its containing large number of members.

deekoulos

comment created time in 2 hours

issue commentumbraco/Umbraco-CMS

Rebuilding the member index causes time out exception

I think I found the issue.

I was rebuilding the index on application start and unlocking the index if it was locked and in some cases, it led to those exceptions:

```

[RuntimeLevel(MinLevel = RuntimeLevel.Run)] // register the component public class CustomizeIndexComposer : ComponentComposer<CustomizeIndexComponent> { }

public class CustomizeIndexComponent : IComponent
{
    private readonly IExamineManager _examineManager;
    private readonly IndexRebuilder _indexRebuilder;

    public CustomizeIndexComponent(IExamineManager examineManager, IndexRebuilder indexRebuilder)
    {
        _examineManager = examineManager;
        _indexRebuilder = indexRebuilder;
    }

    public void Initialize()
    {
        if (!_examineManager.TryGetIndex(Constants.UmbracoIndexes.MembersIndexName, out IIndex index))
            return;

        // modify an existing field type (not recommended)
        index.FieldDefinitionCollection.AddOrUpdate(new FieldDefinition("minimumProjectSize", FieldDefinitionTypes.Integer));
        index.FieldDefinitionCollection.AddOrUpdate(new FieldDefinition("memberGroups", FieldDefinitionTypes.FullTextSortable));

        var luceneIndex = index as LuceneIndex;
        var dir = luceneIndex.GetLuceneDirectory();
        if (IndexWriter.IsLocked(dir))
            IndexWriter.Unlock(dir);

        _indexRebuilder.RebuildIndex(index.Name);
    }

    public void Terminate() { }
}

The reason why I had to do this was that by updating field definitions at this stage, without rebuilding the index, the index was kinda empty. no members in it. So I had to find a way to update the field definitions like above and rebuild the index to get all members back in it. Now I found a way to work around the above field updates. Without updating the field definitions, I do not need to rebuild the index here and since then I have no exceptions.

Which is not really a solution for this issue but at least a work around.

I think unlocking a locked index is not a good approach, but I wasn't able to find any other solution, to update field definitions and keeping the member index state ready with all data in it. 

Best
Dee
deekoulos

comment created time in 2 hours

PR closed h5bp/html5-boilerplate

Dev

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

+1 -3

0 comment

1 changed file

MatthewJacksonCM

pr closed time in 7 hours

PR opened h5bp/html5-boilerplate

Dev

Types of changes

<!--- What types of changes does your code introduce? Put an x in all the boxes that apply: -->

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

<!--- Go over all the following points, and put an x in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->

  • [ ] My code follows the code style of this project.
  • [ ] My change requires a change to the documentation.
  • [ ] I have updated the documentation accordingly.
  • [ ] I have read the CONTRIBUTING document.
  • [ ] I have added tests to cover my changes.
  • [ ] All new and existing tests passed.

Pull requests should be thought of as a conversation. There will be some back and forth when trying to get code merged into this or any other project. With all but the simplest changes you can and should expect that the maintainers of the project will request changes to your code. Please be aware of that and check in after you open your PR in order to get your code merged in cleanly.

Thanks!

+1 -3

0 comment

1 changed file

pr created time in 7 hours

push eventumbraco/Umbraco-CMS

Niels Lyngsø

commit sha e02732b19bb0a5d5df58af1fd2c527510403f241

adjust slider look

view details

push time in 8 hours

push eventlaravel/laravel

Daniel Coulbourne

commit sha f6f772ba5490de48d8a79747b39540afe61eed24

Uncomment TrustHosts middleware to enable it by default. (#5477)

view details

push time in 8 hours

pull request commentlaravel/laravel

[8.x] Uncomment TrustHosts middleware to enable it by default

I think I will go ahead with this. "Multi-tenant" applications are not as common as traditional applications and if someone is building one they can just comment out the middleware.

DanielCoulbourne

comment created time in 8 hours

PR merged laravel/laravel

[8.x] Uncomment TrustHosts middleware to enable it by default

We recently learned of a vulnerability in our app through our Bug Bounty program which allowed an attacker to change the host of a signed URL using the X-Forwarded-Host header. This allowed an attacker to generate a malicious password-reset email which, if the link was clicked, would send the user's password reset token to a website controlled by the hacker.

Enabling this middleware by default could close this vulnerability for many websites who may currently be exposed to this same vulnerability.

+1 -1

10 comments

1 changed file

DanielCoulbourne

pr closed time in 8 hours

pull request commentumbraco/Umbraco-CMS

Multi URL Picker enhancements, add Content property and option to hide target checkbox

Looks like a pretty solid implementation here @ronaldbarendse - thanks for sorting it, any idea when it maybe approved?

ronaldbarendse

comment created time in 9 hours

push eventumbraco/Umbraco-CMS

Paul Johnson

commit sha 85c706087c752b5a884d68565904663ff3846aa4

Add collection builder support to UmbracoBuilder

view details

Andy Butland

commit sha 0fbe01cd22ea498084068ae607f46ce3195e5640

Created new abstraction IUmbracoWebsiteSecurity and migrated controller's using it (replacing MembershipHelper) to Umbraco.Web.Website.

view details

Simone Chiaretta

commit sha 3303df491804777c5f5c739db1e135527449fef6

Added netcore-only solution file

view details

Andy Butland

commit sha d8ef341854c9f753f3e7ba209ec7788df53e4eef

Refactored to async where appropriate. Added call to new abstraction in member authorize attribute.

view details

Steve Temple

commit sha 945d9b9a8e1ad0555777f2b4ebac604032bf262d

Merge pull request #9411 from simonech/netcore/feature/linux-solution-file Added netcore-only solution file

view details

Andy Butland

commit sha c971a2d23dd9edb2c9f42d373f6e1a3d4ce2f00f

Introduced website security accessor to ensure members aren't shared between sessions.

view details

Andy Butland

commit sha 024b37e0e61da606a9c13d6fd0e08ccd3e782231

Added further method header comment.

view details

Paul Johnson

commit sha aec25d500721af6ba56f53022cee95e37e3ba898

Replace Composition with UmbracoBuilder

view details

Paul Johnson

commit sha 48b61ec4c4196087e98b1f12f3025214e325a2f8

Simplify UmbracoBuilder setup

view details

Elitsa Marinovska

commit sha 790271382e822174d4424ebbfbb1e157d184aa45

Placing ConfigurationEditor to its correct (old) place

view details

Elitsa Marinovska

commit sha 74262e18b54810004716230d98f459f2487be80a

Migrations from PropertyEditors/ValueConverters without dependencies to DataValueEditor or ConfigurationEditor<TConfiguration>

view details

Elitsa Marinovska

commit sha 7809d1501e3e4c6f194f0039170ccf96c4640e47

Migrations from PropertyEditors folder without dependencies to DataValueEditor or ConfigurationEditor<TConfiguration>

view details

Paul Johnson

commit sha 3672a9f2f28fcdf0ff4fe29fa9d6d0fef59317db

Add composers via extension on UmbracoBuilder reduce scope of CoreRuntimeBootstrapper

view details

Paul Johnson

commit sha 8b97ce69b18907a638e61647818ca72d0c78dd00

Removed CoreRuntimeBootstrapper Establish runtime level at run time not during service registration.

view details

Paul Johnson

commit sha daf972fc62d7153ec0af26b24d52264d6eae74c3

Closer to removing all BuildServiceProvider calls

view details

Paul Johnson

commit sha 4520b2ab21785ea044937fead4afdcb39a97e236

Fix for failing test RelationRepositoryTests.Get_Paged_Child_Entities_By_Parent_Id

view details

Paul Johnson

commit sha 5b1ccb065919d28ef8a3ea21a62617e87346becd

Remove the crazy Func param on AddUmbracoCore

view details

Paul Johnson

commit sha 39657dea6d37e468006174b61f784fa583595e6b

UmbracoBuilder now requires TypeLoader via ctor

view details

Paul Johnson

commit sha 5e2de50382ce21577a5519b432a55dd77d8df26b

Fix legacy tests

view details

Paul Johnson

commit sha 0241649f7ff2d43d04bc607d422c4eb811cbcbc2

Cleanup AddUmbraco & AddUmbracoCore

view details

push time in 9 hours

push eventumbraco/Umbraco-CMS

Shannon

commit sha e01abf28024c930299f2d153525914a44bc445e1

Moves some files, adds notes, starts poc for back office login providers

view details

Shannon

commit sha c08db7763eccec03bec401a886b636bc8344e32b

Gets oauth working (with google) now need to test others and debug why the styles aren't working

view details

push time in 9 hours

push eventumbraco/Umbraco-CMS

Paul Johnson

commit sha 85c706087c752b5a884d68565904663ff3846aa4

Add collection builder support to UmbracoBuilder

view details

Paul Johnson

commit sha aec25d500721af6ba56f53022cee95e37e3ba898

Replace Composition with UmbracoBuilder

view details

Paul Johnson

commit sha 48b61ec4c4196087e98b1f12f3025214e325a2f8

Simplify UmbracoBuilder setup

view details

Paul Johnson

commit sha 3672a9f2f28fcdf0ff4fe29fa9d6d0fef59317db

Add composers via extension on UmbracoBuilder reduce scope of CoreRuntimeBootstrapper

view details

Paul Johnson

commit sha 8b97ce69b18907a638e61647818ca72d0c78dd00

Removed CoreRuntimeBootstrapper Establish runtime level at run time not during service registration.

view details

Paul Johnson

commit sha daf972fc62d7153ec0af26b24d52264d6eae74c3

Closer to removing all BuildServiceProvider calls

view details

Paul Johnson

commit sha 4520b2ab21785ea044937fead4afdcb39a97e236

Fix for failing test RelationRepositoryTests.Get_Paged_Child_Entities_By_Parent_Id

view details

Paul Johnson

commit sha 5b1ccb065919d28ef8a3ea21a62617e87346becd

Remove the crazy Func param on AddUmbracoCore

view details

Paul Johnson

commit sha 39657dea6d37e468006174b61f784fa583595e6b

UmbracoBuilder now requires TypeLoader via ctor

view details

Paul Johnson

commit sha 5e2de50382ce21577a5519b432a55dd77d8df26b

Fix legacy tests

view details

Paul Johnson

commit sha 0241649f7ff2d43d04bc607d422c4eb811cbcbc2

Cleanup AddUmbraco & AddUmbracoCore

view details

Paul Johnson

commit sha 73bd42a9160f5fe16d6274d4290788f36525595c

Fix parameter name for IUmbracoBuilder

view details

Paul Johnson

commit sha a62079d79470197cddabae1e2f1afe81381e20c8

Use OptionsMonitorAdapter over AspNetCoreHostingEnvironmentWithoutOptionsMonitor Rollback Serilog setup as I broke BASEDIR env var

view details

Paul Johnson

commit sha 8ca3f602e21603583de6f2b0a66294b88a0a08fa

Further cleanup of AddUmbracoCore IUmbracoBootPermissionChecker is irrelevant in .net core as there's no concept of full trust Allow container to create DbProviderFactoryCreator with a factory method.

view details

Paul Johnson

commit sha 7abf9466c026fd00a827436ba4aaf1d5f4473865

Merge branch 'netcore/netcore' into netcore/feature/msdi-remove-composition

view details

Paul Johnson

commit sha 5268f9d7f03fa2555529c81aec0de4952d9051a2

Resolve review comments

view details

Andy Butland

commit sha b331d683ecb8d665837d48bffd75e855ad52ce3e

Migrated member related partial views along with necessary methods from MembershipHelper into IUmbracoWebsiteSecurity.

view details

Paul Johnson

commit sha 61a4f3f6c66e656b4d6d90f3c34f4772106e9d2f

Always boot for RelationRepository tests If we don't boot tests can fail based on the point at which IPublishedSnapshotService is first resolved. At runtime it is resolved by the NuCacheComponent as soon as CoreRuntime is resolved during UseUmbracoCore. By doing this the integration tests match the real application lifecycle.

view details

Paul Johnson

commit sha 633c391f85d0557411f45f6220081a6df88fb6df

Merge branch 'netcore/netcore' into netcore/feature/msdi-remove-composition

view details

Paul Johnson

commit sha 7e9a13a4ab5b3555371de87f1085d309bd434698

Register instances instead of factory method with discard.

view details

push time in 9 hours

PR opened umbraco/Umbraco-CMS

NetCore: Set up CI with Azure Pipelines project/net-core

Creating a YAML pipeline for Azure DevOps for .NET Core project.

It includes:

  • executing Unit Tests on Linux image;
  • executing Unit Tests on Windows image + building the NuGet packages;
  • executing Integration Tests on Windows (for now all tests are running on 1 server).
+141 -0

0 comment

2 changed files

pr created time in 9 hours

pull request commentwting/autojump

{/usr/bin/ => }env to work with termux

@JohnAZoidberg If it's implemented in a compiled language like Go, we don't have to worry about the shebang lines. So I rewrote it in Go: https://github.com/suzaku/shonenjump

emanresusername

comment created time in 9 hours

push eventumbraco/Umbraco-CMS

Niels Lyngsø

commit sha d583955c2d02ff63f76d9c54f3d4df3ebd4ebf7b

scroll to scale

view details

push time in 10 hours

push eventumbraco/Umbraco-CMS

Elitsa Marinovska

commit sha 10cb685b05b1547271aee8ce25a45951b2c0c570

Adding steps for running the Integration Tests

view details

push time in 11 hours

push eventumbraco/Umbraco-CMS

Elitsa Marinovska

commit sha e5b3f84371fd61b1715580b38274bb5be0017fd0

Fix naming

view details

push time in 11 hours

push eventumbraco/Umbraco-CMS

Elitsa Marinovska

commit sha 8168667267768143505e916e50510a151d175189

adding displayName

view details

push time in 11 hours

issue commentwting/autojump

Created autojump.fish on my Manjaro arch but it keeps saying command not found

I have written a autojump (almost) clone in Go named shonenjump. I've fixed Fish shell support recently, you may want to give it a try.

Odeseos

comment created time in 11 hours

push eventumbraco/Umbraco-CMS

Elitsa Marinovska

commit sha 80379499c3bb793b2621e60e81908a0cadb0505c

syntax issue

view details

push time in 11 hours

push eventumbraco/Umbraco-CMS

Elitsa Marinovska

commit sha 03504399f29461c23aea1ac9296dffa4c66c564a

Adding stages

view details

push time in 11 hours

push eventumbraco/Umbraco-CMS

Elitsa Marinovska

commit sha 2d3bc4bef62f806fbd738c46496a86164c9592fa

Fixing step for building the nuget packages

view details

push time in 12 hours

push eventumbraco/Umbraco-CMS

Andy Butland

commit sha b331d683ecb8d665837d48bffd75e855ad52ce3e

Migrated member related partial views along with necessary methods from MembershipHelper into IUmbracoWebsiteSecurity.

view details

Bjarke Berg

commit sha 41f3dae9c897cfb891fcecd2ba84c1b217c2f12c

Fix paths in LogviewerTests

view details

Paul Johnson

commit sha 7f8ed7b2e3206b58d767dc3fec5c10847d3b13c2

Resolve naming issues from #9415 Note that I removed the comment around funky namespace without changing namespace, dead comment from 2016.

view details

Bjarke Berg

commit sha 0b7f7e4f37d3b778d37cb91a28dd7c4744570284

Use temp path for test Signed-off-by: Bjarke Berg <mail@bergmania.dk>

view details

Bjarke Berg

commit sha 1e2ad85718ebe3e06d6d2bc76db0f0f35d864a25

Fix test for linux: config folder is lowercase Signed-off-by: Bjarke Berg <mail@bergmania.dk>

view details

Bjarke Berg

commit sha a117d6be925a0b090d40ca5ce1fe4223a946270d

Fix test for linux: use temp folder inside content root Signed-off-by: Bjarke Berg <mail@bergmania.dk>

view details

Bjarke Berg

commit sha 052b8fc9b41ac3b404e06dd0b68b3bc7ffe96236

Merge pull request #9451 from rustybox/netcore/netcore Netcore: Misc resolve naming issues

view details

Bjarke Berg

commit sha e17cc8ad706b583a01d596a9d1b87605f8f088ca

Merge pull request #9452 from umbraco/netcore/bugfix/linux-fix-test Netcore: Fix unit tests, so they pass on linux too

view details

Paul Johnson

commit sha 667c00ccd4d3373650b28af9c072f4335b3c924a

Hotfix for PublishedSnapshotService initialization

view details

Bjarke Berg

commit sha 9b567cb6afdf21ef75162526efb039bd7f9acf21

Merge pull request #9455 from rustybox/netcore/netcore Netcore: Hotfix for PublishedSnapshotService initialization

view details

Bjarke Berg

commit sha 642c4550249b0c02bc43fe71f2aea9903537c3d2

Reuse UmbracoWebsiteSecurityAccessor.WebsiteSecurity and align with other templates, by saving in variable even if it is just used once. + Signed-off-by: Bjarke Berg <mail@bergmania.dk>

view details

Bjarke Berg

commit sha 2534a32b9f6e7ebbe34f06d51881271445880f46

Handle all PartialViewMacros Templates as content + Aligned directory seperators Signed-off-by: Bjarke Berg <mail@bergmania.dk>

view details

Bjarke Berg

commit sha 87b6c4852f26ad3913244af915cca37aade497c0

Merge pull request #9448 from AndyButland/feature/membership-helper-facade-2 NetCore: Migrated member related partial views

view details

Bjarke Berg

commit sha 81bbfe93ceb4ab989936e78dd09b11fb11ad28b7

Merge remote-tracking branch 'origin/netcore/netcore' into netcore/task/6666-auth-policies

view details

push time in 12 hours

issue commentumbraco/Umbraco-CMS

[V8] Errors in SurfaceControllers does not get logged

Just to get this one back on track, my loggs are never flooded with exceptions but in each install I have to create a custom logger to log errors in SurfaceControllers,

Also noted that the same is true for UmbracoApiControllers where errors are not getting logged.

I think we should:

  • Remove the condition for HttpExceptions (maybe create a eventhandler if someone wants to filter out some exceptions)
  • Add a ExceptionHandler for errors in WebApi as well.

What do you think?

enkelmedia

comment created time in 12 hours

push eventumbraco/Umbraco-CMS

Elitsa Marinovska

commit sha 5ba4f8f01e88a8191b1c1ff8363175e0159bda68

another syntax fix

view details

push time in 12 hours

more