profile
viewpoint
Michael Vorburger ⛑️ vorburger Google Switzerland http://vorburger.ch Geek Father. EPFL alumni. Speaks Esperanto, Java, no Klingon, but a few other langs. (Works at Google. Formerly at Red Hat. Repos here are personal.)

fabric8io-images/s2i 67

OpenShift S2I images for Java and Karaf applications

lastnpe/eclipse-null-eea-augments 25

Eclipse External null Annotations (EEA) repository

vorburger/ch.vorburger.fswatch 18

Java lib for monitoring directories or individual files via java.nio.file.WatchService

vorburger/ch.vorburger.exec 11

Java library to launch external processes

ericpauley/Alice 9

An alice mod that aims to fix the features of the now inactive Alice 2.2

vorburger/Alice 2

An alice mod that aims to fix the features of the now inactive Alice 2.2

vorburger/awesome-java 1

A curated list of awesome Java frameworks, libraries and software.

vorburger/CFExamples 1

Example projects to demonstrate use of OFSConnectorService Component API in variety of different scenarios for developers

lbovet/replay 0

Record HTTP scenarios and replay them for both the client and the server

Pull request review commentapache/fineract

FINERACT-1241-elastic-web-hook

+/**+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements. See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership. The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License. You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied. See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */+package org.apache.fineract.infrastructure.hooks.processor;++import static org.apache.fineract.infrastructure.hooks.api.HookApiConstants.contentTypeName;+import static org.apache.fineract.infrastructure.hooks.api.HookApiConstants.payloadURLName;++import com.google.gson.Gson;+import com.google.gson.JsonObject;+import java.io.PrintWriter;+import java.util.HashMap;+import java.util.Map;+import java.util.Set;+import org.apache.fineract.infrastructure.hooks.domain.Hook;+import org.apache.fineract.infrastructure.hooks.domain.HookConfiguration;+import org.apache.fineract.useradministration.domain.AppUser;+import org.springframework.beans.factory.annotation.Autowired;+import org.springframework.stereotype.Service;+import retrofit.Callback;++@Service+public class ElasticSearchHookProcessor implements HookProcessor {++    @Autowired+    private ProcessorHelper processorHelper;++    private PrintWriter out = null;

This looks like it's not multi thread safe? Or am I missing anything?

fynmanoj

comment created time in 5 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapache/fineract

FINERACT-1095 Added status parameter in Loans API

@thesmallstar @ptuomola where were we with this one? Good to merge as-is, or updates needed? (Perhaps best to rebase it now.)

thesmallstar

comment created time in 16 hours

pull request commentapache/fineract

Fineract-1058 added support for limit,offset and orderBy in SQLbuilder

@thesmallstar ping on this?

thesmallstar

comment created time in 16 hours

PullRequestReviewEvent

pull request commentapache/fineract

Introduce first "pure Spring" integration test, without Cargo (FINERACT-764)

BTW #1422 has some related thoughts re. our testing strategy, I'll comment over there as well.

vorburger

comment created time in 16 hours

pull request commentapache/fineract

Introduce first "pure Spring" integration test, without Cargo (FINERACT-764)

@ptuomola @vidakovic I'm undecided / unclear where we should take this to.. thoughts? I guess we could... EITHER (probably best AFTER #1465 will have gone in):

a) move towards entirely ditching the Cargo plugin and not start the WAR but just use this new style to fire up Spring "in-process" for (all) ITs

b) forget about this approach and abandon this PR and just close FINERACT-764 (I don't actually really mind either)

c) have some mixed form - keep testing the WAR with the Cargo plugin for some basic tests, but move other ITs to this style.

vorburger

comment created time in 16 hours

Pull request review commentapache/fineract

Introduce first "pure Spring" integration test, without Cargo (FINERACT-764)

      private final int httpPort; -    private ResponseSpecification responseSpec;-    private RequestSpecification requestSpec;+    private final ResponseSpecification responseSpec;+    private final RequestSpecification requestSpec; -    public RestAssuredFixture(int http) {--        this.httpPort = http;+    public RestAssuredFixture() {+        this.httpPort = 844;

@awasum well spotted, yes this looks wrong. It's surprising that it still worked - I think this line can probably be removed. I could do that, but I think there is a larger question of what direction we want to take re ITs - I'll comment on the main comment instead of inline here about that.

vorburger

comment created time in 17 hours

PullRequestReviewEvent

pull request commentapache/fineract

FINERACT-1209: Integration Tests using new Swagger Client API

FYI: don't think this is related to my changes; before a run was failing on a different line (creating Docker images). Locally the integration tests worked ok; maybe the Travis configuration needs some tweaking.

@vidakovic I had a quick closer look, and created FINERACT-1244. Always follow https://github.com/apache/fineract/#pull-requests in such cases.

vidakovic

comment created time in 17 hours

Pull request review commentapache/fineract

FINERACT-1169 fixed credit bureau Loan-product mapping module

 CREATE TABLE `m_creditbureau_loanproduct_mapping` (   `is_creditcheck_mandatory` tinyint DEFAULT NULL,   `skip_creditcheck_in_failure` tinyint DEFAULT NULL,   `stale_period` INT DEFAULT NULL,-  `is_active` tinyint DEFAULT NULL,+  `isActive` tinyint DEFAULT NULL,

@nikpawar89 @rrpawar96 even on the develop branch we should never update existing SQL migration scripts.. think about it, if you have an existing DB, this script won't re-run (because Flyway thinks tgat 327 already ran) - and then your code would fail.

rrpawar96

comment created time in 17 hours

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapache/fineract

Add new ImageTest (FINERACT-1218)

@vidakovic @ptuomola review this one? Finally green build.

vorburger

comment created time in a day

push eventvorburger/fineract

Michael Vorburger

commit sha 8d6cc68483332ea9c80954276cf22ac9d2288192

client: Fix bad dateFormat in FineractClient (FINERACT-1242)

view details

Michael Vorburger

commit sha 95f6f93ebd86fea40f96f47e0b18ab680f48d21f

Add new ImageTest (FINERACT-1218)

view details

push time in 2 days

push eventvorburger/fineract

Michael Vorburger

commit sha 754d1cd878b87a2d79ed8fcdde0c741857ca0a61

client: Fix bad dateFormat in FineractClient (FINERACT-1242)

view details

Michael Vorburger

commit sha 137788beb81d0aa0444f828fc36ae063a17454a7

Add new ImageTest (FINERACT-1218)

view details

push time in 2 days

create barnchvorburger/fineract

branch : FINERACT-1242_FineractClient-dateFormat

created branch time in 2 days

pull request commentapache/fineract

Add new ImageTest (FINERACT-1218)

@vorburger there seems to be an import error?

Fixed that, but I expect that this will now fail due to FINERACT-1242... hereby calling out looking for anyone willing to fix that!

vorburger

comment created time in 2 days

push eventvorburger/fineract

Michael Vorburger

commit sha e714c2f281dd1b70bac6e5f5a94eda0952c65977

Add new ImageTest (FINERACT-1218)

view details

push time in 2 days

Pull request review commentapache/fineract

FINERACT-1241-elastic-web-hook

 public WebHookService createWebHookService(final String url) {         final RestAdapter restAdapter = new RestAdapter.Builder().setEndpoint(url).setClient(new OkClient(client)).build();         return restAdapter.create(WebHookService.class);     }++    public Callback createCallback(final String url, String payload) {++        return new Callback() {++            @Override+            public void success(final Object o, final Response response) {+                LOG.info("URL : {} \tStatus : {}", url, response.getStatus());+            }++            @Override+            public void failure(final RetrofitError retrofitError) {+                LOG.info("{}", retrofitError.getMessage());

LOG.error() is probably better here?

fynmanoj

comment created time in 2 days

Pull request review commentapache/fineract

FINERACT-1241-elastic-web-hook

 import org.apache.fineract.infrastructure.security.service.PlatformSecurityContext; import org.apache.fineract.useradministration.domain.AppUser; import org.joda.time.DateTime;+import org.joda.time.DateTimeZone;

Joda Time support has just been removed.. use java.time.

fynmanoj

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

push eventvorburger/MariaDB4j

dependabot-preview[bot]

commit sha fcb36a1880b34f4b32e71add63cc61a7aaffe83e

Bump mockito-core from 3.5.13 to 3.5.15 Bumps [mockito-core](https://github.com/mockito/mockito) from 3.5.13 to 3.5.15. - [Release notes](https://github.com/mockito/mockito/releases) - [Commits](https://github.com/mockito/mockito/compare/v3.5.13...v3.5.15) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 3 days

delete branch vorburger/MariaDB4j

delete branch : dependabot/maven/org.mockito-mockito-core-3.5.15

delete time in 3 days

PR merged vorburger/MariaDB4j

Bump mockito-core from 3.5.13 to 3.5.15 dependencies

Bumps mockito-core from 3.5.13 to 3.5.15. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/mockito/mockito/releases">mockito-core's releases</a>.</em></p> <blockquote> <h2>v3.5.15</h2> <p><!-- raw HTML omitted --><!-- raw HTML omitted --><em>Release notes were automatically generated by <a href="http://shipkit.org/">Shipkit</a></em><!-- raw HTML omitted --><!-- raw HTML omitted --></p> <h4>3.5.15</h4> <ul> <li>2020-10-19 - <a href="https://github.com/mockito/mockito/compare/v3.5.14...v3.5.15">4 commits</a> by <a href="https://github.com/raphw">Rafael Winterhalter</a> - published to <a href="https://bintray.com/mockito/maven/mockito/3.5.15"><img src="https://img.shields.io/badge/Bintray-3.5.15-green.svg" alt="Bintray" /></a></li> <li>Mock resolver plugin [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2042">#2042</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2042">mockito/mockito#2042</a>)</li> </ul> <h2>v3.5.14</h2> <p><!-- raw HTML omitted --><!-- raw HTML omitted --><em>Release notes were automatically generated by <a href="http://shipkit.org/">Shipkit</a></em><!-- raw HTML omitted --><!-- raw HTML omitted --></p> <h4>3.5.14</h4> <ul> <li>2020-10-17 - <a href="https://github.com/mockito/mockito/compare/v3.5.13...v3.5.14">2 commits</a> by <a href="https://github.com/Marcono1234">Marcono1234</a> (1), <a href="https://github.com/shestee">shestee</a> (1) - published to <a href="https://bintray.com/mockito/maven/mockito-development/3.5.14"><img src="https://img.shields.io/badge/Bintray-3.5.14-green.svg" alt="Bintray" /></a></li> <li>Fixes <a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2061">#2061</a>: ArgumentMatcher error messages use lambda class names [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2071">#2071</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2071">mockito/mockito#2071</a>)</li> <li>Fixed typo in osgi.gradle [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2070">#2070</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/pull/2070">mockito/mockito#2070</a>)</li> <li>Lambda used as ArgumentMatcher causes decamelized lambda name to appear in error message [(<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2061">#2061</a>)](<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2061">mockito/mockito#2061</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/mockito/mockito/commit/18da8f2a874bf0d366453d9391e78ef861a833a6"><code>18da8f2</code></a> 3.5.15 release (previous 3.5.14) + release notes updated by CI build 4819</li> <li><a href="https://github.com/mockito/mockito/commit/e098342c3cfad32a8b183593aa6719fb66b72674"><code>e098342</code></a> [ci maven-central-release] Merge pull request <a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2042">#2042</a> from mockito/mock-resolve...</li> <li><a href="https://github.com/mockito/mockito/commit/e388e924ccc018934def0eb189a2926fca6063cb"><code>e388e92</code></a> 3.5.14 release (previous 3.5.13) + release notes updated by CI build 4814</li> <li><a href="https://github.com/mockito/mockito/commit/214d66fa84af85026be9791456fccc06af2f6b61"><code>214d66f</code></a> Fixes <a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2061">#2061</a>: ArgumentMatcher error messages use lambda class names (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2071">#2071</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/b16ec17cafdbf4fb968413c4992f044c1bb9526a"><code>b16ec17</code></a> Fix typo in osgi.gradle (<a href="https://github-redirect.dependabot.com/mockito/mockito/issues/2070">#2070</a>)</li> <li><a href="https://github.com/mockito/mockito/commit/c81b028f4ac121f4939341ef724465d307274cd0"><code>c81b028</code></a> Fixing "best" constructor choice.</li> <li><a href="https://github.com/mockito/mockito/commit/48d817fe83c556e95cf84e87d9a119211351a08f"><code>48d817f</code></a> Add mock resolver API to allow for resolving provided instances from third-pa...</li> <li><a href="https://github.com/mockito/mockito/commit/e6fdaf766d42b9acda43ed1a7ced02b83859196d"><code>e6fdaf7</code></a> Complete javadoc.</li> <li>See full diff in <a href="https://github.com/mockito/mockito/compare/v3.5.13...v3.5.15">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

If all status checks pass Dependabot will automatically merge this pull request.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

</details>

+1 -1

0 comment

1 changed file

dependabot-preview[bot]

pr closed time in 3 days

PullRequestReviewEvent

pull request commentapache/fineract

Add new ImageTest (FINERACT-1218)

@vidakovic @ptuomola this one is next.. do you both want to review and LGTM this, and the 2nd one merges when good?

vorburger

comment created time in 3 days

push eventvorburger/fineract

Michael Vorburger

commit sha cb3260b61f3454244afdaac3d1bcb154fb0a35e5

Minor: Return bad Image MIME type to API client

view details

Michael Vorburger

commit sha 6d225493731270a07a0b15eaa1fdeb9b8332cb14

Fix possible NPE when uploading Documents & Images (FINERACT-1036)

view details

Michael Vorburger

commit sha af1509abee27cf3b75fa8525a14e51d350a16a05

client: Skip generating generated utilities which are broken (FINERACT-1231)

view details

Michael Vorburger

commit sha ff0db483cde6fe90b4c62f925bbf89813edb05d0

client: serialize LocalDate as 2009-01-01 (FINERACT-1234)

view details

jagadeeshakn

commit sha 6992102035cd83dc912847ab0bd706e2d8c36d29

FINERACT-1165

view details

Michael Vorburger

commit sha 20daf59a3efbe717c9dd0e1fd6d3be5c153338bc

Add new DocumentTest (FINERACT-1218)

view details

Michael Vorburger

commit sha 5f4211227814fedea46448076d159f7b40e97aee

client: Fix mediaType MIME code (FINERACT-1218)

view details

percyashu

commit sha 43ef6e19839992fbc4b7d29a933c2b41bf8d64b7

FINERACT-826 Migrate to java.time from Joda API

view details

Michael Vorburger

commit sha 420d26a67964e660ee1456875ad904fbea53ee5b

Minor: CallSubject.hasHttpStatus() throws unchecked CallFailedRuntimeException

view details

Michael Vorburger

commit sha 2347e21bd2831f882b50665e117189a64267d2da

Add new ImageTest (FINERACT-1218)

view details

push time in 3 days

pull request commentapache/fineract

Minor: CallSubject.hasHttpStatus() throws unchecked CallFailedRuntimeException

@vidakovic @ptuomola would one of you be willing to merge this one? It's simple enough for an "either of you" (not both) single review & merge.

vorburger

comment created time in 3 days

push eventvorburger/fineract

Michael Vorburger

commit sha cb3260b61f3454244afdaac3d1bcb154fb0a35e5

Minor: Return bad Image MIME type to API client

view details

Michael Vorburger

commit sha 6d225493731270a07a0b15eaa1fdeb9b8332cb14

Fix possible NPE when uploading Documents & Images (FINERACT-1036)

view details

Michael Vorburger

commit sha af1509abee27cf3b75fa8525a14e51d350a16a05

client: Skip generating generated utilities which are broken (FINERACT-1231)

view details

Michael Vorburger

commit sha ff0db483cde6fe90b4c62f925bbf89813edb05d0

client: serialize LocalDate as 2009-01-01 (FINERACT-1234)

view details

jagadeeshakn

commit sha 6992102035cd83dc912847ab0bd706e2d8c36d29

FINERACT-1165

view details

Michael Vorburger

commit sha 20daf59a3efbe717c9dd0e1fd6d3be5c153338bc

Add new DocumentTest (FINERACT-1218)

view details

Michael Vorburger

commit sha 5f4211227814fedea46448076d159f7b40e97aee

client: Fix mediaType MIME code (FINERACT-1218)

view details

Michael Vorburger

commit sha 41dcfadf9a3601eeafc6bc1986d7210c56e3a667

Minor: CallSubject.hasHttpStatus() throws unchecked CallFailedRuntimeException

view details

push time in 3 days

issue commentjlarriba/jrmapi

jrmapi/src/main/java/module-info.java:[5,25] module not found: net.lingala.zip4j

@jlarriba thanks - understood. What I would probably do if I were you if I had to depend on pre-Java 11 libs was to write this project in Java 11, compile it with Java 11, use Java 11 syntax (var!) but just not put a module-info.java.. unless you want to have lots of fun with JPMS, it's "not worth" the overhead of having to maintain a fork of one of the libraries you use (including keep rebasing it - see #7). Just FYI I do that in my fork in https://github.com/jlarriba/jrmapi/compare/master...vorburger:vorburger (but that's not to say you should, just sharing a point of view).

vorburger

comment created time in 3 days

create barnchvorburger/jrmapi

branch : vorburger

created branch time in 3 days

create barnchvorburger/jrmapi

branch : bump-zip4j-javadoc-maven-plugin

created branch time in 3 days

PR opened jlarriba/jrmapi

Add Eclipse .gitignore
+3 -0

0 comment

1 changed file

pr created time in 3 days

create barnchvorburger/jrmapi

branch : gitignore

created branch time in 3 days

push eventvorburger/jrmapi

Michael Vorburger

commit sha 2554ea0b2f86194cb239742688e9c6d77f505c5f

Add Device Registration Token support

view details

push time in 3 days

PR opened jlarriba/jrmapi

Add Device Registration Token support
+156 -32

0 comment

6 changed files

pr created time in 3 days

create barnchvorburger/jrmapi

branch : DeviceRegistration

created branch time in 3 days

issue commentjlarriba/jrmapi

jrmapi/src/main/java/module-info.java:[5,25] module not found: net.lingala.zip4j

rm src/main/java/module-info.java works around this.

vorburger

comment created time in 3 days

issue openedjlarriba/jrmapi

jrmapi/src/main/java/module-info.java:[5,25] module not found: net.lingala.zip4j

$ git clone git@github.com:jlarriba/jrmapi.git && cd jrmapi

$ mvn package
[INFO] --- maven-compiler-plugin:3.8.1:compile (default-compile) @ jrmapi ---
[INFO] Changes detected - recompiling the module!
[INFO] Compiling 13 source files to /home/vorburger/dev/Remarkable/jrmapi/target/classes
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/vorburger/dev/Remarkable/jrmapi/src/main/java/module-info.java:[5,25] module not found: net.lingala.zip4j
[INFO] 1 error

[vorburger@vulcan jrmapi]$ java -version
openjdk version "11.0.8" 2020-07-14
OpenJDK Runtime Environment 18.9 (build 11.0.8+10)
OpenJDK 64-Bit Server VM 18.9 (build 11.0.8+10, mixed mode, sharing)
[vorburger@vulcan jrmapi]$ 
[vorburger@vulcan jrmapi]$ 
[vorburger@vulcan jrmapi]$ mvn -version
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /home/vorburger/bin/apache-maven-3.6.3
Java version: 11.0.8, vendor: Red Hat, Inc., runtime: /usr/lib/jvm/java-11-openjdk-11.0.8.10-2.fc32.x86_64
Default locale: en_IN, platform encoding: UTF-8
OS name: "linux", version: "5.8.14-200.fc32.x86_64", arch: "amd64", family: "unix"

created time in 3 days

startedsrikanth-lingala/zip4j

started time in 3 days

PR opened jlarriba/jrmapi

Add /LICENSE

Hello @jlarriba,

Thank You for this project!

Would you be willing to add a clear /LICENSE file to your project, to make it crystal clear to any interested party under what condition this code may be re-used? This allows facilitates contributions (if you are interested in any). I've generated this PR using https://choosealicense.com, and chosen the ASL based on seeing you having put that in the header e.g. for https://github.com//jrmapi/blob/master/src/main/java/es/jlarriba/jrmapi/Authentication.java.

Best, M.

+201 -0

0 comment

1 changed file

pr created time in 4 days

create barnchvorburger/jrmapi

branch : LICENSE

created branch time in 4 days

fork vorburger/jrmapi

A Java API for the reMarkable Cloud

fork in 4 days

startedjlarriba/jrmapi

started time in 4 days

startedreHackable/awesome-reMarkable

started time in 4 days

pull request commentapache/fineract

Fix mediaType MIME code (FINERACT-1218)

@ptuomola merge if this LGTY?

vorburger

comment created time in 4 days

push eventvorburger/fineract

Michael Vorburger

commit sha 21174a084ed84f4eecac446b483fa171920c18cc

client: Fix mediaType MIME code (FINERACT-1218)

view details

push time in 4 days

push eventvorburger/fineract

Michael Vorburger

commit sha cb3260b61f3454244afdaac3d1bcb154fb0a35e5

Minor: Return bad Image MIME type to API client

view details

Michael Vorburger

commit sha 6d225493731270a07a0b15eaa1fdeb9b8332cb14

Fix possible NPE when uploading Documents & Images (FINERACT-1036)

view details

Michael Vorburger

commit sha af1509abee27cf3b75fa8525a14e51d350a16a05

client: Skip generating generated utilities which are broken (FINERACT-1231)

view details

Michael Vorburger

commit sha ff0db483cde6fe90b4c62f925bbf89813edb05d0

client: serialize LocalDate as 2009-01-01 (FINERACT-1234)

view details

jagadeeshakn

commit sha 6992102035cd83dc912847ab0bd706e2d8c36d29

FINERACT-1165

view details

Michael Vorburger

commit sha 20daf59a3efbe717c9dd0e1fd6d3be5c153338bc

Add new DocumentTest (FINERACT-1218)

view details

Michael Vorburger

commit sha cbba30c867a153118e8a8b36c8dd137300e109ca

client: Fix mediaType MIME code (FINERACT-1218)

view details

push time in 4 days

pull request commentapache/fineract

Add new DocumentTest (FINERACT-1218)

@ptuomola build passed now!

vorburger

comment created time in 4 days

push eventvorburger/fineract

Michael Vorburger

commit sha 59dad0f70b4103a5b7006ea08be8080bdfc5baf6

Add new DocumentTest (FINERACT-1218)

view details

push time in 4 days

pull request commentapache/fineract

Add new DocumentTest (FINERACT-1218)

@ptuomola thanks for (as always very prompt, much appreciated) review! Have addressed your feedback. Want to merge this? Let's not hold this up with FINERACT-1227; if you do get to doing something about that, just wipe my DocumentsApiFixed again in a follow-up PR, but after this is merged? I would be obviously have no objection at all to see it gone - if this test still passes! :smile:

vorburger

comment created time in 4 days

Pull request review commentapache/fineract

Add new DocumentTest (FINERACT-1218)

+/**+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements. See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership. The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License. You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied. See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */+package org.apache.fineract.integrationtests.newstyle;++import java.io.File;+import java.io.IOException;+import okhttp3.MediaType;+import okhttp3.MultipartBody.Part;+import okhttp3.ResponseBody;+import org.apache.fineract.client.models.GetEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.PostEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.util.Parts;+import org.junit.jupiter.api.Order;+import org.junit.jupiter.api.Test;++/**+ * Integration Test for /documents API.+ *+ * @author Michael Vorburger.ch+ */+public class DocumentTest extends IntegrationTest {++    final File testFile = new File(getClass().getResource("/michael.vorburger-crepes.jpg").getFile());++    Long clientId = new ClientTest().getClientId();+    Long documentId;++    @Test+    @Order(1)+    void retrieveAllDocuments() throws IOException {+        assertThat(ok(fineract().documents.retreiveAllDocuments("clients", clientId))).isNotNull();+    }++    @Test+    @Order(2)+    void createDocument() throws IOException {+        String name = "Test";+        Part part = Parts.fromFile(testFile);+        String description = null;+        // TODO used var in tests when moved from fineract-client (Java 8 only) to new module+        PostEntityTypeEntityIdDocumentsResponse response = ok(+                fineract().documents.createDocument("clients", clientId, part, name, description));+        assertThat(response.getResourceId()).isNotNull();+        assertThat(response.getResourceIdentifier()).isNotEmpty();+        documentId = response.getResourceId();+    }++    @Test+    @Order(3)+    void getDocument() throws IOException {+        GetEntityTypeEntityIdDocumentsResponse doc = ok(fineract().documents.getDocument("clients", clientId, documentId));+        assertThat(doc.getName()).isEqualTo("Test");+        assertThat(doc.getFileName()).isEqualTo(testFile.getName());+        assertThat(doc.getDescription()).isNull();+        assertThat(doc.getId()).isEqualTo(documentId);+        assertThat(doc.getParentEntityType()).isEqualTo("clients");+        assertThat(doc.getParentEntityId()).isEqualTo(clientId);+        // TODO huh?! It's more than uploaded file; seems like a bug - it's including create body, not just file size+        assertThat(doc.getSize()).isEqualTo(testFile.length() + 385);+        // TODO huh?! MIME is always text/plain instead of image/jpeg... :(+        assertThat(doc.getType()).isEqualTo("text/plain");+        // TODO doc.getStorageType() shouldn't be exposed by the API?!+    }

Indeed. As well as how easy it now is to write decent tests, using the shiny new client API! PS: The MIME thing is a bug in the test util, not core - fix for that coming up as soon as this PR is merged... :smile_cat:

vorburger

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentapache/fineract

Add new DocumentTest (FINERACT-1218)

+/**+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements. See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership. The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License. You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied. See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */+package org.apache.fineract.integrationtests.newstyle;++import java.io.File;+import java.io.IOException;+import okhttp3.MediaType;+import okhttp3.MultipartBody.Part;+import okhttp3.ResponseBody;+import org.apache.fineract.client.models.GetEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.PostEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.util.Parts;+import org.junit.jupiter.api.Order;+import org.junit.jupiter.api.Test;++/**+ * Integration Test for /documents API.+ *+ * @author Michael Vorburger.ch+ */+public class DocumentTest extends IntegrationTest {++    final File testFile = new File(getClass().getResource("/michael.vorburger-crepes.jpg").getFile());++    Long clientId = new ClientTest().getClientId();+    Long documentId;++    @Test+    @Order(1)+    void retrieveAllDocuments() throws IOException {+        assertThat(ok(fineract().documents.retreiveAllDocuments("clients", clientId))).isNotNull();+    }

fixed (in 2 places)

vorburger

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentapache/fineract

Add new DocumentTest (FINERACT-1218)

+/**+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements. See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership. The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License. You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied. See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */+package org.apache.fineract.client.services;++import java.util.List;+import okhttp3.ResponseBody;+import org.apache.fineract.client.models.DeleteEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.GetEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.PostEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.PutEntityTypeEntityIdDocumentsResponse;+import retrofit2.Call;+import retrofit2.http.DELETE;+import retrofit2.http.GET;+import retrofit2.http.POST;+import retrofit2.http.PUT;++// This class was originally generated by OpenAPI Generator (https://openapi-generator.tech),+// but then had to be manually edited by Michael Vorburger.ch to manually fix https://issues.apache.org/jira/browse/FINERACT-1227.+// If we could fix our OpenAPI / Swagger YAML generation from the JAX RS and OpenAPI annotation to have the correct notation for binary document files and images, then this could be removed again.+public interface DocumentsApiFixed {

Agreed, see FINERACT-1227.

vorburger

comment created time in 4 days

PullRequestReviewEvent

Pull request review commentapache/fineract

Add new DocumentTest (FINERACT-1218)

+/**+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements. See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership. The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License. You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied. See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */+package org.apache.fineract.integrationtests.newstyle;++import java.io.File;+import java.io.IOException;+import okhttp3.MediaType;+import okhttp3.MultipartBody.Part;+import okhttp3.ResponseBody;+import org.apache.fineract.client.models.GetEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.PostEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.util.Parts;+import org.junit.jupiter.api.Order;+import org.junit.jupiter.api.Test;++/**+ * Integration Test for /documents API.+ *+ * @author Michael Vorburger.ch+ */+public class DocumentTest extends IntegrationTest {++    final File testFile = new File(getClass().getResource("/michael.vorburger-crepes.jpg").getFile());++    Long clientId = new ClientTest().getClientId();+    Long documentId;++    @Test+    @Order(1)+    void retrieveAllDocuments() throws IOException {+        assertThat(ok(fineract().documents.retreiveAllDocuments("clients", clientId))).isNotNull();+    }++    @Test+    @Order(2)+    void createDocument() throws IOException {+        String name = "Test";+        Part part = Parts.fromFile(testFile);+        String description = null;+        // TODO used var in tests when moved from fineract-client (Java 8 only) to new module+        PostEntityTypeEntityIdDocumentsResponse response = ok(+                fineract().documents.createDocument("clients", clientId, part, name, description));+        assertThat(response.getResourceId()).isNotNull();+        assertThat(response.getResourceIdentifier()).isNotEmpty();+        documentId = response.getResourceId();+    }++    @Test+    @Order(3)+    void getDocument() throws IOException {+        GetEntityTypeEntityIdDocumentsResponse doc = ok(fineract().documents.getDocument("clients", clientId, documentId));+        assertThat(doc.getName()).isEqualTo("Test");+        assertThat(doc.getFileName()).isEqualTo(testFile.getName());+        assertThat(doc.getDescription()).isNull();+        assertThat(doc.getId()).isEqualTo(documentId);+        assertThat(doc.getParentEntityType()).isEqualTo("clients");+        assertThat(doc.getParentEntityId()).isEqualTo(clientId);+        // TODO huh?! It's more than uploaded file; seems like a bug - it's including create body, not just file size+        assertThat(doc.getSize()).isEqualTo(testFile.length() + 385);+        // TODO huh?! MIME is always text/plain instead of image/jpeg... :(+        assertThat(doc.getType()).isEqualTo("text/plain");+        // TODO doc.getStorageType() shouldn't be exposed by the API?!+    }++    @Test+    @Order(4)+    void downloadFile() throws IOException {+        ResponseBody r = ok(fineract().documents.downloadFile("clients", clientId, documentId));+        assertThat(r.contentType()).isEqualTo(MediaType.get("text/plain")); // TODO wrong, bug; needs to be "image/jpeg"+                                                                            // (as above)+        assertThat(r.bytes().length).isEqualTo(testFile.length());+        // NOK: assertThat(r.contentLength()).isEqualTo(testFile.length());+    }++    @Test+    @Order(10)+    void updateDocument() throws IOException {+        String newName = "Test changed name";+        String newDescription = getClass().getName();+        ok(fineract().documents.updateDocument("clients", clientId, documentId, null, newName, newDescription));++        GetEntityTypeEntityIdDocumentsResponse doc = ok(fineract().documents.getDocument("clients", clientId, documentId));+        assertThat(doc.getName()).isEqualTo(newName);+        assertThat(doc.getDescription()).isEqualTo(newDescription);+    }++    @Test+    @Order(99)+    void deleteDocument() throws IOException {+        ok(fineract().documents.deleteDocument("clients", clientId, documentId));+    }

done, added: assertThat(fineract().documents.getDocument("clients", clientId, documentId)).hasHttpStatus(404);

vorburger

comment created time in 4 days

PullRequestReviewEvent

push eventvorburger/fineract

jagadeeshakn

commit sha 6992102035cd83dc912847ab0bd706e2d8c36d29

FINERACT-1165

view details

Michael Vorburger

commit sha 0a0bf593a2503261205a8eec2ce48f5abb7984d6

Add new DocumentTest (FINERACT-1218)

view details

push time in 4 days

push eventvorburger/vorburger-dotfiles-bin-etc

Michael Vorburger

commit sha d8d9a93344b3288b8ae0eeb681cd5e8c8d7f93c3

grd = git rebase develop

view details

push time in 4 days

Pull request review commentapache/fineract

Add new DocumentTest (FINERACT-1218)

+/**+ * Licensed to the Apache Software Foundation (ASF) under one+ * or more contributor license agreements. See the NOTICE file+ * distributed with this work for additional information+ * regarding copyright ownership. The ASF licenses this file+ * to you under the Apache License, Version 2.0 (the+ * "License"); you may not use this file except in compliance+ * with the License. You may obtain a copy of the License at+ *+ * http://www.apache.org/licenses/LICENSE-2.0+ *+ * Unless required by applicable law or agreed to in writing,+ * software distributed under the License is distributed on an+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY+ * KIND, either express or implied. See the License for the+ * specific language governing permissions and limitations+ * under the License.+ */+package org.apache.fineract.client.services;++import java.util.List;+import okhttp3.ResponseBody;+import org.apache.fineract.client.models.DeleteEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.GetEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.PostEntityTypeEntityIdDocumentsResponse;+import org.apache.fineract.client.models.PutEntityTypeEntityIdDocumentsResponse;+import retrofit2.Call;+import retrofit2.http.DELETE;+import retrofit2.http.GET;+import retrofit2.http.POST;+import retrofit2.http.PUT;++// This class was originally generated by OpenAPI Generator (https://openapi-generator.tech),+// but then had to be manually edited by Michael Vorburger.ch to manually fix https://issues.apache.org/jira/browse/FINERACT-1227.+// If we could fix our OpenAPI / Swagger YAML generation from the JAX RS and OpenAPI annotation to have the correct notation for binary document files and images, then this could be removed again.+public interface DocumentsApiFixed {

If you do, take FINERACT-1227. (I'm not entirely sure if this is completely trival; curious myself how you would fix that.)

vorburger

comment created time in 4 days

PullRequestReviewEvent

push eventapache/fineract

jagadeeshakn

commit sha 6992102035cd83dc912847ab0bd706e2d8c36d29

FINERACT-1165

view details

push time in 4 days

PR merged apache/fineract

FINERACT-1165

FINERACT-1165

resending the PR When tested the load capacity on the platform for the savings module with 40k accounts along with around 100 Transactions for each account, it takes approx 45 Sec to bring up a savings account.

further identified the solution that adding an index to a column "savings_account_transaction_id" of table "m_note" would fix the issue. This Pull request contains a flyway script to add indexing to the m_note table's savings_account_transaction_id column.

Note: I have used the Version number as V363 as the latest on develop branch was V362. Not sure how we are maintaining and picking the numbers in series, please let me know if V363 is already taken and to which number I can change.

+21 -0

9 comments

1 changed file

bharathcgowda

pr closed time in 4 days

issue commentlastnpe/eclipse-null-eea-augments

Invite @jason-faust and @J-N-K as committers

@J-N-K @jason-faust just an FYI that I've just "unwatched" this repo now, seeing that it is I great hands with you! If you still need me for anything in the future, please raise/tag me @vorburger, as I won't be actively "reading along" anymore, as I have do far. Just wanted to let you know. Thanks again for stepping up and in here. This, to me, is open source at its best. All the best to you.

vorburger

comment created time in 4 days

pull request commentapache/fineract

Add new DocumentTest (FINERACT-1218)

@ptuomola thanks for previous merges, that makes this one now ready as the next one in my "chain"... how does this one look to you?

vorburger

comment created time in 5 days

push eventvorburger/fineract

Michael Vorburger

commit sha cb3260b61f3454244afdaac3d1bcb154fb0a35e5

Minor: Return bad Image MIME type to API client

view details

Michael Vorburger

commit sha 6d225493731270a07a0b15eaa1fdeb9b8332cb14

Fix possible NPE when uploading Documents & Images (FINERACT-1036)

view details

Michael Vorburger

commit sha af1509abee27cf3b75fa8525a14e51d350a16a05

client: Skip generating generated utilities which are broken (FINERACT-1231)

view details

Michael Vorburger

commit sha ff0db483cde6fe90b4c62f925bbf89813edb05d0

client: serialize LocalDate as 2009-01-01 (FINERACT-1234)

view details

Michael Vorburger

commit sha a46821eae961ece4141f9c2b5c37bddd8cddafab

Add new DocumentTest (FINERACT-1218)

view details

push time in 5 days

delete branch apache/fineract

delete branch : vorburger-FineractClient-doc_FINERACT-1216

delete time in 5 days

pull request commentapache/fineract

FINERACT-826 Migrate to java.time from Joda API

@awasum remind me who was the Mentor ;) of @percyashu during GSOC? Perhaps that person could do the final review of mentee work, and merge this if LGTY?

percyashu

comment created time in 5 days

create barnchvorburger/fineract

branch : postman-FINERACT-1239

created branch time in 5 days

Pull request review commentapache/fineract

FINERACT-1209: Integration Tests using new Swagger Client API

  <suppressions>     <suppress files="[/\\]build[/\\]generated[/\\]" checks=".*"/>+    <!-- TODO: fix integration test formatting -->+    <suppress files="[/\\]integration-tests[/\\]src[/\\]test[/\\]main[/\\]" checks=".*"/>

I'm guessing we currently haven't covered integration-tests? We should perhaps try to fix that, first? Or leave as is?

vidakovic

comment created time in 5 days

Pull request review commentapache/fineract

FINERACT-1209: Integration Tests using new Swagger Client API

 configure(project.fineractJavaProjects) {      // Configuration for the spotless plugin     // https://github.com/diffplug/spotless/tree/main/plugin-gradle+    dependencies {+        spotbugsPlugins 'jp.skypencil.findbugs.slf4j:bug-pattern:1.5.0@jar'+        spotbugs 'com.github.spotbugs:spotbugs:4.1.4'+    }+     spotless {         java {-            targetExclude '**/build/**', '**/bin/**', '**/out/**'+            targetExclude '**/build/**', '**/bin/**', '**/out/**', '**/integration-tests/**'

why exclude integration-tests from Spotless now? Or are we already not covering them? Then we should separately fix that, first?

vidakovic

comment created time in 5 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentapache/fineract

Skip generating generated utilities which are broken (FINERACT-1231)

I thought I put these already in place? Weird...

@vidakovic so.. do you want to merge this one if this is OK for you like this? Thanks! :smiley_cat:

vorburger

comment created time in 6 days

pull request commentapache/fineract

client: serialize LocalDate as 2009-01-01 (FINERACT-1234)

@ptuomola @vidakovic so this one would be next in my... "streak" :smile: Does this LGTY? (Whenever you get to it - no stress.)

vorburger

comment created time in 6 days

pull request commentapache/fineract

client: serialize LocalDate as 2009-01-01 (FINERACT-1234)

/rebase

vorburger

comment created time in 6 days

pull request commentapache/fineract

Introduce ImageResizer to simplify ImageData (FINERACT-1201)

Draft until I double check if the changes here are covered by an integration test using #1464 (will rebase when that one is merged).

vorburger

comment created time in 6 days

PR closed apache/fineract

Clean up ImageData (FINERACT-1201)

FINERACT-1201

+15 -21

2 comments

3 changed files

vorburger

pr closed time in 6 days

pull request commentapache/fineract

Clean up ImageData (FINERACT-1201)

Maybe it's not worth to have this small initial change as a separate PR.. probably simpler to "fold" this into the overall #1425.

vorburger

comment created time in 6 days

push eventvorburger/fineract

Michael Vorburger

commit sha dd5653e2c060f07e2436da20a6846fda8c736f7a

Minor: CallSubject.hasHttpStatus() throws unchecked CallFailedRuntimeException

view details

push time in 6 days

push eventvorburger/fineract

Michael Vorburger

commit sha dd5653e2c060f07e2436da20a6846fda8c736f7a

Minor: CallSubject.hasHttpStatus() throws unchecked CallFailedRuntimeException

view details

push time in 6 days

PR opened apache/fineract

Add new ImageTest (FINERACT-1218)

see FINERACT-1218

+1061 -32

0 comment

24 changed files

pr created time in 6 days

push eventvorburger/fineract

Michael Vorburger

commit sha 09b1cc1141d0772b77a9524cfb0e627518771eb1

Add new ImageTest (FINERACT-1218)

view details

push time in 6 days

create barnchvorburger/fineract

branch : ImageUploadException

created branch time in 6 days

create barnchvorburger/fineract

branch : FINERACT-1218_ImageTest

created branch time in 6 days

create barnchvorburger/fineract

branch : FINERACT-1218_DocumentTest-CallSubject

created branch time in 6 days

PR opened apache/fineract

Fix mediaType MIME code (FINERACT-1218)

for FINERACT-1218

+837 -27

0 comment

19 changed files

pr created time in 6 days

pull request commentapache/fineract

Add new DocumentTest (FINERACT-1218)

The failing DocumentTest > createDocumentBadArgs() here requires #1456 to be merged first, and deployed to Fineract.dev.

Which of course is all wrong (that it's testing Fineract.dev instead of localhost latest code), but to fix that, we need FINERACT-1209.

Until then, we could also just merge #1456, wait 15', and then this will pass (against Fineract.dev)... :smile:

vorburger

comment created time in 6 days

push eventvorburger/fineract

Michael Vorburger

commit sha 9350822004e29cb011d51eecea968888661cadfb

Factor out ImageData.resize into ImageResizer (FINERACT-1201)

view details

push time in 6 days

push eventvorburger/fineract

Renovate Bot

commit sha aeecaf012f2909f9d82c8bd13c63e409c00d851c

Update dependency io.swagger:swagger-core to v1.6.2

view details

Michael Vorburger

commit sha 4bbc0ee3a76fd867b71d3f7fb35569d0be14b56f

add .mailmap

view details

Renovate Bot

commit sha 2e7ff4a2aa71c5a49447906a0ec43ca563ad435d

Update dependency io.swagger:swagger-annotations to v1.6.2

view details

Renovate Bot

commit sha 18f1060d05053ac73899a0d47156365eb9fbf975

Update dependency com.github.spullara.mustache.java:compiler to v0.9.7

view details

Aleksandar Vidakovic

commit sha 88765f135b88ccc000bc8e2821b5ab294206552a

FINERACT-1208: -Werror javac compilerArg lost during move to multi modules

view details

Aleksandar Vidakovic

commit sha 03ffc1d013a1b6a746cae67ecb9a307fa56e4c44

FINERACT-1214: SDK Swagger Client Java API methods returning Rx Observable are not intuitive for Java developers

view details

Michael Vorburger

commit sha 6c9f4efa9a7cc41f83926066e53767ec9f91b7b1

rm org.threeten:threetenbp dependency

view details

Michael Vorburger

commit sha d83bdc41661ce3163231cf94d7a424da044c8b84

Add missing test coverage for Image 404 (FINERACT-1201)

view details

Michael Vorburger

commit sha e054a6f0a24ccff367ea6229d03aa90a7b3e4bcc

Improve ProcessorHelper (FINERACT-1211)

view details

Michael Vorburger

commit sha 00166d4543e4547f6e2324c8e0a3a969574791e9

remove weird ImageData.available (FINERACT-1201) I don't understand what this really does, or how to test it. It seems to have been original introduced for FINERACT-288 in PR #259, but the description there doesn't clearly enough explain the problem. Much related code is about to be substantially refactored, and whatever problem this originally worked around may no longer be present when the ongoing refactoring is fully completed. If it still is, then there will likely be a better way to address it.

view details

Michael Vorburger

commit sha 19f2a38095e7b6bcdaa769b365050cd1aade2bd8

Add FineractClientTest for Fineract SDK REST Client (FINERACT-1216) and introduce handy Calls utilitiy

view details

Aleksandar Vidakovic

commit sha 6b28c0e047185ad2128c8ab475a7d4354d784666

FINERACT-1102: Swagger Codegen Client JAR should be available on a Maven repo

view details

Michael Vorburger

commit sha 55b1d4f531e48f67eefc1c27d9b59f4ffc85b277

Simplify FineractClient SDK API (FINERACT-1216)

view details

Renovate Bot

commit sha 90527bd3b0c32367c1a9684b8c703d977129f970

Update dependency net.ltgt.gradle:gradle-errorprone-plugin to v1.3.0

view details

Michael Vorburger ⛑️

commit sha bd38655f8885db6e5cd4475f9567faeeb36f5edb

Create CODE_OF_CONDUCT.md

view details

Michael Vorburger ⛑️

commit sha c8324a90b972f48262fb59ac1591687a142e5ebb

Create CONTRIBUTING.md

view details

Michael Vorburger

commit sha db4d2ae0061b585fd44cfb1eab8ef2e7985da128

Add FineractClientTest.testInvalidOperations (FINERACT-1221)

view details

Aleksandar Vidakovic

commit sha f192b7315b7b0c768c25ac79ecabf3c5bc6ccd09

FINERACT-1207: Clean up fineract-provider/config/swagger following introduction of fineract-client/

view details

Renovate Bot

commit sha 451a24e09303c5adc664fc39df018bf5fad6b065

Update dependency gradle.plugin.com.gorylenko.gradle-git-properties:gradle-git-properties to v2.2.4

view details

Renovate Bot

commit sha 9cf89d719303406b4a1be31804fbc66911be9588

Update dependency org.mockito:mockito-core to v3.5.15

view details

push time in 6 days

more