profile
viewpoint
Van Nguyen vnguyen94 Twilio San Francisco, CA

vnguyen94/module-bundling-comparison 4

compares the popular module bundlers of today (October 2016)

vnguyen94/formik-paste 2

simple declarative bindings for Formik and Twilio React Paste components

vnguyen94/Fibonacci-JS-Vs-WASM 1

Fibonacci performance benchmark between JS and WASM (April 2017)

twilio-labs/formik-paste 0

simple declarative bindings for Formik and Twilio React Paste components

vnguyen94/akka-persistence-java-example 0

This is an Event sourced microservice example implemented using Java, Dropwizard and Akka Persistence

vnguyen94/ant-design 0

🐜 A UI Design Language

vnguyen94/antplanner2 0

A better WebSOC for UCI

push eventtwilio-labs/twilio-style

Jiexi Cao

commit sha 478b564c70c1879b2a54f939d51c11cb6a660720

[eslint-config-twilio-ts] Bump @typescript-eslint/* to v4.13.0 and add override rule for 'no-use-before-define'

view details

Alice Cai

commit sha b082b3c85deb4a7ba4faf5874e619a0089629d25

Merge pull request #101 from ghostling/typescript-eslint-v4.13 [eslint-config-twilio-ts] Bump @typescript-eslint/* to v4.13.0 and add override rule for 'no-use-before-define'

view details

push time in a day

PR merged twilio-labs/twilio-style

[eslint-config-twilio-ts] Bump @typescript-eslint/* to v4.13.0 and add override rule for 'no-use-before-define'

👋 Finally got around to updating our version and saw an error similar to https://github.com/typescript-eslint/typescript-eslint/issues/2502

Solution is in the official docs: https://github.com/typescript-eslint/typescript-eslint/blob/v4.13.0/packages/eslint-plugin/docs/rules/no-use-before-define.md

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.
+112 -166

0 comment

3 changed files

ghostling

pr closed time in a day

push eventtwilio-labs/twilio-style

Alice Cai

commit sha 43268a2827948ed541c688f52629beafe9cab457

add eslint-plugin-sonarjs and eslint-plugin-no-unsanitized

view details

Alice Cai

commit sha 2c1cdc6c8798f0c765547b5b00aad010d065beb4

Merge pull request #100 from twilio-labs/sonarqube-no-unsanitized add eslint-plugin-sonarjs and eslint-plugin-no-unsanitized

view details

push time in a day

delete branch twilio-labs/twilio-style

delete branch : sonarqube-no-unsanitized

delete time in a day

PR opened twilio-labs/twilio-style

[eslint-config-twilio-ts] Bump @typescript-eslint/* to v4.13.0 and ad…

…d override rule for 'no-use-before-define'

👋 Finally got around to updating our version and saw an error similar to https://github.com/typescript-eslint/typescript-eslint/issues/2502

Solution is in the official docs: https://github.com/typescript-eslint/typescript-eslint/blob/v4.13.0/packages/eslint-plugin/docs/rules/no-use-before-define.md

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • [x] I acknowledge that all my contributions will be made under the project's license.
+112 -166

0 comment

3 changed files

pr created time in 2 days

Pull request review commenttwilio-labs/twilio-style

add eslint-plugin-sonarjs and eslint-plugin-no-unsanitized

     "eslint-plugin-import": "^2.22.1",     "eslint-plugin-jsx-a11y": "^6.4.1",     "eslint-plugin-no-only-tests": "^2.4.0",+    "eslint-plugin-no-unsanitized": "^3.1.4",     "eslint-plugin-prettier": "^3.3.0",     "eslint-plugin-react": "^7.21.5",     "eslint-plugin-react-hooks": "^4.2.0",+    "eslint-plugin-sonarjs": "^0.5.0",

👍 ahh that must be annoying :(

ahcai

comment created time in 2 days

Pull request review commenttwilio-labs/twilio-style

add eslint-plugin-sonarjs and eslint-plugin-no-unsanitized

     "eslint-plugin-import": "^2.22.1",     "eslint-plugin-jsx-a11y": "^6.4.1",     "eslint-plugin-no-only-tests": "^2.4.0",+    "eslint-plugin-no-unsanitized": "^3.1.4",     "eslint-plugin-prettier": "^3.3.0",     "eslint-plugin-react": "^7.21.5",     "eslint-plugin-react-hooks": "^4.2.0",+    "eslint-plugin-sonarjs": "^0.5.0",

It is a known lerna bug - setting up symlink for deps of deps does not work properly.

ahcai

comment created time in 2 days

Pull request review commenttwilio-labs/twilio-style

add eslint-plugin-sonarjs and eslint-plugin-no-unsanitized

     "eslint-plugin-import": "^2.22.1",     "eslint-plugin-jsx-a11y": "^6.4.1",     "eslint-plugin-no-only-tests": "^2.4.0",+    "eslint-plugin-no-unsanitized": "^3.1.4",     "eslint-plugin-prettier": "^3.3.0",     "eslint-plugin-react": "^7.21.5",     "eslint-plugin-react-hooks": "^4.2.0",+    "eslint-plugin-sonarjs": "^0.5.0",

o actually i think it's a lerna thing. i just tried removing it but lerna complained that it should be a dev-dependency

ahcai

comment created time in 3 days

Pull request review commenttwilio-labs/twilio-style

add eslint-plugin-sonarjs and eslint-plugin-no-unsanitized

     "eslint-plugin-import": "^2.22.1",     "eslint-plugin-jsx-a11y": "^6.4.1",     "eslint-plugin-no-only-tests": "^2.4.0",+    "eslint-plugin-no-unsanitized": "^3.1.4",     "eslint-plugin-prettier": "^3.3.0",     "eslint-plugin-react": "^7.21.5",     "eslint-plugin-react-hooks": "^4.2.0",+    "eslint-plugin-sonarjs": "^0.5.0",

hmm ya you're right. @ktalebian do you rmb why we have some other plugins as deps here when they're already deps of eslint-config-twilio like eslint-plugin-import and eslint-plugin-prettier?

ahcai

comment created time in 3 days

Pull request review commenttwilio-labs/twilio-style

add eslint-plugin-sonarjs and eslint-plugin-no-unsanitized

     "eslint-plugin-import": "^2.22.1",     "eslint-plugin-jsx-a11y": "^6.4.1",     "eslint-plugin-no-only-tests": "^2.4.0",+    "eslint-plugin-no-unsanitized": "^3.1.4",     "eslint-plugin-prettier": "^3.3.0",     "eslint-plugin-react": "^7.21.5",     "eslint-plugin-react-hooks": "^4.2.0",+    "eslint-plugin-sonarjs": "^0.5.0",

👀 isn't this already in eslint-config-twilio below?

ahcai

comment created time in 3 days

push eventtwilio-labs/twilio-style

Alice Cai

commit sha 43268a2827948ed541c688f52629beafe9cab457

add eslint-plugin-sonarjs and eslint-plugin-no-unsanitized

view details

push time in 3 days

create barnchtwilio-labs/twilio-style

branch : sonarqube-no-unsanitized

created branch time in 3 days

pull request commentvnguyen94/react-hook-form-paste

ci: fix formatting

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vnguyen94

comment created time in 8 days

pull request commentvnguyen94/react-hook-form-paste

Update references

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vnguyen94

comment created time in 8 days

pull request commentvnguyen94/react-hook-form-paste

rename master to main

:tada: This PR is included in version 1.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

vnguyen94

comment created time in 8 days

created tagvnguyen94/react-hook-form-paste

tagv1.0.0

created time in 8 days

push eventvnguyen94/react-hook-form-paste

semantic-release-bot

commit sha ffc3eb14de1f41db85c6d4f7792d561d77c197fb

chore(release): 1.0.0 [skip ci] # 1.0.0 (2021-01-08) ### Features * **ci:** revert to GITHUB_TOKEN ([be0e427](https://github.com/vnguyen94/react-hook-form-paste/commit/be0e42774668d50c0067a1ec24baa72ce9425a1a)) * **empty:** trigger release ([afbc446](https://github.com/vnguyen94/react-hook-form-paste/commit/afbc446fdc14c6c1ce1529243879d6a4f1c09274)) * **empty:** trigger release ([7542a84](https://github.com/vnguyen94/react-hook-form-paste/commit/7542a84429e32505c85ddc525d1ec43a9548ede6))

view details

push time in 8 days

push eventvnguyen94/react-hook-form-paste

GH Pages Bot

commit sha 728da36f8979c05c36f18c94339f18d03aefd0b4

Deploy Storybook to GitHub Pages

view details

push time in 8 days

push eventvnguyen94/react-hook-form-paste

GH Pages Bot

commit sha 3de43444f870691e102e6327f0bb365a6e41def8

Deploy Storybook to GitHub Pages

view details

push time in 8 days

push eventvnguyen94/react-hook-form-paste

GH Pages Bot

commit sha 9c3c5783d810f40297d661a06f82c6e6a04e1837

Deploy Storybook to GitHub Pages

view details

push time in 8 days

pull request commentvnguyen94/react-hook-form-paste

ci: fix formatting

Codecov Report

Merging #3 (28b059a) into main (2141dbe) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #3   +/-   ##
=======================================
  Coverage   99.06%   99.06%           
=======================================
  Files          22       22           
  Lines         107      107           
=======================================
  Hits          106      106           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 048fac9...28b059a. Read the comment docs.

vnguyen94

comment created time in 8 days

create barnchvnguyen94/react-hook-form-paste

branch : gh-pages

created branch time in 8 days

pull request commentvnguyen94/react-hook-form-paste

rename master to main

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@d61bcbd). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #2   +/-   ##
=======================================
  Coverage        ?   99.06%           
=======================================
  Files           ?       22           
  Lines           ?      107           
  Branches        ?        0           
=======================================
  Hits            ?      106           
  Misses          ?        1           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d61bcbd...3fb668e. Read the comment docs.

vnguyen94

comment created time in 8 days

pull request commentvnguyen94/react-hook-form-paste

Update references

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@6482a5e). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   99.06%           
=======================================
  Files           ?       22           
  Lines           ?      107           
  Branches        ?        0           
=======================================
  Hits            ?      106           
  Misses          ?        1           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6482a5e...d3ebcf0. Read the comment docs.

vnguyen94

comment created time in 8 days

push eventtwilio-labs/twilio-style

Kousha Talebian

commit sha 93eb156cb2a665d27497113d4a23e47ff1dc96bd

add release-it

view details

push time in a month

issue openedtwilio-labs/twilio-style

Add no-unsanitized plugin?

https://github.com/mozilla/eslint-plugin-no-unsanitized

Been looking at some security OMM stuff lately and thought this could be useful as we already have the react/no-danger rule in here. Thoughts?

created time in a month

push eventtwilio-labs/twilio-style

Kousha Talebian

commit sha 500ac3a3826123a36ac13e6d7fd7b61b672dd9f6

v1.31.0

view details

push time in a month

more