profile
viewpoint
Vlad Poluch vlapo ZWIZU Bratislava, Slovakia

vlapo/typeorm-jest 7

Just typeorm with jest integration

vlapo/angular 0

One framework. Mobile & desktop.

vlapo/class-validator 0

Validation made easy using TypeScript decorators.

vlapo/components 0

Component infrastructure and Material Design components for Angular

vlapo/DefinitelyTyped 0

The repository for high quality TypeScript type definitions.

vlapo/gitpunch 0

Watch for releases on GitHub → gitpunch.com

vlapo/ionic 0

Build amazing native and progressive web apps with open web technologies. One app running on everything 🎉

vlapo/JavaScript-Garden 0

A collection of documentation about the most quirky parts of the JavaScript language.

Pull request review commentDefinitelyTyped/DefinitelyTyped

Added type declaration for isDate function for Validator package

 declare namespace validator {      */     function isDataURI(str: string): boolean; +    /**+     * Check if the string is a valid date.+     */+    function isDate(str: string): boolean;

I think we should wait while 13.1.17 does not correspond with this isDate type definition yet. I think it will be part of next release of validatorjs.

albinmedoc

comment created time in 2 hours

PullRequestReviewEvent

startedpshihn/windtalk

started time in 6 days

startedpshihn/workly

started time in 6 days

PullRequestReviewEvent

Pull request review commentDefinitelyTyped/DefinitelyTyped

Added type declaration for isDate function for Validator package

 declare namespace validator {      */     function isDataURI(str: string): boolean; +    /**+     * Check if the string is a valid date.+     */+    function isDate(str: string): boolean;

isDate accepts also second options parameter (according to docs) but I believe this change is not released yet.

albinmedoc

comment created time in 7 days

PullRequestReviewEvent

Pull request review commentDefinitelyTyped/DefinitelyTyped

[line-navigator] Add types for line-navigator

+// Type definitions for line-navigator 2.1+// Project: https://github.com/anpur/client-line-navigator+// Definitions by: Vladimir Poluch <https://github.com/vlapo>+// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped++declare namespace LineNavigator {+    interface Options {+        /**+         * Encoding+         * @default 'utf8'+         */+        encoding?: string;+        /**+         * Size of chunk+         * @default 4096+         */+        chunkSize?: number;+        /**+         * Return error when line is longer than chunkSize, otherwise it will be threated as several lines.+         * @default false+         */+        throwOnLongLines?: boolean;+    }++    interface FindMatch {+        line: string;+        offset: number;+        length: number;+    }++    interface FindAllResult extends FindMatch {+        index: string;+    }++    type ReadLinesCallback = (err: any, index: number, lines: string[] | undefined, isEof: boolean | undefined, progress: number | undefined) => void;+    type FindCallback = (err: any, index: number | undefined, match: FindMatch | undefined) => void;+    type FindAllCallback = (err: any, index: number, limitHit: boolean | undefined, results: FindAllResult[] | undefined) => void;

Yes it is but in case err is filled argumentslimitHit and results are undefined (according to code).

vlapo

comment created time in 8 days

PullRequestReviewEvent

Pull request review commentDefinitelyTyped/DefinitelyTyped

[line-navigator] Add types for line-navigator

+// Type definitions for line-navigator 2.1+// Project: https://github.com/anpur/client-line-navigator+// Definitions by: Vladimir Poluch <https://github.com/vlapo>+// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped++declare namespace LineNavigator {+    interface Options {+        /**+         * Encoding+         * @default 'utf8'+         */+        encoding?: string;+        /**+         * Size of chunk+         * @default 4096+         */+        chunkSize?: number;+        /**+         * Return error when line is longer than chunkSize, otherwise it will be threated as several lines.+         * @default false+         */+        throwOnLongLines?: boolean;+    }++    interface FindMatch {+        line: string;+        offset: number;+        length: number;+    }++    interface FindAllResult extends FindMatch {+        index: string;+    }++    type ReadLinesCallback = (err: any, index: number, lines: string[] | undefined, isEof: boolean | undefined, progress: number | undefined) => void;+    type FindCallback = (err: any, index: number | undefined, match: FindMatch | undefined) => void;

Yes it is but in case err is filled argumentsindex and match are undefined (according to code).

vlapo

comment created time in 8 days

PullRequestReviewEvent

Pull request review commentDefinitelyTyped/DefinitelyTyped

[line-navigator] Add types for line-navigator

+// Type definitions for line-navigator 2.1+// Project: https://github.com/anpur/client-line-navigator+// Definitions by: Vladimir Poluch <https://github.com/vlapo>+// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped++declare namespace LineNavigator {+    interface Options {+        /**+         * Encoding+         * @default 'utf8'+         */+        encoding?: string;+        /**+         * Size of chunk+         * @default 4096+         */+        chunkSize?: number;+        /**+         * Return error when line is longer than chunkSize, otherwise it will be threated as several lines.+         * @default false+         */+        throwOnLongLines?: boolean;+    }++    interface FindMatch {+        line: string;+        offset: number;+        length: number;+    }++    interface FindAllResult extends FindMatch {+        index: string;+    }++    type ReadLinesCallback = (err: any, index: number, lines: string[] | undefined, isEof: boolean | undefined, progress: number | undefined) => void;

Yes it is but in case err is filled arguments lines, isEof and progress are undefined (according to code).

vlapo

comment created time in 8 days

PullRequestReviewEvent

PR opened DefinitelyTyped/DefinitelyTyped

[line-navigator] Add types for line-navigator

Please fill in this template.

  • [x] Use a meaningful title for the pull request. Include the name of the package modified.
  • [x] Test the change in your own code. (Compile and run.)
  • [x] Add or edit tests to reflect the change. (Run with npm test YOUR_PACKAGE_NAME.)
  • [x] Follow the advice from the readme.
  • [x] Avoid common mistakes.
  • [x] Run npm run lint package-name (or tsc if no tslint.json is present).

Select one of these and delete the others:

If adding a new definition:

  • [x] The package does not already provide its own types, or cannot have its .d.ts files generated via --declaration
  • [x] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.
  • [x] Create it with dts-gen --dt, not by basing it on an existing project.
  • [x] Represents shape of module/library correctly
  • [x] tslint.json should be present and it shouldn't have any additional or disabling of rules. Just content as { "extends": "dtslint/dt.json" }. If for reason the some rule need to be disabled, disable it for that line using // tslint:disable-next-line [ruleName] and not for whole package so that the need for disabling can be reviewed.
  • [x] tsconfig.json should have noImplicitAny, noImplicitThis, strictNullChecks, and strictFunctionTypes set to true.
+100 -0

0 comment

4 changed files

pr created time in 8 days

create barnchvlapo/DefinitelyTyped

branch : line-navigator-init

created branch time in 8 days

push eventvlapo/DefinitelyTyped

Ted Conn

commit sha a9e7a0200b6e0bfe5b11222a7de57f7d49036175

t(kagekiri): new definitions for kagekiri (#47549) * t(kagekiri): new definitions for kagekiri * Update types/kagekiri/index.d.ts Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com> Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com>

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha f03fd4b23110cbacb79c6e14c57d51262222b45e

feat(vegas): new definition (#47552) Definition file for Vegas jQuery plugin: - definition file - tests https://github.com/jaysalvat/vegas http://vegas.jaysalvat.com/documentation/setup/ Thanks!

view details

Linn Dahlgren

commit sha 35d8a9f149de4fdb321120ae101d4608e12f3672

New definitions for nat-upnp (#47551) * Add nat-upnp typings * Fixed index.d.ts header * Removed accidental docstring meant to be source comment * Apply suggestions from code review Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com> * Add test cases for nat-upnp optional callbacks missing * Fix linter errors Co-authored-by: Piotr Błażejewicz (Peter Blazejewicz) <peterblazejewicz@users.noreply.github.com>

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 8f51ec40ba30f3ae44d4d899f2c805a7abaa04ee

feat(image-to-base64): new definition (#47581) Small util to convert url/path based images to bas64 strings - definition - tests https://github.com/renanbastos93/image-to-base64 Thanks!

view details

Lukas Planz

commit sha 89c78c18e456e62317e0a326a48b6cae211b42de

[nodes7] Add type definitions (#47564) * Added type definitions for nodes7 * Fix error

view details

czgu

commit sha ba87a83b35b6f4b9e28e82ae8b1dd652bdbea385

[gestalt-datepicker] Add type definitions (#47570) * [gestalt-datepicker] Add type definitions * Change export to default to match * update project url

view details

Anton Ratnikov

commit sha 8eb86bfad44ce65114023548c25563e0ee54d23e

fix: add static methods for Airtable (#46723)

view details

Gavin Rehkemper

commit sha 337878ad524b4208f4394f37aa63749e9a532501

🤖 Merge PR #47555 add types for @terraformer/arcgis by @gavinr * add @terraformer/arcgis types * fix tslint * Update types/terraformer__arcgis/index.d.ts Co-authored-by: Linn Dahlgren <admin@opposite.biz> * Update index.d.ts Co-authored-by: Linn Dahlgren <admin@opposite.biz>

view details

Rick Kirkham

commit sha a65f7cba4823a1c4bf30f56c55e3dde51be33237

office-js, office-js-preview, fix link (#47587)

view details

Seržants

commit sha 7aadebe6bf410f589adec161e05f847568e574ae

🤖 Merge PR #47566 Added preventsDisplaySleepDuringVideoPlayback to react-native-video p… by @Serzhs * Added preventsDisplaySleepDuringVideoPlayback to react-native-video props * Added preventsDisplaySleepDuringVideoPlayback to react-native-video test

view details

Piotr Błażejewicz (Peter Blazejewicz)

commit sha 71edd1752d07111dff93a2c81deb2a4c41dccb0e

🤖 Merge PR #47518 update(terser-webpack-plugin): `minimizerOptions` option by @peterblazejewicz - `minimizerOptions` added - test amended - cleanup https://github.com/webpack-contrib/terser-webpack-plugin/pull/311 Thanks!

view details

Jeff King

commit sha 4413f5e64588bb5937d1f40dd7957de84a3fcc75

Upgrade sarif to 2.1.0-rtm.5 (#47593)

view details

Jack Bates

commit sha e30322120f46a0735f049e9687742acb420efe6f

[es6-promisify] Remove superfluous /// <reference types="node" /> (#46738)

view details

Alex Jerabek

commit sha 20cc822b0cad5f8c2c89c4c98b592a746e2ccec9

[office-js, office-js-preview] ExcelAPI 1.12 Updates (#47572) * Excel release * Excel release * Excel preview * Feedback

view details

Oliver Salzburg

commit sha 404f9ce1f90633489715c8fd5708ac5df2ce6ca5

Fix integration with koa-passport (#46718)

view details

Nathan Shively-Sanders

commit sha 38c8574c828cc2ee807e6610426dd12835a9015c

Add ts3.6 references to node v10 (#47601) * Add ts3.6 references to node v10 This may need to be added to other node versions as well. Fixes #47239 * add test case

view details

sejoong_de_jang

commit sha d9cb54e3c93d8a73c1af616a9737e2cb0ba9c6c4

Add the 'tizen-tv-webapis' module (#45812) * Add the tizen-tv-webapis * Remove the comment in package.json * Add the files * Resolve the file names * Refine indendation with the prettier * Set tslint exception rule in each files * Convert the @deprecated tag to @note * Resolve the 'no-redundant-jsdoc-2' * Modify the package name and version * Modify the version * Remove the orinazation * Modify the npm package name * Register the npm-name: false rule * Remove the tab * Remove the useless package * Move files to the project root * Remove delcare in each files, replace to export * Change the npm path * Remove the 'npm-naming' rule

view details

Jack Bates

commit sha ef49ffb4c80e2b4dc1eb84d6faba47478cd6f3b1

[node] Put newest versions of files in the root (#47576)

view details

Google API Typings Generator

commit sha 4e302d63e9bcb3f041cc05c8f228a66731dc2d0e

🤖 Merge PR #47604 [gapi.client.classroom] automatic update by @google-api-typings-generator Co-authored-by: Maxim Mazurok <maxim@mazurok.com>

view details

Nathan Shively-Sanders

commit sha 3a947ccb1bbbab9dc909130db46ace0e876266b7

Restore deleted jsdom tests (#47600) * Restore deleted jsdom tests Deleted by mistake in the move in #47200 * use approved directory structure

view details

push time in 8 days

issue commentvalor-software/ng2-charts

Error: Can't resolve '@valor-software/ng2-charts'

Not it works. Thank you! 🙏

sabbir-hossain

comment created time in a month

issue commentvalor-software/ng2-charts

Error: Can't resolve '@valor-software/ng2-charts'

Sure it works. Your workaround is just redirecting compiler from @valor-software/ng2-charts path to node_modules/ng2-charts. But why should I use workaround when this is clearly problem in ng2-charts@2.4.1 package.

@valor-software/ng2-charts ng2-charts@noreply.github.com was mistakenly

As you said @valor-software/ng2-charts was mistake so why do we see the signs of @valor-software/ng2-charts in ng2-charts@2.4.1 package?

sabbir-hossain

comment created time in a month

issue commentvalor-software/ng2-charts

Error: Can't resolve '@valor-software/ng2-charts'

I dont think so. Fast test:

  1. Install @angular/cli@8
  2. Create new empty project
  3. install ng2-charts
  4. Import ChartsModule
  5. Run build ng build --prod

Build failed with Module not found: Error: Can't resolve '@valor-software/ng2-charts'

  1. Remove all @valor-software/ strings from all files in ./node_modules/ng2-charts/* - so we will have ng2-charts instead of @valor-software/ng2-charts. I have to change files:
    node_modules/ng2-charts/valor-software-ng2-charts.metadata.json
    node_modules/ng2-charts/bundles/valor-software-ng2-charts.umd.min.js
    node_modules/ng2-charts/bundles/valor-software-ng2-charts.umd.js
    
  2. Run build again ng build --prod

Build passed.

sabbir-hossain

comment created time in a month

issue commentvalor-software/ng2-charts

Error: Can't resolve '@valor-software/ng2-charts'

Hi @paviad thank you for your code snippet but I think your solution is only workaround. I found "@valor-software" string in v2.4.1 bundles and metadata.json. It looks like package was build with incorrect package name. You should rebuild package, increment version and unpublish corrupted version 2.4.1

grep "@valor-software" -R .

./node_modules/ng2-charts/valor-software-ng2-charts.metadata.json:{"__symbolic":"module","version":4,"metadata":{"ChartsModule":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"NgModule","line":3,"character":1},"arguments":[{"declarations":[{"__symbolic":"reference","name":"BaseChartDirective"}],"imports":[],"exports":[{"__symbolic":"reference","name":"BaseChartDirective"}]}]}],"members":{}},"SingleDataSet":{"__symbolic":"interface"},"MultiDataSet":{"__symbolic":"interface"},"SingleOrMultiDataSet":{"__symbolic":"interface"},"PluginServiceGlobalRegistrationAndOptions":{"__symbolic":"interface"},"SingleLineLabel":{"__symbolic":"interface"},"MultiLineLabel":{"__symbolic":"interface"},"Label":{"__symbolic":"interface"},"BaseChartDirective":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Directive","line":63,"character":1},"arguments":[{"selector":"canvas[baseChart]","exportAs":"base-chart"}]}],"members":{"data":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":69,"character":3}}]}],"datasets":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":70,"character":3}}]}],"labels":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":71,"character":3}}]}],"options":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":72,"character":3}}]}],"chartType":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":73,"character":3}}]}],"colors":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":74,"character":3}}]}],"legend":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":75,"character":3}}]}],"plugins":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Input","line":76,"character":3}}]}],"chartClick":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Output","line":78,"character":3}}]}],"chartHover":[{"__symbolic":"property","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Output","line":79,"character":3}}]}],"__ctor__":[{"__symbolic":"constructor","parameters":[{"__symbolic":"reference","module":"@angular/core","name":"ElementRef","line":113,"character":21},{"__symbolic":"reference","name":"ThemeService"}]}],"ngOnInit":[{"__symbolic":"method"}],"themeChanged":[{"__symbolic":"method"}],"ngDoCheck":[{"__symbolic":"method"}],"copyLabel":[{"__symbolic":"method"}],"labelsEqual":[{"__symbolic":"method"}],"copyColor":[{"__symbolic":"method"}],"colorsEqual":[{"__symbolic":"method"}],"updateColors":[{"__symbolic":"method"}],"ngOnChanges":[{"__symbolic":"method"}],"ngOnDestroy":[{"__symbolic":"method"}],"update":[{"__symbolic":"method"}],"hideDataset":[{"__symbolic":"method"}],"isDatasetHidden":[{"__symbolic":"method"}],"toBase64Image":[{"__symbolic":"method"}],"getChartConfiguration":[{"__symbolic":"method"}],"getChartBuilder":[{"__symbolic":"method"}],"smartMerge":[{"__symbolic":"method"}],"isMultiLineLabel":[{"__symbolic":"method"}],"joinLabel":[{"__symbolic":"method"}],"propagateDatasetsToData":[{"__symbolic":"method"}],"propagateDataToDatasets":[{"__symbolic":"method"}],"isMultiDataSet":[{"__symbolic":"method"}],"getDatasets":[{"__symbolic":"method"}],"refresh":[{"__symbolic":"method"}]}},"Color":{"__symbolic":"interface"},"Colors":{"__symbolic":"interface"},"defaultColors":[[255,99,132],[54,162,235],[255,206,86],[231,233,237],[75,192,192],[151,187,205],[220,220,220],[247,70,74],[70,191,189],[253,180,92],[148,159,177],[77,83,96]],"ThemeService":{"__symbolic":"class","decorators":[{"__symbolic":"call","expression":{"__symbolic":"reference","module":"@angular/core","name":"Injectable","line":4,"character":1},"arguments":[{"providedIn":"root"}]}],"members":{"__ctor__":[{"__symbolic":"constructor"}],"setColorschemesOptions":[{"__symbolic":"method"}],"getColorschemesOptions":[{"__symbolic":"method"}]},"statics":{"ɵprov":{}}},"monkeyPatchChartJsLegend":{"__symbolic":"function"},"monkeyPatchChartJsTooltip":{"__symbolic":"function"}},"origins":{"ChartsModule":"./lib/charts.module","SingleDataSet":"./lib/base-chart.directive","MultiDataSet":"./lib/base-chart.directive","SingleOrMultiDataSet":"./lib/base-chart.directive","PluginServiceGlobalRegistrationAndOptions":"./lib/base-chart.directive","SingleLineLabel":"./lib/base-chart.directive","MultiLineLabel":"./lib/base-chart.directive","Label":"./lib/base-chart.directive","BaseChartDirective":"./lib/base-chart.directive","Color":"./lib/color","Colors":"./lib/colors","defaultColors":"./lib/default-colors","ThemeService":"./lib/theme.service","monkeyPatchChartJsLegend":"./lib/monkey-patch-chart-js-legend","monkeyPatchChartJsTooltip":"./lib/monkey-patch-chart-js-tooltip"},"importAs":"@valor-software/ng2-charts"}
./node_modules/ng2-charts/bundles/valor-software-ng2-charts.umd.js:    typeof define === 'function' && define.amd ? define('@valor-software/ng2-charts', ['exports', '@angular/core', 'rxjs', 'lodash-es', 'chart.js'], factory) :
./node_modules/ng2-charts/bundles/valor-software-ng2-charts.umd.min.js:!function(t,e){"object"==typeof exports&&"undefined"!=typeof module?e(exports,require("@angular/core"),require("rxjs"),require("lodash-es"),require("chart.js")):"function"==typeof define&&define.amd?define("@valor-software/ng2-charts",["exports","@angular/core","rxjs","lodash-es","chart.js"],e):e(((t="undefined"!=typeof globalThis?globalThis:t||self)["valor-software"]=t["valor-software"]||{},t["valor-software"]["ng2-charts"]={}),t.ng.core,t.rxjs,t._,t.chart_js)}(this,(function(t,e,r,o,a){"use strict";
sabbir-hossain

comment created time in a month

startedelsewhencode/project-guidelines

started time in 2 months

startedsindresorhus/awesome

started time in 2 months

startedEbookFoundation/free-programming-books

started time in 2 months

push eventtypestack/class-validator

snyk-bot

commit sha 395fc3cb37e7ff3b21131caad0204d1e0de0b3dd

fix: upgrade @types/validator from 13.0.0 to 13.1.0 Snyk has created this PR to upgrade @types/validator from 13.0.0 to 13.1.0. See this package in npm: https://www.npmjs.com/package/@types/validator See this project in Snyk: https://app.snyk.io/org/vlapo/project/c11cece6-b879-4797-a433-bba4a18ca67d?utm_source=github&utm_medium=upgrade-pr

view details

push time in 3 months

push eventtypestack/class-validator

snyk-bot

commit sha 93104abeb4d6eb11407d75f393843018c92361ae

fix: upgrade validator from 13.0.0 to 13.1.1 Snyk has created this PR to upgrade validator from 13.0.0 to 13.1.1. See this package in npm: https://www.npmjs.com/package/validator See this project in Snyk: https://app.snyk.io/org/vlapo/project/c11cece6-b879-4797-a433-bba4a18ca67d?utm_source=github&utm_medium=upgrade-pr

view details

push time in 3 months

more