profile
viewpoint
Vojtěch Juránek vjuranek Red Hat

jenkinsci/ec2-plugin 258

Jenkins ec2 plugin

oVirt/vdsm 97

This is a mirror for http://gerrit.ovirt.org, for issues use http://bugzilla.redhat.com

oVirt/ovirt-ansible-collection 39

Ansible collection with official oVirt modules and roles

jenkinsci/groovy-plugin 33

Jenkins groovy plugin

jenkinsci/selenium-tests 25

deprecated Selenium tests

jenkinsci/disk-usage-plugin 22

Jenkins disk-usage plugin

PullRequestReviewEvent
PullRequestReviewEvent

push eventvjuranek/notes

Vojtěch Juránek

commit sha f822e4292d5f269cd314b01c55f0bd6486a75b26

iSER setup (not fully workong for me yet)

view details

push time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentdebezium/debezium

postgres: allow numeric slot name

 private PGReplicationStream startPgReplicationStream(final Lsn lsn, Function<Cha                 .getReplicationAPI()                 .replicationStream()                 .logical()-                .withSlotName(slotName)+                .withSlotName("\"" + slotName + "\"")

Thanks for the validation steps!

AFAICT everything works:

  • started compose with 1.7 and "slot.name": "dbz_1042"
  • provided 1.8 snapshort with this change via mount dir
  • restarted connect service
  • CDC works after restart, relevant log part after restart:
connect_1    | 2021-11-17 21:21:57,764 INFO   Postgres|dbserver1|streaming  Obtained valid replication slot ReplicationSlot [active=false, latestFlushedLsn=LSN{0/2081100}, catalogXmin=601]   [io.debezium.connector.postgresql.connection.PostgresConnection]
connect_1    | 2021-11-17 21:21:57,767 INFO   Postgres|dbserver1|streaming  Connection gracefully closed   [io.debezium.jdbc.JdbcConnection]
postgres_1   | 2021-11-17 21:21:57.777 GMT [151] LOG:  starting logical decoding for slot "dbz_1042"
postgres_1   | 2021-11-17 21:21:57.777 GMT [151] DETAIL:  Streaming transactions committing after 0/2081100, reading WAL from 0/20810C8.
postgres_1   | 2021-11-17 21:21:57.777 GMT [151] STATEMENT:  START_REPLICATION SLOT dbz_1042 LOGICAL 0/2081100
postgres_1   | 2021-11-17 21:21:57.777 GMT [151] LOG:  logical decoding found consistent point at 0/20810C8
postgres_1   | 2021-11-17 21:21:57.777 GMT [151] DETAIL:  There are no running transactions.
postgres_1   | 2021-11-17 21:21:57.777 GMT [151] STATEMENT:  START_REPLICATION SLOT dbz_1042 LOGICAL 0/2081100
connect_1    | 2021-11-17 21:21:57,805 INFO   Postgres|dbserver1|streaming  Requested thread factory for connector PostgresConnector, id = dbserver1 named = keep-alive   [io.debezium.util.Threads]
connect_1    | 2021-11-17 21:21:57,806 INFO   Postgres|dbserver1|streaming  Creating thread debezium-postgresconnector-dbserver1-keep-alive   [io.debezium.util.Threads]

After compose stop/start, still with 1.8 snapshot and numeric slot name "slot.name": "1042", it starts and CDC works, log:

connect_1    | 2021-11-17 21:37:53,786 INFO   Postgres|dbserver1|streaming  Obtained valid replication slot ReplicationSlot [active=false, latestFlushedLsn=LSN{0/2078D38}, catalogXmin=601]   [io.debezium.connector.postgresql.connection.PostgresConnection]
connect_1    | 2021-11-17 21:37:53,787 INFO   Postgres|dbserver1|streaming  Connection gracefully closed   [io.debezium.jdbc.JdbcConnection]
kafka_1      | 2021-11-17 21:37:53,790 - INFO  [data-plane-kafka-request-handler-2:Logging@66] - [Partition dbserver1.inventory.geom-0 broker=1] No checkpointed highwatermark is found for partition dbserver1.inventory.geom-0
kafka_1      | 2021-11-17 21:37:53,790 - INFO  [data-plane-kafka-request-handler-2:Logging@66] - [Partition dbserver1.inventory.geom-0 broker=1] Log loaded for partition dbserver1.inventory.geom-0 with initial high watermark 0
postgres_1   | 2021-11-17 21:37:53.791 GMT [89] LOG:  starting logical decoding for slot "1042"
postgres_1   | 2021-11-17 21:37:53.791 GMT [89] DETAIL:  Streaming transactions committing after 0/2078D38, reading WAL from 0/2078D00.
postgres_1   | 2021-11-17 21:37:53.791 GMT [89] STATEMENT:  START_REPLICATION SLOT "1042" LOGICAL 0/2078D38
postgres_1   | 2021-11-17 21:37:53.791 GMT [89] LOG:  logical decoding found consistent point at 0/2078D00
postgres_1   | 2021-11-17 21:37:53.791 GMT [89] DETAIL:  There are no running transactions.
postgres_1   | 2021-11-17 21:37:53.791 GMT [89] STATEMENT:  START_REPLICATION SLOT "1042" LOGICAL 0/2078D38
connect_1    | 2021-11-17 21:37:53,804 INFO   Postgres|dbserver1|streaming  Requested thread factory for connector PostgresConnector, id = dbserver1 named = keep-alive   [io.debezium.util.Threads]
connect_1    | 2021-11-17 21:37:53,804 INFO   Postgres|dbserver1|streaming  Creating thread debezium-postgresconnector-dbserver1-keep-alive   [io.debezium.util.Threads]

For completeness (reproducing original issue), another compose stop/star with "slot.name": "1042" and 1.7, it fails with syntax error:

connect_1    | 2021-11-17 21:49:36,227 INFO   Postgres|dbserver1|postgres-connector-task  No previous offset found   [io.debezium.connector.postgresql.PostgresConnectorTask]
connect_1    | 2021-11-17 21:49:36,227 INFO   Postgres|dbserver1|postgres-connector-task  Taking initial snapshot for new datasource   [io.debezium.connector.postgresql.snapshot.InitialSnapshotter]
connect_1    | 2021-11-17 21:49:36,236 INFO   Postgres|dbserver1|postgres-connector-task  Creating replication slot with command CREATE_REPLICATION_SLOT 1042  LOGICAL decoderbufs   [io.debezium.connector.postgresql.connection.PostgresReplicationConnection]
postgres_1   | 2021-11-17 21:49:36.236 GMT [88] ERROR:  syntax error
connect_1    | 2021-11-17 21:49:36,238 ERROR  ||  WorkerSourceTask{id=inventory-connector-0} Task threw an uncaught and unrecoverable exception. Task is being killed and will not recover until manually restarted   [org.apache.kafka.connect.runtime.WorkerTask]
connect_1    | io.debezium.DebeziumException: Creation of replication slot failed
connect_1    |  at io.debezium.connector.postgresql.PostgresConnectorTask.start(PostgresConnectorTask.java:144)
connect_1    |  at io.debezium.connector.common.BaseSourceTask.start(BaseSourceTask.java:133)
connect_1    |  at org.apache.kafka.connect.runtime.WorkerSourceTask.initializeAndStart(WorkerSourceTask.java:231)
connect_1    |  at org.apache.kafka.connect.runtime.WorkerTask.doRun(WorkerTask.java:186)
connect_1    |  at org.apache.kafka.connect.runtime.WorkerTask.run(WorkerTask.java:237)
connect_1    |  at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
connect_1    |  at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
connect_1    |  at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
connect_1    |  at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
connect_1    |  at java.base/java.lang.Thread.run(Thread.java:829)
connect_1    | Caused by: org.postgresql.util.PSQLException: ERROR: syntax error
connect_1    |  at org.postgresql.core.v3.QueryExecutorImpl.receiveErrorResponse(QueryExecutorImpl.java:2552)
connect_1    |  at org.postgresql.core.v3.QueryExecutorImpl.processResults(QueryExecutorImpl.java:2284)
connect_1    |  at org.postgresql.core.v3.QueryExecutorImpl.execute(QueryExecutorImpl.java:322)
connect_1    |  at org.postgresql.jdbc.PgStatement.executeInternal(PgStatement.java:481)
connect_1    |  at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:401)
connect_1    |  at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:322)
connect_1    |  at org.postgresql.jdbc.PgStatement.executeCachedSql(PgStatement.java:308)
connect_1    |  at org.postgresql.jdbc.PgStatement.executeWithFlags(PgStatement.java:284)
connect_1    |  at org.postgresql.jdbc.PgStatement.execute(PgStatement.java:279)
connect_1    |  at io.debezium.connector.postgresql.connection.PostgresReplicationConnection.createReplicationSlot(PostgresReplicationConnection.java:363)
connect_1    |  at io.debezium.connector.postgresql.PostgresConnectorTask.start(PostgresConnectorTask.java:137)
connect_1    |  ... 9 more
vjuranek

comment created time in 15 days

PullRequestReviewEvent

pull request commentdebezium/debezium

postgres: Reflect decimal.handling.mode in money conversion and allow to specify scale

Added documentation updates.

vjuranek

comment created time in 16 days

push eventvjuranek/debezium

Chris Cranford

commit sha 20627bd14aa7649890170981942dcfdfe12d7c56

DBZ-4082 Fix test failure SchemaHistoryTopicIT::schemaChangeAfterSnapshot

view details

Jiri Pechanec

commit sha 309ae26c7d66bf525a62010e3b705b7a3d6ef176

DBZ-4286 Upgrade MySQL driver to 8.0.27

view details

Vojtech Juranek

commit sha 15ccdbed7024d061a242cb7bdd6725c1cc84933f

DBZ-1344 Don't warn about empty schema when using snapshot mode 'never'

view details

Gunnar Morling

commit sha 62cb992b4f4b463f5f82555495ca94ce77fb91a6

DBZ-4289 Avoiding superfluous component builds

view details

Chris Cranford

commit sha 3569cb46024683ae0287a1d48b12e90318b7f79e

DBZ-4291 Reducing log verbosity * Reduce Incremental Snapshot Test verbosity * Reduce excessive SnapshotReader logging

view details

Kate

commit sha 44073cf7d89c17922476fffa226ec4497f493ad2

DBZ-4196 Support schema changes during incremental snapshot

view details

Anisha Mohanty

commit sha 9bfcf021d75d2d8be13eeb31fcde3edd5b6e54b5

DBZ-4280 Allow Alter Table to Rebuild an Index Partition

view details

Chris Cranford

commit sha 0fbfd88f6cc73f511191101271a1b956f506d58d

DBZ-4276 Add `unavailable.value.placeholder` support for Oracle

view details

Chris Cranford

commit sha ca173522219e1ab5ba6cec9645e18d54f3fd7ed0

DBZ-4276 Unify unavailable value placeholder handling Deprecate the `toasted.value.placeholder` option in PostgreSQL in favor of the new `unavailable.value.placeholder` option that is shared by all relational connectors.

view details

Chris Cranford

commit sha d1453eb954e01fe91c4ce60e8ade22c2fe5b7996

DBZ-4276 Improve map initialization

view details

Chris Cranford

commit sha e3da449303763446acc0c519bb6db4970d72405c

DBZ-4276 Expose unavailable value placeholder for PG and Oracle only

view details

Chris Cranford

commit sha ba525abe97c7ee5631590e63de49d8ab44ab4003

DBZ-4276 Use xref rather than link-prefix

view details

Chris Cranford

commit sha 1745203866a229df35418abfb7871f74499a6a6c

DBZ-4276 Clarify unavailable placeholder docs

view details

Sergei Morozov

commit sha 0e04204443f5d2bb964fede4ac434952422c3d48

DBZ-4285: Handle login failure during instance upgrade as retriable

view details

Chris Cranford

commit sha 593359e3f8581401258dc16df1af6b9583c29f37

DBZ-4224 Fix parsing of creation of queue tables

view details

Vojtech Juranek

commit sha 8b73c347bb95dd36b65656e0d5bb6fbb638fb5f7

DBZ-1931 Reflect decimal.handling.mode in money conversion

view details

Vojtech Juranek

commit sha ae752ce9502e61fa1c41b5c2ca37751520814710

DBZ-1931 Allow to specify number of fraction digits for the money type

view details

Vojtech Juranek

commit sha f2e551065a214bea4c57f22dbe07d7422a4ee201

DBZ-1931 Document mapping and config option

view details

push time in 16 days

push eventvjuranek/debezium

camilesing

commit sha dfabe8cda849abadc66257c342679cd73eb54beb

DBZ-4275 fix AbstractDatabaseHistory typo

view details

Chris Cranford

commit sha 7720c653e52dd437ebdb2bf19149dbb456cdfe1a

DBZ-4279 For test compatibility with Xstream

view details

Vojtech Juranek

commit sha 9ca7629f1b0ff306600fb9b9c661d74fcc087a1f

DBZ-3570 return non-zero exit code from Debezium server upon failure

view details

Chris Cranford

commit sha 20627bd14aa7649890170981942dcfdfe12d7c56

DBZ-4082 Fix test failure SchemaHistoryTopicIT::schemaChangeAfterSnapshot

view details

Jiri Pechanec

commit sha 309ae26c7d66bf525a62010e3b705b7a3d6ef176

DBZ-4286 Upgrade MySQL driver to 8.0.27

view details

Vojtech Juranek

commit sha 15ccdbed7024d061a242cb7bdd6725c1cc84933f

DBZ-1344 Don't warn about empty schema when using snapshot mode 'never'

view details

Gunnar Morling

commit sha 62cb992b4f4b463f5f82555495ca94ce77fb91a6

DBZ-4289 Avoiding superfluous component builds

view details

Chris Cranford

commit sha 3569cb46024683ae0287a1d48b12e90318b7f79e

DBZ-4291 Reducing log verbosity * Reduce Incremental Snapshot Test verbosity * Reduce excessive SnapshotReader logging

view details

Kate

commit sha 44073cf7d89c17922476fffa226ec4497f493ad2

DBZ-4196 Support schema changes during incremental snapshot

view details

Anisha Mohanty

commit sha 9bfcf021d75d2d8be13eeb31fcde3edd5b6e54b5

DBZ-4280 Allow Alter Table to Rebuild an Index Partition

view details

Chris Cranford

commit sha 0fbfd88f6cc73f511191101271a1b956f506d58d

DBZ-4276 Add `unavailable.value.placeholder` support for Oracle

view details

Chris Cranford

commit sha ca173522219e1ab5ba6cec9645e18d54f3fd7ed0

DBZ-4276 Unify unavailable value placeholder handling Deprecate the `toasted.value.placeholder` option in PostgreSQL in favor of the new `unavailable.value.placeholder` option that is shared by all relational connectors.

view details

Chris Cranford

commit sha d1453eb954e01fe91c4ce60e8ade22c2fe5b7996

DBZ-4276 Improve map initialization

view details

Chris Cranford

commit sha e3da449303763446acc0c519bb6db4970d72405c

DBZ-4276 Expose unavailable value placeholder for PG and Oracle only

view details

Chris Cranford

commit sha ba525abe97c7ee5631590e63de49d8ab44ab4003

DBZ-4276 Use xref rather than link-prefix

view details

Chris Cranford

commit sha 1745203866a229df35418abfb7871f74499a6a6c

DBZ-4276 Clarify unavailable placeholder docs

view details

Sergei Morozov

commit sha 0e04204443f5d2bb964fede4ac434952422c3d48

DBZ-4285: Handle login failure during instance upgrade as retriable

view details

Chris Cranford

commit sha 593359e3f8581401258dc16df1af6b9583c29f37

DBZ-4224 Fix parsing of creation of queue tables

view details

push time in 16 days

push eventvjuranek/debezium

camilesing

commit sha dfabe8cda849abadc66257c342679cd73eb54beb

DBZ-4275 fix AbstractDatabaseHistory typo

view details

Chris Cranford

commit sha 7720c653e52dd437ebdb2bf19149dbb456cdfe1a

DBZ-4279 For test compatibility with Xstream

view details

Vojtech Juranek

commit sha 9ca7629f1b0ff306600fb9b9c661d74fcc087a1f

DBZ-3570 return non-zero exit code from Debezium server upon failure

view details

Vojtech Juranek

commit sha e616c081e55ed2f1bdf0f7635829633dc057415e

DBZ-1042 Allow numeric slot names

view details

Vojtech Juranek

commit sha 49d252440ea38bf4c3230c88fedb836d2f661656

DBZ-1042 Allow Postgres connector to use numeric slot names To be able to use numeric slot names, the slot name has to be quoted. This may be consider as s bug in Postgres driver as Debezium passes the slot name as string. To workaround this issue, quote the slot name on the Debezium side.

view details

push time in 17 days

Pull request review commentdebezium/debezium

postgres: allow numeric slot name

 private PGReplicationStream startPgReplicationStream(final Lsn lsn, Function<Cha                 .getReplicationAPI()                 .replicationStream()                 .logical()-                .withSlotName(slotName)+                .withSlotName("\"" + slotName + "\"")

IMHO should be fine (this could be an issue in case of numeric slot names, but it doesn't work with current version). Anyway, definitely worth checking - will do (may me take some time).

vjuranek

comment created time in 17 days

PullRequestReviewEvent

Pull request review commentdebezium/debezium

postgres: allow numeric slot name

 public void shouldHaveLastCommitLsn() throws InterruptedException {         }     } +    @Test

done

vjuranek

comment created time in 17 days

PullRequestReviewEvent

Pull request review commentdebezium/debezium

postgres: allow numeric slot name

 public void initConnection() throws SQLException, InterruptedException {          try (Statement stmt = pgConnection().createStatement()) {             String createCommand = String.format(-                    "CREATE_REPLICATION_SLOT %s %s LOGICAL %s",+                    "CREATE_REPLICATION_SLOT \"%s\" %s LOGICAL \"%s\"",

Right, this change is not needed.

vjuranek

comment created time in 17 days

PullRequestReviewEvent

push eventvjuranek/debezium

camilesing

commit sha dfabe8cda849abadc66257c342679cd73eb54beb

DBZ-4275 fix AbstractDatabaseHistory typo

view details

Chris Cranford

commit sha 7720c653e52dd437ebdb2bf19149dbb456cdfe1a

DBZ-4279 For test compatibility with Xstream

view details

Vojtech Juranek

commit sha 9ca7629f1b0ff306600fb9b9c661d74fcc087a1f

DBZ-3570 return non-zero exit code from Debezium server upon failure

view details

Vojtech Juranek

commit sha ba6a45688d0990396aba61a37bd3337876ffed53

DBZ-1931 Reflect decimal.handling.mode in money conversion

view details

Vojtech Juranek

commit sha 66cf3250c0abdb57d2ed381b23861f617c68121f

DBZ-1931 Allow to specify number of fraction digits for the money type

view details

push time in 17 days

pull request commentdebezium/debezium

postgres: Reflect decimal.handling.mode in money conversion and allow to specify scale

* Do we have a test which doesn't provide the decimal handling mode setting, so to make sure that default mapping for `MONEY` column doesn't change?

Good point, AFAICT there's no such test, adding it.

* Could you update the docs (see https://github.com/debezium/debezium/blob/main/documentation/modules/ROOT/pages/connectors/postgresql.adoc) accordingly; we should describe the mapping of montary columns (currently not listed in the table with type mappings), and we should describe that `decimal.handling.mode` impacts monetary columns; probably best to search for references to that option name so to see where adjustments should be made

Sure, I wanted to check if you are fine the proposed changes first, before spending time with documentation :-) Doc changes may take me some time, will push it in next version. Now pushing new test testing default mapping and change you've proposed for testStreamMoneyAsString()

vjuranek

comment created time in 17 days

push eventvjuranek/debezium

camilesing

commit sha dfabe8cda849abadc66257c342679cd73eb54beb

DBZ-4275 fix AbstractDatabaseHistory typo

view details

Chris Cranford

commit sha 7720c653e52dd437ebdb2bf19149dbb456cdfe1a

DBZ-4279 For test compatibility with Xstream

view details

Vojtech Juranek

commit sha 9ca7629f1b0ff306600fb9b9c661d74fcc087a1f

DBZ-3570 return non-zero exit code from Debezium server upon failure

view details

Vojtech Juranek

commit sha 00c33ead95c84c6cdc483e2fa17a8427235b1d10

DBZ-1344 Don't warn about empty schema when using snapshot mode 'never'

view details

push time in 17 days

PullRequestReviewEvent

pull request commentoVirt/ovirt-ansible-collection

ovirt_remove_stale_lun: Retry "multipath -f" while removing the LUNs

LGTM, thanks @nijinashok !

nijinashok

comment created time in 17 days

push eventvjuranek/debezium

Vojtech Juranek

commit sha a581ef51b338d15e34bfcf0124f2f3d4d3cbe739

DBZ-3570 return non-zero exit code from Debezium server upon failure

view details

push time in 17 days

PR opened debezium/debezium

DBZ-3570 return non-zero exit code from Debezium server upon failure

https://issues.redhat.com/browse/DBZ-3570

+9 -1

0 comment

1 changed file

pr created time in 18 days

PR opened debezium/debezium

postgres: Reflect decimal.handling.mode in money conversion and allow to specify scale

https://issues.redhat.com/browse/DBZ-1931

+154 -23

0 comment

5 changed files

pr created time in 18 days

PR opened debezium/debezium

DBZ-1344 Don't warn about empty schema when using snapshot mode 'never'

https://issues.redhat.com/browse/DBZ-1344

+21 -1

0 comment

2 changed files

pr created time in 18 days

PR opened debezium/debezium

postgres: allow numeric slot name

https://issues.redhat.com/browse/DBZ-1042

+35 -2

0 comment

2 changed files

pr created time in 18 days

create barnchvjuranek/debezium

branch : DBZ-3570

created branch time in 18 days

create barnchvjuranek/debezium

branch : DBZ-1344

created branch time in 18 days

more