profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/vinkesh/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Vinkesh Banka vinkesh Thoughtworks Bangalore , India

Bahmni/emr-functional-tests 3

emr functional tests

Bahmni/bahmni-docker-old 2

DEPRECATED - This repository contains the relevant docker configuration for setting up Bahmni

Bahmni/bahmni-java-utils 2

This repository has various functional utilities needed by bahmni.

Bahmni/bahmni-reports 1

Reports web application for the Bahmni project

Bahmni/clojure_test_datasetup 1

Setup and Tear Down test data sets for integration tests in clojure

Bahmni/jss-config 1

[DEPRECATED - Moved to JSS GitHub organization (https://github.com/JanSwasthyaSahyog/jss-config) JSS Hospital specific configuration, scripts and data.

Bahmni/openmrs-data 1

Demo OpenMRS data for Bahmni.

Bahmni/openmrs-distro-bahmni 1

Generates distro for bahmni

Bahmni/openmrs-module-idgen-webservices 1

Rest services for openmrs idgen api

Pull request review commentopenmrs/openmrs-module-fhir2

FM2-398: Integration tests for $lastn in R3 and R4

 public void shouldReturnCountForObservationAsXml() throws Exception { 		assertThat(result, hasProperty("total", equalTo(21))); 		 	}++	@Test+	public void shouldReturnLastnObservationsAsJson() throws Exception {+		MockHttpServletResponse response = get(+				"Observation/$lastn?max=2&subject=" + OBS_PATIENT_UUID + "&category=laboratory&code=5242")+				.accept(FhirMediaTypes.JSON).go();++		assertThat(response, isOk());+		assertThat(response.getContentType(), is(FhirMediaTypes.JSON.toString()));+		assertThat(response.getContentAsString(), notNullValue());++		Bundle results = readBundleResponse(response);++		assertThat(results, notNullValue());+		assertThat(results.getType(), equalTo(Bundle.BundleType.COLLECTION));+		assertThat(results.hasEntry(), is(true));+		assertThat(results, hasProperty("total", equalTo(7)));++		List<Bundle.BundleEntryComponent> entries = results.getEntry();++		assertThat(entries, everyItem(hasProperty("fullUrl", startsWith("http://localhost/ws/fhir2/R3/Observation/"))));+		assertThat(entries, everyItem(hasResource(instanceOf(Observation.class))));+		assertThat(entries, everyItem(hasResource(validResource())));+		assertThat(entries,+				everyItem(hasResource(hasProperty("subject", hasProperty("reference", endsWith(OBS_PATIENT_UUID))))));+		assertThat(entries, everyItem(hasResource(+				hasProperty("code", hasProperty("coding", everyItem(hasProperty("display", equalTo("Respiratory rate"))))))));+		assertThat(entries, everyItem(hasResource(hasProperty("category",+				everyItem(hasProperty("coding", everyItem(hasProperty("code", equalTo("laboratory")))))))));

Since we queried for top 2 resources and got 7 in the query, we should verify that our logic for fetching the top ranked results is working correctly. That is, the number of distinct obsDateTime should be 2. We should add asserts for this in all the tests in my opinion.

Medhavi-16

comment created time in 9 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-143: Fix record merge issue test

 public void setUp() throws Exception {         patient1 = new TestPatient();     } -    @Ignore+    @Test+    @Category(BuildTests.class)     public void recordMergeIssueTest() throws Exception {-        homePage.goToRegisterPatientApp();+        homePage.goToRegisterPatientApp().waitForPage();

After the test invoking many pages during the test setUp(), the patient registration page takes a bit longer to be loaded by the classLoader. Adding waitforPage() resolves the delay Otherwise the actions that follow are not effective and the patient data is not saved in db instance

kdaud

comment created time in 5 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-143: Fix record merge issue test

 public void tearDown() throws Exception {         p.uuid = patient.uuid;         deletePatient(p);         waitForPatientDeletion(patient.uuid);-        headerPage.logOut();

After deleting the test patient data from the db instance there is no need to invoke headerPage.logOut() within tearDown() function

kdaud

comment created time in 5 hours

pull request commentopenmrs/openmrs-contrib-android-client

AC-973 Added feature of setting system default theme

@shivamsawlani02 I ran this PR locally, the option System Default in the theme dropdown section is a bit out of order, I think that needs a fix.

What do you mean by out of order? Default is going to the next line and is cut?

shivamsawlani02

comment created time in 6 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-74: Failing Test: ignored AddFormTests Follow up

     private static final By MANAGE_MODULES = By.cssSelector("#legacyui-manageModules a");     private final static By MANAGE_VISIT_TYPES = By.cssSelector("#legacyui-manageVisitTypes a");     private static final By MANAGE_PROVIDERS = By.cssSelector("#content a[href='/openmrs/admin/provider/index.htm']");-    private static final By MANAGE_PERSONS = By.cssSelector("#content a[href=\"/openmrs/admin/person/index.htm\"]");+    private static final By MANAGE_PERSONS = By.cssSelector("#content a[href='/openmrs/admin/person/index.htm']");+    private static final By MANAGE_HTMLFORMS_PAGE = By.cssSelector("#content a[href*='/module/htmlformentry/htmlForms.list']");

Resolved thanks

sherrif10

comment created time in 7 hours

PR opened openmrs/openmrs-distro-referenceapplication

RATEST-143: Fix record merge issue test

Ticket ID Description -> Fix record merge issue test

+10 -5

0 comment

1 changed file

pr created time in 7 hours

PR opened openmrs/openmrs-module-adminui

EMPT-75: Beautified error thrown on geting unexisting privilage

Before this PR, when you click,

  • configure metadata,
  • manage privileges,
  • edit icon of any privilege (personally, i used Add Allergies)
  • the URL will be openmrs/adminui/metadata/privileges/privilege.page?privilegeName=Add+Allergies&action=edit&
  • change the section Add+Allergies to asdf+lkjh or any non-existing Privilege.

You get an error image

With this PR you get something like image ,

+36 -29

0 comment

2 changed files

pr created time in 7 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-74: Failing Test: ignored AddFormTests Follow up

 public void addFormTest() throws Exception {         manageForm.formIdFromUrl();         manageForm.save();         headerPage.clickOnHomeIcon();-        homePage.goToActiveVisitPatient();

This is not needed with in this code, it will only break the automation perhaps it also doesnt add up within the workflow

sherrif10

comment created time in 8 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

fixed RATEST-149:Failing Test: Check Modules Test

     /**      * Check the list of modules to be sure they are all started.      */-    @Ignore+    @Test     @Category(org.openmrs.reference.groups.BuildTests.class)

@category(buildTest.class)

I think @sherrif10 meant @Category(BuildTest.class)

insookwa

comment created time in 8 hours

Pull request review commentopenmrs/openmrs-module-reportingrest

Fix swagger error by changing webservices dependency version to imple…

 public void testEvaluatingSerializedCohortDefintionWithParams() throws Exception 	private void assertCohortMembers(Object evaluated, String json, String[] expectedUuids) throws Exception { 		assertEquals(expectedUuids.length, ((List) path(evaluated, "members")).size()); 		for (String expected : expectedUuids) {

Does this mean the resource was changed from patient to person? Could you point me to where that was done?

logeshvar

comment created time in 8 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

fixed RATEST-149:Failing Test: Check Modules Test

     /**      * Check the list of modules to be sure they are all started.      */-    @Ignore+    @Test     @Category(org.openmrs.reference.groups.BuildTests.class)

You can make it as @Category(buildTest.class) not org.openmrs.reference.groups.buildTests.class simply because the full package is being defined in pom class

insookwa

comment created time in 8 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

fixed RATEST-149:Failing Test: Check Modules Test

     /**      * Check the list of modules to be sure they are all started.      */-    @Ignore+    @Test

the @category is just below the @Test

insookwa

comment created time in 8 hours

pull request commentopenmrs/openmrs-module-webservices.rest

RESTWS-823: Add REST resource for Alert Management

@dkayiwa Can you see why the snyk job has failed? I can't access it

BartlomiejRasztabiga

comment created time in 17 hours

Pull request review commentopenmrs/openmrs-module-reportingrest

Fix swagger error by changing webservices dependency version to imple…

 public void testEvaluatingSerializedCohortDefintionWithParams() throws Exception 	private void assertCohortMembers(Object evaluated, String json, String[] expectedUuids) throws Exception { 		assertEquals(expectedUuids.length, ((List) path(evaluated, "members")).size()); 		for (String expected : expectedUuids) {

Yes, due to change in dependency version, there is some change in the internals that cause this.. so had to change that. :)

logeshvar

comment created time in a day

push eventopenmrs/openmrs-contrib-android-client

Saurabh kumar

commit sha 05c6b3ba5c7d859fb39e89c16a6b60f43dee501e

AC-925 : Used Viewbinding for VisitDashboard package. (#904) 1. left the nullifying of binding in activity since its a local variable.

view details

push time in a day

PR merged openmrs/openmrs-contrib-android-client

AC-925 : Used Viewbinding for VisitDashboard package.

<!--- Add a pull request title above in this format --> <!--- real example: 'AC-204 Applying MVP Model' --> <!--- 'AC-JiraIssueNumber JiraIssueTitle' -->

Description of what I changed

<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->

  1. left the nullifying of binding in activity since its a local variable.
  2. Used ViewBinding for whole package.

Issue I worked on

<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it --> <!--- Just add the issue number at the end: --> JIRA Issue: https://issues.openmrs.org/browse/AC-925

Checklist: I completed these to help reviewers :)

<!--- Put an x in the box if you did the task --> <!--- If you forgot a task please follow the instructions below -->

  • [x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1). <!--- No? -> read here on how to squash multiple commits into one -->

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) <!--- No? -> write tests and add them to this commit git add . && git commit --amend-->

  • [x] All new and existing tests passed. <!--- No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. -->

  • [x] My pull request is based on the latest changes of the master branch. <!--- No? Unsure? -> execute command git pull --rebase upstream master -->

+33 -21

0 comment

3 changed files

LuGO0

pr closed time in a day

push eventopenmrs/openmrs-contrib-android-client

Saurabh kumar

commit sha aab998e98c08561c5ddfc55b6d1555c3a97ae93a

AC-912 : used ViewBinding for lastViewed patients package (#901) 1. added binding for fragment and activity as well. 2. taken care of onDestroy on fragment.

view details

push time in a day

PR merged openmrs/openmrs-contrib-android-client

AC-912 : used ViewBinding for lastViewed patients package

<!--- Add a pull request title above in this format --> <!--- real example: 'AC-204 Applying MVP Model' --> <!--- 'AC-JiraIssueNumber JiraIssueTitle' -->

Description of what I changed

<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->

  1. added binding for fragment and activity as well.
  2. taken care of onDestroy on fragment.

Issue I worked on

<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it --> <!--- Just add the issue number at the end: --> JIRA Issue: https://issues.openmrs.org/browse/AC-912

Checklist: I completed these to help reviewers :)

<!--- Put an x in the box if you did the task --> <!--- If you forgot a task please follow the instructions below -->

  • [x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1). <!--- No? -> read here on how to squash multiple commits into one -->

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) <!--- No? -> write tests and add them to this commit git add . && git commit --amend-->

  • [x] All new and existing tests passed. <!--- No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. -->

  • [x] My pull request is based on the latest changes of the master branch. <!--- No? Unsure? -> execute command git pull --rebase upstream master -->

+44 -30

1 comment

2 changed files

LuGO0

pr closed time in a day

push eventopenmrs/openmrs-contrib-android-client

Saurabh kumar

commit sha ea8e8d7bfc1d770e7368f05ad38e64f17a83f806

Ac-911: Used View binding in FormDisplay package (#902) 1. did not nullify the binding variable in activity but did in fragment. 2. used binding in both activity and fragment.

view details

push time in a day

PR merged openmrs/openmrs-contrib-android-client

AC-911: Used View binding in FormDisplay package

<!--- Add a pull request title above in this format --> <!--- real example: 'AC-204 Applying MVP Model' --> <!--- 'AC-JiraIssueNumber JiraIssueTitle' -->

Description of what I changed

<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->

  1. did not nullify the binding variable in activity but did in fragment.
  2. used binding in both activity and fragment.

Issue I worked on

<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it --> <!--- Just add the issue number at the end: --> JIRA Issue: https://issues.openmrs.org/browse/AC-911

Checklist: I completed these to help reviewers :)

<!--- Put an x in the box if you did the task --> <!--- If you forgot a task please follow the instructions below -->

  • [x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1). <!--- No? -> read here on how to squash multiple commits into one -->

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) <!--- No? -> write tests and add them to this commit git add . && git commit --amend-->

  • [x] All new and existing tests passed. <!--- No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. -->

  • [x] My pull request is based on the latest changes of the master branch. <!--- No? Unsure? -> execute command git pull --rebase upstream master -->

+51 -37

1 comment

2 changed files

LuGO0

pr closed time in a day

Pull request review commentopenmrs/openmrs-contrib-android-client

AC-924 : Used ViewBinding in SyncedPatients package.

  public class SyncedPatientsFragment extends ACBaseFragment<SyncedPatientsContract.Presenter> implements SyncedPatientsContract.View {     // Fragment components-    private TextView mEmptyList;-    private RecyclerView mSyncedPatientRecyclerView;+    private FragmentSyncedPatientsBinding binding = null;+    private TextView emptyList;+    private RecyclerView syncedPatientRecyclerView;     private SwipeRefreshLayout swipeRefreshLayout;     //Initialization Progress bar

This too. In fact remove all unnecessary comments

LuGO0

comment created time in a day

Pull request review commentopenmrs/openmrs-contrib-android-client

AC-924 : Used ViewBinding in SyncedPatients package.

  public class SyncedPatientsFragment extends ACBaseFragment<SyncedPatientsContract.Presenter> implements SyncedPatientsContract.View {     // Fragment components

Remove this

LuGO0

comment created time in a day

Pull request review commentopenmrs/openmrs-contrib-android-client

AC-924 : Used ViewBinding in SyncedPatients package.

 import org.openmrs.mobile.activities.ACBaseActivity; import org.openmrs.mobile.activities.lastviewedpatients.LastViewedPatientsActivity; import org.openmrs.mobile.application.OpenMRS;+import org.openmrs.mobile.databinding.ActivityFindPatientsBinding; import org.openmrs.mobile.utilities.ApplicationConstants; import org.openmrs.mobile.utilities.StringUtils;  public class SyncedPatientsActivity extends ACBaseActivity {-    public SyncedPatientsPresenter mPresenter;+    public SyncedPatientsPresenter presenter;     private SearchView searchView;     private String query;     //Menu Items

Can you remove this comment too

LuGO0

comment created time in a day

CommitCommentEvent

PR closed openmrs/openmrs-module-adminui

EMPT:75 Beautified error on accesing none existing Privilege

Before this PR, when you click,

  • configure metadata,
  • manage privileges,
  • edit icon of any privilege (personally, i used Add Allergies)
  • the URL will be openmrs/adminui/metadata/privileges/privilege.page?privilegeName=Add+Allergies&action=edit&
  • change the section Add+Allergies to asdf+lkjh or any non-existing Privilege. You get an error image

with this PR you get image

cc @isears @sherrif10

+0 -0

0 comment

0 changed file

jnsereko

pr closed time in a day

Pull request review commentopenmrs/openmrs-esm-patient-chart

MF-624: Improve Workspace visual formatting (tablet and desktop mode)

 const VitalsAndBiometricForms: React.FC<VitalsAndBiometricFormProps> = ({ patien   const session = useSessionUser();   const config = useConfig() as ConfigObject;   const { t } = useTranslation();+  const layout = useLayoutType();   const { vitalsSignsConceptMetadata, conceptsUnits } = useVitalsSignsConceptMetaData();   const biometricsUnitsSymbols = config.biometrics;   const [patientVitalAndBiometrics, setPatientVitalAndBiometrics] = useState<PatientVitalAndBiometric>();   const [patientBMI, setPatientBMI] = useState<number>();   const [isSubmitting, setIsSubmitting] = useState<boolean>(false);+  const [lightMode, setLightMode] = useState<boolean>();

Again.

donaldkibet

comment created time in a day

Pull request review commentopenmrs/openmrs-esm-patient-chart

MF-624: Improve Workspace visual formatting (tablet and desktop mode)

 export interface OrderBasketSearchProps {  export default function OrderBasketSearch({ encounterUuid, onSearchResultClicked }: OrderBasketSearchProps) {   const { t } = useTranslation();+  const layout = useLayoutType();   const [searchTerm, setSearchTerm] = useState('');+  const [lightMode, setLightMode] = useState<boolean>();

useMemo it is : )

donaldkibet

comment created time in a day