Since we queried for top 2 resources and got 7 in the query, we should verify that our logic for fetching the top ranked results is working correctly. That is, the number of distinct obsDateTime should be 2. We should add asserts for this in all the tests in my opinion.

After the test invoking many pages during the test setUp(), the patient registration page takes a bit longer to be loaded by the classLoader. Adding waitforPage() resolves the delay Otherwise the actions that follow are not effective and the patient data is not saved in db instance

After deleting the test patient data from the db instance there is no need to invoke headerPage.logOut() within tearDown() function

@shivamsawlani02 I ran this PR locally, the option System Default in the theme dropdown section is a bit out of order, I think that needs a fix.

What do you mean by out of order? Default is going to the next line and is cut?

Resolved thanks

Ticket ID Description -> Fix record merge issue test

Before this PR, when you click,

• configure metadata,
• manage privileges,
• edit icon of any privilege (personally, i used Add Allergies)
• the URL will be openmrs/adminui/metadata/privileges/privilege.page?privilegeName=Add+Allergies&action=edit&
• change the section Add+Allergies to asdf+lkjh or any non-existing Privilege.

You get an error

With this PR you get something like ,

This is not needed with in this code, it will only break the automation perhaps it also doesnt add up within the workflow

@category(buildTest.class)

I think @sherrif10 meant @Category(BuildTest.class)

Does this mean the resource was changed from patient to person? Could you point me to where that was done?

You can make it as @Category(buildTest.class) not org.openmrs.reference.groups.buildTests.class simply because the full package is being defined in pom class

the @category is just below the @Test

@dkayiwa Can you see why the snyk job has failed? I can't access it

@ibacher PTAL.

Yes, due to change in dependency version, there is some change in the internals that cause this.. so had to change that. :)

Related issue: https://issues.openmrs.org/browse/RESTWS-841

<!--- Add a pull request title above in this format --> <!--- real example: 'AC-204 Applying MVP Model' --> <!--- 'AC-JiraIssueNumber JiraIssueTitle' -->

Description of what I changed

<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->

1. left the nullifying of binding in activity since its a local variable.
2. Used ViewBinding for whole package.

Issue I worked on

<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it --> <!--- Just add the issue number at the end: --> JIRA Issue: https://issues.openmrs.org/browse/AC-925

Checklist: I completed these to help reviewers :)

<!--- Put an x in the box if you did the task --> <!--- If you forgot a task please follow the instructions below -->

• [x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1). <!--- No? -> read here on how to squash multiple commits into one -->

• [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) <!--- No? -> write tests and add them to this commit git add . && git commit --amend-->

• [x] All new and existing tests passed. <!--- No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. -->

• [x] My pull request is based on the latest changes of the master branch. <!--- No? Unsure? -> execute command git pull --rebase upstream master -->

<!--- Add a pull request title above in this format --> <!--- real example: 'AC-204 Applying MVP Model' --> <!--- 'AC-JiraIssueNumber JiraIssueTitle' -->

Description of what I changed

<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->

1. added binding for fragment and activity as well.
2. taken care of onDestroy on fragment.

Issue I worked on

<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it --> <!--- Just add the issue number at the end: --> JIRA Issue: https://issues.openmrs.org/browse/AC-912

Checklist: I completed these to help reviewers :)

<!--- Put an x in the box if you did the task --> <!--- If you forgot a task please follow the instructions below -->

• [x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1). <!--- No? -> read here on how to squash multiple commits into one -->

• [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) <!--- No? -> write tests and add them to this commit git add . && git commit --amend-->

• [x] All new and existing tests passed. <!--- No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. -->

• [x] My pull request is based on the latest changes of the master branch. <!--- No? Unsure? -> execute command git pull --rebase upstream master -->

<!--- Add a pull request title above in this format --> <!--- real example: 'AC-204 Applying MVP Model' --> <!--- 'AC-JiraIssueNumber JiraIssueTitle' -->

Description of what I changed

<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->

1. did not nullify the binding variable in activity but did in fragment.
2. used binding in both activity and fragment.

Issue I worked on

<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it --> <!--- Just add the issue number at the end: --> JIRA Issue: https://issues.openmrs.org/browse/AC-911

Checklist: I completed these to help reviewers :)

<!--- Put an x in the box if you did the task --> <!--- If you forgot a task please follow the instructions below -->

• [x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1). <!--- No? -> read here on how to squash multiple commits into one -->

• [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) <!--- No? -> write tests and add them to this commit git add . && git commit --amend-->

• [x] All new and existing tests passed. <!--- No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. -->

• [x] My pull request is based on the latest changes of the master branch. <!--- No? Unsure? -> execute command git pull --rebase upstream master -->

This too. In fact remove all unnecessary comments

Remove this

Can you remove this comment too

Before this PR, when you click,

• configure metadata,
• manage privileges,
• edit icon of any privilege (personally, i used Add Allergies)
• the URL will be openmrs/adminui/metadata/privileges/privilege.page?privilegeName=Add+Allergies&action=edit&
• change the section Add+Allergies to asdf+lkjh or any non-existing Privilege. You get an error

with this PR you get

cc @isears @sherrif10

Again.

useMemo it is : )