profile
viewpoint

andreikop/qutepart 81

Code editor component for PyQt5

johannhof/markdown.rs 72

Rust Markdown parsing library

vi/dive 44

Start programs inside unshare/lxc namespaces easily using UNIX sockets + easy access to capabilities, namespaces, chroot and others.

vi/fdlinecombine 32

Read multiple fds and print data to stdout linewise.

vi/execfuse 19

Turn a bunch of scripts into FUSE filesystem

vi/dnscache 11

Simple DNS proxy with forced caching

vi/AnkiImporter 4

Import cards into AnkiDroid from text files using API

vi/compactmap 4

CompactMap data structure for Rust

vi/DisplayAndPickPixel 4

Display picture and print coordinates on clicks

vi/chaoticfs 3

Encrypting FUSE filesystem with "false bottom" allowing exposing the data only partially

issue commentremkop/picocli

Invalid error message generated when unmatched positional argument is the same as one of previous valid argument

First and third elements of the array should match to make it err.

vi

comment created time in a day

issue commentremkop/picocli

Invalid error message generated when unmatched positional argument is the same as one of previous valid argument

Approximate redacted source code:


import picocli.CommandLine;

import picocli.CommandLine.Command;
import picocli.CommandLine.Option;
import picocli.CommandLine.Parameters;
import java.util.concurrent.Callable;

@Command(name = "app", mixinStandardHelpOptions = true, version = "app 1.0",
         description = "....")
public class App implements Callable<Integer> {

    @Parameters(index = "0", description = "...")
    private String arg1;

    @Parameters(index = "1", description = "...", defaultValue="")
    private String arg2;

    @Override
    public Integer call() throws Exception {
        return 0;
    }
    public static void main(String[] args) {
        int exitCode = new CommandLine(new App()).execute(args);
        System.exit(exitCode);
    }
}

(not checked buildability)

vi

comment created time in a day

issue openedremkop/picocli

Invalid error message generated when unmatched positional argument is the same as one of previous valid argument

$ java -jar  app.jar   sdf sf sdf
Unmatched argument at index 0: 'sdf'
Usage: app [-hV] <arg1> <arg2>
...
$ java -jar  app.jar   sdf sf qqq
Unmatched argument at index 2: 'qqq'
Usage: app [-hV] <arg1> <arg2>

Expected them to be both "index 2".

created time in a day

starteddtolnay/paste

started time in 2 days

startedlambda-fairy/if_chain

started time in 2 days

startedEmoun/duplicate

started time in 2 days

issue openedBurntSushi/xsv

Feature request: repeat headers for `xsv table`

When doing xsv table | less -S it is easy to lose track of which column you are looking at. Repeating the column headers row, for example, each 20 rows would make it more friendly.

created time in 3 days

issue commentrust-lang/rustup

Please support a "system" toolchain

As a minimum it should suggest rustup toolchain link in this message:

info: downloading installer
warning: it looks like you have an existing installation of Rust at:
warning: /usr/bin
warning: rustup should not be installed alongside Rust. Please uninstall your existing Rust first.
warning: Otherwise you may have confusion unless you are careful with your PATH
warning: If you are sure that you want both rustup and your already installed Rust
warning: then please reply `y' or `yes' or set RUSTUP_INIT_SKIP_PATH_CHECK to yes
warning: or pass `-y' to ignore all ignorable checks.
error: cannot install while Rust is installed

Continue? (y/N)

Maybe it there should be easy interactive choice leading to linking system toolchain, not downloading any additional toolchains and making system toolchain default.

It should be straightforward to enable cargo +nightly build touching the default way.

joshtriplett

comment created time in 4 days

issue commentTribler/tribler

socket.gaierror: [Errno -2] Name or service not known

Will it include tribler/docker-tribler-prod?

Also can Triber run core and GUI separate again, like long ago?

vi

comment created time in 5 days

issue commentTribler/tribler

socket.gaierror: [Errno -2] Name or service not known

Shall new version of Docker image be published to Hub each time new stable Triber version is tagged?

vi

comment created time in 5 days

issue commentTribler/tribler

socket.gaierror: [Errno -2] Name or service not known

It's the latest version of tribler/docker-tribler-prod image. But it was CREATED 7 months ago, so I doubt it's has the last version of Triber&deps inside.

vi

comment created time in 5 days

issue commentTribler/tribler

socket.gaierror: [Errno -2] Name or service not known

Traceback (most recent call last):
  File "/home/tribler/tribler/src/tribler-gui/tribler_gui/event_request_manager.py", line 114, in on_read_data
    raise RuntimeError(json_dict["event"]["text"])
RuntimeError: Task was destroyed but it is pending!
vi

comment created time in 5 days

issue commentTribler/tribler

socket.gaierror: [Errno -2] Name or service not known

Another spurious failure:

Traceback (most recent call last):
  File "/home/tribler/tribler/src/tribler-gui/tribler_gui/event_request_manager.py", line 114, in on_read_data
    raise RuntimeError(json_dict["event"]["text"])
RuntimeError: Task was destroyed but it is pending!

Is tribler/docker-tribler-prod a good way to run Tribler in general? Or is it some abandoned experiment?

vi

comment created time in 5 days

issue openedTribler/tribler

socket.gaierror: [Errno -2] Name or service not known

Tribler version/branch+revision:

Docker image 5a5d40220b8b from tribler/docker-tribler-prod

Operating system and version:

Linux + Docker

Steps to reproduce the behavior:
  1. Start Tribler
  2. Subscribe to a channel
  3. Add a download
  4. Wait
Expected behavior:

It goes smoothly

Actual behavior:

It shows error box and exits.

Error report also cannot be sent - the button gets stuck at "Sending".

Relevant log file output:
Traceback (most recent call last):
  File "/home/tribler/tribler/src/tribler-gui/tribler_gui/event_request_manager.py", line 114, in on_read_data
    raise RuntimeError(json_dict["event"]["text"])
RuntimeError: Traceback (most recent call last):
  File "/usr/lib/python3.8/asyncio/events.py", line 81, in _run
    self._context.run(self._callback, *self._args)
  File "/home/tribler/tribler/src/pyipv8/ipv8/taskmanager.py", line 108, in done_cb
    future.result()
  File "/home/tribler/tribler/src/pyipv8/ipv8/messaging/anonymization/tunnel.py", line 166, in resolve
    infos = await get_event_loop().getaddrinfo(host, 0, family=socket.AF_INET)
  File "/usr/lib/python3.8/asyncio/base_events.py", line 825, in getaddrinfo
    return await self.run_in_executor(
  File "/usr/lib/python3.8/concurrent/futures/thread.py", line 57, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/usr/lib/python3.8/socket.py", line 918, in getaddrinfo
    for res in _socket.getaddrinfo(host, port, family, type, proto, flags):
socket.gaierror: [Errno -2] Name or service not known

Those "key-value" things cannot be copied from report.

I also see those things in log:

Traceback (most recent call last):
  File "/usr/lib/python3.8/asyncio/selector_events.py", line 1046, in sendto
    self._sock.sendto(data, addr)
AttributeError: 'NoneType' object has no attribute 'sendto'
AttributeError: 'NoneType' object has no attribute 'call_exception_handler'

created time in 5 days

issue commentvi/websocat

Output of received messages to stdout truncated to 1024 bytes

@yeryomenkom Does the threadedstdio: workaround work for you as well?

rollulus

comment created time in 10 days

startedBurntSushi/xsv

started time in 13 days

issue commentpyfisch/cbor

Looking for Maintainers

@hansl, What is status of the rewrite? Are there plans to releasing it to crates.io?

pyfisch

comment created time in 19 days

issue commentron-rs/ron

How do I round trip ron files preserving formatting and comments?

Maybe like with cbor rewrite, RON should have two crates: low-level serde-independent and high-level serde-based?

vi

comment created time in 19 days

issue commentvi/websocat

REQUEST: Option to display ping/pong/close

Note that those pings and closes are already visible if you increase the logging level further websocat -v -v.

I made them INFO and now should be visible at one -v.

FGasper

comment created time in 20 days

push eventvi/websocat

Vitaly _Vi Shukela

commit sha a00078416e3f94a32d385dbd24538c6fffda86f3

Upgrade log level of server-sent pings and closes from debug to info Should resolve #49

view details

push time in 20 days

issue closedvi/websocat

REQUEST: Option to display ping/pong/close

Hello,

Is there an option to display sent/received control frames? I don’t see one.

Thank you!

closed time in 20 days

FGasper

issue commentSmujb/powered-pixel-dungeon

Power Pylon is still glitched in old savefile

In a newly started savefile it does not work as well.

Fortunately, there was a wand that time, so the game progressed.

vi

comment created time in 20 days

issue commentvi/websocat

REQUEST: Option to display ping/pong/close

Would just adding INFO logs for them be enough?

FGasper

comment created time in 20 days

issue openedSmujb/powered-pixel-dungeon

Arcane bomb remained in "burning fuse" state for long, when dropped just before diving in

It was shown blinking in red when I found it again. Just picked up back to inventory.

created time in 20 days

issue openedSmujb/powered-pixel-dungeon

Short press on the wait button somtimes waits too much

If a fast hero waits an enemy at the door, pressing "wait" should only wait for enough time for enemy to appear at the door, not also attack or walk away.

created time in 20 days

issue openedSmujb/powered-pixel-dungeon

Shall more things that restore health also restore morale?

Examples:

  • Well of health. I assumed it just restored everything, found out morale is excluded.
  • "Well fed" buff. Shall it grant faster morale regen, like it generates health regen?

created time in 21 days

issue openedSmujb/powered-pixel-dungeon

Power Pylon is still glitched in old savefile

pylon

That game session cannot progress; the savefile is waiting for a fix to arrive.

created time in 22 days

issue commentSmujb/powered-pixel-dungeon

Wand charge counter disappears from quickslot when the wand is equipped after clicking on quickslot

How many taps would be required to alternate wands competing over one equipment slot after such removal?

vi

comment created time in 22 days

pull request commentnix-rust/nix

Mark nix::unistd::fork as unsafe.

@asomers, Shall something more to be done about this pull request?

vi

comment created time in 22 days

issue openedandrewhickman/fs-err

Is localisation of error messages in scope for this project?

Or shall it stay English-only?

created time in 23 days

issue openedSmujb/powered-pixel-dungeon

Each dark gold ore piece is collected twice

At least when Pickaxe is activated from a quickslot, it shows dark ore collecting animation twice and obtains two dark ore items.

It deviates from Shattered. Is it intended/expected?

created time in 23 days

issue openedSmujb/powered-pixel-dungeon

Morale loss even when drunk

It's hard to get back to normal morale level once it dips below 30%.

Beverages are now ineffective and it seems that hunger (and maybe even battles) cause morale to still drop even when drunk.

Is it indented and expected?

created time in 23 days

PR closed websockets-rs/rust-websocket

Update docs invalid
+1 -1

1 comment

1 changed file

ajaycstech

pr closed time in 24 days

push eventwebsockets-rs/rust-websocket

Christopher Annanie

commit sha fd82aa28bb2aeb21d235afc9607e9f79631404a0

Expose native_tls as it's needed to use your API

view details

Vitaly Shukela

commit sha b78d08b9bdb401a5ddfb5bea97240af7c49e9795

Merge pull request #247 from levelonedev/pub_native_tls Expose native_tls as it's needed to use your API

view details

push time in 24 days

PR merged websockets-rs/rust-websocket

Expose native_tls as it's needed to use your API

In order to use any of the connect functions I would be required to depend on native_tls directly. It would be easier if you exposed the version you depend on.

use native_tls::TlsConnector; //Errors out currently
use websocket::native_tls::{TlsConnector, Certificate}; //What I propose

let mut file = File::open("cert.pem")?;
let mut data:Vec<u8> = Vec::new();
file.read_to_end(&mut data);
let root_ca = Certificate::from_pem(&data)?;
let connector = TlsConnector::builder().add_root_certificate(root_ca).build()?;

let mut builder: ClientBuilder = ClientBuilder::from_url(&self.url);
let mut client = builder.connect(Some(connector))?;
+1 -1

0 comment

1 changed file

levelonedev

pr closed time in 24 days

Pull request review commentwebsockets-rs/rust-websocket

Update docs

 Rust-WebSocket is a WebSocket ([RFC6455](https://datatracker.ietf.org/doc/rfc645  Rust-WebSocket provides a framework for dealing with WebSocket connections (both clients and servers). The library is currently in an experimental state, but provides functionality for both normal and secure WebSockets, a message level API supporting fragmentation, a data frame level API, and the ability to extend and customize behaviour. -## Installation+## Basic Installation

What's the difference?

ajaycstech

comment created time in 24 days

PullRequestReviewEvent

issue openedSmujb/powered-pixel-dungeon

Bronze door image still looks teared

shear

commit 01c7b741d1c8981a89f912d79427a1d05bbbaa93

created time in 25 days

issue openedSmujb/powered-pixel-dungeon

Scroll of Lullaby gets wasted when health is full, but morale is not full.

"too healthy and resist urge to sleep"

Is it really intended and a source of damage is required to restore morale using the scroll?

created time in 25 days

issue openedSmujb/powered-pixel-dungeon

Wand charge counter disappears from quickslot when the wand is equipped after clicking on quickslot

UI issue.

For example, there are two identified wands, only one of which is typically equipped. Normally I expect both wands to show charge counter in quickslot.

But when I click on unequipped wand's quickslot and choose the other wand to be unequipped, the counter for newly equipped wand disappears.

created time in 25 days

issue commentlexica/lexica

Counters in letter cells often go below 0.

german dictionary À

Strange letter for a German dictionary.

vi

comment created time in a month

issue commentlexica/lexica

Counters in letter cells often go below 0.

It is Russian mode. I haven't tried other languages enough yet. It happens rather often, maybe with about 20% probability.

vi

comment created time in a month

issue commentlexica/lexica

Counters in letter cells often go below 0.

Version is 1.3.1 from F-Droid.

1 2 3 4 5

vi

comment created time in a month

issue openedlexica/lexica

Counters in letter cells often go below 0.

Often counters seem to underestimate number of words a letter occurs in, so when solving it goes to 0 (white-coloured cell), then to -1 and below.

created time in a month

issue commentSmujb/powered-pixel-dungeon

UX issues when using multiple weapons with different reach

Even if I press the wait button, long-reaching weapon still not gets available until I attack at a short range.

I think it should be possible to temporarily ignore the short-reach weapon and use only long-reach one, maybe by alternating "attack" and "wait" buttons.

vi

comment created time in a month

issue openedSmujb/powered-pixel-dungeon

Description text is often wrong.

  • Rogue garb (and probably mage's robe) is still "null".
  • "The Rogue starts with a unique artifact: the Cloack of Shadows" - looks no longer relevant.
  • Once when I loaded an old savefile, it showed that mage has a Greatsword imbued with Wand of Breath Sentry (and it had the sword's sprite). I cannot reproduce it anymore (even when loading the same savefile). I also immeidately exited, so no screenshot or behaviour. Probably it's some saving/restoring issue.

commit 01c7b741d1c8981a89f912d79427a1d05bbbaa93

created time in a month

issue openedSmujb/powered-pixel-dungeon

Navigation though level is annoyingly interrupted by enemies chaotically phasing in and out of perception

This leads to much more clicks to walk to distant room, as you need to reconfirm movement again and again compared to Shattered.

Typically when hero becomes aware of an enemy in Shattered, he/she need to do something with it, so unconditional interruption is usually granted. In Powered it is much often that the hero needs to just ignore it for the time being.

Ideas about UX improvement:

  • Second tap to continue walking at the same destination should temporarily add currently visible enemies into an ignorelist. If an enemy from the ignorelist becomes imperceptible, then perceptible again, it does not interrupt the walk. Ignorelist is cleared when you arrive at the destination.
  • Sleeping enemies that are behind a wall and cannot be attacked are just always ignored (once they are shown once). A unhighlighted "hero's memory" mark can be shown on map to avoid this leading to missing occasional advantage of knowing about an enemy in advance.

created time in a month

issue openedSmujb/powered-pixel-dungeon

Is grass supposed to grow underwater?

Are blooming weapons supposed to bloom underwater?

underwater1

commit 01c7b741d1c8981a89f912d79427a1d05bbbaa93

created time in a month

issue openedSmujb/powered-pixel-dungeon

Deatch when diving out looks strange.

  • Map is undiscovered (it was partially visible before)
  • Not on top of deep water
  • No "Game over" text (it has probably blinked though in the water level).
  • No loot (it has probably remained in the water)

underwater2

commit 01c7b741d1c8981a89f912d79427a1d05bbbaa93

created time in a month

issue openedSmujb/powered-pixel-dungeon

UX issues when using multiple weapons with different reach

Sometimes option to attach at a distance is present, sometimes it is not. I don't know remember if it affects gameplay, but it certainly requires more taps e.g. when doing fishing from safe distance.

created time in a month

issue commentvi/websocat

[Question] Keep connection open in the background.

Do you want something like this?

mygizli04

comment created time in a month

pull request commentnix-rust/nix

Mark nix::unistd::fork as unsafe.

@asomers Rebased the pull request.

vi

comment created time in a month

push eventvi/nix

Vitaly _Vi Shukela

commit sha 4db701dafedf6dacce465bb90d4594628b67dbf8

Adapt for safe-isation of some libc functions. (https://github.com/rust-lang/libc/pull/1870) Denied lint being overridden instead of unsafe block removed to preserve compatibility with old `libc` versions.

view details

bors[bot]

commit sha 2c2440521acb5942a5f937b8d3126577cf91106a

Merge #1294 1294: Add allow(unused_unsafe) to some functions. r=asomers a=vi Co-authored-by: Vitaly _Vi Shukela <vi0oss@gmail.com>

view details

Vitaly _Vi Shukela

commit sha 74cb1545f4d2249b6086c3f4aa242e43362759de

Mark nix::unistd::fork as unsafe. Fix tests. No change in documentation. Resolves #1030.

view details

Vitaly _Vi Shukela

commit sha 42172a6764c96ed5e420debcb3ed00c6dca5fb41

Add CHANGELOG.md entry about unsafe fork.

view details

push time in a month

pull request commentnix-rust/nix

Add allow(unused_unsafe) to some functions.

@asomers What more to be done for this?

vi

comment created time in a month

pull request commentTyOverby/Bark

it liiiiiiives! (remove unsafe `Send` impl for `Bark` and then do lots of other stuff)

@sdleffler, Maybe publish a fork and start maintaining it yourself?

sdleffler

comment created time in a month

issue commentrust-lang/wg-cargo-std-aware

Can't build executables for musl

Workaround by building staticlib for x86_64-unknown-linux-gnu with #[no_mangle] pub fn main, then linking with musl-gcc -static seems to work and produce slightly a larger, yet comparable-sized helloworld.

$ grep crate-type Cargo.toml
crate-type = ["staticlib"]

$ cat src/lib.rs
#[no_mangle]
pub fn main() -> i32 {
    println!("Hello, world!");
    0
}


$ cargo build --release -Zbuild-std=panic_abort,std -Zbuild-std-features=panic_immediate_abort --target=x86_64-unknown-linux-gnu
    Finished release [optimized] target(s) in 0.04s

$ musl-gcc -static target/x86_64-unknown-linux-gnu/release/libkoo.a -o koo_static
$ strip koo_static
$ file koo_static
koo_static: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped
$ ls -lh koo_static
-rwxrwxr-x 1 vi vi 38K Sep 18 01:13 koo_static
$ ./koo_static
Hello, world!

So in theory it should be possible to build std for musl with std-aware-cargo.

vi

comment created time in a month

issue openedrust-lang/wg-cargo-std-aware

Can't build std if I specify target json file: std does not see networking

Building hello world for x86_64-unknown-linux-gnu works.

But if I save x86_64-unknown-linux-gnu's target specification to json and build using that json, std fails to find socket-related things.

$ cargo --version
cargo 1.48.0-nightly (8777a6b1e 2020-09-15)
$ rustc --version
rustc 1.48.0-nightly (285fc7d70 2020-09-16)

$ rustc +nightly -Z unstable-options --print target-spec-json > mytarget.json
$ gvim mytarget.json # change `is-builin` to `false`. It doesn't matter actually.
$ cargo build --release -Zbuild-std=panic_abort,std -Zbuild-std-features=panic_immediate_abort --target=./mytarget.json
...
   Compiling std v0.0.0 (/nix/rust/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std)
error[E0432]: unresolved imports `crate::sys_common::net::getsockopt`, `crate::sys_common::net::setsockopt`, `crate::sys_common::net::sockaddr_to_addr`
 --> /nix/rust/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/unix/net.rs:8:30
  |
8 | use crate::sys_common::net::{getsockopt, setsockopt, sockaddr_to_addr};
  |                              ^^^^^^^^^^  ^^^^^^^^^^  ^^^^^^^^^^^^^^^^ no `sockaddr_to_addr` in `sys::unix::net`
  |                              |           |
  |                              |           no `setsockopt` in `sys::unix::net`
  |                              no `getsockopt` in `sys::unix::net`

error[E0432]: unresolved import `crate::sys_common::net::LookupHost`
... (a lot of other missing things related to networking) ...

I except building using custom target json that happens to be the same as built-in json to be exactly the same as building specifying built-in target directly.

created time in a month

issue openedrust-lang/wg-cargo-std-aware

Can't build executables for musl

Usual target works:

$ grep panic Cargo.toml
panic = 'abort'

$ cargo build --release -Zbuild-std=panic_abort,std -Zbuild-std-features=panic_immediate_abort --target=x86_64-unknown-linux-gnu
...

$ strip target/x86_64-unknown-linux-gnu/release/koo -o koo
$ ls -lh koo
-rwxrwxr-x 1 vi vi 35K Sep 18 00:57 koo
$ ./koo
Hello, world!

But musl don't:

$ cargo build --release -Zbuild-std=panic_abort,std -Zbuild-std-features=panic_immediate_abort --target=x86_64-unknown-linux-musl
   Compiling compiler_builtins v0.1.35
   Compiling libc v0.2.77
   Compiling unwind v0.0.0 (/nix/rust/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/unwind)
The following warnings were emitted during compilation:

warning: cc: error: ../../src/llvm-project/libunwind/src/Unwind-EHABI.cpp: No such file or directory
warning: cc: fatal error: no input files
warning: compilation terminated.

error: failed to run custom build command for `unwind v0.0.0 (/nix/rust/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/unwind)`

Caused by:
  process didn't exit successfully: `/tmp/rustexp/koo/target/release/build/unwind-3ba23c349fd7fbd4/build-script-build` (exit code: 1)
  --- stdout
  cargo:rerun-if-changed=build.rs
  cargo:rustc-link-search=native=/tmp/rustexp/koo/target/x86_64-unknown-linux-musl/release/build/unwind-030b776e200555ef/out
  CC_x86_64-unknown-linux-musl = None
  CC_x86_64_unknown_linux_musl = None
  TARGET_CC = None
  CC = None
  CROSS_COMPILE = None
  CFLAGS_x86_64-unknown-linux-musl = None
  CFLAGS_x86_64_unknown_linux_musl = None
  TARGET_CFLAGS = None
  CFLAGS = None
  CRATE_CC_NO_DEFAULTS = None
  CARGO_CFG_TARGET_FEATURE = Some("fxsr,mmx,sse,sse2")
  running: "musl-gcc" "-Os" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "../../src/llvm-project/libunwind/include" "-std=c99" "-std=c++11" "-nostdinc++" "-fno-exceptions" "-fno-rtti" "-fstrict-aliasing" "-funwind-tables" "-fvisibility=hidden" "-D__LITTLE_ENDIAN__=1" "-D_LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS" "-o" "/tmp/rustexp/koo/target/x86_64-unknown-linux-musl/release/build/unwind-030b776e200555ef/out/../../src/llvm-project/libunwind/src/Unwind-EHABI.o" "-c" "../../src/llvm-project/libunwind/src/Unwind-EHABI.cpp"
  cargo:warning=cc: error: ../../src/llvm-project/libunwind/src/Unwind-EHABI.cpp: No such file or directory
  cargo:warning=cc: fatal error: no input files
  cargo:warning=compilation terminated.
  exit code: 1

  --- stderr


  error occurred: Command "musl-gcc" "-Os" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-I" "../../src/llvm-project/libunwind/include" "-std=c99" "-std=c++11" "-nostdinc++" "-fno-exceptions" "-fno-rtti" "-fstrict-aliasing" "-funwind-tables" "-fvisibility=hidden" "-D__LITTLE_ENDIAN__=1" "-D_LIBUNWIND_DISABLE_VISIBILITY_ANNOTATIONS" "-o" "/tmp/rustexp/koo/target/x86_64-unknown-linux-musl/release/build/unwind-030b776e200555ef/out/../../src/llvm-project/libunwind/src/Unwind-EHABI.o" "-c" "../../src/llvm-project/libunwind/src/Unwind-EHABI.cpp" with args "musl-gcc" did not execute successfully (status code exit code: 1).


warning: build failed, waiting for other jobs to finish...
error: could not find native static library `c`, perhaps an -L flag is missing?

error: aborting due to previous error

error: build failed

Why unwind? I specified that panic aborts. Can all the stack trickery be completely opted out?

created time in a month

pull request commentnix-rust/nix

Added clock_gettime, clock_getres, clock_settime, clock_getcpuclockid

On a side note, once rust-lang/libc#1891 gets into new release the unsafe blocks and allow(unused_unsafe) won't be needed anymore.

allow(unused_unsafe) with unsafe blocks can still be beneficial to extend the range of supported libc versions.

xonatius

comment created time in a month

issue commentjsdw/weave

Support HTTPS sources

Is this going to be implemented?

What is maintainership status of weave in general?

jsdw

comment created time in a month

pull request commentnix-rust/nix

Add allow(unused_unsafe) to some functions.

Is this pull request still needed in face of #1281 which supposedly also includes similar changes?

vi

comment created time in a month

push eventvi/nix

Vitaly _Vi Shukela

commit sha 4db701dafedf6dacce465bb90d4594628b67dbf8

Adapt for safe-isation of some libc functions. (https://github.com/rust-lang/libc/pull/1870) Denied lint being overridden instead of unsafe block removed to preserve compatibility with old `libc` versions.

view details

push time in a month

Pull request review commentnix-rust/nix

Relax overly strict deny(unused) policy.

 #![cfg_attr(test, deny(warnings))] #![recursion_limit = "500"] #![deny(unused)]+#![allow(unused_unsafe)]

Why a point release? Shouldn't lint caps hide those errors when nix is used as a crates.io dependency?

vi

comment created time in a month

PullRequestReviewEvent

Pull request review commentnix-rust/nix

Relax overly strict deny(unused) policy.

 #![cfg_attr(test, deny(warnings))] #![recursion_limit = "500"] #![deny(unused)]+#![allow(unused_unsafe)]

I expect it to be this.

Shall it be fixed just for for this use case or also for possible future unsafe-to-safe conversions?

Shall it be fixed by just removing unsafe{} or by allowing unused_unsafe selectively?

vi

comment created time in a month

PullRequestReviewEvent

issue commentjonathandturner/rhai

Use cargo features additively.

I tried but it wasn't easy.

Maybe it can be done gradually, starting from some one feature?

Is there some statistics of how Rhai is used (especially in libraries), which features are typically enabled and where absense of features are really required?

You told that Rhai is sometimes used as math expression evaulator in some libraries (as far as I understood). Which of reverse dependencies are worth revieing? Are there known projects that are not on crates.io?

vi

comment created time in a month

pull request commentnix-rust/nix

Mark nix::unistd::fork as unsafe.

It not caused by the changed code, it's just master brach is not buildable anymore.

I submitted a separate pull request with an easy way to fix it: #1294.

vi

comment created time in a month

pull request commentnix-rust/nix

Relax overly strict deny(unused) policy.

Or shall a bunch of unsafe{} blocks be removed instead? Will it cause incompatibilities for users with legacy rustc or deps?

vi

comment created time in a month

push eventvi/nix

Vitaly _Vi Shukela

commit sha df9b44e8038992df43a662fb69018ca44f040181

#![allow(unused_unsafe)] Make exception from `#![deny(unused)]` rule.

view details

push time in a month

PR opened nix-rust/nix

Relax overly strict deny(unused) policy.
+0 -0

0 comment

0 changed file

pr created time in a month

push eventvi/nix

Vitaly _Vi Shukela

commit sha a401dd2ab330cbd7167af23b73f7e2fb0ac1bccd

A neutral commit to trigger Travis build

view details

push time in a month

create barnchvi/nix

branch : overstrict_deny_unused

created branch time in a month

pull request commentnix-rust/nix

Mark nix::unistd::fork as unsafe.

Added changelog entry.

vi

comment created time in a month

push eventvi/nix

Vitaly _Vi Shukela

commit sha 59583686c2d7e1db89092ebed305cef47bf9a8c1

Add CHANGELOG.md entry about unsafe fork.

view details

push time in a month

issue commentjonathandturner/rhai

Use cargo features additively.

But this way it is very hard to remove the code if you don't need it.

What about things like


pub trait RhaiFeatures {
    const ENABLE_FLOATS : bool = true;
    const ENABLE_OPTIMIZE: bool = true;
    ...
}

impl<F:RhaiFeatures> Something<F> {
    pub fn do_something() {
         if F::ENABLE_FLOATS {
             heavyweight_function();
         }
    }
}

Does it provide enough assurance that heavyweight_function is really not inclued?


Maybe a fork/branch of Rhai with experimental feature selection revamp should be created?

vi

comment created time in a month

issue commentnix-rust/nix

Shall safety status of `unistd::fork` be the same as std's `Process::pre_exec`?

@asomers, Make the pull request.

vi

comment created time in a month

push eventvi/nix

Vitaly _Vi Shukela

commit sha e46ce3c3455fe574078da144b0c64f43ffb7f093

Mark nix::unistd::fork as unsafe. Fix tests. No change in documentation. Resolves #1030.

view details

push time in a month

pull request commentnix-rust/nix

Mark nix::unistd::fork as unsafe.

r? @asomers

vi

comment created time in a month

PR opened nix-rust/nix

Mark nix::unistd::fork as unsafe.

Fix tests. No change in documentation.

Resolves #1030.

Don't forget to bump major version number to 0.19.

+12 -12

0 comment

5 changed files

pr created time in a month

create barnchvi/nix

branch : unsafe_fork

created branch time in a month

issue commentnix-rust/nix

Shall safety status of `unistd::fork` be the same as std's `Process::pre_exec`?

Why is it still not marked unsafe?

Is it just missing a pull request that adds unsafe to the function and unsafe { } to the tests?

vi

comment created time in a month

issue commentjonathandturner/rhai

Use cargo features additively.

A library pulling in Rhai with while-loop set will conflict with other code that doesn't require it. In other words, it does harm. The other code that doesn't set while-loop will expect the while statement to throw a syntax error.

It may be solved by double check: a library which wants to fine tune which parts of Rhai it wants does two things:

  1. Includes appropriate Cargo feature
  2. Enables the keywords using in-code configuration (runtime or compiletime)

This way two Rhai engines: the one with while identifier and the other one with while keyword can coexist.


will expect the while statement to throw a syntax error

I think relying on things being syntax errors is not future-proof anyway. It is like relying on optimisation removing bad code.

vi

comment created time in a month

issue commentjonathandturner/rhai

Use cargo features additively.

The only way is to exclude those code with compile-time config switches.

Or usage of compile-time evaluation (const functions) and optimisation (including whole-program fat LTO). String formatting and panicking code is often excluded this way when doing embedded.

vi

comment created time in a month

issue commentjonathandturner/rhai

Use cargo features additively.

It is technically not intended to be used to model pre-requisits.

I don't understand this phrase.

Do you consider Tokio's usage of feature flags an intended use case of Cargo features?

vi

comment created time in a month

issue commentjonathandturner/rhai

Use cargo features additively.

Libraries may want to exclude feature to minimize code bloat even if otherwise it is no problem to leave feature enabled.

I expect sync and no-sync to be the biggest problem. Some libraries publish even two crates because of that. Example: im im-rc.

vi

comment created time in a month

issue commentjonathandturner/rhai

Use cargo features additively.

Do you plan leaving the "Rhai v1.0" with cargo features usage still unfixed?

What does mean "for the time being" and how does it interact woth "wontfix" label?

Or maybe adjusting feature completeness vs compactness will be moved away from Cargo features to e.g. plugins? (can it handle sync and !sync engines within the same project?)

vi

comment created time in 2 months

issue commentvi/read_write_at

ReadAt/WriteAt for File on windows

  1. Simply impl ReadAt/WriteAt for File Could be hidden behind an opt-in feature?

How is the documentation supposed to look like in this case? Shall this impl be missing from docs.rs?

MaulingMonkey

comment created time in 2 months

issue commentvi/read_write_at

ReadAt/WriteAt for File on windows

Note that hard coded io::Result in trait methods is going to be refactored into a associated type in version 0.2.

Would it cause inconvenience for you?

MaulingMonkey

comment created time in 2 months

issue commentvi/read_write_at

ReadAt/WriteAt for File on windows

If IO: Read + Seek + Send is OK then maybe IO: ReadAtMut would also be OK?

MaulingMonkey

comment created time in 2 months

push eventvi/timeago

Vitaly _Vi Shukela

commit sha 57804ad2c7abfefaf735310242e815c87635f266

README.md

view details

push time in 2 months

issue commentvi/websocat

how to send message to websocket

winsocket

WebSocket

Sec-WebSocket-Key:

WebSocat should automatically generate this field, no need to manually specify it.

Authorization: Bearer w5...

Note that this is now a published information. You should change credentials.

mmm286

comment created time in 2 months

issue commentvi/websocat

how to send message to websocket

-vv

What diagnostic messages does it output?

I'm trying to send message with command line with websocat but I can't see that message arrives

Is receiving works?


Another debugging command to try:

echo "0j281nwq9mjysddsfsd" | ./websocat_arm-linux-static -t -H "'Sec-WebSocket-Protocol: xmpp" -H "Sec-WebSocket-Key: EOuQ0Dgwvs53p1Vhb/tjyA==" --ws-c-uri=wss://mongooseimprotool-prod.wallapop.com/ws-xmpp - ws-connect:sh-c:'socat -v -x - ssl:mongooseimprotool-prod.wallapop.com:443,verify=0'

This needs socat programm to be installed. For me it outputs:

> 2020/09/06 19:40:31.046116  length=212 from=0 to=211
 47 45 54 20 2f 77 73 2d 78 6d 70 70 20 48 54 54  GET /ws-xmpp HTT
 50 2f 31 2e 31 0d 0a                             P/1.1..
 27 53 65 63 2d 57 65 62 53 6f 63 6b 65 74 2d 50  'Sec-WebSocket-P
 72 6f 74 6f 63 6f 6c 3a 20 78 6d 70 70 0d 0a     rotocol: xmpp..
 53 65 63 2d 57 65 62 53 6f 63 6b 65 74 2d 4b 65  Sec-WebSocket-Ke
 79 3a 20 36 4b 58 77 61 65 6d 50 76 67 64 50 4a  y: 6KXwaemPvgdPJ
 6c 2b 4e 4d 67 6f 70 33 41 3d 3d 0d 0a           l+NMgop3A==..
 48 6f 73 74 3a 20 6d 6f 6e 67 6f 6f 73 65 69 6d  Host: mongooseim
 70 72 6f 74 6f 6f 6c 2d 70 72 6f 64 2e 77 61 6c  protool-prod.wal
 6c 61 70 6f 70 2e 63 6f 6d 0d 0a                 lapop.com..
 43 6f 6e 6e 65 63 74 69 6f 6e 3a 20 55 70 67 72  Connection: Upgr
 61 64 65 0d 0a                                   ade..
 55 70 67 72 61 64 65 3a 20 77 65 62 73 6f 63 6b  Upgrade: websock
 65 74 0d 0a                                      et..
 53 65 63 2d 57 65 62 53 6f 63 6b 65 74 2d 56 65  Sec-WebSocket-Ve
 72 73 69 6f 6e 3a 20 31 33 0d 0a                 rsion: 13..
 0d 0a                                            ..
--
< 2020/09/06 19:40:31.288249  length=159 from=0 to=158
 48 54 54 50 2f 31 2e 31 20 31 30 31 20 53 77 69  HTTP/1.1 101 Swi
 74 63 68 69 6e 67 20 50 72 6f 74 6f 63 6f 6c 73  tching Protocols
 0d 0a                                            ..
 63 6f 6e 6e 65 63 74 69 6f 6e 3a 20 55 70 67 72  connection: Upgr
 61 64 65 0d 0a                                   ade..
 53 65 63 2d 57 65 62 53 6f 63 6b 65 74 2d 50 72  Sec-WebSocket-Pr
 6f 74 6f 63 6f 6c 3a 20 78 6d 70 70 0d 0a        otocol: xmpp..
 75 70 67 72 61 64 65 3a 20 77 65 62 73 6f 63 6b  upgrade: websock
 65 74 0d 0a                                      et..
 73 65 63 2d 77 65 62 73 6f 63 6b 65 74 2d 61 63  sec-websocket-ac
 63 65 70 74 3a 20 42 79 39 43 73 63 73 75 53 75  cept: By9CscsuSu
 72 42 48 77 72 55 44 4b 68 57 7a 51 6c 33 30 6b  rBHwrUDKhWzQl30k
 63 3d 0d 0a                                      c=..
 0d 0a                                            ..
--
> 2020/09/06 19:40:31.290830  length=32 from=212 to=243
 81 94 ca 74 0c e1 fa 1e 3e d9 fb 1a 7b 90 f3 19  ...t....>...{...
 66 98 b9 10 68 92 ac 07 68 eb 88 80 bd 07 9b c4  f...h...h.......
--
< 2020/09/06 19:40:31.515627  length=2 from=159 to=160
 88 00                                            ..
--

This shows that someting is being sent to server after connecting.

mmm286

comment created time in 2 months

issue commentjonathandturner/rhai

Use cargo features additively.

Than should Rhai be explicitly documented against usage as a private (internal) dependency in libraries?

Something like "Don't use Rhai in libraries. Rhai as a language is sensitive to the chosen Cargo feature set and is expected to appear only once in a project's dependency tree. Internal Rhai dependency may introduce unwanted Rhai feature switches or be confused by activating unwanted switches from neighbouring Rhai dependency inclusion".

vi

comment created time in 2 months

issue commentvi/websocat

add cookies with websocat

Currently you need to manually translate curl -b to equivalent curl -H, then use Websocat's -H option.

If there is enough popular demand for this feature, I can implement a --cookie parameter that does curl-like mapping to -H within Websocat (short name -b is busy).

mmm286

comment created time in 2 months

issue commentmpv-android/mpv-android

0% brigtness higher than 1%.

The 0% vs 1% problem is not always reproducible.

vi

comment created time in 2 months

issue commentvi/websocat

How could I install websocat in raspbian (raspberry)?

Does this executable work for you?

mmm286

comment created time in 2 months

issue openedmpv-android/mpv-android

Shall hardware/software decode be moved to "Advanced" popup?

For me typically hardware decoding always works, so it just takes up button space.

Ideally UI should be a bit customisable, allowing to select which adjustments to promote to quick access buttons and which leave in advanced window. For example, for some broken videos you need to constrantly readjust A/V delay (or subtitle delay) for it to remain in sync.

created time in 2 months

more