profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/velrest/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Jonas Cosandey velrest @adfinis-sygroup Switzerland

johnfrancisgit/IOT_hue 0

Scripts to manipulate phillips hue lights based on various sensor inputs.

velrest/.atom-DEPRECATED 0

My personal Atom configuration

velrest/.i3-DEPRECATED 0

My Personal i3 configuration

velrest/.vim-DEPRECATED 0

My Personal vim configuration

velrest/ale 0

Check syntax in Vim asynchronously and fix files, with Language Server Protocol (LSP) support

velrest/alexandria 0

Document management service

velrest/balsamik.kak 0

A simple WIP file navigator for kakoune heavily inspired by vim's netrw and tpope/vim-vinegar

velrest/caluma-portal-demo 0

A demo app to showcase caluma in an building permit scenario

velrest/charts 0

helm charts for caluma

PullRequestReviewEvent

Pull request review commentadfinis-sygroup/ember-ebau-gwr

fix(building): make default building entrance editable

 export default class BuildingFormController extends Controller {       yield this.fetchBuilding.perform();        if (this.model.buildingWork?.isNew) {-        return this.model.buildingWork;+        console.log("this.building.newRecord:", this.buildingAPI.newRecord);+        return this.buildingAPI.newRecord+          ? this.buildingAPI.newRecord+          : this.model.buildingWork;
        return this.buildingAPI.newRecord ?? this.model.buildingWork;
luytena

comment created time in a day

Pull request review commentadfinis-sygroup/ember-ebau-gwr

fix(building): make default building entrance editable

 export default class BuildingEntrance extends XMLModel {    static template = `   {{#if model.isNew}}-    {{#if model.buildingEntranceNo}}-      <ns2:buildingEntranceNo>{{model.buildingEntranceNo}}</ns2:buildingEntranceNo>-    {{/if}}-    <ns2:isOfficialAddress>{{model.isOfficialAddress}}</ns2:isOfficialAddress>-    {{> Street model=model.street}}-    {{> Locality model=model.locality}}+    <ns2:buildingEntrance>

Api doesnt like <ns2:buildingEntrance on most request types

luytena

comment created time in a day

Pull request review commentadfinis-sygroup/ember-ebau-gwr

fix(building): make default building entrance editable

 import Route from "@ember/routing/route";+import { inject as service } from "@ember/service"; -export default class BuildingEditIndexRoute extends Route {}+export default class BuildingEditIndexRoute extends Route {+  @service building;++  model() {+    // reset the newRecord+    console.log("model buidling");+    this.building.newRecord = null;

Would be nice if this were in beforeModel since the model hooks is just for "fetching" model data

luytena

comment created time in a day

Pull request review commentadfinis-sygroup/ember-ebau-gwr

fix(building): make default building entrance editable

 export default class BuildingFormController extends Controller {   getChangeHint(currentStatus, newStatus) {     return this.buildingAPI.getChangeHint(currentStatus, newStatus);   }++  @action+  updateEntrance(key, value) {+    console.log("kv:", key, value);+    set(this.buildingWork.building.buildingEntrance[0], key, value);

Maybe comment about key beeing a dot-propertybalbal

luytena

comment created time in a day

Pull request review commentadfinis-sygroup/ember-ebau-gwr

fix(building): make default building entrance editable

 export default class Building extends XMLModel {     {{/if}}      {{#if model.isNew}}-      <ns2:buildingEntrance>-        <ns2:buildingEntranceNo>4</ns2:buildingEntranceNo>-        <ns2:locality>-          <ns2:name>-            <ns2:nameLong>{{model.municipalityName}}</ns2:nameLong>-          </ns2:name>-        </ns2:locality>-      </ns2:buildingEntrance>+      {{#each model.buildingEntrance}}+        {{> BuildingEntrance model=this}}

Please comment :smile:

luytena

comment created time in a day

Pull request review commentadfinis-sygroup/ember-ebau-gwr

fix(building): make default building entrance editable

 export default class BuildingEntrance extends XMLModel {    static template = `   {{#if model.isNew}}-    {{#if model.buildingEntranceNo}}-      <ns2:buildingEntranceNo>{{model.buildingEntranceNo}}</ns2:buildingEntranceNo>-    {{/if}}-    <ns2:isOfficialAddress>{{model.isOfficialAddress}}</ns2:isOfficialAddress>-    {{> Street model=model.street}}-    {{> Locality model=model.locality}}+    <ns2:buildingEntrance>+      {{#if model.buildingEntranceNo}}

{{{modelField...}}}

luytena

comment created time in a day

Pull request review commentadfinis-sygroup/ember-ebau-gwr

fix(building): make default building entrance editable

 export default class BuildingEditEntranceLinkStreetController extends Controller   }    get backRoute() {+    console.log("buildingId:", this.model.buildingId);+    if (this.model.buildingId === "new") {+      return "building.new";+    }+     return `building.edit.entrance.${       this.buildingEntrance.newRecord ? "new" : "edit.index"     }`;   } +  get backRouteLabel() {+    return this.intl.t(this.model.buildingId === "new"+      ? "ember-gwr.buildingEntrance.backToBuilding"+      : "ember-gwr.buildingEntrance.backToEntrance");
    return this.intl.t(`ember-gwr.buildingEntrance.${
      this.model.buildingId === "new"
        ? "backToBuilding"
        : "backToEntrance"
      }`);
luytena

comment created time in a day

PullRequestReviewEvent

Pull request review commentadfinis-sygroup/ember-ebau-gwr

fix(building): make default building entrance editable

+import Component from "@glimmer/component";+import Models from "ember-ebau-gwr/models";++export default class LinkStreetComponent extends Component {+  Models = Models;
import Street from "ember-ebau-gwr/models/street";

export default class LinkStreetComponent extends Component {
  Street = Street;
luytena

comment created time in a day

push eventluytena/ember-ebau-gwr

Alana Luyten

commit sha e2924592ac0eca51a5b72927c71963fea5e1e02c

feat: add import for buildings, entrances & dwellings Enable buildings, entrances & dwellings to be imported from caluma data. If multiple objects are available, a modal is provided to select and import one of the models.

view details

push time in a day

push eventluytena/ember-ebau-gwr

Alana Luyten

commit sha 95b035b0fdae5e2ac02ecf0c897593f711311fc3

feat: add import for buildings, entrances & dwellings Enable buildings, entrances & dwellings to be imported from caluma data. If multiple objects are available, a modal is provided to select and import one of the models.

view details

push time in a day

push eventluytena/ember-ebau-gwr

Alana Luyten

commit sha 1b498403e0a38684ce4033f27e3eb57bbb67047c

feat: add import for buildings, entrances & dwellings Enable buildings, entrances & dwellings to be imported from caluma data. If multiple objects are available, a modal is provided to select and import one of the models.

view details

push time in a day

issue openedadfinis-sygroup/ember-ebau-gwr

Delete building entrances

Currently, entrances cannot be deleted. To implement we need to display the error message returned by the api if there are still linked dwellings.

created time in 2 days

push eventadfinis-sygroup/ember-ebau-gwr

Alana Luyten

commit sha 65f5265ce8b010fb13933bc808b8cb510272feb0

fix(ui): render tooltips in correct application container Render tooltips in correct application container. Fixes integration issue with camac-ng.

view details

push time in 2 days

PR merged adfinis-sygroup/ember-ebau-gwr

fix(ui): render tooltips in correct application container

Render tooltips in correct application container. Fixes integration issue with camac-ng.

+16 -3

0 comment

6 changed files

luytena

pr closed time in 2 days

push eventluytena/ember-ebau-gwr

Alana Luyten

commit sha ab7df83431bab62c0c2edf8b3d5850ce2ff18956

fix(import): ignore null values in import data

view details

Alana Luyten

commit sha b73d6a5dafd6984ebba548abc7e68c67734d74a1

fix(model-form): ensure date values are reset on model update

view details

Jonas Cosandey

commit sha 4f3778fd0d9a358a3cb58acf6aab7bb92d1e7b0c

Merge branch 'main' into fix-tooltip-container

view details

push time in 2 days

PullRequestReviewEvent

push eventadfinis-sygroup/ember-ebau-gwr

Alana Luyten

commit sha b73d6a5dafd6984ebba548abc7e68c67734d74a1

fix(model-form): ensure date values are reset on model update

view details

push time in 2 days

push eventluytena/ember-ebau-gwr

Alana Luyten

commit sha ab7df83431bab62c0c2edf8b3d5850ce2ff18956

fix(import): ignore null values in import data

view details

Jonas Cosandey

commit sha 42a993de4cb8bb5adba6c43f138e5960c39640d7

Merge branch 'main' into fix-reset-dates

view details

push time in 2 days

push eventadfinis-sygroup/ember-ebau-gwr

Alana Luyten

commit sha ab7df83431bab62c0c2edf8b3d5850ce2ff18956

fix(import): ignore null values in import data

view details

push time in 2 days

push eventluytena/ember-ebau-gwr

Alana Luyten

commit sha bca5f83ca15f5a5311a86471a9ce9144a31e3bf0

fix(project): replace non-realisation date with cancellation date The API returns the cancellation date instead of the non- realisation date. All references to that field are updated accordingly.

view details

Jonas Cosandey

commit sha 106f486440dd8c10b145fde246a446da5545b1ca

Merge branch 'main' into fix-reset-dates

view details

push time in 2 days

PullRequestReviewEvent

push eventluytena/ember-ebau-gwr

Alana Luyten

commit sha bca5f83ca15f5a5311a86471a9ce9144a31e3bf0

fix(project): replace non-realisation date with cancellation date The API returns the cancellation date instead of the non- realisation date. All references to that field are updated accordingly.

view details

Jonas Cosandey

commit sha 1968cd672aeef74cea14669921fc7d192a225d18

Merge branch 'main' into fix-invalid-import-values

view details

push time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent