profile
viewpoint
Aliaksandr Valialkin valyala @VictoriaMetrics Kyiv https://victoriametrics.com Working on @VictoriaMetrics

valyala/fasthttp 13994

Fast HTTP package for Go. Tuned for high performance. Zero memory allocations in hot paths. Up to 10x faster than net/http

valyala/fastjson 1069

Fast JSON parser and validator for Go. No custom structs, no code generation, no reflection

valyala/gorpc 618

Simple, fast and scalable golang rpc library for high load

valyala/fasttemplate 455

Simple and fast template engine for Go

valyala/bytebufferpool 440

Anti-memory-waste byte buffer pool

valyala/goloris 276

Slowloris for nginx DoS. Written in go

valyala/gozstd 257

go wrapper for zstd

valyala/fastrand 111

Fast and scalable pseudorandom generator for Go

valyala/gheap 104

Fast generalized heap tree algorithms in C++ and C. Provides simultaneous support for D-heap and B-heap.

valyala/fastrpc 74

Building blocks for fast rpc systems

pull request commentVictoriaMetrics/helm-charts

Update documentation of charts using 'helm-docs' command. See CONTRIB…

Thank you for contribution!

aeciopires

comment created time in 2 hours

push eventVictoriaMetrics/helm-charts

Aecio Pires

commit sha c8bd752ba3195941b6d3b0203a87c12592f2106b

Update documentation of charts using 'helm-docs' command. See CONTRIBUTING.md file

view details

push time in 2 hours

PR merged VictoriaMetrics/helm-charts

Update documentation of charts using 'helm-docs' command. See CONTRIB…

What was done?

Update documentation of charts using 'helm-docs' command. See CONTRIBUTING.md file.

Why was it done?

To update documentation of all charts using helm-docs command. See CONTRIBUTING.md file.

Ref: https://github.com/norwoodj/helm-docs

+9 -9

1 comment

6 changed files

aeciopires

pr closed time in 2 hours

pull request commentVictoriaMetrics/helm-charts

updates operator chart,

Done, thanks for pointing, it seems like, we need some github action with linting.

Something like:

helm-docs
docs_is_clean=$(git status -uno --porcelain)
[[ ! -z $docs_is_clean ]] && echo "apply helm-docs to charts $docs_is_clean" &&  exit 1
f41gh7

comment created time in 2 hours

push eventVictoriaMetrics/helm-charts

f41gh7

commit sha 339f89893a2c1f69fbbefb1c89b249bf8c3870d5

applied helm-docs formatting

view details

push time in 3 hours

issue commentvalyala/fasthttp

optimizing fasthttp

ok, what will the client see if the server reaches max number of connections?

Arnold1

comment created time in 3 hours

startedvalyala/fasthttp

started time in 3 hours

pull request commentVictoriaMetrics/VictoriaMetrics

dashboard: Prometheus compatibility fix for `Storage full ETA` panel

Codecov Report

Merging #938 (928c63b) into master (ae1db8f) will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   60.95%   60.93%   -0.03%     
==========================================
  Files         201      201              
  Lines       22673    22673              
==========================================
- Hits        13821    13815       -6     
- Misses       7541     7544       +3     
- Partials     1311     1314       +3     
Impacted Files Coverage Δ
app/vmalert/remotewrite/remotewrite.go 58.49% <0.00%> (-1.89%) :arrow_down:
lib/mergeset/table.go 65.68% <0.00%> (-0.32%) :arrow_down:
lib/storage/partition.go 68.38% <0.00%> (-0.26%) :arrow_down:
lib/storage/index_db.go 63.96% <0.00%> (-0.11%) :arrow_down:
lib/decimal/decimal.go 94.14% <0.00%> (+0.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ae1db8f...928c63b. Read the comment docs.

hagen1778

comment created time in 4 hours

create barnchVictoriaMetrics/VictoriaMetrics

branch : cluster-dash-eta

created branch time in 4 hours

create barnchVictoriaMetrics/VictoriaMetrics

branch : single-dash-eta

created branch time in 4 hours

Pull request review commentVertamedia/chproxy

fix get query from body of GET request

 func testCanCacheQuery(t *testing.T, q string, expected bool) { }  func TestGetQuerySnippetGET(t *testing.T) {-	req, err := http.NewRequest("GET", "", nil)+	req, err := http.NewRequest("GET", "", bytes.NewBuffer(nil))

True, didn't know about that. However, I still find it useful to check object for not being nil before calling its methods. I think, it makes code more robust. Otherwise, you'll need to explain in this test why it is required to path non-nil body for GET request.

tochka

comment created time in 4 hours

pull request commentVictoriaMetrics/helm-charts

updates operator chart,

Hi @f41gh7!

I agree with the changes and improvements made.

In CONTRIBUTING.md file has instructions for install helm-docs command to update documentation and update table with new values.

... Install the follow packages: git, kubectl, helm, helm-docs. See this tutorial...

and

...Run command helm-docs to update content of README.md file using the README.md.gotmpl template...

Can you execute these instructions?

f41gh7

comment created time in 4 hours

pull request commentVictoriaMetrics/helm-charts

Update documentation of charts using 'helm-docs' command. See CONTRIB…

Hi @valyala and @artemsre!

Can you review this Pull Request?

I suggest running the helm-docs command at the root of the helm-charts directory whenever changes are made to a Chart.yaml and / or values.yaml file.

It is very simple to keep the doc up to date. This command uses the contents of the README.md.gotmpl file to parse and generate the README.md file for each chart. See CONTRIBUTING.md file.

aeciopires

comment created time in 4 hours

PR opened VictoriaMetrics/helm-charts

Update documentation of charts using 'helm-docs' command. See CONTRIB…

What was done?

Update documentation of charts using 'helm-docs' command. See CONTRIBUTING.md file.

Why was it done?

To update documentation of all charts using helm-docs command. See CONTRIBUTING.md file.

Ref: https://github.com/norwoodj/helm-docs

+9 -9

0 comment

6 changed files

pr created time in 4 hours

issue commentvalyala/fasthttp

optimizing fasthttp

Normally you will have one goroutine per connection.

You could use Server.Concurrency to limit the number of concurrent connections. Once the max number of connections is reached new connections will be closed without reading the request or writing a response.

Arnold1

comment created time in 5 hours

issue openedvalyala/fasthttp

optimizing fasthttp

Hi,

I currently see about 500 open connections and between 500 and 1400 go routines. go_gc_duration_seconds (quaintly 1) = 12ms

It looks like a new go routine is created a a request in fasthttp.

what happens if too many requests are received by the server? I know it also depends on the number of concurrent requests etc. how to deal with that? should you limit the number of go routines in that case, any other ideas?

Thanks, Arnold

created time in 6 hours

push eventpatsevanton/victoriametrics-rpm

Anton Patsev

commit sha 1013a815da7e0823a53d115caa1e00d800a8acf1

v1.49.0

view details

push time in 9 hours

startedvalyala/fasthttp

started time in 10 hours

startedvalyala/quicktemplate

started time in 11 hours

pull request commentVictoriaMetrics/operator

In PrometheusConverter in created objects include ownerReferences

@f41gh7 thanks for devoting your time to this PR and generally thanks for you work!

teqwve

comment created time in 11 hours

issue commentvalyala/httpteleport

it's working with teleports now after i modified the code to disable detection of domain name using self signed cert

i realised POST request header is empty when using httptp. how do i resolve this?

gitmko0

comment created time in 12 hours

issue openedvalyala/httpteleport

it's working with teleports now after i modified the code to disable detection of domain name using self signed cert

i'm getting Status Code 403 from nginx<->php7.4 for wordpress

user <-> httptpS <-----------> httptpS <-> nginx <-> wordpress

only for a post method, the returned async response i get status 403. the rest of the get / post method seems fine.

this happens when i try to upload an image to wordpress

error msg from wordpress: Post-processing of the image failed likely because the server is busy or does not have enough resources. Uploading a smaller image may help. Suggested maximum size is 2500 pixels. Reponse header...

Request Method: POST Status Code: 403 Remote Address: 123.123.123.123:443 Referrer Policy: strict-origin-when-cross-origin

how do i resolve this? what am i missing?

created time in 13 hours

startedvalyala/fasthttp

started time in 14 hours

Pull request review commentvalyala/fasthttp

Add test cases for StreamRequestBody

 func TestMaxBodySizePerRequest(t *testing.T) { 	} } +func TestStreamRequestBody(t *testing.T) {+	t.Parallel()++	part1 := strings.Repeat("1", 1<<10)+	part2 := strings.Repeat("2", 1<<20-1<<10)+	contentLength := len(part1) + len(part2)+	next := make(chan struct{})+	done := make(chan struct{})++	s := &Server{+		Handler: func(ctx *RequestCtx) {+			checkReader(t, ctx.RequestBodyStream(), part1)+			close(next)+			<-done

Instead of adding the done channel I think it's probably a better idea to add a sync.Mutex to readWriter to make its operations safe just like reading and writing on a normal socket would be.

kiyonlin

comment created time in 17 hours

startedvalyala/fasthttp

started time in 19 hours

startedvalyala/fasthttp

started time in 20 hours

startedvalyala/httpteleport

started time in a day

issue closedVictoriaMetrics/operator

Pod can not start on OpenShift 4.5.18

The operator can not start OpenShift 4.5.18. Error message

{"level":"error","ts":1606717363.033731,"logger":"controller_vmcluster","msg":"cannot update or create vmcluster","Request.Namespace":"monitoring-system","Request.Name":"example-vmcluster-persistent","error":"cannot create new vmstorage sts: statefulsets.apps \"vmstorage-example-vmcluster-persistent\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\tgithub.com/go-logr/zapr@v0.1.0/zapr.go:128\ngithub.com/VictoriaMetrics/operator/controllers.(*VMClusterReconciler).Reconcile\n\tgithub.com/VictoriaMetrics/operator/controllers/vmcluster_controller.go:47\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:235\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:209\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\tsigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:188\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\tk8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\tk8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\tk8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.Until\n\tk8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:90"}
{"level":"error","ts":1606717363.0338337,"logger":"controller","msg":"Reconciler error","reconcilerGroup":"operator.victoriametrics.com","reconcilerKind":"VMCluster","controller":"vmcluster","name":"example-vmcluster-persistent","namespace":"monitoring-system","error":"cannot create new vmstorage sts: statefulsets.apps \"vmstorage-example-vmcluster-persistent\" is forbidden: cannot set blockOwnerDeletion if an ownerReference refers to a resource you can't set finalizers on: , <nil>","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\tgithub.com/go-logr/zapr@v0.1.0/zapr.go:128\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler\n\tsigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:237\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem\n\tsigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:209\nsigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).worker\n\tsigs.k8s.io/controller-runtime@v0.6.2/pkg/internal/controller/controller.go:188\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1\n\tk8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:155\nk8s.io/apimachinery/pkg/util/wait.BackoffUntil\n\tk8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:156\nk8s.io/apimachinery/pkg/util/wait.JitterUntil\n\tk8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:133\nk8s.io/apimachinery/pkg/util/wait.Until\n\tk8s.io/apimachinery@v0.18.6/pkg/util/wait/wait.go:90"}

Pods status

NAME                                      READY   STATUS    RESTARTS   AGE
vm-operator-6c566dfb76-pwp86              1/1     Running   1          4d19h
vm-operator-vm-operator-854f4c5c8-r95c8   1/1     Running   0          4d19h

Probably issue related with OCP RBAC Happy to provide more information if required.

closed time in a day

mancubus77
more