profile
viewpoint
Valeriy Van valeriyvan Berlin/Odessa Coding for more than 20 years, still like it.

valeriyvan/CircleGestureRecognizer 10

Example iOS app demonstrating how Circle Gesture Recogniser is working

valeriyvan/BadooOverviewAssignment 2

Code test for iOS developer position at Badoo

valeriyvan/AZTransition 1

API to make great custom transitions in one method

valeriyvan/DJIVideoPreviewer 1

DJI Video Previewer

valeriyvan/Aerial 0

Apple TV Aerial Screensaver for Mac

valeriyvan/amber-framework 0

an open source Objective-C framework including useful categories and other utilities, for Mac and iPhone OS

valeriyvan/anyline-ios-swift-demo 0

This is a small demo example how to use the AnylineSDK with swift

valeriyvan/anyline-ocr-examples-ios 0

Example configurations of the Anyline OCR SDK.

valeriyvan/Apodimark 0

Fast, flexible markdown parser written in Swift

PR opened rism-ch/verovio

Fix possible null pointer dereference
+4 -1

0 comment

1 changed file

pr created time in a day

create barnchvaleriyvan/verovio

branch : keySigNull

created branch time in a day

push eventvaleriyvan/verovio

Monceber

commit sha d6547ed3d3e53b61af67e445bf00e0d297b87a64

Improve layer overlap logic to work with chords - separated existing logic of overlaps for notes into new function - added check to verify if chords are in unison with each other to allow overlaps for certain unison chords - added logic for checking overlaps for stems

view details

Monceber

commit sha 74f60f1d8da59c7eb68f7078cd3c166347b49aea

Fix for layer adjustments when notes have accidentals - if note that has accidental were to be adjusted to the right - adjust it to the left instead so that it's closer to the relevant accidental

view details

Laurent Pugin

commit sha 1623616559127ef50676b0c264eac7746d39004e

Starting 3.1.0-dev

view details

amakarchuk

commit sha 967483ea05b40cfb4153e3d8c7a92de2d8fe30bb

Update handling of grace notes within beam (#1721) - updated logic of FilterList for beam to take into account notes that are in the grace groups (opposed to notes with @grace attribute) - updated logic of stem for beamed grace notes - they do not extend to the center of the system and generally should have shorter stems

view details

amakarchuk

commit sha 16c16635cd6919ade06cf55be592939c0bf2ab9b

Improve rendering of the situations when grace notes/groups collide with beams (#1722) * Adjust beams to avoid overlapping with other layer elements - added functor to adjust beam vertical positioning to avoid possible underlying elements (grace notes, beams with grace notes, keySig, etc.) * Improve beam adjustment with clefs inside beam - added separate functor to the Clef to calculate proper beam adjustments; drawing Y position of the Clef is the anchor point of the glyph and does not represent top position of the clef, hence we need to take into account a part of the height. * Adjsut clef/beam collision logic - updated conditions on which beam and clef are considered overlapping and when adjustments are needed * Fix for clef intersecting with downward beams - fixed logic to take into account correct proportions of the clef and to apply correct sign to calculation of the beam overlap when stem direction of the beam is DOWN * Minor calculation fix - slightly improved calculation of offset for the layerElements to avoid right-on-top situations

view details

Laurent Pugin

commit sha e205168220b996c1bb8be339d70e4add601f42fd

Removing doxygen warning output

view details

Laurent Pugin

commit sha 508daeb0d6b9f189e4c6962d7c54677554e012f9

Merge branch 'develop' of https://github.com/rism-ch/verovio into develop

view details

Klaus Rettinghaus

commit sha e5142827f30a51fae325addb447c7efb7b7091b5

Improving barline rendition (#1727) * add barLineSeparation to options * update DrawBarLine * add repeatBarlineDotSeparation to options * fix dots position on repeat barlines * improve barLine element * fix spelling

view details

Laurent Pugin

commit sha 92c0b5838eb247d3eace46962328a4d44ed1bbd3

Adding brackets

view details

Laurent Pugin

commit sha 25eefb9b4258debcdca54fc82c5d62b939ef2808

Commenting old code that breaks mRest positioning with scale

view details

Laurent Pugin

commit sha 7bac6e860b06f64fe21437a5a808749e80aeee95

Merge branch 'develop' of https://github.com/rism-ch/verovio into develop

view details

Laurent Pugin

commit sha 13a71d97e37c677c8cc6137168aea8c951f8beca

Develop leipzig (#1731) * add missing Schleifer and short piano pedal glyphs (#1683) * add Schleifer * adding P and S pedal glyphs * make glyphs available * validate and generate SVG * regenerate fonts * Update script that generates SMuFL metadata - changes strings to number - chang value for legerLineExtension * update font metadata (#1730) Co-authored-by: Klaus Rettinghaus <klaus.rettinghaus@gmail.com>

view details

Klaus Rettinghaus

commit sha 2c541c51e033d888dea953d87323911266e1be73

Import more IDs from MusicXML 3.1 (#1734) * improve support for MusicXML 3.1 IDs * clang-format * add support for octave@n

view details

Klaus Rettinghaus

commit sha ec9a07f28b27727aacad6bb01ac29ac72ce8eb85

update changelog

view details

Klaus Rettinghaus

commit sha 6536c39208f23e0249b250a273bb460111bdd0cd

fix octave lines across systems

view details

Craig Stuart Sapp

commit sha 1d736d60ea70ffee8fb97fd1b7dd161b91a5b3ac

Merge pull request #1736 from rettinghaus/develop fix octave lines across systems

view details

Monceber

commit sha 477bb2bb34037ef66468d7dcdbfcfc5867fa10c2

Add handling of special fermata shapes to MusicXML - added function to process double-dot, double-square, double-angeld, half-curve and curlew fermata shapes in the musicXML; these shapes are added as @glyph.num given that MEI still do not support them

view details

Klaus Rettinghaus

commit sha 7928bc6b5197ecedc04306426734fe7cb9c5eee0

Updated staff spacing calculation behaviour (#1700) * Updated staff spacing calculation behaviour - Added support of ScoreDef spacing attributes - When brace/bracket group spacing is not set fallback to staff spacing or ScoreDef spacings.. * clang-format Co-authored-by: Oleksandr Gnatenko <Oleksandr.Gnatenko@infopulse.com>

view details

Monceber

commit sha 96c1e9a711fd660a566c59f05aee37c229fcb627

Small fix for whole notes unison positioning - fixed whole notes unisons having space between them

view details

amakarchuk

commit sha 0eaf496cfdd7cb9234a8fa4333890a8d18b318d1

Beam slope improvement (#1735) * Minor fix for the beam slope - fixed mismatched stem length for notes on ledger lines (for 16th and shorter) - removed redundant variable * Beam slope improvements - rewritten previous change to used existing m_shortestDur variable - changed logic on how slope positioning was decided for 32th beams and shorter - those that have just one step difference between their notes should be horizontal instead of having really low slope * Remove redundant code * Fix grace beam stem calculation * Small fix for the beam positioningl - fixed starting position of the beam in certain cases being in between two staff lines * Revert "Small fix for the beam positioningl" This reverts commit 67a388084575e03878887f6f6df17940b2f258f9.

view details

push time in a day

PR closed apple/swift

[stdlib] adds fast path to internal func foreignErrorCorrectedGrapheme

<!-- What's in this pull request? --> Adds fast path to internal func foreignErrorCorrectedGrapheme. Addresses TODO. Eliminates redundant buffer zeroing in slow path.

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+0 -1

20 comments

1 changed file

valeriyvan

pr closed time in 2 days

pull request commentapple/swift

[stdlib] adds fast path to internal func foreignErrorCorrectedGrapheme

PR doesn't make sense anymore

valeriyvan

comment created time in 2 days

push eventvaleriyvan/swift

Antoine Cœur

commit sha 4c30f8bd6de5487603ed645cc4dd2a2983f4f0ba

appendingPathComponent(:isDirectory:) should account for isDirectory

view details

Xiaodi Wu

commit sha 26cda274ca78b1df246521ba1eeea33285b57d5f

[stdlib] Simplify 'BinaryFloatingPoint.init?<T: BinaryFloatingPoint>(exactly: T)'

view details

Mike Ash

commit sha ece0399d601eec1069131f465bdbe7e16f4c6a50

[Runtime] Have ConcurrentReadableHashMap use 1-byte or 2-byte indices when possible.

view details

Butta

commit sha 69d04aad08da3245f87c6a2df35869126d48b55e

[linux] remove absolute rpath of /usr/lib/swift/linux added to many shared libraries This was presumably added as a backup, in case the libraries in a toolchain couldn't be found, but will not work well, so take it out.

view details

Alexis Laferrière

commit sha 14e6772dc04cf778ba393bebc21a0a8b8ada3603

Consider inherited platform unavailability to silence diagnostics rdar://68597591

view details

Holly Borla

commit sha 3a47087cc197aab8970a55ee265d395bc4f6f002

[Parser] Don't resolve decl references in the parser if the declaration has a custom attribute.

view details

Holly Borla

commit sha 9b2cd5e3ffa09063a8b64250cd0c62850a41fd26

[NameLookup] Teach unqualified lookup to resolve backing property wrapper and projected value references

view details

Holly Borla

commit sha b33dbedd9b8d3dc2e6ee28373c69a24764249745

[SILGen] Teach SIlGen to emit local property wrappers

view details

Holly Borla

commit sha 0842b4212773b36778d773331155df6be20d2c21

[SILGen] Only use assign_by_wrapper for wrapped instance properties inside an initializer, and for wrapped local variables.

view details

Holly Borla

commit sha 9bd3d0b67fc9599c693735d98c6ff98defccc8e5

[Property Wrappers] Make sure captures are computed for synthesized property wrapper accessors.

view details

Holly Borla

commit sha d8df6217d32cf7ec970d67bc66ff966df0c1a671

[Property Wrappers] Allow property wrappers on local variables.

view details

Holly Borla

commit sha 21cbdfa337dfa41e108573d5d99c6259bee671c9

[Property Wrappers] Add a VarDecl helper method for visiting synthesized property wrapper vars.

view details

Arnold Schwaighofer

commit sha 8e8c57caf59f043b4046ad0df6e7c358bcac9903

SIL type lowering: Compute IsTypeExpansionSensitive and use it instead of TypeBase's hasOpaqueArchetypePropertiesOrCases A type is IsTypeExpansionSensitive if it contains an opaque result type that influences how the type is lowered. This could be because the type mentions an opaque archetype and therefore we would look through to the underlying type depending on the type expansion and could get a different SIL type. For example '() -> out some P' could lower to '() -> @out Int'. Or this could be because when we lower an aggregate type some of its fields are opaque types that could be looked through and therefore the aggregate has different lowering (e.g address vs. loadable) in different type expansion contexts. By replacing it this change also fixes an infinite recursion in hasOpaqueArchetypePropertiesOrCases. rdar://68798822

view details

Adrian Prantl

commit sha 26b5230f3c93ace3b5ad77ce36826bb5ea5da0d6

Remove stray character.

view details

Holly Borla

commit sha 2a67c651eecb6ccd6384a90961cfee46338c954e

[Property Wrappers] Generalize a few property wrapper decl context checks to check for type context instead of local context. This generalization will help us implement property wrappers on global variables, which should use the same approach of not adding synthesized accessors to the AST and instead lazily visit them in SILGen.

view details

Slava Pestov

commit sha dec9bf680e00eac0e1ca3074bc3967f5e582c068

AST: Remove unused UnqualifiedLookupFactory::Consumer field

view details

Slava Pestov

commit sha ba4d6ede07919fe141eb134dc2ab8aee8ea1aae6

AST: Remove unused NamedDeclConsumer class

view details

Slava Pestov

commit sha 17a0b41a40cc5d8e2c20aca07d96c096bab2bffc

Sema: Remove dead code from CheckRedeclarationRequest::evaluate()

view details

Slava Pestov

commit sha c56ab07c77184229d215213ec7a9e0b3c360fa36

ASTScope: Add finishLookupInBraceStmt parameter to ASTScope::lookupLocalDecls() This will be used to implement re-declaration checking for local declarations. Currently this is handled by parse-time lookup. To make it work with ASTScope, we need to perform lookups that look into the innermost local scope only; for example, this is an invalid redeclaration: do { let x = 321 let x = 123 } But the following is fine, even though both VarDecls are in the same *DeclContext*: do { let x = 321 do { let x = 123 } }

view details

Slava Pestov

commit sha d58583850d323cc8538f4508d4fcc16395556439

Sema: Check for re-declarations in local context in CheckRedeclarationRequest

view details

push time in 2 days

push eventvaleriyvan/swift

Valeriy Van

commit sha cbe62dd3b52d35da2db31850a0a81fa36097585b

Revertining initial code with just comment deleted

view details

push time in 2 days

pull request commentapple/swift

[stdlib] adds fast path to internal func foreignErrorCorrectedGrapheme

This introduces a significant safety hazard in hard-to-test corner cases for an unimportant optimization. Just remove the TODO(String performance) comment, it was added in a world when we thought we'd get small-stack types soon.

Do you mean whole PR should become just removing TODO(String performance)?

valeriyvan

comment created time in 2 days

push eventvaleriyvan/swift-corelibs-foundation

Brian Gontowski

commit sha 8e039ff590eb01d8eea29bb7d98364932f0416b4

Added CVarArg support to NSString and String

view details

Brian Gontowski

commit sha 0cf72bcd1b8adf4b4e2ae863280abac36e46d3e8

Implemented _CVarArgObject protocol to retain the NSString

view details

Brian Gontowski

commit sha 2260aefce4f89e59b0dd387fa694f00811965282

_CVarArgObject is currently only available on platforms without ObjC runtime

view details

Max Desiatov

commit sha c9fd004c253211651bab56c41d97f1ec89658773

Add support for WASI in CFDate.c The Linux/BSD branches are fully compatible with WASI here.

view details

Alexander Smarus

commit sha 27a734d12dae8b1d265ce542e27c769bd48a8100

Hash implementation for NSIndexSet

view details

Jon Shier

commit sha 4b1eccfa2701847712b97562fae0b6f8a3ea10db

Add URLSessionTaskMetrics and associated types.

view details

Jon Shier

commit sha 75bcd79a15e4234f3d4437c3338ab721b9a8f792

Correct method indentation.

view details

Lily Vulcano

commit sha 7cc937ee0e324add05af287c835e86a00a8089aa

Merge pull request #2886 from jshier/add-urlsessiontaskmetrics Add URLSessionTaskMetrics

view details

Lily Vulcano

commit sha 68b260e7810bf32874cb4ab1e421d7fd65b43fa7

Merge pull request #2881 from readdle/nsindexset-hash Hash implementation for NSIndexSet

view details

Lily Vulcano

commit sha 3184ab9de3b78b92947611f0127253a6480e9916

Merge pull request #2880 from apple/maxd/cfdate-wasi Add support for WASI in CFDate.c

view details

Brian Gontowski

commit sha b7c4b8cc3373a627872f0da78e1cca2a22ce9f86

Return a pointer using AnyObject instead of CFString

view details

Lily Vulcano

commit sha 14893a089982a08c65a961f79c9a2114d059827f

Merge pull request #2821 from Molanda/implement_string_varargs Added CVarArg support to NSString and String

view details

Saleem Abdulrasool

commit sha c332bb7f0ef02bc32c684a16c9d0b015abea8d8c

FoundationNetworking: make `CFURLSessionInterface` `@_implementationOnly` Remove the public exposure to `CFURLSessionInterface` which was never meant to be public. This requires removal of some of the `Equatable` conformances as scoped conformances are not yet a part of the language. This does the minimal change for to get `FoundationNetworking` to build.

view details

Lily Vulcano

commit sha 2dce19576a6ac1b487a33a0185c8acd3ae911b8f

Merge pull request #2891 from compnerd/IO-Networking FoundationNetworking: make `CFURLSessionInterface` `@_implementationO…

view details

Saleem Abdulrasool

commit sha 43d7b752ddf80f404776b0139054a95f0ae049b9

Foundation: extract `cfSource` from `RunLoop._Source` Making `cfSource` a member within the structure prevents allowing overriding of the `open` class as the type it returns cannot be deserialised. Because the member is not a stored property, extract it to an extension which removes it from the vtable. This allows the use of the private type in an external context.

view details

swift-ci

commit sha 9ebb4442a45223b252ab714a2c101748a969e2da

Merge pull request #2893 from compnerd/open-the-source

view details

Tim Kientzle

commit sha 2d7dc96f0626e067d3077de3429cdb00505bf561

Remove an invalid numeric JSON test The value `2.7976931348623158e+308` is a perfectly valid JSON number and should be accepted. This test is only passing today because the Swift standard library's `Double(_ String:)` initializer has a bug that rejected numbers larger than the maximum Double value. But we're getting ready to fix that bug in the Swift standard library, (apple/swift#34339) which will break this test when it lands.

view details

Simon Evans

commit sha cfef71fe9e0df0a5d6430f6fb202896080a17956

Merge pull request #2903 from tbkka/tbkka/RemoveInvalidNumericTest Remove an invalid numeric JSON test

view details

push time in 3 days

push eventvaleriyvan/XcodeBenchmark

Valeriy Van

commit sha 4c9f72cf7f484e3ec38d2fd293e2e1f9cef06ae2

Adds benchmark for MacBook Pro 15" Late 2013

view details

push time in 6 days

delete branch valeriyvan/iOSAppIconResizer

delete branch : add-license-1

delete time in 7 days

delete branch valeriyvan/iOSAppIconResizer

delete branch : square

delete time in 7 days

delete branch valeriyvan/iOSAppIconResizer

delete branch : refactor

delete time in 7 days

delete branch valeriyvan/iOSAppIconResizer

delete branch : bugfix/slash

delete time in 7 days

delete branch valeriyvan/iOSAppIconResizer

delete branch : ios13-xcode11

delete time in 7 days

Pull request review commentapple/swift

Replicate changes of doc comments from Array.swift to ArraySlice.swift and ContiguousArray.swift

 extension ArraySlice: RangeReplaceableCollection {   /// `LazyMapCollection<Dictionary<String, Int>, Int>` to a simple   /// `[String]`.   ///-  ///     func cacheImagesWithNames(names: [String]) {+  ///     func cacheImages(withNames names: [String]) {

cacheImages(withNames:) was suggested by reviewer of original PR which was approved by @natecook1000 as well.

Please let me know if I should change to cacheImages(names:).

valeriyvan

comment created time in 12 days

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentapple/swift

Replicate changes of doc comments from Array.swift to ArraySlice.swift and ContiguousArray.swift

 extension ArraySlice {   ///   /// - Parameter body: A closure with an `UnsafeMutableBufferPointer`   ///   parameter that points to the contiguous storage for the array.-  ///    If `body` has a return value, that value is also+  ///    If no such storage exists, it is created. If `body` has a return value, that value is also

I believe it was always like this. I could track this line yet in Arrays.swift.gyb. I believe when this comment was added to Array it was forgotten to add it to ArraySlice as well.

valeriyvan

comment created time in 12 days

PullRequestReviewEvent

Pull request review commentapple/swift

Replicate changes of doc comments from Array.swift to ArraySlice.swift and ContiguousArray.swift

 extension ContiguousArray: CustomStringConvertible, CustomDebugStringConvertible   /// A textual representation of the array and its elements, suitable for   /// debugging.   public var debugDescription: String {+    // Always show sugared representation for Arrays.

It's just copy-paste from Array.swift. I believe when this comment was added to Array.swift it was just forgotten to add this change also to ContiguousArray.swift.

valeriyvan

comment created time in 12 days

PullRequestReviewEvent

pull request commentapple/swift

Fix example snippet in Array.swift

Has the bridging behavior changed also? The new discussion (which has some English usage problems we can fix later) tells a different story with regard to optionals.

Yes, bringing behaviour have changed. Original snippet claims it should be compile error. But snippets compiles without errors and runs without errors.

Snippet could not be left untouched because it tells wrong story.

valeriyvan

comment created time in 12 days

pull request commentapple/swift

Fix example snippet in Array.swift

The documentation for NSString.write(to:atomically:) suggests using write(to:atomically:encoding:) instead. How did you decide to use write(to:)?

It not about NSString.write(to:atomically:) but about write(to:atomically:). It's deprecated. Therefore I have decided to use write(to:).

valeriyvan

comment created time in 12 days

pull request commentapple/swift-corelibs-foundation

Fix memory leak in CFBundle_Executable.c

The commit message should be reworked.

Updated commit message

valeriyvan

comment created time in 12 days

push eventvaleriyvan/swift-corelibs-foundation

Valeriy Van

commit sha b60785cfd8db2c3214be24c76a9e2fd56cfba9e8

Fix memory leak by calling CFRelease for object returned from CFURLCreateWithFileSystemPathRelativeToBase which returns +1 retain count according to Create rule.

view details

push time in 12 days

pull request commentapple/swift-corelibs-foundation

Fix memory leak in CFBundle_Executable.c

Personally, I would prefer it as a comment at the appropriate location in the code.

File CFBundle_Executable.c has 46 calls of CFRelease. No-one is commented. Why exactly this one should be commented? This is trivial bug. Someone just forgotten that retained object should be released. I don't see any reason why this call of CFRelease deserves to be commented.

valeriyvan

comment created time in 12 days

pull request commentapple/swift-corelibs-foundation

Fix memory leak in CFURL.c

This needs a better commit message.

Updated commit message

valeriyvan

comment created time in 12 days

push eventvaleriyvan/swift-corelibs-foundation

Valeriy Van

commit sha 7af5ec9c77ed8e4f73f949bddfe771bb95b1ca71

Fix memory leak by moving CFRelease to proper place

view details

push time in 12 days

pull request commentapple/swift-corelibs-foundation

Fix memory leak in CFURL.c

POSIXPathToURLPath

POSIXPathToURLPath is annotated as CF_RETURNS_RETAINED

valeriyvan

comment created time in 12 days

pull request commentapple/swift-corelibs-foundation

Fix memory leak in CFBundle_Executable.c

Please add a better commit message than 'Fix memory leak'. How was this detected? What scenarios did it occur under? Seems like this is the non-Windows Swift path, which means that Darwin would not be impacted?

Found with Xcode static analyser. On line 85 call CFURLCreateWithFileSystemPathRelativeToBase returns object with +1 retain count according to Create rule.

valeriyvan

comment created time in 12 days

create barnchvaleriyvan/swift-corelibs-foundation

branch : leak1_CFBundle_Executable

created branch time in 13 days

create barnchvaleriyvan/swift-corelibs-foundation

branch : leak_CFURL

created branch time in 13 days

create barnchvaleriyvan/swift-corelibs-foundation

branch : leak_CFBundle_Executable

created branch time in 14 days

pull request commentapple/swift

Fix example snippet in Array.swift

@natecook1000, @amartini51 could you please have a look?

valeriyvan

comment created time in 17 days

pull request commentapple/swift

[stdlib] adds fast path to internal func foreignErrorCorrectedGrapheme

@milseman?

valeriyvan

comment created time in 17 days

pull request commentapple/swift

Replicate changes of doc comments from Array.swift to ArraySlice.swift and ContiguousArray.swift

@natecook1000, @amartini51 could you please have a look?

valeriyvan

comment created time in 17 days

create barnchvaleriyvan/verovio

branch : deadstore1

created branch time in 18 days

push eventvaleriyvan/verovio

Klaus Rettinghaus

commit sha 310f051563091cc7c8d54cdad1173d6fda54cd45

fix logic on arpeg with arrow (#1696) * fix logic on arpeg with arrow * add simple test for arrow shape * fix division by zero

view details

Klaus Rettinghaus

commit sha a02753469a51a8cc44e2f77c81bae24a6029013e

Fix support for legerLineExtension and legerLineThickness (#1687) * fix ledger line definition * lower minimal sub-bracket value * remove hard coded value

view details

Klaus Rettinghaus

commit sha fb04c6a92cdb8f055e27dd85ffae8bedc0436e32

set layer@n by order (#1699)

view details

Klaus Rettinghaus

commit sha 522d1ca5f98ce09efbc63187f1f786ca466ab5ed

improve tuplet drawing (#1701)

view details

amakarchuk

commit sha 835c82015377e820c402b1d41148508b177add5f

Alternate stem direction based on the layer number (#1705) - changed logic of the stem direction so that it's alternated depending on hte layer number (down for even-numbered layers, up - for odd)

view details

Laurent Pugin

commit sha 20fe795d72da76458759eb00ff70b83adbc131bf

Revert "Develop support for plain text fonts (#1691)" (#1709) This reverts commit 9a06f486d5ba0e2676a8b453c45f24efd60c2d53.

view details

Klaus Rettinghaus

commit sha 326c108ae06f445b9f3d6d7f657933916ae907c2

Fix grace chords in MusicXML import (#1707) * fix grace chords * support for 3 octave changes * consider fret nodes to prevent broken MEI output * add support for line breaks in part-abbreviation

view details

Klaus Rettinghaus

commit sha d023a6727c701d271fdb15af7431321dcf9f66d9

improve group symbol position (#1704)

view details

amakarchuk

commit sha 01c3bd7cc6206170148a7535ea58df80adf2ca8c

Minor fix for the beams with rests (#1711) - beams should extend to the middle of the rest

view details

Klaus Rettinghaus

commit sha 07f82d100f88999a43d08f8e8c9132386bdb14be

Use up or down Y coordinate of the staff for brocken side of the slur (#1703) Co-authored-by: Oleksandr.Priadka <oleksandr.priadka@infopulse.com>

view details

Klaus Rettinghaus

commit sha 375ee1e6a6e8765cf22467316a50741197259db9

do not draw brackets on single note tremolos (#1712)

view details

amakarchuk

commit sha d64087bcbd778d8deeb1b2ad091a948ac622bb44

Fix beam slope behavior (#1710) * Separate beam stemLen calculation logic into a function - added new function that contains logic (unchanged) of stem length calculation in the beam * Fixed beam stem length calculation to aboid incorrect slopes - added uniform stem length to the beamSegment to avoid beams with mismatched stems and slopes - uniform stem length is based on the longest stem out of all coords in the beam segement (their calculation remains the same) * Small refactoring of the duplicating code - reduced amout of code with same functionality * Minor fix - fix condition for beam extending to center

view details

Klaus Rettinghaus

commit sha 81f088c4cbd945ed6c417912cf6c66b0af7dceff

update travis.yml (#1716) remove deprecated keyword update linux to latest lts

view details

Klaus Rettinghaus

commit sha b51583e2175517b55d6ddab3e15c7a11d63697b6

use unsigned for count

view details

Klaus Rettinghaus

commit sha 16c7114ce7e4786b16723994071642f7fc1797ba

fix ties over breaks on dotted notes

view details

Klaus Rettinghaus

commit sha 858b3b1dbdecacf3c1c68b1172058317daf6b30b

fix zero stem length bug

view details

Klaus Rettinghaus

commit sha b963d83954b472b587d2c479cef21e09816046b4

prevent ties from touching bar lines

view details

Klaus Rettinghaus

commit sha 3656dc2b40c5bf94f3c519815c2c0d52ba23fd05

clang format

view details

Craig Stuart Sapp

commit sha 1fdfdf72bc8b550dcc5f94c2385d36d93cdeffb2

Merge pull request #1719 from rettinghaus/develop fix ties over breaks on dotted notes

view details

Klaus Rettinghaus

commit sha ecd85863dac9c09d77f15c4a84520f3ba6613265

consider non-arpeggios (#1714)

view details

push time in 18 days

pull request commentapple/swift-corelibs-foundation

Fix memory leak in CFBundle_Executable.c

@millenomi?

valeriyvan

comment created time in 18 days

push eventvaleriyvan/SwiftyGPIO

Valeriy Van

commit sha 71857ad85ed8c1695863b66217867c42be794be3

Simplify switch using UInt8 instead of Character.asciiValue (#115)

view details

push time in 22 days

delete branch valeriyvan/SwiftyGPIO

delete branch : makeInterruptThread

delete time in 22 days

PR opened uraimo/SwiftyGPIO

Simplify switch using UInt8 instead of Character.asciiValue

What's in this pull request?

Simplify switch using UInt8 instead of Character.asciiValue

Is there something you want to discuss?

Pull Request Checklist

  • [ ] I've added the default copyright header to every new file.
  • [ ] Every new file has been correctly indented, no tabs, 4 spaces (you can use swiftlint).
  • [ ] Verify that you only import what's necessary, this reduces compilation time.
  • [ ] Try to declare the type of every variable and constant, not using type inference greatly reduces compilation time.
  • [ ] Verify that your code compiles with the currently supported Swift version (currently 4.1.3)
  • [ ] You've read the contribution guidelines.
+2 -2

0 comment

1 changed file

pr created time in 22 days

create barnchvaleriyvan/SwiftyGPIO

branch : makeInterruptThread

created branch time in 22 days

delete branch valeriyvan/SwiftyGPIO

delete branch : fallthrough

delete time in 22 days

delete branch valeriyvan/SwiftyGPIO

delete branch : readFromFile

delete time in 22 days

delete branch valeriyvan/SwiftyGPIO

delete branch : makeInterruptThread

delete time in 22 days

push eventvaleriyvan/swift

Valeriy Van

commit sha d32a993d286addeda6814fb573e5597eda3fdcdb

Fix example snippet in Array.swift

view details

push time in 22 days

push eventvaleriyvan/swift

Valeriy Van

commit sha 3b9c0b33610bd94925c6a71a42f8867505c4993d

Fix example snippet in Array.swift

view details

push time in 22 days

PR opened apple/swift

Fix example snippet in Array.swift

<!-- What's in this pull request? --> Fix example snippet in Array.swift

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->

Example snippet has several problems:

  • it uses deprecated function write(to:atomically:)

  • snippet and explanation claim bridging [String?] toNSArray is compile error when it's not - bridging works fine, but write(to:atomically:) function fails. Despite retuned fail and true atomically parameter, function writes elements into file until first NSNull and keeps this file in file system. Probably it's another problem which should be filed. cc: @millenomi

This PR uses write(to:) instead of deprecated write(to:atomically:) in example, adds do catch and changes explanation preceding example. I feel that this explanation should be improved. Help is appreciated.

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+20 -9

0 comment

1 changed file

pr created time in 22 days

push eventvaleriyvan/swift

Valeriy Van

commit sha 117ffcba29b74ac64a372b0a7e4ded65de6ec730

Fix example snippet in Array.swift

view details

push time in 22 days

create barnchvaleriyvan/swift

branch : ArrayBridging

created branch time in 22 days

push eventvaleriyvan/swift

Owen Voorhees

commit sha 6b6b640e133ca547139c6586eb0dcbf7933b46ec

[Driver] Don't test for null source locations in driver diagnostics swift-driver doesn't emit these, and there's no reason to check that they're present when using the integrated driver.

view details

Varun Gandhi

commit sha 8e63a4b43f77d8530b58f84939447cffc9692e79

[Serialization] Gate Clang type (de)serialization behind UseClangFunctionTypes.

view details

Varun Gandhi

commit sha 88e256256b72fb6c2d4a25ba21caaa47d27d18e5

[NFC] Tidy up test relying to Clang type serialization.

view details

Slava Pestov

commit sha fe9d1ed595db13ef4ba69758187875dc99589ab6

Sema: Use ASTScope::lookupSingleLocalDecl() in VarDeclUsageChecker::handleIfConfig()

view details

Slava Pestov

commit sha 025921c927e4764ac186f58c265b7f585928f279

Parse: Move the lookup of 'self' for a SuperRefExpr to preCheckExpression()

view details

Slava Pestov

commit sha bd7763df3099bc5122eeca8d3b7aeea8d87b40a4

AST: Remove unused UnqualifiedLookupFactory::resultsSizeBeforeLocalsPass This was read but never written to. I believe it was an artifact of the pre-ASTScope lookup logic.

view details

Brent Royal-Gordon

commit sha aaa4e45fa819ad83f70553bc162532199d436217

[ClangImporter] Update umbrella header diagnostic handling In apple/llvm-project#1860, the diagnostic for a missing import in an umbrella header was improved by moving it to the end of the file and including a fix-it suggesting the import that would be needed. This breaks two things on the Swift side: • One Swift test assumes the old source location will be used. • The `ClangSourceBufferImporter` doesn’t work correctly when a diagnostic is emitted at EOF. It tries to create a virtual file covering EOF..<EOF, but it’s not actually valid to start a virtual file at EOF—it would always be empty. This commit corrects these issues, which should unblock the automerger. Fixes rdar://69707827.

view details

Rintaro Ishizaki

commit sha 77a76c9900b6c1efeac0ac278210763402655a9f

[LookupVisibleDecls] Use correct BaseTy to check the decls are applicable 'lookupTypeMembers()' accepts 'BaseTy' to check found value decls are applicable to the type. When looking into super classes, it used to use the interface type of the super class which was not good. Instead, use the original "base type" consistently. rdar://problem/69308207 https://bugs.swift.org/browse/SR-13574

view details

Doug Gregor

commit sha ab3c5dee3ea2bea8e29d1e70ed8b9e7a2aeff1be

[Concurrency] Introduce Actor protocol to which actor classes all conform. Introduce a new Actor protocol, which is a class-bound protocol with only one requirement: func enqueue(partialTask: PartialAsyncTask) All actor classes implicitly conform to this protocol, and will synthesize a (currently empty) definition of `enqueue(partialTask:)` unless a suitable one is provided explicitly.

view details

Doug Gregor

commit sha 8f3c912f46dc6a2ee3734f741de50bdebf803ec0

[Concurrency] Fix new source file header.

view details

Erik Eckstein

commit sha e64848274f9918e842b48cf772fc3ccbc3314040

tests: add a missing codesign command in merge_func_ptrauth.swift rdar://problem/69727772

view details

Alexey Komnin

commit sha f18f3daba856ea08660225810e8e84bc2818f145

Fix SR-13490: Fix LT operator and add tests for ImportPath

view details

swift-ci

commit sha 0756c402583cf19adb62252ca36b0a56aae26453

Merge pull request #34113 from eeckstein/fix-test

view details

Varun Gandhi

commit sha 3016a898bde3f184de139fee061fe1eb0ae69404

Merge pull request #34102 from varungandhi-apple/vg-gate-clang-type-serde [Serialization] Gate Clang type (de)serialization behind UseClangFunctionTypes

view details

Ben Langmuir

commit sha 28228eba49a9669ca9c5fb8c88143b8a9c1d2ca5

[code-completion] Fix cache writer for non-decl kind Thanks to Ben Barham for spotting this: sizeof(~static_cast<uint8_t>(...)) is 4, but we need to write a single byte here. Thankfully this code was probably not being hit in the current caching scheme, which only caches declarations. Looking at the history, this code was broken by d8fbaa01eb10, which was fixing an MSVC warning in this code. Unfortunately I do not have access to the version of MSVC to check if there is still a warning here or for what.

view details

Rintaro Ishizaki

commit sha 0ff5f60cae8535a15d446044b9bd22348026057e

Merge pull request #34110 from rintaro/ide-completion-rdar69308207 [LookupVisibleDecls] Use correct BaseTy to check the decls are applicable

view details

Richard Wei

commit sha a845c5aff3528ad522034d01d42ed222fc0b862e

[AutoDiff] NFC: Rename AutoDiff-specific method and improve documentation. (#34112) `findAbstractFunctionDecl` in TypeCheckAttr.cpp has a very general name but the functionality is specific to AutoDiff. This patch renames it to `findAutoDiffOriginalFunctionDecl` and introduces minor improvements to the documentation.

view details

Slava Pestov

commit sha 8920da22a64a7501fba1cd659413b2cd104c4aaa

Merge pull request #34104 from slavapestov/more-astscope-fixes More ASTScope fixes in preparation for turning off parse-time lookup

view details

Pavel Yaskevich

commit sha 427c6478bc448218b11ce04b681502809d3a6c15

[ConstraintSystem] `ConstraintSystem` cannot be const when inferring new bindings It's possible that bindings would need to mutate constraint system e.g. by allocating new locators.

view details

Pavel Yaskevich

commit sha c22027260d69e8f9f0279a27b4b310a2b4bdda5e

[CSBindings] Infer any type variable connected to a code completion token as a potential hole If type variable is associated with a code completion token it's possible that it doesn't have enough contextual information to be resolved to anything, so let's add a hole type which originates from type variable associated with code completion expression to make this relationship explicit and avoid "fixing" problems rooted in fact that type variable is underconstrained due to code completion.

view details

push time in 22 days

push eventvaleriyvan/swift-corelibs-foundation

Saleem Abdulrasool

commit sha 7e9c243be767731396744e8aa15fda49fdfdbf01

Foundation: map `ECANCELED` properly for Windows This is generally not a very helpful constant for Windows, however, it can be passed from Dispatch in some cases. Lets just provide the mapping for the Windows version.

view details

Lily Vulcano

commit sha e9d8347e64ece3de453d617887af7229f73358d8

Merge pull request #2887 from compnerd/cancelled Foundation: map `ECANCELED` properly for Windows

view details

push time in 22 days

push eventvaleriyvan/SwiftyGPIO

Valeriy Van

commit sha e76a76da5bcdc1143b1715fcc9ae386bff408de2

Refoctor func makeInterruptThread of GPIO to avoid creating string instance (#114)

view details

Valeriy Van

commit sha 15e757898753c578f1f44dda0f1177b1fe983edd

Refactores readFromFile func avoiding not needed allocations (#113)

view details

push time in 22 days

PR opened uraimo/SwiftyGPIO

Refactor func makeInterruptThread of GPIO to avoid creating string instance

What's in this pull request?

Refactor func makeInterruptThread of GPIO to avoid creating string instance

Is there something you want to discuss?

Pull Request Checklist

  • [ ] I've added the default copyright header to every new file.
  • [ ] Every new file has been correctly indented, no tabs, 4 spaces (you can use swiftlint).
  • [ ] Verify that you only import what's necessary, this reduces compilation time.
  • [ ] Try to declare the type of every variable and constant, not using type inference greatly reduces compilation time.
  • [ ] Verify that your code compiles with the currently supported Swift version (currently 4.1.3)
  • [ ] You've read the contribution guidelines.
+4 -7

0 comment

1 changed file

pr created time in 22 days

create barnchvaleriyvan/SwiftyGPIO

branch : makeInterruptThread

created branch time in 22 days

create barnchvaleriyvan/swift-corelibs-foundation

branch : main

created branch time in 24 days

delete branch valeriyvan/swift

delete branch : Array-fix-snippet-endianness

delete time in 24 days

delete branch valeriyvan/anyline-ocr-examples-ios

delete branch : deprecations

delete time in 24 days

PR opened apple/swift

Replicate changes of doc comments from Array.swift to ArraySlice.swift and ContiguousArray.swift

<!-- What's in this pull request? --> Replicate changes of doc comments from Array.swift to ArraySlice.swift and ContiguousArray.swift

<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->

<!-- Before merging this pull request, you must run the Swift continuous integration tests. For information about triggering CI builds via @swift-ci, see: https://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci

Thank you for your contribution to Swift! -->

+9 -7

0 comment

2 changed files

pr created time in 24 days

create barnchvaleriyvan/swift

branch : array

created branch time in 24 days

create barnchvaleriyvan/swift

branch : main

created branch time in 24 days

push eventvaleriyvan/swift

Valeriy Van

commit sha cdba663d805773653a3da129368e5ef995d4f72c

Fixes example snippets in Array.swift considering endianness

view details

push time in 24 days

Pull request review commentapple/swift

Fixes example snippets in Array.swift considering endianness

 extension Array {   ///     }   ///     // numbers == [1, 2]   ///+  /// [1]: https://developer.mozilla.org/en-US/docs/Glossary/Endianness

Done

valeriyvan

comment created time in 24 days

PullRequestReviewEvent

push eventvaleriyvan/swift

Valeriy Van

commit sha ce9ddef5707d0ea1e4c507300c9323e8be39188a

Removes links as suggested in review

view details

push time in 24 days

PullRequestReviewEvent

Pull request review commentapple/swift

Fixes example snippets in Array.swift considering endianness

 extension Array {   ///     }   ///     // numbers == [1, 2]   ///+  /// [1]: https://developer.mozilla.org/en-US/docs/Glossary/Endianness

I am not sure I understand. Should link be removed???

valeriyvan

comment created time in 25 days

push eventvaleriyvan/swift

Valeriy Van

commit sha 62c631ab3e1e2c237000be7b484f35cbfd110e82

Replicate changes from Array.swift to ContiguousArray.swift

view details

push time in a month

push eventvaleriyvan/swift

Valeriy Van

commit sha 109719606c7f4ef5fc702276722560823d207483

Replicate changes from Array.swift to ArraySlice.swift

view details

push time in a month

push eventvaleriyvan/swift

Valeriy Van

commit sha eb6a6ff329fbb84504427507a58c4ddf37dd80fc

Fixes example snippets in Array.swift considering endianness

view details

push time in a month

Pull request review commentapple/swift

Fixes example snippets in Array.swift considering endianness

 extension Array {   ///     }   ///     // numbers == [1, 2]   ///+  /// - Note: This example shows the behavior on a [little-endian][1] platform.

fixed

valeriyvan

comment created time in a month

PullRequestReviewEvent

push eventvaleriyvan/swift

Valeriy Van

commit sha 11de00e374de96b2e2426aee670562e79a967936

Adds empty line as suggested in review

view details

push time in a month

create barnchvaleriyvan/anyline-ios-swift-demo

branch : housekeeping

created branch time in a month

fork valeriyvan/anyline-ios-swift-demo

This is a small demo example how to use the AnylineSDK with swift

https://anyline.com

fork in a month

create barnchvaleriyvan/anyline-ocr-examples-ios

branch : deprecations

created branch time in a month

create barnchvaleriyvan/anyline-ocr-examples-ios

branch : format

created branch time in a month

pull request commentfyber-engineering/fairbid-sample-app-ios

disclaimer about ad availability

👍🏿

saschabienert

comment created time in a month

Pull request review commentapple/swift

Fixes example snippets in Array.swift considering endianness

 extension Array {   /// and enums.   ///   /// The following example copies bytes from the `byteValues` array into-  /// `numbers`, an array of `Int`:+  /// `numbers`, an array of `Int32`; on a [little-endian][1] machine, the+  /// result is as shown:

Fixed as suggested

valeriyvan

comment created time in a month

PullRequestReviewEvent

push eventvaleriyvan/swift

Valeriy Van

commit sha 02c0ddde9b02be785aba91084f063437426d38de

Changes comment as suggested in review

view details

push time in a month

push eventvaleriyvan/verovio

Alexandr Pryadka

commit sha cd4754c04edd0f7fcdce8dfabe96d35a16cb7e6a

Separate slurs if they have common point (#1676) * Separate slurs if they have common point * Use more readable names * Formatting * Support above/below slurs Co-authored-by: Oleksandr.Priadka <oleksandr.priadka@infopulse.com>

view details

Laurent Pugin

commit sha d2c830653c65fee4909a82b01cfac9649499548a

Update to XCode 12

view details

Laurent Pugin

commit sha 9f38a686d981e35e7830b566ec1b114a1b40294c

Merge branch 'develop' of https://github.com/rism-ch/verovio into develop

view details

Klaus Rettinghaus

commit sha a49b0f7173d57199577fc601a8a57b3f1d7b6157

silence warning on updating data.PERCENT (#1697)

view details

amakarchuk

commit sha 9a06f486d5ba0e2676a8b453c45f24efd60c2d53

Develop support for plain text fonts (#1691) * Add xsl file to extract glyphs from all fonts - added file so that all glyphs (regardless of the presence of 'uni') are extracted when it's passed to saxon * Update font generation script to work with plain fonts - changed logic of the generate-bbox script - it not can either take JSON(for smufl fonts) or CFG (for plain fonts). - CFG file contains mapping between glyph names (comma, space, etc.) and their unicode number. These values are matched and resulting xml file contains bboxes with proper codes. - CFG file can be generated along with SVG file using FontForge. * Updated generation process of the plain fonts - Added python script to generate SVG and relevant metadata for the font - Changed JS to use G2N file for metadata instead of CFG. G2N is relevant for ttf/otf fonts and has better scructure compared to CFG file * Add script for text font generation - Added shell script with commands for text font generation * Introduced option --text-font * Replace hard coded references to Times * Add default font name into DeviceContext and set it from options value. * Make text font script independent of font format and CWD * Add xsl file to extract glyphs from all fonts - added file so that all glyphs (regardless of the presence of 'uni') are extracted when it's passed to saxon * Update font generation script to work with plain fonts - changed logic of the generate-bbox script - it not can either take JSON(for smufl fonts) or CFG (for plain fonts). - CFG file contains mapping between glyph names (comma, space, etc.) and their unicode number. These values are matched and resulting xml file contains bboxes with proper codes. - CFG file can be generated along with SVG file using FontForge. * Updated generation process of the plain fonts - Added python script to generate SVG and relevant metadata for the font - Changed JS to use G2N file for metadata instead of CFG. G2N is relevant for ttf/otf fonts and has better scructure compared to CFG file * Add script for text font generation - Added shell script with commands for text font generation * Introduced option --text-font * Replace hard coded references to Times * Add default font name into DeviceContext and set it from options value. * Make text font script independent of font format and CWD * Add start/end comments to the script for better visibility * Re-arrange order of the options Co-authored-by: Oleksandr Gnatenko <Oleksandr.Gnatenko@infopulse.com> Co-authored-by: Oleksandr.Priadka <oleksandr.priadka@infopulse.com> Co-authored-by: Thomas Weber <thomas.weber@notengrafik.com>

view details

push time in a month

more