profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/untitaker/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Markus Unterwaditzer untitaker @getsentry Vienna, Austria https://unterwaditzer.net "Do not even think of telephoning me about this program. Send cash first!" --Author of the UNIX file command.

beetbox/beets 9974

music library manager and MusicBrainz tagger

quicktype/quicktype 6076

Generate types and converters from JSON, Schema, and GraphQL

mitsuhiko/pipsi 1999

pip script installer

mitsuhiko/redis-rs 1855

Redis library for rust

click-contrib/click-repl 151

Subcommand REPL for click apps

click-contrib/click-log 86

Simple and beautiful logging for click applications

niax/rust-email 50

Implementation of MIME Messages for Rust

lol-qwop/lol-qwop 35

Everyone who has a merged pull request is invited to become an admin of this repo.

python-webuntis/python-webuntis 30

Bindings for WebUntis

tehmaze/ansi 27

ANSI cursor movement and graphics in Python

fork jart/fish-shell

The user-friendly command line shell.

https://fishshell.com

fork in 5 hours

startedspulec/moto

started time in 8 hours

issue openedgetsentry/sentry-python

Django template span has invalid description

Environment

How do you use Sentry? Self-hosted, version 21.2.0

Which SDK and version? Python 1.0.0

Steps to Reproduce

  1. Set up performance tracing for a Django application
  2. Send performance data for a view which is a subclass of TemplateView
  3. View the performance information for the view in Sentry

Expected Result

Sentry accepts all of the submitted performance data.

Actual Result

The following alert appears above the performance information:

Sentry Error

This is caused by #957.

At https://github.com/Christophe31/sentry-python/blob/db2d87e503b0178a7d56bdedb00db19ac6ddc9d8/sentry_sdk/integrations/django/templates.py#L60, a span is created with the description self.template_name. If the TemplateResponse was created by a Django TemplateView, template_name will be a list, not a string.

A similar error can occur with django.shortcuts.render, but I don't use it, so I haven't experienced the issue there.

created time in 9 hours

pull request commentgetsentry/relay

fix(stacktrace): Skip more null values

<!-- 1 failure: Please consider a... 0 warning:

1 markdown notices DangerID: danger-id-Danger; -->

<table> <thead> <tr> <th width="50"></th> <th width="100%" data-danger-table="true">Fails</th> </tr> </thead> <tbody><tr> <td>:no_entry_sign:</td> <td>Please consider adding a changelog entry for the next release.</td> </tr> </tbody> </table>

<details> <summary><b>Instructions and example for changelog</b></summary>

For changes exposed to the Python package, please add an entry to py/CHANGELOG.md. This includes, but is not limited to event normalization, PII scrubbing, and the protocol.

For changes to the Relay server, please add an entry to CHANGELOG.md under the following heading:

  1. Features: For new user-visible functionality.
  2. Bug Fixes: For user-visible bug fixes.
  3. Internal: For features and bug fixes in internal operation, especially processing mode.

To the changelog entry, please add a link to this PR (consider a more descriptive message):

- Skip more null values. ([#944](https://github.com/getsentry/relay/pull/944))

If none of the above apply, you can opt out by adding #skip-changelog to the PR description.

</details>

<p align="right"> Generated by :no_entry_sign: <a href="https://danger.systems/js">dangerJS</a> against 6eb5e3df9957854d7fa0c9ba9e557364cd4cf621 </p>

untitaker

comment created time in 10 hours

issue closedgetsentry/sentry-python

Please detail breaking changes

The release notes for v1.0 say "This release contains breaking changes".

But what are the breaking changes? Are all six features/fixes going to cause breakages to any pre 1.0 installation? Or only one of them, in certain situations? What do I need to do to prevent things breaking?

closed time in 12 hours

philgyford

issue commentgetsentry/sentry-python

Please detail breaking changes

Great, thank you for clarifying!

philgyford

comment created time in 12 hours

issue commentgetsentry/sentry-python

Please detail breaking changes

Hey @philgyford Thanks for bringing that to my attention!

The breaking changes:

  • The experimental flag auto_session_tracking has been moved to a proper option that is set to True by default
  • The experimental flag session_mode has been removed in favor of auto detecting the mode from within the sdk

Let me know if you have another questions

philgyford

comment created time in 12 hours

push eventgetsentry/sentry-python

Ahmed Etefy

commit sha b530b6f89ba9c13a9f65a0fa3f151ed42c9befe0

Clarified breaking change in release 1.0 changelog (#1047)

view details

push time in 12 hours

delete branch getsentry/sentry-python

delete branch : ahmedetefy-changelog

delete time in 12 hours

create barnchgetsentry/sentry-python

branch : ahmedetefy-changelog

created branch time in 12 hours

issue openedgetsentry/sentry-python

Please detail breaking changes

The release notes for v1.0 say "This release contains breaking changes".

But what are the breaking changes? Are all six features/fixes going to cause breakages to any pre 1.0 installation? Or only one of them, in certain situations? What do I need to do to prevent things breaking?

created time in 14 hours

issue commentgetsentry/sentry-python

DedupeIntegration causing events not to send

I tried this and unfortunately the events still don't send to sentry.

I ended up resolving this by creating a new project in sentry - it appears it wasn't anything related to my client/config, since the new project "just worked" 🤷‍♂️ Looks like a bug on the sentry SAAS itself.

Thanks for the help though.

mitchfriedman

comment created time in 15 hours

pull request commentgetsentry/rust-proguard

Implement parsing for a full stacktrace

Thanks for merging, that went so quickly. Didn't fully rollback the remap_stacktrace signature yet, is that okay?

dnaka91

comment created time in 15 hours

push eventgetsentry/sentry-release-registry

getsentry-bot

commit sha 9471ce3469d1e497ea81c4fa10139b9400885a8b

craft: release "composer:sentry/sentry-laravel", version "2.4.1"

view details

push time in 16 hours

created repositorymatklad/hashset-vs-vec-bench

created time in 17 hours

Pull request review commentgetsentry/rust-proguard

meta: Update CI/Release Infrastructure

+name: CI++on:+  push:+    branches:+      - master+      - "release/**"+  pull_request:++jobs:+  lints:+    name: Lints+    runs-on: ubuntu-latest+    steps:+      - uses: actions/checkout@v2++      - uses: actions-rs/toolchain@v1+        with:+          profile: minimal+          toolchain: stable+          override: true+          components: rustfmt, clippy++      - uses: Swatinem/rust-cache@v1++      - uses: actions-rs/cargo@v1+        with:+          command: fmt+          args: --all -- --check++      - uses: actions-rs/cargo@v1+        with:+          command: clippy+          args: --all-features --workspace --tests --examples -- -D clippy::all++  test:+    strategy:+      fail-fast: false+      matrix:+        os: [ubuntu-latest, macos-latest, windows-latest]+        rust: [stable]++    name: Test using Rust ${{ matrix.rust }} on ${{ matrix.os }}+    runs-on: ${{ matrix.os }}++    steps:+      - uses: actions/checkout@v2++      - uses: actions-rs/toolchain@v1+        with:+          profile: minimal+          toolchain: ${{ matrix.rust }}

Let's simplify and just hardcode stable here, if you only have a single value.

Swatinem

comment created time in 18 hours

Pull request review commentgetsentry/rust-proguard

meta: Update CI/Release Infrastructure

+name: CI++on:+  push:+    branches:+      - master+      - "release/**"+  pull_request:++jobs:+  lints:+    name: Lints+    runs-on: ubuntu-latest+    steps:+      - uses: actions/checkout@v2++      - uses: actions-rs/toolchain@v1+        with:+          profile: minimal+          toolchain: stable+          override: true+          components: rustfmt, clippy++      - uses: Swatinem/rust-cache@v1++      - uses: actions-rs/cargo@v1+        with:+          command: fmt+          args: --all -- --check++      - uses: actions-rs/cargo@v1+        with:+          command: clippy+          args: --all-features --workspace --tests --examples -- -D clippy::all++  test:+    strategy:+      fail-fast: false+      matrix:+        os: [ubuntu-latest, macos-latest, windows-latest]

This crate doesn't do anything OS specific, does it? At least, the old test suite only ran on Linux, and you can speed this up by removing the matrix.

Swatinem

comment created time in 18 hours

Pull request review commentgetsentry/rust-proguard

meta: Update CI/Release Infrastructure

+name: CI++on:+  push:+    branches:+      - master+      - "release/**"+  pull_request:++jobs:+  lints:+    name: Lints+    runs-on: ubuntu-latest+    steps:+      - uses: actions/checkout@v2++      - uses: actions-rs/toolchain@v1+        with:+          profile: minimal+          toolchain: stable+          override: true+          components: rustfmt, clippy++      - uses: Swatinem/rust-cache@v1

nit: You can run cargo fmt even before pulling in the heavy cache.

Swatinem

comment created time in 18 hours

Pull request review commentgetsentry/rust-proguard

meta: Update CI/Release Infrastructure

 impl<'s> ProguardMapper<'s> {      /// Remaps a complete Java StackTrace, similar to [`Self::remap_stacktrace`] but instead works on     /// strings as input and output.-    pub fn remap_stacktrace(&self, input: &str) -> Result<String, std::fmt::Error> {+    pub fn remap_stacktrace(&'s self, input: &str) -> Result<String, std::fmt::Error> {

This is certainly wrong. Nothing in this function should require this bound.

Swatinem

comment created time in 19 hours

Pull request review commentgetsentry/rust-proguard

meta: Update CI/Release Infrastructure

 impl<'s> ProguardMapper<'s> {     /// # Example     ///     /// ```-    /// use proguard::{ProguardMapper,Throwable};+    /// use proguard::{ProguardMapper, Throwable};     ///     /// let mapping = "com.example.Mapper -> a.b:";     /// let mapper = ProguardMapper::from(mapping);     ///     /// let throwable = Throwable::try_parse(b"a.b: Crash").unwrap();     /// let mapped = mapper.remap_throwable(&throwable);     ///-    /// assert_eq!(Some(Throwable::with_message("com.example.Mapper", "Crash")), mapped);+    /// assert_eq!(+    ///     Some(Throwable::with_message("com.example.Mapper", "Crash")),+    ///     mapped+    /// );     /// ```-    pub fn remap_throwable<'a>(&'a self, throwable: &Throwable<'a>) -> Option<Throwable<'a>> {+    pub fn remap_throwable(&'s self, throwable: &Throwable<'s>) -> Option<Throwable<'s>> {

Are you sure this is equivalent? Previously, this was bound to the lifetime of self and of the data in Throwable, Now, this is bound to 's, and you're requiring that the self lifetime is equal to 's. Can you double-check lifetime bounds here, please?

Swatinem

comment created time in 19 hours

PR opened getsentry/rust-proguard

meta: Update CI/Release Infrastructure
  • Switch to GHA and create a Release Action
  • Format doctests and sync lifetimes with rest of the code
  • Prepare CHANGELOG
+127 -27

0 comment

7 changed files

pr created time in 19 hours

push eventgetsentry/rust-proguard

Arpad Borsos

commit sha 6cf22339ae2288718686956fa7256a7111583f04

meta: Update CI/Release Infrastructure - Switch to GHA and create a `Release` Action - Format doctests and sync lifetimes with rest of the code - Prepare CHANGELOG

view details

push time in 19 hours

create barnchgetsentry/rust-proguard

branch : meta/infra

created branch time in 19 hours

push eventgetsentry/sentry-release-registry

getsentry-bot

commit sha 5f14c41121c8ce4f692cfec139d64ceca05a8f9e

craft: release "composer:sentry/sentry-laravel", version "2.4.0"

view details

push time in 19 hours

PR merged getsentry/rust-proguard

Implement parsing for a full stacktrace

First of all thanks for this crate. This allows me to finally not having to spawn a Java process to run retrace from Rust.

While using it, I realized that this crate currently only support the plain stack frames like

at com.example.Class1.method(Class1.java:3)
at com.example.Class2.otherMethod(Class2.java:1)
...

I'm using this in a personal project where I get a full stack trace from errors through the ACRA crash reporting library. First of all it didn't remap anything as this crate expects at ... with spaces but ACRA sends the stack trace with tabs \tat ....

Furthermore the full stack trace from a Throwable that's created with printStackTrace contains some more components in the output like

com.example.CustomException: Crashed
    at com.example.Class1.method(Class1.java:3)
    at com.other.ClassAbc.someMethod(ClassAbc.java:53)
Caused by: com.example.OtherException: Engines exploded
    at com.example.Engine.startup(Engine.java:122)
...

Therefore, I implemented a new StackTrace struct that represents this full stack trace and all the parsing that comes with it. The struct can maybe be further split up for a Cause that could be the same but with non-optional throwable as that always exists and the new tests should probably be moved to another place.

All existing structs in stacktrace.rs used Cow<'s, str> and I switched to &str as I couldn't find any specific use for the Cow<'s, str>. If you would like to keep that instead, I can roll it back of course.

Just would to hear your opinion about these changes so far, before I correct the last few bits.

+629 -53

2 comments

4 changed files

dnaka91

pr closed time in 19 hours

push eventgetsentry/rust-proguard

Dominik Nakamura

commit sha 2a0e912b2b6b24e7e83122adac3ab123bdbc7c36

feat: Implement parsing for a full stacktrace (#19)

view details

push time in 19 hours

push eventgetsentry/sentry-python

dependabot-preview[bot]

commit sha f2a3ad14b2fe4723282e1541caa13f9edbcccdab

build(deps): bump sphinx from 3.5.0 to 3.5.1 Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 3.5.0 to 3.5.1. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/3.x/CHANGES) - [Commits](https://github.com/sphinx-doc/sphinx/compare/v3.5.0...v3.5.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

OutOfFocus4

commit sha 37105d981fb116c60df2ea3d1e58a87b9c65fc21

Use path_info instead of path (#1029)

view details

Ahmed Etefy

commit sha 1279eeca6763e119d97da5da8318f48a04d3adef

feat(release-health): Enable session tracking by default (#994) * Auto enabled auto session tracking * Moved auto_session_tracking outof expeirmental features and added it by default * fix: Formatting * Fixed type error * Removed auto_session_tracking from from Experiment type * Removed redundant default * Auto detection of session mode when auto_session_tracking is enabled * fix: Formatting * Added test that ensures session mode is flips from applicatoin to request in WSGI handler * New line at end of file * Linting fixes * Added default for session_mode in auto_session_tracking * Added defaults to session_mode to Session class * Fixed failing test due to changes in WSGI handler tracking requests: * Reordered param to the end * fix: Formatting * Modified flask test to match request mode sessions * Removed redundant typing Union Co-authored-by: sentry-bot <markus+ghbot@sentry.io>

view details

Katie Byers

commit sha 51987c57157102bbd32e1e7b084c26f4dc475d86

fix(tracing): Get HTTP headers from span rather than transaction if possible (#1035)

view details

Ahmed Etefy

commit sha ed7d722fdd086a1044d44bc28f2d29a91d87d8ca

bug(flask): Transactions missing body (#1034) * Add test that ensreus transaction includes body data even if no exception was raised * Removed weakref to request that was being gc before it was passed to event_processor * fix: Formatting * Linting fixes Co-authored-by: sentry-bot <markus+ghbot@sentry.io>

view details

Ahmed Etefy

commit sha 3a0bd746390528b3e718b4fe491552865aad12c4

fix(django): Added SDK logic that honors the `X-Forwarded-For` header (#1037) * Passed django setting USE_X_FORWARDED_FOR to sentry wsgi middleware upon creation * Linting changes * Accessed settings attr correctly * Added django tests for django setting of USE_X_FORWARDED_HOST and extracting the correct request url from it * fix: Formatting Co-authored-by: sentry-bot <markus+ghbot@sentry.io>

view details

Ahmed Etefy

commit sha b9cdcd60c9f80d3bf652172f23c5f21059c9a71e

Used settings fixture instead of importing django settings (#1038)

view details

Markus Unterwaditzer

commit sha 68fb0b4c7e420df4cfa6239d256fc4d0a9e32ff1

fix(worker): Log data-dropping events with error (#1032) Co-authored-by: sentry-bot <markus+ghbot@sentry.io>

view details

Ahmed Etefy

commit sha b4ca43c0255d2569695af9819260807b09caa18a

Release: 1.0.0 (#1039) * Added Change log for major release 1.0.0 * Increased the timeout for tests in workflow * Added entry to changelog in regards to worker fix

view details

getsentry-bot

commit sha 2e16934be5157198759a3b10ac3292c87f971b4a

release: 1.0.0

view details

Sentry Bot

commit sha 07bb2c74806c0e197936e2a5d4f5730e69b14b27

Merge release/1.0.0 into master

view details

Hynek Schlawack

commit sha de1ceb8081a29c5e1a0ff01d8d7b7f6ae7b9dbfc

Get rid of setup.cfg by moving the only option to setup.py (#1040)

view details

Bruno Garcia

commit sha dec29405a6bb65202fff3ac45325506269146d66

We're hiring

view details

dependabot-preview[bot]

commit sha 860af86183fa94e13af94e8751efe2d8dfab1210

build(deps): bump sphinx from 3.5.1 to 3.5.2 Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 3.5.1 to 3.5.2. - [Release notes](https://github.com/sphinx-doc/sphinx/releases) - [Changelog](https://github.com/sphinx-doc/sphinx/blob/3.x/CHANGES) - [Commits](https://github.com/sphinx-doc/sphinx/compare/v3.5.1...v3.5.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 7a3c3dfbafdd5205ba42a7a8d3d2476f2b236ff7

build(deps): bump flake8-bugbear from 20.11.1 to 21.3.1 Bumps [flake8-bugbear](https://github.com/PyCQA/flake8-bugbear) from 20.11.1 to 21.3.1. - [Release notes](https://github.com/PyCQA/flake8-bugbear/releases) - [Commits](https://github.com/PyCQA/flake8-bugbear/commits) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

dependabot-preview[bot]

commit sha 09384d4be8be89b9a723da6f9571b62cf0b411a5

build(deps): bump mypy from 0.782 to 0.812 Bumps [mypy](https://github.com/python/mypy) from 0.782 to 0.812. - [Release notes](https://github.com/python/mypy/releases) - [Commits](https://github.com/python/mypy/compare/v0.782...v0.812) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

view details

push time in 20 hours

delete branch getsentry/sentry-python

delete branch : dependabot/pip/flake8-bugbear-21.3.1

delete time in 20 hours