Is your feature request related to a problem? Please describe.

On cognitoUser.completeNewPasswordChallenge the second function variable is the users attributes, what I've done is on the callback for cognitoUser.authenticateUser: newPasswordRequired returns the attributes, I set them in my state. However due to cognitoUser.completeNewPasswordChallenge accepting attributes back that are immutable, email_verified etc, I think the challenge response from cognito in ChallengeParameters should have an array of immutableAttributes that way we can check any attributes aren't immutable before they get sent back to to cognito for challenges, updating attributes etc? I think this would flow a lot easier.

Describe the solution you'd like Array of immutableAttributes from the cognito endpoint after you invoke a login, you will get a challenge such as NEW_PASSWORD_REQUIRED. Then within the package we check against immutable attributes and remove them.

Describe alternatives you've considered Manual checking outside the package, but this could be a check already done within the package for ease.

Additional context Example usage currently:

  signIn(
    { state: State, commit, dispatch }: ActionContext<State, null>,
    credentials: Credentials
  ) {
    commit("setUserPool");
    commit("setCognitoDetails", credentials);
    return new Promise((resolve, reject) => {
      state.cognitoUser.authenticateUser(state.authDetails, {
        onSuccess: (result: any) => {
          console.log("sign in success");
          commit("setTokens", result);
          commit("signIn");
          router.push("/profile");
          dispatch("getUserAttributes");
          dispatch("setLogoutTimer", 3600);
          resolve();
        },
        onFailure: (err: { code: string }) => {
          switch (err.code) {
            case "UserNotFoundException":
            case "NotAuthorizedException":
              reject({
                code: err.code,
                message: "Incorrect username or password"
              });
              break;
            case "UserNotConfirmedException":
              reject({
                code: err.code,
                message: "User registration not confirmed"
              });
              break;
            case "LimitExceededException":
              reject({
                code: err.code,
                message: "Login attempts limit exceeded, please try after later"
              });
              break;
            default:
              reject({
                code: err.code,
                message: "An error occured"
              });
              break;
          }
        },
        newPasswordRequired: (attributes: any) => {
          commit("setAttributes", attributes);
          reject({
            code: "NEW_PASSWORD_REQUIRED",
            message: "Please set a new password"
          });
        }
      });
    });
  },
  completeNewPasswordChallenge(
    { state: State }: ActionContext<State, null>,
    password: string
  ) {
    return new Promise((resolve, reject) => {
      // Checks here would be need to make sure the state attributes saved from the above callback don't contain immutable attributes or will return 400 bad request from cognito
      state.cognitoUser.completeNewPasswordChallenge(
        password,
        state.attributes,
        {
          onSuccess: (res: any) => {
            console.log(res);
            resolve();
          },
          onFailure: (err: any) => {
            console.log(err);
            reject({
              code: err.code,
              message: err.message
            });
          }
        }
      );
    });
  },

Was showing a lowercase pool when actually it's expecting Pool, easier Error reading.

Issue #, if available:

Description of changes:

Capitalised Pool from pool, the actual type is Pool.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nicolas-grekas Do we know what the issue was?

Not fixed @fabpot

Ping to @fabpot - Can we get this pinned and an up to date open discussion, it's going to be a high traffic issue i believe as it stops the install of certain frameworks on windows.

There should be one pinned as this is an ongoing issue and shouldn't be closed. Would stop duplication.

Laravel app, here's the composer.json:

{
    "name": "laravel/laravel",
    "type": "project",
    "description": "The Laravel Framework.",
    "keywords": [
        "framework",
        "laravel"
    ],
    "license": "MIT",
    "require": {
        "php": "^7.2.5",
        "akaunting/money": "^1.2",
        "fideloper/proxy": "^4.2",
        "fruitcake/laravel-cors": "^1.0",
        "guzzlehttp/guzzle": "^6.3",
        "laravel/framework": "^7.0",
        "laravel/sanctum": "^2.4",
        "laravel/tinker": "^2.0",
        "league/flysystem-aws-s3-v3": "^1.0",
        "yab/laravel-scout-mysql-driver": "^3.0"
    },
    "require-dev": {
        "facade/ignition": "^2.0",
        "fzaninotto/faker": "^1.9.1",
        "knuckleswtf/scribe": "1.6.0",
        "mockery/mockery": "^1.3.1",
        "nunomaduro/collision": "^4.1",
        "phpunit/phpunit": "^8.5"
    },
    "config": {
        "optimize-autoloader": true,
        "preferred-install": "dist",
        "sort-packages": true
    },
    "extra": {
        "laravel": {
            "dont-discover": []
        }
    },
    "autoload": {
        "psr-4": {
            "App\\": "app/"
        },
        "classmap": [
            "database/seeds",
            "database/factories"
        ]
    },
    "autoload-dev": {
        "psr-4": {
            "Tests\\": "tests/"
        }
    },
    "minimum-stability": "dev",
    "prefer-stable": true,
    "scripts": {
        "post-autoload-dump": [
            "Illuminate\\Foundation\\ComposerScripts::postAutoloadDump",
            "@php artisan package:discover --ansi"
        ]
    }
}

Yeh this looks a lot better!

@philnichol yeh the _id is what throws it off, cheers for the reference.

<!--- Please keep this note for the community --->

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

<!--- Thank you for keeping this note for the community --->

Terraform CLI and Terraform AWS Provider Version

<!--- Please run terraform -v to show the Terraform core version and provider version(s). If you are not running the latest version of Terraform or the provider, please upgrade because your issue may have already been fixed. Terraform documentation on provider versioning. --->

Affected Resource(s)

• cloudfront_distribution

Expected Behavior

Pass the ID instead of the ARN

Actual Behavior

When using cloudfront_distribution and want to assign a WAFv2 to the distribution you use web_acl_id this in fact for WAFv2 isn't the ID and needs to be the ARN to be assigned to work. I found this by using a id from aws_wafv2_web_acl.test.id but works by doing aws_wafv2_web_acl.test.arn instead

Was created with issue helper ^

I want to achieve something this this:

import { RouteRecordRaw, createRouter, createWebHistory } from "vue-router";
import store from "@/store";

const routes: Array<RouteRecordRaw> = [
  {
    path: "/login",
    name: "Login",
    component: () => import("../views/Login.vue")
  },
  {
    path: "/",
    name: "Home",
    component: () => import("../views/Home.vue"),
    meta: {
      requiresAuth: true
    }
  },
];

const router = createRouter({
  history: createWebHistory(process.env.BASE_URL),
  routes
});

router.beforeEach((to, from, next) => {
  const loggedIn = store.state.authentication.loggedIn;
  if (to.matched.some(record => record.meta.requiresAuth) && !loggedIn) {
    next({
      name: "Login",
      query: { redirect: to.fullPath }
    });
  } else {
    next();
  }
});

export default router;

However I get:

I've tried:

• !!
• (store && store.state.authentication.loggedIn)
• can't inject useStore as this isn't a component and doesn't use the setup() method

My Vuex setup: store:

import { createStore } from "vuex";
import authentication from "@/store/modules/authentication/index.ts";

export default createStore({
  modules: {
    authentication: authentication
  }
});

authentication module:

import { ActionContext } from "vuex";

type User = {
  id: number;
  token: string;
  name: string;
};

type State = {
  user?: User;
  loggedIn: boolean;
};

const state: State = {
  user: undefined,
  loggedIn: false
};

const getters = {
  loggedIn: (state: State) => {
    return state.loggedIn;
  },
  currentUser: (state: State) => {
    return state.user;
  }
};

const actions = {
  login({ state: State, commit }: ActionContext<State, null>, user: User) {
    commit("setUser", user);
  },
  logout({ state: State, commit }: ActionContext<State, null>) {
    commit("clearUser");
  }
};

const mutations = {
  setUser(state: State, user: User) {
    state.user = user;
    state.loggedIn = true;
  },
  clearUser(state: State) {
    state.user = undefined;
    state.loggedIn = false;
  }
};

export default {
  namespaced: true,
  state,
  getters,
  actions,
  mutations
};

Any ideas on to fix this? thanks in advance

I want to achieve something this this:

import { RouteRecordRaw, createRouter, createWebHistory } from "vue-router";
import store from "@/store";

const routes: Array<RouteRecordRaw> = [
  {
    path: "/login",
    name: "Login",
    component: () => import("../views/Login.vue")
  },
  {
    path: "/",
    name: "Home",
    component: () => import("../views/Home.vue"),
    meta: {
      requiresAuth: true
    }
  },
];

const router = createRouter({
  history: createWebHistory(process.env.BASE_URL),
  routes
});

router.beforeEach((to, from, next) => {
  const loggedIn = store.state.authentication.loggedIn;
  if (to.matched.some(record => record.meta.requiresAuth) && !loggedIn) {
    next({
      name: "Login",
      query: { redirect: to.fullPath }
    });
  } else {
    next();
  }
});

export default router;

However I get:

I've tried:

• !!
• (store && store.state.authentication.loggedIn)
• can't inject useStore as this isn't a component and doesn't use the setup() method

My Vuex setup: store:

import { createStore } from "vuex";
import authentication from "@/store/modules/authentication/index.ts";

export default createStore({
  modules: {
    authentication: authentication
  }
});

authentication module:

import { ActionContext } from "vuex";

type User = {
  id: number;
  token: string;
  name: string;
};

type State = {
  user?: User;
  loggedIn: boolean;
};

const state: State = {
  user: undefined,
  loggedIn: false
};

const getters = {
  loggedIn: (state: State) => {
    return state.loggedIn;
  },
  currentUser: (state: State) => {
    return state.user;
  }
};

const actions = {
  login({ state: State, commit }: ActionContext<State, null>, user: User) {
    commit("setUser", user);
  },
  logout({ state: State, commit }: ActionContext<State, null>) {
    commit("clearUser");
  }
};

const mutations = {
  setUser(state: State, user: User) {
    state.user = user;
    state.loggedIn = true;
  },
  clearUser(state: State) {
    state.user = undefined;
    state.loggedIn = false;
  }
};

export default {
  namespaced: true,
  state,
  getters,
  actions,
  mutations
};

Any ideas on to fix this? thanks in advance

@adamwathan Sure, take into account I understand the claims for accessibility about this PR, but I feel like the user should be responsible for that to a certain degree.

If outline: none (or outline: 0) is an option within css I think we should keep it within the framework, I guess users will have their own use cases to why they remove it and keep it (a11y), I guess that depends on what they're building and possibly their target users also.

I use outline-none within our electron app that has certain styling to elements that I don't want to have the standard outline. (I also know someone who just said to me they're using it in a three.js ui also which they removed it from) Please take into account that today tailwind isn't just used to make websites, dashboards etc but Is also used with frameworks such as React Native, Electron etc. I know it would be ideal to have everything accessible but with tailwind becoming bigger and bigger by the day the use case for the applications varies quite a lot.

I feel like the outline utility should be reworked and options added like you said outline-0 xyz, I also feel like we are missing styles such as like dotted, dashed, solid... and the rest, which I guess you could argue could be a plugin or you just make a class for it.

I personally wouldn't merge outline-none from 0 to suddenly a 2px outline, feel like the naming on that convention doesn't work well.

I hope this feedback helps, It wasn't to shut this PR down or anything like that just thought I'd address my concerns with this as to me if this got merged it would also be a breaking change in terms of how our UI works. Keep up the good work <3

I actually use outline-none because I don't want an outline at all. I think enforcing it to output an outline for accessibility etc is a bit far if that's the case it should be a configure option like you said but to me the term "none" is no outline etc even if you add outline-0 but I would use that kind of terminology to say something is none then actually has a 2px outline output. That's said I do think outline should be configurable.

<!--- Please keep this note for the community --->

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

<!--- Thank you for keeping this note for the community --->

Description

Add the name to a VPC Not supported currently from the docs (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc)

New or Affected Resource(s)

<!--- Please list the new or affected resources and data sources. --->

• aws_vpc

Potential Terraform Configuration

<!--- Information about code formatting: https://help.github.com/articles/basic-writing-and-formatting-syntax/#quoting-code --->

resource "aws_vpc" "main" {
  cidr_block = "10.0.0.0/16"
  name = "foobar"
}

At the min I've just been adding tags, but this seems an option to actually define the VPC name.

@dthvt hey, thanks for that I was aware about naming them just wasn't 100% if it was a tag etc. But I will update that now on my end. Thanks again!

<!--- Please keep this note for the community --->

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

<!--- Thank you for keeping this note for the community --->

Description

Add the name to a VPC Not supported currently from the docs (https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/vpc)

New or Affected Resource(s)

<!--- Please list the new or affected resources and data sources. --->

• aws_vpc

Potential Terraform Configuration

<!--- Information about code formatting: https://help.github.com/articles/basic-writing-and-formatting-syntax/#quoting-code --->

resource "aws_vpc" "main" {
  cidr_block = "10.0.0.0/16"
  name = "foobar"
}

At the min I've just been adding tags, but this seems an option to actually define the VPC name.

Still waiting to add variables 😆

Why was this even a change? What's the reason to it @taylorotwell @driesvints

I agree I think something is needed rather than waiting for the mean time.

Something funky still going on, just attempted to build inside WSL2 (ubuntu latest ditro):

nick@DESKTOP-JSB0V3F:/mnt/c/Users/Nick/desktop/github/mvp/mvp$ docker ps
CONTAINER ID        IMAGE               COMMAND             CREATED             STATUS              PORTS               NAMES
nick@DESKTOP-JSB0V3F:/mnt/c/Users/Nick/desktop/github/mvp/mvp$ docker-compose up --build
Removing network mvp_app
Creating network "mvp_app" with driver "bridge"
Building backend

Hangs on the building of a container within Ubuntu 😕

@stephen-turner does anyone work on docker-compose anymore i see a constant backlog of issues and no replies from anyone in this repo?

@davclark these are volumes mounted from docked-compose. It's only been affected in these latest releases.

Latest version I'm still hitting this issue again, 🤔 - https://github.com/docker/for-win/issues/8164#issuecomment-679204006

New version release.

Hi,

So I'm in the process of microservicing with oak.

I have a file structure of:

• core
• authentication
• etc etc microservices
• main.ts

So the goal is to run main.ts and it will import the routes file from each service serviceXYZ/router/routes.ts which is made up of:

import { Router } from "../../deps.ts";
import { Context } from "../types/types.ts";

const router: Router = new Router();

router.get("/", (ctx: Context) => {
  ctx.response.body = "API Server Online";
});

export { router };

So when I want to run main.ts it will do this:

const routes = expandGlobSync("*/router/routes.ts", {
  root: Deno.cwd(),
  extended: true,
});

for await (const routesWalkEntry of routes) {
  const serviceRoutes = await import(routesWalkEntry.path);
  app.use(serviceRoutes.routes());
  app.use(serviceRoutes.allowedMethods());
}

It will import each router and use that.

However... It's returning:

error: Uncaught TypeError: Unsupported scheme "c" for module "authentication\router\routes.ts". Supported schemes: [
    "http",
    "https",
    "file",
]

If I direct import the router above as one file without doing the for await, it will work. Confused by this now. 🤔 However I need this to be dynamic as we add more services in etc as they will be automated builds.

Any idea how to achieve this? thanks in advance.

Got it working for anyone for future ref:

const routes = expandGlobSync("*/router/routes.ts", {
  root: Deno.cwd(),
  extended: true,
});

for await (const routesWalkEntry of routes) {
  const { serviceRouter } = await import(`file://${routesWalkEntry.path}`);
  router.use(serviceRouter);
}

Constantly getting this now also:

And:

Traceback (most recent call last):
  File "site-packages\docker\utils\build.py", line 96, in create_archive
OSError: [Errno 22] Invalid argument: '\\\\?\\C:\\Users\\Nick\\Desktop\\GitHub\\mvp\\mvp\\backend\\vendor\\bin\\carbon'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "docker-compose", line 6, in <module>
  File "compose\cli\main.py", line 72, in main
  File "compose\cli\main.py", line 128, in perform_command
  File "compose\cli\main.py", line 1078, in up
  File "compose\cli\main.py", line 1074, in up
  File "compose\project.py", line 548, in up
  File "compose\service.py", line 367, in ensure_image_exists
  File "compose\service.py", line 1106, in build
  File "site-packages\docker\api\build.py", line 160, in build
  File "site-packages\docker\utils\build.py", line 31, in tar
  File "site-packages\docker\utils\build.py", line 100, in create_archive
OSError: Can not read file in context: \\?\C:\Users\Nick\Desktop\GitHub\mvp\mvp\backend\vendor\bin\carbon
[38084] Failed to execute script docker-compose

Seem to be constant file sharing issues, this is only on the latest version + the private build above also, if I revert it works fine. Seems to be when it's mounted.

WSL keeps shitting itself and disconnecting from these 2 versions? It's not liking mounts at all for some weird reason and randomly dropping off still?

Checked with 2 other dev machines also, we've had to roll back. No issues on actual Ubuntu machines, just seems somethings going on with WSL and Docker on windows..

Just to add is there a method like router.use() that when you import router you can import other routers into that to build up a form of tree like how express works? tia.

Full main.ts for ref:

import { Application, expandGlobSync} from "./deps.ts";
import * as middleware from "./core/middleware/middleware.ts";
import { Context } from "./core/types/types.ts";

const port = 8000;
const app = new Application<Context>();

app.use(middleware.loggerMiddleware);
app.use(middleware.timingMiddleware);
app.use(middleware.errorMiddleware);
app.use(middleware.corsMiddleware);

const routes = expandGlobSync("*/router/routes.ts", {
  root: Deno.cwd(),
  extended: true,
});

for await (const routesWalkEntry of routes) {
  const serviceRoutes = await import(routesWalkEntry.path);
  app.use(serviceRoutes.routes());
  app.use(serviceRoutes.allowedMethods());
}

app.addEventListener("listen", ({ hostname, port, secure }) => {
  const protocol = secure ? "https" : "http";
  const url = `${protocol}://${hostname ?? "localhost"}:${port}`;
  console.log(`SERVER STARTED: Listening on: ${url}`);
});

await app.listen({ port });

Hi,

So I'm in the process of microservicing with oak.

I have a file structure of:

• core
• authentication
• etc etc microservices
• main.ts

So the goal is to run main.ts and it will import the routes file from each service serviceXYZ/router/routes.ts which is made up of:

import { Router } from "../../deps.ts";
import { Context } from "../types/types.ts";

const router: Router = new Router();

router.get("/", (ctx: Context) => {
  ctx.response.body = "API Server Online";
});

export { router };

So when I want to run main.ts it will do this:

const routes = expandGlobSync("*/router/routes.ts", {
  root: Deno.cwd(),
  extended: true,
});

for await (const routesWalkEntry of routes) {
  const serviceRoutes = await import(routesWalkEntry.path);
  app.use(serviceRoutes.routes());
  app.use(serviceRoutes.allowedMethods());
}

It will import each router and use that.

However... It's returning:

error: Uncaught TypeError: Unsupported scheme "c" for module "authentication\router\routes.ts". Supported schemes: [
    "http",
    "https",
    "file",
]

Any idea how to achieve this? thanks in advance.

Update your deno version.

@justinleveck did you run a container also? the issue is intermittent

Also ^

It randomly is dropping off for some weird reason

@djs55 Same issue mate

^ Just to add also I keep getting WSL2 issues where it's enabled, then randomly disabling itself. Then intermittently it will show no distros available. Not sure if that's something with this where docker is using wsl2 then dropping off?

I've jumped into the same issue now. Update has seemed to kill this as well getting DIR errors on this update also?

Traceback (most recent call last):
  File "site-packages\docker\utils\build.py", line 96, in create_archive
OSError: [Errno 22] Invalid argument: '\\\\?\\C:\\U

However it's working on the previous version on linux right now 🤷🏻

docker-compose version 1.26.2, build eefe0d31 Docker version 19.03.13-beta2, build ff3fbc9d55

@WhoAdarshPandya I would look at modules like https://github.com/ryo-ma/deno-websocket and make suggestions or ideas on modules vs this being core functionality.

Update deno ci to v1.3.0 + std to v0.65.0

Is this a breaking change?

• [ ] Yes
• [x] No

Description:

Updates Std dep to latest version using deno v1.3.0

@halvardssm Nice little command there :) gone ahead and done them changes.

You could create a module to support that functionality but it shouldn't be standard.

Updating Deno to v1.3.0 and Std to v0.65.0

We open to creating an examples folder and putting a few examples of blueprints in there, i.e CRM, TODO List, etc.. A little "showcase" of what you can do with magic ;).

removed credentials..
OUTPUT=./output
VUE_OUTPUT=./vue
HTMLMODE=alpine|comments
TRANSFORMERS=convertVue
BUILDINDEX=1

Is generating blank vue components as:

<template>
  
</template>

<script>
export default {
  data: () => ({
	
  })
}
</script>

I would create a /controllers/UserController.ts and put all the CRUD inside that then import as { addUser, updateUser, etc..} from '../controllers/UserController.ts' opinions ?

@lucacasonato over to you mate, added the widerContent if passed as true, does what it says on the box

@lucacasonato You happy for a prop to be passed then, widerContent boolean? if true usesmax-w-screen-xl if not defaults to max-w-screen-lg ?

@lucacasonato Magic, reverted them changes now :)

Ah @lucacasonato I will revert them then, confused, should the manual and the other sections be lowercase too or?

Just added capitalisation to the "deno doc" same as the rest of the website

Remove 2 lower padding, same padding as manual now.

From:

To:

Example padding from manual:

This also fixes the responsiveness issue as well @lucacasonato

That said I think on the homepage with this change the max-w-screen-sm content sections could become max-w-screen-md and have a more reading area so they're less compact, opinions?

From this:

To this:

Looks like a previous update to a file has killed the linter. Will pull repo and run lint on the files.

Update the CI version to run as Deno v1.3.0

Updates the CI to Deno v1.3.0

Updates the CI to v1.3.0 for deno.