ULIVZ ulivz Alipay Hangzhou, China Team member of @vuejs, focus on VuePress 1.x and its ecology.

push eventulivz/awesome-vuepress

YINGYANG

commit sha f26a2f2412e271cba2f18f04f2ec292398ed3462

feat: Added "Vuepress Theme Cool Starter" to Projects Using VuePress-> Open Source (#29)

view details

push time in 21 minutes

PR merged ulivz/awesome-vuepress

Added "Vuepress Theme Cool Starter" to Projects Using VuePress-> Open…

Added "Vuepress Theme Cool Starter" to Projects Using VuePress-> Open Source

Contains many things that are in no other projects

+1 -1

0 comment

1 changed file

SenaxDev

pr closed time in 21 minutes

issue commentvuejs/vuepress

pre, next not work

Thanks for submitting this issue! To help us investigate your problem, please include a minimal reproduction using e.g. CodeSandbox, CodePen, or a GitHub repository (e.g. vuepress-global-layout-repro).

li-xiaojun

comment created time in a day

push eventvuejs/vuepress

Zaid J. Barghouthi

commit sha 41b5cfba3f0aa6e0d6b0df9a31c1eb7d3d76faa8

docs($theme-default): indicate that plugin-search is used. (#1552)

view details

push time in a day

PR merged vuejs/vuepress

Indicate that plugin-search is used.

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary Updated README.md in default-theme to indicate the usage of plugin-search

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [x] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+1 -0

0 comment

1 changed file

ZaidBarghouthi

pr closed time in a day

push eventvuejs/vuepress

zyxd

commit sha 2c930c907e4398e113ef29e7de05686638b45ee6

feat($core): infer page's date via directory name (#1553)

view details

push time in a day

PR merged vuejs/vuepress

Using directory name to get page date if it is not specified elsewhere

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [ ] Firefox
  • [x] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+23 -9

0 comment

2 changed files

zyxd

pr closed time in a day

push eventvuejs/vuepress

Haoqun Jiang

commit sha 09709540780b4d03f7b2b468d60095a6e588e94b

chore: update dependencies (#1555)

view details

push time in a day

PR merged vuejs/vuepress

chore: update dependencies

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [x] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Several dependencies have been updated to their latest majors in this PR, most of them introduced insignificant breaking changes such as dropping support for Node v4, thus won't affect end users.

The most important one is css-loader from v0.28 to v2. This change fixes a vulnerability warning caused by js-yaml "~3.7.0" (the dependency chain: css-loader@^0.28.11 > cssnano@^3.10.0 > postcss-svgo "^2.1.1" > svgo@^0.7.0 > js-yaml "~3.7.0").

+421 -736

3 comments

7 changed files

sodatea

pr closed time in a day

PR opened vuejs/vuepress

feat($core): set minimum compatible version of node to 8.0

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [ ] Firefox
  • [x] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

There are still many users using node 8 in the production environment.

+39 -30

0 comment

8 changed files

pr created time in 8 days

create barnchvuejs/vuepress

branch : feat/compatible-with-node-8

created branch time in 8 days

push eventvuejs/vuepress

ULIVZ

commit sha cafb991603152a2c0b758b9e14b4bb57f9988295

docs: fix outdated links

view details

push time in 8 days

issue closedvuejs/vuepress

Stylus is not compiled in markdown file.

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

<!-- Please confirm you will submit an issue. --> <!-- Issues which contain questions or support requests will be closed. --> <!-- (Update "[ ]" to "[x]" to check a box) -->

  • [x] I confirm that this is an issue rather than a question.

<!-- Please ask questions via following several ways. --> <!-- https://vue-land.js.org/ --> <!-- https://forum.vuejs.org/ --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress -->

Bug report

Version

1.0.0-alpha.47

Steps to reproduce

<!-- If you are reporting a bug that can ONLY be reproduced on your repository, PLEASE provide this repo link. That takes guessing work out of the way and saves us time. -->

<!-- If your repo isn't public, you can use this boilerplate to create a proper reproduction repo quickly: https://github.com/ulivz/template-vuepress -->

I have stylus code in my markdown file, but it is not compiled in browser.

Code example:

<style lang="stylus">
.test
  width 200px
</style>

What is expected?

It should be compiled to

.test {
  width: 200px;
}

What is actually happening?

Not compiled.

Other relevant information

  • Your OS: Mac
  • Node.js version: v10.15.0
  • Browser version: Chrome v75
  • Is this a global or local install? Local install.
  • Which package manager did you use for the install? Yarn.
  • Does this issue occur when all plugins are disabled? Yes.

closed time in 8 days

LasyIsLazy

issue commentvuejs/vuepress

Stylus is not compiled in markdown file.

Sorry but I cannot reproduce it.

image

LasyIsLazy

comment created time in 8 days

PR closed vuejs/vuepress

fix #764 : implement support for external links in sidebar semver: minor

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Closes #764

Summary We introduce a new type of sidebar item called 'external' which are treated differently in Sidebar/SidebarLink. These items are rendered as <a> elements with an added icon indicating that the element points to an external location.

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [X] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

vuepress-pr-external-link

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [X] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [X] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [X] Firefox v63.0
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+24 -2

9 comments

3 changed files

rasapetter

pr closed time in 8 days

pull request commentvuejs/vuepress

fix #764 : implement support for external links in sidebar

Closing in favor of #1534

rasapetter

comment created time in 8 days

push eventvuejs/vuepress

Anton Wilhelm

commit sha 141bd11e4b7e1b4d1bee53a49c232b11a36516cd

feat($theme-default): support external links in sidebar (close: #764)(#1534)

view details

push time in 8 days

issue closedvuejs/vuepress

External urls in the sidebar

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

Feature request

<!-- Please ask questions on StackOverflow. --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress --> <!-- Issues which contain questions or support requests will be closed. -->

What problem does this feature solve?

Allows users to put external URLs in the sidebar

What does the proposed API look like?

Not sure

How should this be implemented in your opinion?

I would do it exactly the same as header menu items {text: 'foo', link: 'google.com'}

Are you willing to work on this yourself?**

Yes, point me in the right direction :)

closed time in 8 days

hoppities

PR merged vuejs/vuepress

fix #764 - support external links in sidebar

Credits goes to #1012 This PR is based on top of master and has no changes in the Sidebar.vue file compared to the original.

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot: before sidebar is not rendered at all, because of an error

after sidebar is rendered with external links properly

See demo: https://hungry-yonath-bfd0a1.netlify.com/

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+22 -1

0 comment

2 changed files

timaschew

pr closed time in 8 days

push eventulivz/donate

ULIVZ

commit sha bed9448e974022e82f2f1122a219def7674deaf1

feat: update

view details

push time in 9 days

push eventulivz/donate

真山

commit sha 9e04e940de7bf31ebbcbfb856962cb2eddaaf020

update

view details

push time in 9 days

pull request commentvuejs/vuepress

feat(options): make enhancers async ready

But in the past, we all use normal functions.

Slashgear

comment created time in 9 days

PR closed vuejs/vuepress

feat(options): make enhancers async ready

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [x] Firefox
  • [x] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature
  • [ ] Related documents have been updated There is no dedicated documentation for async options for now
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

I am working on a project where I use vuepress alpha.47. I am trying to fetch dynamically information for $page data base on a frontmatter value.

Here is the code of the plugin I am trying to introduce in my project.

const { fetchUser } = require('./service');

module.exports = () => {
  const authors = {};

  return {
    name: "github",

    async extendPageData($page) {
      if($page.frontmatter.type === "post") {
        const githubProfile = $page.frontmatter.github_profile;

        if(!authors[githubProfile]){
          const fetched = await fetchUser(githubProfile); 
          authors[githubProfile] = fetched;

          $page.frontmatter.gh = fetched;
          return $page;
        }
      }
      return $page;
    }
  }
};

But extendPageData is not async ready for now. So this is my contribution to make is async ready 🎉

Tested locally with yarn link

+9 -9

0 comment

1 changed file

Slashgear

pr closed time in 9 days

Pull request review commentvuejs/vuepress

fix #764 - support external links in sidebar

 export function isActive (route, path) { }  export function resolvePage (pages, rawPath, base) {+  if (isExternal(rawPath)) {+    return {+      type: 'external',+      title: rawPath,

It looks strange to assign rawPath to title, you can omit it.

timaschew

comment created time in 9 days

Pull request review commentvuejs/vuepress

docs: clarification in Theme Inheritance usage

 For now theme inheritance doesn't support high-order inheritance, that means, a  ## Usage -Suppose you want to create a theme inherited from the default theme, you just need to configure the [extend](./option-api.md#extend) option in your theme configuration:+Suppose you want to create a theme inherited from the default theme, you just need to configure the [extend](./option-api.md#extend) option in your theme configuration (`.vuepress/theme/index.js`):

Actually you can modify the theme configuration to theme entry and link it to Glossary > themeEntry.

anisabboud

comment created time in 9 days

Pull request review commentvuejs/vuepress

docs: correct 1.x zh homepage bash commands

 footer: MIT Licensed | Copyright © 2018-present Evan You  ``` bash # 安装-yarn global add vuepress # 或者:npm install -g vuepress+yarn global add vuepress@next

Why changing this?

allen-zh

comment created time in 9 days

push eventvuejs/vuepress

ULIVZ

commit sha 1b6c4cdcd272e2108922457128e200b58a4c2f61

chore: update compatible node version

view details

push time in 9 days

issue closedvuejs/vuepress

Links to improve documentation follow improper path through Github

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

Feature request

<!-- Please ask questions on StackOverflow. --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress --> <!-- Issues which contain questions or support requests will be closed. -->

What problem does this feature solve?

When a user clicks on the "Improve this page on Github" link, they are directed to the Github page where the error is found.

The user then edits the page and, according to the Github UI, clicks "Propose Change."

From there, the user can also submit a Pull Request, based on this proposal. All of this happens automatically in the Github UI.

The problem is that a user may not realize that the Github project they are attempting to improve may have a formal Pull Request process, such as here, on Vuepress.

The formal process may include a request from the team to check boxes giving information about the Pull Request specifics.

The user has thus submitted a PR incorrectly, and the project owner is likely to reject the proposal, making this a waste of time, and if the owner does not take time to properly explain, the user will not even know why the request was rejected..

This has happened to me on a few separate occasions.

Users get lost while trying to make improvements to doc pages, and can end up improperly submitting requests.

What does the proposed API look like?

How should this be implemented in your opinion?

Instead, what should happen is that the link to "Improve this page on Github" should lead to a page that walks the user through the process of properly submitting a pull request, and provide a link to the correct page for editing.

Perhaps this is a task for those who utilize Vuepress to consider, but as this has happened to me a few times, I would imagine that automating this would be better.

Are you willing to work on this yourself?

Perhaps! I do use Vuepress daily for work, and I could probably help here.

closed time in 10 days

siddhartha-crypto

issue commentvuejs/vuepress

Hot reload doesn't normal work without --temp .temp

Since you're using a globally installed vuepress, the temp files will be placed under the global installed directory so that VuePress cannot detect the change of it.


BTW, the docs has been updated.

Xinyii

comment created time in 10 days

push eventvuejs/vuepress

ULIVZ

commit sha 2592af2a262eeb5fd42039fd5e62cf22a3e504a0

docs: update

view details

push time in 10 days

issue commentvuejs/vuepress

rollup project, all vuepress dynamic import are broken

You should at least provide a minimal repro repo to prove that it's really just a problem working with Rollup.

ale-grosselle

comment created time in 10 days

issue closedvuejs/vuepress

rollup project, all vuepress dynamic import are broken

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

<!-- Please confirm you will submit an issue. --> <!-- Issues which contain questions or support requests will be closed. --> <!-- (Update "[ ]" to "[x]" to check a box) -->

  • [ ] I confirm that this is an issue rather than a question.

<!-- Please ask questions via following several ways. --> <!-- https://vue-land.js.org/ --> <!-- https://forum.vuejs.org/ --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress -->

Bug report

Version

1.0.0-alpha.47

Steps to reproduce

In my rollup project, run decs:dev, "You may need an appropriate loader to handle this file type" import("/Users/al....")

All dynamic import are broken

What is expected?

What is actually happening?

All dynamic import are broken

Other relevant information

  • Your OS: MAC Os
  • Node.js version: 10.15.3
  • Browser version:
  • Is this a global or local install? CHROME
  • Which package manager did you use for the install? NPM
  • Does this issue occur when all plugins are disabled?

image

closed time in 10 days

ale-grosselle

issue commentvuejs/vuepress

Links with anchors don't scroll to the correct position *the first time*

Truly an issue and contribution welcome!

gauravve

comment created time in 10 days

issue closedvuejs/vuepress

back-to-top

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

<!-- Please confirm you will submit an issue. --> <!-- Issues which contain questions or support requests will be closed. --> <!-- (Update "[ ]" to "[x]" to check a box) -->

  • [x] I confirm that this is an issue rather than a question.

<!-- Please ask questions via following several ways. --> <!-- https://vue-land.js.org/ --> <!-- https://forum.vuejs.org/ --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress -->

Bug report

Version

Steps to reproduce

<!-- If you are reporting a bug that can ONLY be reproduced on your repository, PLEASE provide this repo link. That takes guessing work out of the way and saves us time. -->

<!-- If your repo isn't public, you can use this boilerplate to create a proper reproduction repo quickly: https://github.com/ulivz/template-vuepress -->

What is expected?

What is actually happening?

Other relevant information

  • Your OS: ubuntu16.04

  • Node.js version: v11.2.0

  • Browser version: Version 73.0.3683.86 (Official Build) (64-bit)

  • Is this a global or local install? global

  • Which package manager did you use for the install? npm install -D @vuepress/plugin-back-to-top@next

  • Does this issue occur when all plugins are disabled? According to the official website configuration, it cannot take effect

closed time in 10 days

qiufeihong2018

PR closed vuejs/vuepress

Reviewers
fix($test): change to mocked names

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

VuePress uses a temporary workaround for jest cannot resolve module path from 'mocks' when using 'require.resolve'. However, it will break all the tests on external packages.

Example: https://circleci.com/gh/vuepress/vuepress-plugin-mathjax/5

image

In this PR, VuePress module loader will only workaround under jest and for plugins and themes that matches the following regular expression:

const MOCKED_REGEX = /^(@vuepress\/|(@[\w-]+\/)?vuepress-)(theme|plugin)-mocked-/

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [x] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

N/A

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

N/A

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+46 -45

1 comment

20 changed files

Shigma

pr closed time in 10 days

pull request commentvuejs/vuepress

fix($test): change to mocked names

Closing this in favor of: https://github.com/vuejs/vuepress/commit/5d2fc90016a2c4738b386216f1917db8f57b42d2

Shigma

comment created time in 10 days

push eventvuejs/vuepress

ULIVZ

commit sha 5d2fc90016a2c4738b386216f1917db8f57b42d2

test: remove mock hack of `require.reesolve` ref: https://github.com/facebook/jest/pull/7687

view details

push time in 10 days

push eventvuejs/vuepress

ULIVZ

commit sha d6040f645812cc252734ced61f047f825710c77b

chore: bump jest, babel-jest, jest-serializer-vue, ts-jest

view details

push time in 10 days

push eventvuejs/vuepress

RogerIF

commit sha 005dd5b00253deb54063fec9497a6b9b5cd23bce

chore: fix typo (#1528)

view details

push time in 10 days

PR merged vuejs/vuepress

fix($test):fix spelling error of the word snippet,it used to be snipets

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary When the yarn test command is run, the test for the snippet in the result is misspelled.

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome

  • [ ] Firefox

  • [ ] Safari

  • [ ] Edge

  • [ ] IE N/A If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature

  • [ ] Related documents have been updated

  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+2 -2

0 comment

2 changed files

rogerIF

pr closed time in 10 days

push eventvuejs/vuepress

Charles Villard

commit sha f47b5fa0d579f01d28dbe458edc05350fbfc8fbc

docs: add tip to explain CSS pre-processor installation (#1530)

view details

push time in 10 days

PR merged vuejs/vuepress

Add tip to explain CSS pre-processor installation

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [X] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [X] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information: As previously in 0.x, information on installing CSS pre-processors was dissociated with the config documentation. This provides a link directly to that information from within the quick guide.

+4 -0

0 comment

1 changed file

cdvillard

pr closed time in 10 days

push eventcdvillard/vuepress

ULIVZ

commit sha afdd01dc85e2d62fbd7e77bca6dd3994a89faedb

chore: tweaks

view details

push time in 10 days

push eventvuejs/vuepress

Charles Villard

commit sha ab5814d66b35f9a97a107aa30b3d3b4b382ea47d

docs: add CSS preprocessor tip to Build Pipeline section (#1522)

view details

push time in 10 days

PR merged vuejs/vuepress

Add CSS preprocessor tip to Build Pipeline section

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [X] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [X] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information: While this document is solely concerned with documenting the configuration options, it isn't very explicit regarding structure or the addition of dependencies such as the CSS pre-processors. This change attempts to clarify that some by pointing to more instructive sections of the site better detailing how to configure CSS pre-processors.

+4 -0

2 comments

1 changed file

cdvillard

pr closed time in 10 days

push eventcdvillard/vuepress

ULIVZ

commit sha d8ba2cd6d5bfbf8aeaaabf725dc71d54720092ff

fix: link usage

view details

push time in 10 days

push eventcdvillard/vuepress

ULIVZ

commit sha 2ec188a2a47f224eab3db6b44b75eba5f8fae799

chore: using md

view details

push time in 10 days

issue commentvuejs/vuepress

Group in sidebar is not expanded for deep nested children

The group (Frameworks) in the sidebar is not expanded. You need to expand the first group manually.

Isn't this the default behavior of a sidebar group?

timaschew

comment created time in 10 days

Pull request review commentvuejs/vuepress

fix #764 - support external links in sidebar

 function renderChildren (h, children, path, route, maxDepth, depth = 1) {     ])   })) }++function renderExternal (h, to, text) {+  return h('a', {+    attrs: {+      href: to,+      target: '_blank'

Added rel: 'noopener noreferrer' here.

timaschew

comment created time in 10 days

issue commentvuejs/vuepress

Group in sidebar is not expanded for deep nested children

I cannot reproduced at your repro. Did you update it?

timaschew

comment created time in 10 days

push eventvuejs/vuepress

Shigma

commit sha 441f0232c86ecbf526689153219a560ad4ccbe07

feat($core): prevent duplicate route (#1525)

view details

push time in 10 days

PR merged vuejs/vuepress

feat($core): prevent duplicate route

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

If we add multiple pages with the same path (i.e. theme has already provided a homepage but we want to override it), VuePress client will break with the following message:

[vue-router] Duplicate named routes definition: { name: "v-b2754d56", path: "" }

This PR prevent from adding duplicate route. If a duplicate route was to be add, it will override the old one.

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+8 -1

0 comment

1 changed file

Shigma

pr closed time in 10 days

push eventvuejs/vuepress

ULIVZ

commit sha 2a4ba9fef6634abae96c2d734d92b62a6620e555

chore: tweaks

view details

push time in 10 days

startedwhatwg/url

started time in 11 days

startedsmooth-code/loadable-components

started time in 11 days

Pull request review commentvuejs/vuepress

feat($core): prevent duplicate route

 module.exports = class App {       computed: new this.ClientComputedMixinConstructor(),       enhancers: this.pluginAPI.getOption('extendPageData').items     })-    this.pages.push(page)+    const index = this.pages.findIndex(({ path }) => path === page.path)+    if (index >= 0) {+      // override a page if corresponding path already exists+      if (!this.pages[index].overridable) {+        logger.warn(`Override existing page ${chalk.yellow(page.path)}.`)

If it's a flag to control the overridable of a page, should it wrap the splice operation?

Shigma

comment created time in 11 days

IssuesEvent

push eventvuejs/vuepress

Rahul Kadyan

commit sha 9efc6785b2744541866c02708e7c72c1c33475f6

fix($core): use directory name to compute slug if filename is readme or index (close: #1443) (#1535)

view details

push time in 11 days

PR merged vuejs/vuepress

fix #1443: Use directory name to compute slug if filename is readme or index

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> Summary

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number) fix #1443

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+30 -3

0 comment

1 changed file

znck

pr closed time in 11 days

issue closedvuejs/vuepress

Generates invalid slug for readme.md/index.vue

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

<!-- Please confirm you will submit an issue. --> <!-- Issues which contain questions or support requests will be closed. --> <!-- (Update "[ ]" to "[x]" to check a box) -->

  • [x] I confirm that this is an issue rather than a question.

<!-- Please ask questions via following several ways. --> <!-- https://vue-land.js.org/ --> <!-- https://forum.vuejs.org/ --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress -->

Bug report

Version 1.0.0-alpha.44

Steps to reproduce

Create a file _posts/my-new-article/readme.md with permalink :slug <!-- If you are reporting a bug that can ONLY be reproduced on your repository, PLEASE provide this repo link. That takes guessing work out of the way and saves us time. -->

<!-- If your repo isn't public, you can use this boilerplate to create a proper reproduction repo quickly: https://github.com/ulivz/template-vuepress -->

What is expected?

The route should be /my-new-article

What is actually happening?

The route is /readme

closed time in 11 days

znck

push eventvuejs/vuepress

ULIVZ

commit sha fb324d54c78e9177d1747b9e5fa39302cd0bc8e9

fix($core): webpack externals (ref: #451)

view details

push time in 11 days

pull request commentvuejs/vuepress

fix #451: fix webpack externals

Out at 0.14.11. ❤️

egoist

comment created time in 11 days

created tagvuejs/vuepress

tagv0.14.11

📝 Minimalistic Vue-powered static site generator

created time in 11 days

push eventvuejs/vuepress

ULIVZ

commit sha 6897b421b5d3ce0e07a2942ad961adb2f0401271

0.14.11

view details

ULIVZ

commit sha 15377f6c7460dc8459c388d7f56b0b494a8ad4b9

chore: changelog

view details

push time in 11 days

push eventvuejs/vuepress

EGOIST

commit sha aaf4a7bca073aa50e8da110a06baef2030a396c9

fix($core): unexpected webpack externals (close: #451) (#1539)

view details

push time in 11 days

PR merged vuejs/vuepress

fix #451: fix webpack externals

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+1 -1

1 comment

1 changed file

egoist

pr closed time in 11 days

issue closedvuejs/vuepress

IE支持性太差了,希望兼容到至少IE10以上吧?

image

如图所示,用IE打开官网直接就炸了。。。唔,是不是要做一些兼容呢?

closed time in 12 days

keer6

issue closedulivz/awesome-vuepress

Add objection.js to the list

Objection - a node ORM - just changed their website from Slate to VuePress, and should be included in the list

closed time in 15 days

JaneJeon

issue commentulivz/awesome-vuepress

Add objection.js to the list

Feel free to create a pull request.

JaneJeon

comment created time in 15 days

Pull request review commentvuejs/vuepress

feat($core): prevent duplicate route

 module.exports = class App {       computed: new this.ClientComputedMixinConstructor(),       enhancers: this.pluginAPI.getOption('extendPageData').items     })-    this.pages.push(page)+    const index = this.pages.findIndex(({ path }) => path === page.path)+    if (index >= 0) {+      this.pages.splice(index, 1, page)

It would be better to emit a warning with previous and actual active route here.

Shigma

comment created time in 17 days

issue commentvuejs/vuepress

First time anchor URL navigation locks sidebar highlighting after yarn build

Actually it is a bug of markdown-it-toc, which will generate <div> in <p> (incorrect html). In fact, 0.x docs have the same problem.

Aren't you fixing it now?

KyleJShaver

comment created time in 18 days

push eventvuejs/vuepress

ULIVZ

commit sha 23b0ce3efc69df06d3d2ac70c987348b3c06078a

chore: changelog

view details

push time in 18 days

push eventvuejs/vuepress

ULIVZ

commit sha edc3733669c33c5a527430110aa0368d9d4f8a50

chore: 1.0.0-alpha.47 changelog

view details

push time in 18 days

created tagvuejs/vuepress

tagv1.0.0-alpha.47

📝 Minimalistic Vue-powered static site generator

created time in 18 days

push eventvuejs/vuepress

ULIVZ

commit sha 78ce258b22f399eac7e16aa87bf06373f752e477

v1.0.0-alpha.47

view details

push time in 18 days

issue commentvuejs/vuepress

Using Local Workbox Files Instead of CDN

Fixed at 4640614. In 1.x you can get this by:

module.exports = {
  plugins: [
    ['@vuepress/pwa', {
       serviceWorker: true,
       updatePopup: true,
       generateSWConfig: {
         importWorkboxFrom: 'local'
       }
    }],
  ]
}
SebastianNiemann

comment created time in 18 days

push eventvuejs/vuepress

ULIVZ

commit sha 9420ca92332f21ef81e2f9046286111983810b59

chore: bump to optimize-css-assets-webpack-plugin@5.0.1

view details

ULIVZ

commit sha 46406148f630fa1f83ff93ab1a7ceff122e9a86c

feat($plugin-pwa): allow using local workbox files (close: #539)

view details

push time in 18 days

issue closedvuejs/vuepress

Using Local Workbox Files Instead of CDN

Feature request

Using local workbox files for the service worker, instead of loading them from a CDN.

What problem does this feature solve?

By using the CDN, any client will automatically open a connection to https://storage.googleapis.com/workbox-cdn/releases/... and inevitably transmit his IP address, which is regarded as personal information under EU law. As under the European General Data Protection Regulation, the site owner is responsible for any leak of personal information that is shared or made accessibly because of his site. Therefore, the site owner must obtain the clients permission in advance, or be able to ensure that no such information is shared/accessible.

This is especially a concern for services like workbox, since if many pages include it via a CDN, tracking a client between different sites becomes possible, which is even more restricted.

What does the proposed API look like?

Depending on the favoured solution, this would either need an additional config to let the site owner decide whether local files or the CDN should be used, or no changes at all if we could switch from CDN-only to local-only.

How should this be implemented in your opinion?

Instead of using the CDN, local files could be used as described under https://developers.google.com/web/tools/workbox/modules/workbox-sw

This would also be the easiest option compared to obtaining the clients permission beforehand. In addition, this also seems to comply with Privacy by Design and Default -- which is also a European General Data Protection Regulation requirement.

If I saw it correctly, the package workbox-build is used for this process, together with the generateSW function.

As of https://developers.google.com/web/tools/workbox/reference-docs/latest/module-workbox-build, the source could easily be switched from CDN to local by adding importWorkboxFrom: 'local' to the function call. As stated in the documentation, this should also cover copying all needed files.

Are you willing to work on this yourself?

Sure 👍

I will gladly submit a pull request that adds importWorkboxFrom: 'local' to generateSW as well as making it configurable if required.

closed time in 18 days

SebastianNiemann

issue commentvuejs/vuepress

First time anchor URL navigation locks sidebar highlighting after yarn build

@Shigma Could you follow up on this ASAP? If it's not easy to solve, please roll back to the original TOC.

KyleJShaver

comment created time in 18 days

issue commentvuejs/vuepress

vuepress dev <projectDir> goes ahead even if the directory doesn't exist

Updated at https://github.com/vuejs/vuepress/commit/6da9a5f112fae442ca26b14374d18ca560769053

open-source-explorer

comment created time in 18 days

push eventvuejs/vuepress

ULIVZ

commit sha 6da9a5f112fae442ca26b14374d18ca560769053

feat($core): emit warning if the source directory doesn't exist (close: #1521)

view details

push time in 18 days

issue closedvuejs/vuepress

vuepress dev <projectDir> goes ahead even if the directory doesn't exist

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

<!-- Please confirm you will submit an issue. --> <!-- Issues which contain questions or support requests will be closed. --> <!-- (Update "[ ]" to "[x]" to check a box) -->

  • [x] I confirm that this is an issue rather than a question.

<!-- Please ask questions via following several ways. --> <!-- https://vue-land.js.org/ --> <!-- https://forum.vuejs.org/ --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress -->

Bug report

Steps to reproduce

<!-- If you are reporting a bug that can ONLY be reproduced on your repository, PLEASE provide this repo link. That takes guessing work out of the way and saves us time. -->

<!-- If your repo isn't public, you can use this boilerplate to create a proper reproduction repo quickly: https://github.com/ulivz/template-vuepress -->

What is expected?

vuepress dev <directory> should show an appropriate warning if the directory doesn't exist.

What is actually happening?

The default template is being served.

System: OS: Linux 4.18 Ubuntu 18.10 (Cosmic Cuttlefish) CPU: (4) x64 Intel(R) Core(TM) i5-7200U CPU @ 2.50GHz Shell: 4.4.19 - /bin/bash Binaries: Node: 8.11.4 - /usr/bin/node Yarn: 1.13.0 - /usr/local/bin/yarn npm: 6.9.0 - /usr/local/bin/npm Browsers: Chrome: 73.0.3683.75 Firefox: 66.0.2

closed time in 18 days

open-source-explorer

issue commentvuejs/vuepress

vuepress dev <projectDir> goes ahead even if the directory doesn't exist

Maybe we should emit warning instead of an error since a VuePress application can be all composed with dynamic additionalPages.

open-source-explorer

comment created time in 18 days

push eventvuejs/vuepress

Siddhartha Crypto

commit sha 09f53469eaaae527bcaf18e40d01b5d7bc42962e

docs: add information about absolute paths for `.vuepress/public` dir (#1511)

view details

push time in 18 days

PR merged vuejs/vuepress

add information about absolute paths for .vuepress/public dir

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [x] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [x] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+9 -0

0 comment

1 changed file

siddhartha-crypto

pr closed time in 18 days

push eventvuejs/vuepress

Shigma

commit sha 74887c50da1001df27b9ece1d8f10cb611ac4728

feat($core): assert return type for functional plugin (#1516)

view details

push time in 18 days

PR merged vuejs/vuepress

fix($core): assert object return type for functional plugin

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

// vuepress-plugin-foo.js
module.exports = () => {}

VuePress should show error and fallback to {} when confronted with such situations.

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [ ] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [ ] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

N/A

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

+8 -0

1 comment

1 changed file

Shigma

pr closed time in 18 days

pull request commentvuejs/vuepress

fix($core): assert object return type for functional plugin

Maybe it should be a feature.

Shigma

comment created time in 18 days

push eventvuejs/vuepress

Nick Evans

commit sha 5c307c99b940bfd8081e53e814fb8e415051dcf1

fix($markdown): Snippets should allow spaces in file path (closes #1505) (#1517)

view details

push time in 18 days

issue closedvuejs/vuepress

Snippet file "not found" error if the path has a space in it

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

<!-- Please confirm you will submit an issue. --> <!-- Issues which contain questions or support requests will be closed. --> <!-- (Update "[ ]" to "[x]" to check a box) -->

  • [x] I confirm that this is an issue rather than a question.

<!-- Please ask questions via following several ways. --> <!-- https://vue-land.js.org/ --> <!-- https://forum.vuejs.org/ --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress -->

Bug report

Including a snippet fails if there is a space anywhere in the path name. This snippet:

<<< @/docs/dev/tools/Test File.js

Results in an error showing the cut-off filename:

Not found: /Users/myuser/dev/my-cool-website/docs/dev/tools/Test

This happens if the space is in the @ alias (for cwd) -- I can rename the files under docs/, but when this builds in my CI env, there's a space that is outside of my control, which is really unfortunate!

Version

I am using 0.14.10.

Looking at the snippet code in the 1.x branch, I believe 1.x would be affected as well.

Steps to reproduce

  1. Create a page & include the snippet Test Doc.js
  2. Create a Test Doc.js file
  3. View the page & see the error.

<!-- If you are reporting a bug that can ONLY be reproduced on your repository, PLEASE provide this repo link. That takes guessing work out of the way and saves us time. -->

<!-- If your repo isn't public, you can use this boilerplate to create a proper reproduction repo quickly: https://github.com/ulivz/template-vuepress -->

What is expected?

The snippet should be included in the page.

What is actually happening?

The snippet is not being included in the page.

Other relevant information

  • Your OS: OS X 10.13.6
  • Node.js version: v11.12.0
  • Browser version: n/a
  • Is this a global or local install? Local
  • Which package manager did you use for the install? Yarn
  • Does this issue occur when all plugins are disabled? Yes

closed time in 18 days

nie7321

PR merged vuejs/vuepress

fix($markdown): Snippets should allow spaces in file path (closes #1505)

<!-- Please don't delete this template -->

<!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) -->

Summary

What kind of change does this PR introduce? (check at least one)

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update
  • [ ] Refactor
  • [ ] Docs
  • [ ] Build-related changes
  • [ ] Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • [ ] Yes
  • [x] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • [x] Chrome
  • [ ] Firefox
  • [ ] Safari
  • [ ] Edge
  • [ ] IE

If adding a new feature, the PR's description includes:

  • [ ] A convincing reason for adding this feature
  • [ ] Related documents have been updated
  • [ ] Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information: Ports 0.x fix from https://github.com/vuejs/vuepress/pull/1509 to 1.x.

+21 -1

0 comment

5 changed files

nie7321

pr closed time in 18 days

Pull request review commentvuejs/vuepress

Add CSS preprocessor tip to Build Pipeline section

 module.exports = {  ## Build Pipeline +:::tip Configuring CSS Pre-processors+VuePress comes with built-in webpack config for the CSS pre-processors listed below. For more information on installation these or pre-processors without built-in support, see (Using Pre-Processors)[https://vuepress.vuejs.org/guide/using-vue.html#using-pre-processors] for more information.+:::

BTW, you should use relative path of source markdown files (../guide/using-vue.md#using-pre-processors) here.

cdvillard

comment created time in 18 days

issue commentvuejs/vuepress

Index.styl is not injected at the end of the style bundle

Fixed at https://github.com/vuejs/vuepress/commit/dabf506022978ecf5101ff49cc9de1776a552ab5

Slashgear

comment created time in 18 days

push eventvuejs/vuepress

ULIVZ

commit sha dabf506022978ecf5101ff49cc9de1776a552ab5

fix($core): `Index.styl` is not injected at the end of the style bundle (close: #1523) BTW, A theme cannot require the theme's styles at the layout but need use `Index.styl` instead.

view details

push time in 18 days

issue closedvuejs/vuepress

Index.styl is not injected at the end of the style bundle

<!-- Please don't delete this template or we'll close your issue --> <!-- Before creating an issue please make sure you are using the latest version of VuePress. -->

<!-- Please confirm you will submit an issue. --> <!-- Issues which contain questions or support requests will be closed. --> <!-- (Update "[ ]" to "[x]" to check a box) -->

  • [x] I confirm that this is an issue rather than a question.

<!-- Please ask questions via following several ways. --> <!-- https://vue-land.js.org/ --> <!-- https://forum.vuejs.org/ --> <!-- https://stackoverflow.com/questions/ask?tags=vuepress -->

Bug report

Version

1.0.0-alpha.46

Steps to reproduce

Try to override body background color in index.styl file. For example,

body {
  background-color: black;
}

The body will use default theme and won't be black. <!-- If you are reporting a bug that can ONLY be reproduced on your repository, PLEASE provide this repo link. That takes guessing work out of the way and saves us time. -->

<!-- If your repo isn't public, you can use this boilerplate to create a proper reproduction repo quickly: https://github.com/ulivz/template-vuepress -->

What is expected?

Custom style in injected at the end of style bundle

What is actually happening?

Style is injected at the beginning of the bundle, so there is no way to override defaut theme. 😭

Other relevant information

  • Your OS: MacOs 10.14.4
  • Node.js version: 10.15
  • Browser version: Safari 12.1
  • Is this a global or local install? local
  • Which package manager did you use for the install? yarn
  • Does this issue occur when all plugins are disabled? no

closed time in 18 days

Slashgear

push eventulivz/vuepress-plugin-yuque

ULIVZ

commit sha 7be619510969cc62ababf222ce08c2b90ea9a525

docs: enable yuqueLink

view details

push time in 19 days

created tagulivz/vuepress-plugin-yuque

tagv0.6.0

Input: Yuque Repo, Output: VuePress Site!

created time in 19 days

push eventulivz/vuepress-plugin-yuque

ULIVZ

commit sha b3d7d066a1ad06ad462f74e52c98b7c89caa3ad1

feat: yuqueLink & yuqueLinkHtml option

view details

push time in 19 days

push eventulivz/vuepress-plugin-yuque

ULIVZ

commit sha 2a0b86b4aa504d6dba5b55c63af69f63283cbf71

fix: typo

view details

ULIVZ

commit sha c392600e95e889c6dd61d0f7cfd0ad248e254b62

0.5.5

view details

push time in 19 days

created tagulivz/vuepress-plugin-yuque

tagv0.5.5

Input: Yuque Repo, Output: VuePress Site!

created time in 19 days

more