profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tv-openbig/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Thorsten Vocks tv-openbig big-consulting GmbH Deutschland http://www.openbig.org

tv-openbig/docker-runbot 1

Docker Image for the LasLabs' Odoo Runbot Environment

tv-openbig/aeroo_reports 0

Aeroo Reports

tv-openbig/InstallScript 0

Odoo install script

tv-openbig/odoo-mirror 0

Mirrored Odoo

tv-openbig/Odoo_Samples 0

This repository contains samples with Odoo code

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_skr03_mis_reports

@hkapatel-initos Do we really need the dependency to l10n_generic_coa ?

hkapatel-initos

comment created time in 2 hours

pull request commentOCA/l10n-germany

[14.0] [mig] l10n_de_tax_statement

Hello, @tv-opening now all the checks are passed and the issue is resolved.

Hello @hkapatel-initos , is it really a good idea to put l10n_generic_coa as a dependency to solve the travis test issue ? Do we now install the generic "odoo demo" accounts as well beneath the l10n_de_skr03 or l10n_de_skr04 accounts ? Is there a way to bypass the reference to l10n_generic_coa reference in the test itself ?

Done, I have removed the l10n_generic_coa dependencies and fix the issue in the test case.

Hello @hkapatel-initos , i did a manual check once again. We still suffer from an issue. Now invoices are visible by clicking on the lense icon to see the details behind a base and / or a tax value:

Bildschirmfoto 2021-09-28 um 09 56 12

However there is no special tax_tag_ids filter applied. The correct tax_tag_ids should be in the domain. Now all results are the same as there seems no domain applied on the detailed results query. As you can see in the screenshot we have invoices with +41 base, +41 tax, +81 base, +81 tax in the tax_tag_ids column as well as an entry without any tax_tag_id value. It should be visible either +41 base / +41 tax (result should be the same) or +81 base, + 81 tax (result should be the same) lines only in my example. Invoices without any tax_tag_id should be excluded.

Bildschirmfoto 2021-09-28 um 10 07 34

Here in my test case the line 20 should represent the +41 base / +41 tax tax_tag_ids domain. The line 26 should represent the +81 base / +81 tax tax_tag_ids domain (as an example).

dsolanki-initos

comment created time in 6 hours

PR merged OCA/l10n-germany

[13.0][mig]l10n_de_skr04_mis_reports approved ready to merge
+3042 -1

7 comments

12 changed files

hkapatel-initos

pr closed time in 6 hours

push eventOCA/l10n-germany

David Guhrmann

commit sha a9643935ad3c8c2f4938c007e85e6ee54e644f71

updated for odoo v12

view details

hkapatel

commit sha c01e2f31f6e78217c8d4849d810ffafd39f00017

[IMP] l10n_de_skr04_mis_reports: black, isort, prettier

view details

hkapatel

commit sha 1f1042edce481e2901dcb428bb813d68753dc2e6

[MIG] l10n_de_skr04_mis_reports: Migration to 13.0

view details

Thorsten Vocks

commit sha aa69e058eb518f5224cb3ccca99447d9b8b243be

Merge pull request #91 from initOS/13.0-mig-l10n_de_skr04_mis_reports [13.0][mig]l10n_de_skr04_mis_reports

view details

push time in 6 hours

pull request commentOCA/l10n-germany

[14.0] [mig] l10n_de_tax_statement

Hello, @tv-opening now all the checks are passed and the issue is resolved.

Hello @hkapatel-initos , is it really a good idea to put l10n_generic_coa as a dependency to solve the travis test issue ? Do we now install the generic "odoo demo" accounts as well beneath the l10n_de_skr03 or l10n_de_skr04 accounts ? Is there a way to bypass the reference to l10n_generic_coa reference in the test itself ?

dsolanki-initos

comment created time in 4 days

push eventOCA/l10n-germany

fkantelberg

commit sha ebdb39892586345b37648cdb99210e8a8191ebb4

[11.0] German toponyms (#34)

view details

oca-travis

commit sha a7dc34b5582af76c6258e6633053dadef763d6b8

[UPD] Update l10n_de_toponyms.pot

view details

Thorsten Vocks

commit sha 83c97bafb1e8bb4451cc124aa141f5a268b7cd6c

fix of pylint and travis errors ************* Module l10n_de_toponyms l10n_de_toponyms/wizard/l10n_de_toponyms_zipcodes.xml:1: [W7930(file-not-used), ] not used from manifest ************* Module l10n_de_tax_statement_zm l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Enumerated list ends without a blank line; unexpected unindent. l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Inline emphasis start-string without end-string. l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Inline emphasis start-string without end-string. ----------------------------------- Your code has been rated at 9.87/10

view details

Frederik Kramer

commit sha ad756eb494b709ab0b2866fd493561343dc90750

Translated using Weblate (German) Currently translated at 100.0% (15 of 15 strings) Translation: l10n-germany-11.0/l10n-germany-11.0-l10n_de_toponyms Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-11-0/l10n-germany-11-0-l10n_de_toponyms/de/

view details

hkapatel

commit sha b5572780c8f0622bee9ee66be2dec1a525ab7cff

[MIG] l10n_de_toponyms: Migration to 14.0

view details

hkapatel

commit sha 970a6480d5ca727bd09a791165a573e863fd7431

[IMP] l10n_de_toponyms: black, isort, prettier

view details

hkapatel

commit sha caa481f9c87b751c4da58275c87609685f026162

[MIG] l10n_de_toponyms: Migration to 13.0

view details

Thorsten Vocks

commit sha f8c960765ad2c3ef647c3b9de287a34213372a97

Merge pull request #90 from initOS/13.0-mig-l10n_de_toponyms [13.0][mig]l10n_de_toponyms

view details

push time in 5 days

PR merged OCA/l10n-germany

[13.0][mig]l10n_de_toponyms approved ready to merge
+385 -0

3 comments

14 changed files

hkapatel-initos

pr closed time in 5 days

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_toponyms

@hkapatel-initos May you force-push once again, as the dependency to l10n_de_country_states was merged some minutes ago ?

hkapatel-initos

comment created time in 5 days

push eventOCA/l10n-germany

Antonio Espinosa

commit sha b8059a6c5b97ad55616b5a937fa20bd794de950e

[ADD] l10n_de_country_states addon

view details

Yannick Vaucher

commit sha 51403e3eb2094a5c8ef60c3ec9bf44503631131e

Add bug tracker link on README.rst

view details

Stéphane Bidoul

commit sha aa3734eaf52fd63ff9d73399b60dddd0c69b7ec6

[UPD] prefix versions with 8.0

view details

Pedro M. Baeza

commit sha e8c4d59be390c94cd71936842060c6f4484fdf21

[MIG] Migration operations: * Make modules uninstallable * Rename manifest files

view details

Stéphane Bidoul (ACSONE)

commit sha 36eaf1e9cd1fdb3ec1ae69c8fc67d5f1cf087e62

fix website url in manifest

view details

David Vidal

commit sha 85c31b34e1cb9bd430965bc11d3280c9bac1ae9b

[MIG] l10n_de_country_states: Migration to 10.0

view details

ralwafaie

commit sha dc95bd84946c3928cdb9fb692d9a7b260cd0d896

[MIG] l10n_de_country_states: Migration to 11.0

view details

Alexandre Díaz

commit sha 58c0d4e7a3a71e57fbc463444fcc507887175c7f

[MIG] l10n_de_country_states: Migration to 12.0

view details

oca-travis

commit sha 2a9996bab9ec5001b8d57d1ae75bbccb5cae4a90

[UPD] Update l10n_de_country_states.pot

view details

OCA-git-bot

commit sha dda24c6040b5ac128e85c39e0a07cb619454ce4b

[UPD] README.rst

view details

hkapatel

commit sha e6eb8c44da7cfd213edff62f02707427df801c9a

[IMP] 10n_de_country_states: black, isort, prettier

view details

helly

commit sha 70e6d7dbc6f571a7d684082c527766f800ccae21

[MIG] l10n_de_country_states: Migration to 13.0

view details

Thorsten Vocks

commit sha ee754118163ef5017bcb981248618aed755efaf3

Merge pull request #85 from initOS/13.0-mib-l10n_de_country_states [13.0][mig]l10n_de_country_states

view details

push time in 5 days

PR merged OCA/l10n-germany

[13.0][mig]l10n_de_country_states approved ready to merge
+831 -0

8 comments

15 changed files

hkapatel-initos

pr closed time in 5 days

push eventOCA/l10n-germany

Yu Weng

commit sha d6795f8137a071f4baa45191443ee49d3c9ad758

[ADD] l10n_de_holidays addon

view details

oca-travis

commit sha 98ccb87cafc419d3059a322b77ede465fb6529db

[UPD] Update l10n_de_holidays.pot

view details

OCA-git-bot

commit sha 80febaab6e6e69ac5b2452273c01bdd12d75564b

[ADD] icon.png

view details

Nasser

commit sha ba13d87b5944fa16eb491e0a84dbdc650e1749bb

[UPD] edit version number from 11 to 12 in manifest file

view details

Nasser

commit sha 44d69fd89773f4562d4e022778602bb27ec1aa53

[UPD] Move hr_holidays_public_generator_de file into l10n_de_holidays The file has been deleted from hr_holidays_public when migrating code from 11.0 to 12.0 because it's specific to Germany by allowing us to autogenerate holidays' date for german states

view details

Nasser

commit sha d1aad376275d087093502ae73d5f6debefc36697

[REM] remove dependency from l10n_de_country_states Because in Odoo 12, german states are now defined in the module l10n_de

view details

Nasser

commit sha 46f0d873edf3d78a8130fb07e8f8446a9439bafd

[IMP] add country id when query states

view details

Nasser

commit sha 6d2f909f8b8300a862fe6a31ac5aa177c8f1be7a

[FIX] TypeError: strptime() argument 1 must be str, not datetime.date

view details

Nasser

commit sha 0043e9bf0b2d9f266824ec0256c40a7a26c3f88c

[FIX] W0102: Dangerous default value [] as argument

view details

Nasser

commit sha 275b33943b0070db423ab551f1515dd449caa95d

[FIX] add _description to avoid warning message

view details

hkapatel

commit sha 5ec1e0848ea9518d9fa0127877e94fba09c8adfe

[IMP] l10n_de_holidays: black, isort, prettier

view details

hkapatel

commit sha a1d846cd1a1f51dc4e2c57d802cf90fc83d11d52

[MIG] l10n_de_holidays: Migration to 13.0

view details

Thorsten Vocks

commit sha 5680f410b53551e12a389c8afdf787fa65a646a1

Merge pull request #86 from initOS/13.0-mig-l10n_de_holidays [13.0][mig]l10n_de_holidays

view details

push time in 6 days

PR merged OCA/l10n-germany

[13.0][mig]l10n_de_holidays approved ready to merge

V12 PR: https://github.com/OCA/l10n-germany/pull/76 add oca_dependencies.txt on this module

+945 -0

6 comments

17 changed files

hkapatel-initos

pr closed time in 6 days

pull request commentOCA/l10n-germany

[14.0] [mig] l10n_de_tax_statement

Hello, @tv-openbig could you please re-check this and Travis is failed because of https://app.travis-ci.com/github/OCA/l10n-germany/jobs/538380311#L2208

Hello @hkapatel-initos, Hello @astirpe ,

the solution key will be imho to compare the test file from the follwing commit, as the logic from l10n_de_tax_statement was adopted from l10n_nl_tax_statement module: https://github.com/OCA/l10n-netherlands/commit/e7f9d7cabc32feb1d52e98b1a92c4012581ff613# The travis error is a missing reference to ... ValueError: External ID not found in the system: l10n_generic_coa.configurable_chart_template

The module l10n_generic_coa is a dependency in l10n_us module. It is neither included in l10n_nl nor in l10n_de. However the test from the "OCA/l10n-netherlands" commit of the module l10n_nl_tax_statement, which i have referenced above also have some references to l10n_generic_coa.configurable_chart_template without a travis error on their merge attempt. Finally it seems we miss in our german test file the logic to define sub companies at first. It is just a guess from my side, as i am not a developer and therefore it is diffficult for me to read and write the test files.

The following is included approx. at line 30 ff in the netherlands test file and not included in german test file so far: def _create_company_children(self): self.company_child_1 = self.env["res.company"].create( { "name": "Child 1 Company", "country_id": self.env.ref("base.nl").id, "parent_id": self.company_parent.id, } ) self.env.user.company_id = self.company_child_1 self.coa.try_loading_for_current_company() self.coa.try_loading() self.company_child_2 = self.env["res.company"].create( { "name": "Child 2 Company", "country_id": self.env.ref("base.be").id, "parent_id": self.company_parent.id, } ) self.env.user.company_id = self.company_child_2 self.coa.try_loading_for_current_company() self.coa.try_loading() self.env.user.company_id = self.company_parent

For sure the first company should reference in our case to "base.de" instead of "base.nl". Then in the setup part it is also a bit different (approx. line 50): def setUp(self): super().setUp()

    self.eur = self.env["res.currency"].search([("name", "=", "EUR")])
    self.coa = self.env.ref("l10n_nl.l10nnl_chart_template", False)
    self.coa = self.coa or self.env.ref(
        "l10n_generic_coa.configurable_chart_template"
    )
    self.company_parent = self.env["res.company"].create(
        {
            "name": "Parent Company",
            "country_id": self.env.ref("base.nl").id,
            "currency_id": self.eur.id,
        }
    )
    self.env.user.company_id = self.company_parent

Hopefully this could bypass to remark the missing dependency to l10n_generic_coa module: External ID not found in the system: l10n_generic_coa.configurable_chart_template

Best regards Thorsten

dsolanki-initos

comment created time in 6 days

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_skr03_mis_reports

@hkapatel-initos In oca_dependencies.txt was mis_builder in line 3. Shouldn't it be mis-builder ?

hkapatel-initos

comment created time in 11 days

issue commentOCA/account-financial-reporting

[14.0][BUG] account_financial_report : issue with columns of first line

Steps to reproduce it?

1.) Invoicing App / Reporting / OCA accounting reports / Journal Ledger 2.) Select a start/end date or a pre-defined date_range (with account moves for sure) 3.) Click on "View"

tv-openbig

comment created time in 12 days

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_skr03_mis_reports

@hkapatel-initos

The functional test was successfull: Bildschirmfoto 2021-09-15 um 08 58 13

hkapatel-initos

comment created time in 13 days

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_country_states

@tv-openbig Maybe I missed it, but why do you want to merge with failed travis checks?

@kmatthes That's correct. I have removed the "ready to merge" label. From functional side, the module is working on a local installation.

hkapatel-initos

comment created time in 13 days

push eventOCA/l10n-germany

fkantelberg

commit sha 71952aa7facf780f11ece794b775a1349f75f8e4

[11.0] German toponyms (#34)

view details

oca-travis

commit sha d1ba03626bc77de5ac9f760d46030de7e90909de

[UPD] Update l10n_de_toponyms.pot

view details

Thorsten Vocks

commit sha 41ae28b0d480f655e756ba9d1c7b80702d1bc5dc

fix of pylint and travis errors ************* Module l10n_de_toponyms l10n_de_toponyms/wizard/l10n_de_toponyms_zipcodes.xml:1: [W7930(file-not-used), ] not used from manifest ************* Module l10n_de_tax_statement_zm l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Enumerated list ends without a blank line; unexpected unindent. l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Inline emphasis start-string without end-string. l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Inline emphasis start-string without end-string. ----------------------------------- Your code has been rated at 9.87/10

view details

Frederik Kramer

commit sha 77f58ad76baf57dc8585486195ca558e607f7ee3

Translated using Weblate (German) Currently translated at 100.0% (15 of 15 strings) Translation: l10n-germany-11.0/l10n-germany-11.0-l10n_de_toponyms Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-11-0/l10n-germany-11-0-l10n_de_toponyms/de/

view details

hkapatel

commit sha e9277b14d67c4150f3052a89458e34ae5f65d686

[MIG] l10n_de_toponyms: Migration to 12.0

view details

Thorsten Vocks

commit sha 411fdbf402f875c22d02624ecc5e625e8d6699e9

Merge pull request #89 from initOS/12.0-mig-l10n_de_toponyms [12.0][mig]l10n_de_toponyms

view details

push time in 13 days

PR merged OCA/l10n-germany

[12.0][mig]l10n_de_toponyms needs fixing
+380 -0

7 comments

12 changed files

hkapatel-initos

pr closed time in 13 days

pull request commentOCA/l10n-germany

[12.0][mig]l10n_de_toponyms

Hello, @tv-openbig Travis issue is resolved and All checks are passed.

Hello @hkapatel-initos Thanks a lot for your efforts! I will merge your PR.

hkapatel-initos

comment created time in 13 days

pull request commentOCA/l10n-germany

[12.0][mig]l10n_de_toponyms

@hkapatel-initos Theoretically it would work. However there is an issue with the installation, as here odoo standard v12 already imports german states (contacts module): https://github.com/odoo/odoo/blob/12.0/addons/l10n_de/data/res.country.state.csv It was removed since V13: https://github.com/odoo/odoo/tree/13.0/addons/l10n_de/data. As a result the dependency to l10n_de_country_states caused an error on installation, because of duplicated states (cities and zips) entries in the database. The issue could be bypassed by manual removal of states in advance of the installation. However this will obviously leading to issues if l10n_de needs to be updated. In general the functionality would work also on a V12 setup in the same way as on V13, V14: Bildschirmfoto 2021-09-10 um 16 04 23 Bildschirmfoto 2021-09-10 um 16 03 56

I have done some changes and Travis is failed because of https://app.travis-ci.com/github/OCA/l10n-germany/jobs/536983793#L340. can you please re-review it?

@hkapatel-initos I have deleted the last line which was highlighted as wrong in the check. How to apply the test once again ?

hkapatel-initos

comment created time in 14 days

push eventOCA/l10n-germany

Thorsten Vocks

commit sha 7e1f06205c7ec1d9d3aef81a6dceb829d08c0a08

Update Roadmap.rst

view details

push time in 14 days

push eventOCA/l10n-germany

fkantelberg

commit sha e032857bbabb7b38a2861ff5b2eda79b46cb6c5d

[11.0] German toponyms (#34)

view details

oca-travis

commit sha a759fbe37c53a322870ec2504c69da9bda586a21

[UPD] Update l10n_de_toponyms.pot

view details

Thorsten Vocks

commit sha 244cd3e25049812863275bf256da9af9fc0cbf9d

fix of pylint and travis errors ************* Module l10n_de_toponyms l10n_de_toponyms/wizard/l10n_de_toponyms_zipcodes.xml:1: [W7930(file-not-used), ] not used from manifest ************* Module l10n_de_tax_statement_zm l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Enumerated list ends without a blank line; unexpected unindent. l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Inline emphasis start-string without end-string. l10n_de_tax_statement_zm/readme/USAGE.rst:5: [E7901(rst-syntax-error), ] Inline emphasis start-string without end-string. ----------------------------------- Your code has been rated at 9.87/10

view details

Frederik Kramer

commit sha 1a0cbbbc0cbf4cf14d73365ad4d7d2676a03d4b4

Translated using Weblate (German) Currently translated at 100.0% (15 of 15 strings) Translation: l10n-germany-11.0/l10n-germany-11.0-l10n_de_toponyms Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-11-0/l10n-germany-11-0-l10n_de_toponyms/de/

view details

hkapatel

commit sha bb5eb523642b79be2616208dbce3ff30a7a1eaf3

[IMP] l10n_de_toponyms: black, isort, prettier

view details

hkapatel

commit sha 4cb0fe160c93fecc0ed75061a79b2a9d47589e14

[MIG] l10n_de_toponyms: Migration to 14.0

view details

Thorsten Vocks

commit sha aa0343c5d5f653802bb8a53b05733b868b39ae98

Merge pull request #88 from initOS/14.0-mig-l10n_de_toponyms [14.0][mig]l10n_de_toponyms

view details

push time in 14 days

PR merged OCA/l10n-germany

[14.0][mig]l10n_de_toponyms needs fixing
+401 -0

5 comments

15 changed files

hkapatel-initos

pr closed time in 14 days

pull request commentOCA/l10n-germany

[14.0][mig]l10n_de_toponyms

@hkapatel-initos I get a rights issue, if i click "Import data from ..." in the wizard: Bildschirmfoto 2021-09-09 um 11 40 35

Hello, can you please recheck it?

@hkapatel-initos

Ok, now it works as expected. I will merge the module as everything is green now. Thanks a lot for your qucik reply and efforts. Bildschirmfoto 2021-09-14 um 15 23 28

hkapatel-initos

comment created time in 14 days

pull request commentOCA/l10n-germany

[12.0][mig]l10n_de_toponyms

@hkapatel-initos Theoretically it would work. However there is an issue with the installation, as here odoo standard v12 already imports german states (contacts module): https://github.com/odoo/odoo/blob/12.0/addons/l10n_de/data/res.country.state.csv It was removed since V13: https://github.com/odoo/odoo/tree/13.0/addons/l10n_de/data. As a result the dependency to l10n_de_country_states caused an error on installation, because of duplicated states (cities and zips) entries in the database. The issue could be bypassed by manual removal of states in advance of the installation. However this will obviously leading to issues if l10n_de needs to be updated.

In general the functionality would work also on a V12 setup in the same way as on V13, V14:

Bildschirmfoto 2021-09-10 um 16 04 23 Bildschirmfoto 2021-09-10 um 16 03 56

hkapatel-initos

comment created time in 18 days

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_toponyms

@hkapatel-initos I have checked the installation and functionality: Bildschirmfoto 2021-09-09 um 14 04 46 Bildschirmfoto 2021-09-09 um 14 05 00

Is it possible to bypass the travis check. I assume it fails as time limit is to low. I have added "limit-time-real=100000" to odoo-conf or paramter --limit-time-real=100000 to oddo-bin in order to test it.

hkapatel-initos

comment created time in 19 days

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_holidays

@hkapatel-initos I have checked the functionality. However i do not know if travis and runbot checks have to be successfull ? Bildschirmfoto 2021-09-09 um 13 25 05 Bildschirmfoto 2021-09-09 um 13 23 03

hkapatel-initos

comment created time in 19 days

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_skr04_mis_reports

@hkapatel-initos I did a functional check on a V13 setup: Bildschirmfoto 2021-09-09 um 12 45 23

May i merge, even if the travis check fails ?

hkapatel-initos

comment created time in 19 days

pull request commentOCA/l10n-germany

[13.0][mig]l10n_de_country_states

@hkapatel-initos

I have reviewed the installation and functions of the module: Bildschirmfoto 2021-09-09 um 11 59 22

Is it possible to merge even if the travis check failed ?

hkapatel-initos

comment created time in 19 days