profile
viewpoint
Ashish Dixit tundal45 Who wants to know?

ryanb/cancan 6316

Authorization Gem for Ruby on Rails.

kytrinyx/etsy 156

A friendly Ruby interface to the Etsy API

rubyforgood/casa 14

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.

tundal45/bmoreonrails-techdebt 1

talk I gave at bmoreonrails

tundal45/current_status 1

A simple Sinatra app that shows a particular user's current status images in a gallery view. This is a personal project for Mendicant University's Front-End Web Development course.

tundal45/gollum-rails 1

Gollum Rails 3 demo application

chadwpry/phone-insight 0

Phone Insight SInatra Application

fastly/ember-cli-acceptance-test-helpers 0

A set of useful test helpers for ember acceptance tests.

PR opened rubyforgood/casa

Reviewers
Removes edit link for previous volunteer

What github issue is this PR for, if any?

Resolves #406

What changed, and why?

In the volunteer dashboard, we could see the link to edit profile for previous volunteers assigned to the case in the case contacts section. While clicking on that link brought you right back, it's better to not provide a link in the first place. This change checks if the current user has permissions to edit the contact creator and only them provides the edit link. For all other cases, it just shows the display name of the contact creator.

How will this affect user permissions?

No impact

How is this tested? (please write tests!) 💖💪

Visually. I looked at what existed in terms of tests and it looked daunting. Maybe we can pair in the near future on how to improve test coverage.

Screenshots please :)

PG CASA 2020-07-12 17-29-00

Feelings gif (optional)

unsure

+7 -1

0 comment

1 changed file

pr created time in 2 hours

create barnchrubyforgood/casa

branch : ashish/remaining-406-tasks

created branch time in 2 hours

push eventrubyforgood/casa

Ashish Dixit

commit sha c3fc2c3d50c527daec0341fbeb26414da49ce726

Checks user is authorized to edit case contact Also rescued Pundit::UnauthorizedError and redirects to the root path with a nice flash message explaining why. Related to #406 Co-authored-by: Eric Tillberg <eric.tillberg@gmail.com> Co-authored-by: Linda Goldstein <compiledwrong@gmail.com> Co-authored-by: Zoe R <zrivkap@gmail.com>

view details

push time in 7 hours

PR opened rubyforgood/casa

Checks user is authorized to edit case contact

#357 # What github issue is this PR for, if any?

Related to #406

What changed, and why?

The volunteer dashboard showed edit links for case contacts that were created by other volunteers assigned to case before. It also did not check the policy on whether they are authorized. This hides the edit button for case contacts current user is not allowed to edit. If they try to guess edit path of another case contact, this prevents displaying the message, routes them to the root path with a helpful message explaining why.

How will this affect user permissions?

  • Volunteer permissions: Volunteers will no longer be able to edit case contacts created by other volunteers. This is good.
  • Supervisor permissions: No change
  • Admin permissions: No change

How is this tested? (please write tests!) 💖💪

It was tested visually but I can write tests for it in a separate PR.

Screenshots please :)

Paired over zoom with @Zrrrpy & @compwron so have seen how this looks.

Feelings gif (optional)

Loki, Prince of Asgard, celebrating success

+9 -2

0 comment

2 changed files

pr created time in 7 hours

push eventrubyforgood/casa

Ashish Dixit

commit sha 0fa595191bec62203100067910aa0d38f46c8d6f

Checks user is authorized to edit case contact Also rescued Pundit::UnauthorizedError and redirects to the root path with a nice flash message explaining why. Related to #406 Co-authored-by: Eric Tillberg <eric.tillberg@gmail.com> Co-authored-by: Linda Goldstein <compiledwrong@gmail.com>

view details

push time in 7 hours

push eventtundal45/rulers

Ashish Dixit

commit sha 7936b9f0f446ea3e0afccc32f03c952b387cd3a5

Defaults to HomeController in routing logic

view details

push time in 9 hours

push eventtundal45/best_quotes

Ashish Dixit

commit sha cecaba353fde9cfe2adec9000eea60c0c935851b

Adds HomeController

view details

push time in 9 hours

create barnchtundal45/best_quotes

branch : ashish/chapter-two-exercise-three

created branch time in 9 hours

create barnchtundal45/rulers

branch : ashish/chapter-two-exercise-three

created branch time in 9 hours

create barnchtundal45/rulers

branch : ashish/chapter-two-exercise-two

created branch time in 10 hours

create barnchtundal45/best_quotes

branch : ashish/chapter-two-exercise-two

created branch time in 10 hours

create barnchtundal45/best_quotes

branch : ashish/chapter-two-exercise-one

created branch time in 10 hours

push eventtundal45/best_quotes

Ashish Dixit

commit sha 1680d1113b6ce2f946f6fbd02641a441de2d8e89

End of chapter 2 - First Controller

view details

push time in 10 hours

push eventtundal45/rulers

Ashish Dixit

commit sha e0384c0e23e7e8f35c14e052e72478389a02c058

Adds basic routing End of chapter 2 without exercises

view details

push time in 10 hours

push eventtundal45/rulers

Ashish Dixit

commit sha cabe163348923975e01f54e87070a4d6d3980a41

Get rid of rspec for real

view details

push time in a day

delete branch tundal45/rulers

delete branch : ashish/chapter-one-exercise-five

delete time in a day

delete branch tundal45/rulers

delete branch : ashish/chapter-one-exercise-three

delete time in a day

push eventtundal45/rulers

Ashish Dixit

commit sha 520bca5a09c5f149b858882d0bca3a4018a3c3b1

Offically minitest tested Removes rspec boilerplate, adds a test

view details

Ashish Dixit

commit sha 485c5bdb74588a0e9a1b383c02c521c4f9c86339

Merge pull request #2 from tundal45/ashish/chapter-one-exercise-three Offically minitest tested

view details

push time in a day

PR merged tundal45/rulers

Offically minitest tested

Removes rspec boilerplate, adds a test

+57 -27

0 comment

7 changed files

tundal45

pr closed time in a day

PR opened tundal45/rulers

Offically minitest tested

Removes rspec boilerplate, adds a test

+57 -27

0 comment

7 changed files

pr created time in a day

push eventtundal45/rulers

Ashish Dixit

commit sha bb9cb5dc24e10763f025b558480bd9de774fc91d

Ignores rulers-\*.gem files We don't need to add .gem files in the codebase. Adding this to .gitignore ensures we do not do it.

view details

Ashish Dixit

commit sha 40181eb198d6675fb5176816f854ff36c60f620f

Merge pull request #1 from tundal45/ashish/chapter-one-exercise-five Ignores rulers-\*.gem files

view details

push time in a day

PR merged tundal45/rulers

Ignores rulers-\*.gem files

We don't need to add .gem files in the codebase. Adding this to .gitignore ensures we do not do it.

+2 -0

0 comment

1 changed file

tundal45

pr closed time in a day

PR opened tundal45/rulers

Ignores rulers-\*.gem files

We don't need to add .gem files in the codebase. Adding this to .gitignore ensures we do not do it.

+2 -0

0 comment

1 changed file

pr created time in a day

create barnchtundal45/rulers

branch : ashish/chapter-one-exercise-five

created branch time in a day

create barnchtundal45/rulers

branch : ashish/chapter-one-exercise-three

created branch time in a day

create barnchtundal45/rulers

branch : ashish/chapter-one-exercise-two

created branch time in a day

create barnchtundal45/rulers

branch : ashish/chapter-one-exercise-one

created branch time in a day

push eventtundal45/rulers

Ashish Dixit

commit sha c0407a2e900b23f3bfa375c459e000b7df9aa276

Adds default response to rulers

view details

push time in a day

create barnchtundal45/best_quotes

branch : main

created branch time in a day

created repositorytundal45/best_quotes

A test app that uses rulers framework to build its functionality. This is part of me working through Rebuilding Rails book.

created time in a day

delete branch tundal45/rulers

delete branch : master

delete time in a day

create barnchtundal45/rulers

branch : main

created branch time in a day

create barnchtundal45/rulers

branch : master

created branch time in a day

created repositorytundal45/rulers

The repo for a Rack-based Web Framework built as I read through Rebuilding Rails.

created time in a day

fork tundal45/practicing-ruby-manuscripts

Collection of source manuscripts for publicly released Practicing Ruby articles

fork in 22 days

startedJuanitoFatas/ruby-performance-tools

started time in a month

issue commentrubyforgood/casa

Auto-run new migrations in heroku on deploy

Yes, it's on my list to do this weekend but if other folks are interested in taking this on before that, feel free!

compwron

comment created time in 2 months

PR opened rubyforgood/casa

Run brakeman on CI

What github issue is this PR for, if any?

Resolves #001

Checklist

  • [ ] I have performed a self-review of my own code
  • [ ] I added comments, particularly in hard-to-understand areas
  • [ ] I updated the /docs
  • [ ] I added tests that prove my fix is effective or that my feature works
  • [ ] bundle exec rake passes locally
  • [ ] My PR title includes "WIP" or is draft PR if work is in progress

What changed, and why?

How will this affect user permissions?

  • Volunteer permissions:
  • Supervisor permissions:
  • Admin permissions:

How is this tested?

Screenshots please :)

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/

+1 -0

0 comment

1 changed file

pr created time in 3 months

create barnchrubyforgood/casa

branch : ashish/brakeman

created branch time in 3 months

PR opened rubyforgood/casa

Updates PR template
+18 -46

0 comment

1 changed file

pr created time in 3 months

push eventrubyforgood/casa

Lisa Vogt

commit sha fb9c3730b5373c1dade2047dbfe0ed9aea3b94fa

#101 makes CASA correctly all caps on the front end

view details

Lisa Vogt

commit sha d9564c95cbf40e17c77918076dc2105c355318f3

enforce CASA casing within form partial

view details

Lisa Vogt

commit sha 3814d5c426d536bbf4ab8e1489a0f828c7046e05

further standardize display of 'CASA Case'

view details

colinsoleim

commit sha 8cd95cc922c25e06983431e06ead3ee76dd6b09e

Adds migration for new case_contact fields

view details

naufragio del desastre linda metafísico de producción oncall

commit sha b186923b0b65b0239e91d94dadca7c4bd9ac0a6b

Merge pull request #139 from rubyforgood/readme-2 Remove useless rubocop checks and unimplemented tests. Add slack info to readme

view details

colinsoleim

commit sha d800f1222e8387fc73650d982a0ed42a0c480435

Add UI and decorators for new fields

view details

colinsoleim

commit sha a896355f26bba957a7d0eeebe4395f710cda9255

Merge branch 'master' of https://github.com/rubyforgood/casa into issue-121-add-medium-type-to-case-contacts

view details

colinsoleim

commit sha fbce196e9eda1c20ce74524202873b3b151cb718

Adds transition aged youth filter to dashboard - Adds new decorator function to display if a volunteer is assigned - Adds new filter using that column to hide/show volunteers accordingly

view details

naufragio del desastre linda metafísico de producción oncall

commit sha 6dc9f200505265935b8597d070a7a604622dcfce

Merge pull request #140 from colinsoleim/issue-111-add-transition-aged-youth-filter Adds transition aged youth filter to dashboard

view details

naufragio del desastre linda metafísico de producción oncall

commit sha f257af1684cbdae5a084764c07b49d7ad827b143

Merge pull request #138 from colinsoleim/issue-121-add-medium-type-to-case-contacts Adds medium_type and contact_made fields to case_contacts

view details

Linda

commit sha e6a9107182c74cae27937121e02939734a450ef3

Add comments generated by rake db migrate

view details

naufragio del desastre linda metafísico de producción oncall

commit sha f9d4227fc3cc2b1b63b429937dc7e255f240f569

Merge pull request #141 from rubyforgood/migrations-cleanup Add comments generated by rake db migrate

view details

Lisa Vogt

commit sha ead9093bb7b4a704af3d6f898c3232422be7f619

cleanup, update case for 'Create CASA Case' and update schema

view details

naufragio del desastre linda metafísico de producción oncall

commit sha dc0e71e9b4ae30b99105237bdb4ca8aa13e2ddc5

Merge pull request #144 from rubyforgood/casa_should_be_all_caps_101 CASA should be all caps [101]

view details

eclectic-coding

commit sha e4dba7041891f0b73dd3876c00131f3434ce0987

Removed the new casa contact on Admin dashboard

view details

eclectic-coding

commit sha b475fe25b4f329aaa53a563df6e40ff0235e3d0e

Resolves #147. Clarified setup instruction and Contributors file.

view details

eclectic-coding

commit sha 8a6cbb8fe3d72f016954e93502faf42b533eb52e

Made requested changes to links and ordered list for formatting

view details

naufragio del desastre linda metafísico de producción oncall

commit sha 29083ac911be3e429303264eaf6c7a787fac7347

Merge pull request #148 from eclectic-coding/edit/setup-directions Resolves #147. Clarified setup instruction and Contributors file.

view details

naufragio del desastre linda metafísico de producción oncall

commit sha 348c7db81bf0d2247d1d12e380f0b07076552639

Merge pull request #146 from eclectic-coding/edit/remove-new-case-contact-admin Removed the new casa contact on Admin dashboard

view details

colinsoleim

commit sha ffb9edb87a2c21f36d684d46afd36b23f67dde4b

Removes duplicated notices and adds notice styles

view details

push time in 3 months

Pull request review commentrubyforgood/casa

Resolves #147. Clarified setup instruction and Contributors file.

 https://casa-r4g-staging.herokuapp.com/ If you have any troubles, also look at `.travis.yml` which is what makes the CI build run  1. install a ruby version manager: [rvm](https://rvm.io/) or [rbenv](https://github.com/rbenv/rbenv)-1. when you cd into the project diretory, let your version manager install the ruby version in `.ruby-version`-1. `gem install bundler`-1. Make sure that postgres is installed [brew install postgres](https://wiki.postgresql.org/wiki/Homebrew) OR brew postgresql-upgrade-database (if you have an older version of postgres)-1. Make sure [nvm](https://github.com/nvm-sh/nvm#installing-and-updating) is installed -1. Make sure [yarn](https://classic.yarnpkg.com/en/docs/instal) is installed-1. Make sure you have [google chrome](https://chromedriver.chromium.org/) installed so the selenium tests can run-1. `bundle install`-1. `bundle exec rails webpacker:compile`-1. `yarn`-1. `bundle exec rails db:setup`-1. `bundle exec rails spec`-1. `rails db:create # requires running local postgres`-1. `rails db:migrate`-1. `bundle exec rails server` # run server+2. when you cd into the project diretory, let your version manager install the ruby version in `.ruby-version`

Markdown renders them with incremental numbers even if you use 1. for all of them. The benefit of using 1 everywhere is that if you add steps anywhere in the list, you don't have to re-number everything else.

eclectic-coding

comment created time in 3 months

Pull request review commentrubyforgood/casa

Resolves #147. Clarified setup instruction and Contributors file.

 Here are the basic steps to submit a pull request.  1. Fork the [repo] and clone your forked repo locally on your machine. -1. Follow [setup guidelines] to get the project setup locally.+1. Follow [setup guidelines](https://github.com/rubyforgood/casa#setup-to-develop) to get the project setup locally.

Oops! Did I accidentally remove the link from links section below that this could reference? If so, could you look at how we use [code of conduct] and [issues] to remain consistent?

eclectic-coding

comment created time in 3 months

PR opened rubyforgood/casa

Updates contributing guidelines again

We discovered that access restrictions prevents people from assigning issues to themselves. Instead of taking on the burden of managing access for each contributor, it makes sense to just ask them to comment on the issue saying they are working on it. It also changes the issue URL to remove the no assignee filter.

+3 -3

0 comment

1 changed file

pr created time in 3 months

MemberEvent

push eventrubyforgood/casa

Ashish Dixit

commit sha 77d809fe3806ec57f84aa26fb50b58a0eb25046d

Update contributing guidelines

view details

Ashish Dixit

commit sha 62021c8a9ba8c7ab4605e530d7a8229d6c8f111d

Merge pull request #104 from rubyforgood/ashish/updates-contributing-guideline Update contributing guidelines

view details

push time in 3 months

delete branch rubyforgood/casa

delete branch : ashish/updates-contributing-guideline

delete time in 3 months

PR merged rubyforgood/casa

Reviewers
Update contributing guidelines

Minor formatting changes and additions to improve clarity.

+17 -11

2 comments

1 changed file

tundal45

pr closed time in 3 months

push eventrubyforgood/casa

Ashish Dixit

commit sha 1275ae74ea2d2dee3dc4c481cc8daba014923b15

I thought I cleaned this up

view details

naufragio del desastre linda metafísico de producción oncall

commit sha e2bb2ffea3663dc3b4f44a5a52358e3c62fc8de6

Merge pull request #103 from rubyforgood/ashish/remove-shenanigans I thought I cleaned this up

view details

colinsoleim

commit sha e3a458a3a2aeb7b1e142620256fdeaeaddd1682d

Adds Hour & Minutes Input for Case Contacts - Resolves Issue #88 - Adds case_contact model method for displaying duration_minutes as hrs + mins - Adds helper methods to print minute and hour select_tags - Refactors case_contacts#create to use CaseContactParameters

view details

naufragio del desastre linda metafísico de producción oncall

commit sha 9113ddfa7f4599055759b46013e53a0a1ce47b80

Merge pull request #106 from colinsoleim/issue-88-hour-input-for-case-contact Adds Hour & Minutes Input for Case Contacts

view details

Ashish Dixit

commit sha 77d809fe3806ec57f84aa26fb50b58a0eb25046d

Update contributing guidelines

view details

push time in 3 months

pull request commentrubyforgood/casa

Update contributing guidelines

I'd like to see a mention of the slack channel and how to join it ...how do you join it?

I thought about whether that step is necessary, I can include it but figured it might be too many steps!

tundal45

comment created time in 3 months

Pull request review commentrubyforgood/casa

Update contributing guidelines

  We ♥ contributors! By participating in this project, you agree to abide by the Ruby for Good [code of conduct]. -**First:** if you're unsure or afraid of *anything*, just ask or submit the issue or pull request anyways. You won't be yelled at for giving your best effort. The worst that can happen is that you'll be politely asked to change something. We appreciate any sort of contributions, and don't want a wall of rules to get in the way of that.+If you're unsure about an issue or have any questions or concerns, just ask in an *existing issue* or *open a new issue*. If you don't have any questions and the issue is clear and not currently assigned to anyone, you can open a PR as well. You won't be yelled at for giving your best effort. The worst that can happen is that you'll be politely asked to change something. We appreciate any sort of contributions, and don't want a wall of rules to get in the way of that. -[code of conduct]: https://github.com/rubyforgood/code-of-conduct--Here are the basic steps to submit a pull request. Make sure that you're working on an [open issue]–if the relevant issue doesn't exist, open it!+Here are the basic steps to submit a pull request. -[open issue]: https://github.com/rubyforgood/casa/issues+1. Claim an issue on [our issue tracker][issues] by assigning it to yourself (core team member) or commenting. If the issue doesn't exist yet, open it. -1. Claim an issue on [our issue tracker][open issue] by assigning it to yourself (core team member) or commenting. If the issue doesn't exist yet, open it.+2. Fork the [repo] and clone your forked repo locally on your machine.

Lol an ex co-worker used to do that and I always wondered why until I was re-numbering them just now but was so committed to my old ways that did not thing to change. Updated.

tundal45

comment created time in 3 months

push eventrubyforgood/casa

Ashish Dixit

commit sha 5ac7d0e45e58f27a5fa36e0ced9ffc5a574273ec

Update contributing guidelines

view details

push time in 3 months

PR opened rubyforgood/casa

Update contributing guidelines

Minor formatting changes and additions to improve clarity.

+16 -12

0 comment

1 changed file

pr created time in 3 months

create barnchrubyforgood/casa

branch : ashish/updates-contributing-guideline

created branch time in 3 months

PR opened rubyforgood/casa

I thought I cleaned this up
+0 -0

0 comment

1 changed file

pr created time in 3 months

create barnchrubyforgood/casa

branch : ashish/remove-shenanigans

created branch time in 3 months

more