profile
viewpoint
Tshepang Lekhonkhobe tshepang @panoptix-za Johannesburg tshepang.net

tshepang/actix-website 0

The Actix website.

tshepang/api-guidelines 0

Rust API guidelines

tshepang/app 0

A easy-to-use command-line-parser.

tshepang/argh 0

Rust derive-based argument parsing optimized for code size

Pull request review commentrust-lang/rust

make concurrency helper more pleasant to read

 //! Helper module which helps to determine amount of threads to be used //! during tests execution.-use std::env;-use std::thread;+use std::{env, thread}; -#[allow(deprecated)] pub fn get_concurrency() -> usize {-    match env::var("RUST_TEST_THREADS") {-        Ok(s) => {-            let opt_n: Option<usize> = s.parse().ok();-            match opt_n {-                Some(n) if n > 0 => n,-                _ => panic!("RUST_TEST_THREADS is `{}`, should be a positive integer.", s),-            }+    if let Ok(value) = env::var("RUST_TEST_THREADS") {

maybe we better spell it out as string, but with value, I meant "whatever value we read from env var"

tshepang

comment created time in a day

PullRequestReviewEvent

Pull request review commentrust-lang/rust

make concurrency helper more pleasant to read

 //! Helper module which helps to determine amount of threads to be used //! during tests execution.-use std::env;-use std::thread;+use std::{env, thread}; -#[allow(deprecated)] pub fn get_concurrency() -> usize {-    match env::var("RUST_TEST_THREADS") {-        Ok(s) => {-            let opt_n: Option<usize> = s.parse().ok();-            match opt_n {-                Some(n) if n > 0 => n,-                _ => panic!("RUST_TEST_THREADS is `{}`, should be a positive integer.", s),-            }+    if let Ok(value) = env::var("RUST_TEST_THREADS") {+        match value.parse().ok() {+            Some(n) if n > 0 => n,+            _ => panic!("RUST_TEST_THREADS is `{}`, should be a positive integer.", value),

type inference/coercion is helped by the return type, or do you feel it's too far, preferring the type spelled out close to the declaration

tshepang

comment created time in a day

PullRequestReviewEvent

Pull request review commentrust-lang/rust

make concurrency helper more pleasant to read

 //! Helper module which helps to determine amount of threads to be used //! during tests execution.-use std::env;-use std::thread;+use std::{env, thread}; -#[allow(deprecated)] pub fn get_concurrency() -> usize {-    match env::var("RUST_TEST_THREADS") {-        Ok(s) => {-            let opt_n: Option<usize> = s.parse().ok();-            match opt_n {-                Some(n) if n > 0 => n,-                _ => panic!("RUST_TEST_THREADS is `{}`, should be a positive integer.", s),-            }+    if let Ok(value) = env::var("RUST_TEST_THREADS") {

what does s mean

tshepang

comment created time in a day

PullRequestReviewEvent

push eventtshepang/rust

Tshepang Lekhonkhobe

commit sha 9862cf073861fa055fd5cdccb1b2b7356557c1f2

Update library/test/src/helpers/concurrency.rs Co-authored-by: Ivan Tham <pickfire@riseup.net>

view details

push time in a day

create barnchtshepang/rust

branch : nits

created branch time in a day

push eventtshepang/rust

Tshepang Lekhonkhobe

commit sha 34f3b2abf695c06d762ba0d4e45004d166d73802

make concurrency helper more pleasant to read

view details

push time in a day

PR opened rust-lang/rust

make cncurrency helper more pleasant to read
+7 -11

0 comment

1 changed file

pr created time in a day

pull request commentrust-lang/blog.rust-lang.org

Add post about using regression labels

@camelid please do

camelid

comment created time in 6 days

delete branch tshepang/murundiri

delete branch : patch-1

delete time in 10 days

PR opened TNkemdilim/murundiri

readme: some nits
+3 -3

0 comment

1 changed file

pr created time in 11 days

push eventtshepang/murundiri

Tshepang Lekhonkhobe

commit sha 03c8994a2d735dddbd089822308986829f6d736a

readme: some nits

view details

push time in 11 days

fork tshepang/murundiri

Blazing fast and configurable idempotency reverse-proxy designed for scale.

fork in 11 days

PullRequestReviewEvent

push eventLeSeulArtichaut/rustc-guide

Tshepang Lekhonkhobe

commit sha 68e30b782f1eac94924043279238fd926f360d1d

Update src/getting-started.md Co-authored-by: Camelid <37223377+camelid@users.noreply.github.com>

view details

push time in 16 days

push eventLeSeulArtichaut/rustc-guide

Tshepang Lekhonkhobe

commit sha 11c50260b85bb1eeeb5d0ccd48c13d7cdc4b042a

Update src/getting-started.md Co-authored-by: Camelid <37223377+camelid@users.noreply.github.com>

view details

push time in 16 days

push eventrust-lang/rustc-dev-guide

Roman

commit sha fdd5946d58dd66409a876dc932998c0fbd4b7224

add the last missing code highlight to t-compiler in the docs

view details

push time in 17 days

PR merged rust-lang/rustc-dev-guide

add the last missing code highlight to t-compiler in the docs

This is something that I found during reading the docs. All the other places have backticks around the t-compiler part, but this was the a part where it was missing.

+2 -2

0 comment

1 changed file

r-52

pr closed time in 17 days

PullRequestReviewEvent

push eventrust-lang/rustc-dev-guide

Joshua Nelson

commit sha a8b7e92c12f3d0f2fae55507a34a3fe329593069

Fix typo

view details

push time in 19 days

PR merged rust-lang/rustc-dev-guide

Fix typo
+1 -1

0 comment

1 changed file

jyn514

pr closed time in 19 days

PullRequestReviewEvent

delete branch tshepang/rust

delete branch : overlong

delete time in 21 days

push eventrust-lang/rustc-dev-guide

Joshua Nelson

commit sha 5f39b8131fc228cb70baa0e70a66b555e8f6fa6e

Add docs for x.py setup

view details

push time in 23 days

PR merged rust-lang/rustc-dev-guide

Add docs for x.py setup waiting-on-review

Follow-up to https://github.com/rust-lang/rust/pull/76631

+21 -14

0 comment

1 changed file

jyn514

pr closed time in 23 days

PullRequestReviewEvent

create barnchtshepang/rust

branch : overlong

created branch time in 23 days

PR opened rust-lang/rust

reduce overlong line
+2 -1

0 comment

1 changed file

pr created time in 23 days

pull request commentrust-lang/areweasyncyet.rs

minor documentation fix - missing space on line 37 of README.md

It's not a typo... the command works with and without the space.

anirudhRowjee

comment created time in 24 days

created tagtshepang/mrh

tagv0.10.12

created time in 25 days

push eventtshepang/mrh

Tshepang Lekhonkhobe

commit sha 242eddb26263a3d7778cf96267db477e425d5426

bump version

view details

push time in 25 days

push eventtshepang/mrh

Tshepang Lekhonkhobe

commit sha a5081dc29e293340010d624414a78e5f31b86f4e

rm ugly annotation

view details

Tshepang Lekhonkhobe

commit sha 2ae1eda2a6b3440582848e62d55a0823e2cf80cc

one less direct dep

view details

Tshepang Lekhonkhobe

commit sha ec1a3823f6b49623404c02d42c375a89c4aa2c3b

bump dep: dirs

view details

push time in 25 days

push eventtshepang/foo

push time in a month

create barnchtshepang/foo

branch : bar

created branch time in a month

push eventtshepang/foo

Tshepang Lekhonkhobe

commit sha 14aef1b18bfb96ac605a78162c9b53caaea6f3e3

foo

view details

push time in a month

create barnchtshepang/foo

branch : foo

created branch time in a month

create barnchtshepang/foo

branch : master

created branch time in a month

created repositorytshepang/foo

created time in a month

pull request commentzonyitoo/rust-ini

Simpler code structure, moved everything to `lib.rs`

This should be bumped to v0.16.0 if it breaks code

marioortizmanero

comment created time in a month

delete branch tshepang/seed-rs.org

delete branch : patch-1

delete time in a month

delete branch tshepang/seed-quickstart

delete branch : patch-1

delete time in a month

PR opened seed-rs/seed-quickstart

missing word
+1 -1

0 comment

1 changed file

pr created time in a month

push eventtshepang/seed-quickstart

Tshepang Lekhonkhobe

commit sha 5a6fe59c754ce346cca915a41b4e7c23c925b0d0

missing word

view details

push time in a month

fork tshepang/seed-quickstart

Bare essentials to start a Seed app.

https://seed-rs.org/

fork in a month

PR opened seed-rs/seed-rs.org

replace unusual usage
+1 -1

0 comment

1 changed file

pr created time in a month

push eventtshepang/seed-rs.org

Tshepang Lekhonkhobe

commit sha 3966926a1641fc0803b7e95ad381ed3133483f59

replace unusual usage

view details

push time in a month

PR opened rust-lang/rust

remove orphaned files

Should been part of https://github.com/rust-lang/rust/pull/74163

+0 -52

0 comment

3 changed files

pr created time in a month

create barnchtshepang/rust

branch : unused

created branch time in a month

push eventtshepang/rust

Surya Midatala

commit sha 7569cf98f93949880aae66fe843c90490f0f5120

Merge conflict fix: disambiguate f32 -> prim@f32 and u32 -> prim@u32

view details

bors

commit sha 1f2dd3b56aec4d8f97eb0b0552c166ef549d3316

Auto merge of #75903 - jyn514:lint-refactor, r=GuillaumeGomez Warn about unknown or renamed lints in rustdoc Fixes https://github.com/rust-lang/rust/issues/75884. This is best reviewed one commit at a time. r? @GuillaumeGomez Originally I tried to do a much broader refactoring that got rid of `init_lints` altogether. My reasoning is that now the lints aren't being run anymore (after https://github.com/rust-lang/rust/pull/73566), there's no need to ignore them explicitly. But it seems there are still some lints that aren't affected by setting `lint_mod` to a no-op: ``` deny(pub_use_of_private_extern_crate) deny(const_err) warn(unused_imports) ``` (there are possibly more, these are just the ones that failed in the rustdoc test suite). Some of these seem like we really should be warning about, but that's a much larger change and I don't propose to make it here. So for the time being, this just adds the `unknown_lints` and `renamed_or_removed_lints` passes to the list of lints rustdoc warns about.

view details

bors

commit sha 64c4bb0d2bac5f7810d7d0fa6ad846417b3ca60a

Auto merge of #5966 - 1c3t3a:1c3t3a-dev-5819-fix, r=Manishearth Corrects the float_equality_without_abs lint Fixes an issue in the `float_equality_without_abs` lint. The lint suggestion was configured in a way that it lints the whole error and not just the subtraction part. In the current configuration the lint would suggest to change the expression in a wrong way, e.g. ```rust let _ = (a - b) < f32::EPSILON; // before let _ = (a - b).abs(); // after ``` This was dicovered by @flip1995. (See discussion of PR #5952). Also the suggestion is now formatted via `utils::sugg`. changelog: none

view details

bors

commit sha 48717b6f3ce661d2a0d64f7bdfdfb5fd3484ee5b

Auto merge of #75912 - scottmcm:manuallydrop-vs-forget, r=Mark-Simulacrum Suggest `mem::forget` if `mem::ManuallyDrop::new` isn't used I think this communicates the intent more idiomatically, and is shorter anyway. Inspired because [it came up on URLO](https://users.rust-lang.org/t/validity-of-memory-area-after-std-forget/47730/7?u=scottmcm), and it turns out that std had done it too in one spot: ![image](https://user-images.githubusercontent.com/18526288/91203819-e19f2980-e6f2-11ea-9112-835f3b22ce05.png)

view details

Joshua Nelson

commit sha 29399fad5f961f0e235d28ed2f4c68e7a1ae5062

Fix swapped stability attributes This fixes a regression introduced in https://github.com/rust-lang/rust/pull/74855.

view details

Arkadiusz Piekarz

commit sha aa40c028fcb20a47fb214fea2899ff9a8ae88840

Unstable Book: add links to tracking issues for FFI features

view details

bors

commit sha 2d8a3b9181f41d3af9b9f016c5d73b2553e344bf

Auto merge of #75944 - jumbatm:issue-75924-clashing-extern-decl-ice, r=spastorino Fix ICE on unwrap of unknown layout in ClashingExternDeclarations. Fixes #75924.

view details

Mark Rousskov

commit sha c8b240241a94a3a5badcbdcbe1b642a0dd440119

Avoid function-scoping global variables In 2e6f2e885506ee4, we added a main function to the publish_toolstate.py script. Unfortunately, we missed that the Python program implicitly declares global variables in that code, which means that adding a function changes variable scoping and breaks other code. This commit avoids introducing that function and adds a warning to future editors of the code.

view details

Camelid

commit sha 294c1160bb693a77ad2683321b9196352bd837dc

Improve docs for the `const` keyword

view details

Josh Triplett

commit sha 30b7dac745b1555cd96f41977f7d24435cbe7fa2

Set ninja=true by default Ninja substantially improves LLVM build time. On a 96-way system, using Make took 248s, and using Ninja took 161s, a 35% improvement. We already require a variety of tools to build Rust. If someone wants to build without Ninja (for instance, to minimize the set of packages required to bootstrap a new target), they can easily set `ninja=false` in `config.toml`. Our defaults should help people build Rust (and LLVM) faster, to speed up development.

view details

Josh Triplett

commit sha 181ce0e013453fcbe2cc493a37ea77d7cfe6b990

Disable ninja on macOS CI Should be re-enabled when we have a recipe for installing ninja on macOS.

view details

Josh Triplett

commit sha 6149dffff959c0c338ef319b4cea2f49560041e7

Install ninja on CI builders Windows CI builds already install ninja. Install it in all the Docker-based builds as well.

view details

Josh Triplett

commit sha bb39f3555c14275472386ffca637071e22714521

Provide a better diagnostic if ninja isn't installed Let people know that they can set ninja=false if they don't want to install ninja.

view details

rail

commit sha edc05da57d4ad5ab19b5ca64e80e359e487ab2d0

Fix the wrong use of `snippet_with_applicability` This includes a workaround of the issue #5822, the cause of this little mistake.

view details

bors

commit sha 45a83e97ccc70a99794346eb60c11e209c67ecba

Auto merge of #75898 - lcnr:variant-def-recovered, r=petrochenkov VariantDef: move `recovered` into `VariantFlags`

view details

bors

commit sha e45c59e922c4450b8ab136eac38a37000fca9254

Auto merge of #5968 - rail-rain:fix_use_snippet_with_applicability, r=flip1995 Fix the wrong use of `snippet_with_applicability` For the context, please see https://github.com/rust-lang/rust-clippy/issues/5822#issuecomment-680749728 and https://github.com/rust-lang/rust-clippy/issues/5822#issuecomment-680783381. --- changelog: none

view details

Dylan DPC

commit sha 2eec2ecbdec1cae9b749e079a376540d9cc5e304

Rollup merge of #74730 - androm3da:fix_libstd_hexlinux_01, r=dtolnay Hexagon libstd: update type defs

view details

Dylan DPC

commit sha 730449d22ad6d152f4f58719ef2f3c459984a361

Rollup merge of #75758 - bpangWR:master, r=Mark-Simulacrum Fixes for VxWorks r? @alexcrichton

view details

Dylan DPC

commit sha a79f9af290ad69cd4fb32a3e1b5e610a21262717

Rollup merge of #75780 - matklad:unconfuseunpindocs, r=KodrAus Unconfuse Unpin docs a bit * Don't say that Unpin is used to prevent moves, because it is used to *allow* moves * Be more precise about kindedness of things, it is `Pin<Pointer<Data>>`, rather than just `Pin<Pointer>`.

view details

Dylan DPC

commit sha 463fdf3e042c7429f2d85d2cdc042463d2cd7720

Rollup merge of #75806 - GuillaumeGomez:prevent-automatic-page-change-history, r=pickfire Prevent automatic page change when using history Fixes #75774.

view details

push time in a month

Pull request review commentrust-lang/rustc-dev-guide

Document new way to not build LLVM

 git worktree add -b my-feature ../rust2 master You can then use that rust2 folder as a separate workspace for modifying and building `rustc`! -## Building with system LLVM+## Skipping LLVM Build -By default, LLVM is built from source, and that can take significant amount of-time.  An alternative is to use LLVM already installed on your computer.+By default, LLVM is built from source, and that takes significant amount of+time. One way to avoid that is to add this to `config.toml`: -This is specified in the `target` section of `config.toml`:+```toml+[llvm]+download-ci-llvm = true+```++Downloading LLVM from CI is still experimental though, and might not be+available on all platforms. Otherwise, we'd make it a default!

I was only referring to "Other, we'd make it a default". First sentence is all good.

matklad

comment created time in a month

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Document new way to not build LLVM

 git worktree add -b my-feature ../rust2 master You can then use that rust2 folder as a separate workspace for modifying and building `rustc`! -## Building with system LLVM+## Skipping LLVM Build -By default, LLVM is built from source, and that can take significant amount of-time.  An alternative is to use LLVM already installed on your computer.+By default, LLVM is built from source, and that takes significant amount of+time. One way to avoid that is to add this to `config.toml`: -This is specified in the `target` section of `config.toml`:+```toml+[llvm]+download-ci-llvm = true+```++Downloading LLVM from CI is still experimental though, and might not be+available on all platforms. Otherwise, we'd make it a default!

This does not feel like the right place to indicate planned policy/default, here referring to "we'd make it a default".

matklad

comment created time in a month

PullRequestReviewEvent

delete branch rust-lang/rustc-dev-guide

delete branch : LeSeulArtichaut-patch-1

delete time in a month

push eventLeSeulArtichaut/rustc-guide

Tshepang Lekhonkhobe

commit sha 7579014ccc0d929657b589480cc73f0a4529474e

Update src/rustbot.md

view details

push time in a month

Pull request review commentrust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

+# Mastering @rustbot++`@rustbot` (also known as `triagebot`) is a utility robot that is mostly used to+allow any contributor to achieve certain tasks that would normally require GitHub+membership to the `rust-lang` organization. Its most interesting features for+contributors to `rustc` are isssue claiming and relabeling.++## Issue claiming++`@rustbot` exposes a command that allows anyone to assign an issue to themselves.+If you see an issue you want to work on, you can send the following message as a+comment on the issue at hand:++    @rustbot claim++If you are a member of the `rust-lang` organization, `@rustbot` will assign the+issue to you. Otherwise, `@rustbot` will assign itself as a placeholder and edit+the top comment to reflect the fact that the issue is now assigned to you.++If you want to unassign from an issue, `@rustbot` has a different command:++    @rustbot release-assignment++## Issue relabeling++Changing labels for an issue or PR is also normally reserved to members of the+organization. However, `@rustbot` allows you to relabel an issue yourself, only+with a few restrictions. This is mostly useful in two cases:++**Helping with issue triage**: Rust's issue tracker has more than 5,000 open+issues at the time of this writing, so labels are the most powerful tool that we+have to keep it as tidy as possible. You may not spend hours in the issue tracker+to triage issues, but if you open an issue, you should feel free to label it if+you are comfortable with doing it yourself.++**Updating the status of a PR**: we use "status labels" to reflect the status of+PRs. For example, if your PR has merge conflicts, it will automatically be assigned+the `S-waiting-on-author`, and reviewers might not review it until you rebase your+PR. Once you did rebase your branch, you should change the labels yourself to remove
PR. Once you do rebase your branch, you should change the labels yourself to remove
LeSeulArtichaut

comment created time in a month

PullRequestReviewEvent

push eventLeSeulArtichaut/rustc-guide

Tshepang Lekhonkhobe

commit sha 52691642a337c25bd4cbaafa3efe89be0b18fb36

Update src/rustbot.md

view details

push time in a month

Pull request review commentrust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

+# Mastering @rustbot++`@rustbot` (also known as `triagebot`) is a utility robot that is mostly used to+allow any contributor to achieve certain tasks that would normally require GitHub+membership to the `rust-lang` organization. Its most interesting features for+contributors to `rustc` are isssue claiming and relabeling.++## Issue claiming++`@rustbot` exposes a command that allows anyone to assign an issue to themselves.+If you see an issue you want to work on, you can send the following message as a+comment on the issue at hand:++    @rustbot claim++If you are a member of the `rust-lang` organization, `@rustbot` will assign the+issue to you. Otherwise, `@rustbot` will assign itself as a placeholder and edit+the top comment to reflect the fact that the issue is now assigned to you.++If you want to unassign from an issue, `@rustbot` has a different command:++    @rustbot release-assignment++## Issue relabeling++Changing labels for an issue or PR is also normally reserved to members of the+organization. However, `@rustdoc` allows you to relabel an issue yourself, only
organization. However, `@rustbot` allows you to relabel an issue yourself, only
LeSeulArtichaut

comment created time in a month

PullRequestReviewEvent

push eventLeSeulArtichaut/rustc-guide

Tshepang Lekhonkhobe

commit sha b19cdd46dc63efe2e23be09c148a9b9fd1b3f5e3

Update src/contributing.md Co-authored-by: Camelid <37223377+camelid@users.noreply.github.com>

view details

push time in a month

push eventLeSeulArtichaut/rustc-guide

Tshepang Lekhonkhobe

commit sha 0761d345b2bf0a0713629581b35cf4276a53c45c

Update src/contributing.md

view details

push time in a month

Pull request review commentrust-lang/rustc-dev-guide

Add a chapter on useful `@rustbot` commands

 labels to triage issues:  * Red, **I**-prefixed labels indicate the **importance** of the issue. The   [I-nominated][inom] label indicates that an issue has been nominated for-  prioritizing at the next triage meeting.+  prioritizing at the next triage meeting. Similarely, the [I-prioritize][ipri]
  prioritizing at the next triage meeting. Similarly, the [I-prioritize][ipri]
LeSeulArtichaut

comment created time in a month

PullRequestReviewEvent

push eventrust-lang/rustc-dev-guide

LeSeulArtichaut

commit sha ee99dea822d95e3bfef58b455e30a4080a044b09

Clean up 'Contributing to Rust - Pull Requests'

view details

LeSeulArtichaut

commit sha 6366c1dbaae299b04517541557889b4c14a20ccf

Apply suggestions from code review Co-authored-by: Joshua Nelson <joshua@yottadb.com>

view details

LeSeulArtichaut

commit sha 150b915338bac3e6fcf903433c122e00cafdc153

Fix typo Co-authored-by: Tshepang Lekhonkhobe <tshepang@gmail.com>

view details

push time in a month

PR merged rust-lang/rustc-dev-guide

Clean up 'Contributing to Rust - Pull Requests' waiting-on-review

Also helps with #866.

+55 -36

4 comments

1 changed file

LeSeulArtichaut

pr closed time in a month

Pull request review commentrust-lang/rustc-dev-guide

Clean up 'Contributing to Rust - Pull Requests'

 make a documentation change, add to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign [@steveklabnik][steveklabnik] instead of a random person. This is entirely optional. +In addition to being reviewed by a human, pull requests are automatically tested+thanks to continuous integration (CI). Basically, every time you open and update+a pull request, CI builds the compiler and tests it against the+[compiler test suite][rctd], and also performs other tests such as checking that+your pull request is in compliance with Rust's style guidelines.++Running continuous integration tests allows PR authors to catch mistakes early+without going through a first review cycle, and also helps reviewers stay aware+of the status of a particular pull request.++Rust has plenty of CI capacity, and you should never have to worry about wasting+computational resources each time you push a change. It is also perfectly fine+(and even encouraged!) to use the CI to test your changes if it can help your+productivity. In particular, we don't recommend running the full `x.py test` suite locally,+since it takes a very long time to execute.+ After someone has reviewed your pull request, they will leave an annotation on the pull request with an `r+`. It will look something like this:      @bors r+  This tells [@bors], our lovable integration bot, that your pull request has been approved. The PR then enters the [merge queue][merge-queue], where [@bors]-will run all the tests on every platform we support. If it all works out,+will run *all* the tests on *every* platform we support. If it all works out, [@bors] will merge your code into `master` and close the pull request.  Depending on the scale of the change, you may see a slightly different form of `r+`:      @bors r+ rollup -The additional `rollup` tells [@bors] that this change is eligible for to be-"rolled up". Changes that are rolled up are tested and merged at the same time, to+The additional `rollup` tells [@bors] that this change should always be "rolled up".+Changes that are rolled up are tested and merged alongside other PRs, to speed the process up. Typically only small changes that are expected not to conflict-with one another are rolled up.+with one another are marked as "always roll up".  [rust-highfive]: https://github.com/rust-highfive [steveklabnik]: https://github.com/steveklabnik [@bors]: https://github.com/bors [merge-queue]: https://buildbot2.rust-lang.org/homu/queue/rust -Speaking of tests, Rust has a comprehensive test suite. More information about-it can be found [here][rctd].+### Opening a PR++You are now ready to file a pull request? Great! Here are a few points you+should be aware of.++All pull requests should be filed against the `master` branch, except in very+particular scenarios. Unless you know for sure that you should target another+branch, `master` will be the right choice (it's also the default).++Make sure your pull request is in compliance with Rust's style guidelines by running++    $ ./x.py test tidy --bless++We recommand to make this check before every pull request (and every new commit
We recommend to make this check before every pull request (and every new commit
LeSeulArtichaut

comment created time in a month

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Clean up 'Contributing to Rust - Pull Requests'

 make a documentation change, add to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign [@steveklabnik][steveklabnik] instead of a random person. This is entirely optional. +In addition to being reviewed by a human, pull requests are automatically tested+thanks to continuous integration (CI). Basically, every time you open and update+a pull request, CI builds the compiler and tests it against the

The inconsistency bothered me

LeSeulArtichaut

comment created time in a month

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Clean up 'Contributing to Rust - Pull Requests'

 make a documentation change, add to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign [@steveklabnik][steveklabnik] instead of a random person. This is entirely optional. +In addition to being reviewed by a human, pull requests are automatically tested+thanks to continuous integration (CI). Basically, every time you open and update+a pull request, CI builds the compiler and tests it against the

This avoids having to decide between pull request and Pull Request

LeSeulArtichaut

comment created time in a month

PullRequestReviewEvent

Pull request review commentrust-lang/rustc-dev-guide

Clean up 'Contributing to Rust - Pull Requests'

 make a documentation change, add to the end of the pull request description, and [@rust-highfive][rust-highfive] will assign [@steveklabnik][steveklabnik] instead of a random person. This is entirely optional. +In addition to being reviewed by a human, pull requests are automatically tested+thanks to continuous integration (CI). Basically, every time you open and update+a pull request, CI builds the compiler and tests it against the
a PR, CI builds the compiler and tests it against the
LeSeulArtichaut

comment created time in a month

PullRequestReviewEvent

delete branch rust-lang/rustc-dev-guide

delete branch : jyn514-patch-1

delete time in a month

Pull request review commentrust-lang/rustc-dev-guide

Add a chapter on all the identifiers used through `rustc`

+# Identifiers in the Compiler++If you have read the few previous chapters, you now know that the `rustc` uses+many different intermediate representations to perform different kinds of analysis.
many different intermediate representations to perform different kinds of analyses.
LeSeulArtichaut

comment created time in a month

Pull request review commentrust-lang/rustc-dev-guide

Add a chapter on all the identifiers used through `rustc`

+# Identifiers in the Compiler++If you have read the few previous chapters, you now know that the `rustc` uses
If you have read the few previous chapters, you now know that `rustc` uses
LeSeulArtichaut

comment created time in a month

PullRequestReviewEvent
PullRequestReviewEvent

push eventrust-lang/rustc-dev-guide

Joshua Nelson

commit sha 7d544181379af99e80c7e48647f7a30acc90dd8c

Document how to promote a target from cross-compiled to hosted

view details

Tshepang Lekhonkhobe

commit sha 987b5ef0085c3ac490ad84a99f236351603b7537

Update src/building/new-target.md

view details

Joshua Nelson

commit sha 683cbdda74559b7d3cdc79ede2b4305f876a1102

Fix nit

view details

push time in a month

PR merged rust-lang/rustc-dev-guide

Document how to promote a target from cross-compiled to hosted waiting-on-review

I don't know anything about how this works, just enough to link to more resources. r? @pietroalbini - and if you have more suggestions of docs to add, please let me know!

+9 -0

3 comments

1 changed file

jyn514

pr closed time in a month

pull request commentrust-lang/rustc-dev-guide

Document speculative crate loading

maybe we should bring in bors

jyn514

comment created time in a month

pull request commentrust-lang/rustc-dev-guide

Document how to promote a target from cross-compiled to hosted

I see no need to wait... this is useful enough, and I did learn just by reading this PR. We can indeed always update it later.

jyn514

comment created time in a month

PullRequestReviewEvent

push eventjyn514/rustc-dev-guide

Tshepang Lekhonkhobe

commit sha b15f73261e2b87a2521282005d2da1cebf8c371d

Update src/building/new-target.md

view details

push time in a month

PullRequestReviewEvent

push eventrust-lang/rustc-dev-guide

Joshua Nelson

commit sha 13c18fccbeb61d0580be8e1c9cc13d0b9a5efe0b

Fix typo

view details

push time in a month

PR merged rust-lang/rustc-dev-guide

Fix typo waiting-on-review

r? @nico-abram

+1 -1

2 comments

1 changed file

jyn514

pr closed time in a month

PullRequestReviewEvent
PullRequestReviewEvent

push eventrust-lang/rustc-dev-guide

Joshua Nelson

commit sha 677a95f264c22a9750d46d59ef1c4b74819080b3

Update error codes to match the current implementation - All codes are in one crate, `rustc_error_codes` - Extended descriptions are loaded using `include_str!` - Give an example of a PR adding an error code

view details

push time in a month

PR merged rust-lang/rustc-dev-guide

Update error codes to match the current implementation waiting-on-review
  • All codes are in one crate, rustc_error_codes
  • Extended descriptions are loaded using include_str!

I wrote this just by looking at the code, not by talking with anyone about it, so this might not be perfectly accurate. Follow-up to https://github.com/rust-lang/rustc-dev-guide/pull/838#discussion_r479810627.

r? @mark-i-m

+16 -12

3 comments

1 changed file

jyn514

pr closed time in a month

PullRequestReviewEvent

push eventjyn514/rustc-dev-guide

Tshepang Lekhonkhobe

commit sha 928cd7865a6e617e74d5316c835c30717a54f8a0

Update src/building/how-to-build-and-run.md

view details

push time in a month

Pull request review commentrust-lang/rustc-dev-guide

Link to 'prerequisites' immediately

 be hacking on `rustc`, you'll want to tweak the configuration of the compiler. The default configuration is oriented towards running the compiler as a user, not a developer. +For instructions on how to install python and other prerequisites,
For instructions on how to install Python and other prerequisites,
jyn514

comment created time in a month

PullRequestReviewEvent

push eventrust-lang/rustc-dev-guide

Ivan Tham

commit sha bb4695345ed432382f20e7ee1023754fa04a215c

Rename src/rustc to compiler/rustc

view details

push time in a month

more