profile
viewpoint
Thomas Shafer trshafer @google Seattle, WA

fmoo/react-typeahead 665

Pure react-based typeahead and typeahead-tokenizer

StevenLShafer/stanpumpR 7

stanpumpR, and PK/PD simulation program

2collegebums/passenger_reloader 5

Reloads passenger server when plugin files are edited

adigami/permissible_system 4

A database-configured, realtime authorization plugin for Rails.

trshafer/friendly_id 1

FriendlyId is the “Swiss Army bulldozer” of slugging and permalink plugins for ActiveRecord. It allows you to create pretty URL’s and work with human-friendly strings as if they were numeric ids for ActiveRecord models.

trshafer/hobson 1

A distributed testing framework built on resque

trshafer/538riddlers 0

Riddle solutions by the Riddler Solvers

issue commentknative/serving

`certificates.networking.internal.knative.dev` and `certificates.cert-manager.io` use same aliases

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

romachalm

comment created time in 9 minutes

issue commentknative/serving

when install fluent-ds the pods status CrashLoopBackOff and throw ConfigError

This issue is stale because it has been open for 90 days with no activity. It will automatically close after 30 more days of inactivity. Reopen the issue with /reopen. Mark the issue as fresh by adding the comment /remove-lifecycle stale.

wohugb

comment created time in 9 minutes

issue openedknative/serving

Revision controller needs some cleanup/organization

/area API /kind cleanup

Just revisited the revision controller after sometime. I figured I should write down my thoughts before I'm off on vacation starting now.

The revision controller is very fragile wrt. ordering of reconciling its child resources. Currently deployments are reconciled prior to pod autoscalers. Thus I've noticed:

  1. Phases reading into the revision status may be reading stale data
    • The deployment phase looks at the Active condition, then after the PodAutoscaler phase may updates it
    • MakePA looks at the revisions conditions to reconcile. Afterwards PA conditions are propagated to revision. Maybe this causes some churn?
  2. Last Mark*() method wins - there's code in the PA phase to guard against overriding false conditions that it assumes the deployment phase has set
  3. Re-ordering phases exposes assumptions:
    • deployment phase (when deployment is not found) marks the revision as 'Deploying' - but the PA phase doesn't.
    • test fixtures aren't accurate - ie. deployment was not ready when testing the steady state but still passed because of PA's ready state trumped all (see 2. above)

created time in 3 hours

pull request commentknative/serving

Development instructions update (k8s version, go)

@YoussB: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-upgrade-tests 315bfdafc8a301b025d484718063fc1a7e4b0558 link /test pull-knative-serving-upgrade-tests

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

YoussB

comment created time in 5 hours

pull request commentknative/test-infra

[master] Upgrade to latest dependencies

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: <a href="https://github.com/knative/test-infra/pull/2585#" title="Author self-approved">knative-automation</a>, <a href="https://github.com/knative/test-infra/pull/2585#issuecomment-734972214" title="Approved">vagababov</a> To complete the pull request process, please assign grantr after the PR has been reviewed. You can assign the PR to them by writing /assign @grantr in a comment when ready.

The full list of commands accepted by this bot can be found here.

<details open> Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":["grantr"]} -->

knative-automation

comment created time in 5 hours

pull request commentknative/test-infra

[master] Upgrade to latest dependencies

/lgtm /approve

knative-automation

comment created time in 5 hours

push eventknative/serving

knative-automation

commit sha 5c887f93b67f2d22ba6a96e26061f4b176062e09

Update net-contour nightly (#10206) Signed-off-by: Knative Automation <automation@knative.team>

view details

push time in 6 hours

PR merged knative/serving

[Automated] Update net-contour nightly approved cla: yes lgtm size/S

Produced via:

for x in net-contour.yaml contour.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-contour/latest/$x > ${GITHUB_WORKSPACE}/./third_party/contour-latest/$x
done

/assign @knative/networking-wg-leads /cc @knative/networking-wg-leads

+10 -10

6 comments

2 changed files

knative-automation

pr closed time in 6 hours

pull request commentknative/serving

[Automated] Update net-contour nightly

/retest

knative-automation

comment created time in 7 hours

push eventknative/serving

knative-automation

commit sha 2450784363016a86759795c151d053d7c083dcf0

Update net-kourier nightly (#10213) Signed-off-by: Knative Automation <automation@knative.team>

view details

push time in 8 hours

PR merged knative/serving

[Automated] Update net-kourier nightly approved cla: yes lgtm size/S

Produced via:

for x in kourier.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-kourier/latest/$x > ${GITHUB_WORKSPACE}/./third_party/kourier-latest/$x
done

/assign @knative/networking-wg-leads /cc @knative/networking-wg-leads

+11 -11

4 comments

1 changed file

knative-automation

pr closed time in 8 hours

pull request commentknative/serving

[Automated] Update net-contour nightly

@knative-automation: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-contour-latest 0ae46ac0180c9c4ba749596d993bf9a1a410468c link /test pull-knative-serving-contour-latest

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

knative-automation

comment created time in 9 hours

pull request commentknative/serving

[WIP] Migrate upgrade tests to the new framework

@mgencur: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-build-tests 92c1150f1177a63a42886ec572bc89f511cfc76e link /test pull-knative-serving-build-tests

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

mgencur

comment created time in 9 hours

push eventknative/serving

knative-automation

commit sha 15d9da79a3c122e157a12bac862f88db6b27b856

Update net-certmanager nightly (#10214) Signed-off-by: Knative Automation <automation@knative.team>

view details

push time in 10 hours

PR merged knative/serving

[Automated] Update net-certmanager nightly approved cla: yes lgtm size/S

Produced via:

for x in net-certmanager.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-certmanager/latest/$x > ${GITHUB_WORKSPACE}/./third_party/cert-manager-latest/$x
done

/assign @knative/networking-wg-leads /cc @knative/networking-wg-leads

+10 -10

3 comments

1 changed file

knative-automation

pr closed time in 10 hours

push eventknative/serving

Dave Protasowski

commit sha 99601bbeb15eb94c0b7e9b4c64a570a0bf17597d

on vacation (#10211)

view details

push time in 10 hours

PR merged knative/serving

Reviewers
on vacation approved cla: yes lgtm size/XS

<!-- Please include the 'why' behind your changes if no issue exists -->

Proposed Changes

  • Drop my name from my support week

Release Note

<!-- Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string "action required". If no release note is required, write "NONE". -->

NONE
+1 -1

3 comments

1 changed file

dprotaso

pr closed time in 10 hours

pull request commentknative/serving

[WIP] Migrate upgrade tests to the new framework

@mgencur: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-build-tests 202b8fb32d9eb6c29816b13d25ed1a980f00463b link /test pull-knative-serving-build-tests

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

mgencur

comment created time in 10 hours

pull request commentknative/serving

[WIP] Migrate upgrade tests to the new framework

@mgencur: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-build-tests 37cc9aa0e06a943b670e960988c81b4b2a1d8047 link /test pull-knative-serving-build-tests

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

mgencur

comment created time in 10 hours

pull request commentknative/serving

[Automated] Update net-kourier nightly

/retest

knative-automation

comment created time in 10 hours

pull request commentknative/serving

[Automated] Update net-contour nightly

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/knative/serving/pull/10206#issuecomment-734881010" title="Approved">dprotaso</a>, <a href="https://github.com/knative/serving/pull/10206#" title="Author self-approved">knative-automation</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

knative-automation

comment created time in 10 hours

pull request commentknative/serving

[Automated] Update net-contour nightly

/lgtm /approve

knative-automation

comment created time in 10 hours

pull request commentknative/serving

[Automated] Update net-kourier nightly

@knative-automation: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-kourier-stable 8599399b4e5ed9f769eee0d45ea9699409a58c3b link /test pull-knative-serving-kourier-stable
pull-knative-serving-istio-stable-no-mesh 8599399b4e5ed9f769eee0d45ea9699409a58c3b link /test pull-knative-serving-istio-stable-no-mesh

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

knative-automation

comment created time in 10 hours

pull request commentknative/serving

[Automated] Update net-kourier nightly

@knative-automation: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-kourier-stable 8599399b4e5ed9f769eee0d45ea9699409a58c3b link /test pull-knative-serving-kourier-stable

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

knative-automation

comment created time in 11 hours

pull request commentknative/serving

[WIP] Migrate upgrade tests to the new framework

@mgencur: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-knative-serving-build-tests 00f0abea8e59aafad12159304cec809cd89b4c77 link /test pull-knative-serving-build-tests

Full PR test history. Your PR dashboard.

<details>

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. </details> <!-- test report -->

mgencur

comment created time in 11 hours

push eventknative/serving

knative-automation

commit sha 16fb904214466123c9aeee5d2b6b12fb36f3b950

Update net-istio nightly (#10212) Signed-off-by: Knative Automation <automation@knative.team>

view details

push time in 11 hours

PR merged knative/serving

[Automated] Update net-istio nightly approved cla: yes lgtm size/M

Produced via:

for x in net-istio.yaml; do
  curl https://storage.googleapis.com/knative-nightly/net-istio/latest/$x > ${GITHUB_WORKSPACE}/./third_party/istio-latest/$x
done

/assign @knative/networking-wg-leads /cc @knative/networking-wg-leads

+15 -15

3 comments

1 changed file

knative-automation

pr closed time in 11 hours

pull request commentknative/serving

[Automated] Update net-kourier nightly

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/knative/serving/pull/10213#issuecomment-734856731" title="Approved">dprotaso</a>, <a href="https://github.com/knative/serving/pull/10213#" title="Author self-approved">knative-automation</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

knative-automation

comment created time in 11 hours

pull request commentknative/serving

[Automated] Update net-kourier nightly

/lgtm /approve

knative-automation

comment created time in 11 hours

pull request commentknative/serving

[Automated] Update net-istio nightly

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: <a href="https://github.com/knative/serving/pull/10212#issuecomment-734856568" title="Approved">dprotaso</a>, <a href="https://github.com/knative/serving/pull/10212#" title="Author self-approved">knative-automation</a>

The full list of commands accepted by this bot can be found here.

The pull request process is described here

<details > Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment </details> <!-- META={"approvers":[]} -->

knative-automation

comment created time in 11 hours

more