profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tpantelis/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Thomas Pantelis tpantelis Red Hat

mangelajo/submariner 0

Connect all your Kubernetes clusters, no matter where they are in the world.

mangelajo/submariner-operator 0

Submariner's Operator installs and maintains your Submariner deployment.

tpantelis/admiral 0

Admiral is the submariner API for integration with federation systems

tpantelis/cloud-prepare 0

Go library to prepare your cloud infrastructure via API for submariner to work on top

tpantelis/coastguard 0

Controller to facilitate network policing on a multi-cluster connected environments (proof-of-concept state)

tpantelis/enhancements 0

This repository contains enhancement proposals for submariner-io projects

tpantelis/lighthouse 0

Controller to facilitate DNS discovery between clusters (proof of concept state)

tpantelis/opendaylight-eclipse-setup 0

Eclipse "Oomph" setup models for OpenDaylight

tpantelis/openemr 0

OpenEMR is the most popular open source electronic health records and medical practice management solution. ONC certified with international usage, OpenEMR's goal is a superior alternative to its proprietary counterparts.

push eventtpantelis/admiral

Mike Kolesnik

commit sha 79a1277a59143b3f42b9fda6b6dec8fdeb2a4921

Rename job so it won't shard on stable branches Right now auto release logic updates `devel` to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections. To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

view details

push time in 20 hours

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

pull request commentopen-cluster-management/submariner-addon

Enable golangci-lint revive linter, fix errors

After improving the ignores, these are the new failures revive finds. What do you think @tpantelis, are these real issues? Any tips about fixing them?

pkg/helpers/testing/helpers.go:25:51: unexported-return: exported func NewFakeSyncContext returns unexported type *testing.fakeSyncContext, which can be annoying to use (revive)
func NewFakeSyncContext(t *testing.T, key string) *fakeSyncContext {
                                                  ^

This will be going away soon when converted to Ginkgo. You can either ignore it or change it to return factory.SyncContext from "github.com/openshift/library-go/pkg/controller/factory".

pkg/hub/submarineraddonagent/agent.go:78:98: unexported-return: exported func NewAddOnAgent returns unexported type *submarineraddonagent.addOnAgent, which can be annoying to use (revive) func NewAddOnAgent(kubeClient kubernetes.Interface, recorder events.Recorder, agentImage string) *addOnAgent {

Change it to return the interface agent.AgentAddon.

dfarrell07

comment created time in a day

pull request commentopen-cluster-management/submariner-addon

Enable golangci-lint nilerr linter, fix errors

CI job failed:

Can't get enabled linters: unknown linters: 'nilerr', run 'golangci-lint linters' to see the list of supported linters

So it seems the older golangci-lint version that prow uses doesn't contain the nilerr linter. Perhaps we can get it upgraded. I'll leave this open for now.

tpantelis

comment created time in 2 days

Pull request review commentsubmariner-io/admiral

Enable gocritic hugeParam, fix issues

 func GetAuthorizedRestConfig(apiServer, apiServerToken, caData string, tls rest. 	return } -func BuildRestConfig(apiServer, apiServerToken, caData string, tls rest.TLSClientConfig) (*rest.Config, error) {+func BuildRestConfig(apiServer, apiServerToken, caData string, tls *rest.TLSClientConfig) (*rest.Config, error) {+	if tls == nil {+		return nil, fmt.Errorf("can't build a RestConfig from nil")+	}

We can allow nil - just use an empty struct as the caller would have done before.

	if tls == nil {
		tls = &rest.TLSClientConfig{}
	}
skitt

comment created time in 2 days

Pull request review commentsubmariner-io/admiral

Enable gocritic hugeParam, fix issues

 import ( )  // TryAppendCondition appends the given Condition if it's not equal to the last Condition.-func TryAppendCondition(conditions []metav1.Condition, newCondition metav1.Condition) []metav1.Condition {+func TryAppendCondition(conditions []metav1.Condition, newCondition *metav1.Condition) []metav1.Condition {

Perhaps we should check for nil whether passed accidentally or not. We could log a message.

func TryAppendCondition(conditions []metav1.Condition, newCondition *metav1.Condition) []metav1.Condition {
    if newCondition == nil {
        klog.Warning("TryAppendCondition called with newCondition nil")
        return conditions
    }
skitt

comment created time in 2 days

PullRequestReviewEvent
PullRequestReviewEvent

pull request commentopen-cluster-management/submariner-addon

Enable golangci-lint nilerr linter, fix errors

/cc @skitt @dfarrell07

tpantelis

comment created time in 2 days

create barnchtpantelis/submariner-addon

branch : enable_nilerr

created branch time in 2 days

Pull request review commentopen-cluster-management/submariner-addon

Enable golangci-lint godot linter, fix errors

 var ( 	GroupName     = "submarineraddon.open-cluster-management.io" 	GroupVersion  = schema.GroupVersion{Group: GroupName, Version: "v1alpha1"} 	schemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)-	// Install is a function which adds this version to a scheme+	// Install is a function which adds this version to a scheme. 	Install = schemeBuilder.AddToScheme -	// SchemeGroupVersion generated code relies on this name-	// Deprecated+	// SchemeGroupVersion generated code relies on this name.+	// DEPRECATED! 	SchemeGroupVersion = GroupVersion-	// AddToScheme exists solely to keep the old generators creating valid code-	// DEPRECATED+	// AddToScheme exists solely to keep the old generators creating valid code.+	// DEPRECATED! 	AddToScheme = schemeBuilder.AddToScheme )  // Resource generated code relies on this being here, but it logically belongs to the group-// DEPRECATED+// DEPRECATED!
// Deprecated: generated code relies on Resource being present, but it logically belongs to the group.
dfarrell07

comment created time in 2 days

PullRequestReviewEvent

Pull request review commentopen-cluster-management/submariner-addon

Enable golangci-lint godot linter, fix errors

 var ( 	GroupName     = "submarineraddon.open-cluster-management.io" 	GroupVersion  = schema.GroupVersion{Group: GroupName, Version: "v1alpha1"} 	schemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)-	// Install is a function which adds this version to a scheme+	// Install is a function which adds this version to a scheme. 	Install = schemeBuilder.AddToScheme -	// SchemeGroupVersion generated code relies on this name-	// Deprecated+	// SchemeGroupVersion generated code relies on this name.+	// DEPRECATED!

It's recommended that deprecated code begin with "Deprecated:" followed by some information about the deprecation.

	// Deprecated: generated code relies on SchemeGroupVersion.
dfarrell07

comment created time in 2 days

Pull request review commentopen-cluster-management/submariner-addon

Enable golangci-lint godot linter, fix errors

 var ( 	GroupName     = "submarineraddon.open-cluster-management.io" 	GroupVersion  = schema.GroupVersion{Group: GroupName, Version: "v1alpha1"} 	schemeBuilder = runtime.NewSchemeBuilder(addKnownTypes)-	// Install is a function which adds this version to a scheme+	// Install is a function which adds this version to a scheme. 	Install = schemeBuilder.AddToScheme -	// SchemeGroupVersion generated code relies on this name-	// Deprecated+	// SchemeGroupVersion generated code relies on this name.+	// DEPRECATED! 	SchemeGroupVersion = GroupVersion-	// AddToScheme exists solely to keep the old generators creating valid code-	// DEPRECATED+	// AddToScheme exists solely to keep the old generators creating valid code.+	// DEPRECATED!
	// Deprecated: AddToScheme exists solely to keep the old generators creating valid code.
dfarrell07

comment created time in 2 days

PullRequestReviewEvent

push eventsubmariner-io/cloud-prepare

dependabot[bot]

commit sha 5d6d621a072b84dba562f73524668130902f4066

Bump github.com/aws/aws-sdk-go from 1.40.59 to 1.41.4 Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.40.59 to 1.41.4. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](https://github.com/aws/aws-sdk-go/compare/v1.40.59...v1.41.4) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

view details

push time in 2 days

PR merged submariner-io/cloud-prepare

Reviewers
Bump github.com/aws/aws-sdk-go from 1.40.59 to 1.41.4 dependencies

Bumps github.com/aws/aws-sdk-go from 1.40.59 to 1.41.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-sdk-go/releases">github.com/aws/aws-sdk-go's releases</a>.</em></p> <blockquote> <h1>Release v1.41.4 (2021-10-15)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/elasticfilesystem</code>: Updates service documentation <ul> <li>EFS adds documentation for a new exception for short identifiers to be thrown after its migration to long resource identifiers.</li> </ul> </li> <li><code>service/glue</code>: Updates service API and documentation <ul> <li>Enable S3 event base crawler API.</li> </ul> </li> </ul> <h1>Release v1.41.3 (2021-10-14)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/autoscaling</code>: Updates service API and documentation <ul> <li>Amazon EC2 Auto Scaling now supports filtering describe Auto Scaling groups API using tags</li> </ul> </li> <li><code>service/elasticloadbalancingv2</code>: Updates service API and documentation</li> <li><code>service/robomaker</code>: Updates service API and documentation</li> <li><code>service/sagemaker</code>: Updates service API and documentation <ul> <li>This release updates the provisioning artifact ID to an optional parameter in CreateProject API. The provisioning artifact ID defaults to the latest provisioning artifact ID of the product if you don't provide one.</li> </ul> </li> </ul> <h1>Release v1.41.2 (2021-10-13)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/config</code>: Updates service API</li> <li><code>service/ec2</code>: Updates service API and documentation <ul> <li>This release adds support for additional VPC Flow Logs delivery options to S3, such as Apache Parquet formatted files, Hourly partitions and Hive-compatible S3 prefixes</li> </ul> </li> <li><code>service/kinesisanalyticsv2</code>: Updates service API and documentation</li> <li><code>service/storagegateway</code>: Updates service API and documentation <ul> <li>Adding support for Audit Logs on NFS shares and Force Closing Files on SMB shares.</li> </ul> </li> <li><code>service/workmail</code>: Updates service API, documentation, and paginators <ul> <li>This release adds APIs for adding, removing and retrieving details of mail domains</li> </ul> </li> </ul> <h1>Release v1.41.1 (2021-10-12)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/cloudsearch</code>: Updates service API <ul> <li>Adds an additional validation exception for Amazon CloudSearch configuration APIs for better error handling.</li> </ul> </li> <li><code>service/ec2</code>: Updates service API and documentation <ul> <li>EncryptionSupport for InstanceStorageInfo added to DescribeInstanceTypes API</li> </ul> </li> <li><code>service/ecs</code>: Updates service documentation <ul> <li>Documentation only update to address tickets.</li> </ul> </li> <li><code>service/mediatailor</code>: Updates service API, documentation, and paginators</li> </ul> <h1>Release v1.41.0 (2021-10-11)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/ec2</code>: Updates service documentation</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md">github.com/aws/aws-sdk-go's changelog</a>.</em></p> <blockquote> <h1>Release v1.41.4 (2021-10-15)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/elasticfilesystem</code>: Updates service documentation <ul> <li>EFS adds documentation for a new exception for short identifiers to be thrown after its migration to long resource identifiers.</li> </ul> </li> <li><code>service/glue</code>: Updates service API and documentation <ul> <li>Enable S3 event base crawler API.</li> </ul> </li> </ul> <h1>Release v1.41.3 (2021-10-14)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/autoscaling</code>: Updates service API and documentation <ul> <li>Amazon EC2 Auto Scaling now supports filtering describe Auto Scaling groups API using tags</li> </ul> </li> <li><code>service/elasticloadbalancingv2</code>: Updates service API and documentation</li> <li><code>service/robomaker</code>: Updates service API and documentation</li> <li><code>service/sagemaker</code>: Updates service API and documentation <ul> <li>This release updates the provisioning artifact ID to an optional parameter in CreateProject API. The provisioning artifact ID defaults to the latest provisioning artifact ID of the product if you don't provide one.</li> </ul> </li> </ul> <h1>Release v1.41.2 (2021-10-13)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/config</code>: Updates service API</li> <li><code>service/ec2</code>: Updates service API and documentation <ul> <li>This release adds support for additional VPC Flow Logs delivery options to S3, such as Apache Parquet formatted files, Hourly partitions and Hive-compatible S3 prefixes</li> </ul> </li> <li><code>service/kinesisanalyticsv2</code>: Updates service API and documentation</li> <li><code>service/storagegateway</code>: Updates service API and documentation <ul> <li>Adding support for Audit Logs on NFS shares and Force Closing Files on SMB shares.</li> </ul> </li> <li><code>service/workmail</code>: Updates service API, documentation, and paginators <ul> <li>This release adds APIs for adding, removing and retrieving details of mail domains</li> </ul> </li> </ul> <h1>Release v1.41.1 (2021-10-12)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/cloudsearch</code>: Updates service API <ul> <li>Adds an additional validation exception for Amazon CloudSearch configuration APIs for better error handling.</li> </ul> </li> <li><code>service/ec2</code>: Updates service API and documentation <ul> <li>EncryptionSupport for InstanceStorageInfo added to DescribeInstanceTypes API</li> </ul> </li> <li><code>service/ecs</code>: Updates service documentation <ul> <li>Documentation only update to address tickets.</li> </ul> </li> <li><code>service/mediatailor</code>: Updates service API, documentation, and paginators</li> </ul> <h1>Release v1.41.0 (2021-10-11)</h1> <h3>Service Client Updates</h3> <ul> <li><code>service/ec2</code>: Updates service documentation</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/aws/aws-sdk-go/commit/bdbaf04864f503518c19b5f6d83e62ebf5d6bbe4"><code>bdbaf04</code></a> Release v1.41.4 (2021-10-15) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4135">#4135</a>)</li> <li><a href="https://github.com/aws/aws-sdk-go/commit/604e45fe9a2bae2916d32c542286cab431313dcc"><code>604e45f</code></a> Release v1.41.3 (2021-10-14) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4133">#4133</a>)</li> <li><a href="https://github.com/aws/aws-sdk-go/commit/40296143827033e447c2429dd0db906591e1a29f"><code>4029614</code></a> Release v1.41.2 (2021-10-13) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4131">#4131</a>)</li> <li><a href="https://github.com/aws/aws-sdk-go/commit/a4682d4210120fddcd2172057123998b2ca6fa02"><code>a4682d4</code></a> Release v1.41.1 (2021-10-12) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4130">#4130</a>)</li> <li><a href="https://github.com/aws/aws-sdk-go/commit/2e947ecd4b2ce3f00df92b4caf9fa95b9472ed21"><code>2e947ec</code></a> Release v1.41.0 (2021-10-11) (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4128">#4128</a>)</li> <li><a href="https://github.com/aws/aws-sdk-go/commit/f51ef4284d925803f7540a3baccd06bf7aa894ad"><code>f51ef42</code></a> Update SDK's serialization of REST-JSON API input and Content-Type (<a href="https://github-redirect.dependabot.com/aws/aws-sdk-go/issues/4116">#4116</a>)</li> <li>See full diff in <a href="https://github.com/aws/aws-sdk-go/compare/v1.40.59...v1.41.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+3 -3

0 comment

2 changed files

dependabot[bot]

pr closed time in 2 days

push eventsubmariner-io/submariner-operator

Mike Kolesnik

commit sha 3928012be343b70e8f1466472ba5cb8a9adb4aa8

Rename job so it won't shard on stable branches Right now auto release logic updates `devel` to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections. To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

view details

push time in 2 days

PR merged submariner-io/submariner-operator

Reviewers
Rename job so it won't shard on stable branches ready-to-test

Right now auto release logic updates devel to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections.

To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job

Signed-off-by: Mike Kolesnik mkolesni@redhat.com

<!-- Thanks for sending a pull request! Here are some tips for you:

  1. If this is your first time, please read our developer guide: https://submariner.io/development/
  2. Ensure you have added the appropriate tests for your PR: https://submariner.io/development/code-review/#test-new-functionality
  3. Read the code review guide to ease the review process: https://submariner.io/development/code-review/
  4. If the PR is unfinished, mark it as a draft: https://submariner.io/development/code-review/#mark-work-in-progress-prs-as-drafts
  5. If you are using CI to debug, use your private fork: https://submariner.io/development/code-review/#use-private-forks-for-debugging-prs-by-running-ci
  6. Add labels to the PR as appropriate.

This template is based on the K8s/K8s template:

https://github.com/kubernetes/kubernetes/blob/master/.github/PULL_REQUEST_TEMPLATE.md -->

+2 -2

1 comment

1 changed file

mkolesnik

pr closed time in 2 days

push eventtpantelis/submariner-addon

Tom Pantelis

commit sha 5e40f8a0ab4bcc211a2b4aa31e219a38de058135

Enable golangci-lint gocyclo linter, fix errors The existing min-complexity setting was 20 which yielded one function in violation. Generally 10 is considered within the cyclomatic complexity acceptable range but I think 15 is reasonable. Only 4 functions required some refactoring: pkg/spoke/submarineragent/deployment_controller.go:61:1: cyclomatic complexity 24 of func `(*deploymentStatusController).sync` is high (> 15) (gocyclo) func (c *deploymentStatusController) sync(ctx context.Context, syncCtx factory.SyncContext) error { ^ pkg/spoke/submarineragent/config_controller.go:115:1: cyclomatic complexity 20 of func `(*submarinerConfigController).sync` is high (> 15) (gocyclo) func (c *submarinerConfigController) sync(ctx context.Context, syncCtx factory.SyncContext) error { ^ pkg/hub/submarineragent/controller.go:261:1: cyclomatic complexity 16 of func `(*submarinerAgentController).syncManagedCluster` is high (> 15) (gocyclo) func (c *submarinerAgentController) syncManagedCluster( ^ pkg/hub/submarineragent/controller.go:176:1: cyclomatic complexity 16 of func `(*submarinerAgentController).sync` is high (> 15) (gocyclo) func (c *submarinerAgentController) sync(ctx context.Context, syncCtx factory.SyncContext) error { ^ Signed-off-by: Tom Pantelis <tompantelis@gmail.com>

view details

push time in 2 days

push eventsubmariner-io/cloud-prepare

Mike Kolesnik

commit sha 452e19ffdfdf1e5fa931e8b7abba42e1d02154fb

Rename job so it won't shard on stable branches Right now auto release logic updates `devel` to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections. To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

view details

Thomas Pantelis

commit sha e77916713964bd8d53f6105c333af02556e85702

Merge branch 'devel' into dependabot/go_modules/github.com/aws/aws-sdk-go-1.41.4

view details

push time in 2 days

PR merged submariner-io/get.submariner.io

Rename job so it won't shard on stable branches

Right now auto release logic updates devel to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections.

To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job

Signed-off-by: Mike Kolesnik mkolesni@redhat.com

+2 -2

1 comment

1 changed file

mkolesnik

pr closed time in 2 days

push eventsubmariner-io/get.submariner.io

Mike Kolesnik

commit sha fb6453d1adce15b3f1502af1a99916690efbb5b3

Rename job so it won't shard on stable branches Right now auto release logic updates `devel` to the stable branch name when creating stable branches. This leads to this job "sharding" into multiple jobs, and messes up branch protections. To keep things simple, the main job name will remain the same so that there's no "PR targets X" and "PR targets Y" jobs, just the one "PR targets branch" job Signed-off-by: Mike Kolesnik <mkolesni@redhat.com>

view details

push time in 2 days

push eventsubmariner-io/cloud-prepare

Automated Release

commit sha ce1381b955ef397d58386eb4a8d288ba64bb69cf

Pin Admiral to v0.11.0-rc2 Signed-off-by: Automated Release <release@submariner.io>

view details

push time in 2 days

PR merged submariner-io/cloud-prepare

Reviewers
Pin Admiral to v0.11.0-rc2 ready-to-test

Pin Admiral to v0.11.0-rc2

+4 -4

1 comment

2 changed files

submariner-bot

pr closed time in 2 days

PullRequestReviewEvent