profile
viewpoint

aboutyou/dart_packages 80

Dart and Flutter plugins maintained and used by @ABOUTYOU

tp/fetch-rs 4

Small Rust library to fetch web pages.

tp/fetchall 2

Make HTTP requests beyond the 32MB urlfetch limit on Google App Engine

tp/cursor-utilities 1

Create custom cursors for any modern browser.

tp/docky-thunderbird 1

Shows unread count as badge on Thunderbird icon

LunaONE/web 0

LunaONE website

tp/adjust_flutter_sdk 0

This is the Flutter SDK of

tp/ay-flutter-meetup-hh-2019-07-23 0

Flutter Meetup @ ABOUT YOU 2019-06-23

tp/azure-content 0

Repository containing the Articles on windowsazure.com Documentation Center

tp/babel-plugin-typecheck 0

Static and runtime type checking for JavaScript in the form of a Babel plugin.

PublicEvent

issue commentaboutyou/dart_packages

SignInWithAppleButton Text Style

@LiuJQ have you faced issues from Apple regarding this? We haven't gotten issues in regards that Apple rejects App with the provided styling of the button from our package.

Not yet, I haven't submit my app for approval.

muarachmann

comment created time in 7 hours

issue commentaboutyou/dart_packages

SignInWithAppleButton Text Style

@muarachmann our idea is to not use our SignInWithAppleButton widget at all but rather use your custom button widget (which is used for the other buttons) directly.

For that reason, we export the Apple logo which needs to be shown inside the button. This solution is also exactly what we do in our own App where we don't use the SignInWithAppleButton.

Hi thanks, I already revamped it and thanks for the reply

muarachmann

comment created time in 19 hours

issue commentaboutyou/dart_packages

SignInWithAppleButton Text Style

@LiuJQ have you faced issues from Apple regarding this? We haven't gotten issues in regards that Apple rejects App with the provided styling of the button from our package.

muarachmann

comment created time in 19 hours

issue commentaboutyou/dart_packages

SignInWithAppleButton Text Style

@muarachmann our idea is to not use our SignInWithAppleButton widget at all but rather use your custom button widget (which is used for the other buttons) directly.

For that reason, we export the Apple logo which needs to be shown inside the button. This solution is also exactly what we do in our own App where we don't use the SignInWithAppleButton.

muarachmann

comment created time in 19 hours

issue closedaboutyou/dart_packages

[sign_in_with_apple] I get the error Domain=AKAuthenticationError Code=-7022

Hi,
when I try to use the plugin I get the error as the subject.

I added the capability in xcode, and I do not know howto solve it.

closed time in 19 hours

giacomok

issue commentaboutyou/dart_packages

[sign_in_with_apple] I get the error Domain=AKAuthenticationError Code=-7022

Closing due to inactivity

giacomok

comment created time in 19 hours

issue closedaboutyou/dart_packages

AppleSignIn with Auth0 provider

Is there possible to use returned credentials to login using Auth0 provder (http://auth0.com) I have a flutter app and use this package to implement Apple Sign In feature. I get the authorization data from the Apple like below:

userIdentifier = "0XXXX7.6bb65XXXXXXXXXXXXXXXX36.1XXX2"
givenName = "test"
familyName = "signing"
email = "testemail@company.com"
authorizationCode = "c372xxxxxxxa526eexxxxxx1111e.0.rwsex.SwXxxXXXdDj_XxxXXXxxX"
identityToken = "eyJraXxxuxjxxxXxxxXx.eyJXxxxxtXxxxxxxhlYXxxXXxXxXXXXX"
state = null

The I have tried to send the authorizationCode as described here in Step 3: https://auth0.com/docs/connections/nativesocial/apple And I get the 403 Forbidded {"error":"invalid_grant","error_description":"Invalid authorization code"}

I have configured the settings in the Auth0 dashobard in Social and Applications section. Is there any way to use the autorizationCode to login using Auth0?

closed time in 19 hours

mkolbusz

issue commentaboutyou/dart_packages

AppleSignIn with Auth0 provider

Sorry for the late reply here @mkolbusz. Our library only forwards you the authorization code which we receive from Apple, so there should be nothing preventing you from using Auth0.

Please double check your configuration on Auth0 side as this is outside of our library scope.

mkolbusz

comment created time in 19 hours

issue commentaboutyou/dart_packages

[sign_in_with_apple] iOS 14 Simulator issues

If nothing happens after entering password and pressing Continue even on iOS 13 simulator, check this:

  • "Sign in with Apple" capability must be enabled in Xcode
  • "Sign in with Apple" capability must be enabled for the bundle id (from developer.apple.com/account/resources/identifiers/list)
  • Provisioning profile must be re-downloaded and set for signing, if using manual code signing
bakeyevrus

comment created time in 20 hours

startedleoafarias/fvm

started time in 3 days

issue commentaboutyou/dart_packages

SignInWithAppleButton Text Style

I have another question, the flutter SignInWithAppleButton doesn't seen like the same as the native one -.-!

flutter native
WX20201130-173025@2x WX20201130-172957@2x
muarachmann

comment created time in 3 days

issue commentgithubnemo/CompileDaemon

Reload not working on OSX

@githubnemo It would be great if warnings are documented in READMD.md. Can I update it? oh you already updated it. nevermind XD

Yep but thanks anyway :)

Btw, I believe using hot-reload daemon for production is not a good practice in itself, isn't it?

I have nothing against using fsnotify based hot-reload but using polling should be discouraged as it is quite wasteful and should never become a default or habit just because there's a bug somewhere.

paologf-mb

comment created time in 4 days

issue commentgithubnemo/CompileDaemon

Reload not working on OSX

oh you already updated it. nevermind XD

paologf-mb

comment created time in 4 days

issue commentgithubnemo/CompileDaemon

Reload not working on OSX

@githubnemo It would be great if warnings are documented in READMD.md. Can I update it?

Btw, I believe using hot-reload daemon for production is not a good practice in itself, isn't it?

paologf-mb

comment created time in 4 days

push eventgithubnemo/CompileDaemon

githubnemo

commit sha 39b144afa93c8bc1b8da4d498cd72c9927c1ce49

Document polling workaround

view details

push time in 4 days

issue commentgithubnemo/CompileDaemon

Change events not triggered in Docker after a while

Thanks to @HurSungYun, CompileDaemon now supports -polling=true which switches from FS notifications to active polling for changes. While this is neither instant (notifications are delayed by the polling rate) nor resource friendly (always looking instead of being event driven) it is a workaround to help get people back to work. I strongly discourage you from using this in any production environment.

yuraxdrumz

comment created time in 4 days

issue commentgithubnemo/CompileDaemon

Reload not working on OSX

Thanks to @HurSungYun, CompileDaemon now supports -polling=true which switches from FS notifications to active polling for changes. While this is neither instant (notifications are delayed by the polling rate) nor resource friendly (always looking instead of being event driven) it is a workaround to help get people back to work. I strongly discourage you from using this in any production environment.

paologf-mb

comment created time in 4 days

pull request commentgithubnemo/CompileDaemon

Add polling-style file watch option

thank you for your thoughtful reviews :)

HurSungYun

comment created time in 4 days

push eventgithubnemo/CompileDaemon

Lambert

commit sha cd9ce0bc6d5a4cb91ac99a2bd067dc71c4d6b19b

add file watcher using polling method

view details

Lambert

commit sha ec8c6ceccb99d6aa3f04a548f068456b6d4bbe69

change module name

view details

Lambert

commit sha 7af6fc5a1aef5a55aa39d9b7975d4defa58a715b

fix: use filepath.Walk to filter exclude-dir properly

view details

Lambert

commit sha 6075450cf97f7462c19f9e3a300ed412cd2ad126

chore: refactor common logics

view details

Lambert

commit sha 68eec40045fbe6e0101ecfc643df9469368790d5

change module name

view details

Sungyun Hur

commit sha bcbd3f4ef12e1ee80244180e2c0d2091f3e60083

Apply suggestions from code review Co-authored-by: githubnemo <githubnemo@users.noreply.github.com>

view details

Lambert

commit sha 6270e28dbc76887f1b52b811091135289fc71623

refactor global variables

view details

Lambert

commit sha b70935d7bb0d2edb0e4ae949167bb9bdaf3e7077

make polling interval a parameter

view details

Lambert

commit sha e4782d7e733a1176a65496aa9303466a2188faa4

update README.md

view details

push time in 4 days

PR merged githubnemo/CompileDaemon

Reviewers
Add polling-style file watch option

As discussed in #44 and #47, file watch via fsnotify is troublesome in some Mac OS X or Docker environment.

So, I implemented optional polling-style file watch mechanism to avoid horrible file system issues as suggested in #44.

It still has optional parameter to choose either polling or fsevent, so non-OS X user won't be affected by this change.

+232 -60

1 comment

5 changed files

HurSungYun

pr closed time in 4 days

pull request commentgithubnemo/CompileDaemon

Add polling-style file watch option

Thanks a lot! The changes are well implemented and I can see them being useful to workaround the issues around Docker on Mac OS X and Windows bind mounts.

HurSungYun

comment created time in 4 days

startedbitsdojo/bitsdojo_window

started time in 4 days

Pull request review commentgithubnemo/CompileDaemon

Add polling-style file watch option

 func main() { 		log.Fatal("Graceful termination is not supported on your platform.") 	} -	watcher, err := fsnotify.NewWatcher()+	///////////////////////////////++	watcher, err := NewWatcher(*flagPolling)

Absolutely I can :)

HurSungYun

comment created time in 4 days

Pull request review commentgithubnemo/CompileDaemon

Add polling-style file watch option

 import ( 	"path/filepath" 	"regexp" 	"strings"-	"syscall" 	"time"  	"github.com/fatih/color"-	"github.com/fsnotify/fsnotify" )  // Milliseconds to wait for the next job to begin after a file change const WorkDelay = 900 +// Milliseconds of interval between polling file changes when polling option is selected+const PollingInterval = 100

I have tested folder with about 150 files only, so there might be a problem with thousands of files. It would be better to make this an optional parameter.

HurSungYun

comment created time in 4 days

Pull request review commentgithubnemo/CompileDaemon

Add polling-style file watch option

+package main++import (+	"fmt"+	"github.com/fsnotify/fsnotify"+	pollingWatcher "github.com/radovskyb/watcher"+	"log"+	"os"+	"path/filepath"+	"regexp"+	"syscall"+	"time"+)++type FileWatcher interface {+	Close() error+	AddFiles(pattern *regexp.Regexp) error+	add(path string) error+	Watch(jobs chan<- string, pattern *regexp.Regexp)+}++type NotifyWatcher struct {+	watcher *fsnotify.Watcher+}++func (n NotifyWatcher) Close() error {+	return n.watcher.Close()+}++func (n NotifyWatcher) AddFiles(pattern *regexp.Regexp) error {+	return addFiles(n)+}++func (n NotifyWatcher) Watch(jobs chan<- string, pattern *regexp.Regexp) {+	for {+		select {+		case ev := <-n.watcher.Events:+			if ev.Op&fsnotify.Remove == fsnotify.Remove || ev.Op&fsnotify.Write == fsnotify.Write || ev.Op&fsnotify.Create == fsnotify.Create {+				base := filepath.Base(ev.Name)++				// Assume it is a directory and track it.+				if *flagRecursive == true && !flagExcludedDirs.Matches(ev.Name) {+					n.watcher.Add(ev.Name)+				}++				if flagIncludedFiles.Matches(base) || matchesPattern(pattern, ev.Name) {+					if !flagExcludedFiles.Matches(base) {

👍

HurSungYun

comment created time in 4 days

Pull request review commentgithubnemo/CompileDaemon

Add polling-style file watch option

+package main++import (+	"fmt"+	"github.com/fsnotify/fsnotify"+	pollingWatcher "github.com/radovskyb/watcher"+	"log"+	"os"+	"path/filepath"+	"regexp"+	"syscall"+	"time"+)++type FileWatcher interface {+	Close() error+	AddFiles(pattern *regexp.Regexp) error+	add(path string) error+	Watch(jobs chan<- string, pattern *regexp.Regexp)+}++type NotifyWatcher struct {+	watcher *fsnotify.Watcher+}++func (n NotifyWatcher) Close() error {+	return n.watcher.Close()+}++func (n NotifyWatcher) AddFiles(pattern *regexp.Regexp) error {+	return addFiles(n)+}++func (n NotifyWatcher) Watch(jobs chan<- string, pattern *regexp.Regexp) {+	for {+		select {+		case ev := <-n.watcher.Events:+			if ev.Op&fsnotify.Remove == fsnotify.Remove || ev.Op&fsnotify.Write == fsnotify.Write || ev.Op&fsnotify.Create == fsnotify.Create {+				base := filepath.Base(ev.Name)++				// Assume it is a directory and track it.+				if *flagRecursive == true && !flagExcludedDirs.Matches(ev.Name) {

sure :+1:

HurSungYun

comment created time in 4 days

Pull request review commentgithubnemo/CompileDaemon

Add polling-style file watch option

 import ( 	"path/filepath" 	"regexp" 	"strings"-	"syscall" 	"time"  	"github.com/fatih/color"-	"github.com/fsnotify/fsnotify" )  // Milliseconds to wait for the next job to begin after a file change const WorkDelay = 900 +// Milliseconds of interval between polling file changes when polling option is selected+const PollingInterval = 100

Is this something that should be an option? Did you have to tune this often?

HurSungYun

comment created time in 5 days

Pull request review commentgithubnemo/CompileDaemon

Add polling-style file watch option

 func main() { 		log.Fatal("Graceful termination is not supported on your platform.") 	} -	watcher, err := fsnotify.NewWatcher()+	///////////////////////////////++	watcher, err := NewWatcher(*flagPolling)

Personally I would have found it better to pass the global variables like ignored directories, flagRecursive, etc. to the watcher and not rely on global variables in watcher.go since it would make the component testable in the future. Do you think you can do that?

HurSungYun

comment created time in 5 days

Pull request review commentgithubnemo/CompileDaemon

Add polling-style file watch option

+package main++import (+	"fmt"+	"github.com/fsnotify/fsnotify"+	pollingWatcher "github.com/radovskyb/watcher"+	"log"+	"os"+	"path/filepath"+	"regexp"+	"syscall"+	"time"+)++type FileWatcher interface {+	Close() error+	AddFiles(pattern *regexp.Regexp) error+	add(path string) error+	Watch(jobs chan<- string, pattern *regexp.Regexp)+}++type NotifyWatcher struct {+	watcher *fsnotify.Watcher+}++func (n NotifyWatcher) Close() error {+	return n.watcher.Close()+}++func (n NotifyWatcher) AddFiles(pattern *regexp.Regexp) error {+	return addFiles(n)+}++func (n NotifyWatcher) Watch(jobs chan<- string, pattern *regexp.Regexp) {+	for {+		select {+		case ev := <-n.watcher.Events:+			if ev.Op&fsnotify.Remove == fsnotify.Remove || ev.Op&fsnotify.Write == fsnotify.Write || ev.Op&fsnotify.Create == fsnotify.Create {+				base := filepath.Base(ev.Name)++				// Assume it is a directory and track it.+				if *flagRecursive == true && !flagExcludedDirs.Matches(ev.Name) {+					n.watcher.Add(ev.Name)+				}++				if flagIncludedFiles.Matches(base) || matchesPattern(pattern, ev.Name) {+					if !flagExcludedFiles.Matches(base) {+						jobs <- ev.Name+					}+				}+			}++		case err := <-n.watcher.Errors:+			if v, ok := err.(*os.SyscallError); ok {+				if v.Err == syscall.EINTR {+					continue+				}+				log.Fatal("watcher.Error: SyscallError:", v)+			}+			log.Fatal("watcher.Error:", err)+		}+	}+}++func (n NotifyWatcher) add(path string) error {+	return n.watcher.Add(path)+}++type PollingWatcher struct {+	watcher *pollingWatcher.Watcher+}++func (p PollingWatcher) Close() error {+	p.watcher.Close()+	return nil+}++func (p PollingWatcher) AddFiles(pattern *regexp.Regexp) error {+	p.watcher.AddFilterHook(pollingWatcher.RegexFilterHook(pattern, false))++	return addFiles(p)+}++func (p PollingWatcher) Watch(jobs chan<- string, pattern *regexp.Regexp) {+	// Start the watching process.+	go func() {+		if err := p.watcher.Start(PollingInterval * time.Millisecond); err != nil {+			log.Fatalln(err)+		}+	}()++	for {+		select {+		case event := <-p.watcher.Event:+			if *flagVerbose {+				// Print the event's info.+				fmt.Println(event)+			}++			base := filepath.Base(event.Path)++			if flagIncludedFiles.Matches(base) || matchesPattern(pattern, event.Path) {+				if !flagExcludedFiles.Matches(base) {+					jobs <- event.String()+				}+			}+		case err := <-p.watcher.Error:+			if err == pollingWatcher.ErrWatchedFileDeleted {+				fmt.Println(err)

Shouldn't be the removal of a tracked file not trigger a warning at all? I would say this is quite normal.

HurSungYun

comment created time in 5 days

more