profile
viewpoint
Thomas Schaller torkleyy Wolf GmbH Bavaria, Germany

amethyst/rendy 702

State of the art "build your own engine" kit powered by gfx-hal

amethyst/shred 164

Shared resource dispatcher

amethyst/rfcs 32

RFCs are documents that contain major plans and decisions for the engine

rust-gamedev/ecs_bench_suite 23

A suite of benchmarks designed to test and compare Rust ECS library performance across a variety of challenging circumstances.

torkleyy/floating-duration 5

Rust duration conversion and formatting

torkleyy/clmerge 3

Opinionated, simple changelog merger

torkleyy/cargo-web 1

A Cargo subcommand for the client-side Web

Jolly5/potential-train 0

School project

torkleyy/ags 0

AGS editor and engine source code

torkleyy/alto 0

Idiomatic Rust bindings for OpenAL 1.1 and extensions (including EFX).

startedamethyst/legion

started time in 2 days

push eventtorkleyy/gShort

Thomas Schaller

commit sha 1a039b70b352c77b424b43c27accc1fd691b1c94

Update Dockerfile

view details

push time in 3 days

push eventtorkleyy/gShort

Thomas Schaller

commit sha e8afef219d3195bceaeb2cf46af8cee3419e7e6f

Create Dockerfile

view details

push time in 3 days

fork torkleyy/gShort

URL Shortener without all the crap

fork in 6 days

startedxcnt/kubernetes-update-manager

started time in 20 days

issue commentron-rs/ron

How do I round trip ron files preserving formatting and comments?

I don't think it's using serde though.

vi

comment created time in 23 days

issue commentron-rs/ron

How do I round trip ron files preserving formatting and comments?

Yes: https://github.com/ordian/toml_edit

This crate allows you to parse and modify toml documents, while preserving comments, spaces* and relative order* or items.

vi

comment created time in 23 days

issue closedslide-rs/atom

Create new cargo release to address safety issue

I noticed there's been a bunch of changes on master contributed by @dbkaplun that haven't made their way out onto the cargo crate. Most importantly, the latest release, 0.3.5 is missing https://github.com/slide-rs/atom/commit/dc096ef61a7cf69ce1a833a277b1c2a7c726c129 which fixes a fairly important soundness issue around the Send trait's bounds.

Without this commit, it's possible to Send across unsafe objects like Rc and potentially run into data races like so:

#![forbid(unsafe_code)]

extern crate atom;

use atom::Atom;
use std::rc::Rc;
use std::sync::mpsc;
use std::{thread, time, mem};

const NUM_CLONES: usize = 10000000;

fn main() {
    let x = Rc::new(());
    let y = Rc::clone(&x);

    // Place our Rc in the Atom through a Box.
    let shared_atom = Atom::empty();
    shared_atom.swap(Box::new(x));

    let child = thread::spawn(move || {
        // We now have the Rc shared across a thread.
        let x = shared_atom.take().unwrap();
        for _ in 0..NUM_CLONES {
            let clone = x.clone();
            mem::forget(clone);
        }
    });

    for _ in 0..NUM_CLONES {
        let clone = y.clone();
        mem::forget(clone);
    }

    // Wait for the spawned thread to finish its cloning.
    child.join().unwrap();

    // We made NUM_CLONES on both threads plus 2 references in the main thread.
    // But in reality we'll see that the strong_count varies across every run.
    assert_eq!(Rc::strong_count(&y), (NUM_CLONES * 2) + 2);
}

This could lead to use-after-frees and is a fairly easy mistake to make.

closed time in 23 days

ammaraskar

issue commentslide-rs/atom

Create new cargo release to address safety issue

Thanks for the report!

I released a patch, 0.3.6 which contains a backport of the linked commit (https://github.com/slide-rs/atom/tree/v0.3).

I also published the current master as 0.4.

ammaraskar

comment created time in 23 days

create barnchslide-rs/atom

branch : v0.3

created branch time in 23 days

push eventslide-rs/atom

Thomas Schaller

commit sha 2efac720e702c6f8b04a67e4a5bf27b456a46050

Bump to 0.4.0

view details

push time in 23 days

push eventtorkleyy/nitric

Thomas Schaller

commit sha a1ba2fdf6601c4fb6b184eeb0906ed9d4045801a

Update README.md

view details

push time in a month

delete branch ron-rs/ron

delete branch : rm-link

delete time in 2 months

push eventron-rs/ron

Thomas Schaller

commit sha 6ff3dd28a5019056b6b4f0fd3fd4f9487978bde7

Remove link to paid IntelliJ plugin reviews say "broken and dev doesn't respond"

view details

Thomas Schaller

commit sha 83628d99f24521c1d40712de30bdfaa56843ec80

Merge pull request #274 from ron-rs/rm-link Remove link to paid IntelliJ plugin

view details

push time in 2 months

PR merged ron-rs/ron

Remove link to paid IntelliJ plugin

reviews say "broken and dev doesn't respond"

see https://plugins.jetbrains.com/plugin/12635-ron-rusty-object-notation-/reviews

+1 -3

2 comments

1 changed file

torkleyy

pr closed time in 2 months

pull request commentron-rs/ron

Remove link to paid IntelliJ plugin

bors r+

torkleyy

comment created time in 2 months

PR opened ron-rs/ron

Remove link to paid IntelliJ plugin

reviews say "broken and dev doesn't respond"

see https://plugins.jetbrains.com/plugin/12635-ron-rusty-object-notation-/reviews

+1 -3

0 comment

1 changed file

pr created time in 2 months

create barnchron-rs/ron

branch : rm-link

created branch time in 2 months

issue commentron-rs/ron

pretty printing regression

Can this be closed?

m4b

comment created time in 2 months

push eventron-rs/ron.vim

Andreas Andersson

commit sha 04004b3395d219f95a533c4badd5ba831b7b7c07

Set indentation to 4 spaces by default (#5) To override add this to your .vimrc let g:ron_recommended_style = 0

view details

push time in 2 months

PR merged ron-rs/ron.vim

Set indentation to 4 spaces by default

This commit change so that vim use 4 space indentation when editing .ron files. A user can skip setting the indentation by adding let g:ron_recommended_style = 0 to their .vimrc.

I bet that the Rusty Object Notation file format does not really care about indentation, but humans in a rust mindset probably do. Setting up vim to use 4 space indentation makes for a consistent experience when working both in .rs and .ron files at the same time.

This change mimics how the rust vim plugin sets indentation in ftplugin/rust.vim.

+7 -0

0 comment

1 changed file

derwiath

pr closed time in 2 months

PullRequestReviewEvent

issue commentron-rs/ron

MSRV

RON is tested against 1.34 right now:

https://github.com/ron-rs/ron/blob/5947067d1505bb785f992d22c156d08d7e0ee302/.github/workflows/ci.yaml#L12

SirWindfield

comment created time in 2 months

more