profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/toph-allen/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Toph Allen toph-allen @rstudio New York toph.io

SaraBee/MCGJ 20

A Flask web app for running collaborative playlist parties

toph-allen/OutlineView 16

A simple SwiftUI re-implementation of an outline view, something roughly like NSOutlineView

rstudio/plumbertableau 3

R package for creating Plumber APIs that function as Tableau Analytics Extensions

toph-allen/nlmehaversine 1

A hacked-together version of R's nlme package to use great circle distances for gls() and lme() spatial autocorrelation distance matrices.

erchiggins/pairing-rc-w2-2020 0

Pair programming exercises from Recurse Center W2 2020

rstudio/fastapitableau 0

A Python package for writing FastAPI apps that you can call from Tableau.

toph-allen/Ashley 0

A Readable & Responsive Theme for Tumblr

toph-allen/calmotron 0

A script for producing randomly-generated ambient midi files

toph-allen/comma-chameleon 0

A desktop CSV editor with validation magic - Built with electron.js

push eventrstudio/fastapitableau

Toph Allen

commit sha dadc64c0e0942c4c73d247efbf8d838453ea45fa

cleanup

view details

push time in 2 days

PR opened rstudio/fastapitableau

Initial implementation of Tableau-friendly exception handlers

This PR adds exception handlers that format all returned exceptions in a Tableau-friendly manner. It also includes a few other misc changes.

Exception handling

There are two special case exception handlers for HTTPException and RequestValidationError, and a general fallback for all other Exceptions.

All exceptions are returned as JSON objects, with a message property containing Server Error: [Python Exception subclass name] and more detail in an info property. For example:

❯ curl -X 'POST' \
      'http://127.0.0.1:8000/evaluate' \
      -H 'accept: application/json' \
      -H 'Content-Type: application/json' \
      -d '{
          "script": "/fail",
          "data": {
                  "arg1_": ["rabbit"]
          }
  }' -i
HTTP/1.1 420
date: Thu, 23 Sep 2021 15:37:41 GMT
server: uvicorn
content-length: 52
content-type: application/json

{"message":"Server Error","info":"This didn't work"}


❯ curl -X 'POST' \
      'http://127.0.0.1:8000/fail' \
      -H 'accept: application/json' \
      -H 'Content-Type: application/json' \
      -d '{
          "first": ["Toph", "Bill", "James"]
  }'
{"message":"Server Error: RequestValidationError","info":"1 validation error for Request\nbody\n  value is not a valid list (type=type_error.list)"}

The special cases for RequestValidationError and HTTPException work around the fact that they contain .detail properties that aren't included when you run str(exception), and that they imply specific error codes.

The fallback, registered for all Exceptions, means that any error occurring in the server should be sent back in a Tableau-friendly manner.

Other changes

  • Moved get_swagger_ui_html() to openapi.py.
+187 -94

0 comment

6 changed files

pr created time in 2 days

push eventrstudio/fastapitableau

Toph Allen

commit sha 7a8f5115511553571002287042616151f96d69d7

Minor fix

view details

push time in 2 days

push eventrstudio/fastapitableau

Toph Allen

commit sha c4306cadee6d3c0a9ba74ec3973fbe056a17bc9b

Fixed issue

view details

push time in 2 days

create barnchrstudio/fastapitableau

branch : toph/exception-handlers

created branch time in 2 days

delete branch rstudio/fastapitableau

delete branch : update-connect-feature-flag

delete time in 2 days

push eventrstudio/fastapitableau

Bill Sager

commit sha 5b645b0096ddcc98778a47b555385a3b720b3c42

correct feature flag name

view details

Toph Allen

commit sha f323057f65bacce986a4fb59729b7a38949865e5

Merge pull request #13 from rstudio/update-connect-feature-flag correct feature flag name

view details

push time in 2 days

PR merged rstudio/fastapitableau

correct feature flag name

Description

Feature flag was wrong in error message..

+1 -1

0 comment

1 changed file

sagerb

pr closed time in 2 days

PullRequestReviewEvent

PR opened rstudio/fastapitableau

Style changes and wordsmithing

This PR contains a bunch of tweaks of the new styles, and incorporates Kelly's wordsmithing feedback.

Screen Shot 2021-09-22 at 6 03 55 PM

Screen Shot 2021-09-22 at 6 05 43 PM

Screen Shot 2021-09-22 at 6 05 48 PM

Screen Shot 2021-09-22 at 6 05 57 PM

+135 -38

0 comment

8 changed files

pr created time in 3 days

push eventrstudio/fastapitableau

Toph Allen

commit sha 13ca19668e84fadca60ff448d9849813cc89ce72

Got anchors working

view details

push time in 3 days

push eventrstudio/fastapitableau

Toph Allen

commit sha 00f38582e70433890fea4233f57cb9b8708279ab

Wordsmithing

view details

push time in 3 days

create barnchrstudio/fastapitableau

branch : toph/style-changes

created branch time in 3 days

push eventrstudio/fastapitableau

Bill Sager

commit sha ddb80f9b3bb1f8000a2d96cc33e2fe7374fa73d5

style adjustments - remove unused styles - combine style files - adjust left-margins - adjust swagger docs to be wide

view details

Bill Sager

commit sha c95ae1424a0047183d57e285c6f00ecb2045d09b

warning message styling

view details

Toph Allen

commit sha d39ccf9e2a4b1996e22f94ffe00a17aa05c32eab

Merge pull request #11 from rstudio/eliminate-unused-css

view details

push time in 3 days

delete branch rstudio/fastapitableau

delete branch : eliminate-unused-css

delete time in 3 days

PR merged rstudio/fastapitableau

Style adjustments for UX

Description

  • remove unused styles
  • combine style files
  • adjust left-margins
  • fix swagger docs to show their normal styles
  • adjust swagger docs to be wide
  • update styles for warning messages
+508 -5307

0 comment

7 changed files

sagerb

pr closed time in 3 days

PullRequestReviewEvent

Pull request review commentrstudio/fastapitableau

Style adjustments for UX

-{# <!DOCTYPE html>

The missing styles are used on lines 8 and 23 of this document.

sagerb

comment created time in 3 days

Pull request review commentrstudio/fastapitableau

Style adjustments for UX

+@charset "UTF-8";+html {+    box-sizing: border-box;+    -webkit-text-size-adjust: none;+    -ms-text-size-adjust: none;+    text-size-adjust: none+} -.padded-flat-top {-  padding: 0 1rem;+*,+:after,+:before {+    box-sizing: inherit } -.api-desc {-  margin-top: 0;+body {+    margin: 0+}++a,+button,+input,+label {+    -webkit-tap-highlight-color: transparent+}++a {+    color: inherit;+    text-decoration: none+}++img {+    border-style: none+}++:root {+    --md-default-fg-color: rgba(0, 0, 0, 0.87);+    --md-default-fg-color--light: rgba(0, 0, 0, 0.54);+    --md-default-fg-color--lighter: rgba(0, 0, 0, 0.32);+    --md-default-fg-color--lightest: rgba(0, 0, 0, 0.07);+    --md-default-bg-color: #fff;+    --md-default-bg-color--light: hsla(0, 0%, 100%, 0.7);+    --md-default-bg-color--lighter: hsla(0, 0%, 100%, 0.3);+    --md-default-bg-color--lightest: hsla(0, 0%, 100%, 0.12);+    --md-primary-fg-color: #4051b5;+    --md-primary-fg-color--light: #5d6cc0;+    --md-primary-fg-color--dark: #303fa1;+    --md-primary-bg-color: #fff;+    --md-primary-bg-color--light: hsla(0, 0%, 100%, 0.7);+    --md-accent-fg-color: #526cfe;+    --md-accent-fg-color--transparent: rgba(83, 108, 254, 0.1);+    --md-accent-bg-color: #fff;+    --md-accent-bg-color--light: hsla(0, 0%, 100%, 0.7)+}++:root>* {+    --md-code-fg-color: #24292f;+    --md-code-bg-color: rgba(175,184,193,0.2);+    --md-code-hl-color: rgba(255, 255, 0, 0.5);+    --md-code-hl-number-color: #d52a2a;+    --md-code-hl-special-color: #db1457;+    --md-code-hl-function-color: #a846b9;+    --md-code-hl-constant-color: #6e59d9;+    --md-code-hl-keyword-color: #3f6ec6;+    --md-code-hl-string-color: #1c7d4d;+    --md-code-hl-name-color: var(--md-code-fg-color);+    --md-code-hl-operator-color: var(--md-default-fg-color--light);+    --md-code-hl-punctuation-color: var(--md-default-fg-color--light);+    --md-code-hl-comment-color: var(--md-default-fg-color--light);+    --md-code-hl-generic-color: var(--md-default-fg-color--light);+    --md-code-hl-variable-color: var(--md-default-fg-color--light);+    --md-typeset-color: var(--md-default-fg-color);+    --md-typeset-a-color: var(--md-primary-fg-color);+    --md-typeset-mark-color: rgba(255, 255, 0, 0.5);+    --md-typeset-del-color: rgba(245, 80, 61, 0.15);+    --md-typeset-ins-color: rgba(11, 213, 112, 0.15);+    --md-typeset-kbd-color: #fafafa;+    --md-typeset-kbd-accent-color: #fff;+    --md-typeset-kbd-border-color: #b8b8b8;+    --md-admonition-fg-color: var(--md-default-fg-color);+    --md-admonition-bg-color: var(--md-default-bg-color);+    --md-footer-fg-color: #fff;+    --md-footer-fg-color--light: hsla(0, 0%, 100%, 0.7);+    --md-footer-fg-color--lighter: hsla(0, 0%, 100%, 0.3);+    --md-footer-bg-color: rgba(0, 0, 0, 0.87);+    --md-footer-bg-color--dark: rgba(0, 0, 0, 0.32)+}++.md-icon svg {+    display: block;+    width: 1.2rem;+    height: 1.2rem;+    fill: currentColor+}++body,+input {+    font-feature-settings: "kern", "liga";+    font-family: var(--md-text-font-family, _), -apple-system, BlinkMacSystemFont, Helvetica, Arial, sans-serif+}++:root {+    --md-typeset-table--ascending: url("data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'><path d='M11 4h2v12l5.5-5.5 1.42 1.42L12 19.84l-7.92-7.92L5.5 10.5 11 16V4z'/></svg>");+    --md-typeset-table--descending: url("data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'><path d='M13 20h-2V8l-5.5 5.5-1.42-1.42L12 4.16l7.92 7.92-1.42 1.42L13 8v12z'/></svg>")+}++.md-typeset {+    font-size: .8rem;+    line-height: 1.6;+    -webkit-print-color-adjust: exact;+    color-adjust: exact+}++.md-typeset blockquote,+.md-typeset dl,+.md-typeset figure,+.md-typeset ol,+.md-typeset pre,+.md-typeset ul {+    margin: 1em 0+}++.md-typeset h1 {+    margin: 0 0 1.25emline-height:1.3;+    font-size: 36px;+}++.md-typeset h1,+.md-typeset h2 {+    letter-spacing: -.01em+}++.md-typeset h2 {+    margin: 1.6em 0 .64em;+    font-size: 1.5625em;+    line-height: 1.4+}++.md-typeset h3 {+    margin: 1.6em 0 .8em;+    font-weight: bold;+    font-size: 1.25em;+    line-height: 1.5;+    letter-spacing: -.01em+}++.md-typeset h4 {+    margin: 1em 0;+    font-weight: 700;+    letter-spacing: -.01em+}++.md-typeset a {+    color: var(--md-typeset-a-color);+    word-break: break-word+}++.md-typeset a,+.md-typeset a:before {+    transition: color 125ms+}++.md-typeset a:focus,+.md-typeset a:hover {+    color: var(--md-accent-fg-color)+}++.md-typeset ul {+    list-style-type: disc+}++.md-typeset ol,+.md-typeset ul {+    margin-left: .625em;+    padding: 0+}++.md-typeset ol li,+.md-typeset ul li {+    margin-bottom: .5em;+    margin-left: 1.25em+}++.md-typeset ol li:last-child,+.md-typeset ul li:last-child {+    margin-bottom: 0+}++.md-typeset img,+.md-typeset svg {+    max-width: 100%;+    height: auto+}++html {+    height: 100%;+    overflow-x: hidden;+    font-size: 125%+}++body {+    position: relative;+    display: flex;+    flex-direction: column;+    width: 100%;+    min-height: 100%;+    font-size: .5rem;+    background-color: var(--md-default-bg-color)+}++/* .md-grid {+    max-width: 61rem;+    margin-right: auto;+    margin-left: auto+} */++.md-container {+    display: flex;+    flex-direction: column;+    flex-grow: 1+}++.md-main {+    flex-grow: 1+}++.md-main__inner {+    display: flex;+    height: 100%;+}++.md-ellipsis {+    overflow: hidden;+    white-space: nowrap;+    text-overflow: ellipsis+}++:root {+    --md-clipboard-icon: url("data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'><path d='M19 21H8V7h11m0-2H8a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h11a2 2 0 0 0 2-2V7a2 2 0 0 0-2-2m-3-4H4a2 2 0 0 0-2 2v14h2V3h12V1z'/></svg>")+}++.md-content {+    flex-grow: 1;+    overflow: hidden;+    scroll-padding-top: 51.2rem+}++.md-content__inner {+    margin: 0 .8rem 1.2rem 20px;+    padding-top: .6rem;+    max-width: 710px+}++.md-content__inner:before {+    display: block;+    height: .4rem;+    content: ""+}++.md-content__inner>:last-child {+    margin-bottom: 0+}++.md-header {+    position: -webkit-sticky;+    position: sticky;+    top: 0;+    right: 0;+    left: 0;+    z-index: 2;+    color: var(--md-primary-bg-color);+    background-color: var(--md-primary-fg-color);+    box-shadow: 0 0 .2rem transparent, 0 .2rem .4rem transparent }-.route {-  margin-bottom: 3rem;-  max-width: 1000px;++.md-header[data-md-state=shadow] {+    box-shadow: 0 0 .2rem rgba(0, 0, 0, .1), 0 .2rem .4rem rgba(0, 0, 0, .2);+    transition: transform .25s cubic-bezier(.1, .7, .1, 1), box-shadow .25s } -.route h3 {

This is the missing style referenced above

sagerb

comment created time in 3 days

Pull request review commentrstudio/fastapitableau

Style adjustments for UX

+@charset "UTF-8";+html {+    box-sizing: border-box;+    -webkit-text-size-adjust: none;+    -ms-text-size-adjust: none;+    text-size-adjust: none+} -.padded-flat-top {-  padding: 0 1rem;+*,+:after,+:before {+    box-sizing: inherit } -.api-desc {-  margin-top: 0;+body {+    margin: 0+}++a,+button,+input,+label {+    -webkit-tap-highlight-color: transparent+}++a {+    color: inherit;+    text-decoration: none+}++img {+    border-style: none+}++:root {+    --md-default-fg-color: rgba(0, 0, 0, 0.87);+    --md-default-fg-color--light: rgba(0, 0, 0, 0.54);+    --md-default-fg-color--lighter: rgba(0, 0, 0, 0.32);+    --md-default-fg-color--lightest: rgba(0, 0, 0, 0.07);+    --md-default-bg-color: #fff;+    --md-default-bg-color--light: hsla(0, 0%, 100%, 0.7);+    --md-default-bg-color--lighter: hsla(0, 0%, 100%, 0.3);+    --md-default-bg-color--lightest: hsla(0, 0%, 100%, 0.12);+    --md-primary-fg-color: #4051b5;+    --md-primary-fg-color--light: #5d6cc0;+    --md-primary-fg-color--dark: #303fa1;+    --md-primary-bg-color: #fff;+    --md-primary-bg-color--light: hsla(0, 0%, 100%, 0.7);+    --md-accent-fg-color: #526cfe;+    --md-accent-fg-color--transparent: rgba(83, 108, 254, 0.1);+    --md-accent-bg-color: #fff;+    --md-accent-bg-color--light: hsla(0, 0%, 100%, 0.7)+}++:root>* {+    --md-code-fg-color: #24292f;+    --md-code-bg-color: rgba(175,184,193,0.2);+    --md-code-hl-color: rgba(255, 255, 0, 0.5);+    --md-code-hl-number-color: #d52a2a;+    --md-code-hl-special-color: #db1457;+    --md-code-hl-function-color: #a846b9;+    --md-code-hl-constant-color: #6e59d9;+    --md-code-hl-keyword-color: #3f6ec6;+    --md-code-hl-string-color: #1c7d4d;+    --md-code-hl-name-color: var(--md-code-fg-color);+    --md-code-hl-operator-color: var(--md-default-fg-color--light);+    --md-code-hl-punctuation-color: var(--md-default-fg-color--light);+    --md-code-hl-comment-color: var(--md-default-fg-color--light);+    --md-code-hl-generic-color: var(--md-default-fg-color--light);+    --md-code-hl-variable-color: var(--md-default-fg-color--light);+    --md-typeset-color: var(--md-default-fg-color);+    --md-typeset-a-color: var(--md-primary-fg-color);+    --md-typeset-mark-color: rgba(255, 255, 0, 0.5);+    --md-typeset-del-color: rgba(245, 80, 61, 0.15);+    --md-typeset-ins-color: rgba(11, 213, 112, 0.15);+    --md-typeset-kbd-color: #fafafa;+    --md-typeset-kbd-accent-color: #fff;+    --md-typeset-kbd-border-color: #b8b8b8;+    --md-admonition-fg-color: var(--md-default-fg-color);+    --md-admonition-bg-color: var(--md-default-bg-color);+    --md-footer-fg-color: #fff;+    --md-footer-fg-color--light: hsla(0, 0%, 100%, 0.7);+    --md-footer-fg-color--lighter: hsla(0, 0%, 100%, 0.3);+    --md-footer-bg-color: rgba(0, 0, 0, 0.87);+    --md-footer-bg-color--dark: rgba(0, 0, 0, 0.32)+}++.md-icon svg {+    display: block;+    width: 1.2rem;+    height: 1.2rem;+    fill: currentColor+}++body,+input {+    font-feature-settings: "kern", "liga";+    font-family: var(--md-text-font-family, _), -apple-system, BlinkMacSystemFont, Helvetica, Arial, sans-serif+}++:root {+    --md-typeset-table--ascending: url("data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'><path d='M11 4h2v12l5.5-5.5 1.42 1.42L12 19.84l-7.92-7.92L5.5 10.5 11 16V4z'/></svg>");+    --md-typeset-table--descending: url("data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'><path d='M13 20h-2V8l-5.5 5.5-1.42-1.42L12 4.16l7.92 7.92-1.42 1.42L13 8v12z'/></svg>")+}++.md-typeset {+    font-size: .8rem;+    line-height: 1.6;+    -webkit-print-color-adjust: exact;+    color-adjust: exact+}++.md-typeset blockquote,+.md-typeset dl,+.md-typeset figure,+.md-typeset ol,+.md-typeset pre,+.md-typeset ul {+    margin: 1em 0+}++.md-typeset h1 {+    margin: 0 0 1.25emline-height:1.3;+    font-size: 36px;+}++.md-typeset h1,+.md-typeset h2 {+    letter-spacing: -.01em+}++.md-typeset h2 {+    margin: 1.6em 0 .64em;+    font-size: 1.5625em;+    line-height: 1.4+}++.md-typeset h3 {+    margin: 1.6em 0 .8em;+    font-weight: bold;+    font-size: 1.25em;+    line-height: 1.5;+    letter-spacing: -.01em+}++.md-typeset h4 {+    margin: 1em 0;+    font-weight: 700;+    letter-spacing: -.01em+}++.md-typeset a {+    color: var(--md-typeset-a-color);+    word-break: break-word+}++.md-typeset a,+.md-typeset a:before {+    transition: color 125ms+}++.md-typeset a:focus,+.md-typeset a:hover {+    color: var(--md-accent-fg-color)+}++.md-typeset ul {+    list-style-type: disc+}++.md-typeset ol,+.md-typeset ul {+    margin-left: .625em;+    padding: 0+}++.md-typeset ol li,+.md-typeset ul li {+    margin-bottom: .5em;+    margin-left: 1.25em+}++.md-typeset ol li:last-child,+.md-typeset ul li:last-child {+    margin-bottom: 0+}++.md-typeset img,+.md-typeset svg {+    max-width: 100%;+    height: auto+}++html {+    height: 100%;+    overflow-x: hidden;+    font-size: 125%+}++body {+    position: relative;+    display: flex;+    flex-direction: column;+    width: 100%;+    min-height: 100%;+    font-size: .5rem;+    background-color: var(--md-default-bg-color)+}++/* .md-grid {+    max-width: 61rem;+    margin-right: auto;+    margin-left: auto+} */++.md-container {+    display: flex;+    flex-direction: column;+    flex-grow: 1+}++.md-main {+    flex-grow: 1+}++.md-main__inner {+    display: flex;+    height: 100%;+}++.md-ellipsis {+    overflow: hidden;+    white-space: nowrap;+    text-overflow: ellipsis+}++:root {+    --md-clipboard-icon: url("data:image/svg+xml;charset=utf-8,<svg xmlns='http://www.w3.org/2000/svg' viewBox='0 0 24 24'><path d='M19 21H8V7h11m0-2H8a2 2 0 0 0-2 2v14a2 2 0 0 0 2 2h11a2 2 0 0 0 2-2V7a2 2 0 0 0-2-2m-3-4H4a2 2 0 0 0-2 2v14h2V3h12V1z'/></svg>")+}++.md-content {+    flex-grow: 1;+    overflow: hidden;+    scroll-padding-top: 51.2rem+}++.md-content__inner {+    margin: 0 .8rem 1.2rem 20px;+    padding-top: .6rem;+    max-width: 710px+}++.md-content__inner:before {+    display: block;+    height: .4rem;+    content: ""+}++.md-content__inner>:last-child {+    margin-bottom: 0+}++.md-header {+    position: -webkit-sticky;+    position: sticky;+    top: 0;+    right: 0;+    left: 0;+    z-index: 2;+    color: var(--md-primary-bg-color);+    background-color: var(--md-primary-fg-color);+    box-shadow: 0 0 .2rem transparent, 0 .2rem .4rem transparent }-.route {-  margin-bottom: 3rem;-  max-width: 1000px;++.md-header[data-md-state=shadow] {+    box-shadow: 0 0 .2rem rgba(0, 0, 0, .1), 0 .2rem .4rem rgba(0, 0, 0, .2);+    transition: transform .25s cubic-bezier(.1, .7, .1, 1), box-shadow .25s } -.route h3 {

There was also a block in home.css that applied to pre and code, and we were using code in the User Guide. This is just from memory for later reference for me

sagerb

comment created time in 3 days

Pull request review commentrstudio/fastapitableau

Style adjustments for UX

+@charset "UTF-8";+html {

image

Some of our code styling has been reverted or is missing. I'd made some changes in the last PR — copying font strings and padding from GitHub. I'm not sure if that was an intentional change, or something that got accidentally pulled out in the accidental CSS stripping.

Either way, happy to work on it some more. It'll be much easier with this more streamlined setup. 👍🏻

sagerb

comment created time in 3 days

Pull request review commentrstudio/fastapitableau

Style adjustments for UX

+@charset "UTF-8";

This is so much more manageable than before!!

sagerb

comment created time in 3 days

Pull request review commentrstudio/fastapitableau

Style adjustments for UX

 def custom_get_swagger_ui_html(     </header>     <!-- END: Insert our header into the documentation --> -    <!-- BEGIN: Embed swagger docs into our style containers -->-    <div class="md-container">-    <main class="md-main">-      <div class="md-main__inner md-grid">-        <div class="md-content">-          <article class="md-content__inner md-typeset" style="margin-top: -2.7rem !important; margin-left: -5px;">-    <!-- END: Embed swagger docs into our style containers -->+    <!-- BEGIN: Small container to make positions consistent between this and other pages -->

Thanks for doing this in a more consistent way.

I wasn't as clear when I was talking about it last night, but I do agree with you that the slightly larger left margin looks better. I think that I was reacting to the narrow max width of the Swagger docs within our UI — I think padding the left and right sides evenly, rather than forcing it to be the same column width as everything else, would be acceptable too. :)

sagerb

comment created time in 3 days

PullRequestReviewEvent

push eventrstudio/fastapitableau

Toph Allen

commit sha bb6933ef183f916f6d05eeaccabff6f2f23facb7

more minor tweaks

view details

push time in 4 days

push eventrstudio/fastapitableau

Toph Allen

commit sha 5f8d067ca33417c5f780a69778ec20f5578d3b18

Fix the bug that Mike encountered

view details

Toph Allen

commit sha 947f37a2f89767059f0394058b9e72287042ae93

Some wordsmithing on the home page Misc other small changes

view details

push time in 4 days

push eventrstudio/fastapitableau

Toph Allen

commit sha 0a170fcccc33684b051793174f9697a8ad9d6ca4

Small fixes - Remove ".min" from the no-longer-minified CSS file's name - Move calc_app_base_url() out of the app object, since it is associated with requests, not apps. It now lives in utils.py.

view details

push time in 4 days

push eventrstudio/fastapitableau

Toph Allen

commit sha 00234f64bf9a0b9af2e90bdb203650e4d3fa302b

Unminified CSS

view details

Toph Allen

commit sha b7d0f90f968b4271b045fabf4d900a3ebaf1bf0c

Cleaned up the styling a little. - Unminified the big blob of styles - Checked and removed the old styles.css file and renamed new_styles.css to styles.css. - Removed the "orig-" prefix.

view details

push time in 4 days

push eventrstudio/fastapitableau

Toph Allen

commit sha 13785ffe42bb8d35a0b400d439a36175384d1cc0

Reintroduce some checks for non-current Connect versions Bill pointed out some checks were R-specific. Those haven't been reintroduced.

view details

push time in 4 days

Pull request review commentrstudio/fastapitableau

Bill's Update UX branch

-    <div class="args">+    <div class="orig-route-args">

It's unclear to me why the orig prefix is added here. Is there a new-route-args class too?

toph-allen

comment created time in 4 days