profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tomers/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Tomer Shalev tomers Haifa, Israel

tomers/quasar-geolocation-example 12

Sample app demonstrating usage of geolocation with Quasar Framework

tomers/docker-ubuntu-14.04-python-3.6.2 1

Dockerfile with Ubuntu 14.04 and python 3.6.2

tomers/node-devops-boilerplate 1

Simple Node.js boilerplate to demonstrate deployment with testing, linting and coverage reporting, CI/CD using Circle CI

tomers/quasar-i18n-example 1

A sample app to demonstrate Quasar's i18n capabilities

tomers/age-gender-estimation 0

Keras implementation of a CNN network for age and gender estimation

tomers/aiobotocore 0

asyncio support for botocore library using aiohttp

tomers/app-extension-devour-client 0

JSON API client for Quasar Framework

tomers/app-extension-geolocation 0

A Quasar App Extension to add Geolocation support

tomers/click-log 0

Simple and beautiful logging for click applications

issue commentc-icap/c-icap-server

c-icap crashes on reconfigure

@abolinhas, if this issue is fixed, could you please close this ticket?

abolinhas

comment created time in 2 months

issue closedc-icap/c-icap-server

Valgrind reported issue: memory leak of port list

==17== 2,056 bytes in 1 blocks are possibly lost in loss record 736 of 770
==17==    at 0x48A16C0: malloc (vg_replace_malloc.c:306)
==17==    by 0x48CB3C9: pool_allocator_alloc (mem.c:813)
==17==    by 0x48C9AF7: ci_buffer_alloc (mem.c:186)
==17==    by 0x48D7C4D: ci_vector_create (array.c:350)
==17==    by 0x116DA5: cfg_set_port (cfg_param.c:403)
==17==    by 0x118901: process_line (cfg_param.c:883)
==17==    by 0x118ACC: parse_file (cfg_param.c:919)
==17==    by 0x118280: cfg_include_config_file (cfg_param.c:713)
==17==    by 0x118901: process_line (cfg_param.c:883)
==17==    by 0x118ACC: parse_file (cfg_param.c:919)
==17==    by 0x118CF8: config (cfg_param.c:981)
==17==    by 0x10F439: main (aserver.c:154)

In mpmt_server.c::start_server() I see the call to ci_port_list_release(CI_CONF.PORTS) on shutdown. In the console I can see the Exiting.... line, so I know it was called. However, Valgrind reports that the memory allocated by cg_set_port was not released eventually.

closed time in 2 months

tomers

issue commentc-icap/c-icap-server

Valgrind reported issue: memory leak of port list

Ok, good to know. Thanks for this info, @chtsanti. This issue was made following Valgrind report, which indicated this as a potential memory leak. It would be nice to somehow suppress that warning. I hope your future fixes will resolve it. Closing this ticket for now.

tomers

comment created time in 2 months

startedmarceloprates/prettymaps

started time in 2 months

issue commentc-icap/c-icap-server

Valgrind reported issue: memory leak of port list

@chtsanti, could you advice how can this be resolved? I am willing to try to fix this, but I need guidance, as I am not familiar with the configuration sub-system...

tomers

comment created time in 2 months

pull request commentc-icap/c-icap-server

NSOF-5427acl: destroy ACL upon shutdown

Hi Christoc,

Could you please deploy a new version with recent changes?

Thanks, Tomer

On Mon, Aug 23, 2021 at 6:20 PM Christos Tsantilas ***@***.***> wrote:

Merged #25 https://github.com/c-icap/c-icap-server/pull/25 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/c-icap/c-icap-server/pull/25#event-5195179368, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAUL42QBKW6KJU7Z3SWKLDT6JRM5ANCNFSM5ANBTUYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

tomers

comment created time in 2 months

delete branch tomers/c-icap-server

delete branch : destroy-acl

delete time in 2 months

push eventtomers/vector

Tomer Shalev

commit sha c0530ca2fc183c53087ec2e886e5baba6c26c506

Introduce aggregate configuration If aggregate=true reduce transformation behaves like aggregator that aggregates records and flushes them periodically Signed-off-by: Tomer Shalev <shalev.tomer@gmail.com>

view details

push time in 2 months

push eventtomers/vector

Tomer Shalev

commit sha 8e69d3697cdaeb495666b701b01c4a72be74bd06

Introduce aggregate configuration If aggregate=true reduce transformation behaves like aggregator that aggregates records and flushes them periodically Signed-off-by: Tomer Shalev <shalev-tomer@gmail.com>

view details

push time in 2 months

PR opened timberio/vector

feat(transforms): Introduce aggregate configuration

If aggregate=true reduce transformation behaves like aggregator that aggregates records and flushes them periodically

type=feat

Closes issue #8747

+12 -4

0 comment

1 changed file

pr created time in 2 months

create barnchtomers/vector

branch : aggregate-configuration

created branch time in 2 months

issue openedtimberio/vector

Aggregates events per period, from first event

In current implementation it closes aggregation based on some value or field. The suggestion implementation adds aggregate field, that when set to true it just aggregates per period.

created time in 2 months

startedtomers/vector

started time in 2 months

fork tomers/vector

A high-performance, highly reliable, observability data pipeline.

https://vector.dev

fork in 2 months

Pull request review commentc-icap/c-icap-server

NSOF-5427acl: destroy ACL upon shutdown

 static void exit_normaly() #ifdef MULTICHILD     child_data = NULL;     dettach_childs_queue(childs_queue);+    ci_acl_destroy();

There's no include now

tomers

comment created time in 3 months

PullRequestReviewEvent
PullRequestReviewEvent

Pull request review commentc-icap/c-icap-server

NSOF-5427acl: destroy ACL upon shutdown

 int ci_acl_typelist_init(struct ci_acl_type_list *list)     return 1; } +void ci_acl_typelist_destroy(struct ci_acl_type_list *list)+{+    free(list->acl_type_list);

Fixed.

tomers

comment created time in 3 months

issue openedquasarframework/quasar

Add --quiet flag to quasar build

Following discussion #10285, it would be great to have quasar build --quiet flag which suppresses progress-bars. This is very useful for CI runs.

created time in 3 months

issue commentmitsuhiko/redis-rs

password can't support #

Rust code:

use urlencoding::encode;

...

    fn get_connection_info(redis_password: &str, redis_host: &str, redis_port: &str) -> String {
        format!(
            "redis://:{}@{}:{}/",
            encode(redis_password),
            redis_host,
            redis_port
        )
    }
figo361

comment created time in 3 months

push eventtomers/redis-rs

Tomer Shalev

commit sha b52bcb3433f86bb700a32a3ea0a1e897b2096d34

Extend test_redis_url_fromstr

view details

push time in 3 months

issue commentmitsuhiko/redis-rs

password can't support #

You need to encode the password that is set in the connection info URL. See examples in: https://github.com/mitsuhiko/redis-rs/pull/522/files

❯ python3 -c "from urllib.parse import quote; print(quote('/mypass#/+ word=$+', safe=''))"
%2Fmypass%23%2F%2B%20word%3D%24%2B
figo361

comment created time in 3 months

issue closedmitsuhiko/redis-rs

Client does not quoted password in connection info URL

While migrating my Python code (using the redis-py client library) to Rust, I've encountered a case where I had a URL with password that contains a slash. This resulted in Redis URL did not parse error.

I triaged the issue and found that the rust client does not treat the password string from the URL as an encoded string.

The Python client does treat the password field (among some other fields too!) as quoted strings:

  • Implementation: https://github.com/andymccurdy/redis-py/blob/master/redis/connection.py#L953
  • Test code: https://github.com/andymccurdy/redis-py/blob/master/tests/test_connection_pool.py#L379

Having special characters in the password field breaks the URL parsing. This was also reported in issue #517.

closed time in 3 months

tomers

issue commentmitsuhiko/redis-rs

Client does not quoted password in connection info URL

This issue is wrong, since the URL should contain an encoded password in the first place... Closing

tomers

comment created time in 3 months

PR opened mitsuhiko/redis-rs

Extend test_redis_url_fromstr
+14 -1

0 comment

1 changed file

pr created time in 3 months

create barnchtomers/redis-rs

branch : extend_test_redis_url_fromstr

created branch time in 3 months

fork tomers/redis-rs

Redis library for rust

https://docs.rs/redis

fork in 3 months

startedmitsuhiko/redis-rs

started time in 3 months

issue openedmitsuhiko/redis-rs

Client does not quoted password in connection info URL

While migrating my Python code (using the redis-py client library) to Rust, I've encountered a case where I had a URL with password that contains a slash. This resulted in Redis URL did not parse error.

I triaged the issue and found that the rust client does not treat the password string from the URL as an encoded string.

The Python client does treat the password field (among some other fields too!) as quoted strings:

  • Implementation: https://github.com/andymccurdy/redis-py/blob/master/redis/connection.py#L953
  • Test code: https://github.com/andymccurdy/redis-py/blob/master/tests/test_connection_pool.py#L379

Having special characters in the password field breaks the URL parsing. This was also reported in issue #517.

created time in 3 months

fork tomers/rust-url

URL parser for Rust

https://docs.rs/url/

fork in 3 months