profile
viewpoint

tnajdek/ASCII--Dammit 32

Stupid library to turn MS chars (like smart quotes) and ISO-Latin chars into ASCII, dammit. Will do plain text approximations, or more accurate HTML representations. Can also be jiggered to just fix the smart quotes and leave the rest of ISO-Latin alone.

tnajdek/django-kendoui-backend 23

Generic data backend for Kendo UI components

fcheslack/libZoteroJS 18

JS implementation of libZotero

tnajdek/bootstrap-multiselector 2

Little widget for Twitter's Bootstrap to enable nice mechanism of grouping check boxes under single drop-down box and a customizable label

tnajdek/django-json-utils 2

A few reusable JSON utilities.

tnajdek/django-media-bundler 1

Django application that bundles your Javascript and CSS and sprites your icons.

tnajdek/gamejs 1

A thin library on top of the HTML canvas element. The API is modeled after PyGame.

tnajdek/jquery-typing 1

assign callbacks for started/stopped typing events

issue openedzotero/zotero

Create stored-file copy of linked files when dragging parent item to group library

https://forums.zotero.org/discussion/comment/369199/#Comment_369199

We may or may not want to do this as the default, but it could at least be an option if we add a wizard to confirm what to copy

created time in a day

push eventzotero/zotero

Dan Stillman

commit sha 01646f1f8f403c61afa8eea6a8dd9af071fbf56b

Fix regression in 84730e610c Only switch item types in fromJSON() if one was actually parsed out of Extra

view details

push time in a day

push eventzotero/zotero

Dan Stillman

commit sha 17cafcb0133fa7fafa351ecc96c51836937a26d2

Update version

view details

Dan Stillman

commit sha 84730e610c6b4caf4f954054b40dc3d96fb04b93

Don't delete valid item/CSL type from Type in Extra on sync After a local item change, Zotero uploads the JSON and then applies the saved JSON returned from the API to the local object using `fromJSON()`, the same as it would apply any other remote change. `fromJSON()` is meant to migrate Extra lines into real types and fields after future item type/field changes. It calls `Z.Utilities.Internal.extractExtraFields()`, which looks for valid item type or CSL type values in Type lines in Extra, handles the rest of parsing accordingly, and passes back the parsed item type. `fromJSON()` wasn't handling `itemType` in the response object, so the item type didn't get applied and the Type line was stripped. This fixes that. Since valid type values are now parsed, if you have a Journal Article item with a Pages field and enter "Type: song" into Extra and sync, the item will be converted to Audio Recording and `Pages: 123` will be placed in Extra. https://forums.zotero.org/discussion/comment/369221/#Comment_369221

view details

Dan Stillman

commit sha a249cd16086655816eae422140d149d24847a398

Update citeproc-js to 1.4.50

view details

push time in a day

issue openedzotero/zotero

Ignore punctuation in citation dialog search

https://forums.zotero.org/discussion/86401/robustness-of-quickformatcitations-autocomplete-to-commas-semicolons-etc

created time in a day

starteddmtrKovalenko/odiff

started time in 2 days

startedtnajdek/zotero-api-client

started time in 4 days

issue openedzotero/zotero

How to set author name in batches?

for exampe: zotero's default setting is Jiang and yu-gang image I want change it to yu-gang jiang: image

But it’s silly to make changes one by one, can I change that in a faster way?

created time in 4 days

push eventzotero/zotero

Adomas Venčkauskas

commit sha ddcbb47538097cf0014a6c7f011b96efd9dc4c88

Fix number inputs and adjust linux styling for feed settings

view details

push time in 5 days

push eventzotero/zotero

Dan Stillman

commit sha c4cc44528c4352d47c240403520bc8106152b0d3

Fix error upgrading old databases after errors 5b9e6497af8 Creating missing tables breaks schema update steps that assume those tables don't exist, so we'll need another solution here. For now, disable the automatic integrity check and make a couple recent schema update steps more forgiving for people on the beta who already triggered this.

view details

push time in 5 days

PR opened zotero/zotero

Sync storage
  • Allows for setting different cache size limits for My Library and Group Libraries
  • Currently the process to identify/delete files only is kicked off by a temporary context menu item. It will eventually be started by a change in preference (should be debounced somehow) and when new files are downloaded through automatic syncing.
  • Only affects attachment files
  • Provides a separate "Manual Cache", which provides Download/Remove options for both individual attachments or entire items
  • In preferences dialog there is a View Storage Breakdown, which scans your entire storage folder and identifies cache sizes for automatic and manual cache (This should probably be broken out by library as well).
+1306 -36

0 comment

27 changed files

pr created time in 5 days

startedbendyzx/imagesaver

started time in 6 days

pull request commentzotero/zotero

Update metadata

Blue yellow or red then?

mrtcode

comment created time in 8 days

pull request commentzotero/zotero

Update metadata

We currently use a green checkmark (which may or may not be right) when there are no changes, so I don't think it could be green.

mrtcode

comment created time in 8 days

pull request commentzotero/zotero

Update metadata

The exclamation mark for available changes seems a little alarming, though I don't have a better suggestion off-hand

Perhaps a green circle 🟢 ?

mrtcode

comment created time in 8 days

push eventzotero/zotero

Dan Stillman

commit sha 75497e14c7588eef8092f4ff99b859b186c3ae2e

Item context menu: "Create Parent Item" → "Create Parent Item…" Now that a dialog is displayed asking for further input Follow-up to #1901

view details

Dan Stillman

commit sha 304a38083c77939b5b7d1749ecf0670b3ae0d812

Update locales from Transifex and merge new English strings

view details

push time in 8 days

push eventzotero/zotero

fletcherhaz

commit sha 86b77cc45e71321278facad88053f38b34a197d9

Add an option to create parent item from identifier (#1901)

view details

push time in 8 days

pull request commentzotero/zotero

Add an option to create parent item from identifier

A few more things:

  • Let's go with padding: 20px 15px; instead of 2em for the dialog padding
  • "to identify this item" → "to identify this file" — I guess this depends on whether you're identifying the file or identifying the parent item you're about to create, but given that you start with a file and we're putting the filename above the text box in bold, "file" seems more right to me
  • We should disable the accept button when the input box is empty
fletcherhaz

comment created time in 9 days

Pull request review commentzotero/zotero

Add an option to create parent item from identifier

 'use strict';  import React, { memo } from 'react';+import ReactDom from "react-dom";

ReactDomReactDOM

fletcherhaz

comment created time in 9 days

issue openedzotero/zotero

Error due to long filenames or path when exporting on Windows

[JavaScript Error: "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIFile.copyTo]" {file: "chrome://zotero/content/xpcom/translation/translate_item.js" line: 1208}]

This is a longstanding problem. For file sync, we shorten filenames, and we could try something similar here.

created time in 9 days

pull request commentzotero/zotero

Update engines.json, add 3 search engines

I'd like to point out that sci-hub is not legal in many jurisdictions.

qizidog

comment created time in 9 days

fork JPustkuchen/jquery-typing

assign callbacks for started/stopped typing events

narf.pl/jquery-typing

fork in 10 days

pull request commentzotero/zotero

Add an option to create parent item from identifier

Also, for what it's worth, we kind of gave up on the container/component split thing. If there's no compelling reason to keep that, it's fine to combine into just a component. In the past I've found it a little useful to develop a complicated component outside of Zotero, with nothing Zotero-specific in the component, but that's probably not necessary here.

fletcherhaz

comment created time in 10 days

pull request commentzotero/zotero

Add an option to create parent item from identifier

Let's try this:

mockup

  • Just the PDF as the title. "Create parent item for:" with a colon is a bit weird.
  • I think "Create Empty Parent" → "Manual Entry" makes more sense. "Create Empty Parent" is technically more accurate — it's the creation of the empty item that's happening immediately — but we don't really say "Parent" without "Item", and "Manual Entry" makes it a little clearer what you're setting yourself up for by creating an empty item.
  • Add <?xml-stylesheet href="chrome://zotero-platform/content/overlay.css" type="text/css"?> to get proper the font for the input box on macOS
  • font-size: 14px for the input
  • Slight change in order of identifiers in placeholder, and no colon
  • Narrower width
  • Align buttons with input box
fletcherhaz

comment created time in 10 days

Pull request review commentzotero/zotero

Add an option to create parent item from identifier

 var ZoteroPane = new function() 	}; 	 	-	this.createParentItemsFromSelected = Zotero.Promise.coroutine(function* () {+	this.createParentItemsFromSelected = async function () { 		if (!this.canEdit()) { 			this.displayCannotEditLibraryMessage(); 			return; 		} 		-		var items = this.getSelectedItems();-		for (var i=0; i<items.length; i++) {-			var item = items[i];-			if (!item.isTopLevelItem() || item.isRegularItem()) {-				throw('Item ' + itemID + ' is not a top-level attachment or note in ZoteroPane_Local.createParentItemsFromSelected()');-			}-			-			yield Zotero.DB.executeTransaction(function* () {+		let item = this.getSelectedItems()[0];+		if (!item.isAttachment() || !item.isTopLevelItem()) {+			throw('Item ' + itemID + ' is not a top-level attachment');

throwthrow new Error (that's why we can remove the function name)

fletcherhaz

comment created time in 10 days

push eventzotero/zotero

Tom Najdek

commit sha 67f4b5254c9d47f85e7ce81cfa800a9c9b1f3993

Switch to pure js sass compiler

view details

Dan Stillman

commit sha f393a233e9be0882f07d884fca01468494f39dfd

Merge pull request #1912 from tnajdek/js-sass-compiler Switch to pure js sass compiler

view details

push time in 10 days

PR merged zotero/zotero

Switch to pure js sass compiler
+1906 -3734

0 comment

3 changed files

tnajdek

pr closed time in 10 days

issue openedzotero/zotero

Don't allow items to be set as child items of notes

(Except for embedded image attachments in a future version)

https://forums.zotero.org/discussion/86214/sync-error-parent-item-ajxhtfhx-cannot-be-a-child-item

Probably a plugin bug, but it shouldn't be allowed

created time in 11 days

push eventzotero/zotero

Fletcher Hazlehurst

commit sha a2620b757df3b950a4d7b3c4fdd0c72892a2f069

Update SingleFile and fix several bugs - Using `sandboxPrototype` properly uses window as prototype - This commit removes the need for our patch in babel-worker.js: https://github.com/gildas-lormeau/SingleFile/commit/3d0bc4cf9fd23e4fe8f5b684a89c69521c306b60 - We properly inject into frames in the client if we ever include frames

view details

Fletcher Hazlehurst

commit sha c0ec91f26d694c63b6baf1334c4bed6692496e15

Fix bug for empty title when a translator does not provide one.

view details

Fletcher Hazlehurst

commit sha a72ae1481631dcefe603ef9ff3a1a9f7f5c747d8

Fix bug with double saving of snapshots.

view details

Dan Stillman

commit sha 07874d84bd2fbcb33ba7f2e0800f4760a4540b15

Merge pull request #1909 from fletcherhaz/snapshot Update SingleFile for bug fixes

view details

push time in 11 days

PR merged zotero/zotero

Update SingleFile for bug fixes
  • Using sandboxPrototype properly uses window as prototype
  • This commit removes the need for our patch in babel-worker.js https://github.com/gildas-lormeau/SingleFile/commit/3d0bc4cf9fd23e4fe8f5b684a89c69521c306b60

This fixes #1908 and other similar issues like it.

@dstillman I also turned off removeFrames and included an extra commit that properly injects scripts to retrieve frame contents in the client. So frames should be working in both the connector and the client without the 10 second delay we saw before.

Here are two forum posts which both now work with these commits: https://forums.zotero.org/discussion/85726/error-report-zetero-connector-failed-to-upload-webpage-snapshot https://forums.zotero.org/discussion/85603/bug-in-zotero-beta-video-iframe-image-not-saved-in-snapshot

+184 -89

6 comments

8 changed files

fletcherhaz

pr closed time in 11 days

more