profile
viewpoint

JasonVMo/office-ui-fabric-react 0

React components for building experiences for Office and Office 365.

tkamireh/fluentui-react-native 0

A react-native control library aligned with office-ui-fabric-react

tkamireh/just 0

The task library that just works

tkamireh/office-ui-fabric-react 0

React components for building experiences for Office and Office 365.

tkamireh/react-native-windows 0

A framework for building native Windows apps with React.

tkamireh/yoga 0

Yoga is a cross-platform layout engine which implements Flexbox. Follow https://twitter.com/yogalayout for updates.

PR opened microsoft/fluentui-react-native

Add readme for using svgs in fluent react native

Platforms Impacted

  • [ ] iOS
  • [ ] macOS
  • [ ] win32 (Office)
  • [ ] windows
  • [ ] android

Description of changes

(a summary of the changes made, often organized by file)

Verification

(how the change was tested, including both manual and automated tests)

Before After
Screenshot or description before this change Screenshot or description with this change

Pull request checklist

This PR has considered (when applicable):

  • [ ] Automated Tests
  • [x] Documentation and examples
  • [ ] Keyboard Accessibility
  • [ ] Voiceover
  • [ ] Internationalization and Right-to-left Layouts
+132 -0

0 comment

1 changed file

pr created time in 3 days

Pull request review commentmicrosoft/fluentui-react-native

Add Icon support for iOS

 const testTtf = require('./assets/Font Awesome 5 Free-Solid-900.otf'); import TestSvg from './assets/test.svg';  const icons: React.FunctionComponent<{}> = () => {-  const rasterProps: RasterImageIconProps = { src: testImage };+  const fontCustomFontProps: FontIconProps = {+    fontFamily: 'Font Awesome 5 Free',+    fontSrcFile: testTtf,+    codepoint: 0xf083,+    fontSize: 32,+  };++  const fontBuiltInProps = {+    fontFamily: 'Arial',+    codepoint: 0x2663,+    fontSize: 32,+  };    const svgProps: SvgIconProps = {     src: TestSvg,     viewBox: '0 0 500 500',   }; +  // d20 icon by Lonnie Tapscott, licensed under CC BY, modified to use "currentColor"+  // https://thenounproject.com/search/?q=d20&i=2453700+  const svgD20DataUriProps: SvgIconProps = {+    uri: 'data:image/svg;base64,PHN2ZyBoZWlnaHQ9JzMwMHB4JyB3aWR0aD0nMzAwcHgnIGZpbGw9ImN1cnJlbnRDb2xvciIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB2aWV3Qm94PSIwIDAgMTAwIDEwMCIgeD0iMHB4IiB5PSIwcHgiPjx0aXRsZT5BcnRib2FyZCA2PC90aXRsZT48cGF0aCBkPSJNOTEuOSw2MS4zN2wtMTQtNDJhMiwyLDAsMCwwLTEuMzMtMS4yOWwtMzctMTFhMiwyLDAsMCwwLTIsLjUxbC0zMSwzMWEyLDIsMCwwLDAtLjQ4LDIuMDZsMTUsNDRBMiwyLDAsMCwwLDIyLjczLDg2bDM2LDVMNTksOTFhMiwyLDAsMCwwLDEuMzEtLjQ5bDMxLTI3QTIsMiwwLDAsMCw5MS45LDYxLjM3Wk0yNC40NCw4MiwzMS42LDQ3LjA1bDMzLjA4LDM0Wk03Ny4yNiwzMS42OSwzMi4zMyw0My42MWw3LjA2LTMxLjc1Wm0tNDcsMTIuMTJMMTEuMTYsMzkuNjYsMzYuODgsMTRaTTY2LjM4LDc5LjkyLDMyLjkxLDQ1LjUzLDc4LjM4LDMzLjQ2bC4xMi4zNS0xMiw0NlpNNzcsMjkuMjlsLTMwLjUyLTE2LDI4LDguMzFaTTEwLjY2LDQxLjZsMTkuMTYsNC4xN0wyMy4xNiw3OC4yNlpNNTguMzcsODYuODksMzUuNSw4My43MmwyNy4yMy0uNjJabTEwLjg1LTkuNDRMNzkuNjYsMzcuMjlsOCwyNC4wOFpNNDEuNjQsMzUuNWE3LDcsMCwwLDEsMS44NS0zLjgyLDE2LjkzLDE2LjkzLDAsMCwwLDEuODQtMi41OEEyLjQ0LDIuNDQsMCwwLDAsNDUuNCwyN2EyLjY3LDIuNjcsMCwwLDAtMS4xMy0xLjI4LDIuMzQsMi4zNCwwLDAsMC0xLjc0LS4yMWMtLjkuMi0xLjM4LjY0LTEuNDYsMS4zMWE0LjM1LDQuMzUsMCwwLDAsLjM2LDEuNzRsLTMsLjdhNiw2LDAsMCwxLS40Mi0zYy4yNi0xLjUxLDEuNC0yLjQ3LDMuNC0yLjkxYTYuNjIsNi42MiwwLDAsMSw0LjIxLjMxLDUuMjcsNS4yNywwLDAsMSwyLjczLDIuNzEsMy44MiwzLjgyLDAsMCwxLC4yMSwyLjg2LDcuNDYsNy40NiwwLDAsMS0xLjM1LDIuMjhsLS44NSwxLjA4cS0uODEsMS0xLjA4LDEuNDdBMi44MSwyLjgxLDAsMCwwLDQ1LDM1bDYuNjItMS43NCwxLjExLDIuNDVMNDIuMDksMzguNkE2Ljc1LDYuNzUsMCwwLDEsNDEuNjQsMzUuNVpNNTYuNTcsMjEuODFBMTMsMTMsMCwwLDEsNjAsMjYuMzZhMTAuNDgsMTAuNDgsMCwwLDEsMS40Nyw1LjI4Yy0uMSwxLjQtMS4wNiwyLjM2LTIuODcsMi44NWE1LjExLDUuMTEsMCwwLDEtNC43Ni0uODIsMTMsMTMsMCwwLDEtMy41My00LjkzLDkuNzgsOS43OCwwLDAsMS0xLjItNS4yNWMuMi0xLjMsMS4xOS0yLjE0LDMtMi41M0E1LjE4LDUuMTgsMCwwLDEsNTYuNTcsMjEuODFabS0xLjI2LDkuNjZhMi4xMywyLjEzLDAsMCwwLDIuMjUuODEsMS4yOSwxLjI5LDAsMCwwLDEtMS42NiwxMy43MiwxMy43MiwwLDAsMC0xLjMzLTMuNTcsMTUsMTUsMCwwLDAtMi4wNi0zLjM0QTIuMDksMi4wOSwwLDAsMCw1My4wNywyMywxLjI0LDEuMjQsMCwwLDAsNTIsMjQuNDYsMTIuNjcsMTIuNjcsMCwwLDAsNTMuMjMsMjgsMTUuMzMsMTUuMzMsMCwwLDAsNTUuMzEsMzEuNDdaIj48L3BhdGg+PC9zdmc+',+    viewBox: '25 10 50 50'+  };++  // This one doesn't get tinted because it doesn't use currentColor   const svgUriProps: SvgIconProps = {     uri: 'https://upload.wikimedia.org/wikipedia/commons/8/84/Example.svg',-    viewBox: '0 0 100 100',+    viewBox: '0 0 1000 1000'   }; -  const fontProps: FontIconProps = {-    fontFamily: `Font Awesome 5 Free`,-    fontSrcFile: testTtf,-    codepoint: 0xf083,-    fontSize: 32,-  };+  const rasterRainbowSpectrumProps: RasterImageIconProps = { src: testImage };++  // Chess icon by Justicon, licensed under CC BY+  // https://thenounproject.com/search/?q=chess&i=2960386+  const rasterChessProps: RasterImageIconProps = { src: { uri: 'https://static.thenounproject.com/png/2960386-200.png' } };++  const showFontIcons = true;

Maybe just add a comment explaining that it's togglable for debugging? Might be a little confusing to others without more context

amgleitman

comment created time in 3 days

Pull request review commentmicrosoft/fluentui-react-native

Add Icon support for iOS

 function renderRasterImage(iconProps: IconProps) { }  function fontFamilyFromFontSrcFile(fontSrcFile: string, fontFamily: string): string {-  const asset = assetRegistry.getAssetByID(fontSrcFile);-  return `${fontFamily}#${asset.httpServerLocation}/${asset.name}.${asset.type}`;+  if (Platform.OS == 'windows') {

Can you comment that in code? Sometimes that's not always obvious to someone else looking at this once it gets checked in

amgleitman

comment created time in 3 days

Pull request review commentmicrosoft/fluentui-react-native

Add Icon support for iOS

 function renderRasterImage(iconProps: IconProps) { }  function fontFamilyFromFontSrcFile(fontSrcFile: string, fontFamily: string): string {-  const asset = assetRegistry.getAssetByID(fontSrcFile);-  return `${fontFamily}#${asset.httpServerLocation}/${asset.name}.${asset.type}`;+  if (Platform.OS == 'windows') {

Font icon support should be available; I've just been having trouble getting the font bundled in. That's why I added an Arial-based font icon to the test page.

amgleitman

comment created time in 7 days

Pull request review commentmicrosoft/fluentui-react-native

Add Icon support for iOS

 const testTtf = require('./assets/Font Awesome 5 Free-Solid-900.otf'); import TestSvg from './assets/test.svg';  const icons: React.FunctionComponent<{}> = () => {-  const rasterProps: RasterImageIconProps = { src: testImage };+  const fontCustomFontProps: FontIconProps = {+    fontFamily: 'Font Awesome 5 Free',+    fontSrcFile: testTtf,+    codepoint: 0xf083,+    fontSize: 32,+  };++  const fontBuiltInProps = {+    fontFamily: 'Arial',+    codepoint: 0x2663,+    fontSize: 32,+  };    const svgProps: SvgIconProps = {     src: TestSvg,     viewBox: '0 0 500 500',   }; +  // d20 icon by Lonnie Tapscott, licensed under CC BY, modified to use "currentColor"+  // https://thenounproject.com/search/?q=d20&i=2453700+  const svgD20DataUriProps: SvgIconProps = {+    uri: 'data:image/svg;base64,PHN2ZyBoZWlnaHQ9JzMwMHB4JyB3aWR0aD0nMzAwcHgnIGZpbGw9ImN1cnJlbnRDb2xvciIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB2aWV3Qm94PSIwIDAgMTAwIDEwMCIgeD0iMHB4IiB5PSIwcHgiPjx0aXRsZT5BcnRib2FyZCA2PC90aXRsZT48cGF0aCBkPSJNOTEuOSw2MS4zN2wtMTQtNDJhMiwyLDAsMCwwLTEuMzMtMS4yOWwtMzctMTFhMiwyLDAsMCwwLTIsLjUxbC0zMSwzMWEyLDIsMCwwLDAtLjQ4LDIuMDZsMTUsNDRBMiwyLDAsMCwwLDIyLjczLDg2bDM2LDVMNTksOTFhMiwyLDAsMCwwLDEuMzEtLjQ5bDMxLTI3QTIsMiwwLDAsMCw5MS45LDYxLjM3Wk0yNC40NCw4MiwzMS42LDQ3LjA1bDMzLjA4LDM0Wk03Ny4yNiwzMS42OSwzMi4zMyw0My42MWw3LjA2LTMxLjc1Wm0tNDcsMTIuMTJMMTEuMTYsMzkuNjYsMzYuODgsMTRaTTY2LjM4LDc5LjkyLDMyLjkxLDQ1LjUzLDc4LjM4LDMzLjQ2bC4xMi4zNS0xMiw0NlpNNzcsMjkuMjlsLTMwLjUyLTE2LDI4LDguMzFaTTEwLjY2LDQxLjZsMTkuMTYsNC4xN0wyMy4xNiw3OC4yNlpNNTguMzcsODYuODksMzUuNSw4My43MmwyNy4yMy0uNjJabTEwLjg1LTkuNDRMNzkuNjYsMzcuMjlsOCwyNC4wOFpNNDEuNjQsMzUuNWE3LDcsMCwwLDEsMS44NS0zLjgyLDE2LjkzLDE2LjkzLDAsMCwwLDEuODQtMi41OEEyLjQ0LDIuNDQsMCwwLDAsNDUuNCwyN2EyLjY3LDIuNjcsMCwwLDAtMS4xMy0xLjI4LDIuMzQsMi4zNCwwLDAsMC0xLjc0LS4yMWMtLjkuMi0xLjM4LjY0LTEuNDYsMS4zMWE0LjM1LDQuMzUsMCwwLDAsLjM2LDEuNzRsLTMsLjdhNiw2LDAsMCwxLS40Mi0zYy4yNi0xLjUxLDEuNC0yLjQ3LDMuNC0yLjkxYTYuNjIsNi42MiwwLDAsMSw0LjIxLjMxLDUuMjcsNS4yNywwLDAsMSwyLjczLDIuNzEsMy44MiwzLjgyLDAsMCwxLC4yMSwyLjg2LDcuNDYsNy40NiwwLDAsMS0xLjM1LDIuMjhsLS44NSwxLjA4cS0uODEsMS0xLjA4LDEuNDdBMi44MSwyLjgxLDAsMCwwLDQ1LDM1bDYuNjItMS43NCwxLjExLDIuNDVMNDIuMDksMzguNkE2Ljc1LDYuNzUsMCwwLDEsNDEuNjQsMzUuNVpNNTYuNTcsMjEuODFBMTMsMTMsMCwwLDEsNjAsMjYuMzZhMTAuNDgsMTAuNDgsMCwwLDEsMS40Nyw1LjI4Yy0uMSwxLjQtMS4wNiwyLjM2LTIuODcsMi44NWE1LjExLDUuMTEsMCwwLDEtNC43Ni0uODIsMTMsMTMsMCwwLDEtMy41My00LjkzLDkuNzgsOS43OCwwLDAsMS0xLjItNS4yNWMuMi0xLjMsMS4xOS0yLjE0LDMtMi41M0E1LjE4LDUuMTgsMCwwLDEsNTYuNTcsMjEuODFabS0xLjI2LDkuNjZhMi4xMywyLjEzLDAsMCwwLDIuMjUuODEsMS4yOSwxLjI5LDAsMCwwLDEtMS42NiwxMy43MiwxMy43MiwwLDAsMC0xLjMzLTMuNTcsMTUsMTUsMCwwLDAtMi4wNi0zLjM0QTIuMDksMi4wOSwwLDAsMCw1My4wNywyMywxLjI0LDEuMjQsMCwwLDAsNTIsMjQuNDYsMTIuNjcsMTIuNjcsMCwwLDAsNTMuMjMsMjgsMTUuMzMsMTUuMzMsMCwwLDAsNTUuMzEsMzEuNDdaIj48L3BhdGg+PC9zdmc+',+    viewBox: '25 10 50 50'+  };++  // This one doesn't get tinted because it doesn't use currentColor   const svgUriProps: SvgIconProps = {     uri: 'https://upload.wikimedia.org/wikipedia/commons/8/84/Example.svg',-    viewBox: '0 0 100 100',+    viewBox: '0 0 1000 1000'   }; -  const fontProps: FontIconProps = {-    fontFamily: `Font Awesome 5 Free`,-    fontSrcFile: testTtf,-    codepoint: 0xf083,-    fontSize: 32,-  };+  const rasterRainbowSpectrumProps: RasterImageIconProps = { src: testImage };++  // Chess icon by Justicon, licensed under CC BY+  // https://thenounproject.com/search/?q=chess&i=2960386+  const rasterChessProps: RasterImageIconProps = { src: { uri: 'https://static.thenounproject.com/png/2960386-200.png' } };++  const showFontIcons = true;

They can't be toggled within the app, only in source code. But they can be useful for developers working on this part of the code. That being said, I wouldn't have a problem with reverting these.

amgleitman

comment created time in 7 days

Pull request review commentmicrosoft/fluentui-react-native

Add Icon support for iOS

 const testTtf = require('./assets/Font Awesome 5 Free-Solid-900.otf'); import TestSvg from './assets/test.svg';  const icons: React.FunctionComponent<{}> = () => {-  const rasterProps: RasterImageIconProps = { src: testImage };+  const fontCustomFontProps: FontIconProps = {+    fontFamily: 'Font Awesome 5 Free',

It's described here: https://www.w3schools.com/icons/fontawesome5_intro.asp

amgleitman

comment created time in 7 days

Pull request review commentmicrosoft/fluentui-react-native

Add Icon support for iOS

 const testTtf = require('./assets/Font Awesome 5 Free-Solid-900.otf'); import TestSvg from './assets/test.svg';  const icons: React.FunctionComponent<{}> = () => {-  const rasterProps: RasterImageIconProps = { src: testImage };+  const fontCustomFontProps: FontIconProps = {+    fontFamily: 'Font Awesome 5 Free',+    fontSrcFile: testTtf,+    codepoint: 0xf083,+    fontSize: 32,+  };++  const fontBuiltInProps = {+    fontFamily: 'Arial',+    codepoint: 0x2663,+    fontSize: 32,+  };    const svgProps: SvgIconProps = {     src: TestSvg,     viewBox: '0 0 500 500',   }; +  // d20 icon by Lonnie Tapscott, licensed under CC BY, modified to use "currentColor"+  // https://thenounproject.com/search/?q=d20&i=2453700+  const svgD20DataUriProps: SvgIconProps = {+    uri: 'data:image/svg;base64,PHN2ZyBoZWlnaHQ9JzMwMHB4JyB3aWR0aD0nMzAwcHgnIGZpbGw9ImN1cnJlbnRDb2xvciIgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB2aWV3Qm94PSIwIDAgMTAwIDEwMCIgeD0iMHB4IiB5PSIwcHgiPjx0aXRsZT5BcnRib2FyZCA2PC90aXRsZT48cGF0aCBkPSJNOTEuOSw2MS4zN2wtMTQtNDJhMiwyLDAsMCwwLTEuMzMtMS4yOWwtMzctMTFhMiwyLDAsMCwwLTIsLjUxbC0zMSwzMWEyLDIsMCwwLDAtLjQ4LDIuMDZsMTUsNDRBMiwyLDAsMCwwLDIyLjczLDg2bDM2LDVMNTksOTFhMiwyLDAsMCwwLDEuMzEtLjQ5bDMxLTI3QTIsMiwwLDAsMCw5MS45LDYxLjM3Wk0yNC40NCw4MiwzMS42LDQ3LjA1bDMzLjA4LDM0Wk03Ny4yNiwzMS42OSwzMi4zMyw0My42MWw3LjA2LTMxLjc1Wm0tNDcsMTIuMTJMMTEuMTYsMzkuNjYsMzYuODgsMTRaTTY2LjM4LDc5LjkyLDMyLjkxLDQ1LjUzLDc4LjM4LDMzLjQ2bC4xMi4zNS0xMiw0NlpNNzcsMjkuMjlsLTMwLjUyLTE2LDI4LDguMzFaTTEwLjY2LDQxLjZsMTkuMTYsNC4xN0wyMy4xNiw3OC4yNlpNNTguMzcsODYuODksMzUuNSw4My43MmwyNy4yMy0uNjJabTEwLjg1LTkuNDRMNzkuNjYsMzcuMjlsOCwyNC4wOFpNNDEuNjQsMzUuNWE3LDcsMCwwLDEsMS44NS0zLjgyLDE2LjkzLDE2LjkzLDAsMCwwLDEuODQtMi41OEEyLjQ0LDIuNDQsMCwwLDAsNDUuNCwyN2EyLjY3LDIuNjcsMCwwLDAtMS4xMy0xLjI4LDIuMzQsMi4zNCwwLDAsMC0xLjc0LS4yMWMtLjkuMi0xLjM4LjY0LTEuNDYsMS4zMWE0LjM1LDQuMzUsMCwwLDAsLjM2LDEuNzRsLTMsLjdhNiw2LDAsMCwxLS40Mi0zYy4yNi0xLjUxLDEuNC0yLjQ3LDMuNC0yLjkxYTYuNjIsNi42MiwwLDAsMSw0LjIxLjMxLDUuMjcsNS4yNywwLDAsMSwyLjczLDIuNzEsMy44MiwzLjgyLDAsMCwxLC4yMSwyLjg2LDcuNDYsNy40NiwwLDAsMS0xLjM1LDIuMjhsLS44NSwxLjA4cS0uODEsMS0xLjA4LDEuNDdBMi44MSwyLjgxLDAsMCwwLDQ1LDM1bDYuNjItMS43NCwxLjExLDIuNDVMNDIuMDksMzguNkE2Ljc1LDYuNzUsMCwwLDEsNDEuNjQsMzUuNVpNNTYuNTcsMjEuODFBMTMsMTMsMCwwLDEsNjAsMjYuMzZhMTAuNDgsMTAuNDgsMCwwLDEsMS40Nyw1LjI4Yy0uMSwxLjQtMS4wNiwyLjM2LTIuODcsMi44NWE1LjExLDUuMTEsMCwwLDEtNC43Ni0uODIsMTMsMTMsMCwwLDEtMy41My00LjkzLDkuNzgsOS43OCwwLDAsMS0xLjItNS4yNWMuMi0xLjMsMS4xOS0yLjE0LDMtMi41M0E1LjE4LDUuMTgsMCwwLDEsNTYuNTcsMjEuODFabS0xLjI2LDkuNjZhMi4xMywyLjEzLDAsMCwwLDIuMjUuODEsMS4yOSwxLjI5LDAsMCwwLDEtMS42NiwxMy43MiwxMy43MiwwLDAsMC0xLjMzLTMuNTcsMTUsMTUsMCwwLDAtMi4wNi0zLjM0QTIuMDksMi4wOSwwLDAsMCw1My4wNywyMywxLjI0LDEuMjQsMCwwLDAsNTIsMjQuNDYsMTIuNjcsMTIuNjcsMCwwLDAsNTMuMjMsMjgsMTUuMzMsMTUuMzMsMCwwLDAsNTUuMzEsMzEuNDdaIj48L3BhdGg+PC9zdmc+',+    viewBox: '25 10 50 50'+  };++  // This one doesn't get tinted because it doesn't use currentColor   const svgUriProps: SvgIconProps = {     uri: 'https://upload.wikimedia.org/wikipedia/commons/8/84/Example.svg',-    viewBox: '0 0 100 100',+    viewBox: '0 0 1000 1000'   }; -  const fontProps: FontIconProps = {-    fontFamily: `Font Awesome 5 Free`,-    fontSrcFile: testTtf,-    codepoint: 0xf083,-    fontSize: 32,-  };+  const rasterRainbowSpectrumProps: RasterImageIconProps = { src: testImage };++  // Chess icon by Justicon, licensed under CC BY+  // https://thenounproject.com/search/?q=chess&i=2960386+  const rasterChessProps: RasterImageIconProps = { src: { uri: 'https://static.thenounproject.com/png/2960386-200.png' } };++  const showFontIcons = true;

Are these three variables togglable somewhere? If not then I'm not sure I see their purpose

amgleitman

comment created time in 9 days

Pull request review commentmicrosoft/fluentui-react-native

Add Icon support for iOS

 function renderRasterImage(iconProps: IconProps) { }  function fontFamilyFromFontSrcFile(fontSrcFile: string, fontFamily: string): string {-  const asset = assetRegistry.getAssetByID(fontSrcFile);-  return `${fontFamily}#${asset.httpServerLocation}/${asset.name}.${asset.type}`;+  if (Platform.OS == 'windows') {

A comment would be nice in the two places we have this windows platform check to let folks know the plan for macOS/iOS font icon support and why it's not available

amgleitman

comment created time in 9 days

Pull request review commentmicrosoft/fluentui-react-native

Add Icon support for iOS

 const testTtf = require('./assets/Font Awesome 5 Free-Solid-900.otf'); import TestSvg from './assets/test.svg';  const icons: React.FunctionComponent<{}> = () => {-  const rasterProps: RasterImageIconProps = { src: testImage };+  const fontCustomFontProps: FontIconProps = {+    fontFamily: 'Font Awesome 5 Free',

Where does this fontFamily come from? Never heard of that one

amgleitman

comment created time in 9 days

pull request commentmicrosoft/fluentui-react-native

Bump @microsoft/api-extractor from 7.10.4 to 7.12.0

<!--[AutoMerge]--> Hello @msftbot[bot]!

Because this pull request has the AutoMerge :repeat: label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 8 hours. No worries though, I will be back when the time is right! :wink:

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.
dependabot[bot]

comment created time in 9 days

delete branch microsoft/fluentui-react-native

delete branch : dependabot/npm_and_yarn/microsoft/api-extractor-7.11.4

delete time in 9 days

PR closed microsoft/fluentui-react-native

Bump @microsoft/api-extractor from 7.10.4 to 7.11.4 AutoMerge :repeat: dependencies

Bumps @microsoft/api-extractor from 7.10.4 to 7.11.4. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/rushstack/commit/a8cb10a7a6d7cda85b5a288dd49f41bb78bd7071"><code>a8cb10a</code></a> Applying package updates.</li> <li><a href="https://github.com/microsoft/rushstack/commit/c59dbd7320a467ebde79d58208637b7dd94be4dd"><code>c59dbd7</code></a> Deleting change files and updating change logs for package updates.</li> <li><a href="https://github.com/microsoft/rushstack/commit/9034c325d1f4dec0201db3f21a5132bc9eb13105"><code>9034c32</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/microsoft/rushstack/issues/2261">#2261</a> from microsoft/octogonz/packlets2</li> <li><a href="https://github.com/microsoft/rushstack/commit/735ba030dffd8c6a511301f08190614c0e81e3be"><code>735ba03</code></a> Applying package updates.</li> <li><a href="https://github.com/microsoft/rushstack/commit/60f22f0e7cdc46cb2cc321150c91d5b3d53db6a8"><code>60f22f0</code></a> Deleting change files and updating change logs for package updates.</li> <li><a href="https://github.com/microsoft/rushstack/commit/462a37760242f3e64f31aeeeff2e86d6e1706247"><code>462a377</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/microsoft/rushstack/issues/2333">#2333</a> from D4N14L/danade/copy-plugin</li> <li><a href="https://github.com/microsoft/rushstack/commit/c3984b1481950855da339b870b72bebe79c5fa65"><code>c3984b1</code></a> rush change</li> <li><a href="https://github.com/microsoft/rushstack/commit/23a7a514dc23ce3cdf9fd1f682b9a25fead76530"><code>23a7a51</code></a> Add a test project for copy.</li> <li><a href="https://github.com/microsoft/rushstack/commit/88ddbcaf8bcca7d536c3d834bcb4ef4c0e0d4d3d"><code>88ddbca</code></a> Include copyFiles in the heft.json template.</li> <li><a href="https://github.com/microsoft/rushstack/commit/113bbea810bfc6192d8289581f4cf255e9b9555d"><code>113bbea</code></a> Better optmize the file extensions glob</li> <li>Additional commits viewable in <a href="https://github.com/microsoft/rushstack/compare/@microsoft/api-extractor_v7.10.4...@microsoft/api-extractor_v7.11.4">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+29 -29

1 comment

1 changed file

dependabot[bot]

pr closed time in 9 days

pull request commentmicrosoft/fluentui-react-native

Bump @microsoft/api-extractor from 7.10.4 to 7.11.4

Superseded by #563.

dependabot[bot]

comment created time in 9 days

PR opened microsoft/fluentui-react-native

Bump @microsoft/api-extractor from 7.10.4 to 7.12.0

Bumps @microsoft/api-extractor from 7.10.4 to 7.12.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/rushstack/commit/95e1f086b3055f166102e54ee1e8f4f7c53ef756"><code>95e1f08</code></a> Applying package updates.</li> <li><a href="https://github.com/microsoft/rushstack/commit/172709b4c30a3c75cb98d66b245658d912f438ef"><code>172709b</code></a> Deleting change files and updating change logs for package updates.</li> <li><a href="https://github.com/microsoft/rushstack/commit/3d6f94807e87a901a4e7a63e3878220f88831e61"><code>3d6f948</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/microsoft/rushstack/issues/2364">#2364</a> from microsoft/octogonz/ae-more-optional-properties</li> <li><a href="https://github.com/microsoft/rushstack/commit/e33d3873407c09187249af7d8d99db749270e189"><code>e33d387</code></a> rush change</li> <li><a href="https://github.com/microsoft/rushstack/commit/c8c6e1ee3813d96b0a502c8afa21a97ceb89b0f3"><code>c8c6e1e</code></a> Update api-extractor and api-documenter to use the new ApiOptionalMixin API</li> <li><a href="https://github.com/microsoft/rushstack/commit/f4691b572f5ef0d260fa13fe2f569f7a639b83f9"><code>f4691b5</code></a> Introduce an ApiOptionalMixin so that isOptional can be applied to methods as...</li> <li><a href="https://github.com/microsoft/rushstack/commit/e0307a2fcce9060b0b8bc579e89045829f70e854"><code>e0307a2</code></a> Applying package updates.</li> <li><a href="https://github.com/microsoft/rushstack/commit/cae80e2c7175f8beda15509d7668484d0088abef"><code>cae80e2</code></a> Deleting change files and updating change logs for package updates.</li> <li><a href="https://github.com/microsoft/rushstack/commit/b40d49183f81d108aa554aed5bfa8a61ff9b268e"><code>b40d491</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/microsoft/rushstack/issues/2363">#2363</a> from microsoft/octogonz/fix-changelog</li> <li><a href="https://github.com/microsoft/rushstack/commit/f40623b3d35b154b122869b3e07312c5e4564c6f"><code>f40623b</code></a> rush change</li> <li>Additional commits viewable in <a href="https://github.com/microsoft/rushstack/compare/@microsoft/api-extractor_v7.10.4...@microsoft/api-extractor_v7.12.0">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+29 -29

0 comment

1 changed file

pr created time in 9 days

push eventmicrosoft/fluentui-react-native

Samuel Freiberg

commit sha 8d7cf2744ce32ee2fdb36c1de38370ea7fc4a1fb

Replace WinAppDriver 1.2.1 with WinAppDriver 1.1 (#561) * Yarn * Merge * Fixing repo * Update package * Merge * Fixing WinAppDriver version for CI Pipeline * Fixing repo * Moving WinAppDriver change to only Windows jobs

view details

push time in 10 days

PR merged microsoft/fluentui-react-native

Reviewers
Replace WinAppDriver 1.2.1 with WinAppDriver 1.1

Platforms Impacted

  • [ ] iOS
  • [ ] macOS
  • [X] win32 (Office)
  • [X] windows
  • [ ] android

Description of changes

WinAppDriver 1.2 is being deployed across MS hosted agents. appium-windows-driver is tied to a specific version of WinAppDriver, failing if a hash is mismatched. The latest current available package supports 1.2rc.

Uninstall WinAppDriver 1.2.1 if installed and instead install WinAppDriver 1.1 for now

See #6393 for details

Verification

Automated

Pull request checklist

This PR has considered (when applicable):

  • [ ] Automated Tests
  • [ ] Documentation and examples
  • [ ] Keyboard Accessibility
  • [ ] Voiceover
  • [ ] Internationalization and Right-to-left Layouts
+18 -0

3 comments

2 changed files

samuelfreiberg

pr closed time in 10 days

pull request commentmicrosoft/fluentui-react-native

Replace WinAppDriver 1.2.1 with WinAppDriver 1.1

I moved this to only the Windows jobs, thanks!

samuelfreiberg

comment created time in 10 days

pull request commentmicrosoft/fluentui-react-native

Bump eslint-plugin-standard from 4.0.1 to 4.1.0

Hey @tkamireh just fyi that I noticed an auto-merge failure backend here. Depending on whether you expect the PR to be merged presently, the failure might have prevented auto-merge from actually happening. I am continuing to investigate the root cause but just notifying that you may have to merge this one on your own.

dependabot[bot]

comment created time in 10 days

PR opened microsoft/fluentui-react-native

Bump react-native-test-app from 0.2.14 to 0.2.16

Bumps react-native-test-app from 0.2.14 to 0.2.16. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/microsoft/react-native-test-app/releases">react-native-test-app's releases</a>.</em></p> <blockquote> <h2>0.2.16</h2> <h2><a href="https://github.com/microsoft/react-native-test-app/compare/0.2.15...0.2.16">0.2.16</a> (2020-11-09)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>Windows:</strong> Cannot install release build (<a href="https://github-redirect.dependabot.com/microsoft/react-native-test-app/issues/241">#241</a>) (<a href="https://github.com/microsoft/react-native-test-app/commit/e8b5bc110943520a7149065014c37a93f67f39bd">e8b5bc1</a>)</li> </ul> <h2>0.2.15</h2> <h2><a href="https://github.com/microsoft/react-native-test-app/compare/0.2.14...0.2.15">0.2.15</a> (2020-11-04)</h2> <h3>Bug Fixes</h3> <ul> <li><strong>Apple:</strong> Also create an xcscheme to match app name (<a href="https://github-redirect.dependabot.com/microsoft/react-native-test-app/issues/240">#240</a>) (<a href="https://github.com/microsoft/react-native-test-app/commit/0597820e0fd37183b690a2ea47a1dbd583f09894">0597820</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/react-native-test-app/commit/e8b5bc110943520a7149065014c37a93f67f39bd"><code>e8b5bc1</code></a> fix(Windows): Cannot install release build (<a href="https://github-redirect.dependabot.com/microsoft/react-native-test-app/issues/241">#241</a>)</li> <li><a href="https://github.com/microsoft/react-native-test-app/commit/0597820e0fd37183b690a2ea47a1dbd583f09894"><code>0597820</code></a> fix(Apple): Also create an xcscheme to match app name (<a href="https://github-redirect.dependabot.com/microsoft/react-native-test-app/issues/240">#240</a>)</li> <li>See full diff in <a href="https://github.com/microsoft/react-native-test-app/compare/0.2.14...0.2.16">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

</details>

+3 -3

0 comment

1 changed file

pr created time in 10 days

delete branch microsoft/fluentui-react-native

delete branch : dependabot/npm_and_yarn/workspace-tools-0.9.8

delete time in 11 days

pull request commentmicrosoft/fluentui-react-native

Bump workspace-tools from 0.9.4 to 0.9.8

OK, I won't notify you again about this release, but will get in touch when a new version is available.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot]

comment created time in 11 days

pull request commentmicrosoft/fluentui-react-native

Replace WinAppDriver 1.2.1 with WinAppDriver 1.1

It looks like this is being included for multiple platforms right now. This should only be included for Windows PRs.

samuelfreiberg

comment created time in 14 days

PR opened microsoft/fluentui-react-native

Reviewers
Replace WinAppDriver 1.2.1 with WinAppDriver 1.1

Platforms Impacted

  • [ ] iOS
  • [ ] macOS
  • [X] win32 (Office)
  • [X] windows
  • [ ] android

Description of changes

WinAppDriver 1.2 is being deployed across MS hosted agents. appium-windows-driver is tied to a specific version of WinAppDriver, failing if a hash is mismatched. The latest current available package supports 1.2rc.

Uninstall WinAppDriver 1.2.1 if installed and instead install WinAppDriver 1.1 for now

See #6393 for details

Verification

Automated

Pull request checklist

This PR has considered (when applicable):

  • [ ] Automated Tests
  • [ ] Documentation and examples
  • [ ] Keyboard Accessibility
  • [ ] Voiceover
  • [ ] Internationalization and Right-to-left Layouts
+9 -0

0 comment

1 changed file

pr created time in 14 days

pull request commentmicrosoft/fluentui-react-native

Add Icon support for iOS

I'm currently leaving this as a draft PR because there's still an issue with getting the font icon's font to link properly since the test app isn't set up like a brand new React Native project and I'm still relatively new to React Native. It works if we use a system font, but I at least want to make sure the test page looks good on iOS before fully committing this.

amgleitman

comment created time in 15 days

PR opened microsoft/fluentui-react-native

Add Icon support for iOS

Platforms Impacted

  • [x] iOS
  • [ ] macOS
  • [ ] win32 (Office)
  • [ ] windows
  • [ ] android

Description of changes

This adds Icon support for iOS.

The previous work to get Icon up and running on Win32 mostly works as is. One notable thing is that we need to set up SVG support for the iOS test project. This is handled by the first commit in this PR.

Verification

Test page has been activated for iOS.

Pull request checklist

This PR has considered (when applicable):

  • [ ] Automated Tests
  • [ ] Documentation and examples
  • [ ] Keyboard Accessibility
  • [ ] Voiceover
  • [ ] Internationalization and Right-to-left Layouts
+494 -42

0 comment

7 changed files

pr created time in 15 days

push eventmicrosoft/fluentui-react-native

E.J. Layne

commit sha c3631b58d5c37402da97ef4f73f555560a95995c

Update Win32 readme again Replaced "install packages" with "clone and build" in step #1

view details

push time in 16 days

push eventmicrosoft/fluentui-react-native

E.J. Layne

commit sha bc4f3cf01e2dcce2a0adbf60b4cd41175eb41e7e

Update Win32 readme link Updated Getting Started link in Win32 readme to point to "Setup your development environment" which has the relevant instructions.

view details

push time in 16 days

delete branch microsoft/fluentui-react-native

delete branch : dependabot/npm_and_yarn/microsoft/api-extractor-7.11.2

delete time in 16 days

more