profile
viewpoint
tjcsl Fairfax, VA https://tjhsst.edu TJHSST Computer Systems Lab

push eventtjcsl/hocoapp

Theo Ouzhinski

commit sha de7ae843baff6e9ccb64bea136b6f3e0d3623794

OK: Update requirements

view details

Theo Ouzhinski

commit sha 9df86188f4cceb935c2bdee4f954759aa044cafa

Update hoco admins

view details

Theo Ouzhinski

commit sha afdfefbceee93db049a504d3dfa0a5d88191f906

Force zero total to zero

view details

Theo Ouzhinski

commit sha b03e8aa2b6729b62373e24e65ce88a9d88fe34e9

Updates for 2019

view details

Theo Ouzhinski

commit sha c4f2699d5986166f0e525fd89811bed6f69243f2

Update for class of 2019

view details

push time in 19 hours

push eventtjcsl/ion

Travis

commit sha 6d23f138639cc5f44ce4cc2f1de67d44d6ddbfbd

Travis build 4848

view details

push time in a day

push eventtjcsl/ion

Theo Ouzhinski

commit sha 5ab46ab7191f7d278d5838caa5ffbf5c1651f0a2

chore: makemigrations for Course & Section

view details

push time in a day

push eventtjcsl/ion

Theo Ouzhinski

commit sha 79b4ee7e3a0b727e1498a99c902f086121cedde0

fix(fab): restart ion supervisor service on restart

view details

Theo Ouzhinski

commit sha 5b39f7a12e429626890d93a364bdb0c7520a6d5c

fix(users): register models

view details

Theo Ouzhinski

commit sha f7e74821e2ec812f0f2c2410013517600c18b4dc

style: reformat users tests

view details

Theo Ouzhinski

commit sha c39adff4cc5e7725040bde9d585c7c29f9e8f0c9

chore(users): clean up commented fields in form

view details

Theo Ouzhinski

commit sha ae47e0e122e3d667eba57b2927ee968b7f46aadc

refactor(users): use get_object_or_404

view details

Theo Ouzhinski

commit sha 774056d044c3d74fe2c372b93cce016ed4ed6982

refactor(users): use more get_object_or_404

view details

Theo Ouzhinski

commit sha 40456fb6fd342ec85122a6d503733e995e27677b

refactor(users): refactor has_been_nominated logic

view details

Theo Ouzhinski

commit sha eedbe6f62c4624013c4d5e4196ae5d0be4ea02d8

refactor(users): refactor courses CSS

view details

Theo Ouzhinski

commit sha 1716fb1e1f91a8ba1ee523298fbadaf86235ee75

style: format a little of users/class.html

view details

Theo Ouzhinski

commit sha bf6304279c94f733d7791f8887cbbfa47c6f6d87

fix(users): rename course_section_view -> section_view

view details

Theo Ouzhinski

commit sha d651d1c5bf1223186c33927ad4b05e28159cc59a

fix(users): add ordering to Course & Section

view details

Theo Ouzhinski

commit sha 2c1ffd55b7dc9eaf170f5cf1dda1030f7179f739

test: add more users tests

view details

Theo Ouzhinski

commit sha a36f39f14a1782b15b74304cae50afe72ad8977e

test(users): fix section_info tests

view details

Theo Ouzhinski

commit sha 476726c59cc49259bf2c040a7ea5fcac10cd947b

test(users): use right attribute

view details

Theo Ouzhinski

commit sha 04dbbc14ed908dc85bc56f67f8d79f047103f280

chore(users): remove unused serializers

view details

Theo Ouzhinski

commit sha 410a66538a47d472d07c4d5077674169afe780a1

refactor(users): reduce duplication

view details

Theo Ouzhinski

commit sha 5e9eaf3e0f03b02e2c493fa44ada5601df8528b4

fix(eighth): deny unauthorized signup API request

view details

Theo Ouzhinski

commit sha 2f941adcd53468307c3621599222ee807c4d7961

refactor(users): reduce unnecessary line count

view details

Theo Ouzhinski

commit sha 6670b8aad8a4657784ca83791d70bf0b047922a8

test(users): add more API tests

view details

Theo Ouzhinski

commit sha 810c598ccb22670753ec54271365f25ac8913380

test: generalize logins for tests

view details

push time in a day

push eventtjcsl/ion

Theo Ouzhinski

commit sha 1581952179377ff1c40973eac433d1bc0dbcb703

fix(eighth): reintroduce Grade.names

view details

Theo Ouzhinski

commit sha f6ecc3b3934012cfc32999521b0ed8015e7e9acb

refactor(tests): eliminate unnecessary function

view details

Theo Ouzhinski

commit sha 3725033d8905ee3924dcfab1c9ca001c6d82839b

style: add space around comparison

view details

Theo Ouzhinski

commit sha 688ed64c547a3a82f99015a39e9494ed6237d389

chore(pylint): disable protected-access

view details

push time in a day

push eventtjcsl/ion

Theo Ouzhinski

commit sha 04dbbc14ed908dc85bc56f67f8d79f047103f280

chore(users): remove unused serializers

view details

Theo Ouzhinski

commit sha 410a66538a47d472d07c4d5077674169afe780a1

refactor(users): reduce duplication

view details

Theo Ouzhinski

commit sha 5e9eaf3e0f03b02e2c493fa44ada5601df8528b4

fix(eighth): deny unauthorized signup API request

view details

Theo Ouzhinski

commit sha 2f941adcd53468307c3621599222ee807c4d7961

refactor(users): reduce unnecessary line count

view details

Theo Ouzhinski

commit sha 6670b8aad8a4657784ca83791d70bf0b047922a8

test(users): add more API tests

view details

Theo Ouzhinski

commit sha 810c598ccb22670753ec54271365f25ac8913380

test: generalize logins for tests

view details

Theo Ouzhinski

commit sha cda19c7be7465adce2d2c8a9ce723d9bcf74a79b

refactor: be more explicit

view details

Theo Ouzhinski

commit sha 72e246ad98c92f07969650f3f89ceeb31e9a1eee

test(users): add test_get_profile_picture_api

view details

Theo Ouzhinski

commit sha b384f1854b46e1d28393c30ceb20390f770358b8

fix(users): fix spelling in view name

view details

push time in a day

push eventtjcsl/rustbot

Peter Foley

commit sha c1e70cd18e43ec8d2541df5b302a58aee499c3b4

update deps

view details

push time in 3 days

push eventtjcsl/ion

Travis

commit sha e1393fdacd1c4e13acec1957168ec0521962e173

Travis build 4845

view details

push time in 5 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 476726c59cc49259bf2c040a7ea5fcac10cd947b

test(users): use right attribute

view details

push time in 5 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 79b4ee7e3a0b727e1498a99c902f086121cedde0

fix(fab): restart ion supervisor service on restart

view details

Theo Ouzhinski

commit sha 5b39f7a12e429626890d93a364bdb0c7520a6d5c

fix(users): register models

view details

Theo Ouzhinski

commit sha f7e74821e2ec812f0f2c2410013517600c18b4dc

style: reformat users tests

view details

Theo Ouzhinski

commit sha c39adff4cc5e7725040bde9d585c7c29f9e8f0c9

chore(users): clean up commented fields in form

view details

Theo Ouzhinski

commit sha ae47e0e122e3d667eba57b2927ee968b7f46aadc

refactor(users): use get_object_or_404

view details

Theo Ouzhinski

commit sha 774056d044c3d74fe2c372b93cce016ed4ed6982

refactor(users): use more get_object_or_404

view details

Theo Ouzhinski

commit sha 40456fb6fd342ec85122a6d503733e995e27677b

refactor(users): refactor has_been_nominated logic

view details

Theo Ouzhinski

commit sha eedbe6f62c4624013c4d5e4196ae5d0be4ea02d8

refactor(users): refactor courses CSS

view details

Theo Ouzhinski

commit sha 1716fb1e1f91a8ba1ee523298fbadaf86235ee75

style: format a little of users/class.html

view details

Theo Ouzhinski

commit sha bf6304279c94f733d7791f8887cbbfa47c6f6d87

fix(users): rename course_section_view -> section_view

view details

Theo Ouzhinski

commit sha d651d1c5bf1223186c33927ad4b05e28159cc59a

fix(users): add ordering to Course & Section

view details

Theo Ouzhinski

commit sha 2c1ffd55b7dc9eaf170f5cf1dda1030f7179f739

test: add more users tests

view details

Theo Ouzhinski

commit sha a36f39f14a1782b15b74304cae50afe72ad8977e

test(users): fix section_info tests

view details

push time in 5 days

fork al2me6/ion

TJ Intranet 3 (Ion)

https://ion.tjhsst.edu

fork in 5 days

push eventtjcsl/ion

Travis

commit sha 6aea215af85b76e368723de37fcbfad34ee7f188

Travis build 4842

view details

push time in 6 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha ae579ff2d43f07d5b4b6e47a6168ecb21dae5e5c

test: don't set user attribute by default

view details

Theo Ouzhinski

commit sha 9797afacfbcd6f7c7fc9dce55b014d7181fecddf

chore: remove old template

view details

Theo Ouzhinski

commit sha ca0a082e89f63ce8d4e8ac92d86e59229cafaaa1

chore: remove welcome_done view

view details

Theo Ouzhinski

commit sha 1986b6114546817468f143cf78406a2978924cf1

chore: sources

view details

Theo Ouzhinski

commit sha 991794d9f5dc8bd8fe442af468cb6a4540cedea2

style: blackify welcome/views.py

view details

Theo Ouzhinski

commit sha bf99f988da8e27782d55ac9b9256e91d95a91621

fix(welcome): readd welcome_done

view details

Theo Ouzhinski

commit sha 4f2578cc2edd8af5295e4db27102cd0f3d6ae225

style: reformat welcome templates

view details

Theo Ouzhinski

commit sha 7ca71277deff301c7a5909970f42ca4abf3759c4

fix(welcome): fix welcome templates

view details

Theo Ouzhinski

commit sha 20e7e11c957a2e69cbcbf5dcdc489dea198329d9

test: add test_welcome_done

view details

Theo Ouzhinski

commit sha f6ee3d854f932fd8e666cf8acf1c9a728bcf04aa

style: blackify users

view details

Theo Ouzhinski

commit sha d4c1f7e062e409a9c46a9cb9ebd592e8e39622d2

chore(users): remove obsolete management command

view details

Theo Ouzhinski

commit sha 5be1458d594002d95a03823eb56e6fa85b491387

chore: remove obsolete management command

view details

Theo Ouzhinski

commit sha 6e89f910ba92ebbd53ab92c11312927ccf438c38

build: fix sources

view details

Theo Ouzhinski

commit sha b5487696cae3943dbb09c8744d4badafa760e3a5

tests: fix pylint && check redirect of welcome_done

view details

Theo Ouzhinski

commit sha 7f087718e962886bbecfe5ee6832e23df58f4aed

chore(pylint): disable bad-continuation check

view details

Theo Ouzhinski

commit sha 8237dd41f81f92c1b1915a19db52403cb5cb06aa

tests: fix done_welcome tests

view details

Theo Ouzhinski

commit sha c59d4b9b4da41201b0b6ea65d633eeed5552713f

chore: rename class_urls.py to courses_urls.py

view details

Theo Ouzhinski

commit sha 9620a24c17aa7fa432c4906f36901ffeff22b5f2

fix(sentry): enable send_default_pii

view details

Theo Ouzhinski

commit sha cd64987e8b764cfdc0154880c7d9d99d19235538

docs(users): update users docstrings/comments

view details

Theo Ouzhinski

commit sha 66cef2c1e7f8625abd7d185ad542e17eda242209

tests: add more users tests

view details

push time in 6 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 5e9e001d4c2649c941d88057325db31b4d0b5ba2

docs: update sourcedocs

view details

push time in 6 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha c59d4b9b4da41201b0b6ea65d633eeed5552713f

chore: rename class_urls.py to courses_urls.py

view details

Theo Ouzhinski

commit sha 9620a24c17aa7fa432c4906f36901ffeff22b5f2

fix(sentry): enable send_default_pii

view details

Theo Ouzhinski

commit sha cd64987e8b764cfdc0154880c7d9d99d19235538

docs(users): update users docstrings/comments

view details

Theo Ouzhinski

commit sha 66cef2c1e7f8625abd7d185ad542e17eda242209

tests: add more users tests

view details

push time in 6 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha f6ee3d854f932fd8e666cf8acf1c9a728bcf04aa

style: blackify users

view details

Theo Ouzhinski

commit sha d4c1f7e062e409a9c46a9cb9ebd592e8e39622d2

chore(users): remove obsolete management command

view details

Theo Ouzhinski

commit sha 5be1458d594002d95a03823eb56e6fa85b491387

chore: remove obsolete management command

view details

Theo Ouzhinski

commit sha 6e89f910ba92ebbd53ab92c11312927ccf438c38

build: fix sources

view details

Theo Ouzhinski

commit sha b5487696cae3943dbb09c8744d4badafa760e3a5

tests: fix pylint && check redirect of welcome_done

view details

Theo Ouzhinski

commit sha 7f087718e962886bbecfe5ee6832e23df58f4aed

chore(pylint): disable bad-continuation check

view details

Theo Ouzhinski

commit sha 8237dd41f81f92c1b1915a19db52403cb5cb06aa

tests: fix done_welcome tests

view details

push time in 6 days

push eventtjcsl/gitbook

Theo Ouzhinski

commit sha 4960b6330fa0e5552c0fef186b3771f0bc5d6929

GitBook: [master] 70 pages modified

view details

push time in 7 days

push eventtjcsl/director

Theo Ouzhinski

commit sha f6b0242e52fadacd61b736ffa84ceebebb5334be

Add locale settings

view details

push time in 7 days

push eventtjcsl/director

Theo Ouzhinski

commit sha f6b0242e52fadacd61b736ffa84ceebebb5334be

Add locale settings

view details

push time in 7 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha ae579ff2d43f07d5b4b6e47a6168ecb21dae5e5c

test: don't set user attribute by default

view details

Theo Ouzhinski

commit sha 9797afacfbcd6f7c7fc9dce55b014d7181fecddf

chore: remove old template

view details

Theo Ouzhinski

commit sha ca0a082e89f63ce8d4e8ac92d86e59229cafaaa1

chore: remove welcome_done view

view details

Theo Ouzhinski

commit sha 1986b6114546817468f143cf78406a2978924cf1

chore: sources

view details

Theo Ouzhinski

commit sha 991794d9f5dc8bd8fe442af468cb6a4540cedea2

style: blackify welcome/views.py

view details

Theo Ouzhinski

commit sha bf99f988da8e27782d55ac9b9256e91d95a91621

fix(welcome): readd welcome_done

view details

Theo Ouzhinski

commit sha 4f2578cc2edd8af5295e4db27102cd0f3d6ae225

style: reformat welcome templates

view details

Theo Ouzhinski

commit sha 7ca71277deff301c7a5909970f42ca4abf3759c4

fix(welcome): fix welcome templates

view details

Theo Ouzhinski

commit sha 20e7e11c957a2e69cbcbf5dcdc489dea198329d9

test: add test_welcome_done

view details

push time in 7 days

push eventtjcsl/ion

Travis

commit sha 00f570bd1a5f50fa0394345a09181c7e538ba43b

Travis build 4837

view details

push time in 8 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha ea9481d6af050be2431b919dbcba3580b9f3f101

fix(events): fix/cleanup templates for events

view details

Theo Ouzhinski

commit sha ec55df0f8aa0341f8c93de48e440491c0e664bf7

style: blackify events/forms.py

view details

Theo Ouzhinski

commit sha ab4ef7cf2eda290e88885e6c9beddfba55d4af8a

fix(events): fix events views Also update docstrings && perform cleanup

view details

Theo Ouzhinski

commit sha 742af2f45ac0332bcf2db0173b800c78bdcadefe

tests: update events tests

view details

Theo Ouzhinski

commit sha 2da83f4bd4923800c63d3e6bbc18c33d4a8c52a0

build: fix build

view details

Theo Ouzhinski

commit sha 4f9ac74a87128ed6b6473bb97fce4a5cba8e6e70

chore: remove unused settings AUTHUSER_PASSWORD && ldap_simple_bind_password

view details

Theo Ouzhinski

commit sha 15f477221d62877a0badc174d1ea18ad91b69cc3

build: remove flake8 check since `pylint` basically duplicates the work

view details

Theo Ouzhinski

commit sha 4696c55efd9cc8647340e5e3c28f8a3d4db2bdfb

build: remove alabaster It is unused and already included in core Sphinx

view details

Theo Ouzhinski

commit sha aba8e3c67c557e1b264e467d49ac391facb7f7a4

build(deps): remove cffi already required by argon-cffi

view details

Theo Ouzhinski

commit sha 06a2d085bd8a51d55a6657ff52210e2570ac4981

chore: allow dynamic configuration of maintenance mode

view details

Theo Ouzhinski

commit sha 49240e3fc99a976da59869f2933db699e9ac2442

build(deps): update django-maintenance-mode

view details

Theo Ouzhinski

commit sha 676fa514e661e286f95a5099ab57646a13a73370

chore: add info on packages from which apps come from

view details

Theo Ouzhinski

commit sha d1c9f8a326b2a66360fcd92cda7cbbd9bc0cab14

build(deps): upgrade ipython

view details

Theo Ouzhinski

commit sha 002561dd4d945c4d9807c2d28e9fb014b953b0c9

build(deps): remove nose

view details

Theo Ouzhinski

commit sha 246853fbcb2741ab9f7c4b52ee584adab791207b

build(deps): remove olefile not required

view details

Theo Ouzhinski

commit sha c3b9953ba53392a62a05c7c4137487589e8662f6

build(deps): remove paramiko already required by pysftp

view details

Theo Ouzhinski

commit sha 09321c07ede952b690fcf868ca99073975373655

build(deps): remove redis since we don't interact with redis directly

view details

Theo Ouzhinski

commit sha 8316b118a805d2dac4f84a7de3492a44a3dfa663

build(deps): upgrade sphinx

view details

Theo Ouzhinski

commit sha eeb3eea5c3f4de2074b1b61bbdbf8035311de122

build(deps): upgrade sphinx-bootstrap-theme

view details

Theo Ouzhinski

commit sha 74432153e19a74cba0e31f13e969814b7569b0cf

build(deps): remove urllib3 && werkzeug already required

view details

push time in 8 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 66cfce1731076ef0da8533bcbb9eea34a6643c0a

chore: sources

view details

Theo Ouzhinski

commit sha 33c97b545a6c30cd280489c21638db8c5c3f02aa

chore: update gitignore

view details

push time in 8 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 15f477221d62877a0badc174d1ea18ad91b69cc3

build: remove flake8 check since `pylint` basically duplicates the work

view details

Theo Ouzhinski

commit sha 4696c55efd9cc8647340e5e3c28f8a3d4db2bdfb

build: remove alabaster It is unused and already included in core Sphinx

view details

Theo Ouzhinski

commit sha aba8e3c67c557e1b264e467d49ac391facb7f7a4

build(deps): remove cffi already required by argon-cffi

view details

Theo Ouzhinski

commit sha 06a2d085bd8a51d55a6657ff52210e2570ac4981

chore: allow dynamic configuration of maintenance mode

view details

Theo Ouzhinski

commit sha 49240e3fc99a976da59869f2933db699e9ac2442

build(deps): update django-maintenance-mode

view details

Theo Ouzhinski

commit sha 676fa514e661e286f95a5099ab57646a13a73370

chore: add info on packages from which apps come from

view details

Theo Ouzhinski

commit sha d1c9f8a326b2a66360fcd92cda7cbbd9bc0cab14

build(deps): upgrade ipython

view details

Theo Ouzhinski

commit sha 002561dd4d945c4d9807c2d28e9fb014b953b0c9

build(deps): remove nose

view details

Theo Ouzhinski

commit sha 246853fbcb2741ab9f7c4b52ee584adab791207b

build(deps): remove olefile not required

view details

Theo Ouzhinski

commit sha c3b9953ba53392a62a05c7c4137487589e8662f6

build(deps): remove paramiko already required by pysftp

view details

Theo Ouzhinski

commit sha 09321c07ede952b690fcf868ca99073975373655

build(deps): remove redis since we don't interact with redis directly

view details

Theo Ouzhinski

commit sha 8316b118a805d2dac4f84a7de3492a44a3dfa663

build(deps): upgrade sphinx

view details

Theo Ouzhinski

commit sha eeb3eea5c3f4de2074b1b61bbdbf8035311de122

build(deps): upgrade sphinx-bootstrap-theme

view details

Theo Ouzhinski

commit sha 74432153e19a74cba0e31f13e969814b7569b0cf

build(deps): remove urllib3 && werkzeug already required

view details

Theo Ouzhinski

commit sha a1534772323c4f5d3766332063d159a66368926b

docs: update sourcedocs with new sphinx

view details

Theo Ouzhinski

commit sha 1c9b54b06dc4b6692d5311f8a2bc9fb7f7c3a8b9

docs: add docs on Ion requirements

view details

Theo Ouzhinski

commit sha 0c2ba0c48dd8569e61d967efa140c71de6b2d4a0

docs: move requirements documentation and edit index

view details

push time in 8 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 4f9ac74a87128ed6b6473bb97fce4a5cba8e6e70

chore: remove unused settings AUTHUSER_PASSWORD && ldap_simple_bind_password

view details

push time in 8 days

delete branch tjcsl/ion

delete branch : docs

delete time in 9 days

delete branch tjcsl/ion

delete branch : events

delete time in 9 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha ea9481d6af050be2431b919dbcba3580b9f3f101

fix(events): fix/cleanup templates for events

view details

Theo Ouzhinski

commit sha ec55df0f8aa0341f8c93de48e440491c0e664bf7

style: blackify events/forms.py

view details

Theo Ouzhinski

commit sha ab4ef7cf2eda290e88885e6c9beddfba55d4af8a

fix(events): fix events views Also update docstrings && perform cleanup

view details

Theo Ouzhinski

commit sha 742af2f45ac0332bcf2db0173b800c78bdcadefe

tests: update events tests

view details

Theo Ouzhinski

commit sha 2da83f4bd4923800c63d3e6bbc18c33d4a8c52a0

build: fix build

view details

push time in 10 days

PR merged tjcsl/ion

Update events app
+248 -119

1 comment

7 changed files

theo-o

pr closed time in 10 days

Pull request review commenttjcsl/ion

Update events app

 def events_view(request):      Shows a list of events occurring in the next week, month, and     future.-     """      is_events_admin = request.user.has_admin_permission("events")      if request.method == "POST":         if "approve" in request.POST and is_events_admin:-            event_id = request.POST.get("approve")-            event = get_object_or_404(Event, id=event_id)-            event.rejected = False-            event.approved = True-            event.approved_by = request.user-            event.save()-            messages.success(request, "Approved event {}".format(event))+            event_id = get_id(request.POST.get("approve"))+            if event_id:+                event = get_object_or_404(Event, id=event_id)+                event.rejected = False+                event.approved = True+                event.approved_by = request.user+                event.save()+                messages.success(request, "Approved event {}".format(event))+            else:+                raise http.Http404          if "reject" in request.POST and is_events_admin:-            event_id = request.POST.get("reject")-            event = get_object_or_404(Event, id=event_id)-            event.approved = False-            event.rejected = True-            event.rejected_by = request.user-            event.save()-            messages.success(request, "Rejected event {}".format(event))+            event_id = get_id(request.POST.get("reject"))+            if event_id:

Same as above.

            if event_id is not None:
theo-o

comment created time in 11 days

Pull request review commenttjcsl/ion

Update events app

 def events_view(request):      Shows a list of events occurring in the next week, month, and     future.-     """      is_events_admin = request.user.has_admin_permission("events")      if request.method == "POST":         if "approve" in request.POST and is_events_admin:-            event_id = request.POST.get("approve")-            event = get_object_or_404(Event, id=event_id)-            event.rejected = False-            event.approved = True-            event.approved_by = request.user-            event.save()-            messages.success(request, "Approved event {}".format(event))+            event_id = get_id(request.POST.get("approve"))+            if event_id:

Nitpicking here, but I would do:

            if event_id is not None:

Since get_id() will always either return an int or None. I know that ids should never be 0, but this feels a little better.

theo-o

comment created time in 11 days

pull request commenttjcsl/ion

Update events app

Coverage Status

Coverage increased (+1.03%) to 48.067% when pulling ec2c6dc6d3dcbf59e598c1e52d616ff2995fbbd3 on events into 0b1452ab0f810a9cb29cbf63bae94fa697e6d993 on dev.

theo-o

comment created time in 11 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha ec2c6dc6d3dcbf59e598c1e52d616ff2995fbbd3

build: fix build

view details

push time in 11 days

PR opened tjcsl/ion

Reviewers
Update events app
+249 -119

0 comment

7 changed files

pr created time in 11 days

create barnchtjcsl/ion

branch : events

created branch time in 11 days

push eventtjcsl/ion

Travis

commit sha 598da87bd7e60afddf5163e659bcea6ea272d7ce

Travis build 4828

view details

push time in 12 days

push eventtjcsl/ion

anonymoose2

commit sha eee16daf9fb43a6fb2a66daecbb94d8422623593

chore: remove unused activity ID changing code Changing activity IDs would be more trouble than it's worth

view details

anonymoose2

commit sha 35b90622ee4fc845f94cc3a7053a571489b99de5

tests: add eighth pass tests

view details

anonymoose2

commit sha f2809e4f33ce9b24cede7edaaaccf657a15e8a17

tests: add more eighth tests

view details

Theo Ouzhinski

commit sha 011e8517e2bee6934ae7839849f9f2859519f218

style: blackify eighth tests

view details

anonymoose2

commit sha f6a64ff28a35b4da078b7d6d68e9811938c90ada

fix: confirm admin actions with potentially undesirable consequences Many such actions already require confirmation, but there are some that do not. This PR fixes the two that I was able to find.

view details

anonymoose2

commit sha 9994fcb864da6ec529ac477e073ef050c7be393a

style: switch all XHTML-style empty tags to the HTML style

view details

Theo Ouzhinski

commit sha 8b7036a5b8ec96856f004210e9ba89866e8e7b7e

chore: eliminate unnecessary warnings

view details

anonymoose2

commit sha dcb334458d9f99320884425b8fd7d9d9e494756b

fix: fix the build during July Also took this opportunity to set explicit 00:00:00 times for the datetimes return by get_date_range_this_year()

view details

Theo Ouzhinski

commit sha a823c61c2c74c82993358e86b07cc55934a40152

style: blackify utils/date.py

view details

anonymoose2

commit sha 7abdd016c0cb3c7626bcb37f74b5a3f5d8cd0a7c

chore: disable more pylint checks We want Pylint to find bugs, not complain that a function is too long. Also removed some now-unnecessary comments disabling Pylint checks.

view details

anonymoose2

commit sha 7b9452f153cfec8642da4e3287986d0fcc04e321

chore: remove ineffectual checks from Pylint 'disable' list Some are Python 2-specific; some don't actually exist

view details

anonymoose2

commit sha c496fc5e2a9e4026f95d98cb004576b37fdb38fd

chore: ignore another Pylint error

view details

anonymoose2

commit sha 45982cd537dcbc45d5d50d1990f1b0d68492b754

chore: remove unused 'generate_fake_data' user management command

view details

anonymoose2

commit sha 23e215953b4840ca62f694457ede6dd2ccc6dc96

chore(pylint): disable full reports

view details

anonymoose2

commit sha 9b63ce8b1c62be6d29540e1eaa04290b6f36da2c

chore(pylint): use long check names for disable comments

view details

anonymoose2

commit sha 603e87a0b0c543f0f34bb8734f286a7f383c80d1

chore(pylint): remove unnecessary pylint enable

view details

anonymoose2

commit sha 2dd0b31c6a202199a4f036664902f36f677966b7

chore: remove old commented-out code from eighth models

view details

anonymoose2

commit sha 37f33dda5d6e61d5b67da5db4e48fba4e6def0e8

ci(travis): add Pylint check to Travis build Some checks had to be disabled to get it to pass; they indicate items to be worked on

view details

anonymoose2

commit sha fc9add3eecac2e3eb19f53e3fb996319c997614f

build(deps): bump django from 1.11.21 to 1.11.22

view details

Theo Ouzhinski

commit sha 0b1452ab0f810a9cb29cbf63bae94fa697e6d993

build: add dependabot config

view details

push time in 12 days

push eventtjcsl/ion

push time in 12 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 0b1452ab0f810a9cb29cbf63bae94fa697e6d993

build: add dependabot config

view details

push time in 12 days

push eventtjcsl/ion

Travis

commit sha fb12053e335ce3e1f5ba60fc85ab26e6f6635772

Travis build 4825

view details

push time in 12 days

push eventtjcsl/ion

anonymoose2

commit sha 73f63e127719ff221bbd859027e75e9c5861167b

style: switch all XHTML-style empty tags to the HTML style

view details

Theo Ouzhinski

commit sha 2c9b03d4af7f279609675ee8af513dc316548cd6

chore: eliminate unnecessary warnings

view details

anonymoose2

commit sha 41bd2c3a2663d08354d91279261279ff43258961

fix: fix the build during July Also took this opportunity to set explicit 00:00:00 times for the datetimes return by get_date_range_this_year()

view details

Theo Ouzhinski

commit sha c4ee199488933028eba9c7edc569552e1ca3e34c

style: blackify utils/date.py

view details

anonymoose2

commit sha 864704472bd01529af0bffdd72b24a619a0448ab

chore: disable more pylint checks We want Pylint to find bugs, not complain that a function is too long. Also removed some now-unnecessary comments disabling Pylint checks.

view details

anonymoose2

commit sha d15b1a148eb123710baa37436dc596bd0b53bb4b

chore: remove ineffectual checks from Pylint 'disable' list Some are Python 2-specific; some don't actually exist

view details

anonymoose2

commit sha c80a8eec20da89c1ea151a6b5e3899c2f2aa695f

chore: ignore another Pylint error

view details

anonymoose2

commit sha e6f3bad0d3e3d7ee2bcd447f2c11a3c6b9f4f8d0

chore: remove unused 'generate_fake_data' user management command

view details

anonymoose2

commit sha af745788852e413b89b4e8eacb1c605c4b16bea8

chore(pylint): disable full reports

view details

anonymoose2

commit sha 48aa76ca47492b54d5c061381857716af347ba8c

chore(pylint): use long check names for disable comments

view details

anonymoose2

commit sha b01886ed00441e90dddcf4fb1ee8f888c0c114bf

chore(pylint): remove unnecessary pylint enable

view details

anonymoose2

commit sha a4a3f7c610c1399c99b585ed3e100ff2b1f8d5bf

chore: remove old commented-out code from eighth models

view details

anonymoose2

commit sha f34a474c95911ea0135768aeb822d0b97fe08454

ci(travis): add Pylint check to Travis build Some checks had to be disabled to get it to pass; they indicate items to be worked on

view details

anonymoose2

commit sha 217102bfc70f7551711e75558a4587985864f75a

build(deps): bump django from 1.11.21 to 1.11.22

view details

push time in 12 days

PR merged tjcsl/ion

Dev
+1012 -1178

0 comment

181 changed files

theo-o

pr closed time in 12 days

PR opened tjcsl/ion

Reviewers
Dev
+1012 -1178

0 comment

181 changed files

pr created time in 12 days

delete branch tjcsl/ion

delete branch : dependabot/pip/django-1.11.22

delete time in 12 days

delete branch tjcsl/ion

delete branch : dependabot/pip/docs/django-1.11.22

delete time in 12 days

pull request commenttjcsl/ion

build(deps): bump django from 1.11.21 to 1.11.22

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot]

comment created time in 12 days

PR closed tjcsl/ion

Reviewers
build(deps): bump django from 1.11.21 to 1.11.22 dependencies

Bumps django from 1.11.21 to 1.11.22. <details> <summary>Commits</summary>

  • 480380c [1.11.x] Bumped version for 1.11.22 release.
  • 32124fc [1.11.x] Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_S...
  • 58553bb [1.11.x] Added stub release notes for security releases.
  • bc5febe [1.11.x] Fixed GeoIPTest.test04_city() failure with the latest GeoIP2 database.
  • 7906968 [1.11.x] Bumped minimum ESLint version to 4.18.2.
  • 341f444 [1.11.x] Added CVE-2019-12308 to the security release archive.
  • 9f8bed5 [1.11.x] Added CVE-2019-11358 to the security release archive.
  • a07ce0e [1.11.x] Fixed typo in 1.11.21 release notes.
  • 2f67c8e [1.11.x] Post-release version bump.
  • See full diff in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+3 -3

0 comment

3 changed files

dependabot[bot]

pr closed time in 12 days

pull request commenttjcsl/ion

build(deps): bump django from 1.11.21 to 1.11.22 in /docs

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot]

comment created time in 12 days

PR closed tjcsl/ion

Reviewers
build(deps): bump django from 1.11.21 to 1.11.22 in /docs dependencies

Bumps django from 1.11.21 to 1.11.22. <details> <summary>Commits</summary>

  • 480380c [1.11.x] Bumped version for 1.11.22 release.
  • 32124fc [1.11.x] Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_S...
  • 58553bb [1.11.x] Added stub release notes for security releases.
  • bc5febe [1.11.x] Fixed GeoIPTest.test04_city() failure with the latest GeoIP2 database.
  • 7906968 [1.11.x] Bumped minimum ESLint version to 4.18.2.
  • 341f444 [1.11.x] Added CVE-2019-12308 to the security release archive.
  • 9f8bed5 [1.11.x] Added CVE-2019-11358 to the security release archive.
  • a07ce0e [1.11.x] Fixed typo in 1.11.21 release notes.
  • 2f67c8e [1.11.x] Post-release version bump.
  • See full diff in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+1 -1

0 comment

1 changed file

dependabot[bot]

pr closed time in 12 days

push eventtjcsl/ion

anonymoose2

commit sha fc9add3eecac2e3eb19f53e3fb996319c997614f

build(deps): bump django from 1.11.21 to 1.11.22

view details

push time in 12 days

PR merged tjcsl/ion

Reviewers
Bump django from 1.11.21 to 1.11.22

#654 and #655 each only change one file and are currently broken.

+3 -3

1 comment

3 changed files

anonymoose2

pr closed time in 12 days

pull request commenttjcsl/ion

Bump django from 1.11.21 to 1.11.22

Coverage Status

Coverage remained the same at 47.034% when pulling 85d9506d630515e954334fc3c09720e867e5db32 on anonymoose2:safe-code into 37f33dda5d6e61d5b67da5db4e48fba4e6def0e8 on tjcsl:dev.

anonymoose2

comment created time in 12 days

PR opened tjcsl/ion

Reviewers
Bump django from 1.11.21 to 1.11.22

#654 and #655 each only change one file and are currently broken.

+3 -3

0 comment

3 changed files

pr created time in 12 days

push eventtjcsl/website

anonymoose2

commit sha 92b823a28b069f33c554c8918cb708da90920107

Require Django 2.2.3 or later; update other dependencies

view details

push time in 12 days

PR opened tjcsl/ion

Reviewers
build(deps): bump django from 1.11.21 to 1.11.22 in /docs

Bumps django from 1.11.21 to 1.11.22. <details> <summary>Commits</summary>

  • 480380c [1.11.x] Bumped version for 1.11.22 release.
  • 32124fc [1.11.x] Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_S...
  • 58553bb [1.11.x] Added stub release notes for security releases.
  • bc5febe [1.11.x] Fixed GeoIPTest.test04_city() failure with the latest GeoIP2 database.
  • 7906968 [1.11.x] Bumped minimum ESLint version to 4.18.2.
  • 341f444 [1.11.x] Added CVE-2019-12308 to the security release archive.
  • 9f8bed5 [1.11.x] Added CVE-2019-11358 to the security release archive.
  • a07ce0e [1.11.x] Fixed typo in 1.11.21 release notes.
  • 2f67c8e [1.11.x] Post-release version bump.
  • See full diff in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+1 -1

0 comment

1 changed file

pr created time in 13 days

create barnchtjcsl/ion

branch : dependabot/pip/docs/django-1.11.22

created branch time in 13 days

PR opened tjcsl/ion

Reviewers
build(deps): bump django from 1.11.21 to 1.11.22

Bumps django from 1.11.21 to 1.11.22. <details> <summary>Commits</summary>

  • 480380c [1.11.x] Bumped version for 1.11.22 release.
  • 32124fc [1.11.x] Fixed CVE-2019-12781 -- Made HttpRequest always trust SECURE_PROXY_S...
  • 58553bb [1.11.x] Added stub release notes for security releases.
  • bc5febe [1.11.x] Fixed GeoIPTest.test04_city() failure with the latest GeoIP2 database.
  • 7906968 [1.11.x] Bumped minimum ESLint version to 4.18.2.
  • 341f444 [1.11.x] Added CVE-2019-12308 to the security release archive.
  • 9f8bed5 [1.11.x] Added CVE-2019-11358 to the security release archive.
  • a07ce0e [1.11.x] Fixed typo in 1.11.21 release notes.
  • 2f67c8e [1.11.x] Post-release version bump.
  • See full diff in compare view </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

</details>

+3 -3

0 comment

3 changed files

pr created time in 13 days

create barnchtjcsl/ion

branch : dependabot/pip/django-1.11.22

created branch time in 13 days

push eventtjcsl/ion

anonymoose2

commit sha 37f33dda5d6e61d5b67da5db4e48fba4e6def0e8

ci(travis): add Pylint check to Travis build Some checks had to be disabled to get it to pass; they indicate items to be worked on

view details

push time in 14 days

PR merged tjcsl/ion

Add Pylint check to Travis build

Some checks had to be disabled to get it to pass. They indicate items to be worked on.

+2 -1

1 comment

1 changed file

anonymoose2

pr closed time in 14 days

pull request commenttjcsl/ion

Add Pylint check to Travis build

Coverage Status

Coverage remained the same at 47.034% when pulling dd186e42895c48339c7960358eb067be45f9d292 on anonymoose2:safe-code into 2dd0b31c6a202199a4f036664902f36f677966b7 on tjcsl:dev.

anonymoose2

comment created time in 14 days

PR opened tjcsl/ion

Reviewers
Add Pylint check to Travis build

Some checks had to be disabled to get it to pass. They indicate items to be worked on.

+1 -0

0 comment

1 changed file

pr created time in 14 days

push eventtjcsl/ion

anonymoose2

commit sha 23e215953b4840ca62f694457ede6dd2ccc6dc96

chore(pylint): disable full reports

view details

anonymoose2

commit sha 9b63ce8b1c62be6d29540e1eaa04290b6f36da2c

chore(pylint): use long check names for disable comments

view details

anonymoose2

commit sha 603e87a0b0c543f0f34bb8734f286a7f383c80d1

chore(pylint): remove unnecessary pylint enable

view details

anonymoose2

commit sha 2dd0b31c6a202199a4f036664902f36f677966b7

chore: remove old commented-out code from eighth models

view details

push time in 14 days

PR merged tjcsl/ion

Clean up parts of the codebase

Part of the #610/#611/#635/#637/#641/#645/#646 chain, but this PR is focused on Pylint-related cleanups.

+14 -83

1 comment

11 changed files

anonymoose2

pr closed time in 14 days

pull request commenttjcsl/ion

Clean up parts of the codebase

Coverage Status

Coverage decreased (-0.008%) to 47.026% when pulling e6c2c715578c7526d64d114a2697ec5ad60938f1 on anonymoose2:clean-code into 45982cd537dcbc45d5d50d1990f1b0d68492b754 on tjcsl:dev.

anonymoose2

comment created time in 14 days

PR opened tjcsl/ion

Reviewers
Clean up parts of the codebase

Part of the #610/#611/#635/#637/#641/#645/#646 chain, but this PR is focused on Pylint-related cleanups.

+14 -83

0 comment

11 changed files

pr created time in 14 days

push eventtjcsl/ion

anonymoose2

commit sha 45982cd537dcbc45d5d50d1990f1b0d68492b754

chore: remove unused 'generate_fake_data' user management command

view details

push time in 14 days

push eventtjcsl/ion

anonymoose2

commit sha 7abdd016c0cb3c7626bcb37f74b5a3f5d8cd0a7c

chore: disable more pylint checks We want Pylint to find bugs, not complain that a function is too long. Also removed some now-unnecessary comments disabling Pylint checks.

view details

anonymoose2

commit sha 7b9452f153cfec8642da4e3287986d0fcc04e321

chore: remove ineffectual checks from Pylint 'disable' list Some are Python 2-specific; some don't actually exist

view details

anonymoose2

commit sha c496fc5e2a9e4026f95d98cb004576b37fdb38fd

chore: ignore another Pylint error

view details

push time in 14 days

PR merged tjcsl/ion

Pylint tweaks

This is a collection of several tweaks to the Pylint configuration that make it a little saner.

+5 -5

1 comment

5 changed files

anonymoose2

pr closed time in 14 days

pull request commenttjcsl/ion

Remove unused 'generate_fake_data' user management command

Coverage Status

Coverage increased (+0.2%) to 47.034% when pulling 42572ea3cce9bd1c9fc60f421cba6c06384364f7 on anonymoose2:fake-data into a823c61c2c74c82993358e86b07cc55934a40152 on tjcsl:dev.

anonymoose2

comment created time in 14 days

pull request commenttjcsl/ion

Pylint tweaks

Coverage Status

Coverage remained the same at 46.786% when pulling 45b0f919179c7ac785d55cf1232907786291e7b8 on anonymoose2:clean-code into a823c61c2c74c82993358e86b07cc55934a40152 on tjcsl:dev.

anonymoose2

comment created time in 14 days

PR opened tjcsl/ion

Reviewers
Remove unused 'generate_fake_data' user management command
+0 -98

0 comment

2 changed files

pr created time in 14 days

PR opened tjcsl/ion

Reviewers
Pylint tweaks

This is a collection of several tweaks to the Pylint configuration that make it a little saner.

+5 -5

0 comment

5 changed files

pr created time in 14 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha a823c61c2c74c82993358e86b07cc55934a40152

style: blackify utils/date.py

view details

push time in 14 days

push eventtjcsl/ion

anonymoose2

commit sha dcb334458d9f99320884425b8fd7d9d9e494756b

fix: fix the build during July Also took this opportunity to set explicit 00:00:00 times for the datetimes return by get_date_range_this_year()

view details

push time in 14 days

PR merged tjcsl/ion

Fix the build during July

Also took this opportunity to set explicit 00:00:00 times for the datetime.datetimes return by get_date_range_this_year().

Note: @theo-o originally tracked down the bug to this function.

+5 -4

1 comment

1 changed file

anonymoose2

pr closed time in 14 days

pull request commenttjcsl/ion

Fix the build during July

Travis appears to be experiencing a backlog of Linux jobs. I've tested this locally and the Travis build passes. Merging.

anonymoose2

comment created time in 14 days

PR opened tjcsl/ion

Reviewers
Fix the build during July

Also took this opportunity to set explicit 00:00:00 times for the datetime.datetimes return by get_date_range_this_year().

+5 -4

0 comment

1 changed file

pr created time in 14 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 8b7036a5b8ec96856f004210e9ba89866e8e7b7e

chore: eliminate unnecessary warnings

view details

push time in 14 days

push eventtjcsl/ion

anonymoose2

commit sha 9994fcb864da6ec529ac477e073ef050c7be393a

style: switch all XHTML-style empty tags to the HTML style

view details

push time in 14 days

PR merged tjcsl/ion

Switch all XHTML-style empty tags to the HTML style

@theo-o: This change was done using simple sed substitutions. I have looked through and it doesn't look like this will break anything, but this is a massive change and I may have missed something. Please take your time when reviewing.

+981 -981

1 comment

158 changed files

anonymoose2

pr closed time in 14 days

push eventtjcsl/ion

anonymoose2

commit sha f38a15a6bb60233e764c1e6ac422919b64c35c1b

refactor(eighth): clean up some of the code in eighth models A mix of restructuring code and translating Python code into Django queries in the hopes of speed improvements

view details

anonymoose2

commit sha 0886a3274b2dea13bc39d7a51b5f0ce76767662d

refactor: use EighthScheduledActivity.cancel()/.uncancel() They exist; we may as well use them. Plus they have logging.

view details

anonymoose2

commit sha 095053e04ed702412335253e5c5466aaea90dc69

fix: make EighthBlockManager.get_next_upcoming_blocks() always return a QuerySet intranet.apps.eighth.management.commands.signup_status_email assumes it returns a QuerySet (it runs .count())

view details

anonymoose2

commit sha 519169fdbd581f31234aa40ec92601a8a2279191

fix: make EighthScheduledActivity.has_open_passes() return a boolean Currently it returns a QuerySet, which is unnecessary and inefficient. This change is not marked as breaking because 1) the name and the docstring imply that it returns a boolean and 2) it is only ever used in a boolean context

view details

anonymoose2

commit sha 3d4d9bf413c1b89eeedaab0083f936d71c8fff7a

chore: remove unused EighthBlock.letter_text property

view details

anonymoose2

commit sha eee16daf9fb43a6fb2a66daecbb94d8422623593

chore: remove unused activity ID changing code Changing activity IDs would be more trouble than it's worth

view details

anonymoose2

commit sha 35b90622ee4fc845f94cc3a7053a571489b99de5

tests: add eighth pass tests

view details

anonymoose2

commit sha f2809e4f33ce9b24cede7edaaaccf657a15e8a17

tests: add more eighth tests

view details

Theo Ouzhinski

commit sha 011e8517e2bee6934ae7839849f9f2859519f218

style: blackify eighth tests

view details

anonymoose2

commit sha f6a64ff28a35b4da078b7d6d68e9811938c90ada

fix: confirm admin actions with potentially undesirable consequences Many such actions already require confirmation, but there are some that do not. This PR fixes the two that I was able to find.

view details

push time in 14 days

pull request commenttjcsl/ion

Switch all XHTML-style empty tags to the HTML style

Coverage Status

Coverage remained the same at 46.789% when pulling a0c8ac2bb9944ac3394ae4c40e75e3bbe3db40c6 on anonymoose2:good-code into f6a64ff28a35b4da078b7d6d68e9811938c90ada on tjcsl:dev.

anonymoose2

comment created time in 16 days

PR opened tjcsl/ion

Reviewers
Switch all XHTML-style empty tags to the HTML style

@theo-o: This change was done using simple sed substitutions. I have looked through and it doesn't look like this will break anything, but this is a massive change and I may have missed something. Please take your time when reviewing.

+981 -981

0 comment

158 changed files

pr created time in 16 days

push eventtjcsl/ion

anonymoose2

commit sha f6a64ff28a35b4da078b7d6d68e9811938c90ada

fix: confirm admin actions with potentially undesirable consequences Many such actions already require confirmation, but there are some that do not. This PR fixes the two that I was able to find.

view details

push time in 16 days

PR merged tjcsl/ion

Require confirmation for admin actions with potentially undesirable consequences

Many such actions already require confirmation, but there are some that do not. This PR fixes the two that I was able to find.

+23 -20

2 comments

2 changed files

anonymoose2

pr closed time in 16 days

pull request commenttjcsl/ion

Require confirmation for admin actions with potentially undesirable consequences

Coverage Status

Coverage remained the same at 46.789% when pulling 3ed686ce8ce84c3cb807bab214d5fcbc7c980679 on anonymoose2:safe-code into 011e8517e2bee6934ae7839849f9f2859519f218 on tjcsl:dev.

anonymoose2

comment created time in 16 days

pull request commenttjcsl/ion

Require confirmation for admin actions with potentially undesirable consequences

Coverage Status

Coverage remained the same at 46.789% when pulling 3ed686ce8ce84c3cb807bab214d5fcbc7c980679 on anonymoose2:safe-code into 011e8517e2bee6934ae7839849f9f2859519f218 on tjcsl:dev.

anonymoose2

comment created time in 16 days

PR opened tjcsl/ion

Reviewers
Require confirmation for admin actions with potentially undesirable consequences

Many such actions already require confirmation, but there are some that do not. This PR fixes the two that I was able to find.

+23 -20

0 comment

2 changed files

pr created time in 16 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 011e8517e2bee6934ae7839849f9f2859519f218

style: blackify eighth tests

view details

push time in 16 days

push eventtjcsl/ion

anonymoose2

commit sha f38a15a6bb60233e764c1e6ac422919b64c35c1b

refactor(eighth): clean up some of the code in eighth models A mix of restructuring code and translating Python code into Django queries in the hopes of speed improvements

view details

anonymoose2

commit sha 0886a3274b2dea13bc39d7a51b5f0ce76767662d

refactor: use EighthScheduledActivity.cancel()/.uncancel() They exist; we may as well use them. Plus they have logging.

view details

anonymoose2

commit sha 095053e04ed702412335253e5c5466aaea90dc69

fix: make EighthBlockManager.get_next_upcoming_blocks() always return a QuerySet intranet.apps.eighth.management.commands.signup_status_email assumes it returns a QuerySet (it runs .count())

view details

anonymoose2

commit sha 519169fdbd581f31234aa40ec92601a8a2279191

fix: make EighthScheduledActivity.has_open_passes() return a boolean Currently it returns a QuerySet, which is unnecessary and inefficient. This change is not marked as breaking because 1) the name and the docstring imply that it returns a boolean and 2) it is only ever used in a boolean context

view details

anonymoose2

commit sha 3d4d9bf413c1b89eeedaab0083f936d71c8fff7a

chore: remove unused EighthBlock.letter_text property

view details

anonymoose2

commit sha eee16daf9fb43a6fb2a66daecbb94d8422623593

chore: remove unused activity ID changing code Changing activity IDs would be more trouble than it's worth

view details

anonymoose2

commit sha 35b90622ee4fc845f94cc3a7053a571489b99de5

tests: add eighth pass tests

view details

anonymoose2

commit sha f2809e4f33ce9b24cede7edaaaccf657a15e8a17

tests: add more eighth tests

view details

push time in 16 days

PR merged tjcsl/ion

Clean up parts of codebase

Part of the #610/#611/#635/#637/#641/#645 chain.

@theo-o: Unlike previous PRs of this type, this PR refactors significant sections of code that are critical to Ion's functionality. Please review carefully.

+164 -187

2 comments

4 changed files

anonymoose2

pr closed time in 16 days

pull request commenttjcsl/ion

Clean up parts of codebase

Some tests would be very nice.

anonymoose2

comment created time in 17 days

pull request commenttjcsl/ion

Clean up parts of codebase

Coverage Status

Coverage increased (+0.06%) to 46.325% when pulling 7d3ba7b0773da70aa8144db6f166a25213aa2ac0 on anonymoose2:clean-code into fc268e06ad6d0b4b711e589e8044aa956643372f on tjcsl:dev.

anonymoose2

comment created time in 17 days

PR opened tjcsl/ion

Reviewers
Clean up parts of codebase

Part of the #610/#611/#635/#637/#641/#645 chain.

@theo-o: Unlike previous PRs of this type, this PR refactors significant sections of code that are critical to Ion's functionality. Please review carefully.

+54 -187

0 comment

3 changed files

pr created time in 17 days

pull request commenttjcsl/ion

Clean up codebase

Coverage Status

Coverage decreased (-0.09%) to 46.262% when pulling eb1bb7099251036d35b1ef119459b96f1b88ff53 on anonymoose2:clean-code into 2ed7371061d1b90024fee1fdfe571f50517f97b7 on tjcsl:dev.

anonymoose2

comment created time in 18 days

push eventtjcsl/ion

Travis

commit sha d66d08837037304f351ecd2a851b8ae2b3e6e9e1

Travis build 4792

view details

push time in 18 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 0309b7b2032383e61c5845ff72b7db651ed96a22

fix(events): use timezone instead of datetime

view details

Theo Ouzhinski

commit sha b39401e436bc2b787643d49d101b1043e7a028d2

style: fix flake8

view details

Theo Ouzhinski

commit sha a7b3d1cb28e9048f40d1513ea5e52997da89af19

test: add more events tests

view details

Theo Ouzhinski

commit sha a32c642a2c22a6a36a142f0530a81511c1f55c8e

fix(events): rename submit event to request event

view details

anonymoose2

commit sha c0d2119b570a36df17f3b7f4a468f86ca0e373e5

perf: generate a dictionary listing permission names at module load Currently, the 'permissions' property lists all the UserProperties object's fields and iterates through them to find the permission fields and add them to the dictionary. This should be a more efficient method.

view details

anonymoose2

commit sha 77bd0650408d9ee96ff8c2a2872e27322b60ecd6

tests: add tests to make sure the privacy options are listed properly

view details

anonymoose2

commit sha 3bebd98f361d80b59274a635af080692a7984183

feat: by default, the block list API now shows all the year's blocks BREAKING CHANGE: when there are no upcoming blocks, the block list API now lists all the past blocks instead of giving an empty list

view details

anonymoose2

commit sha abf0a6e3120f7a9430f1ae09a74e1a930d3132da

perf: pass update_fields to self.save() in models This is good practice, and according to the Django docs it has a slight performance benefit

view details

anonymoose2

commit sha 3f3a2d085293ae20f3eddff5a34182b924b3df82

perf: the trailers are gone; don't handle 'Weyanoke' rooms separately BREAKING CHANGE: Weyanoke trailers are no longer handled separately

view details

anonymoose2

commit sha 2ed7371061d1b90024fee1fdfe571f50517f97b7

tests: test that the API shows past blocks if there aren't upcoming blocks

view details

anonymoose2

commit sha 70538c035a06b69c0104f3f88fe127399a104d33

chore(pylint): disable some pylint checks that are just annoyances In most cases there isn't a better way to do something when these checks don't like it

view details

anonymoose2

commit sha 9ccf7bf652df0d5cb99a07d804fb81db6da83e00

refactor: remove EighthBlock.get_surrounding_blocks() in favor of EighthBlock.objects.get_blocks_this_year() They literally do the exact same thing, except that EighthBlock.get_surrounding_blocks() is less efficient and returns a list instead of a QuerySet

view details

anonymoose2

commit sha adaf1d828abb5677172a288e157f83f0967e0726

refactor: make EighthBlock.previous_blocks() return a QuerySet

view details

anonymoose2

commit sha 6e21f7367b233b574e2f8e8e3d242d432e29b9f7

refactor: call the method EighthBlock.signup_time_future() explicitly Django will still call it in the template, but it's best to be explicit

view details

anonymoose2

commit sha fc268e06ad6d0b4b711e589e8044aa956643372f

refactor: clean up some of the logic in eighth models

view details

push time in 18 days

push eventtjcsl/ion

anonymoose2

commit sha 70538c035a06b69c0104f3f88fe127399a104d33

chore(pylint): disable some pylint checks that are just annoyances In most cases there isn't a better way to do something when these checks don't like it

view details

anonymoose2

commit sha 9ccf7bf652df0d5cb99a07d804fb81db6da83e00

refactor: remove EighthBlock.get_surrounding_blocks() in favor of EighthBlock.objects.get_blocks_this_year() They literally do the exact same thing, except that EighthBlock.get_surrounding_blocks() is less efficient and returns a list instead of a QuerySet

view details

anonymoose2

commit sha adaf1d828abb5677172a288e157f83f0967e0726

refactor: make EighthBlock.previous_blocks() return a QuerySet

view details

anonymoose2

commit sha 6e21f7367b233b574e2f8e8e3d242d432e29b9f7

refactor: call the method EighthBlock.signup_time_future() explicitly Django will still call it in the template, but it's best to be explicit

view details

anonymoose2

commit sha fc268e06ad6d0b4b711e589e8044aa956643372f

refactor: clean up some of the logic in eighth models

view details

push time in 18 days

more