profile
viewpoint
tjcsl Fairfax, VA https://tjhsst.edu TJHSST Computer Systems Lab

startedtjcsl/ion

started time in 2 days

push eventtjcsl/ion

anonymoose2

commit sha f95d405ca2574106af28c19f5d9da320450f5dcb

refactor(users): add error message to AttributeErrors This may seem minor, but the lack of a proper descriptive error message is annoying when debugging.

view details

anonymoose2

commit sha 2aa1ed010f2777369ce02c00e7a6490341e52817

docs: fix typo

view details

push time in 3 days

push eventtjcsl/ion

Travis

commit sha d474630a8ebd0bd03b13823191f42bd2bff50f79

Travis build 5406

view details

push time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha db879f160be5a3b0bf016a80fb1f423b9c67c8ce

chore(dashboard): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha f752885513f54340f9da30cd2cbbd7ff9f4d88a7

chore(emerg): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 43e37fcf8e5121a8f5fb501ec9d52914c075564b

chore(files): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 536ead58e391ee5affa598c1eaf9ff6357969a02

chore(schedule): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 31b98ac4130aef391ce875c93533258e117e70d9

chore(search): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 74fe734b123afbb553f7febd747d74df07a4add9

chore(utils): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 1a89144d1a820f7ce6660092cee4d40dcc9d85ff

chore(polls): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha afd886cafdd6c6733186c415b9bc32443dd48bbf

chore(schedule): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha f7600a98275a67dfc7860bd0c1d702b56679205d

chore(events): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 18c8d945ebf7ea4ca2a296c042201923659f2d1b

chore(eighth): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 3b05ddb0815b6aec78599d628d9933066d1c224a

chore(printing): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha c7c38507b2971806d486b5c6dff5ec38a8c201d7

chore(preferences): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha ac90f78f7e19a2106a87c1e4de09174d3bc31181

chore(parking): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 8b4f1e1335cb6a367580e15228f6230a1a217e26

chore(notifications): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 56e3eb526f3f19398c4d1b2c575d43248826ab1d

chore(lostfound): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha e36cba476afb196e64b69547f2de6178b033fdf8

chore(itemreg): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha e9104bc54e069b38868209c904a04e5580f3850f

chore(feedback): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha aadaa95bbddc734f8d396ce3442ab4a272dd3c7c

chore(emailfwd): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 9559ebb7da7c156f31446ed897e89af894155837

chore(context_processors): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha b7501b4319d83929066e14bb7a629c24d631ed14

chore(announcements): remove unneeded debug log statements

view details

push time in 3 days

delete branch tjcsl/ion

delete branch : passes

delete time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 8a924d9f62fca5ef07dbe154d26ade8ffeb56b24

feat(eighth): add update counselors management command

view details

Theo Ouzhinski

commit sha 960078bb6c1aa35993d280d2da4914e4dd35f3ca

docs: build docs

view details

Theo Ouzhinski

commit sha ec65c463a6f698aa00721eb17c5a05992360dcb0

refactor(eighth): refactor comprehension

view details

push time in 3 days

PR merged tjcsl/ion

Add counselor update management script

Proposed changes

  • Adds a management script that updates counselors associated with a user

Brief description of rationale

A useful script to update counselors based on updated information. This is especially useful when the counselor for many students changes.

+62 -0

1 comment

3 changed files

theo-o

pr closed time in 3 days

push eventtjcsl/website

Laur04

commit sha e65766d7513ad6eacf0b73ffda7402634b52a6b9

do not show prerequites on initial lab page

view details

push time in 3 days

PR merged tjcsl/website

do not show prerequisites on initial lab page
+36 -34

0 comment

2 changed files

Laur04

pr closed time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha db879f160be5a3b0bf016a80fb1f423b9c67c8ce

chore(dashboard): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha f752885513f54340f9da30cd2cbbd7ff9f4d88a7

chore(emerg): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 43e37fcf8e5121a8f5fb501ec9d52914c075564b

chore(files): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 536ead58e391ee5affa598c1eaf9ff6357969a02

chore(schedule): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 31b98ac4130aef391ce875c93533258e117e70d9

chore(search): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 74fe734b123afbb553f7febd747d74df07a4add9

chore(utils): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 1a89144d1a820f7ce6660092cee4d40dcc9d85ff

chore(polls): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha afd886cafdd6c6733186c415b9bc32443dd48bbf

chore(schedule): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha f7600a98275a67dfc7860bd0c1d702b56679205d

chore(events): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 18c8d945ebf7ea4ca2a296c042201923659f2d1b

chore(eighth): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 3b05ddb0815b6aec78599d628d9933066d1c224a

chore(printing): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha c7c38507b2971806d486b5c6dff5ec38a8c201d7

chore(preferences): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha ac90f78f7e19a2106a87c1e4de09174d3bc31181

chore(parking): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 8b4f1e1335cb6a367580e15228f6230a1a217e26

chore(notifications): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 56e3eb526f3f19398c4d1b2c575d43248826ab1d

chore(lostfound): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha e36cba476afb196e64b69547f2de6178b033fdf8

chore(itemreg): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha e9104bc54e069b38868209c904a04e5580f3850f

chore(feedback): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha aadaa95bbddc734f8d396ce3442ab4a272dd3c7c

chore(emailfwd): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha 9559ebb7da7c156f31446ed897e89af894155837

chore(context_processors): remove unneeded debug log statements

view details

Theo Ouzhinski

commit sha b7501b4319d83929066e14bb7a629c24d631ed14

chore(announcements): remove unneeded debug log statements

view details

push time in 3 days

PR merged tjcsl/ion

Log cleanup

Proposed changes

  • Cleans up unneeded debug log statements
  • Refactors an if statement

Brief description of rationale

We have a lot of log statements filling up our prod logs that are just taking up space. Log statements should provide context to what they are logging instead of just dumping information.

+10 -223

1 comment

31 changed files

theo-o

pr closed time in 3 days

pull request commenttjcsl/ion

Log cleanup

Coverage Status

Coverage increased (+0.5%) to 53.643% when pulling 8280e7a9181b7bbc06d0d68673d0184da31e71fa on privacy into 4f6ae4607801e6c5bc6cf50fbb1a2c372b2a06d3 on dev.

theo-o

comment created time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha b47c73913ead9dc04312c1770492e898e0d51ed2

refactor(eighth): refactor comprehension

view details

push time in 3 days

pull request commenttjcsl/ion

Add counselor update management script

Coverage Status

Coverage decreased (-0.1%) to 52.983% when pulling eb53df6cac4c97e54914914f7baf9bf9139e4b5c on fixes into 4f6ae4607801e6c5bc6cf50fbb1a2c372b2a06d3 on dev.

theo-o

comment created time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 8280e7a9181b7bbc06d0d68673d0184da31e71fa

style: fix formatting issue

view details

push time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha eb53df6cac4c97e54914914f7baf9bf9139e4b5c

docs: build docs

view details

push time in 3 days

PR opened tjcsl/ion

Add counselor update management script

Proposed changes

  • Adds a management script that updates counselors associated with a user

Brief description of rationale

A useful script to update counselors based on updated information. This is especially useful when the counselor for many students changes.

+54 -0

0 comment

2 changed files

pr created time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha a53667850a3d505613b292b2a4476d459c86bcf2

chore(emerg): return a debug statement to indicate when emergency info is fetched

view details

push time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 7d768e8956b3cd2508555ea7debcf5d805e4e548

fix(preferences): add a debug statement when preferencs are being changed

view details

push time in 3 days

Pull request review commenttjcsl/ion

Log cleanup

 def check_emerg():  def get_emerg_result():     """Run the fetch command from FCPS."""-    logger.debug("Fetching emergency info from FCPS")

I would actually keep this. It might be helpful to know when we last fetched emergency info from FCPS.

theo-o

comment created time in 3 days

push eventtjcsl/ion

anonymoose2

commit sha b208f0489df0f4cfbbafd65adf8120fd9a9bf09c

feat(announcements): block announcements from containing the text "ION" Closes #805 Also cleans up some of the announcement templates as necessary to make this change possible

view details

anonymoose2

commit sha a06fdccf4c61347ff0049bcc2bf5da7c97a7bce1

feat(events): block events from containing the text "ION" Related to #805

view details

Theo Ouzhinski

commit sha db75172e3f9f9ccbab453e5263ede129346523d2

feat(docs): add terminology docs Related to #805

view details

Theo Ouzhinski

commit sha 7c70bae7eabfe84347f5d21847bf16df04d15fc2

chore: update sources

view details

anonymoose2

commit sha 4692ad86752aa52db731a13b78bd0b3350a580f3

fix(bus): display text correctly on signage bus page in Firefox Fixes #808 Firefox has issues with <svg>s in <iframe>s. This uses a bit of a hack to fix that.

view details

anonymoose2

commit sha 03992ae10040b24f87e5f08eeb331d892fcee065

fix(announcements): fix bug preventing approval of announcements Announcement approval was accidentally broken in b208f0489d.

view details

anonymoose2

commit sha 03896f5f6ce9a03bed5f5ea99adcce7143a37169

fix(printing): identify .docx files properly Fixes the root cause of #790

view details

anonymoose2

commit sha b1eadd536285821faf3bdc52efba6d6dd2f9f627

feat(bus): add out of county buses to signage and bus admin page Closes #568

view details

anonymoose2

commit sha 7c073e852632c139d2255e6fb3113e26a9b54bd2

fix(bus): fix bus display not updating Also clean up bus consumer slightly

view details

anonymoose2

commit sha c759a3a6e099d4ae8d92486e53db942ff4a8e8f1

feat(signage): enlarge and bold bus route text on signage This is about the maximum that the text can be enlarged on signage displays without significant modification.

view details

Theo Ouzhinski

commit sha 11e9ebb71c112db48472c99d53c063a2c964c8f5

chore: update CODEOWNERS

view details

anonymoose2

commit sha c0e4207463318ec381ca5132bb7d8c27e0be6fd9

refactor(dark): change eighth signup block colors The distinction between blocks when the user is signed up vs. not signed up is not very significant, and it can be confusing.

view details

anonymoose2

commit sha 10287f92a20cc8d7deb77f6a022f2cc90c9a3ba6

refactor(dark): use brighter activity icons in dark mode The contrast is not very good in the activity list

view details

Theo Ouzhinski

commit sha 20d0dfda633811b22e97d60a08836e903c9a3c62

feat(eighth): add email templates for removing withdrawn students

view details

Theo Ouzhinski

commit sha 952d147adeb4ce0e3226a9e8f2a68ecf985f99ff

fix(eighth): fix email templates for removing withdrawn students

view details

Theo Ouzhinski

commit sha 5e453296275ecc6f3d092dfdd4c317511d23dc96

feat(eighth): add management script to remove withdrawn students

view details

Theo Ouzhinski

commit sha 1c0caf19bf59708e4bd1f071fc09edaf5548b4de

chore(eighth): remove iodine->Ion import scripts

view details

Theo Ouzhinski

commit sha eaf862f28ff3ad42643ecc2038762a479b202e40

chore(settings): reconcile settings

view details

Theo Ouzhinski

commit sha 218c64afeac6d1d4c88911b7a63fe0d1322de150

docs: build docs

view details

Theo Ouzhinski

commit sha 2d5a1d93a853ab6926b01cb4551f10ab6c367eac

fix(eighth): actually delete users in remove withdrawn students management script

view details

push time in 3 days

PR opened tjcsl/ion

Reviewers
Log cleanup

Proposed changes

  • Cleans up unneeded debug log statements
  • Refactors an if statement

Brief description of rationale

We have a lot of log statements filling up our prod logs that are just taking up space. Log statements should provide context to what they are logging instead of just dumping information.

+8 -223

0 comment

31 changed files

pr created time in 3 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha ef1c4ef743fdb93488fd6c8ef97705bc068a63f8

fix(preferences): disable privacy options form

view details

anonymoose2

commit sha b6b8fa2a47be16cc937703d4874116cf4ac6c909

fix(printing): send_feeback -> send_feedback

view details

anonymoose2

commit sha 7c40f883b98336e409a4664a2edbff3d562f5180

ci(travis): ignore more Pylint checks The duplicate-code check catches a lot of basic code (imports, queries, etc.) and the cyclic-import check can't really be resolved right now.

view details

anonymoose2

commit sha 91fabdefeb5e035a5c08a28dae972e806ce9658a

fix(groups): only let group admins create groups

view details

anonymoose2

commit sha 2a7ea1b83f53835f333f93de221a980b413d47e8

fix(lostfound): don't let users modify or delete other users' items

view details

anonymoose2

commit sha a3043a485af940bcd4114fdb405b16dac2c96bbd

fix(printing): add space

view details

anonymoose2

commit sha d1af39158198bae2a18663a8eb1a8de0853953db

feat(printing): recommend PDFs if a .doc/.docx can't be identified

view details

anonymoose2

commit sha 5a7f65365bee52b0d9861201de8ce3b22ac7e53f

test(printing): make sure the printing page renders correctly

view details

anonymoose2

commit sha 883ce33029d727a668f4161033154b681d78a650

feat(oauth): further discourage use of the iOS app Disables the "Dashboard" button so they can't use it to pull up Ion quickly, and recommends they add the website to their home screen instead.

view details

anonymoose2

commit sha a8fbed063e3377ffdae3093d2c929a273115421c

feat(eighth): add logging to EighthScheduledActivity.add_user() See #629

view details

anonymoose2

commit sha 7942684230f237d9e012ba97d0055b8a4b1cb8e7

feat: add session management page Fixes #559 Fixes #771 This feature is highly experimental, hence the lack of links to it anywhere.

view details

anonymoose2

commit sha 896511eff98c4a9fb92df0d4b76a44c0ab97f7cf

docs: build docs

view details

anonymoose2

commit sha 01d38b5c60a9830d62b4fe8da8266b29a03af54c

fix(auth): fix reauthentication implementation Fixes #846

view details

anonymoose2

commit sha 06480375d46e0fdabe5cba220293bc2ba204c027

refactor(sessionmgmt): delete and block duplicate TrustedSession objects Enforced on a per-user, per-session basis

view details

anonymoose2

commit sha 4fca96ffe6507a4f1904fd44a3d5f46da43c9fb3

fix(sessionmgmt): don't attempt to create duplicate TrustedSessions

view details

anonymoose2

commit sha 123867c40aef44c81d10a5333bc60b5d69ae8b27

refactor: upgrade to Font Awesome 5 Closes #836

view details

anonymoose2

commit sha ffb167effd63e8c715340bdf704b72efae3253c4

chore: update sources

view details

anonymoose2

commit sha 62754306362ba8a0d33d1a8def605c5f4e41ccdd

fix: update other 'base' templates to Font Awesome 5

view details

anonymoose2

commit sha 594026fe74c64c5bbae4e57d00734c0868aac5a0

refactor(sessionmgmt): add bottom margin to device information box

view details

anonymoose2

commit sha c432858630611e32ede1fa0244fe837813132894

refactor(sessionmgmt): don't 404 if a session has already been revoked

view details

push time in 3 days

push eventtjcsl/ion

Travis

commit sha 8bfc2825b619d9d81a58ee3ae069dff5c9fa01c7

Travis build 5389

view details

push time in 3 days

push eventtjcsl/ion

anonymoose2

commit sha 594026fe74c64c5bbae4e57d00734c0868aac5a0

refactor(sessionmgmt): add bottom margin to device information box

view details

anonymoose2

commit sha c432858630611e32ede1fa0244fe837813132894

refactor(sessionmgmt): don't 404 if a session has already been revoked

view details

anonymoose2

commit sha 7de9f54c1c937910cfd9626499fac463aa4da864

chore: update flake8/black exclude lists

view details

anonymoose2

commit sha bc28d38d3ca8109e367488be6e72f30863dd472d

ci(Travis): run black/autopep8/isort in Travis build

view details

anonymoose2

commit sha 01af1728878840c84b094960f1caecc171a09478

style: format everything with new format.sh script

view details

anonymoose2

commit sha dcd5513fd8e3e1f9d9b0bbe0105c9421cf02d5c5

chore: update sources

view details

anonymoose2

commit sha 30c0ccabdd590b7d5a25c620a3689998230227ea

docs: document new scripts/format.sh script

view details

anonymoose2

commit sha 4f6ae4607801e6c5bc6cf50fbb1a2c372b2a06d3

fix(preferences): only allow eighth admins to change privacy options

view details

push time in 3 days

push eventtjcsl/ion

anonymoose2

commit sha 4f6ae4607801e6c5bc6cf50fbb1a2c372b2a06d3

fix(preferences): only allow eighth admins to change privacy options

view details

push time in 3 days

push eventtjcsl/ion

anonymoose2

commit sha 7de9f54c1c937910cfd9626499fac463aa4da864

chore: update flake8/black exclude lists

view details

anonymoose2

commit sha bc28d38d3ca8109e367488be6e72f30863dd472d

ci(Travis): run black/autopep8/isort in Travis build

view details

anonymoose2

commit sha 01af1728878840c84b094960f1caecc171a09478

style: format everything with new format.sh script

view details

anonymoose2

commit sha dcd5513fd8e3e1f9d9b0bbe0105c9421cf02d5c5

chore: update sources

view details

anonymoose2

commit sha 30c0ccabdd590b7d5a25c620a3689998230227ea

docs: document new scripts/format.sh script

view details

push time in 3 days

PR merged tjcsl/ion

Add formatting check to Travis build

Proposed changes

  • Update flake8/black exclude lists
  • Run black/autopep8/isort in Travis build
  • Format everything with new format.sh script

Brief description of rationale

@theo-o has been slowly blackifying the codebase. This makes it official and enforces it.

Note: autopep8 is needed because on certain things black does not agree with flake8/pylint, so we have autopep8 fix those.

+55 -20

1 comment

13 changed files

anonymoose2

pr closed time in 3 days

Pull request review commenttjcsl/ion

Add formatting check to Travis build

 At the time of this writing, the Travis build runs the following commands:         flake8 --max-line-length 150 --exclude=*/migrations/* .         pylint --jobs=0 --disable=fixme,broad-except,global-statement,attribute-defined-outside-init intranet/         isort --check --recursive intranet+        ./scripts.format.sh+Note: The ``./scripts/format.sh`` check is run in such a way that the build will fail if it has to makea any changes.
Note: When the ``./scripts/format.sh`` check is run, the build will fail if it has to make any changes.

Also add a blank line above this line

anonymoose2

comment created time in 3 days

Pull request review commenttjcsl/ion

Add formatting check to Travis build

 At the time of this writing, the Travis build runs the following commands:         flake8 --max-line-length 150 --exclude=*/migrations/* .         pylint --jobs=0 --disable=fixme,broad-except,global-statement,attribute-defined-outside-init intranet/         isort --check --recursive intranet+        ./scripts.format.sh+Note: The ``./scripts/format.sh`` check is run in such a way that the build will fail if it has to makea any changes.  ``flake8`` is a PEP8 style checker, ``pylint`` is a linter (but it also enforces some PEP8 conventions), and ``isort``, when called with these options, checks that all imports are sorted alphabetically. +``./scripts/format.sh`` runs ``black intranet && autopep8 --in-place --recursive intranet && isort --recursive intranet``. The reason for the multiple commands is that ``black`` introduces certain formatting changes which ``flake8``/``pylint`` do not agree with (and offers no options to change them), so we have ``autopep8`` fix it.+ It is recommended that you run all of these locally before opening a pull request (though the Ion developers sometimes skip running the ``pylint`` check locally because it takes a long time to run). All of them are intended to be run from the root directory of the Git repository. -If ``flake8`` or ``pylint`` throw errors, the error messages are usually human-readable. if ``isort`` gives any errors, you can have it automatically correct the order of all imports by running ``isort --recursive intranet``.+If ``flake8`` or ``pylint`` throw errors, the error messages are usually human-readable. if ``isort`` gives any errors, you can have it automatically correct the order of all imports by running ``isort --recursive intranet``. If the running of ``scripts/format.sh`` results in any changes, you can simply run  ``./scripts/format.sh`` to fix your formatting.

If running ``scripts.format.sh`` results in any changes...

anonymoose2

comment created time in 3 days

pull request commenttjcsl/ion

Add formatting check to Travis build

Coverage Status

Coverage remained the same at 53.121% when pulling 31b4e1d22b51d922fc6c49b32f6b40ba1e555d6c on anonymoose2:travis into c432858630611e32ede1fa0244fe837813132894 on tjcsl:dev.

anonymoose2

comment created time in 3 days

PR opened tjcsl/ion

Reviewers
Add formatting check to Travis build

Proposed changes

  • Update flake8/black exclude lists
  • Run black/autopep8/isort in Travis build
  • Format everything with new format.sh script

Brief description of rationale

@theo-o has been slowly blackifying the codebase. This makes it official and enforces it.

Note: autopep8 is needed because on certain things black does not agree with flake8/pylint, so we have autopep8 fix those.

+45 -17

0 comment

10 changed files

pr created time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha 594026fe74c64c5bbae4e57d00734c0868aac5a0

refactor(sessionmgmt): add bottom margin to device information box

view details

anonymoose2

commit sha c432858630611e32ede1fa0244fe837813132894

refactor(sessionmgmt): don't 404 if a session has already been revoked

view details

push time in 4 days

PR merged tjcsl/ion

Session management tweaks

Proposed changes

  • Add bottom margin to device information "box"
  • Fail more gracefully (no 404) if the user tries to revoke a session that has already been revoked

Brief description of rationale

The "boxes" displaying information on each trusted device don't look good when squashed up against each other, and the 404 error is unexpected.

+8 -2

1 comment

2 changed files

anonymoose2

pr closed time in 4 days

pull request commenttjcsl/ion

Session management tweaks

Coverage Status

Coverage decreased (-0.01%) to 53.121% when pulling b44fb247743282d8bebef0b5ad46c9decc2cc9e2 on anonymoose2:session-mgmt into 62754306362ba8a0d33d1a8def605c5f4e41ccdd on tjcsl:dev.

anonymoose2

comment created time in 4 days

PR opened tjcsl/ion

Session management tweaks

Proposed changes

  • Add bottom margin to device information "box"
  • Fail more gracefully (no 404) if the user tries to revoke a session that has already been revoked

Brief description of rationale

The "boxes" displaying information on each trusted device don't look good when squashed up against each other, and the 404 error is unexpected.

+8 -2

0 comment

2 changed files

pr created time in 4 days

push eventtjcsl/ion

Travis

commit sha 6e9cf41bbba830599c677866fa56d6fa8daec06d

Travis build 5380

view details

push time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha 62754306362ba8a0d33d1a8def605c5f4e41ccdd

fix: update other 'base' templates to Font Awesome 5

view details

push time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha 62754306362ba8a0d33d1a8def605c5f4e41ccdd

fix: update other 'base' templates to Font Awesome 5

view details

push time in 4 days

push eventtjcsl/ion

Travis

commit sha e6628c03d4463c0b475a2d15505a70d09fa01167

Travis build 5378

view details

push time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha 123867c40aef44c81d10a5333bc60b5d69ae8b27

refactor: upgrade to Font Awesome 5 Closes #836

view details

anonymoose2

commit sha ffb167effd63e8c715340bdf704b72efae3253c4

chore: update sources

view details

push time in 4 days

issue closedtjcsl/ion

Upgrade to Font Awesome 5

Feature description

Upgrade to Font Awesome 5.

Rationale for adding feature

New cool icons are added

Suggested implementation(s) (if applicable)

closed time in 4 days

theo-o

push eventtjcsl/ion

anonymoose2

commit sha 123867c40aef44c81d10a5333bc60b5d69ae8b27

refactor: upgrade to Font Awesome 5 Closes #836

view details

anonymoose2

commit sha ffb167effd63e8c715340bdf704b72efae3253c4

chore: update sources

view details

push time in 4 days

PR merged tjcsl/ion

Upgrade to Font Awesome 5

Proposed changes

  • Upgrade to Font Awesome 5 (closes #836)
  • Bundles Font Awesome into vendor so we are not dependent on external CDNs

Brief description of rationale

New cool icons are added

+131429 -338

1 comment

1740 changed files

anonymoose2

pr closed time in 4 days

pull request commenttjcsl/ion

Upgrade to Font Awesome 5

Coverage Status

Coverage remained the same at 53.133% when pulling bb705964dba4441c7d158895e49900e157cbf699 on anonymoose2:fontawesome-5 into 4fca96ffe6507a4f1904fd44a3d5f46da43c9fb3 on tjcsl:dev.

anonymoose2

comment created time in 4 days

PR opened tjcsl/ion

Upgrade to Font Awesome 5

Proposed changes

  • Upgrade to Font Awesome 5 (closes #836)
  • Bundles Font Awesome into vendor so we are not dependent on external CDNs

Brief description of rationale

New cool icons are added

+129793 -338

0 comment

1739 changed files

pr created time in 4 days

push eventtjcsl/ion

Travis

commit sha 4dfb1d0821e375886b09b807bd5723a7ec0d8706

Travis build 5373

view details

push time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha 01d38b5c60a9830d62b4fe8da8266b29a03af54c

fix(auth): fix reauthentication implementation Fixes #846

view details

anonymoose2

commit sha 06480375d46e0fdabe5cba220293bc2ba204c027

refactor(sessionmgmt): delete and block duplicate TrustedSession objects Enforced on a per-user, per-session basis

view details

anonymoose2

commit sha 4fca96ffe6507a4f1904fd44a3d5f46da43c9fb3

fix(sessionmgmt): don't attempt to create duplicate TrustedSessions

view details

push time in 4 days

issue closedtjcsl/ion

Change reauthentication implementation to avoid security issues when session management page is added

Topic of discussion

Currently, when the user is required to re-authenticate to Ion to perform certain maintenance tasks, the reauthenticated session key is set to True. This then enables users to view pages that require reauthentication until their session expires.

The problem is that the session management page proposed in #559/#771 and implemented in #839 would reduce the security of this reauthentication method, since users would be able to perform these maintenance tasks on any of their trusted devices for several days after having reauthenticated only once. We should fix this so users have to re-authenticate every few hours, at least.

Proposed options/solutions

First, whatever the re-authenticate expiration timeout is and however it is implemented, it should be defined in settings/__init__.py. so it can be changed easily.

  1. Instead of setting the reauthenticated key, set a reauthenticated_at (or similar) key to the current time (probably just time.time() for simplicity). The reauthentication_required decorator can then check if the amount of time that has elapsed since this was set is less than the expiration timeout.
  2. Set a separate cookie with the current time. The problem here is that we would need to do a number of things in order to properly secure it -- like signing the cookie so we know it's from a trusted source -- and at that point we're almost reimplementing Django sessions.

We also need to decide on whether or not this should auto-renew every time the user visits Ion once they have re-authenticated.

Personal opinion (if applicable)

I am in favor of simply setting a different field in the session. I also think that auto-renewing this every time the user visits Ion would introduce additional security issues, so we should just set it once when they re-authenticate.

closed time in 4 days

anonymoose2

push eventtjcsl/ion

anonymoose2

commit sha 01d38b5c60a9830d62b4fe8da8266b29a03af54c

fix(auth): fix reauthentication implementation Fixes #846

view details

anonymoose2

commit sha 06480375d46e0fdabe5cba220293bc2ba204c027

refactor(sessionmgmt): delete and block duplicate TrustedSession objects Enforced on a per-user, per-session basis

view details

anonymoose2

commit sha 4fca96ffe6507a4f1904fd44a3d5f46da43c9fb3

fix(sessionmgmt): don't attempt to create duplicate TrustedSessions

view details

push time in 4 days

PR merged tjcsl/ion

Fix issues with session management page

Proposed changes

  • Change reauthentication implementation so it doesn't conflict with the new session management page (closes #846)
  • Delete and block duplicate TrustedSession objects
  • Don't attempt to create duplicate TrustedSessions

Brief description of rationale

Fixes a conflict between the reauthentication and session management systems and prevents duplicate TrustedSession objects from being created.

+67 -8

1 comment

8 changed files

anonymoose2

pr closed time in 4 days

pull request commenttjcsl/ion

Fix issues with session management page

Coverage Status

Coverage increased (+0.02%) to 53.133% when pulling a9612dadbddbf146408b53a0c3a51592148d90d3 on anonymoose2:session-mgmt into 896511eff98c4a9fb92df0d4b76a44c0ab97f7cf on tjcsl:dev.

anonymoose2

comment created time in 4 days

Pull request review commenttjcsl/ion

Fix issues with session management page

 def inner(*args, **kwargs): def reauthentication_required(wrapped):     def inner(*args, **kwargs):         request = args[0]  # request is the first argument in a view-        if request.session.get("reauthenticated", False):+        if (+            "reauthenticated_at" in request.session+            and 0 <= (time.time() - request.session["reauthenticated_at"]) <= settings.REAUTHENTICATION_EXPIRE_TIMEOUT

I already fixed it.

anonymoose2

comment created time in 4 days

Pull request review commenttjcsl/ion

Fix issues with session management page

 def inner(*args, **kwargs): def reauthentication_required(wrapped):     def inner(*args, **kwargs):         request = args[0]  # request is the first argument in a view-        if request.session.get("reauthenticated", False):+        if (+            "reauthenticated_at" in request.session+            and 0 <= (time.time() - request.session["reauthenticated_at"]) <= settings.REAUTHENTICATION_EXPIRE_TIMEOUT

Disregard this

anonymoose2

comment created time in 4 days

Pull request review commenttjcsl/ion

Fix issues with session management page

 def inner(*args, **kwargs): def reauthentication_required(wrapped):     def inner(*args, **kwargs):         request = args[0]  # request is the first argument in a view-        if request.session.get("reauthenticated", False):+        if (+            "reauthenticated_at" in request.session+            and 0 <= (time.time() - request.session["reauthenticated_at"]) <= settings.REAUTHENTICATION_EXPIRE_TIMEOUT

There is no validation that request.session["reauthenticated_at"] is an integer.

anonymoose2

comment created time in 4 days

PR opened tjcsl/ion

Fix issues with session management page

Proposed changes

  • Change reauthentication implementation so it doesn't conflict with the new session management page (closes #846)
  • Delete and block duplicate TrustedSession objects
  • Don't attempt to create duplicate TrustedSessions

Brief description of rationale

Fixes a conflict between the reauthentication and session management systems and prevents duplicate TrustedSession objects from being created.

+64 -8

0 comment

7 changed files

pr created time in 4 days

issue openedtjcsl/ion

Add "trust this device" checkbox to login screen

Feature description

When session management becomes more generally available, we should consider adding a "Trust this device" to checkbox to the login page. This reduces friction for users because they don't need to access the session management page in order to trust their device

Rationale for adding feature

Making trusting devices more automatic

Suggested implementation(s) (if applicable)

  • A simple checkbox on the login page that is non-intrusive. It would be set default off. We would probably want to send a message when they login that they have checked this box and that they can edit there preferences by visiting the session management page.

created time in 4 days

push eventtjcsl/ion

Travis

commit sha e946f609edd99468f76d1db3fd232548aaa427c5

Travis build 5368

view details

push time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha a3043a485af940bcd4114fdb405b16dac2c96bbd

fix(printing): add space

view details

anonymoose2

commit sha d1af39158198bae2a18663a8eb1a8de0853953db

feat(printing): recommend PDFs if a .doc/.docx can't be identified

view details

anonymoose2

commit sha 5a7f65365bee52b0d9861201de8ce3b22ac7e53f

test(printing): make sure the printing page renders correctly

view details

anonymoose2

commit sha 883ce33029d727a668f4161033154b681d78a650

feat(oauth): further discourage use of the iOS app Disables the "Dashboard" button so they can't use it to pull up Ion quickly, and recommends they add the website to their home screen instead.

view details

anonymoose2

commit sha a8fbed063e3377ffdae3093d2c929a273115421c

feat(eighth): add logging to EighthScheduledActivity.add_user() See #629

view details

anonymoose2

commit sha 7942684230f237d9e012ba97d0055b8a4b1cb8e7

feat: add session management page Fixes #559 Fixes #771 This feature is highly experimental, hence the lack of links to it anywhere.

view details

anonymoose2

commit sha 896511eff98c4a9fb92df0d4b76a44c0ab97f7cf

docs: build docs

view details

push time in 4 days

issue closedtjcsl/ion

Consider adjusting default Ion session length

Topic of discussion

Currently, https://github.com/tjcsl/ion/blob/fdd9b6f62275c15240470bda68b360b8118cfa47/intranet/settings/init.py#L437 our session lifetime is set to two hours. This setting was chosen rather arbitrarily at the beginning of Ion development and

Proposed options/solutions

I see the following as possible solutions:

  • Decrease the lifetime below an hour
  • Decrease the lifetime to somewhere between an hour or two
  • Keep the lifetime the same
  • Increase the lifetime to somewhere between two and five hours
  • Increase the lifetime to somewhere above hours
  • Or defer discussion until #559 is resolved

Personal opinion (if applicable)

The main question at issue is to what extent do we prioritize the small convenience of long-lived sessions versus protecting against the dangers of long-lived sessions? In my opinion, dropping the lifetime to below an hour would only annoy users while increasing it above lets say eight hours would not be terribly good for security. I believe that the right approach is keeping the lifetime as it is. This is because it satisfies the most prominent use case of long-lived sessions while preserving security. This use case is a hypothetical student logging in to check their eighth period schedules at the end of 7th period (2:15 PM) and then wanting access to Ion until a bit after dismissal. During this time, this hypothetical student would not want to re-authenticate himself/herself, so the student would like a session that lasts two hours from 2:15 PM to 4:15 PM. Hence, a two hour long session would make perfect sense for this usecase. Thoughts?

closed time in 4 days

theo-o

issue closedtjcsl/ion

Improve Session Management

The suggestion has been made multiple times to increase the length of sessions beyond 2 hours. I think that's both reasonable and useful, but of course this opens up security concerns.

I think a good compromise would be to extend session lifetime, but also implement a session management view where logged-in users can remove sessions that they are no longer using. This model is used by a lot of services including GitHub, Facebook, etc to offer more or less infinite-length sessions.

image

closed time in 4 days

naitian

push eventtjcsl/ion

anonymoose2

commit sha 7942684230f237d9e012ba97d0055b8a4b1cb8e7

feat: add session management page Fixes #559 Fixes #771 This feature is highly experimental, hence the lack of links to it anywhere.

view details

anonymoose2

commit sha 896511eff98c4a9fb92df0d4b76a44c0ab97f7cf

docs: build docs

view details

push time in 4 days

PR merged tjcsl/ion

Add session management page

Proposed changes

  • Add session management page (closes #559, closes #771)

Brief description of rationale

The features requested in #559 and #771 would be very helpful.

+469 -0

1 comment

26 changed files

anonymoose2

pr closed time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha a8fbed063e3377ffdae3093d2c929a273115421c

feat(eighth): add logging to EighthScheduledActivity.add_user() See #629

view details

push time in 4 days

PR merged tjcsl/ion

Add logging to EighthScheduledActivity.add_user()

Proposed changes

  • Add more logging to EighthScheduledActivity.add_user()

Brief description of rationale

We are seeing duplicate signups appear (see #629). However, investigation of each case has not been fruitful -- we just don't have much information about what actions the user took leading up to the creation of the duplicate signup. This is designed to help fix that.

Note: I have tested this in the following cases:

  • Signing up for a single-block activity (not being signed up for anything else that block)
  • Signing up for a double-block activity (not being signed up for anything else that block)
  • Switching from a single-block activity to another single-block activity
  • Switching from a double-block activity to another double-block activity
  • Switching from a single-block activity to a double-block activity
  • Switching from a double-block activity to a single-block activity
+33 -0

1 comment

1 changed file

anonymoose2

pr closed time in 4 days

pull request commenttjcsl/ion

Add logging to EighthScheduledActivity.add_user()

Coverage Status

Coverage increased (+0.01%) to 53.113% when pulling 05ed152d3bfbc275c380aa713a4c5c7e05528d1f on anonymoose2:logging into 883ce33029d727a668f4161033154b681d78a650 on tjcsl:dev.

anonymoose2

comment created time in 4 days

PR opened tjcsl/ion

Add logging to EighthScheduledActivity.add_user()

Proposed changes

  • Add more logging to EighthScheduledActivity.add_user()

Brief description of rationale

We are seeing duplicate signups appear (see #629). However, investigation of each case has not been fruitful -- we just don't have much information about what actions the user took leading up to the creation of the duplicate signup. This is designed to help fix that.

Note: I have tested this in the following cases:

  • Signing up for a single-block activity (not being signed up for anything else that block)
  • Signing up for a double-block activity (not being signed up for anything else that block)
  • Switching from a single-block activity to another single-block activity
  • Switching from a double-block activity to another double-block activity
  • Switching from a single-block activity to a double-block activity
  • Switching from a double-block activity to a single-block activity
+13 -0

0 comment

1 changed file

pr created time in 4 days

issue commenttjcsl/ion

Change reauthentication implementation to avoid security issues when session management page is added

Although I do see the immense security benefits for option 2 (signing a cookie), I am personally leaning towards option 1 because the primary goal of reauthentication_required should be to confirm that a user really wants to escalate their privileges to the maximum possible, instead of

If a user's session (especially an eighth admin's account) is compromised, they already can wreck havoc without going to parts of that are wrapped with reauthentication_required.

anonymoose2

comment created time in 4 days

issue openedtjcsl/ion

Change reauthentication implementation to avoid security issues when session management page is added

Topic of discussion

Currently, when the user is required to re-authenticate to Ion to perform certain maintenance tasks, the reauthenticated session key is set to True. This then enables users to view pages that require reauthentication until their session expires.

The problem is that the session management page proposed in #559/#771 and implemented in #839 would reduce the security of this reauthentication method, since users would be able to perform these maintenance tasks on any of their trusted devices for several days after having reauthenticated only once. We should fix this so users have to re-authenticate every few hours, at least.

Proposed options/solutions

First, whatever the re-authenticate expiration timeout is and however it is implemented, it should be defined in settings/__init__.py. so it can be changed easily.

  1. Instead of setting the reauthenticated key, set a reauthenticated_at (or similar) key to the current time (probably just time.time() for simplicity). The reauthentication_required decorator can then check if the amount of time that has elapsed since this was set is less than the expiration timeout.
  2. Set a separate cookie with the current time. The problem here is that we would need to do a number of things in order to properly secure it -- like signing the cookie so we know it's from a trusted source -- and at that point we're almost reimplementing Django sessions.

We also need to decide on whether or not this should auto-renew every time the user visits Ion once they have re-authenticated.

Personal opinion (if applicable)

I am in favor of simply setting a different field in the session. I also think that auto-renewing this every time the user visits Ion would introduce additional security issues, so we should just set it once when they re-authenticate.

created time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha 883ce33029d727a668f4161033154b681d78a650

feat(oauth): further discourage use of the iOS app Disables the "Dashboard" button so they can't use it to pull up Ion quickly, and recommends they add the website to their home screen instead.

view details

push time in 4 days

PR merged tjcsl/ion

Further discourage use of the iOS app

Proposed changes

  • Disables the "Dashboard" button when users try to authenticate to the iOS app so they can't use it just to pull up Ion quickly
  • Recommends that users add Ion to their home screen instead

Brief description of rationale

People should not use the unofficial iOS app just to open Ion quickly when we make it easy for them to do this another way.

+8 -1

1 comment

1 changed file

anonymoose2

pr closed time in 4 days

push eventtjcsl/ion

anonymoose2

commit sha a3043a485af940bcd4114fdb405b16dac2c96bbd

fix(printing): add space

view details

anonymoose2

commit sha d1af39158198bae2a18663a8eb1a8de0853953db

feat(printing): recommend PDFs if a .doc/.docx can't be identified

view details

anonymoose2

commit sha 5a7f65365bee52b0d9861201de8ce3b22ac7e53f

test(printing): make sure the printing page renders correctly

view details

push time in 4 days

PR merged tjcsl/ion

Printing tweaks

Proposed changes

  • Add missing space
  • Recommend users convert to a PDF if a file with a .doc or .docx extension can't be identified (has been tested in a development environment)
  • Add a test to make sure the printing page renders correctly

Brief description of rationale

Fixes a bug, adds a test (however minimal), and gives a helpful message to (likely) confused users.

+31 -3

1 comment

4 changed files

anonymoose2

pr closed time in 4 days

pull request commenttjcsl/ion

Printing tweaks

Coverage Status

Coverage increased (+0.2%) to 53.1% when pulling c17a50b6ac9804f4d0bece8d3292a5968a089dc6 on anonymoose2:printing into 2a7ea1b83f53835f333f93de221a980b413d47e8 on tjcsl:dev.

anonymoose2

comment created time in 5 days

PR opened tjcsl/ion

Reviewers
Printing tweaks

Proposed changes

  • Add missing space
  • Recommend users convert to a PDF if a file with a .doc or .docx extension can't be identified (has been tested in a development environment)
  • Add a test to make sure the printing page renders correctly

Brief description of rationale

Fixes a bug, adds a test (however minimal), and gives a helpful message to (likely) confused users.

+31 -3

0 comment

4 changed files

pr created time in 5 days

pull request commenttjcsl/ion

Further discourage use of the iOS app

Coverage Status

Coverage increased (+0.02%) to 52.94% when pulling 83740085d96ae44b4be6f0a33447cab32628b649 on anonymoose2:ios-app into 2a7ea1b83f53835f333f93de221a980b413d47e8 on tjcsl:dev.

anonymoose2

comment created time in 5 days

PR opened tjcsl/ion

Reviewers
Further discourage use of the iOS app

Proposed changes

  • Disables the "Dashboard" button when users try to authenticate to the iOS app so they can't use it just to pull up Ion quickly
  • Recommends that users add Ion to their home screen instead

Brief description of rationale

People should not use the unofficial iOS app just to open Ion quickly when we make it easy for them to do this another way.

+8 -1

0 comment

1 changed file

pr created time in 5 days

push eventtjcsl/ion

Travis

commit sha 7fb24079004ddbb689efe0cccd1521065741af74

Travis build 5359

view details

push time in 5 days

push eventtjcsl/ion

anonymoose2

commit sha 7c40f883b98336e409a4664a2edbff3d562f5180

ci(travis): ignore more Pylint checks The duplicate-code check catches a lot of basic code (imports, queries, etc.) and the cyclic-import check can't really be resolved right now.

view details

anonymoose2

commit sha 91fabdefeb5e035a5c08a28dae972e806ce9658a

fix(groups): only let group admins create groups

view details

anonymoose2

commit sha 2a7ea1b83f53835f333f93de221a980b413d47e8

fix(lostfound): don't let users modify or delete other users' items

view details

push time in 5 days

push eventtjcsl/ion

anonymoose2

commit sha 7c40f883b98336e409a4664a2edbff3d562f5180

ci(travis): ignore more Pylint checks The duplicate-code check catches a lot of basic code (imports, queries, etc.) and the cyclic-import check can't really be resolved right now.

view details

anonymoose2

commit sha 91fabdefeb5e035a5c08a28dae972e806ce9658a

fix(groups): only let group admins create groups

view details

anonymoose2

commit sha 2a7ea1b83f53835f333f93de221a980b413d47e8

fix(lostfound): don't let users modify or delete other users' items

view details

push time in 5 days

push eventtjcsl/ion

Travis

commit sha fb19a77e4581b4a6da9393dda9219700b3f94777

Travis build 5357

view details

push time in 6 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha ef1c4ef743fdb93488fd6c8ef97705bc068a63f8

fix(preferences): disable privacy options form

view details

anonymoose2

commit sha b6b8fa2a47be16cc937703d4874116cf4ac6c909

fix(printing): send_feeback -> send_feedback

view details

push time in 6 days

push eventtjcsl/ion

anonymoose2

commit sha b6b8fa2a47be16cc937703d4874116cf4ac6c909

fix(printing): send_feeback -> send_feedback

view details

push time in 6 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha ef1c4ef743fdb93488fd6c8ef97705bc068a63f8

fix(preferences): disable privacy options form

view details

push time in 6 days

PR merged tjcsl/ion

Remove privacy form

Proposed changes

  • Disables privacy options form.

Brief description of rationale

The form is currently obsolete.

+21 -9

1 comment

2 changed files

theo-o

pr closed time in 6 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha a99a6e1303b537cb83c2491cb71e76dc99c98ff8

fix(preferences): disable privacy options form

view details

push time in 6 days

Pull request review commenttjcsl/ion

Remove privacy form

 <h3>Personal Information</h3>              {% if preferred_pic_form %}             <h3>Preferred Picture</h3>-            <p>Since the eighth period office and TJ faculty can always see your pictures, it is recommended that you choose your preferred picture even if you disable "Show Pictures" in Privacy Options.</p>+            <p>Since the eighth period office and TJ faculty can always see your pictures, it is recommended that you choose your preferred picture.</p>              {% for choice in preferred_pic_form.preferred_photo %}             {{ choice.tag }} {{ choice.choice_label }}<br>             {% endfor %}             <br>             {% endif %} +            {% comment %}

Again, we might want to add comments explaining why this is disabled.

theo-o

comment created time in 6 days

Pull request review commenttjcsl/ion

Remove privacy form

 def preferences_view(request):             preferred_pic_form = PreferredPictureForm(user, initial=preferred_pic)             bus_route_form = BusRouteForm(initial=bus_route) +            """             privacy_options = get_privacy_options(user)-            logger.debug(privacy_options)             privacy_options_form = PrivacyOptionsForm(user, initial=privacy_options)+            """+            privacy_options_form = None

I would disable the call to save_privacy_options() above, if only to be consistent. We might also want to add comments explaining why this is disabled.

theo-o

comment created time in 6 days

pull request commenttjcsl/ion

Remove privacy form

Coverage Status

Coverage decreased (-0.007%) to 53.397% when pulling e5fd4b667e1a437c8ea3fd5c195bfd1f4277a851 on privacy into 60bc4f6e94b1f48740c8adf32980e62ffab05c76 on dev.

theo-o

comment created time in 6 days

PR opened tjcsl/ion

Reviewers
Remove privacy form

Proposed changes

  • Disables privacy options form.

Brief description of rationale

The form is currently obsolete.

+7 -3

0 comment

2 changed files

pr created time in 6 days

create barnchtjcsl/ion

branch : privacy

created branch time in 6 days

push eventtjcsl/ion

Travis

commit sha 1ef9930d7b092b27a56b1ad0ad072af4c6efdb71

Travis build 5350

view details

push time in 6 days

push eventtjcsl/ion

anonymoose2

commit sha 2895ad2c937eaa10a52f99c97aab747ab67b3a69

refactor(dark): show odd eighth activities in lighter color Matches the style of light mode Ion

view details

anonymoose2

commit sha efd93d5e8d8401ae07eae3b49236f1bb03a1b69d

refactor(eighth): attempt to prevent race conditions

view details

Theo Ouzhinski

commit sha dea12e83298b83c8e46febc83b5aa7dcbca2c264

chore(printing): remove unneeded error message && adjust success message

view details

Theo Ouzhinski

commit sha c707089b784261bc865dc87566aa148ac4b71b23

fix(printing): update print form information

view details

Theo Ouzhinski

commit sha 97914761130482a36d775e9c019ebdc801a1f16f

docs(printing): add docstrings to PrintJob model

view details

Theo Ouzhinski

commit sha e8d330a5f62a9727c9632136434839f6bfb97a65

docs(printing): begin adding docstrings to printing

view details

Theo Ouzhinski

commit sha 4dcce8045fd57e057f81566d4168b633091149a8

fix(printing): apply suggestions from review

view details

Theo Ouzhinski

commit sha e54447139072199ab0d83cfff7611ad1f3204145

fix(printing): fix spelling

view details

Invinceaman

commit sha d05ed3a67f8f29be53cdd5ac62dd012011787d53

refactor(preferences): reorganize preferences page Fixes #619

view details

Invinceaman

commit sha 9e54dd7c0cb401560d64be41fca453f73af73c09

refactor(dashboard): move birthdays down in the dashboard Fixes #609

view details

anonymoose2

commit sha f7608b553b96e07385183eb3a1acaf4bd0f709ff

fix(eighth): fix eighth Prometheus metrics

view details

anonymoose2

commit sha ed883165bffe51cee173adebc79630cf095be179

feat(eighth): add metrics for number of duplicate signups

view details

anonymoose2

commit sha bd9878e2a2e2bfa87eaddcb1cbb369c7c25973fe

fix(eighth): fix EighthBlock.previous_blocks()

view details

anonymoose2

commit sha 6e2d3b2f828617021e6315ba8ad4bfe107690134

refactor(meta): point to /static/manifest.json, not /manifest.json

view details

anonymoose2

commit sha d40cdde150fe4aede69dcd555823b59342debb66

refactor(signage): move signage serviceworker.js to static

view details

anonymoose2

commit sha 60bc4f6e94b1f48740c8adf32980e62ffab05c76

fix(eighth): set EighthSignup.own_signup properly

view details

push time in 6 days

issue closedtjcsl/ion

Move birthdays down in the dashboard

closed time in 6 days

theo-o

issue closedtjcsl/ion

Reorg preferences page

We should put more used preferences near the top of the preferences page (mail forwarding/bus route/email addresses).

closed time in 6 days

theo-o

PR merged tjcsl/ion

Miscellaneous fixes

Proposed changes

  • Fix EighthBlock.previous_blocks()
  • Move signage serviceworker.js to static
  • Point to /static/manifest.json instead of /manifest.json in templates
  • Set EighthSignup.own_signup properly

Brief description of rationale

Mostly miscellaneous fixes or improvements.

serviceworker.js and manifest.json are really static files, and we should treat them like it.

+15 -14

1 comment

6 changed files

anonymoose2

pr closed time in 6 days

push eventtjcsl/ion

anonymoose2

commit sha bd9878e2a2e2bfa87eaddcb1cbb369c7c25973fe

fix(eighth): fix EighthBlock.previous_blocks()

view details

anonymoose2

commit sha 6e2d3b2f828617021e6315ba8ad4bfe107690134

refactor(meta): point to /static/manifest.json, not /manifest.json

view details

anonymoose2

commit sha d40cdde150fe4aede69dcd555823b59342debb66

refactor(signage): move signage serviceworker.js to static

view details

anonymoose2

commit sha 60bc4f6e94b1f48740c8adf32980e62ffab05c76

fix(eighth): set EighthSignup.own_signup properly

view details

push time in 6 days

pull request commenttjcsl/ion

Miscellaneous fixes

Coverage Status

Coverage decreased (-0.004%) to 53.404% when pulling 98d0c2c20043998cdf1b99bad1d04c0ad58eacfa on anonymoose2:fixes into ed883165bffe51cee173adebc79630cf095be179 on tjcsl:dev.

anonymoose2

comment created time in 6 days

PR opened tjcsl/ion

Miscellaneous fixes

Proposed changes

  • Fix EighthBlock.previous_blocks()
  • Move signage serviceworker.js to static
  • Point to /static/manifest.json instead of /manifest.json in templates
  • Set EighthSignup.own_signup properly

Brief description of rationale

Mostly miscellaneous fixes or improvements.

serviceworker.js and manifest.json are really static files, and we should treat them like it.

+12 -13

0 comment

5 changed files

pr created time in 6 days

startedtjcsl/cslbot

started time in 7 days

more