profile
viewpoint
tjcsl Fairfax, VA https://tjhsst.edu TJHSST Computer Systems Lab

issue closedtjcsl/ion

View roster button should be hidden for regular students

Users without the ability to view the 8th period roster should not see that button at all.

closed time in a day

theo-o

issue commenttjcsl/ion

View roster button should be hidden for regular students

Withdrawing issue

theo-o

comment created time in a day

push eventtjcsl/ion

Travis

commit sha 18f5e890c970914f223167f6d2e686da35e2427d

Travis build 4630

view details

push time in a day

push eventtjcsl/ion

Travis

commit sha a0d49f23e1e838785ab19a22a8dd347555bc4b80

Travis build 4628

view details

push time in a day

push eventtjcsl/ion

Theo Ouzhinski

commit sha 66a200491a4199aecdb5d2af3f17ff077b19e420

Update ion worker supervisor name

view details

push time in a day

push eventtjcsl/ion

Theo Ouzhinski

commit sha 66a200491a4199aecdb5d2af3f17ff077b19e420

Update ion worker supervisor name

view details

push time in a day

push eventtjcsl/ion

Theo Ouzhinski

commit sha de3c773b033fc2c7e82ed182ea4832a2dc944632

Update more dates

view details

push time in a day

push eventtjcsl/ion

Theo Ouzhinski

commit sha de3c773b033fc2c7e82ed182ea4832a2dc944632

Update more dates

view details

push time in a day

issue openedtjcsl/ion

View roster button should be hidden for regular students

Users without the ability to view the 8th period roster should not see that button at all.

created time in 2 days

issue openedtjcsl/ion

Introduce mandatory announcements

Allow users to request announcements that must be broadcast to the entire school, regardless of preference settings. This will likely be restricted to admin, and confirmation via a dialog by an announcements admin should be received before being accepted.

created time in 2 days

issue openedtjcsl/ion

Respect user primary email for announcement notifications

https://github.com/tjcsl/ion/blob/c3c719bdf3180ac23821775b1565ad4d2e1a92c2/intranet/apps/announcements/notifications.py#L136

We currently do not respect user.primary_email when sending notifications to students.

created time in 2 days

issue openedtjcsl/ion

Prohibit setting fcpsschools.net addresses as email

Includes not sending notifications to fcpsschools.net. Should also prohibit users from having one as well.

created time in 2 days

push eventtjcsl/website

anonymoose2

commit sha c6efd6e230933c691b2917301b4aac3f9d291414

Display nickname in course string

view details

push time in 3 days

push eventtjcsl/website

anonymoose2

commit sha 6a0a41005a8c7058660363e866537275cefc0c0b

Reduce the size at which the navbar collapses

view details

anonymoose2

commit sha 76df447f8c047d622994580d76514f89bef905d1

Fix login button styling

view details

anonymoose2

commit sha 17d50566764acfe5b08215b9ff047a867531ed23

Change the number of columns on the labs page at smaller screen sizes

view details

anonymoose2

commit sha f28484fef2662f72385616a5ac8fad09083e8c72

Fix lab alignment on lab list page

view details

push time in 3 days

push eventtjcsl/ion

Travis

commit sha 235859a98abae0051af278e17c975a4ade9d2da7

Travis build 4625

view details

push time in 4 days

push eventtjcsl/ion

ovkulkarni

commit sha c3c719bdf3180ac23821775b1565ad4d2e1a92c2

update dates

view details

push time in 4 days

push eventtjcsl/ion

ovkulkarni

commit sha c3c719bdf3180ac23821775b1565ad4d2e1a92c2

update dates

view details

push time in 4 days

push eventtjcsl/ion

Travis

commit sha 93523b867614ccce326b88992a4ef593eba73144

Travis build 4624

view details

push time in 4 days

push eventtjcsl/ion

ovkulkarni

commit sha 4c48f0341b568d05bfdf397fd9d5644f827f6e4b

update for 2019-20

view details

push time in 4 days

push eventtjcsl/ion

ovkulkarni

commit sha 4c48f0341b568d05bfdf397fd9d5644f827f6e4b

update for 2019-20

view details

push time in 4 days

push eventtjcsl/website

anonymoose2

commit sha 11e100a56c02d4d7a55efc8a02afd73065d045bd

Add a 'nickname' field to courses and use it where space is limited Also add a script to set the nickname for all courses without it set

view details

push time in 5 days

push eventtjcsl/gitbook

Jack Duvall

commit sha b5c70234fb89ae4d18e1c773860812774018de0c

compute stick small update

view details

push time in 5 days

push eventtjcsl/website

anonymoose2

commit sha 5abb9c6460b35e0d0e01b58f89c55e87f49b5cc6

Order course list in "Find labs" page by name

view details

push time in 5 days

push eventtjcsl/website

Keegan

commit sha 2d5a379e07789fb0619dfb2c2aeda759b6fd9f33

Fix Masonry View

view details

Keegan

commit sha b8510aaa2d3998972545b7da48009012054f208e

Merge branch 'master' of https://github.com/tjcsl/website

view details

push time in 5 days

push eventtjcsl/website

anonymoose2

commit sha dd0d44e38fcc21325121d817a18444448c0cf31b

When the navbar is collapsed, show the search bar at the top

view details

push time in 5 days

push eventtjcsl/website

anonymoose2

commit sha 0139d0decd0e451359d4b8df9bf305867bf252f7

Tweak "Clubs" and "Labs" links

view details

push time in 5 days

push eventtjcsl/website

unknown

commit sha d1e499627d22ea10dffee9e3f3d23353753b4475

add clubs and labs link

view details

Keegan Lanzillotta

commit sha 16b038380720cac7e4a73622409adbf1ee93fc67

Merge pull request #17 from Laur04/master add clubs and labs link

view details

push time in 5 days

PR merged tjcsl/website

add clubs and labs link
+13 -2

0 comment

2 changed files

Laur04

pr closed time in 5 days

PR opened tjcsl/website

add clubs and labs link
+13 -2

0 comment

2 changed files

pr created time in 5 days

push eventtjcsl/website

Invinceaman

commit sha fa6da49de835ebff6d50cba7ce48a2581152ec4f

Display labs in Masonry layout

view details

Keegan

commit sha 67dd0bb1b312f97daa85930154303c42d2c0a4ad

Merge branch 'master' of https://github.com/tjcsl/website

view details

push time in 5 days

push eventtjcsl/gitbook

Theo Ouzhinski

commit sha c9b5230f3a09ff107b90adce3ac96320aab1b0a6

Document rename from earlier this year

view details

push time in 6 days

push eventtjcsl/website

anonymoose2

commit sha b6f5a2d97dc5462444f44bfebeb14300fc6afaf0

Set padding for submit button in search field

view details

push time in 7 days

push eventtjcsl/website

anonymoose2

commit sha ee8a7738b2ac9ddca0257789c671a40cee1c0104

Serve up most static resources locally

view details

anonymoose2

commit sha 44f6e1dc4c750f14f11227244978f8adb61c5e8c

Merge branch 'master' of github.com:tjcsl/website

view details

push time in 7 days

push eventtjcsl/gitbook

Jack Duvall

commit sha 3cdc7f930ef8611ad75df5912c52c7700b483308

advanced computing

view details

push time in 7 days

push eventtjcsl/website

Invinceaman

commit sha 8744129b96e63760b7a494ba1a53f03945173457

Display recommended courses only when necessary

view details

anonymoose2

commit sha 68b2d3ebd5ce958518e486c27e101daabe9be461

Merge pull request #16 from Invinceaman/master Display recommended courses only when necessary

view details

push time in 7 days

PR opened tjcsl/website

Display recommended courses only when necessary
+8 -6

0 comment

1 changed file

pr created time in 7 days

push eventtjcsl/website

anonymoose2

commit sha 2990e6e15169af492f0ae77d35d52f343031a32a

Fix bug in search field when menu is collapsed

view details

push time in 7 days

push eventtjcsl/website

Invinceaman

commit sha 87c9e5fbc93840335b3f45935a773a96f7f9cd93

Make recommended courses optional

view details

push time in 7 days

push eventtjcsl/website

anonymoose2

commit sha 8fefa6a752f79646214e1bb667f6d8b5f7e5ac2b

Add a navbar toggle button on small screens

view details

push time in 7 days

push eventtjcsl/website

anonymoose2

commit sha b1b50abf9152da102173e24cddc27980253fb062

Add margins to make background image expand

view details

anonymoose2

commit sha 23840ca262a593037c79faeb5c53634473872e72

Consistent CSS formatting

view details

push time in 7 days

push eventtjcsl/website

anonymoose2

commit sha 0518afb56b650ba13f370a60bacd43268c443b77

Add margin and drop shadow to labs list page

view details

push time in 7 days

push eventtjcsl/website

Invinceaman

commit sha 179ec8eff8df7ec61e13e0561fc464836e4e21a1

Organize find labs page in rows of 3

view details

anonymoose2

commit sha 3dbded16e4971f02d00e36603e4853908b695eee

Merge pull request #15 from Invinceaman/master Organize find labs page in rows of 3

view details

push time in 7 days

PR merged tjcsl/website

Organize find labs page in rows of 3
+27 -7

0 comment

4 changed files

Invinceaman

pr closed time in 7 days

push eventtjcsl/website

Theo Ouzhinski

commit sha 65844e316e565f1010c6cc1a8ed0de60f97e1c7b

Add documentation What is a documentation lead who doesn't document?

view details

push time in 8 days

Pull request review commenttjcsl/website

Organize find labs page in rows of 3

  {% block main %}     <div>{{ labs|length }} lab{{ labs|length|pluralize:",s" }}</div>-+    <div><a href="find">

We definitely need a link to /labs/find somewhere, but I see a few problems here:

  1. Hardcoding URLs is bad practice in Django. If you use <a href="{% url 'labs:find' %}"> instead, then it will always use the correct URL even if we change it in urls.py.
  2. Don't put the <h5> inside the <a>, put the <a> inside the <h5>. Block elements (like <h1>, <h2>, etc.) take up the full width of their container, so putting a link around them not only makes their contents (here, the text "Find your labs!") into a link, it makes that entire line (a strip extending to the right edge of the screen) clickable.
  3. I think there are certain contexts in which this template is used (search page?) in which an argument could be made for excluding the link on that specific page. I'm not saying you should change it now, but that's something we should discuss in-person with the entire team.
Invinceaman

comment created time in 8 days

Pull request review commenttjcsl/website

Organize find labs page in rows of 3

 {% block main %}     <h2>Courses</h2>     <form>+        <table>

I agree the list should be split int columns, but using tables simply to create a columned layout is generally considered bad practice. I would recommend using a Boostrap grid for this. If you want to see an example, this is a good one: https://github.com/tjcsl/website/blob/195327c50c470a6f084eb5026a7c1803973a072d/tjhsst/templates/labs/list.html

Really quick summary: You add the row class to the container, then add col-* classes to all of the children.

In the col-*, classes, the number denotes the number of columns (out of 12) the child will span. For example, col-3 will span 3/12 columns, or 25%; col-4 will span 4/12 columns, or 33%; etc.

You can also use the sm, md, lg, and xl prefixes, which denote what container widths these should apply to (which will let you you have the number of columns change as the user resizes the window). There's some documentation on them here: https://getbootstrap.com/docs/4.0/layout/grid/#grid-options. To start, I would recommend using something like col-12 col-sm-6 col-md-4 col-lg-3 (though you will probably want to tweak that).

Invinceaman

comment created time in 8 days

PR opened tjcsl/website

Organize find labs page in rows of 3
+30 -5

0 comment

4 changed files

pr created time in 8 days

push eventtjcsl/ion

Travis

commit sha a33fb10d8d76c611e9f2c4879117ca7e513f3607

Travis build 4622

view details

push time in 11 days

push eventtjcsl/website

unknown

commit sha 0d3b65a488e646dd89c3af8cc86f4b0ff61c2e1d

add login button if users aren't logged in

view details

unknown

commit sha 502aa36f155bfed962dbcd638d79fec3e08c9719

add back button and styling to club edit page

view details

unknown

commit sha 35de3b55b39513f84ea203764502cfedd9cd6df6

fix issues with pr

view details

unknown

commit sha 433af85fd8ad3818aac6d3fbadbe654d29b4ea6e

fix issues with pr

view details

Keegan Lanzillotta

commit sha 672da7f8250f69839b3fc59ff028b0209e95fc51

Merge branch 'master' into master

view details

Keegan Lanzillotta

commit sha f3a1d2f723d48806caff5b81bee78ec460d22a4a

Merge pull request #12 from Laur04/master Add login button to header, add back button/styling to edit page

view details

push time in 11 days

push eventtjcsl/website

Keegan

commit sha db171158c3c6546c8b04428bc7557e153bc41fa0

Create Course Pages

view details

Keegan

commit sha a1c43c1073773a028e033e666769282d0ebed2a7

Style Course Page

view details

Keegan

commit sha 195327c50c470a6f084eb5026a7c1803973a072d

Link to Course pages from Find results

view details

push time in 11 days

CommitCommentEvent

push eventtjcsl/website

anonymoose2

commit sha 432031a19a04e51333ed16c9dd5210fa9c6d6133

Better Django queries

view details

anonymoose2

commit sha eee5bb9e615c0231db725fa8571b71cb02fe75c4

Display the lab description in the listing

view details

push time in 11 days

push eventtjcsl/website

Keegan

commit sha 3b2b09c0a10342ab45acd8046e325177096ab18a

Weight Lab Search Results

view details

push time in 11 days

push eventtjcsl/website

anonymoose2

commit sha b810174499444d89d0536fe6fb4d4ff1063c9b21

More migration conflicts

view details

push time in 11 days

push eventtjcsl/website

anonymoose2

commit sha f12081940e1e214b0ed2ff635117f1b9d7152667

Increase length limits on keywords, categories, and courses

view details

push time in 11 days

push eventtjcsl/website

anonymoose2

commit sha f724c48a2741921be24a1f47b46d4fd18b3a2eaf

Resolve migration conflicts Note to self: Always makemigrations before you push Note to whoever generated the conflicting migration: Always push after you makemigrations

view details

push time in 11 days

push eventtjcsl/website

anonymoose2

commit sha c817de342b571934eea4c17f2e461ad0d08632dd

Add "<number> lab(s)" text back

view details

push time in 11 days

push eventtjcsl/website

anonymoose2

commit sha 8ade4478e316774437b9e9e664cea0f9de5d3e5c

Make the "find by course" results page also the index; add styling

view details

push time in 11 days

push eventtjcsl/website

Akash Bhave

commit sha 14b77a8af5f2bd7a07320e59e964f061a2680498

Make club image display full width

view details

push time in 11 days

push eventtjcsl/website

anonymoose2

commit sha 65ffdcff5f7c437e6367318750f7a74ee0c5e766

Improve "Find labs by courses" results page

view details

push time in 11 days

push eventtjcsl/website

anonymoose2

commit sha c7a417c6c53fb8d778c4f887c7d030ace35bc32a

Formatting

view details

anonymoose2

commit sha e4b3a9ec2c4b39b5e0624576d3947075f081b526

Merge branch 'master' of github.com:tjcsl/website

view details

push time in 11 days

push eventtjcsl/website

Akash Bhave

commit sha 98682253da3719fffba93e6c95e4ff2d7a519ed9

Change primary font to Heebo

view details

push time in 11 days

push eventtjcsl/website

anonymoose2

commit sha 3b4808528166cd79179aaf4913ed698acdc898b1

Delete height and width fields on labs; apply changes I forgot to migrate

view details

push time in 11 days

Pull request review commenttjcsl/website

Add login button to header, add back button/styling to edit page

 <h2>{{ club_form.errors }}</h2>             {% for field in club_form %}                 <div class="tbl-row">                     <span class="tbl-cell bold" style="vertical-align:top;padding-right:5px;">{{ field.label_tag }}</span>-                    <span class="tbl-cell">{{ field }}</span>+                    <span class="tbl-cell" style="padding-top:5px">{{ field }}</span>                 </div>             {% endfor %}         </div>-        <input type="submit" value="Save">+        <input style="background-color: #3366FF;padding:5px 10px;border:none;margin:3px;font-size:20px;" type="submit" value="Save">+        <a href="{% url 'clubs:show' club.url %}"><input style="background-color:  rgba(221, 64, 58, 1);padding:5px 10px;border:none;margin:3px;font-size:20px;" type="button" value="Back"></a>

I fixed these issues and pushed, so this should be good.

Laur04

comment created time in 11 days

push eventtjcsl/website

Invinceaman

commit sha 5b6f6dfac0112f409fef515cc8a6252bd199528f

Create course results page

view details

anonymoose2

commit sha b28273348854421d41a0fb7a6269ea6f24e3e8fd

Merge pull request #14 from Invinceaman/master Create course results page

view details

push time in 11 days

PR merged tjcsl/website

Create course results page
+30 -14

0 comment

2 changed files

Invinceaman

pr closed time in 11 days

PR opened tjcsl/website

Create course results page
+30 -14

0 comment

2 changed files

pr created time in 11 days

push eventtjcsl/website

anonymoose2

commit sha 768714b602001346c8ad91d6e9d919fc688d0178

Add "new lab" and "edit lab" pages; miscellaneous fixes and tweaks

view details

push time in 11 days

push eventtjcsl/website

Invinceaman

commit sha 0ae571446939163b606035b5cdb2785d3fc3b345

Start find labs page

view details

anonymoose2

commit sha 396e3f3c49a8f06d98e6c33d663a1d5e0b8f5ac5

Merge pull request #13 from Invinceaman/master

view details

push time in 11 days

PR merged tjcsl/website

Start find labs page
+35 -2

0 comment

4 changed files

Invinceaman

pr closed time in 11 days

PR opened tjcsl/website

Start find labs page
+19 -2

0 comment

3 changed files

pr created time in 11 days

push eventtjcsl/gitbook

Theo Ouzhinski

commit sha c2b36f23c0e1e285a91c8884ba2584f0a05fec89

GitBook: [master] 2 pages modified

view details

push time in 12 days

Pull request review commenttjcsl/website

Add login button to header, add back button/styling to edit page

 <h1>TJHSST</h1>                             <button type="submit" class="search-button"><i class="fa fa-search"></i></button>                         </form>                     </li>+                {% else %}+                    <li>+                        <span class="navbar-text" style="color:rgb(255,255,255)"><a href="{% url 'auth:login' %}">Login</a></span>
  1. I think you meant to add this to the if tag a few lines down.
  2. From testing with this addition moved down there, this link feels out of place (and the default underline-on-hover behavior feels wrong). Perhaps further discussion is needed.
  3. It turns out setting the color explicitly is unnecessary (it's set by Bootstrap). I know it's done in the username label a few lines down, but we should remove that too.
Laur04

comment created time in 12 days

Pull request review commenttjcsl/website

Add login button to header, add back button/styling to edit page

 <h2>{{ club_form.errors }}</h2>             {% for field in club_form %}                 <div class="tbl-row">                     <span class="tbl-cell bold" style="vertical-align:top;padding-right:5px;">{{ field.label_tag }}</span>-                    <span class="tbl-cell">{{ field }}</span>+                    <span class="tbl-cell" style="padding-top:5px">{{ field }}</span>

I don't feel like this is really necessary. Again, further discussion needed.

Laur04

comment created time in 12 days

Pull request review commenttjcsl/website

Add login button to header, add back button/styling to edit page

 <h2>{{ club_form.errors }}</h2>             {% for field in club_form %}                 <div class="tbl-row">                     <span class="tbl-cell bold" style="vertical-align:top;padding-right:5px;">{{ field.label_tag }}</span>-                    <span class="tbl-cell">{{ field }}</span>+                    <span class="tbl-cell" style="padding-top:5px">{{ field }}</span>                 </div>             {% endfor %}         </div>-        <input type="submit" value="Save">+        <input style="background-color: #3366FF;padding:5px 10px;border:none;margin:3px;font-size:20px;" type="submit" value="Save">+        <a href="{% url 'clubs:show' club.url %}"><input style="background-color:  rgba(221, 64, 58, 1);padding:5px 10px;border:none;margin:3px;font-size:20px;" type="button" value="Back"></a>
  1. Please delete the <input type="button"> and just make the back button a link.
  2. If we do style buttons, then 1) we will want that to be site-wide so it's consistent and 2) we will probably want to copy Ion's styling, not make our own.
Laur04

comment created time in 12 days

PR opened tjcsl/website

Add login button to header, add back button/styling to edit page
+7 -3

0 comment

3 changed files

pr created time in 12 days

PR closed tjcsl/website

add login button if users aren't logged in
+7 -3

0 comment

3 changed files

Laur04

pr closed time in 12 days

push eventtjcsl/gitbook

Jack Duvall

commit sha e7ca640c9b178c3bc6ca9bccd82ad71592dbe1ba

Add compute stick data

view details

push time in 13 days

PR opened tjcsl/website

add login button if users aren't logged in
+4 -0

0 comment

1 changed file

pr created time in 13 days

push eventtjcsl/website

Keegan

commit sha 8ac485f86fc55cabb143917ce0b044728aaac22e

Update secret.sample for Ion OAUTH

view details

push time in 13 days

push eventtjcsl/ion

Travis

commit sha e4917b8a0f92fbac9d678d9caa439775528faacc

Travis build 4621

view details

push time in 14 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 4e139deaf11cdb3cd60eb7da99ff0206be621732

Add 2019 AP schedule

view details

push time in 14 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 4e139deaf11cdb3cd60eb7da99ff0206be621732

Add 2019 AP schedule

view details

push time in 16 days

startedtjcsl/ion

started time in 16 days

push eventtjcsl/ion

Travis

commit sha 9787801ca678fae6b151163809148b569de55eda

Travis build 4618

view details

push time in 16 days

push eventtjcsl/ion

Travis

commit sha 7ecb929e5168be38fb2f2f85a6dfe6655ee77c07

Travis build 4617

view details

push time in 16 days

push eventtjcsl/ion

ovkulkarni

commit sha b9f67228087ea36512279e166764cd5fd5c95744

bump reqs

view details

push time in 16 days

push eventtjcsl/ion

ovkulkarni

commit sha b9f67228087ea36512279e166764cd5fd5c95744

bump reqs

view details

push time in 16 days

push eventtjcsl/ion

anonymoose2

commit sha f0370c25f086a38c5528417cb72d2f62a1a3fa83

Set type attribute for "Day Name" field on schedule daytype field

view details

anonymoose2

commit sha ef295f540aeee91263a818a25c64bd7c9fa2ed1b

Allow the user to set a null bus route on the preferences page This allows people to save the preferences page without setting a bus route

view details

anonymoose2

commit sha 3ee40e8d68d82809887c3c27b3d87a7d8bde577a

Add bus route preferences tests

view details

Theo Ouzhinski

commit sha 004a3b58c3837470c2b1c298d590fa2413eb6890

Hide AP week warning

view details

Theo Ouzhinski

commit sha e9ba9a650bd0429e19cd71d89ecaf16de45d03d1

Attempt to fix flake8

view details

push time in 16 days

PR merged tjcsl/ion

Dev
+23 -8

1 comment

5 changed files

theo-o

pr closed time in 16 days

pull request commenttjcsl/ion

Dev

Coverage Status

Coverage increased (+0.1%) to 42.78% when pulling e9ba9a650bd0429e19cd71d89ecaf16de45d03d1 on dev into 5d722b0725d572039bb0929fd5715a4070c82c72 on master.

theo-o

comment created time in 16 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha e9ba9a650bd0429e19cd71d89ecaf16de45d03d1

Attempt to fix flake8

view details

push time in 16 days

issue openedtjcsl/ion

Allow configuring AP exam schedule

Allow uploading a CSV or equivalent form to populate the AP schedule

created time in 16 days

PR opened tjcsl/ion

Reviewers
Dev
+22 -7

0 comment

5 changed files

pr created time in 16 days

push eventtjcsl/ion

Theo Ouzhinski

commit sha 004a3b58c3837470c2b1c298d590fa2413eb6890

Hide AP week warning

view details

push time in 16 days

push eventtjcsl/ion

Travis

commit sha e54ea0300614d3cdfaef2a7f641eaa88e32dd438

Travis build 4612

view details

push time in 18 days

more