profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/timsetsfire/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Timothy Whittaker timsetsfire datarobot PIttsburgh, PA

datarobot/datarobot-user-models 30

User's custom models boilerplate

AlbertDeFusco/neural-networks-from-scratch 9

Building neural networks with NumPy

timsetsfire/regression-from-scratch 5

demonstrate how to do regression from scratch in python

timsetsfire/gans-from-scratch 3

GANS from scratch in Scala

timsetsfire/breeze-enets 2

GLMs and RLMs with elastic net regularization for Scala

push eventdatarobot/datarobot-user-models

Carson Gee

commit sha 84f99c321d00bb764a2453ccc59253903e64e505

[YOLO] Try xdist out for test performance (#365) * handle server shutdown error * fix typeschema tests to work with xdist * properly implement JavaPredictor failure test Co-authored-by: Yakov Goldberg <yakov.goldberg@datarobot.com>

view details

push time in 3 days

delete branch datarobot/datarobot-user-models

delete branch : carsongee/add_xdist

delete time in 3 days

PR merged datarobot/datarobot-user-models

[YOLO] Try xdist out for test performance 00 - Ready for Review

This repository is public. Do not put here any private DataRobot or customer's data: code, datasets, model artifacts, .etc.

Summary

Attempt to speed up integration tests using xdist

Rationale

🏃

+91 -33

6 comments

6 changed files

carsongee

pr closed time in 3 days

pull request commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

Label Needs Review: Custom Models was removed because @yakov-g is part of Custom Models domain.

carsongee

comment created time in 3 days

Pull request review commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

 def single_value_conditions(cls) -> List["Conditions"]:             cls.NOT_LESS_THAN,         ] +    @classmethod

DONE

carsongee

comment created time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha 1df8ec7a02ba7f2cdd62dc67e2a2f0707b67f30e

handle server shutdown error - 2

view details

Yakov Goldberg

commit sha e3a0b5e820d099abee7cf7403184aef3ca766673

fix typeschema tests to work with xdist

view details

Yakov Goldberg

commit sha eca3afac3421ea6f6b0e1972eed9a785c38740d2

properly implement JavaPredictor failure test

view details

push time in 3 days

Pull request review commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

 def single_value_conditions(cls) -> List["Conditions"]:             cls.NOT_LESS_THAN,         ] +    @classmethod

if they need to be imported, maybe make a constants file in the unit test directory?

carsongee

comment created time in 3 days

Pull request review commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

 def input_values(cls) -> List["Values"]:     def output_values(cls) -> List["Values"]:         return [cls.NEVER, cls.DYNAMIC, cls.ALWAYS, cls.IDENTITY] +    @classmethod

same comment as above, please move to the tests which are the only place they're used

carsongee

comment created time in 3 days

Pull request review commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

 def single_value_conditions(cls) -> List["Conditions"]:             cls.NOT_LESS_THAN,         ] +    @classmethod

these added class methods aren't really useful in any way, they are only for a uniti test suite. can we just make them constants within the unit tests, please. having them here, will just confuse any future users.

also, this isn't numeric conditions, it's ONLY_FOR_NUMERIC

carsongee

comment created time in 3 days

pull request commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

jarvis test cmrunner_integration

carsongee

comment created time in 3 days

Pull request review commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

 def variety_resources(     resource.target = get_variety_target     resource.class_labels = get_variety_classes_labels     return resource+++@pytest.fixture

moved fixtures back

carsongee

comment created time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha 18f01c50f0003b1d8453dbea2d9bc4eb39f2df66

fix typeschema tests to work with xdist

view details

Yakov Goldberg

commit sha c6393d7db0dba6fc6417845d9897f32036c818b6

properly implement JavaPredictor failure test

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha b4d1c43396635d4a23130cb52a80510d4858325b

fix typeschema tests to work with xdist

view details

Yakov Goldberg

commit sha 29965b46c0e8ec7f301f9e76ca9b05dc04364fe0

properly implement JavaPredictor failure test

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha bf839c1dcf33693bb41bd2d0d21ed1c096679d74

fix typeschema tests to work with xdist

view details

Yakov Goldberg

commit sha c83d1cbf81e30165431943b9b197910ff35a4409

properly implement JavaPredictor failure test

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha 7394356c1030853092f69081e8e5aee444032f97

fix typeschema tests to work with xdist

view details

Yakov Goldberg

commit sha a7ea32027f5079753df4f2e4c602adf604048b9a

properly implement JavaPredictor failure test

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha e9450adb1a973dff2f9973520e83def4d56b8b47

fix typeschema tests to work with xdist

view details

Yakov Goldberg

commit sha 516b70e03d5949117727b764e170e461a38b0f41

properly implement JavaPredictor failure test

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha 8128ec54bed590003008718e699f75ca6b576b94

comment out xdist config

view details

Yakov Goldberg

commit sha 31a9449da018e076ef5bb1c273154be0d765d969

add -n auto for inference

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha dc89e32a510e7cae7f72f429cfbdf8e35d97f69f

redo java test

view details

Yakov Goldberg

commit sha f51cf9662df14152be3d7114f103464a2fec7ad5

comment out xdist config

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha b1d5ce3b6b7f7f0d77a176c4ee4d0f952eb91a05

only java predictor

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha 2f5635f1fd763b89c919f64c38a70fece77c05b9

only java predictor

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha c4342b5ab49091e8184697773791131070cb2fd6

all but the inference

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha e4a55b7f9c0451e0706aa43d0745bc65d0895119

run only inference

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha 532d70edc4d5524a19f00f6ecc427c97d60d98fd

try to imlement typeschema enums

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha 5953e38c997dc085f70b19a47e226058608188df

try to imlement typeschema enums

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha a315626fc8d8c64ea4fe886f7eb73bb4c75abe8b

try to imlement typeschema enums

view details

push time in 3 days

push eventdatarobot/datarobot-user-models

Yakov Goldberg

commit sha 763540c6f07a1bef7a83d0b0cb5a60135d92436f

try to imlement typeschema enums

view details

Yakov Goldberg

commit sha 5ea8673498e25c8e0c109217db5d482ff6eb1be7

uncomment numeric

view details

push time in 3 days

pull request commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

jarvis test cmrunner_integration

carsongee

comment created time in 3 days

pull request commentdatarobot/datarobot-user-models

[RAPTOR-5588] Fix R fit bug when handling single-col data

jarvis test cmrunner_integration

jmbannon

comment created time in 3 days

pull request commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

@eric-s-s I'm trying to start running pytest in parallel to decrease test time. I had to comment out some of the test cases, because of the way parametrization is done. Could you tell me what would be the best approach to change it? Just define lists statically?

You can try to uncomment a test case and run it locally using: pytest ./tests/drum/ -n auto, you'll see it fails to collect tests.

just install pytest-xdist

i have no idea. my first go-to solution would be to make them global constants right above the test they're used in: have you tried this?



NUMERIC_CONDITIONS = list(set(Conditions) - set(Conditions.non_numeric()))
# if it needs to be more deterministic
NUMERIC_CONDITIONS = sorted(set(Conditions) - set(Conditions.non_numeric()), key=lambda el: el.name)


class TestSomething
    @pytest.mark.parametrize("condition", NUMERIC_CONDITIONS)
    def test_datatypes_unallowed_conditions(self, condition):
        values = [Values.NUM, Values.TXT]
        input_data_type_str = input_requirements_yaml(self.field, condition, values)


also, another option is to run unit tests in series. they take less than 1 second to run

carsongee

comment created time in 3 days

Pull request review commentdatarobot/datarobot-user-models

[YOLO] Try xdist out for test performance

 def variety_resources(     resource.target = get_variety_target     resource.class_labels = get_variety_classes_labels     return resource+++@pytest.fixture

is there a need to move these? if not, it would save time for the reader to leave them closer to where the tests are. maybe in tests/drum/unit/conftest.py if you want to move them out of the test itself?

carsongee

comment created time in 3 days