profile
viewpoint
Tommy Nguyen tido64 @Microsoft Oslo, Norway https://github.com/tido64 Software Engineer @Microsoft

facebook/react-native 91871

A framework for building native apps with React.

react-native-async-storage/async-storage 2167

An asynchronous, persistent, key-value storage system for React Native.

microsoft/react-native-macos 1479

A framework for building native macOS apps with React.

petterh/react-native-android-activity 200

Sample: Start an Android activity or an iOS view controller from React Native JavaScript.

microsoft/react-native-test-app 73

react-native-test-app provides a test app for all supported platforms as a package

tido64/ngene 1

ngene is a generic genetic algorithm written in C++. The focus lies on performance, as well as making the engine as modular as possible while maintaining cross-platform compatibility. Ngene is built to be flexible from the ground up, and should be applicable in most, if not all, areas. Ngene is extended by writing plugins and setting it up through a configuration file. Some modules such as single point crossover, random mutation and tournament selection are already written and may serve as an example for how Ngene can be extended. This project is a part of a master's thesis written for Norwegian University of Science and Technology in Trondheim, Norway.

tido64/panini 1

panini 🥪 is a dumb-as-bread INI file reader with a SAX-like interface.

AnastasiaOrishchenko/react-native-test-app 0

react-native-test-app provides a test app for all supported platforms as a package

oliviacaraiman/react-native-webview 0

React Native Cross-Platform WebView

tido64/Box2D 0

Box2D is a 2D physics engine for games

issue openedreact-native-async-storage/async-storage

"Attempt to re-open an already-closed object: SQLiteDatabase" error on a Play Store pre-launch tests

Current behavior

In a process of releasing a bundle to the Play Store, I received an errors on a pre-launch tests. It shows up as : «attempt to re-open an already-closed object: SQLiteDatabase /data/user/0/com.app/databases/RKStorage»

Expected behavior

App should not get any errors.

Repro steps

I've got two separate angles at which we can look at this problem.

  1. Automated Sentry error response:

My Sentry error system caught an exception, which may happen then an app has been closed after being put into a background (by pressing Home, I guess)

image

At first glance, the app is already to be closed, so why even bother? I don't know what the user actually saw, which makes me worry a bit. It doesn't happen before.

  1. Pre-launch tests from Play Store

Also, there are pre-launch tests, which are mandatory before uploading an app to the Play Store. They are basically the same.

image

Related issue - https://github.com/firebase/quickstart-unity/issues/861.

Looks like a problem with pre-release test code on a Google side. But worth looking at any way, cause 'async-library' being caught in an error log.

Thanks!

Environment

  • Platforms tested:
    • [8.1.0] Android Nokia 1
    • [ ] iOS
    • [ ] macOS
    • [ ] Windows
  • AsyncStorage version: 1.12.1
  • Environment: react-native: =0.63.3 => 0.63.3
  • Logs/Errors that may be relevant:
An error occurred while executing doInBackground()

android.os.AsyncTask$3 in done at line 353

    java.util.concurrent.FutureTask in finishCompletion at line 383
    java.util.concurrent.FutureTask in setException at line 252
    java.util.concurrent.FutureTask in run at line 271
    com.reactnativecommunity.asyncstorage.AsyncStorageModule$SerialExecutor$1 in run at line 63
    java.util.concurrent.ThreadPoolExecutor in runWorker at line 1162
    java.util.concurrent.ThreadPoolExecutor$Worker in run at line 636
    java.lang.Thread in run at line 764
IllegalStateException

attempt to re-open an already-closed object: SQLiteDatabase: /data/user/0/com.invitor.client/databases/RKStorage
    android.database.sqlite.SQLiteClosable in acquireReference at line 55
    android.database.sqlite.SQLiteDatabase in compileStatement at line 1068
    com.reactnativecommunity.asyncstorage.AsyncStorageModule$2 in doInBackgroundGuarded at line 228
    com.reactnativecommunity.asyncstorage.AsyncStorageModule$2 in doInBackgroundGuarded at line 219
    com.facebook.react.bridge.GuardedAsyncTask in doInBackground at line 36
    com.facebook.react.bridge.GuardedAsyncTask in doInBackground at line 20
    android.os.AsyncTask$2 in call at line 333
    java.util.concurrent.FutureTask in run at line 266
    com.reactnativecommunity.asyncstorage.AsyncStorageModule$SerialExecutor$1 in run at line 63
    java.util.concurrent.ThreadPoolExecutor in runWorker at line 1162
    java.util.concurrent.ThreadPoolExecutor$Worker in run at line 636
    java.lang.Thread in run at line 764

created time in 21 minutes

PublicEvent

issue commentreact-native-community/releases

Upcoming v0.63.4 cherrypicks discussion

hey folks - quick update: I finally got some time to spare to dedicate to this, I've done the cherry pick (see details above, I managed to pick everything but the last one listed about Modal's onDismiss), and local testing. Everything went fairly smoothly and all was good during testing 👍

I'm now updating the remote branch so that CI can also run its tests and I'll ask to the other maintainers if they can double check / run a local test on their machine just to make sure.

Since it's Friday at this point I'd guess Monday I'll be able to get the release out.

kelset

comment created time in 2 hours

delete branch react-native-async-storage/async-storage

delete branch : chore/config-cleanup

delete time in 2 hours

push eventreact-native-async-storage/async-storage

Krzysztof

commit sha 02e56ba66548f8f4b8b6a70e58b768c9779f28c0

chore: Script files cleanup (#497)

view details

push time in 2 hours

PR merged react-native-async-storage/async-storage

chore: Script files cleanup

Summary

Naming and location of scripts/commands was not good, so did a small cleanup.

  • Moved .circleci/scripts content to scripts in root (and renamed them to platform_e2e)
  • Each script contains all necessary functionality for e2e (like bulding apk/ipa, running emulator)

Test Plan

Green CI.

+62 -57

0 comment

5 changed files

Krizzu

pr closed time in 2 hours

Pull request review commentreact-native-async-storage/async-storage

chore: Script files cleanup

 #!/bin/bash

Good point, but let's do it as a follow up PR

Krizzu

comment created time in 2 hours

push eventreact-native-community/releases

Lorenzo Sciandra

commit sha b74d175964603691b3a0b8c1eb2dab808d136d12

[docs] add note about catalina auths

view details

push time in 4 hours

issue commentreact-native-community/releases

Road to v0.64 Discussion

@lorenzoangelini looks like the issue is caused by lottie-react-native so I'd try to interface with the maintainers of that library and find out if on a fresh project that same issue is present (rc.1 + lottie). It could be that lottie needs to update something on their side.

grabbou

comment created time in 5 hours

created repositorykeijiro/AssetBundleBenchmark

created time in 5 hours

issue commentreact-native-community/releases

Road to v0.64 Discussion

@lorenzoangelini one way to be sure, is to install your package in a freshly install RN0.64.1 project.

grabbou

comment created time in 9 hours

issue commentreact-native-community/releases

Road to v0.64 Discussion

Based on Upgrade helper, why devDependencies ( babel, eslint) not updated...

@Bardiamist I checked in the repo and it seems that those versions are in line with the rest of the codebase; maybe you could try to do a PR to update the ones in the template and we can check with FB if that's ok for them?

https://github.com/facebook/react-native/pull/30489

grabbou

comment created time in 11 hours

startedjairovadillo/pychromeless

started time in 12 hours

startedjairovadillo/pychromeless

started time in 12 hours

issue commentreact-native-community/releases

Road to v0.64 Discussion

@kelset yes i followed every step but i get the same error. Are there any changes to xcode that I may not have made?

grabbou

comment created time in 14 hours

fork rchl/core

:house_with_garden: Open source home automation that puts local control and privacy first

https://www.home-assistant.io

fork in 16 hours

created repositorykeijiro/BiplanarMapping

created time in a day

pull request commentreact-native-async-storage/async-storage

Feat/windows autolinking

Hey @kaiguo , mind having a look here?

mateusz1913

comment created time in a day

issue commentreact-native-community/releases

Road to v0.64 Discussion

Based on Upgrade helper, why devDependencies ( babel, eslint) not updated...

@Bardiamist I checked in the repo and it seems that those versions are in line with the rest of the codebase; maybe you could try to do a PR to update the ones in the template and we can check with FB if that's ok for them?

@lorenzoangelini have you done all the steps @mrousavy mentioned in his comment here?

grabbou

comment created time in a day

created repositorykeijiro/CC0TexturesUtils

created time in a day

issue commentreact-native-community/releases

Road to v0.64 Discussion

I'm trying to upgrade to 0.64rc-0, but i have this error. Do other people have it too? Screenshot 2020-11-26 at 00 22 48

grabbou

comment created time in 2 days

fork petterh/issrc

Inno Setup is a free installer for Windows programs. First introduced in 1997, Inno Setup today rivals and even surpasses many commercial installers in feature set and stability.

https://jrsoftware.org/isinfo.php

fork in 2 days

issue commentreact-native-community/releases

Road to v0.64 Discussion

@grabbou So I've tried to build android, but my builds failed because the turbo module JSI JNI .so files were generated more than once:

- More than one file was found with OS independent path 'lib/x86_64/libturbomodulejsijni.so'. If you are using jniLibs and CMake IMPORTED targets, see https://developer.android.com/studio/preview/features#automatic_packaging_of_prebuilt_dependencies_used_by_cmake

I temporarily fixed this, by adding this:

android {
     // ...

+    packagingOptions {
+        pickFirst '**/*.so'
+    }

     // ...
}

in my app/build.gradle (under the android { section). Now it builds fine, but I couldn't get the app running due to errors with reanimated - working on that! https://github.com/software-mansion/react-native-reanimated/pull/1469

grabbou

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.64 Discussion

I see that there a new RC version, I will be testing that,

@mrousavy Hermes was working on IOS just fine, I have not tested on release mode, I'll try that out today.

grabbou

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.64 Discussion

@a-eid could you try if the app works with Hermes enabled in Release mode for you?

grabbou

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.64 Discussion

@grabbou IOS builds fine after upgrading to xCode 12.2

grabbou

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.64 Discussion

New JSX transform is not on by default. React Must be in scope. Is that intentional or should be fixed?

grabbou

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.64 Discussion

@a-eid, we have been testing this release with Xcode 12 and if it fixed the issues for you, here's the answer! I'd recommend upgrading to be 100% sure.

grabbou

comment created time in 2 days

issue commentreact-native-community/releases

Road to v0.64 Discussion

0.64.0-rc.1 shipped with a fix for Android and CLI bump to 5.0.0 (that we have missed before). No other changes. I just built fresh new app with Android. Happy testing!

grabbou

comment created time in 2 days

more