profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/thorbenprimke/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Thorben Primke thorbenprimke @Pinterest San Francisco, CA Engineer at @Pinterest. Working on making Pins buyable. Pushing the product forward from the Android side.

frostney/react-native-create-library 1394

:notebook: Command line tool to create a React Native library with a single command

mustafamotiwala90/InterviewQuestions 10

Interview questions

hgale/BrownFieldExample 4

This is an example of how to integrate React Native into an existing iOS application (BrownField).

repodio/react-native-fs 2

Native filesystem access for react-native

thorbenprimke/BBMVC 2

A MVC framework for BlackBerry Java applications

repodio/react-native-track-player 1

A fully fledged audio module created for music apps. Provides audio playback, external media controls, chromecast support, background mode and more!

thorbenprimke/android-collage-views 1

Draggable, rotatable, and scalable views for Android

thorbenprimke/android-swipelistview 1

An Android List View implementation with support for drawable cells and many other swipe related features

thorbenprimke/BBMVC-ExampleApp 1

An example app using the BBMVC framework

pull request commentezyang/ghstack

Add simple Chrome extension to delete merge button on ghstack PRs

Let me look at how this could be efficiently - maybe there is a way to listen / filter to changes in specific parts only.

Also someone on the project merged one of the ghstack PRs out of habit - so will be good to have this.

ezyang

comment created time in 3 days

issue openedezyang/ghstack

Block / Abort Land If Not All PRs In Stack Are Approved

Started using ghstack with our project this week. The workflow feels already so much better - or really just how I'm used to working with Phabricator - small diffs / change requests and always on top of the base branch.

I looked through the issues but didn't see any mention of being able to block landing based on GH PR approval status. Has it just not come up before? Am I thinking about this wrong such as one should just use GH branch protection rules?

created time in 3 days

issue commentezyang/ghstack

Support non-default base branch

Yea, makes sense in regards to every person on the repo having to override it via the config. In our project we actually have develop set as the default base. So probably even for us the -B option or implicit use of the tracking branch would make more sense for branch specific fixes to staging or master as they are less frequent.

As far as adding the base information, I suppose it would have to be added to each commit in a stack (since partial stack can be landed) similar to the gh-stack-source-id and PR link. Seems like a reasonable trade off to support this.

So you run ghstack in detached state and then use the git hash to revisit a commit to make any changes requested on a PR?

calebho

comment created time in 6 days

startedtimothyandrew/gh-stack

started time in 7 days

startedezyang/ghstack

started time in 7 days

issue commentezyang/ghstack

Support non-default base branch

I looked through the code and based on some hacking, it looks like just default_branch needs to be updated to use the desired branch. Without making the change to submit, I ran into an error with landing.

Personally I could see this work best by implicitly using the tracking branch to override the GH default_branch. However, there is remote_name is the config so perhaps it also could be reasonable to override what's set in GH's default_branch with an option in the ghstack config.

@ezyang - thoughts? You mentioned to use a -B option above.

calebho

comment created time in 7 days

delete branch thorbenprimke/stacked-work

delete branch : gh/thorbenprimke/1/orig

delete time in 7 days

delete branch thorbenprimke/stacked-work

delete branch : gh/thorbenprimke/1/head

delete time in 7 days

delete branch thorbenprimke/stacked-work

delete branch : gh/thorbenprimke/1/base

delete time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha b03ff305978620e15d907ac4bba8f5a2545359f2

develop commit ghstack-source-id: f82efb257d806335163285d972b4df17449297bd Pull Request resolved: https://github.com/thorbenprimke/stacked-work/pull/27

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha db4f1713ffb9e8a4a9e324b0aaf0862a84892edf

develop commit [ghstack-poisoned]

view details

push time in 7 days

create barnchthorbenprimke/stacked-work

branch : gh/thorbenprimke/1/orig

created branch time in 7 days

PR opened thorbenprimke/stacked-work

develop commit

Stack from ghstack:

  • (to be filled)
+2 -0

0 comment

1 changed file

pr created time in 7 days

create barnchthorbenprimke/stacked-work

branch : gh/thorbenprimke/1/base

created branch time in 7 days

create barnchthorbenprimke/stacked-work

branch : gh/thorbenprimke/1/head

created branch time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha 2399d5c7f3af8f76c867b3151ba10d0372865f20

37 on master

view details

Thorben Primke

commit sha d5af24a8a41e459b16c92b9f874903cf420da45d

36 ghstack-source-id: bec20ee5fbba77da49dee42a0bb7d2857371354f Pull Request resolved: https://github.com/thorbenprimke/stacked-work/pull/26

view details

push time in 7 days

delete branch thorbenprimke/stacked-work

delete branch : gh/thorbenprimke/3/orig

delete time in 7 days

delete branch thorbenprimke/stacked-work

delete branch : gh/thorbenprimke/3/head

delete time in 7 days

delete branch thorbenprimke/stacked-work

delete branch : gh/thorbenprimke/3/base

delete time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha d5af24a8a41e459b16c92b9f874903cf420da45d

36 ghstack-source-id: bec20ee5fbba77da49dee42a0bb7d2857371354f Pull Request resolved: https://github.com/thorbenprimke/stacked-work/pull/26

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha dcd510fabd98bc437bcb80e9b624e5bcc599492b

Update on "36" [ghstack-poisoned]

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha 2399d5c7f3af8f76c867b3151ba10d0372865f20

37 on master

view details

Thorben Primke

commit sha 84083aebb8d84312854733a531a61f4b30e24200

Update base for Update on "36" [ghstack-poisoned]

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha 2399d5c7f3af8f76c867b3151ba10d0372865f20

37 on master

view details

Thorben Primke

commit sha 8fcc7af1064f63af82614e2f97ddee53e114b5d6

36 ghstack-source-id: bec20ee5fbba77da49dee42a0bb7d2857371354f Pull Request resolved: https://github.com/thorbenprimke/stacked-work/pull/26

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha 2399d5c7f3af8f76c867b3151ba10d0372865f20

37 on master

view details

Thorben Primke

commit sha 84083aebb8d84312854733a531a61f4b30e24200

Update base for Update on "36" [ghstack-poisoned]

view details

Thorben Primke

commit sha dcd510fabd98bc437bcb80e9b624e5bcc599492b

Update on "36" [ghstack-poisoned]

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha e0192588ad4a87693fcf36b69bbb99dd91083607

Update on "36" [ghstack-poisoned]

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha deb915c6a49c72a11695bc3d0edaacc9f49be370

36 ghstack-source-id: 6e52a18520768dfc2b72d34c57b4f471a77b3d95 Pull Request resolved: https://github.com/thorbenprimke/stacked-work/pull/26

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha 0cd7b8141a45441563866cc0150068485d1c1268

Update base for Update on "36" [ghstack-poisoned]

view details

Thorben Primke

commit sha e0192588ad4a87693fcf36b69bbb99dd91083607

Update on "36" [ghstack-poisoned]

view details

push time in 7 days

push eventthorbenprimke/stacked-work

Thorben Primke

commit sha 0cd7b8141a45441563866cc0150068485d1c1268

Update base for Update on "36" [ghstack-poisoned]

view details

push time in 7 days