profile
viewpoint

redwoodjs/example-invoice 44

Example Invoice app written with Redwood

thedavidprice/language-matlab-octave 14

Atom.io language support for Matlab / Octave converted from TextMate Bundle

thedavidprice/redwood-tutorial-test 2

final state of RedwoodJS Tutorial for Version Testing

thedavidprice/redwoodjs-example-blog-vercel-demo 1

RedwoodJS Example Blog clone that's powering the Vercel Guide demo site

alo9507/acro.ai 0

Acro.ai website

thedavidprice/bell 0

site test

thedavidprice/blacktonic.com 0

public site for blacktonic

thedavidprice/contributors-readme-action 0

A github action to automate a contributors section in readme.

thedavidprice/create-redwood-app 0

Template for `yarn create redwood-app`

pull request commentredwoodjs/redwood

Router: Partial TS rewrite

📦 PR Packages

<details><summary>Click to Show Package Download Links</summary>

https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/create-redwood-app-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-api-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-api-server-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-auth-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-cli-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-core-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-dev-server-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-eslint-config-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-eslint-plugin-redwood-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-forms-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-internal-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-router-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-structure-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-testing-0.23.0-0ee16c9.tgz https://rw-pr-redwoodjs-com.s3.amazonaws.com/1666/redwoodjs-web-0.23.0-0ee16c9.tgz </details>

Install this PR by running yarn rw upgrade --pr 1666:0.23.0-0ee16c9

Tobbe

comment created time in 2 hours

PR opened redwoodjs/redwood

Router: Partial TS rewrite

The main router.tsx file is now written in TypeScript, and some of the helper files, but not all.

+179 -217

0 comment

7 changed files

pr created time in 2 hours

startedairbnb/javascript

started time in 6 hours

issue commentredwoodjs/redwood

Storybook not working with `pathname` in `useLocation` hook in @redwoodjs/router

@peterp not sure this is resolved. I get this error in very simple secenario:

// web/src/components/LinkTest/LinkTest.tsx

import { useLocation } from '@redwoodjs/router';

const LinkTest: React.FunctionComponent = () => {
  const { pathname } = useLocation();
  return <a href={`${pathname}/test`}>testlink</a>;
};

export default LinkTest;

// web/src/components/LinkTest/LinkTest.stories.tsx

import LinkTest from './LinkTest';

export const generated = () => {
  return <LinkTest />;
};

export default { title: 'Components/LinkTest' };

And I see this error in storybook:

Cannot read property 'pathname' of undefined
TypeError: Cannot read property 'pathname' of undefined
    at LinkTest (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:359741:31)
    at renderWithHooks (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:320569:18)
    at mountIndeterminateComponent (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:323248:13)
    at beginWork (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:324362:16)
    at HTMLUnknownElement.callCallback (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:305954:14)
    at Object.invokeGuardedCallbackDev (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:306003:16)
    at invokeGuardedCallback (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:306058:31)
    at beginWork$1 (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:328969:7)
    at performUnitOfWork (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:327920:12)
    at workLoopSync (http://localhost:7910/main.86667f7ae87461ffa9b0.bundle.js:327896:22)

I am using redwood 0.21.0. Am I missing something?

hemildesai

comment created time in 8 hours

pull request commentredwoodjs/redwood

Replaced merge-graphql-schemas with graphql-tools

@thedavidprice definitely! I will resolve the conflicts and see if we sort the failing tests.

himankpathak

comment created time in 16 hours

pull request commentredwoodjs/learn.redwoodjs.com

French translation for footer #32

@M0nica, thanks for the information. So, should I create a new pull request once the issue is fixed?

I don’t think that waiting for the issue to be resolved is necessary in this case.

ShrillShrestha

comment created time in a day

pull request commentredwoodjs/learn.redwoodjs.com

French translation for footer #32

@M0nica, thanks for the information. So, should I create a new pull request once the issue is fixed?

ShrillShrestha

comment created time in a day

pull request commentredwoodjs/learn.redwoodjs.com

French translation for footer #32

@M0nica, can you check once more? If it's still showing the same issue, can you give me some idea to solve it? I haven't change any format files for the project. I just added the JSON files needed for the translations. Also, when I ran it in the localhost it is working fine.

Actually, I found out (based on the convo here: https://github.com/redwoodjs/learn.redwoodjs.com/issues/38#issuecomment-765701029) that the footer color changes are related to a pre-existing strange styling issue that are currently happening in the repo with certain environments 🤔 I see the same footer styling issue on another staging site as well https://deploy-preview-33--learn-redwood.netlify.app/docs/tutorial/welcome-to-redwood.

ShrillShrestha

comment created time in a day

issue commentredwoodjs/repeaterdev-js

Question on usecase

Thanks for the explanation. I'm coming from Celery/RabbitMQ and would like to find a more lightweight solution for usecase 2.

What I had in mind is this:

  1. User clicks a button "Create PDFs".
  2. This will call an API endpoint within my app.
  3. The bacckend script behind the endpoint will create a Job with Repeater.
  4. The job URL (another API endpoint) will start generating the PDFs.
  5. With every PDF which has been processed, I'm updating the job.
  6. With the browser/frontend, I'm calling a 3rd endpoint within my app which just gets the job result.

Does that sound reasonable?

Additional question: I'm not exactly sure about the database flag in order to indicate that the job has finished. I would like to avoid adding flags for the state of every background process with my DB. Do you really think that´s necessary given the workflow described above? Isn't it exactly the point of using something like Repeater in order to check for finished jobs? Or do I miss something here?

sehmaschine

comment created time in a day

pull request commentredwoodjs/redwood

Don't bundle Apollo Client if the user specify their own client

Nice!

Tobbe

comment created time in a day

pull request commentredwoodjs/redwood

Don't bundle Apollo Client if the user specify their own client

With @apollo/client

image

With graphql-hooks and graphql-hooks-memcache

image

Previously the bundle size got bigger when you used your own graphql client, because both the one you use, and apollo client were included. Now, as you can see, the bundle size goes down, and @apollo/client is no longer included when you decide to use another client instead.

Tobbe

comment created time in a day

issue commentredwoodjs/learn.redwoodjs.com

a11y: low contrast for `span.token.comment` in code blocks

I had some additional code block changes (including a darker background) but those styles aren't showing in certain environments! So strange, but I can't comprehend all the combined processes that are in place to make CSS in the modern JS world. :(

I'll see what I can do!

M0nica

comment created time in a day

issue commentredwoodjs/repeaterdev-js

Question on usecase

Hello! All Repeater does is make an HTTP(S) call to a URL at a given point in time and then record the response. It can make that call once, or repeatedly (ha!) at a set interval.

It's also tailored for the Jamstack where you'll generally expose your app's functionality as API calls somewhere. In Jamstack land this has generally been through AWS Lambda functions. When you deploy to lambda you get a URL that you can access to invoke your function.

So in usecase (1) you might have the code that sends an email, or starts a backup, exposed at some endpoint. Repeater would then call that endpoint at the specified time. You can then later query Repeater and ask for the response of that call (or ignore it completely for non-critical jobs).

Now, depending on your email service and its own API, you may be able to have Repeater call the third party service directly and skip your app entirely—SendGrid will send an email by just POSTing to an endpoint. But personally, I'd want to keep the code for sending the email within my app and just expose the "send an email now" functionality as an API call, and just have Repeater call that endpoint for me. That call can contain security information to make sure that bad actors can't find the endpoint and send billions of emails a second (you can set query params and headers in the Repeater call).

Usecase (2) is totally doable, but you may need some creative architecture. Here's two ways I can think of to do what you're looking for:

  1. Have the browser itself make a call to Repeater to start the job, right now. The call to start the job will return right away, and the name you gave the job will be the unique ID you can use to query the state of the job later. So you can start a periodic AJAX request that asks Repeater "are you done yet?" over and over until it's done. You can then update the UI for the user.
  2. If you'd rather rely on your own code to know when the job is done, have Repeater start the job immediately, but the process that is running (the API endpoint that repeater called) will set a flag in your own database indicating that it's done. You then have the browser either periodically ask another endpoint if that database flag is set, or do something with pub/sub and websockets...however complex you want to make that check.

But remember: Repeater itself doesn't perform any logic or execute any packaged up code for you—all it does is call a URL and record the result. Whatever URL it calls will be where the magic actually happens.

Does that help?

sehmaschine

comment created time in a day

pull request commentredwoodjs/learn.redwoodjs.com

French translation for footer #32

@M0nica, can you check once more? If it's still showing the same issue can you give me some idea to solve it. I haven't change any format files for the project. I just added the JSON files needed for the translations.

ShrillShrestha

comment created time in a day

issue commentredwoodjs/learn.redwoodjs.com

a11y: low contrast for some text in nav and footer

Yep I'll take a look at these, thanks for pointing them out!

M0nica

comment created time in a day

issue commentredwoodjs/learn.redwoodjs.com

a11y: low contrast for some text in nav and footer

@cannikin it would be helpful to get your input on making the color schemes more accessible as my understanding is you worked on the initial color schemes.

M0nica

comment created time in a day

pull request commentredwoodjs/learn.redwoodjs.com

French translation for footer #32

I took a peek at your changes and noticed the footer color in light mode is different in your staging site than the production version of site. I am assuming that was an intentional side effect.

The top screenshot is what I see in light mode for the footer in the staging server (https://deploy-preview-36--learn-redwood.netlify.app/docs/tutorial/prerequisites/): Screen Shot 2021-01-22 at 2 19 08 PM

Whereas what I see in light mode for the footer for the production site (https://learn-redwood.netlify.app/docs/tutorial/welcome-to-redwood) is: Screen Shot 2021-01-22 at 2 19 00 PM

ShrillShrestha

comment created time in a day

issue openedredwoodjs/learn.redwoodjs.com

a11y: low contrast for some text in nav and footer

Similar to https://github.com/redwoodjs/learn.redwoodjs.com/issues/38 I noticed on the site that the contrast value for certain text in the footer and navigation is currently too low to be accessible. Generally the minimum contrast level to be accessible is 4.5:1 for AA or 3:1 for large text.

Screenshots below:

Screen Shot 2021-01-22 at 2 05 10 PM Screen Shot 2021-01-22 at 2 04 57 PM Screen Shot 2021-01-22 at 2 04 18 PM Screen Shot 2021-01-22 at 2 04 10 PM

I am happy to work on updating the colors in the footer and navigation to be more accessible but am not sure in terms of branding what colors would be appropriate.

created time in a day

issue openedredwoodjs/learn.redwoodjs.com

a11y: low contrast for `span.token.comment` in code blocks

I noticed on the site that the contrast value for span.token.comment is currently too low to be accessible as it is 1.64. Generally the minimum contrast level to be accessible is 4.5:1 for AA or 3:1 for large text.

I was able to encounter this issue by going to https://learn-redwood.netlify.app/docs/tutorial/cells and viewing the code example that contains // web/src/components/BlogPostsCell/BlogPostsCell.js at the top (screenshot below)

Screen Shot 2021-01-22 at 1 55 57 PM

visually the contrast looked too low for me, I used the Google Developer Tools to confirm the contrast level.

Screen Shot 2021-01-22 at 1 55 48 PM

I am available to work on resolving this issue.

created time in a day

issue closedredwoodjs/learn.redwoodjs.com

Change footer colors to be more accessible

Our page has lovely theming now thanks to Rob but I noticed our footer is somewhat hard to read in light mode.

There is not enough contrast between the dark gray bg and dark red text.

The dark red text is similarly hard to read on dark red bg in dark mode

Light mode image

Dark mode image

closed time in a day

clairefro

issue commentredwoodjs/learn.redwoodjs.com

Change footer colors to be more accessible

Resolved by #37

clairefro

comment created time in a day

push eventredwoodjs/learn.redwoodjs.com

Rob Cameron

commit sha 2b5e10d7c7909b78700acba73d8016fd53f0fd1a

Set footer background color the old fashioned way

view details

Claire Froelich

commit sha 128119beb01ed6905cb34123196e817243f60b5b

Merge branch 'master' into rc-footer-color

view details

Claire Froelich

commit sha a928239a8abb4fa87286749cf0a14edb6e3a0686

Merge pull request #37 from redwoodjs/rc-footer-color Set footer background color the old fashioned way

view details

push time in a day

push eventredwoodjs/learn.redwoodjs.com

Claire Froelich

commit sha e29e4bff65e68b6a0024fca86dd277a626da2895

Merge pull request #30 from redwoodjs/rc-search Adds Algolia serach

view details

Claire Froelich

commit sha c976680842e9b44a8f4e7f4684005bbbd0942095

Add test md doc

view details

Claire Froelich

commit sha 32230c53e8bdd4c8364b106952ae8848be3593f5

New translations test.md (French)

view details

Claire Froelich

commit sha 744b7a22b5656b29b91b32e5c94c7888392664ac

Start re-writing README, prune uneeded files

view details

Claire Froelich

commit sha adacd2e03add4c8f5bfdf25e88c262f77ee50ff2

Add translation guide content

view details

Claire Froelich

commit sha 88da467372fda19309b09c2e578d7938a2c69c32

Boldify FAQ questions

view details

Claire Froelich

commit sha c73f5db9163a2ba68bafc376fad032a96a83cbe6

Merge pull request #35 from redwoodjs/l10n_master New Crowdin updates

view details

Claire Froelich

commit sha fa0efe0b48714abd61060ccd44a4fab3e75d678c

Delete test.md

view details

Claire Froelich

commit sha 170c06ccf8c342253e3476c4df196f6ebc659a6d

Update README.md

view details

Claire Froelich

commit sha 128119beb01ed6905cb34123196e817243f60b5b

Merge branch 'master' into rc-footer-color

view details

push time in a day

create barnchredwoodjs/learn.redwoodjs.com

branch : rc-footer-color

created branch time in a day

Pull request review commentredwoodjs/redwoodjs.com

Docs: TypeScript docs updates

 Create a `./web/tsconfig.json` file:     "paths": {       "src/*": ["./src/*"]     },-    "typeRoots": ["../.redwood"]+    "typeRoots": ["../.redwood"],+    "types": []   },-  "include": ["src"],+  "include": ["src"] } ```  You should now have type definitions, you can rename your files from `.js` to `.ts`, and the files that contain JSX to `.tsx`. +#### Getting types for `jest` in test files++If you're adding tests, you'll want to include the types for `jest` in your `tsconfig`.++```diff+-"types": []++"types": ["jest"]+```++Currently, these are added to `node_modules` by `@redwoodjs/core` and the above approach should just work. If this is not the case, you can `npm i -D @types/jest` in the `web` folder and they will resolve.

@Burnsy Thanks for the feedback! This is under the WEB section, but I guess it wouldn't hurt to add additional clarification language?

It might be a good idea to just add in a quick cli generator for tsconfigs that adds to the root and extends in the respective directories for overrides? I'm not sure if that's already a thing in the TS support meta tracker though.

msutkowski

comment created time in a day

pull request commentredwoodjs/learn.redwoodjs.com

French translation for footer #32

Deploy request for learn-redwood pending review.

Review with commit 359ecb036aedc8766dcaa6d31dc0519ffd4f5948

https://app.netlify.com/sites/learn-redwood/deploys

ShrillShrestha

comment created time in a day

PR opened redwoodjs/learn.redwoodjs.com

French translation for footer #32

I did the french translation for the footer. Can you review it? If there are any queries, free free to mention them.

+70 -0

0 comment

3 changed files

pr created time in a day

delete branch redwoodjs/redwood

delete branch : dependabot/npm_and_yarn/testing-library/react-11.2.3

delete time in a day

more