profile
viewpoint
Christian Schabesberger theScrabi Germany Your advertisement could be written here.

TeamNewPipe/NewPipe 10788

A libre lightweight streaming front-end for Android.

owncloud/android 2994

:phone: The ownCloud Android App

CoraLibre/CoraLibre-android-sdk 143

CoraLibre-android-sdk fork of prestandard DP-3T to make compatible with the Google/Apple protocol

owncloud/android-library 104

:phone: The ownCloud Android Library

theScrabi/Terminightor 33

Terminighor is a free NFC tag based alarm clock for android.

mswart/openmensa-parsers 30

A collection of openmensa.org parsers with feed v2 generator

theScrabi/OCBookmarks 30

Android frontend for Nextcloud/Android Bookmark App

CoraLibre/CoraLibre-android 27

Native Android app using the CoraLibre-android-sdk.

wowtomi/godot-mysql-module 16

MySQL Connector Module for Godot Engine

theScrabi/tttrsss 13

fdroid complient version of the Tiny Tiny RSS android app

PR opened owncloud/android

Remove cookie persistence

This will resolve cookie persistence which should solve braking the cookiejar after restarting the app.

+20 -2

0 comment

3 changed files

pr created time in 2 days

PR opened owncloud/android-library

remove cookie persistence

This will resolve cookie persistence which should solve braking the cookiejar after restarting the app.

+0 -98

0 comment

3 changed files

pr created time in 2 days

create barnchowncloud/android

branch : remove_cookie_persistence

created branch time in 2 days

create barnchowncloud/android-library

branch : remove_cookie_persistence

created branch time in 2 days

issue openedowncloud/android

add lint / checkscript

Add a lint.sh or check.sh script to the android and android-library project, that will check all the small and nasty things one tends to forget when creating a new Pull request. This script could check

  • that the license header was added to all *.kt and *.java files
  • code formation is correct in all *.kt and *.java files
  • lines do not exceed a certain length in all *.kt and *.java files
  • check that author is added
  • copyright year got updated

created time in 2 days

push eventowncloud/android

Phil Davis

commit sha eadf8c459b4bf97388fc53533c10f9bffbe4d3fa

Minor docs correction his-has

view details

Abel García de Prada

commit sha a14574d6697a186e4655b796d7493a8cae03ef68

Merge pull request #2998 from owncloud/his-has Minor docs correction his-has

view details

Christian Schabesberger

commit sha 74e9bdf3a6f5f43631a3b7d324b9ed5036c6ac24

create OCSharee object and mapper

view details

Christian Schabesberger

commit sha 216f3348968fec2d996021a1ff1dff7fca19ace5

update oc sharee tests

view details

Christian Schabesberger

commit sha dae9bb6ac6895e5d4aabdf93c982a9540360a309

integrate OCSharee object

view details

Christian Schabesberger

commit sha 3883323cee7762fae5c2fbe8bdc0f35523d1e69d

add factory for RemoteShareeMapper

view details

Christian Schabesberger

commit sha db8755eb32abbc5095e3c23377d97230f4e78dda

fix OCSharee tests

view details

Christian Schabesberger

commit sha 3d5be1f0c8717abe8d92285678b809b9f7acb2bb

apply suggested changes

view details

Christian Schabesberger

commit sha 07f47b48362f85d10e8f50085959683d100aa724

add OCSharee test for edgecase empty list

view details

Christian Schabesberger

commit sha 48b6003cccd7a1b00ca0a3cba561779e04816aef

updated to latest version of the library

view details

Christian Schabesberger

commit sha 1c7a6f802d7f15558cec2ff66a883e4989566733

update to latest corresponding library

view details

Christian Schabesberger

commit sha f3e3982207725c6b1ae47b7980a35100501f757a

update to latest version of the library

view details

push time in 3 days

push eventowncloud/android

Christian Schabesberger

commit sha 71090b705cc1d1d098174205e1082923aad62632

update to latest version of the library

view details

push time in 3 days

push eventowncloud/android-library

Christian Schabesberger

commit sha fdb373f82420b89dd9c5d1218d59fdc992108442

apply changes acording to review

view details

push time in 3 days

push eventowncloud/android-library

Christian Schabesberger

commit sha cc12ec49ac8c03099b5ce873738da183df0ae7f8

apply changes acording to review

view details

push time in 3 days

Pull request review commentowncloud/android-library

New arch/moshi parse sharees

+/* ownCloud Android Library is available under MIT license+ *   Copyright (C) 2020 ownCloud GmbH.+ *+ *   Permission is hereby granted, free of charge, to any person obtaining a copy+ *   of this software and associated documentation files (the "Software"), to deal+ *   in the Software without restriction, including without limitation the rights+ *   to use, copy, modify, merge, publish, distribute, sublicense, and/or sell+ *   copies of the Software, and to permit persons to whom the Software is+ *   furnished to do so, subject to the following conditions:+ *+ *   The above copyright notice and this permission notice shall be included in+ *   all copies or substantial portions of the Software.+ *+ *   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,+ *   EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF+ *   MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND+ *   NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS+ *   BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN+ *   ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN+ *   CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN+ *   THE SOFTWARE.+ *+ */++package com.owncloud.android.lib.resources.shares.responses++import com.owncloud.android.lib.resources.CommonOcsResponse+import com.squareup.moshi.JsonAdapter+import com.squareup.moshi.Moshi+import com.squareup.moshi.Types+import org.junit.Assert.assertEquals+import org.junit.Assert.assertNotEquals+import org.junit.Assert.assertTrue+import org.junit.Before+import org.junit.Test+import java.io.File+import java.lang.reflect.Type++class ShareeResponseTest {++    lateinit var response: CommonOcsResponse<ShareeOcsResponse>++    private fun loadResponses(fileName: String, adapter: JsonAdapter<CommonOcsResponse<ShareeOcsResponse>>) =+        adapter.fromJson(File(fileName).readText())++    @Before+    fun prepare() {+        val moshi = Moshi.Builder().build()+        val type: Type = Types.newParameterizedType(CommonOcsResponse::class.java, ShareeOcsResponse::class.java)+        val adapter: JsonAdapter<CommonOcsResponse<ShareeOcsResponse>> = moshi.adapter(type)+        response = loadResponses(EXAMPLE_RESPONSE_JSON, adapter)!!+    }++    @Test+    fun `check structure - ok - example response files exist`() {+        val file = File(EXAMPLE_RESPONSE_JSON)+        assertTrue(file.exists())+    }++    @Test+    fun `check structure - ok - contains meta`() {+        assertEquals("OK", response.ocs.meta.message!!)+        assertEquals(200, response.ocs.meta.statusCode!!)+        assertEquals("ok", response.ocs.meta.status!!)+        assertTrue(response.ocs.meta.itemsPerPage?.isEmpty()!!)+        assertTrue(response.ocs.meta.totalItems?.isEmpty()!!)+    }++    @Test+    fun `check structure - ok - contains exact`() {+        assertNotEquals(null, response.ocs.data.exact)+    }++    @Test+    fun `check structure - ok - contains groups`() {+        assertNotEquals(null, response.ocs.data.groups)+    }++    @Test+    fun `check structure - ok - contains remotes`() {+        assertNotEquals(null, response.ocs.data.remotes)+    }++    @Test+    fun `check structure - ok - contains users`() {+        assertNotEquals(null, response.ocs.data.users)

Please correct me if I am wrong, but I learned that every test should test one thing and not everything. Am I wrong?

theScrabi

comment created time in 3 days

PullRequestReviewEvent

Pull request review commentowncloud/android-library

New arch/moshi parse sharees

+/* ownCloud Android Library is available under MIT license+ *   Copyright (C) 2020 ownCloud GmbH.+ *+ *   Permission is hereby granted, free of charge, to any person obtaining a copy+ *   of this software and associated documentation files (the "Software"), to deal+ *   in the Software without restriction, including without limitation the rights+ *   to use, copy, modify, merge, publish, distribute, sublicense, and/or sell+ *   copies of the Software, and to permit persons to whom the Software is+ *   furnished to do so, subject to the following conditions:+ *+ *   The above copyright notice and this permission notice shall be included in+ *   all copies or substantial portions of the Software.+ *+ *   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,+ *   EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF+ *   MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND+ *   NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS+ *   BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN+ *   ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN+ *   CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN+ *   THE SOFTWARE.+ *+ */++package com.owncloud.android.lib.resources.shares.responses++import com.owncloud.android.lib.resources.CommonOcsResponse+import com.squareup.moshi.JsonAdapter+import com.squareup.moshi.Moshi+import com.squareup.moshi.Types+import org.junit.Assert.assertEquals+import org.junit.Assert.assertNotEquals+import org.junit.Assert.assertTrue+import org.junit.Before+import org.junit.Test+import java.io.File+import java.lang.reflect.Type++class ShareeResponseTest {++    lateinit var response: CommonOcsResponse<ShareeOcsResponse>++    private fun loadResponses(fileName: String, adapter: JsonAdapter<CommonOcsResponse<ShareeOcsResponse>>) =+        adapter.fromJson(File(fileName).readText())++    @Before+    fun prepare() {+        val moshi = Moshi.Builder().build()+        val type: Type = Types.newParameterizedType(CommonOcsResponse::class.java, ShareeOcsResponse::class.java)+        val adapter: JsonAdapter<CommonOcsResponse<ShareeOcsResponse>> = moshi.adapter(type)+        response = loadResponses(EXAMPLE_RESPONSE_JSON, adapter)!!+    }++    @Test+    fun `check structure - ok - example response files exist`() {+        val file = File(EXAMPLE_RESPONSE_JSON)+        assertTrue(file.exists())+    }

You are right, but this way you can directly see what happens.

theScrabi

comment created time in 3 days

PullRequestReviewEvent

push eventowncloud/android

Christian Schabesberger

commit sha 99de7fa67e17ab3c136c010060c05241109adbd8

update to latest corresponding library

view details

push time in 3 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 9c9a225dbbb958643c9bb7da7099ade712ac718f

apply suggested changes delete unused const values bla

view details

push time in 3 days

push eventowncloud/android

Christian Schabesberger

commit sha 28b7e45bf47e111bd2278f670aefef320a785137

updated to latest version of the library

view details

push time in 3 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 77739ef12161b33d6e5c470cebce43b5bcc6aeba

apply suggested changes delete unused const values bla

view details

push time in 3 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 747969d2ad5cd4b741e05dcbb9e006933fe9e008

delete unused const values

view details

push time in 3 days

push eventowncloud/android-library

Christian Schabesberger

commit sha d72c609e7b2b1718a896e92c530fb60ea8a721a7

rename json test resources to responses

view details

push time in 3 days

PR closed owncloud/android-library

New arch/moshi parse shares

related issue: https://github.com/owncloud/android/issues/2704

+333 -81

1 comment

12 changed files

theScrabi

pr closed time in 4 days

push eventowncloud/android

Christian Schabesberger

commit sha 705a8c29437c35ef30141d61b2ae4cdd44d6dad5

replace background image with vector data

view details

push time in 4 days

push eventowncloud/android

Christian Schabesberger

commit sha af4cf0cea19393e36b1578fa732f359609c33f8c

apply matrix scaling to sidebar header background image

view details

push time in 4 days

push eventowncloud/android

agarcia

commit sha fc50541502ce92a95239c596d2c2ceaedd451151

Update dependencies and perform a little cleanup

view details

agarcia

commit sha e62e40ca512176645367f9651cb96065d94aa958

Revert multidex support

view details

Abel García de Prada

commit sha 645e9a227e918cbebad7302c701b4c22f6f1b2c1

Reorder some dependencies

view details

Abel García de Prada

commit sha b89c75fceb4576762afc6e7128dd232bc75ea7a7

Update some dependencies

view details

Abel García de Prada

commit sha 8e11c99c813e70bddb8b51481a5f004abd0170f9

Fix a test and update password toggle view

view details

Abel García de Prada

commit sha 119f27753b54cd200291fa6e4123314ace444acd

Android Studio 4.1

view details

Abel García de Prada

commit sha 3364d2bc92c84a236cb5156812a8a52d5865ddbe

Merge pull request #2975 from owncloud/update_dependencies Update dependencies and perform a little cleanup

view details

Christian Scherm

commit sha f49a66f51877e551b88f624f6eda98a94dc3b7a8

Add the new ci images we introduced with oC 10.5

view details

Christian Schabesberger

commit sha 136543ce9ef6a9266dec7b5ccb8f98579c91b1ce

scale login background image correctly using matrix

view details

push time in 4 days

push eventowncloud/android

agarcia

commit sha fc50541502ce92a95239c596d2c2ceaedd451151

Update dependencies and perform a little cleanup

view details

agarcia

commit sha e62e40ca512176645367f9651cb96065d94aa958

Revert multidex support

view details

Abel García de Prada

commit sha 645e9a227e918cbebad7302c701b4c22f6f1b2c1

Reorder some dependencies

view details

Abel García de Prada

commit sha b89c75fceb4576762afc6e7128dd232bc75ea7a7

Update some dependencies

view details

Abel García de Prada

commit sha 8e11c99c813e70bddb8b51481a5f004abd0170f9

Fix a test and update password toggle view

view details

Abel García de Prada

commit sha 119f27753b54cd200291fa6e4123314ace444acd

Android Studio 4.1

view details

Abel García de Prada

commit sha 3364d2bc92c84a236cb5156812a8a52d5865ddbe

Merge pull request #2975 from owncloud/update_dependencies Update dependencies and perform a little cleanup

view details

Christian Schabesberger

commit sha 7cc98d4dda938fa6d58eef217dd4c6f189a4511f

create OCSharee object and mapper

view details

Christian Schabesberger

commit sha b744a4ca4681afab74b08c948b6abede43bf312d

update oc sharee tests

view details

Christian Schabesberger

commit sha 7d55e2f75dc0684c4d98c3eb94be89bff4c21e28

integrate OCSharee object

view details

Christian Schabesberger

commit sha 61161f2abfebfd5c1dacc151617d17e1a84cbf07

add factory for RemoteShareeMapper

view details

Christian Schabesberger

commit sha d6905324eae7a09a84255443950466455969591c

fix OCSharee tests

view details

Christian Schabesberger

commit sha c14b4133b7a492d7a8613315fea6202c62feec31

apply suggested changes

view details

Christian Schabesberger

commit sha a94a00d87e674d66e632d6deb5f0b6db4556911d

add OCSharee test for edgecase empty list

view details

push time in 4 days

push eventowncloud/android-library

Abel García de Prada

commit sha 4b6946a19536fd76bfb284909e109804d0ebfdae

Update dependencies and perform a little cleanup

view details

Abel García de Prada

commit sha e28335ae4e13b9b1d583b8ce2db4c1d77dcfd196

Merge pull request #351 from owncloud/update_dependencies Update dependencies and perform a little cleanup

view details

Christian Schabesberger

commit sha 6698c19b36a5961db4d9e7578e9677cf11f341b7

move responses models into module folder

view details

Christian Schabesberger

commit sha 440a10770d7b229a18cd483bf0b6f6e80d6e1f80

clean run method by braking down into small functions

view details

Christian Schabesberger

commit sha a5aac9dd5681a581382671d50dcd608b2d399d77

add Sharee response model

view details

Christian Schabesberger

commit sha 85bd7b113b672d6aade292bf2ea79ddc7576b2f4

add support for tests

view details

Christian Schabesberger

commit sha 2ef247d8acf6e6d04eeb2f962f99f01edd52e41f

test model

view details

Christian Schabesberger

commit sha 995532c1a20863a0ed8e066e136b09552b988ff2

update GetRemoteShareesOperation to use moshi

view details

Christian Schabesberger

commit sha 0a3ad09c2051acb5165cfc2770e79e6053ff3bb0

update shareeservice to use ShareeOcsResponse

view details

Christian Schabesberger

commit sha f688afe32f56b70a2e7993f9e0102fa6875502b2

get flat representation from ShareeOcsResponse

view details

Christian Schabesberger

commit sha 4d51214bf272ffb6fe25e11fda1d7db65b8b76f9

return sharees without exact match

view details

Christian Schabesberger

commit sha f9c1238e1cffb79aac7867ee419db1f8a5b5e65e

add aditional data field to ocs sharees

view details

Christian Schabesberger

commit sha 25491a88e826a0168eb4fa5aa1a041ec1725b2b2

make sharee parts non null that can't be null

view details

Christian Schabesberger

commit sha cc83e1723d3bccb19abbdf834db24398403a30e8

disable unitTestBinaryResource as its deprecated

view details

Christian Schabesberger

commit sha 3278e6f6af8f0430c27ae997281908abc9a8af72

refactor ShareType

view details

Christian Schabesberger

commit sha b74e4cc3f138535dd20767f2775f5481c7a1e15a

add changes according to review

view details

Christian Schabesberger

commit sha a9e0ee629ab820f24dbccc7885a765eca18522b7

move response json to resource folder

view details

push time in 4 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 797ca0d374f14c7253077ad08fdeb615436d6ff6

move response json to resource folder

view details

push time in 4 days

issue commentOpenSlides/OpenSlides

./build.sh all hangs during installation of npm packages

I see. I upscaled my instance and ./build.sh all runned through :)

theScrabi

comment created time in 5 days

push eventowncloud/docs

mmattel

commit sha 14abfc2722044aa39a295b2b7f12f6bb5acd31da

strict login checking

view details

Phil Davis

commit sha 50987eba2001b1a55a56d93d83beedc7524d889b

Merge pull request #2819 from owncloud/strict-login-doc add doc for strict login checking required for disabling login with LDAP email address

view details

Michael Stingl

commit sha 38832d9a8a55e64114b2072c4d34240b27e560e5

Migrate desktop & mobile system requirements

view details

Michael Stingl

commit sha 9dc51dee4134db93ee4435ecc3f81d6ccc313448

Merge pull request #2821 from owncloud/clients/desktop-mobile-system-requirements Migrate desktop & mobile system requirements

view details

Christian Schabesberger

commit sha cb76b014a0df279dc577b9a9eb8423cb92b78741

add example body for ocs recipient response

view details

Christian Schabesberger

commit sha c9149adfdc376e62086ae0d208f08534e0f481f4

add meaning of exact blog

view details

Christian Schabesberger

commit sha cca462cbd36b4788604a33c8eb826fe517c834c8

add aditional information

view details

Christian Schabesberger

commit sha 3fa56546e7ec8ce115f890f1867558305ca32b0b

add item type to sharee api url

view details

push time in 5 days

push eventowncloud/android

Christian Schabesberger

commit sha 3e4a5a28748bd0871b7328339038de82a256e8fc

apply suggested changes

view details

push time in 5 days

issue openedOpenSlides/OpenSlides

./build.sh all hangs during installation of npm packages

Describe the bug Command ./build.sh all hangs while running the command ng build --prod "--output-path" "/build/app/static". After some timeout ng is killed and the installation process failes. I'm running the setup on a Hetzner CX11 instance. Could it be that it does not have the power to run it correclty?

How to Reproduce

  1. Get a Hetzner CX11 instance
  2. Install official docker
  3. git clone https://github.com/OpenSlides/OpenSlides.git
  4. run ./build.sh all

Expected behavior Compilation runs through so one can run docker-compose up

System information

  • OpenSlides-Version: [current master]
  • Additional version information (if any): [e.g. commit hash or installation-month]
  • Python Version: [none]
  • Device: [Hetzner CX11]
  • OS: [ubuntu 20.04.1]

Screenshots

...

Step 15/19 : RUN npm run build-to-dir /build/app/static
 ---> Running in 70536dd9fb5b

> OpenSlides3-Client@3.2.0 build-to-dir /build/app
> npm run build -- --output-path "/build/app/static"


> OpenSlides3-Client@3.2.0 build /build/app
> ng build --prod "--output-path" "/build/app/static"

Warning: Entry point 'ngx-papaparse' contains deep imports into '/build/app/node_modules/papaparse/papaparse.min.js'. This is probably not a problem, but may cause the compilation of entry points to be out of order.
Generating ES5 bundles for differential loading...
Killed
npm ERR! code ELIFECYCLE
npm ERR! errno 137
npm ERR! OpenSlides3-Client@3.2.0 build: `ng build --prod "--output-path" "/build/app/static"`
npm ERR! Exit status 137
npm ERR! 
npm ERR! Failed at the OpenSlides3-Client@3.2.0 build script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/openslides/.npm/_logs/2020-10-19T16_21_03_004Z-debug.log
npm ERR! code ELIFECYCLE
npm ERR! errno 137
npm ERR! OpenSlides3-Client@3.2.0 build-to-dir: `npm run build -- --output-path "/build/app/static"`
npm ERR! Exit status 137
npm ERR! 
npm ERR! Failed at the OpenSlides3-Client@3.2.0 build-to-dir script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/openslides/.npm/_logs/2020-10-19T16_21_03_154Z-debug.lo

created time in 5 days

Pull request review commentowncloud/android

New arch/moshi parse sharees

 class OCRemoteShareesDataSourceTest {         } returns getRemoteShareesOperationResult          // Get sharees from remote datasource-        val sharees = ocRemoteShareesDataSource.getSharees(+        sharees = ocRemoteShareesDataSource.getSharees(             "user",             1,             30

yes

theScrabi

comment created time in 5 days

PullRequestReviewEvent

push eventowncloud/android-library

Christian Schabesberger

commit sha c697b2d6a81bc72ac56c605ef218d0c09b6ba316

add changes according to review

view details

push time in 5 days

Pull request review commentowncloud/android-library

New arch/moshi parse sharees

+package com.owncloud.android.lib++import com.owncloud.android.lib.resources.CommonOcsResponse+import com.owncloud.android.lib.resources.shares.responses.ShareeOcsResponse+import com.squareup.moshi.JsonAdapter+import com.squareup.moshi.Moshi+import com.squareup.moshi.Types+import junit.framework.Assert.assertEquals+import junit.framework.Assert.assertTrue+import org.junit.Assert.assertNotEquals+import org.junit.Before+import org.junit.Test+import java.lang.reflect.Type++class ShareeResponseTest {++    var response: CommonOcsResponse<ShareeOcsResponse>? = null++    @Before+    fun prepare() {+        val moshi = Moshi.Builder().build()+        val type: Type = Types.newParameterizedType(CommonOcsResponse::class.java, ShareeOcsResponse::class.java)+        val adapter: JsonAdapter<CommonOcsResponse<ShareeOcsResponse>> = moshi.adapter(type)+        response = adapter.fromJson(EXAMPLE_RESPONSE)+    }++    @Test+    fun `check structure - ok - contains meta`() {+        assertEquals("OK", response?.ocs?.meta?.message!!)+        assertEquals(200, response?.ocs?.meta?.statusCode!!)+        assertEquals("ok", response?.ocs?.meta?.status!!)+        assertTrue(response?.ocs?.meta?.itemsPerPage?.isEmpty()!!)+        assertTrue(response?.ocs?.meta?.totalItems?.isEmpty()!!)+    }++    @Test+    fun `check structure - ok - contains exact`() {+        assertNotEquals(null, response?.ocs?.data?.exact)+    }++    @Test+    fun `check structure - ok - contains groups`() {+        assertNotEquals(null, response?.ocs?.data?.groups)+    }++    @Test+    fun `check structure - ok - contains remotes`() {+        assertNotEquals(null, response?.ocs?.data?.remotes)+    }++    @Test+    fun `check structure - ok - contains users`() {+        assertNotEquals(null, response?.ocs?.data?.users)+    }++    @Test+    fun `check structure - ok - groups contains two items`() {+        assertEquals(2, response?.ocs?.data?.groups?.size)+    }++    @Test+    fun `check structure - ok - users contains two items`() {+        assertEquals(2, response?.ocs?.data?.users?.size)+    }++    @Test+    fun `check structure - ok - exact_users contains one item`() {+        assertEquals(1, response?.ocs?.data?.exact?.users?.size)+    }++    @Test+    fun `check structure - ok - user1 contains additional data`() {+        assertEquals("user1@user1.com", response?.ocs?.data?.users?.get(0)?.value?.additionalInfo)+    }++    @Test+    fun `check structure - ok - user2 does not contain additional data`() {+        assertEquals(null, response!!.ocs.data.users!![1].value!!.additionalInfo)+    }++    companion object {+        val EXAMPLE_RESPONSE = """+{+    "ocs": {+        "data": {+            "exact": {+                "groups": [],

Sounds good

theScrabi

comment created time in 5 days

PullRequestReviewEvent

push eventowncloud/android-library

Christian Schabesberger

commit sha f4b23519e494e894a189be0a0889ab3fff5c8731

prevent acumulating cookies on account change

view details

push time in 5 days

push eventowncloud/android

Christian Schabesberger

commit sha 1165eda07cc6b5fa758a79ab3ec51073479a5f09

scale login background image correctly using matrix

view details

push time in 8 days

PullRequestReviewEvent
PullRequestReviewEvent

issue openedowncloud/android

AppAuth uses ApacheHttp

AppAuthConnection still uses ApacheHttp, which we already replaced with OkHttp in other places. This should be changed in order not to have two network libraries.

created time in 10 days

pull request commentowncloud/android

[Fix] Handle redirections with cookies in OAuth

@jesmrec this PR depends on https://github.com/owncloud/android-library/pull/343. Did you merge it into your testbranch before checking this PR?

abelgardep

comment created time in 10 days

PullRequestReviewEvent
PullRequestReviewEvent
PullRequestReviewEvent

PR opened owncloud/android

Add the new ci images we introduced with oC 10.5

related to: https://github.com/owncloud/android/issues/2991

+0 -0

0 comment

2 changed files

pr created time in 10 days

push eventowncloud/android

Thomas Müller

commit sha 96ae6be86d21ee9faf132a0168ae2d8b3888e55e

[tx] updated from transifex

view details

Christian Schabesberger

commit sha 9dd9767ce442825c23fd1239fd416dc06f489a52

fix error on empty mimetype returned on propfind

view details

Abel García de Prada

commit sha 7e276f344e0a41fd9547889976e39ed064c5dd99

Merge pull request #2986 from owncloud/fix/empty_mimetype_in_propfind fix error on empty mimetype returned on propfind

view details

agarcia

commit sha 565f9ca55d81e460ce43f05444b14a1c1cc046ac

Use android share sheet when sharing links and files

view details

agarcia

commit sha f834a79967d4567fc9d51efd5e7c9f856cb334de

Exclude ownCloud from sharing options

view details

Abel García de Prada

commit sha b932d0170a77b37af6fb8a871c04dc8ec018b05c

Add a custom title to sharesheet

view details

Abel García de Prada

commit sha 9849dc330dfe9fbb7d44c5f717ba044356a1344b

update share sheet title

view details

Abel García de Prada

commit sha dd561fc76addd8876b251152818a00f4049aa3b3

Merge pull request #2968 from owncloud/feature/share_sheet [Feature] Android Sharesheet

view details

Thomas Müller

commit sha 1d25f642ab1bc7c74976a9d3321d9c06ca662b12

[tx] updated from transifex

view details

Christian Scherm

commit sha fa8bf18a2136ec0943dd522948046507eecca917

Add the new ci images we introduced with oC 10.5

view details

push time in 10 days

push eventowncloud/android

Christian Schabesberger

commit sha d291e063d37022c3d6598d4372c8b6af6b5d56f9

update to latest corresponding library

view details

push time in 10 days

push eventowncloud/android-library

agarcia

commit sha a55498c64b748e4014178617610e409f84aef3a4

Remove single cookie header

view details

Abel García de Prada

commit sha 411364b3781a9597b734b85a8f9aa910e360c4db

Merge pull request #344 from owncloud/remove_single_cookie_header Remove single cookie header

view details

agarcia

commit sha 4d22971de0ee27766e618e9e7a279ab681fd4a17

Upgrade version code and version name

view details

Abel García de Prada

commit sha 5d21f01f381ee19bbe591702e6d94c83e727ec34

Merge pull request #346 from owncloud/release/1.0.8 [Release] 1.0.8

view details

Christian Schabesberger

commit sha 5d83d91e597157ad034d9110e2f75bd966525f47

move responses models into module folder

view details

Christian Schabesberger

commit sha 61f4493c18a56c5a98249c2fd3abc6f75cfd6017

clean run method by braking down into small functions

view details

Christian Schabesberger

commit sha 338c3ec0a51b3b12278d2f50123c203a9f302407

add Sharee response model

view details

Christian Schabesberger

commit sha 7ebf63f26a2a1678187f09e15a165c6aadc6c84f

add support for tests

view details

Christian Schabesberger

commit sha acc5caf17efa782ef78fc2211e8fad5cd487fe57

test model

view details

Christian Schabesberger

commit sha 516926395da2187b0a78e32621e81ed05c658172

update GetRemoteShareesOperation to use moshi

view details

Christian Schabesberger

commit sha d64b5d5680a08e3ed61fae14131587a736bfbc8d

update shareeservice to use ShareeOcsResponse

view details

Christian Schabesberger

commit sha b2c88bee7461ad20f0c1b2ec821523c5ec3a8665

get flat representation from ShareeOcsResponse

view details

Christian Schabesberger

commit sha 26c793c6168c5c529229b0ce54fc81ed73d80c34

return sharees without exact match

view details

Christian Schabesberger

commit sha 510147d301ee1243bc444ab3e8e31d8e53799c75

add aditional data field to ocs sharees

view details

Christian Schabesberger

commit sha 492d13454e813b76ff13826fbeb78adf5769eb64

make sharee parts non null that can't be null

view details

Christian Schabesberger

commit sha cf5c4b78afefeeddbecb2ac52507fee7d1c3b5df

disable unitTestBinaryResource as its deprecated

view details

Christian Schabesberger

commit sha 88cb76bab8e940f9e96c935d194faf28c3ef8e44

refactor ShareType

view details

push time in 10 days

push eventowncloud/android

Christian Schabesberger

commit sha 9dd9767ce442825c23fd1239fd416dc06f489a52

fix error on empty mimetype returned on propfind

view details

Abel García de Prada

commit sha 7e276f344e0a41fd9547889976e39ed064c5dd99

Merge pull request #2986 from owncloud/fix/empty_mimetype_in_propfind fix error on empty mimetype returned on propfind

view details

agarcia

commit sha 565f9ca55d81e460ce43f05444b14a1c1cc046ac

Use android share sheet when sharing links and files

view details

agarcia

commit sha f834a79967d4567fc9d51efd5e7c9f856cb334de

Exclude ownCloud from sharing options

view details

Abel García de Prada

commit sha b932d0170a77b37af6fb8a871c04dc8ec018b05c

Add a custom title to sharesheet

view details

Abel García de Prada

commit sha 9849dc330dfe9fbb7d44c5f717ba044356a1344b

update share sheet title

view details

Abel García de Prada

commit sha dd561fc76addd8876b251152818a00f4049aa3b3

Merge pull request #2968 from owncloud/feature/share_sheet [Feature] Android Sharesheet

view details

Thomas Müller

commit sha 1d25f642ab1bc7c74976a9d3321d9c06ca662b12

[tx] updated from transifex

view details

Christian Schabesberger

commit sha 8f84e9afeacc305d20ae2e080eb8ec35531a8194

create OCSharee object and mapper

view details

Christian Schabesberger

commit sha 58a858a893a0bc6ea1a111e8b46054d2d9ee8e70

update oc sharee tests

view details

Christian Schabesberger

commit sha 7559fee7bf110b0c80e0876271d8e17a227dce5b

integrate OCSharee object

view details

Christian Schabesberger

commit sha 247c7688ef6bea59a4bceffb463b5082a83c9941

add factory for RemoteShareeMapper

view details

Christian Schabesberger

commit sha 5bad9f81a84c172b47ef4de849a4f3124198b149

update to latest corresponding library

view details

Christian Schabesberger

commit sha e10faa973925874610836d318135b1f3dcf2478d

fix OCSharee tests

view details

push time in 10 days

push eventowncloud/android

Christian Schabesberger

commit sha 6a124dd1c3d9654c3a56d9d40460ac359277745a

fix OCSharee tests

view details

push time in 11 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 8e52305fbc7f1a338a58a5d5b59978baecfd9a29

refactor ShareType

view details

push time in 11 days

push eventowncloud/android

Christian Schabesberger

commit sha 69f338b4fa9f9a30e51bb4e7328cca712e0da5bb

update to latest corresponding library

view details

push time in 11 days

push eventowncloud/android-library

Christian Schabesberger

commit sha f3b1a1a6ac480c84a4c3449cf5cb3c6a181270d7

disable unitTestBinaryResource as its deprecated

view details

push time in 11 days

push eventowncloud/android

Christian Schabesberger

commit sha aab04c90b4ab771cac49f5d03bab7925cbcc5a3d

add factory for RemoteShareeMapper

view details

push time in 11 days

PR opened owncloud/android-library

New arch/moshi parse sharees

related issue: https://github.com/owncloud/android/issues/2704

+333 -81

0 comment

12 changed files

pr created time in 11 days

create barnchowncloud/android-library

branch : new_arch/moshi_parse_sharees

created branch time in 11 days

PR opened owncloud/android

New arch/moshi parse sharees

related Issue: https://github.com/owncloud/android/issues/2704

+156 -88

0 comment

12 changed files

pr created time in 11 days

create barnchowncloud/android

branch : new_arch/moshi_parse_sharees

created branch time in 11 days

PR closed owncloud/android

New arch/moshi parse shares

related Issue: https://github.com/owncloud/android/issues/2704

+156 -88

0 comment

12 changed files

theScrabi

pr closed time in 11 days

PR opened owncloud/android

New arch/moshi parse shares

related Issue: https://github.com/owncloud/android/issues/2704

+156 -88

0 comment

12 changed files

pr created time in 11 days

push eventowncloud/android

Christian Schabesberger

commit sha e94112de425823271bb13ed04d3dd6b7d776f512

integrate OCSharee object

view details

push time in 11 days

push eventowncloud/android

Christian Schabesberger

commit sha e33a3e92ba3f5443495f55c6073859702de57b7e

update oc sharee tests

view details

push time in 11 days

create barnchowncloud/android

branch : new_arch/moshi_parse_shares

created branch time in 11 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 2a6939bcf9f809178d64638801689cd893be7d72

make sharee parts non null that can't be null

view details

push time in 11 days

push eventowncloud/android-library

Christian Schabesberger

commit sha e47d8e387fe7e177cbe97f7bf02bdaeee8c86db8

add aditional data field to ocs sharees

view details

push time in 11 days

push eventowncloud/docs

Christian Schabesberger

commit sha 34ad1268d494b617cacaecaef4096ebc23d765c7

add aditional information

view details

push time in 11 days

push eventowncloud/android-library

Christian Schabesberger

commit sha f9a3e1e4cc0a3bb39206b6b2d645ba2c68aa30a4

return sharees without exact match

view details

push time in 11 days

push eventowncloud/docs

Christian Schabesberger

commit sha e5c82d9a4cc65d648ca7b09a249013541901248a

add meaning of exact blog

view details

push time in 12 days

push eventowncloud/android-library

Christian Schabesberger

commit sha ab2456059dd4d7f496ff0951b4bc7c1e00e8b44d

update shareeservice to use ShareeOcsResponse

view details

Christian Schabesberger

commit sha dda5492ab4cb2c27db91434d184f3df1839134cb

get flat representation from ShareeOcsResponse

view details

push time in 12 days

PullRequestReviewEvent

push eventowncloud/android-library

Christian Schabesberger

commit sha 5b89f019a15224a8db81d9440ccdeea77179ede2

update GetRemoteShareesOperation to use moshi

view details

push time in 16 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 56842ed3e5e0ff6a7c1d371cadd900d78ddd7334

add support for tests

view details

Christian Schabesberger

commit sha 161e12fb314bea9dcfdd8d9f075b9860a21fcd5b

test model

view details

push time in 16 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 01e5c322833ce8d67c8aff6be39d022591f56ece

add Sharee response model

view details

push time in 16 days

PullRequestReviewEvent

PR closed owncloud/android-library

Reviewers
cleanup GetRemoteStatusOperation Sprint

Cleans GetRemoteStatusOperation which is required for the later bugfixing


BUGS & IMPROVEMENTS

  • [X] (1) http suffix enforced https://github.com/owncloud/android-library/pull/342#issuecomment-695950683 [FIXED]
+627 -280

6 comments

14 changed files

theScrabi

pr closed time in 17 days

PR opened owncloud/docs

update OCS responses
  • add or updated meta object in responses
  • move notification api doc into parent folder
+10 -6

0 comment

5 changed files

pr created time in 17 days

create barnchowncloud/docs

branch : add_meta_to_ocs

created branch time in 17 days

PR opened owncloud/docs

add example body for ocs recipient response

Adds the responses to the ocs recipient api.

Todo:

  • [x] add simple response examples
  • [ ] find our and document how remote sharees look like
  • [ ] find out and document what the meaning of "exact" is
+125 -89

0 comment

3 changed files

pr created time in 17 days

create barnchowncloud/docs

branch : ocs_recipient_response

created branch time in 17 days

PR opened owncloud/android-library

New arch/moshi parse shares

related issue: https://github.com/owncloud/android/issues/2704

+85 -67

0 comment

6 changed files

pr created time in 18 days

create barnchowncloud/android-library

branch : new_arch/moshi_parse_shares

created branch time in 18 days

delete branch owncloud/android-library

delete branch : new_arch/moshi_parse_shares

delete time in 18 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 91e890548786bf5a7768a7c4b53d1fb066bf43f9

move responses models into module folder

view details

Christian Schabesberger

commit sha 58b048209fc8204de40d5d0690a388abfd3cb7d7

clean run method by braking down into small functions

view details

push time in 18 days

PR closed owncloud/android-library

[New arch] Use Moshi to parse shares

related issue: https://github.com/owncloud/android/issues/2704

+347 -357

0 comment

14 changed files

theScrabi

pr closed time in 18 days

push eventowncloud/android-library

Christian Schabesberger

commit sha 02f336a7497bad6d2ebedd1de2bedf9e4e5c9a50

clean run method by braking down into small functions

view details

push time in 18 days

create barnchowncloud/android-library

branch : new_arch/moshi_parse_shares

created branch time in 18 days

issue closedowncloud/android

make bitrise public

Bitrise should be make public in order to ensure external contributors to see the test result of their pull requests. This would be mandatory to ensure external contributions.

Since it would requires us to do more work to get our instrumentation tests running on github actions we decided to stay with bitrise for now. Further reasons can be found here: https://github.com/owncloud/android/pull/2988

closed time in 18 days

theScrabi

issue openedowncloud/android

make bitrise public

Bitrise should be make public in order to ensure external contributors to see the test result of their pull requests. This would be mandatory to ensure external contributions.

Since it would requires us to do more work to get our instrumentation tests running on github actions we decided to stay with bitrise for now. Further reasons can be found here: https://github.com/owncloud/android/pull/2988

created time in 19 days

PR closed owncloud/android-library

CI by Github action

Why not using Github action to run CI ? Then this blackbox Bitrise is obsolete

+19 -0

12 comments

2 changed files

hannesa2

pr closed time in 19 days

push eventowncloud/android-library

Christian Schabesberger

commit sha fc75357b0d20ee74f034a458859ebea1ceaf1985

fix redirect with cookie for satatus

view details

Christian Schabesberger

commit sha 46028c5c2554d6f2af9f00240b24edd8c57f6053

clean up CheckPathExistenceRemoteOperation

view details

Christian Schabesberger

commit sha 412047b4c8761cb1a2682ba5fc05029a779742a6

clean up HttpClient

view details

Christian Schabesberger

commit sha 7a2c61d3bfd0452f0d87bd42253b6d58529c86c3

move OwnCloudClient redirect functionallity into redirection manager

view details

Christian Schabesberger

commit sha 0f4fd626c8381b73dadc8ae2a12ffde3000dbb8a

fix ip address without http prefix not recognized

view details

Christian Schabesberger

commit sha b149f44752c090bb37a60a1b5a039c9fc9aaaaa3

add fixes according to review

view details

Christian Schabesberger

commit sha 6bd1ca7f189a200dc1c9b5080218b0dda2055a32

use robolectric for android tests

view details

push time in 19 days

pull request commentowncloud/android

[New arch] Save file in db

I forgot to push.

theScrabi

comment created time in 19 days

push eventowncloud/android

Christian Schabesberger

commit sha c0003758f56b6d8676cb11f28c6d8159eb984f1d

move library to the same used in new_arch/synchronization

view details

push time in 19 days

pull request commentowncloud/android

move to github ci

This could be an explanation however I haven't seen something like this locally.

theScrabi

comment created time in 19 days

pull request commentowncloud/android

move to github ci

After months you came to the same result

I work on this the first week. I haven't work with GithubCI before.

After months you came to the same result as I, that on bitrise it works magically.

Bitrise uses a dedicated setup for Instrumentation tests. GithubCI does not. The time we spend in trying to get GithubCI working we will need on other Projects and since bitrise works I don't see a reason to move.

On my local machine I've the similar issues like Github has, but I can't verify bitrise settings.

Currently bitrise and testresults are only visible to us. We need to change this. However I could not verify this, only one test fails which may be related to the fact that I didn't disable animations. However GithubCI fails more often. The reason it fails is because it could not launch Intents due to timeout. This looks to me like the machine the emulator runs on is to underpowered for what it should accomplish.

theScrabi

comment created time in 19 days

PR closed owncloud/android-library

Reviewers
move to github CI

This will introducd github CI, based on the submission by @hannesa2: https://github.com/owncloud/android-library/pull/304 This will also add artifact upload and testing:

  • [x] research
  • [x] implement testing
  • [x] implement artifact upload
  • [ ] remove bitrise
+31 -0

1 comment

2 changed files

theScrabi

pr closed time in 19 days

pull request commentowncloud/android-library

move to github CI

I'm closing this for the same reason described here: https://github.com/owncloud/android/pull/2988

theScrabi

comment created time in 19 days

pull request commentowncloud/android

move to github ci

After further investigation I think bitrise so far is the best sollution for Android Instrumentation tests as github Actions for android is kind of a "hack" right now, which apparently runs only in some cases. As it can be seen in the test results here. Espresso tests went through on Bitrise. They went through locally as well. However on Github they did not run properly which could be due to a slow emulator.

I'd recommend to move to the pubic version of bitrise, so other contributors can see what happens on bitrise CI, however for now I wouldn't not recommend moving over to github actions.

theScrabi

comment created time in 19 days

PR closed owncloud/android

move to github ci

This will introducd github CI, based on the submission by @hannesa2: https://github.com/owncloud/android/pull/2816 This will also add artifact upload and testing:

  • [x] research
  • [ ] implement testing
  • [ ] implement artifact upload
  • [ ] remove bitrise
+58 -10

1 comment

2 changed files

theScrabi

pr closed time in 19 days

push eventowncloud/android

Christian Schabesberger

commit sha 469c7f8ea4a505ab3342dfc56cd2681d30a12803

remove unused helper function

view details

push time in 19 days

more