profile
viewpoint
Terin Stock terinjokes @cloudflare San Francisco, CA http://terinstock.com Software Engineer @Cloudflare working on Kubernetes

cloudflare/certmgr 156

Automated certificate management using a CFSSL CA.

cloudflare/docker-phan 58

Dockerization of the Phan PHP static analysis tool

cloudflare/ipvs 53

Package ipvs allows you to manage Linux IPVS services and destinations

cloudflare/authr 27

:key: a flexible and expressive approach to access-control

substack/node-nub 17

Uniqueness functions for node

terinjokes/bakelite 5

injects resin into a mold to produce groovy Go programs

terinjokes/BlackScreen 4

Setting the wallpaper of all your screens to black (or another custom image), so you don't have to.

terinjokes/BMDSwitcherMock 3

A Mock COM for testing against the BMDSwitcherAPI

terinjokes/contenteditable 3

Fixing contenteditable

startedvernemq/vernemq

started time in 8 hours

startedhumphrej/rules_dhall

started time in 2 days

starteddoitintl/kube-no-trouble

started time in 6 days

startedgeocom/Wahoo-Sender

started time in 7 days

push eventcloudflare/node-cloudflare

Deployment Bot (from Travis CI)

commit sha a680b7653ae15c3eb753e354a61f811ab14d76a1

Deploy cloudflare/node-cloudflare to github.com/cloudflare/node-cloudflare.git:gh-pages

view details

push time in 8 days

delete branch cloudflare/node-cloudflare

delete branch : patches/api-stream

delete time in 8 days

created tagcloudflare/node-cloudflare

tagv2.9.0

Node.js API for Client API

created time in 8 days

PR closed cloudflare/node-cloudflare

feat: Video Stream API

This PR adds support for Video Stream API https://api.cloudflare.com/#stream-videos-properties

+93 -0

3 comments

2 changed files

jsoizo

pr closed time in 8 days

pull request commentcloudflare/node-cloudflare

feat: Video Stream API

Merged as 2079b457e7ceae23e52e1bfa4d426a5a53ceb81b.

jsoizo

comment created time in 8 days

push eventcloudflare/node-cloudflare

Jun Sakamoto

commit sha 2079b457e7ceae23e52e1bfa4d426a5a53ceb81b

feat(api): support Cloudflare Stream Adds support for the Cloudflare Stream api. Signed-off-by: Terin Stock <terinjokes@gmail.com>

view details

push time in 8 days

push eventcloudflare/node-cloudflare

Deployment Bot (from Travis CI)

commit sha b4139ca8096722729a1efbbd280c81dd1e46a61b

Deploy cloudflare/node-cloudflare to github.com/cloudflare/node-cloudflare.git:gh-pages

view details

push time in 8 days

push eventcloudflare/node-cloudflare

Perlover

commit sha 9072fdadf4a464fac62f4d17ee26c49892e8113a

feat(api): support Page Rules Supports managing Page Rules resources. Signed-off-by: Terin Stock <terinjokes@gmail.com>

view details

Jun Sakamoto

commit sha 2079b457e7ceae23e52e1bfa4d426a5a53ceb81b

feat(api): support Cloudflare Stream Adds support for the Cloudflare Stream api. Signed-off-by: Terin Stock <terinjokes@gmail.com>

view details

push time in 8 days

push eventcloudflare/node-cloudflare

Perlover

commit sha 9072fdadf4a464fac62f4d17ee26c49892e8113a

feat(api): support Page Rules Supports managing Page Rules resources. Signed-off-by: Terin Stock <terinjokes@gmail.com>

view details

push time in 8 days

delete branch cloudflare/node-cloudflare

delete branch : patches/codegen

delete time in 8 days

delete branch cloudflare/node-cloudflare

delete branch : patches/typescript

delete time in 8 days

create barnchcloudflare/node-cloudflare

branch : patches/api-stream

created branch time in 8 days

push eventcloudflare/node-cloudflare

Deployment Bot (from Travis CI)

commit sha 54958e3f478df421bec2788549d2f57840f1b17e

Deploy cloudflare/node-cloudflare to github.com/cloudflare/node-cloudflare.git:gh-pages

view details

push time in 8 days

PR closed cloudflare/node-cloudflare

I added the Page Rules instance

Hello!

I added the Page Rules instance and already tested successfully by this code for example:

cf.pageRules.add(zoneId, {
    targets: [
        {
            "target": "url",
            "constraint": {
                "operator": "matches",
                "value": `https://${domain}/*`
            }
        }
    ],
    actions: [
        {
            "id": "cache_level",
            "value": "cache_everything"
        }
    ]
})
+84 -0

2 comments

2 changed files

Perlover

pr closed time in 8 days

pull request commentcloudflare/node-cloudflare

I added the Page Rules instance

Merged as f20a428e06ab6eabfe854bc6919df97d0740c54c.

Perlover

comment created time in 8 days

push eventcloudflare/node-cloudflare

Perlover

commit sha f20a428e06ab6eabfe854bc6919df97d0740c54c

feat(api): support Page Rules Supports managing Page Rules resources. Signed-off-by: Terin Stock <terinjokes@gmail.com>

view details

push time in 8 days

PR closed cloudflare/node-cloudflare

fixed bug where entire application would fail, in cases where process.versions is undefined

In web applications such as Vue.js, process.versions is not available. This causes the entire application to crash. Here's an easy fix, but feel free to suggest a better solution.

+2 -1

6 comments

1 changed file

Xayer

pr closed time in 8 days

PR closed cloudflare/node-cloudflare

Fix Markdown: MD022 Headers should be surrounded by blank lines.

https://github.com/markdownlint/markdownlint/blob/master/docs/RULES.md

+2 -0

2 comments

1 changed file

jbampton

pr closed time in 8 days

pull request commentcloudflare/node-cloudflare

Fix Markdown: MD022 Headers should be surrounded by blank lines.

Merged as 5cf5f1cd65c896d7e73cee7f0d213ba83191ab37.

jbampton

comment created time in 8 days

push eventcloudflare/node-cloudflare

John Bampton

commit sha 5cf5f1cd65c896d7e73cee7f0d213ba83191ab37

doc(readme): surround headers by blank lines Surrounds headers in readme by blank lines. Signed-off-by: Terin Stock <terinjokes@gmail.com>

view details

push time in 8 days

pull request commentcloudflare/node-cloudflare

restore accountAccessFirewall and others

These are from a experimental (and abandoned) branch, I'm not entirely sure they actually work, since they were meant to be paired with other changes. I'll accept smaller PRs focused on adding functionality actually used.

nosovk

comment created time in 8 days

PR closed cloudflare/node-cloudflare

restore accountAccessFirewall and others

https://github.com/cloudflare/node-cloudflare/issues/15

restored accountAccessFirewall and other methods from https://github.com/cloudflare/node-cloudflare/commit/b6a097c58995dd087da4a4b7fddc4b43f340783a

+391 -1

1 comment

14 changed files

nosovk

pr closed time in 8 days

startedyabits/9pfsPkg

started time in 8 days

issue commentcloudflare/node-cloudflare

Return all custom hostnames on cf.zoneCustomHostNames.browse(<ZONE_ID>) instead of just page 1

Yeah, those can be improved, they were done by me in an afternoon as a proof of concept.

In general, it's method(required1, required2, requiredN, [queryParams, [options]]), where the required parameters fill in parts of the URL.

Connor-Cahill

comment created time in 8 days

issue commentcloudflare/node-cloudflare

Return all custom hostnames on cf.zoneCustomHostNames.browse(<ZONE_ID>) instead of just page 1

You should be able to return multiple pages by passing it in:

cf.zoneCustomHostNames.browse('023e105f4ecef8ad9ca31a8372d0c353', {
	page: 2,
	per_page: 100
});
Connor-Cahill

comment created time in 9 days

startedbatchcorp/plumber

started time in 11 days

startedpoltergeisha/Roll20-Like-A-Boss

started time in 13 days

startedRedReign/Roll20-Dark-Theme

started time in 13 days

startedlambdalisue/fern.vim

started time in 13 days

startedbluewaysw/pcgeos

started time in 15 days

issue closedterinjokes/gulp-uglify

Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.

I got an warning error when gulify js file

(node:40475) [DEP0097] DeprecationWarning: Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.

Here is my code

gulp.task('minify-js', async function() {
    await gulp.src('./source/js/SimpleCore.js')
        .pipe(babel())
        .pipe(uglify())
        .pipe(rename({ extname: '.min.js' }))
        .pipe(gulp.dest('./source/js'));
});

When remove pipe(uglify()) everything is fine. But if added nothing will be generated...

Node version is 12.16.0....

image

closed time in 17 days

kunyintang

issue commentterinjokes/gulp-uglify

Using a domain property in MakeCallback is deprecated. Use the async_context variant of MakeCallback or the AsyncResource class instead.

This is a warning, not an error. It also doesn't come as a result of this project.

kunyintang

comment created time in 17 days

startedGoldenCheetah/GoldenCheetah

started time in 18 days

startedlarioj/plum

started time in 18 days

startednicolagi/pine

started time in 18 days

startedfwmark/registry

started time in 20 days

startedlegalnonsense/elgantt

started time in 20 days

issue commentcloudflare/node-cloudflare

Firewall access rules for a zone

I don't believe accountAccessFirewall was ever on master. I have no objections to merging it in if there's PRs.

geoffreak

comment created time in 20 days

pull request commentgulpjs/glob-watcher

WIP: v6

I would totes be cool with merging this in now, and tackling the other two as separate PRs on the milestone.

phated

comment created time in 21 days

pull request commentgulpjs/glob-watcher

deps: update chokidar to 3.x

The current version of chokidar used by this project is broken on Node.js v12.x

Gulp's test suite still seems to pass on 12.x

I'm a bit confused. Is there a way to see these test runs somewhere?

MylesBorins

comment created time in 22 days

issue commentcloudflare/node-cloudflare

Dependencies upgrade

@vkentta this is believed to be fixed in 2.8.0

artursudnik

comment created time in 22 days

GollumEvent

issue commentwhatwg/console

Add a Console Function that Returns a Value

I took a look at a few functional programming languages. I noticed that among them the equivalent of a console.log are treated as functions that perform side effects (or cause IO) and return an equivalent of undefined or void.

I'm not sure this is something that needs to be added to console. Collection libraries already have support for handling side effects (such as _.tap or RxJS.tap) which would be far more flexible than adding it here.

easilyBaffled

comment created time in a month

PR closed cloudflare/node-cloudflare

chore(deps): bump lodash from 4.17.4 to 4.17.19 dependencies

Bumps lodash from 4.17.4 to 4.17.19. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lodash/lodash/releases">lodash's releases</a>.</em></p> <blockquote> <h2>4.17.16</h2> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/lodash/lodash/commit/d7fbc52ee0466a6d248f047b5d5c3e6d1e099056"><code>d7fbc52</code></a> Bump to v4.17.19</li> <li><a href="https://github.com/lodash/lodash/commit/2e1c0f22f425e9c013815b2cd7c2ebd51f49a8d6"><code>2e1c0f2</code></a> Add npm-package</li> <li><a href="https://github.com/lodash/lodash/commit/1b6c282299f4e0271f932b466c67f0f822aa308e"><code>1b6c282</code></a> Bump to v4.17.18</li> <li><a href="https://github.com/lodash/lodash/commit/a370ac81408de2da77a82b3c4b61a01a3b9c2fac"><code>a370ac8</code></a> Bump to v4.17.17</li> <li><a href="https://github.com/lodash/lodash/commit/1144918f3578a84fcc4986da9b806e63a6175cbb"><code>1144918</code></a> Rebuild lodash and docs</li> <li><a href="https://github.com/lodash/lodash/commit/3a3b0fd339c2109563f7e8167dc95265ed82ef3e"><code>3a3b0fd</code></a> Bump to v4.17.16</li> <li><a href="https://github.com/lodash/lodash/commit/c84fe82760fb2d3e03a63379b297a1cc1a2fce12"><code>c84fe82</code></a> fix(zipObjectDeep): prototype pollution (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4759">#4759</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/e7b28ea6cb17b4ca021e7c9d66218c8c89782f32"><code>e7b28ea</code></a> Sanitize sourceURL so it cannot affect evaled code (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4518">#4518</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/0cec225778d4ac26c2bac95031ecc92a94f08bbb"><code>0cec225</code></a> Fix lodash.isEqual for circular references (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4320">#4320</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4515">#4515</a>)</li> <li><a href="https://github.com/lodash/lodash/commit/94c3a8133cb4fcdb50db72b4fd14dd884b195cd5"><code>94c3a81</code></a> Document matches* shorthands for over* methods (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4510">#4510</a>) (<a href="https://github-redirect.dependabot.com/lodash/lodash/issues/4514">#4514</a>)</li> <li>Additional commits viewable in <a href="https://github.com/lodash/lodash/compare/4.17.4...4.17.19">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~mathias">mathias</a>, a new releaser for lodash since your current version.</p> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+3 -8

1 comment

1 changed file

dependabot[bot]

pr closed time in a month

issue closedcloudflare/node-cloudflare

Using cloudflare 2.7.0 with got 11.5.0 breaks got's DNS resolver globally

This bug just happened today and is one of those that make me give up my faith in humanity and computers. Just posting this here in case someone else has this problem.

This file will work just fine:

import got from 'got'

;(async() => {
  console.dir(await got('https://icanhazip.com'))
})()

This won't:

import got from 'got'
import * as cloudflare from 'cloudflare'

;(async() => {
  console.dir(await got('https://icanhazip.com'))
})()
(node:17224) UnhandledPromiseRejectionWarning: RequestError: connect ECONNREFUSED 127.0.0.1:443
    at ClientRequest.<anonymous> (node_modules/got/dist/source/core/index.js:889:25)
    at Object.onceWrapper (events.js:422:26)
    at ClientRequest.emit (events.js:327:22)
    at ClientRequest.EventEmitter.emit (domain.js:485:12)
    at ClientRequest.origin.emit (node_modules/@szmarczak/http-timer/dist/source/index.js:39:20)
    at TLSSocket.socketErrorListener (_http_client.js:432:9)
    at TLSSocket.emit (events.js:315:20)
    at TLSSocket.EventEmitter.emit (domain.js:485:12)
    at emitErrorNT (internal/streams/destroy.js:84:8)
    at processTicksAndRejections (internal/process/task_queues.js:84:21)
    at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1141:16)

Note that I'm not even using the imported package, the import itself is sufficient to break all usages of got in the whole file.

The fix was to bump the version of cloudflare to 2.8.0 in the package.json. SMH.

closed time in a month

tobiasmuehl

pull request commentterinjokes/gulp-uglify

Fix sourcemap corruption - use composite map from UglifyJS

I'd prefer tests not call out to UglifyJS. It's out of scope for this project to ensure we are seeing a specific byte pattern from them. In fact, in the next major version of this project, we're unlikely to be depending on UglifyJS at all, and users will expected to provide their own (like a few other Gulp plugins). If UglifyJS, or a fork, make another breaking change, that's going to be on them.

You can make that change, or I can do so when merging the rest. Thanks for digging into this and sending a PR.

Jimbly

comment created time in a month

pull request commentterinjokes/gulp-uglify

Fix sourcemap corruption - use composite map from UglifyJS

This is a simple enough single line of code being minified that I would expect it to be stable

UglifyJS makes no promises on the identifiers it uses when minifying.

Jimbly

comment created time in a month

Pull request review commentterinjokes/gulp-uglify

Fix sourcemap corruption - use composite map from UglifyJS

 var assert = require('assert'); var Buffer = require('safe-buffer').Buffer; var Vinyl = require('vinyl'); var SourceListMap = require('source-list-map').SourceListMap;-var fromStringWithSourceMap = require('source-list-map')-  .fromStringWithSourceMap; var td = require('testdouble'); var minify = require('../lib/minify');+// Use actual UglifyJS so we are validating that the final sourcemap is indeed merged+var uglify = require('uglify-js');

This isn't going to be stable across versions.

Jimbly

comment created time in a month

startedGekkio/gb-hardware-db

started time in a month

startedawslabs/s2n

started time in a month

startedx64dbg/x64dbg

started time in a month

startedMattiwatti/EfiGuard

started time in a month

startedjwhited/wgsd

started time in a month

push eventcloudflare/node-cloudflare

Deployment Bot (from Travis CI)

commit sha 71d81f23d17327994fdeebb1934dd1da4271c888

Deploy cloudflare/node-cloudflare to github.com/cloudflare/node-cloudflare.git:gh-pages

view details

push time in a month

push eventcloudflare/node-cloudflare

John Bampton

commit sha 39d716f691a424c10e0de20f53e9afe08b654e30

Fix spelling

view details

push time in a month

startedjwhited/corebgp

started time in a month

pull request commentcloudflare/node-cloudflare

fixed bug where entire application would fail, in cases where process.versions is undefined

This package doesn't support the browser, as there's a CORS policy preventing API access.

Xayer

comment created time in a month

startedsimilarweb/statusbay

started time in a month

startedphillipberndt/autorandr

started time in a month

startedsulami/literate-calc-mode.el

started time in a month

startedsudleyplace/DPMIONE

started time in a month

starteddabreegster/abstreet

started time in a month

issue commentsourcegraph/sourcegraph

redis-exporter image is 32-bit and not open-source

We migrated to a newer redis_exporter image without issue.

terinjokes

comment created time in a month

startedSweets/tiramisu

started time in a month

startedeiginn/ipcalc

started time in a month

startedcloudflare/sandbox

started time in a month

startedGenymobile/scrcpy

started time in a month

startedyihui/hugo-xmin

started time in a month

startederkin/gophwr

started time in 2 months

startedisovalent/kube-test-harness

started time in 2 months

startedoetiker/znapzend

started time in 2 months

startedmdlayher/sdnotify

started time in 2 months

startedjuanfont/headscale

started time in 2 months

startedOpenDiablo2/OpenDiablo2

started time in 2 months

startedymattw/ydiff

started time in 2 months

starteddandavison/delta

started time in 2 months

startedfelixge/fgprof

started time in 2 months

startedgluon-lang/gluon

started time in 2 months

startedeerimoq/monolinux

started time in 2 months

startedeerimoq/nala

started time in 2 months

push eventcloudflare/node-cloudflare

Deployment Bot (from Travis CI)

commit sha af5e4b4e45f81de9cceb6a7a29d0f9b00b88590e

Deploy cloudflare/node-cloudflare to github.com/cloudflare/node-cloudflare.git:gh-pages

view details

push time in 2 months

push eventcloudflare/node-cloudflare

Terin Stock

commit sha 41568a5f7d83c58924393ab0219466e2611ada56

v2.8.0

view details

push time in 2 months

created tagcloudflare/node-cloudflare

tagv2.8.0

Node.js API for Client API

created time in 2 months

PR closed cloudflare/node-cloudflare

chore(deps-dev): bump eslint from 4.15.0 to 4.18.2 dependencies

Bumps eslint from 4.15.0 to 4.18.2. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/eslint/eslint/releases">eslint's releases</a>.</em></p> <blockquote> <h2>v4.18.2</h2> <ul> <li>6b71fd0 Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10022">#10022</a>) (Mathieu Seiler)</li> <li>3c697de Chore: fix incorrect comment about linter.verify return value (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10030">#10030</a>) (Teddy Katz)</li> <li>9df8653 Chore: refactor parser-loading out of linter.verify (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10028">#10028</a>) (Teddy Katz)</li> <li>f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10002">#10002</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10019">#10019</a>) (Jamie Davis)</li> <li>e4f52ce Chore: Simplify dataflow in linter.verify (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10020">#10020</a>) (Teddy Katz)</li> <li>33177cd Chore: make library files non-executable (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10021">#10021</a>) (Teddy Katz)</li> <li>558ccba Chore: refactor directive comment processing (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10007">#10007</a>) (Teddy Katz)</li> <li>18e15d9 Chore: avoid useless catch clauses that just rethrow errors (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10010">#10010</a>) (Teddy Katz)</li> <li>a1c3759 Chore: refactor populating configs with defaults in linter (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10006">#10006</a>) (Teddy Katz)</li> <li>aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9954">#9954</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9985">#9985</a>) (Rachael Sim)</li> </ul> <h2>v4.18.1</h2> <ul> <li>f417506 Fix: ensure no-await-in-loop reports the correct node (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9992">#9992</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9993">#9993</a>) (Teddy Katz)</li> <li>3e99363 Docs: Fixed typo in key-spacing rule doc (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9987">#9987</a>) (Jaid)</li> <li>7c2cd70 Docs: deprecate experimentalObjectRestSpread (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9986">#9986</a>) (Toru Nagashima)</li> </ul> <h2>v4.18.0</h2> <ul> <li>70f22f3 Chore: Apply memoization to config creation within glob utils (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9944">#9944</a>) (Kenton Jacobsen)</li> <li>0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9882">#9882</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9951">#9951</a>) (Teddy Katz)</li> <li>47ac478 Update: add named imports and exports for object-curly-newline (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9876">#9876</a>) (Nicholas Chua)</li> <li>e8efdd0 Fix: support Rest/Spread Properties (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9885">#9885</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9943">#9943</a>) (Toru Nagashima)</li> <li>f012b8c Fix: support Async iteration (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9891">#9891</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9957">#9957</a>) (Toru Nagashima)</li> <li>74fa253 Docs: Clarify no-mixed-operators options (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9962">#9962</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9964">#9964</a>) (Ivan Hayes)</li> <li>426868f Docs: clean up key-spacing docs (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9900">#9900</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9963">#9963</a>) (Abid Uzair)</li> <li>4a6f22e Update: support eslint-disable-* block comments (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/8781">#8781</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9745">#9745</a>) (Erin)</li> <li>777283b Docs: Propose fix typo for function (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9965">#9965</a>) (John Eismeier)</li> <li>bf3d494 Docs: Fix typo in max-len ignorePattern example. (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9956">#9956</a>) (Tim Martin)</li> <li>d64fbb4 Docs: fix typo in prefer-destructuring.md example (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9930">#9930</a>) (Vse Mozhet Byt)</li> <li>f8d343f Chore: Fix default issue template (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9946">#9946</a>) (Kai Cataldo)</li> </ul> <h2>v4.17.0</h2> <ul> <li>1da1ada Update: Add "multiline" type to padding-line-between-statements (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/8668">#8668</a>) (Matthew Bennett)</li> <li>bb213dc Chore: Use messageIds in some of the core rules (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9648">#9648</a>) (Jed Fox)</li> <li>1aa1970 Docs: remove outdated rule naming convention (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9925">#9925</a>) (Teddy Katz)</li> <li>3afaff6 Docs: Add prefer-destructuring variable reassignment example (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9873">#9873</a>) (LePirlouit)</li> <li>d20f6b4 Fix: Typo in error message when running npm (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9866">#9866</a>) (Maciej Kasprzyk)</li> <li>51ec6a7 Docs: Use GitHub Multiple PR/Issue templates (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9911">#9911</a>) (Kai Cataldo)</li> <li>dc80487 Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9907">#9907</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9906">#9906</a>) (Kevin Partington)</li> <li>084351b Docs: Fix the messageId example (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9889">#9889</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9892">#9892</a>) (Jed Fox)</li> <li>9cbb487 Docs: Mention the <code>globals</code> key in the no-undef docs (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9867">#9867</a>) (Dan Dascalescu)</li> </ul> <h2>v4.16.0</h2> <ul> <li>e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/7567">#7567</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9796">#9796</a>) (Michael Ficarra)</li> <li>af043eb Update: Add NewExpression support to comma-style (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9591">#9591</a>) (Frazer McLean)</li> <li>4f898c7 Build: Fix JSDoc syntax errors (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9813">#9813</a>) (Matija Marohnić)</li> <li>13bcf3c Fix: Removing curly quotes in no-eq-null report message (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9852">#9852</a>) (Kevin Partington)</li> <li>b96fb31 Docs: configuration hierarchy for CLIEngine options (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9526">#9526</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9855">#9855</a>) (PiIsFour)</li> <li>8ccbdda Docs: Clarify that -c configs merge with <code>.eslintrc.</code> (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9535">#9535</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9847">#9847</a>) (Kevin Partington)</li> <li>978574f Docs: Fix examples for no-useless-escape (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9853">#9853</a>) (Toru Kobayashi)</li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/eslint/eslint/blob/master/CHANGELOG.md">eslint's changelog</a>.</em></p> <blockquote> <p>v4.18.2 - March 2, 2018</p> <ul> <li>6b71fd0 Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10022">#10022</a>) (Mathieu Seiler)</li> <li>3c697de Chore: fix incorrect comment about linter.verify return value (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10030">#10030</a>) (Teddy Katz)</li> <li>9df8653 Chore: refactor parser-loading out of linter.verify (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10028">#10028</a>) (Teddy Katz)</li> <li>f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10002">#10002</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10019">#10019</a>) (Jamie Davis)</li> <li>e4f52ce Chore: Simplify dataflow in linter.verify (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10020">#10020</a>) (Teddy Katz)</li> <li>33177cd Chore: make library files non-executable (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10021">#10021</a>) (Teddy Katz)</li> <li>558ccba Chore: refactor directive comment processing (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10007">#10007</a>) (Teddy Katz)</li> <li>18e15d9 Chore: avoid useless catch clauses that just rethrow errors (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10010">#10010</a>) (Teddy Katz)</li> <li>a1c3759 Chore: refactor populating configs with defaults in linter (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10006">#10006</a>) (Teddy Katz)</li> <li>aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9954">#9954</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9985">#9985</a>) (Rachael Sim)</li> </ul> <p>v4.18.1 - February 20, 2018</p> <ul> <li>f417506 Fix: ensure no-await-in-loop reports the correct node (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9992">#9992</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9993">#9993</a>) (Teddy Katz)</li> <li>3e99363 Docs: Fixed typo in key-spacing rule doc (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9987">#9987</a>) (Jaid)</li> <li>7c2cd70 Docs: deprecate experimentalObjectRestSpread (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9986">#9986</a>) (Toru Nagashima)</li> </ul> <p>v4.18.0 - February 16, 2018</p> <ul> <li>70f22f3 Chore: Apply memoization to config creation within glob utils (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9944">#9944</a>) (Kenton Jacobsen)</li> <li>0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9882">#9882</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9951">#9951</a>) (Teddy Katz)</li> <li>47ac478 Update: add named imports and exports for object-curly-newline (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9876">#9876</a>) (Nicholas Chua)</li> <li>e8efdd0 Fix: support Rest/Spread Properties (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9885">#9885</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9943">#9943</a>) (Toru Nagashima)</li> <li>f012b8c Fix: support Async iteration (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9891">#9891</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9957">#9957</a>) (Toru Nagashima)</li> <li>74fa253 Docs: Clarify no-mixed-operators options (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9962">#9962</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9964">#9964</a>) (Ivan Hayes)</li> <li>426868f Docs: clean up key-spacing docs (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9900">#9900</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9963">#9963</a>) (Abid Uzair)</li> <li>4a6f22e Update: support eslint-disable- block comments (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/8781">#8781</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9745">#9745</a>) (Erin)</li> <li>777283b Docs: Propose fix typo for function (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9965">#9965</a>) (John Eismeier)</li> <li>bf3d494 Docs: Fix typo in max-len ignorePattern example. (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9956">#9956</a>) (Tim Martin)</li> <li>d64fbb4 Docs: fix typo in prefer-destructuring.md example (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9930">#9930</a>) (Vse Mozhet Byt)</li> <li>f8d343f Chore: Fix default issue template (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9946">#9946</a>) (Kai Cataldo)</li> </ul> <p>v4.17.0 - February 2, 2018</p> <ul> <li>1da1ada Update: Add "multiline" type to padding-line-between-statements (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/8668">#8668</a>) (Matthew Bennett)</li> <li>bb213dc Chore: Use messageIds in some of the core rules (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9648">#9648</a>) (Jed Fox)</li> <li>1aa1970 Docs: remove outdated rule naming convention (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9925">#9925</a>) (Teddy Katz)</li> <li>3afaff6 Docs: Add prefer-destructuring variable reassignment example (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9873">#9873</a>) (LePirlouit)</li> <li>d20f6b4 Fix: Typo in error message when running npm (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9866">#9866</a>) (Maciej Kasprzyk)</li> <li>51ec6a7 Docs: Use GitHub Multiple PR/Issue templates (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9911">#9911</a>) (Kai Cataldo)</li> <li>dc80487 Update: space-unary-ops uses astUtils.canTokensBeAdjacent (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9907">#9907</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9906">#9906</a>) (Kevin Partington)</li> <li>084351b Docs: Fix the messageId example (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9889">#9889</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9892">#9892</a>) (Jed Fox)</li> <li>9cbb487 Docs: Mention the <code>globals</code> key in the no-undef docs (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9867">#9867</a>) (Dan Dascalescu)</li> </ul> <p>v4.16.0 - January 19, 2018</p> <ul> <li>e26a25f Update: allow continue instead of if wrap in guard-for-in (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/7567">#7567</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9796">#9796</a>) (Michael Ficarra)</li> <li>af043eb Update: Add NewExpression support to comma-style (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/9591">#9591</a>) (Frazer McLean)</li> </ul> <!-- raw HTML omitted --> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/eslint/eslint/commit/22ff6f3ab122f61c10fa51f9b1082f2e6f302938"><code>22ff6f3</code></a> 4.18.2</li> <li><a href="https://github.com/eslint/eslint/commit/817b84bf523dee12884ed37c9c86328e9fb5c532"><code>817b84b</code></a> Build: changelog update for 4.18.2</li> <li><a href="https://github.com/eslint/eslint/commit/6b71fd0bcbf9cc00ed4076587f5692b72f6e9aa5"><code>6b71fd0</code></a> Fix: table@4.0.2, because 4.0.3 needs "ajv": "^6.0.1" (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10022">#10022</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/3c697de6182b19d49b910a33b1bc6b0a0e2569b3"><code>3c697de</code></a> Chore: fix incorrect comment about linter.verify return value (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10030">#10030</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/9df865326616b9865ab186c9769e95bc0bf98a20"><code>9df8653</code></a> Chore: refactor parser-loading out of linter.verify (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10028">#10028</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/f6901d0bcf6c918ac4e5c6c7c4bddeb2cb715c09"><code>f6901d0</code></a> Fix: remove catastrophic backtracking vulnerability (fixes <a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10002">#10002</a>) (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10019">#10019</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/e4f52ce6a6b6149e21b1d1a2f3f5f71d58d7106a"><code>e4f52ce</code></a> Chore: Simplify dataflow in linter.verify (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10020">#10020</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/33177cd863e37897fd1c7e98f2f69ba31028453b"><code>33177cd</code></a> Chore: make library files non-executable (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10021">#10021</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/558ccba0fc8cafd969c7f18ff09be7fc0670536f"><code>558ccba</code></a> Chore: refactor directive comment processing (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10007">#10007</a>)</li> <li><a href="https://github.com/eslint/eslint/commit/18e15d978c17503f7ca352333a47069afcb70a1c"><code>18e15d9</code></a> Chore: avoid useless catch clauses that just rethrow errors (<a href="https://github-redirect.dependabot.com/eslint/eslint/issues/10010">#10010</a>)</li> <li>Additional commits viewable in <a href="https://github.com/eslint/eslint/compare/v4.15.0...v4.18.2">compare view</a></li> </ul> </details> <br />

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


<details> <summary>Dependabot commands and options</summary> <br />

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

</details>

+202 -251

0 comment

1 changed file

dependabot[bot]

pr closed time in 2 months

push eventcloudflare/node-cloudflare

Deployment Bot (from Travis CI)

commit sha 006cb61dd7d96e89d7a610149c85cec279fb1867

Deploy cloudflare/node-cloudflare to github.com/cloudflare/node-cloudflare.git:gh-pages

view details

push time in 2 months

issue closedcloudflare/node-cloudflare

Https-proxy-agent needs updating

We are using cloudflare-node version 2.7.0 and cannot use got due to the related issue. cloudflare has a dependency that needs updating cloudflare@2.7.0 └─┬ https-proxy-agent@2.2.4 └── agent-base@4.3.0

related issue: https://github.com/sindresorhus/got/issues/1039

closed time in 2 months

justinasfour04

push eventcloudflare/node-cloudflare

Alex Brown

commit sha 0da93f11521969343214816506ea536ea0d5a65c

Bump https-proxy-agent to 5.0.0

view details

push time in 2 months

PR merged cloudflare/node-cloudflare

Bump https-proxy-agent to 5.0.0

This bumps https-proxy-agent to a version that no longer includes the monkey-patching mentioned in #57 which breaks got https requests (and possibly other http libs)

All project tests are still passing

+43 -24

3 comments

2 changed files

cinder-fish

pr closed time in 2 months

startedJakz/retro8

started time in 2 months

Pull request review commentcloudflare/certmgr

Allow specs to configure what key usage we validate against

 type SpecOptions struct { 	// This is Primarily useful to force an initial randomization if many nodes with certmgr are restarted all 	// at the same time. 	InitialSplay time.Duration++	// KeyUsages specifies what this key will be used for, so that certmgr can verify it is valid for that usage.+	// It is optional and by default we assume keys will be used for "TLS Web Server Authentication"

Can you default elsewhere and make it required in this package?

jmunson

comment created time in 2 months

Pull request review commentcloudflare/certmgr

Allow specs to configure what key usage we validate against

 func ReadSpecFile(path string, defaults *ParsableSpecOptions) (*cert.Spec, error 	// transfer the parsed durations into their final resting spot. 	spec.FinalizeSpecOptionParsing() +	if len(spec.ParsedKeyUsages) > 0 {+		for _, KeyUsageRaw := range spec.ParsedKeyUsages {+			keyUsage, ok := config.ExtKeyUsage[strings.ToLower(KeyUsageRaw)]+			if !ok {+				return nil, fmt.Errorf("spec %s specifies unknown key usage '%s'. Valid values are: [%v]", path, KeyUsageRaw, validExtUsage)+			} else {+				spec.KeyUsages = append(spec.KeyUsages, keyUsage)

You can remove the else clause, as you have a return.

jmunson

comment created time in 2 months

Pull request review commentcloudflare/certmgr

Allow specs to configure what key usage we validate against

 func ReadSpecFile(path string, defaults *ParsableSpecOptions) (*cert.Spec, error 	// transfer the parsed durations into their final resting spot. 	spec.FinalizeSpecOptionParsing() +	if len(spec.ParsedKeyUsages) > 0 {+		for _, KeyUsageRaw := range spec.ParsedKeyUsages {+			keyUsage, ok := config.ExtKeyUsage[strings.ToLower(KeyUsageRaw)]+			if !ok {+				return nil, fmt.Errorf("spec %s specifies unknown key usage '%s'. Valid values are: [%v]", path, KeyUsageRaw, validExtUsage)

Would it be better to use %q with []string?

jmunson

comment created time in 2 months

Pull request review commentcloudflare/certmgr

Allow specs to configure what key usage we validate against

 A certificate spec has the following fields: * `take_actions_only_if_running`: boolean, if true, only fire a spec's action if the service is actually running.   If this is set to false (the default for historical reasons), this can lead to certmgr starting a downed service   when PKI expiry occurs.+* `key_usages`: optional: An array of strings defining what this key should be used for. Certmgr will consider a cert invalid

Can you link to a specific tag, rather than master?

jmunson

comment created time in 2 months

more