profile
viewpoint

mysqljs/mysql 15860

A pure node.js JavaScript Client implementing the MySQL protocol.

eugeneware/debowerify 504

A browserify transform to enable the easy use of bower components in browserify client javascript projects. This can be used in conjunction with deamdify to require AMD components from bower as well.

sidorares/pugify 43

jade transform for browserify v2. Sourcemaps generation included.

tellnes/bunyan-middleware 37

:scroll: Request, response logger middleware for bunyan. Also provides request<>response duration.

tellnes/aws-ses-feedback 1

aws-ses-feedback makes it easy to handle feedback from aws ses.

tellnes/connect 1

Connect is a middleware layer for Node.js

tellnes/debug 1

tiny node.js & browser debugging utility for your libraries and applications

create barnchlafte/symforch-web

branch : master

created branch time in 2 months

created repositorylafte/symforch-web

created time in 2 months

pull request commenttellnes/long-timeout

Umd support

Hi,

Sorry for not getting back to you earlier. Is this something you still want to continue? If so I don't think we should commit the generated dist file. So it would be great if you can add it to gitignore and add a files property to package.json instead.

Btw, what is the use case for needing this in the browser?

AustinMCrane

comment created time in 2 months

issue commenttellnes/long-timeout

What are example use cases?

I don't remember the details as it is 8 years since I created this. By my use case back then was to set I timeout for when I needed to renew/reload some TLS certificates based on the expiration date. But looking at the dependents in the dependency graph you can can probably find a lot of more use cases. I guess more people than me have run into the same problem I did and found this useful since it currently is 24k repositories at GitHub that depends on this.

AbdelrahmanHafez

comment created time in 2 months

issue commentterraform-providers/terraform-provider-aws

add ipv6_ip address to aws_network_interface

Commenting to keep this open. Last time I checked this was still missing.

certnew

comment created time in 2 months

pull request commentpillarjs/finalhandler

remove warning when used with HTTP2

Yes, I was actually thinking the same after writing my latest comment. But I'm also thinking that the warning from core is the correct behavior. HTTP/2 has removed support for status messages. If node core where just to ignore it, it can confuse developers who expect it to behave like HTTP/1. So the solution is to stop using it in user land since it is a deprecated feature.

What we need is some API that lets us check if it is set without triggering the warning. Maybe the middle ground here is to change core to not emit the warning in the getter, but still emit it in the setter.

Btw, I've never seen this feature used for anything in the real world. Have you?

tellnes

comment created time in 3 months

pull request commentpillarjs/finalhandler

remove warning when used with HTTP2

My idea was

if (res.statusMessage) {
  res.statusMessage = ''
}

But it does not work since node core also warns when you are reading the property. Here is the source code in node that we need to work around: https://github.com/nodejs/node/blob/v14.5.0/lib/internal/http2/compat.js#L608-L616

So I don't think we can get around having a check if the response object is from HTTP2 or not.

Btw, I do consider this module HTTP2 compatible even without this change. It just prints an annoying warning to the console. All modules written for the http module should also be compatible with the HTTP2 Compatibility API as long as they only use public APIs from core and not any internal ones.

tellnes

comment created time in 3 months

pull request commentpillarjs/finalhandler

remove warning when used with HTTP2

I'm having this problem because I'm using the http2 module. My goal is to fix that problem. So yes, you can say the goal is to add HTTP2 support.

Actually, I don't really understand why this module is changing this property. Is the goal to reset it in case it was set in a previous middleware?

If that is a case, another solution might be to just set res.statusMessage to an empty string. Core will set the correct status message) if it is not customized and has been doing that since at least 0.8.x which is the oldest version this library is currently tested on.

Btw, core also exposes the status codes as http.STATUS_CODES so the statuses module is not needed.

tellnes

comment created time in 3 months

pull request commentpillarjs/finalhandler

remove warning when used with HTTP2

Thank you for a quick response.

After a quick look it does not look like supertest supports HTTP2. Like you said we do want to run the test suite both for http and http2. So to be able to run the test suite under http2, we probably have to do a big refactor or rewrite of the test suite. But it would be great if there is some quick clever way to do this that I'm not seeing.

Yes there is two ways to do HTTP2 in core. I've assumed usage of the compatibility API in this pr. The HTTP2 Compatibility API targets the public API of the http module. The more low level API exposed by core is not compatible with this module without bigger changes. Eg. there is no request and response object, but a duplex stream instead.

I've read trough index.js and I think that we should not have any other problems than what is in this pr. But yes, it should of course be tested.

I think a bigger rewrite of the test suite is out of scope for this pr and probably something that I also don't have time to do. But I could add something to the readme that document current HTTP2 support.

tellnes

comment created time in 3 months

push eventtellnes/finalhandler

Christian Tellnes

commit sha 2ac16931d0398c5b91952bfecd4090c468ef801f

remove warning when used with HTTP2

view details

push time in 3 months

push eventtellnes/finalhandler

Christian Tellnes

commit sha 4bc8eeb14b9c152e8d075b85d08475000e132d05

remove warning when used with HTTP2

view details

push time in 3 months

push eventtellnes/finalhandler

Christian Tellnes

commit sha e6f2090fc178e9f15d0dd48fcf6adf0413abe1c1

remove warning when used with HTTP2

view details

push time in 3 months

PR opened pillarjs/finalhandler

remove warning when used with HTTP2

The HTTP2 spec does not support sending a status message, so when res.statusMessage is set a process warning is emitted.

+26 -1

0 comment

2 changed files

pr created time in 3 months

create barnchtellnes/finalhandler

branch : http2-warning

created branch time in 3 months

fork tellnes/finalhandler

Node.js final http responder

fork in 3 months

created tagtellnes/json-rpc-constructor

tag1.1.0

A building block to create powerfull JSON-RPC apis

created time in 3 months

push eventtellnes/json-rpc-constructor

Christian Tellnes

commit sha bc4d22662e545b0a64b945c2be56ef4fd8eeaffd

1.1.0

view details

push time in 3 months

push eventtellnes/json-rpc-constructor

Christian Tellnes

commit sha e31c58450537369587b7a9b2266d1ec3946dc087

change to stream interface

view details

Christian Tellnes

commit sha 9b76ce328f949e5b39f228262eddbdd4d5697cde

change from `prepublishOnly` to `prepublish` for tsc build

view details

Christian Tellnes

commit sha 57d960a4947207ed00fe3bf631c4b4ef4196fcaf

add yarn.lock to git

view details

Christian Tellnes

commit sha 35f9ae9e2dc477d8a9526d3f46341406c1cf1b1f

1.1.0

view details

push time in 3 months

push eventtellnes/terraform-provider-aws

Christian Tellnes

commit sha 00ce009bd9b545ba8e26b106329c01cd9d162a43

resource/aws_codebuild_project - add file_system_locations Adds AWS CodeBuild support for EFS

view details

push time in 3 months

pull request commentterraform-providers/terraform-provider-aws

resource/aws_codebuild_project - add `file_system_locations`

@felixb I've rebased it on top of master

tellnes

comment created time in 3 months

push eventtellnes/terraform-provider-aws

Brian Flad

commit sha 85342a881e36ff947283eb339202b70e0629223e

resource/aws_ec2_transit_gateway_peering_attachment: Finish up implementation Mainly just ensuring the tested resource is the main provider, not the alternate. Ensure `transit_gateway_attachment_id` is set during Read. Output from acceptance testing: ``` --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_sameAccount (625.85s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_basic_differentAccount (628.47s) --- PASS: TestAccAWSEc2TransitGatewayPeeringAttachmentAccepter_Tags_sameAccount (630.60s) ```

view details

Brian Flad

commit sha 5e96d5e103d53b874fed26cd2596f9677413522f

Merge branch 'Omarimcblack-om_aws_ec2_transit_gateway_peering_attachment_accepter'

view details

Brian Flad

commit sha 9676e3355ad4a9f209fdefdae7e5a1e5ad7fced6

Update CHANGELOG for #11185

view details

renovate[bot]

commit sha e9b4cba4cce8baf00051c594e452b29c1ae4cf38

Update module bflad/tfproviderdocs to v0.5.2 (#13220) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Graham Davison

commit sha 4b71bbcf36d0ca32fb972dde4fd1894727afd51a

Merge pull request #11655 from DrFaust92/launch-template rd/launch_template - add `partition_number` attribute + validations

view details

Graham Davison

commit sha 90925e4409e0138fb9215889191c1f15bdc57fbe

Update CHANGELOG for #11655

view details

Graham Davison

commit sha 04ad76916751dab8fe9f3fbaaff4dcca10941b4d

Merge pull request #13107 from terraform-providers/t-aws_db_security_group-testAccEC2ClassicPreCheck tests/resource/aws_db_security_group: Include EC2-Classic PreCheck

view details

tf-release-bot

commit sha f4c344991d4a7a0a0f66e01e32ed4915cc411b6a

v2.61.0

view details

tf-release-bot

commit sha 4d8b6d477bed5757d8d5ef5fee2b56fd323a8971

Cleanup after v2.61.0 release

view details

Simon Davis

commit sha fc36c9893c54393e68a50143bfd8b5608a1043bf

refactor docs and add FAQ (+36 squashed commits) Squashed commits: [5a63f2c16] docs rename to info [c5f59c350] added automation column [1eb8f8bb5] refactor table [69e916147] made team deets look a little prettier [d8a17e4c6] remove triage WIP for now [1bc508703] all the labels [16d6057f4] all the labels [17e00f086] more labels [61abf2892] css hascks [2baaba82e] labels [29ebff847] label dictionary [f836f5d02] heading fix [e4bcd5c3b] heading fix [3cc15d6fd] heading fix [76b566921] heading fix [90fac88ea] heading fix [ab54df13e] more acc test split [3cad5f885] rename dev title [1226dfb32] CAPS [b8f4431fa] heading fun [7812068a2] another round of splitting [2a062002d] move roadmap, some other layout [fb923e216] first attempt at splitting [83d09b69e] remove trailing forum id [cecb06227] copy over FAQ [d56e2dd0a] lowercase the d [544db33f7] remove md from link names [d02cecf32] using link [a2e521ddf] reorder links to be consistent [3db9d4484] development > developing [8be60b508] fix requirements link [d0fa12fcc] create docs folder [f958d0ace] remove community source section [85c962931] punctuation [bacfd0a36] fix terrform.io link [8c066dcdb] fix some links (+1 squashed commit) Squashed commits: [56a3e58ba] slimmed down readme

view details

renovate[bot]

commit sha 6cf84739011aa60bb8aa0c501b08dfc280716af7

Update module bflad/tfproviderdocs to v0.5.3 (#13225) Co-authored-by: Renovate Bot <bot@renovateapp.com>

view details

Simon Davis

commit sha 11577bb5501b5f0dd93ada2ae7f2c2d34ea6afc8

add link to the label dictionary

view details

Simon Davis

commit sha 5c1cafdffd4b9c57f59dcf56c6f7029b4a85b2a2

some FAQ changes

view details

Simon Davis

commit sha 565152f88741dd6d9c8a8c8f8c6f136258ba848b

Update info/FAQ.md Co-authored-by: Brian Flad <bflad417@gmail.com>

view details

Simon Davis

commit sha c874930731eb7f08151a0ef467c623567aad49f7

Update info/MAINTAINING.md Co-authored-by: Brian Flad <bflad417@gmail.com>

view details

Simon Davis

commit sha 990b8e4062660c85e9cc76ea9d42b4d2df7d950c

fix waiting response tag link

view details

Simon Davis

commit sha a19c634ecf986ab5f91789e1030a5ebabbf8750c

Update info/contributing/contribution-checklists.md Co-authored-by: Brian Flad <bflad417@gmail.com>

view details

Simon Davis

commit sha 7e1db5a0748b0871dd6551f98f0e548124de33e5

Update info/FAQ.md Co-authored-by: Brian Flad <bflad417@gmail.com>

view details

Simon Davis

commit sha 5f84a958c3a49ee7be18aeaf7e5dffa8c6c704ba

code review fixes

view details

Simon Davis

commit sha 23b7911dba83c5d59ae859408b6474af6a29ee94

Merge branch 'd-documentation-refactor' of github.com:breathingdust/terraform-provider-aws into d-documentation-refactor

view details

push time in 3 months

more