profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/tde-banana-odoo/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Thibault Delavallée tde-banana-odoo @odoo In the attic www.odoo.com Gooroo @odoo

tivisse/odooplants 24

Support material for the Odoo Experience presentations about building a plant nursery

tde-banana-odoo/odoo_tools 1

Odoo tools and helpers

tde-banana-odoo/odoo_plant_nursery 0

Plant Nursery Demonstration Module

pull request commentodoo/odoo

[FIX] website_event: fix the direction of event sub-menus

Thanks for updating @mish-odoo ! Seems to be going into the right direction indeed :) .

@qsm-odoo and @JKE-be could you check that it was effectively what you had in mind ?

mish-odoo

comment created time in 5 hours

push eventodoo-dev/odoo

Thibault Delavallée

commit sha 07c9c3b3fdf97057532f353518e3b16a75cbccd2

[REF] mail, various: clean thread _notify API Global purpose is to rename some methods and add some docstrings to clean API of notification methods used in mail thread. Notably use _notify_thread prefix for main methods, ans _notify_by_mean for tool sub-methods. Remove unused arguments, coming from old implementation and usage. They were introduced notably for performance reason when cache was more often invalidated which is not the case anymore. Anyway when parameters are unused better remove them. This commit should not change anything functionally as it contains only some renaming and docstrings. Task- PR odoo/odoo# PR odoo/enterprise#

view details

Thibault Delavallée

commit sha bf1dfbbb18ecb1288501e944f0e50a0fb869aae8

[IMP] mail: improve alias views Add missing fields in tree view, notably about alias owner. Add buttons allowing to open the updated thread or the alias owner directly from tree view to ease daily management of aliases. Task-36879 (MC Mail) PR odoo/odoo#

view details

Thibault Delavallée

commit sha be20f9762e60323df182ccc098bfde80b00a0d4a

[REF] mail, various: use methods for alias configuration parameters Purpose of this commit is to prepare future improvements by wrapping config parameter access into methods for alias configuration. Task-36879 (MC Mail) PR odoo/odoo#

view details

Thibault Delavallée

commit sha 41b3e42a421b05987756ea2b55a0688f25b5e3c0

[IMP] mail: add model for alias domains Task-36879 (MC Mail) PR odoo/odoo#

view details

Thibault Delavallée

commit sha 30c60eb3ca2c9565d2c3038ab3722b9dc9bd17d8

imp: alias domain on res company

view details

Thibault Delavallée

commit sha 4b70111b8e2e8bba1021aba871cd572ca43fd415

[IMP] mail: allow aliases to be company based Task-36879 (MC Mail) PR odoo/odoo#

view details

Thibault Delavallée

commit sha 2f964f922725d73852bb07cd247155cd98676365

tmp alias domain

view details

push time in 7 hours

pull request commentodoo/odoo

[BP][IMP] various: improves button titles for better command palette

@robodoo r+

tde-banana-odoo

comment created time in 7 hours

PR opened odoo/odoo

[BP][IMP] various: improves button titles for better command palette

Backport of odoo/odoo@c1ea516aa701dde77149348d31fdd08f46550004 as we think this is important to have in 14.5 to ease command palette usage.

Currently, in some of the important business objects' form views, few header buttons are missing the title, and so the command palette displays the button string which is not very clear/useful.

This commit improves the behavior by adding titles to the buttons. Below are the model wise actions/methods linked with updated buttons:

  • preview_invoice (account.move)
  • action_sale_quotations_new (crm.lead)
  • action_set_lost (crm.lead)
  • action_set_won_rainbowman (crm.lead)
  • crm_lead_lost_action (crm.lead)
  • iap_enrich (crm.lead)

Task-2622266

+7 -5

0 comment

4 changed files

pr created time in 7 hours

create barnchodoo-dev/odoo

branch : saas-14.5-bp-ngr-tde

created branch time in 7 hours

push eventodoo-dev/odoo

Hed Shefer

commit sha dbdac91c4bdbb0d1fb8cb9b167a95b632c38ac26

[IMP] l10n_il: improve CoA, fiscal positions, and taxes. Added Vat 0, vat self invoice and vat import line which needed in the israely market. Then, we have added the related fiscal positions. In addition, we have modified the chart of accounts with the up to date accounts and orgenized them with the correct account groups. closes odoo/odoo#77000 X-original-commit: 8b38350cea310930de226a879fdc1fd93de01adf Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

Raf Geens

commit sha 60864de16b43f755aeff4d5cc7cb12472d08cfe2

[FIX] hw_drivers: Block when getting network interface get_ip and get_mac_address respectively try to get the IP and MAC from the IoT box's active network interface. If the interface isn't fully up yet (due to waiting on a slow DHCP server response for example), both functions can end up raising a KeyError exception since neither interface has a value. This can be bad if it's uncaught and happens in something like the Manager thread, potentially killing it as a result. This can then disrupt the rest of the application. The network being gone for a bit or slow is something that can happen during everyday use, so we should be robust against it. Since the box can't do any useful work without an active network connection, this fix keeps retrying until one of the interfaces comes back up. opw-2357144 closes odoo/odoo#77052 X-original-commit: d0359858b17fb84c04c267bdf5cc1626569f5cce Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

view details

William Henrotin

commit sha 9b43d7ec5aff92bf9b4286ec3b44e2c628dcddea

[FIX] purchase_stock: relax constrains on orderpoint location The check added in 643e093a4bc9d46973705831697036b56a89b143 was too strict in case a purchase order was created from an orderpoint triggering multiple rules. The orderpoint's location could be below another warehouse that the first rule's location and thus raising the error. closes odoo/odoo#77079 X-original-commit: df1f90673fc06f3d535833229d8af3ef6a51dd61 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com> Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

view details

Mitul Shah

commit sha 4de6618cdff70bbf5ca9a42ded57edd2e2f128eb

[FIX] website_event: correctly display 'Event Sub-menu' customize menu Right now, when we only have the website_event installed and ther are no other regular(view based) customize menus available, we won't have a divider div tag. And the current code tries to push our menu after the first divider and thus fails due to no divider available. With this commit, we simply check that if there's no existing divider div, we simply add one and then push the menu after divider. Task-2616588 closes odoo/odoo#77083 X-original-commit: 11a54d5fed9e21469363dabc4e973662418b9920 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

David Tran

commit sha f167d47b489f56f9ac29f67c64e5a2500533640c

[FIX] mail: remove emojis 3: There was 3 keys for the same icon 😠 while one of them is usually used in normal text. For example: - Item 1: - Item 2: - Item 3: The last one would convert to `- Item 😠` This PR removes one of the above to keep the other two closes odoo/odoo#77075 X-original-commit: 45e9636c2e0457d3bc4ea1d346ff71ed6824bbe1 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

view details

William Braeckman

commit sha 88f18b1ce9c5fc7a62c761b1c41ddb4922cfb226

[FIX] hr_work_entry_contract: fix traceback Fixes a traceback when generating work entries. How to reproduce: - Create a contract with a working schedule with 0 attendances - Set the contract as running - Make sure you have another contract for another employee running on the same period, this one must have attendances - Go to the work entries views, this should generate working entries for the viewable dates - If the work entries were already generated, go to a month where they are not generated yet, you should have the traceback Task ID: 2654797 closes odoo/odoo#77085 X-original-commit: 13f7f8c4e066b0a2fadef95cdff4a24a4f67f95c Signed-off-by: Kevin Baptiste <kba@odoo.com> Signed-off-by: William Braeckman (wbr) <Williambraecky@users.noreply.github.com>

view details

Alexandre Kühn

commit sha 099bde0b75739abb2aff5909aa21a23829ceee08

[FIX] mail: make webRTC component classname follow BEM convention X-original-commit: c8296c4ed6c3f0c95852bc5b3466f6fea34368a3 Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha d5d93bdf054b5fbbfabc8466c8c067b7e1ae4bd3

[FIX] mail: remove webRTC component excessive getters X-original-commit: 9bf4b6c29207b97368f27098df3cfbe79e2b5f0f Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha 07053cbfaa8409792d3a3cc4c4df0cf5a5d1f866

[IMP] mail: rename "mailRtc" fields to "rtc" X-original-commit: 8db877c99f3b3c405e7a51920a574edfeb7a18d5 Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha b6d9bea33a3ef017f3b6c12fce9735e2f49c3874

[FIX] mail: fix typos (likely to fix webRTC recovery every 30sec in case of failure) X-original-commit: 60eccab558d7a40cb4a27c7042f62f547e581ee6 Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha 527c4202d6277de877d5a75b590f325f5ccca420

[FIX] mail: make keyframes naming more appropriately specific X-original-commit: 07ec5766dd33fae2a128fa62e3ac5e6aec8ea4bc Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha 57bf42603c0f3418b227a1785d3b12fd4afa4df2

[FIX] mail: no crash on save volume settings by guests X-original-commit: a91322154b607e40b4a007e743e9d9975aa1f256 Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha cb69d7a93ec2711811e735dbba9449ec8a4d0ebb

[FIX] mail: enforce boolean value on computed fields of webRTC closes odoo/odoo#77107 X-original-commit: ad9d6fd0f14a4d954940cf4cd5f4a2bcf91b81b5 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com> Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

view details

Aaron Bohy

commit sha 35ac826f940d1c4e76b584e71a51dbc373dff6e3

[FIX] web: effect: display rainbowman by default In [1], we rewrote the effect feature in the wowl infrastructure. However, we lost something in the process: the "type" of effect (basically "rainbow_man" as it is the only implemented effect) became a mandatory param, whereas before it simply defaulted to "rainbow_man" when not set. As a consequence, previously defined effects in views could crash. This commit fixes that issue, and reworks a bit the feature by introducing a registry of effects, which easily allows to add new effects from the outside. An effect is a function that may return a Component (and its props) to display. Most of the diff in the tests is about moving files where they should be (the effect feature being in core/, the tests must be in core/ as well, and not depend on the webclient). [1] 0573acae2306bf5da2005852da9323ddc59e5431 Task 2652927 closes odoo/odoo#77109 X-original-commit: 74dc3f654ee5849982b494e46eefb1fc2b4e0c74 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

view details

qsm-odoo

commit sha ff1f5e6c8c969169a55a40df80dcddddcfa25af5

[REF] web_editor: simplify shape scss definition Don't set 'repeat-y' to false explicitely as it is the default value. X-original-commit: 26612818d71f072eaf291df6d4ee839301f36dc7 Part-of: odoo/odoo#77119

view details

Cocographique

commit sha af666dff2084a05e9a8efd5eb5178a237cee0995

[IMP] web_editor: add new "Zigs" background shape Related to task-2545200 closes odoo/odoo#77119 X-original-commit: 1624b1659d15df731a954912b88908a24aeddb5d Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>

view details

Kevin Baptiste

commit sha 2012a9d2053fa26f4d1812a6df0ac08bb721e8d3

[FIX] hr: bring back "My Profile" Since the merge of 0573aca the override was no longer working. closes odoo/odoo#77097 Taskid: 2651838 X-original-commit: 947194644a09f186899f2b2526cf0b0675af7304 Signed-off-by: Kevin Baptiste <kba@odoo.com>

view details

Rémy Voet (ryv)

commit sha 37086aa55406ab2c6205d64e9f7979e99ec1d5e8

[FIX] sale_purchase: fix purchase count MTO closes odoo/odoo#74141 closes odoo/odoo#77105 X-original-commit: 8fec359b11a7bd57ecd3a6fd43dc429057091de7 Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

view details

Aaron Bohy

commit sha 9d98d1e870066d5124befe97e02829df408eb43f

[REF] web: useTooltip: use template instead of component Allowing to specify components inside tooltips to obtain dynamic and/or html content was a bit overkill and unnecessary: a template can do the trick and it is easier to define. This commit thus renames attribute "data-tooltip-component" into "data-tooltip-template" (the name of the qweb template) and introduces the "data-tooltip-info" attribute (its value is then available in the template under the "info" variable). X-original-commit: 8683a8d762339451e3d9f8706aac86da80510b37 Part-of: odoo/odoo#77113

view details

Aaron Bohy

commit sha 800297064c952b551a72ea9219eae1c4815da5b1

[FIX] web: useTooltip: clearInterval on willUnmount Before this commit, the useTooltip hooks didn't call clearInterval when the component using it was unmounted/destroyed. In practice, it wasn't an issue because the only component using it was the webclient, and it is never destroyed. However, for this hook to be usable in other contexts, it is important to remove this leak. closes odoo/odoo#77113 X-original-commit: d076afd035ad8fadc5a0774c6c0eec15acb15026 Related: odoo/enterprise#21147 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com> Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>

view details

push time in 7 hours

pull request commentodoo/odoo

[FW][FIX] event_booth_sale: set correct product type for 'Event Booth' product

@fw-bot r+

fw-bot

comment created time in 10 hours

pull request commentodoo/odoo

Master various sm scope nla

@robodoo r+ rebase-ff

nla-odoo

comment created time in 12 hours

push eventodoo-dev/odoo

dbkosky

commit sha 516c414683ffff5dffb6e62b30f8a4d5e9dcfbbb

[FIX] account: typo, change active to activate closes odoo/odoo#76904 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Achraf (abz)

commit sha fff6ffc5a1431bbb219f64fe3410cd84522f5ed3

[FIX] sale_stock: Don't compute UoM twice The amount on generated COGS lines can have the UoM factor applied two times. For example, if we have a product costing 1$ per item and we sell it by pack of 12 ("Pack" UoM) we will have 1$*12*12=144$ instead of 1$*12=12$ 0/ Go to a V14 runbot 1/ Create a company which use COGS (eg. Mexican accounting) 2/ Have a storable product priced at 1.5$ from a product category with Costing Method as "First In First Out (FIFO)" and Inventory Valuation as "Automated" 3/ Create a UoM 12 times bigger than the default Unit (eg. 12 Pack) 4/ Create a purchase order costing 50$ for 50 Unit of the product => cost of the product should be 1$ 5/ Create a new purchase order for 50 Unit but costing 0$ (like if got free products from supplier) 6/ Create sale order for 50 units of the product, validate the transfert and create/confirm the invoice => computed COGS amount is 50$ on the invoice => ok 7/ Create a sale order using the "12 Pack" UoM, validate transfert and create/confirm invoice => computed COGS is 144$ => nok opw-2503368 closes odoo/odoo#77007 X-original-commit: d0d9c0a8f8e35fbd9624d934a8ca6152677fbd3e Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com> Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>

view details

William Henrotin

commit sha b857478460a6196237ee0d3defdfcba58636685a

[FIX] mrp: confirm production order at the end This commit removes the action_confirm from the run_manufacture to do it only after all the orderpoints have been processed. In case a production, created in run_manufacture, triggers procurements for one of its component. And those procurements have the same parameters than another one still not run because after the manufacture one in the queue. This new procurement will replenish its quantity plus the other procurement's one. That means too much quantity will be replenished. closes odoo/odoo#77026 X-original-commit: a7bb9f1ac392c00be5bdd133fc5c73b9803c8b4b Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com> Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

view details

Mathieu Duckerts-Antoine

commit sha dfa90a7ffc2e0600706e1f750fe953901039afa6

[REF] web: patchDate function In order to be able to easily patch Date in py_date_tests and elsewhere, we refactor the code of the legacy and new patchDate functions. X-original-commit: 0e697c82be80cae9cc993b4be179fec42b8dae83 Part-of: odoo/odoo#77035

view details

Mathieu Duckerts-Antoine

commit sha 31c9bcaaca0d93d80ee8ee9490c55300a4a2f3e6

[FIX] web: py.js evaluation of to_utc The class PyDateTime did not have a method to_utc. For that reason, it was impossible for the search model to evaluate a dynamic domains like "[('date', '&gt;=', (datetime.datetime.combine(context_today(), datetime.time(0,0,0)).to_utc()))]" We implement that method. X-original-commit: 3ad9a3be64da78d596ee3dc435d4b224728a9e76 Part-of: odoo/odoo#77035

view details

Mathieu Duckerts-Antoine

commit sha 99e77f708e037cf2655d6964ee3b70418dd751ee

[FIX] web: py.js evaluation of current_date current_date was absent from py_builtin. For that reason, it was impossible for the search model to evaluate a dynamic domains like "[('date_deadline', '&lt;', current_date)]" We add current_date to py_builtin. closes odoo/odoo#77035 X-original-commit: ade082c5ad9221c82de90ddbe68b814b1487753d Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

view details

Hed Shefer

commit sha dbdac91c4bdbb0d1fb8cb9b167a95b632c38ac26

[IMP] l10n_il: improve CoA, fiscal positions, and taxes. Added Vat 0, vat self invoice and vat import line which needed in the israely market. Then, we have added the related fiscal positions. In addition, we have modified the chart of accounts with the up to date accounts and orgenized them with the correct account groups. closes odoo/odoo#77000 X-original-commit: 8b38350cea310930de226a879fdc1fd93de01adf Signed-off-by: Josse Colpaert <jco@openerp.com>

view details

Raf Geens

commit sha 60864de16b43f755aeff4d5cc7cb12472d08cfe2

[FIX] hw_drivers: Block when getting network interface get_ip and get_mac_address respectively try to get the IP and MAC from the IoT box's active network interface. If the interface isn't fully up yet (due to waiting on a slow DHCP server response for example), both functions can end up raising a KeyError exception since neither interface has a value. This can be bad if it's uncaught and happens in something like the Manager thread, potentially killing it as a result. This can then disrupt the rest of the application. The network being gone for a bit or slow is something that can happen during everyday use, so we should be robust against it. Since the box can't do any useful work without an active network connection, this fix keeps retrying until one of the interfaces comes back up. opw-2357144 closes odoo/odoo#77052 X-original-commit: d0359858b17fb84c04c267bdf5cc1626569f5cce Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>

view details

William Henrotin

commit sha 9b43d7ec5aff92bf9b4286ec3b44e2c628dcddea

[FIX] purchase_stock: relax constrains on orderpoint location The check added in 643e093a4bc9d46973705831697036b56a89b143 was too strict in case a purchase order was created from an orderpoint triggering multiple rules. The orderpoint's location could be below another warehouse that the first rule's location and thus raising the error. closes odoo/odoo#77079 X-original-commit: df1f90673fc06f3d535833229d8af3ef6a51dd61 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com> Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>

view details

Mitul Shah

commit sha 4de6618cdff70bbf5ca9a42ded57edd2e2f128eb

[FIX] website_event: correctly display 'Event Sub-menu' customize menu Right now, when we only have the website_event installed and ther are no other regular(view based) customize menus available, we won't have a divider div tag. And the current code tries to push our menu after the first divider and thus fails due to no divider available. With this commit, we simply check that if there's no existing divider div, we simply add one and then push the menu after divider. Task-2616588 closes odoo/odoo#77083 X-original-commit: 11a54d5fed9e21469363dabc4e973662418b9920 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

David Tran

commit sha f167d47b489f56f9ac29f67c64e5a2500533640c

[FIX] mail: remove emojis 3: There was 3 keys for the same icon 😠 while one of them is usually used in normal text. For example: - Item 1: - Item 2: - Item 3: The last one would convert to `- Item 😠` This PR removes one of the above to keep the other two closes odoo/odoo#77075 X-original-commit: 45e9636c2e0457d3bc4ea1d346ff71ed6824bbe1 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

view details

William Braeckman

commit sha 88f18b1ce9c5fc7a62c761b1c41ddb4922cfb226

[FIX] hr_work_entry_contract: fix traceback Fixes a traceback when generating work entries. How to reproduce: - Create a contract with a working schedule with 0 attendances - Set the contract as running - Make sure you have another contract for another employee running on the same period, this one must have attendances - Go to the work entries views, this should generate working entries for the viewable dates - If the work entries were already generated, go to a month where they are not generated yet, you should have the traceback Task ID: 2654797 closes odoo/odoo#77085 X-original-commit: 13f7f8c4e066b0a2fadef95cdff4a24a4f67f95c Signed-off-by: Kevin Baptiste <kba@odoo.com> Signed-off-by: William Braeckman (wbr) <Williambraecky@users.noreply.github.com>

view details

Alexandre Kühn

commit sha 099bde0b75739abb2aff5909aa21a23829ceee08

[FIX] mail: make webRTC component classname follow BEM convention X-original-commit: c8296c4ed6c3f0c95852bc5b3466f6fea34368a3 Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha d5d93bdf054b5fbbfabc8466c8c067b7e1ae4bd3

[FIX] mail: remove webRTC component excessive getters X-original-commit: 9bf4b6c29207b97368f27098df3cfbe79e2b5f0f Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha 07053cbfaa8409792d3a3cc4c4df0cf5a5d1f866

[IMP] mail: rename "mailRtc" fields to "rtc" X-original-commit: 8db877c99f3b3c405e7a51920a574edfeb7a18d5 Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha b6d9bea33a3ef017f3b6c12fce9735e2f49c3874

[FIX] mail: fix typos (likely to fix webRTC recovery every 30sec in case of failure) X-original-commit: 60eccab558d7a40cb4a27c7042f62f547e581ee6 Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha 527c4202d6277de877d5a75b590f325f5ccca420

[FIX] mail: make keyframes naming more appropriately specific X-original-commit: 07ec5766dd33fae2a128fa62e3ac5e6aec8ea4bc Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha 57bf42603c0f3418b227a1785d3b12fd4afa4df2

[FIX] mail: no crash on save volume settings by guests X-original-commit: a91322154b607e40b4a007e743e9d9975aa1f256 Part-of: odoo/odoo#77107

view details

Alexandre Kühn

commit sha cb69d7a93ec2711811e735dbba9449ec8a4d0ebb

[FIX] mail: enforce boolean value on computed fields of webRTC closes odoo/odoo#77107 X-original-commit: ad9d6fd0f14a4d954940cf4cd5f4a2bcf91b81b5 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com> Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>

view details

Aaron Bohy

commit sha 35ac826f940d1c4e76b584e71a51dbc373dff6e3

[FIX] web: effect: display rainbowman by default In [1], we rewrote the effect feature in the wowl infrastructure. However, we lost something in the process: the "type" of effect (basically "rainbow_man" as it is the only implemented effect) became a mandatory param, whereas before it simply defaulted to "rainbow_man" when not set. As a consequence, previously defined effects in views could crash. This commit fixes that issue, and reworks a bit the feature by introducing a registry of effects, which easily allows to add new effects from the outside. An effect is a function that may return a Component (and its props) to display. Most of the diff in the tests is about moving files where they should be (the effect feature being in core/, the tests must be in core/ as well, and not depend on the webclient). [1] 0573acae2306bf5da2005852da9323ddc59e5431 Task 2652927 closes odoo/odoo#77109 X-original-commit: 74dc3f654ee5849982b494e46eefb1fc2b4e0c74 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>

view details

push time in 12 hours

pull request commentodoo/odoo

[FIX] event_booth_sale: set correct product type for 'Event Booth' product

@robodoo r+

mish-odoo

comment created time in 13 hours

pull request commentodoo/odoo

Saas 14.5 qweb template nby

There is a big value having the templates in v15 so it's a price to pay.

Are we all clear this is totally not stable and requires to drop existing databases to work? (You might want to tell people with /start15 demo databases). There is a big value for the developers but not for the users (who don't really care how the template are written).

Be sure it was discussed. But indeed Fabien thinks we should not wait another year to have it available for customers, as people mainly follow major releases. We should consider this discussion as closed, or at least to be held outside of this PR. You know how it works ^^ .

Concerning demo tags: it was discussed with Antony and Olivier notably. There is a controversy as this behavior is used notably in some website templates to display default values when the expression gives nothing. However here this trick is used here to display demo values which makes no sense when displayed or sent to customers. Antony agreed that this is not the best implementation and should be improved, but that this could be done in a future cleaning. Notably there is some discussion about a "flag" to propagate in QWeb rendering to be sure this is never sent to people outside of some specific evaluation context like the editor itself. That's about the summary of the discussion.

Goaman

comment created time in 13 hours

pull request commentodoo/odoo

[FW][FIX] test_mail: fix activity tests

@fw-bot r+

fw-bot

comment created time in 13 hours

push eventodoo-dev/odoo

Thibault Delavallée

commit sha 4ce848a013b7e9f92f897353527cf4218acf441b

[IMP] mail, various: clean notification API Remove unused arguments, coming from old implementation and usage. They were introduced notably for performance reason when cache was more often invalidated which is not the case anymore. Anyway those parameters are never used.

view details

Thibault Delavallée

commit sha 044070a5d51abcf22b080bb2bb9d40187ce81f2f

[IMP] mail, various: extract alias parameters into methods Purpose of this commit is to prepare future improvements by wrapping config parameter access into methods for alias configuration. Task-36879 (MC Mail) PR odoo/odoo#

view details

Thibault Delavallée

commit sha ec032701ae825da68d46423aec7ac6adb4952433

[IMP] mail: add model for alias domains Task-36879 (MC Mail) PR odoo/odoo#

view details

Thibault Delavallée

commit sha 09b5d2be1a669fa931a93a9835b2d85ce6372333

imp: alias domain on res company

view details

Thibault Delavallée

commit sha 4b8e588dbcc32b32be9a066af84392cd607bc42a

[IMP] mail: allow aliases to be company based Task-36879 (MC Mail) PR odoo/odoo#

view details

Thibault Delavallée

commit sha 56709e46ec6efa35f5f7b2b62803d10f8bc8f8b0

tmp alias domain

view details

push time in a day

pull request commentodoo/odoo

[FW][FIX] website_event: correctly display 'Event Sub-menu' customize menu

@fw-bot r+

fw-bot

comment created time in a day

pull request commentodoo/odoo

[MERGE] mail, various: use QWeb in mail templates

@odoo/rd-security Could you have a look at this PR ? You already had a look but as many things changed, better have another look. We still target v15 as this is an important change we don't want to delay post-release, so keep that in mind while reviewing :) .

Many thanks !

Goaman

comment created time in a day

push eventodoo-dev/odoo

Munaf Khan

commit sha b56025dff25be70d768aaf3bbafdccb6a9b147ef

[IMP] website_event_track: add quick create form view for tracks Currently, while creating tracks on the fly from an event, we can simply set the name, which is not enough, we should also be able to set date, and display proper placeholder for the name field. This commit add a new quick create form view for the track kanban view, so that user can simply choose the track name and date and can simply add tracks on the fly. Note that it is mandatory to set event on the track. If we are within an event, the default event is already available in context so we don't display it while adding a track within an event. But we are not within an event, we simply display 'event_id' on quick create card so that use can select an event and create track on the fly. TaskId-2635390 closes odoo/odoo#76250 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Goffin Simon

commit sha 955078960401be8576c31240824dd0e5ea760344

[FIX] account, mail: Using alias with journals in multi comapnies Steps to reproduce the bug: - Let's consider two companies A, B - Let's consider two contact with the same email E, C1 in A and C2 in B - Let's create an alias AL for the vendor bill journal of B - Send a vendor bill VB from E to AL Bug: A new bill is created in B with C1 as partner instead of C2 So an access error was raised when trying to open the bill in company B opw:2495870 closes odoo/odoo#76963 X-original-commit: 1a58be583629af80af00f288dc5925c3940be1ef Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Mitul Shah

commit sha 2119232747ddbfe2958cbb2bc6d01c0424792ae1

[FIX] survey: properly display filter label While seeing the survey results, user can filter the answers. When the filter is applied, '>' character is added between each letter of the filter label. This string formatting operation was needed prior v14 for the answers of matrix type question. But with survey the refactoring (see commit[1]), we already get the formatted answers from controller, so we don't have to manage it from the xml template. This commit removes string operation from xml template responsible for adding '>' (greater than) character between each letter of the filter label and thus displays the label properly. commit[1] - https://github.com/odoo/odoo/commit/351a4439b3a28d3832cd9bf17840dc9feaad7231 Task-2638463 closes odoo/odoo#76968 X-original-commit: ccd0970d51a05378ac3cd7a8d86321a5cbbe98ae Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Barad Mahendra

commit sha 6b8429f4c2b126e773002d46f91016ec273a4f57

[FIX] sale_timesheet: fix the upsell activity creation Currently the 'upsell' activity generated when the delivered quantity of the SOL is >= 100% instead of > 100% so in this commit, if SOL is > 100% then only the upsell activity should be generated. also fix the upsell_threshold value to fix the test case. Taskid: 2642872 Closes: #76312 X-original-commit: ee9082b9d93b4f98a9a13694fb3b803cd7d1ac6c Part-of: odoo/odoo#76967

view details

Barad Mahendra

commit sha bda930b6020465297c83753e4c06df3a0153887e

[FIX] project: fix the visibility of assign to me button Currently the 'Assign to me' button is never visible on form view of the task. So in this commit visible the button only when user_ids is Fasle on task. closes odoo/odoo#76967 Taskid: 2642872 Closes: #76312 X-original-commit: 6f96898160bb219427d5c5b23195ef8563e732a8 Related: odoo/enterprise#21072 Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

view details

oco-odoo

commit sha 1bdfdae121658742269c68b4a7b1a5871a39368b

[IMP] l10n_ch: fix typo in UserError closes odoo/odoo#76975 X-original-commit: 704fc0fa9e0d8eecd2f15a7f36f1320a9ed2e717 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>

view details

Nicolas Bayet

commit sha 5b7151e0efc30a8d2016b612f8e4be87b57728b8

[FIX] web_editor: wait editor loading in tests In a undeterministic circumnstance, the editor has not enough time to be loaded after `testUtils.nextTick()`. By using a 100ms timeout instead, it will give more time for the editor to be loaded and therfore reduce the risk of a false negative to appear. closes odoo/odoo#76980 X-original-commit: 190ddf08b8bb6c4750f1d0ad1c57f19b936794de Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>

view details

Kartik Chavda

commit sha e3f3ea347b7f4e1f8f7e436e98e68be635cd45c5

[FIX] analytic: add seach view for cost/revenue stat button Purpose of this commit change search view that display in act_window view that open by cost/revenue stat button in analytic account form view.It displays the search view that come from timesheet, it should be display search view of analytic items. So, In this commit add analytic items search view in action of cost/revenue stat button. Task Id: 2622912 closes odoo/odoo#76999 X-original-commit: 8a6145ca809168080a1a2162f2d6da98b6e5c7e2 Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

view details

Florent de Labarre

commit sha 1ca67905b4e456b57541d80188bc53b25e1282d9

[FIX] mail: handle wrong Final-Recipient header in incoming emails Some emails are wrongly formatted mainly due to old servers. If Final-Recipient header is void or wrongly encoded it currently crashes. This fix ensure there is no crash, even if bounce detection could be incomplete. Task-2641572 PR odoo/odoo#76159 Closes odoo/odoo#75618 X-original-commit: f437967a1fa4fca56c88e1cf79586805101ab712 Part-of: odoo/odoo#77005 Co-authored-by: Thibault Delavallee <tde@odoo.com>

view details

Florent de Labarre

commit sha a8518ae75d987aa4ad9d232376ccc81c39d84cc2

[FIX] mail: handle parsing of void body in incoming emails When body does not contain any tag or content parsing currently fails with an ``lxml.etree.ParserError``. To avoid that we can improve condition about void body: stripping void characters allows to avoid that traceback. Task-2641572 PR odoo#76159 Closes odoo#75625 X-original-commit: 708fe3e74991c144a05c6bdcafa1931672e36ce9 Part-of: odoo/odoo#77005 Co-authored-by: Thibault Delavallee <tde@odoo.com>

view details

Jinal Patel

commit sha 223b51c462ec96f45d618b867a6f3d35ae5b779e

[FIX] mail: fix ACLs issue with mail composer in new mode As create_uid has no value on mail.compose.message model when being in onchange or new mode, 'Mail Compose Message Rule' record rule may crash. In this commit we fix that issue by adding a value for create_uid. An unit test is added to ensure it effectively fixes the use case. Steps to reproduce this warning: 1. Create automated action for the 'mail.compose.message' model 2. Try to open 'Email compose Wizard' Warning: "Due to security restrictions, you are not allowed to modify 'Email composition wizard' (mail.compose.message) records. Records: mail.compose.message,NewId_0x7f8e99762310 (id=NewId_0x7f8e99762310) User: USERNAME (id=2) This restriction is due to the following rules: Contact your administrator to request access if necessary." Task-2641572 opw-2628005 PR odoo#76159 Closes#75369 X-original-commit: 26d64c0b84b76bb9164a8895bcc21b66754478ae Part-of: odoo/odoo#77005 Co-authored-by: Thibault Delavallee <tde@odoo.com>

view details

Jairo Llopis

commit sha 1efeffd2977885aff22ec9c2564c0e8d53de855a

[FW][IMP] test_mail: test models with type do not mess with attachment types Purpose of this commit is to highlight an issue that may happens easily with `crm` that is made generic here within `test_mail`. `crm` alters the context when creating a new record adding in this case `default_type` to it][1]. The returned record contains that altered context. his results in other records created from it trying to assign that same default value for `type`. This is a very common name for fields, and happens to exist in `ir.attachment` too. If you create an alias for incoming leads in your DB with default values `{"type": "lead"}` (something very common) and then an email comes to that alias that contains an inlined base64 image, the attachment creation process would simply fail. Obtained error is ``ValueError: Wrong value for ir.attachment.type: 'lead'`` . [1]: https://github.com/odoo/odoo/blob/272602193f5647f7f2270ed6ec68777625a139dd/addons/crm/models/crm_lead.py#L310-L311 X-original-commit: 99434b2e8528c10fcc9cb6860765e0ddcaa364c8 Part-of: odoo/odoo#77005 Co-authored-by: Thibault Delavallee <tde@odoo.com>

view details

Raf Ven

commit sha be8aa967f012c217fa15ffa35460a180af404a4c

[IMP] base: merge activities of merged partners When merging partners through the ``base.partner.merge.automatic.wizard`` wizard, messages and followers are merged. However activities are not probably because its underlying model is "newer" then messages and followers. This commits fixes that behavior. Task-2641572 PR odoo#76159 Closes #71654 X-original-commit: 7e17678ec6ebbbe37b807a5d264cc5afd46bae1a Part-of: odoo/odoo#77005 Co-authored-by: Thibault Delavallee <tde@odoo.com>

view details

Odoo's Mergebot

commit sha ef6d967907e8e69944a7a0f869cfe7a604608b32

[FW][MERGE] mail: provide fixes for gateway, composer and partner merge Merge fixes coming notably from community reporting. Containing [FIX] mail: handle wrong Final-Recipient header in incoming emails [FIX] mail: handle parsing of void body in incoming emails [FIX] mail: fix ACLs issue with mail composer in new mode [FW][IMP] test_mail: test models with type do not mess with attachmen… [FIX] mail: prevent useless write when pinning a channel [IMP] base: merge activities of merged partners See sub commits for more details Task-2641572 closes odoo/odoo#77005 Forward-port-of: odoo/odoo#76506 Forward-port-of: odoo/odoo#76159 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Habib (ayh)

commit sha 45ee18ce5b2bc01520cdbbc6820df553dedfb16c

[IMP] mail: enable inheritance in the next activity values computation values for next activities are currently prepared inside the `mail_activity._action_done()` method which makes inheritance very difficult. This commit delegates the value computation to a sub-method and thereby improves the extensibility of the module. required to support changes to enterprise documents odoo/enterprise#20769 Task-2627837 closes odoo/odoo#77004 X-original-commit: a26e6e954c5e6c773f37e9239138a7b94ded821f Related: odoo/enterprise#21079 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>

view details

Mitali Patel

commit sha b55f81aa309deef74467127c4e8755482752c27a

[FIX] project: fix seprators in Task analysis report's filter Purpose of this commit is to add the separators before and after the 'unassigned tasks' filter on Task analysis report. Taskid: 2645909 Closes: odoo#76555 X-original-commit: 388b58cd86d3fdc71c1d5e27a471febae9bd8dd5 Part-of: odoo/odoo#77006

view details

Kartik Chavda

commit sha 7b698934e17f0255afa3aa0d9c3fcd45e306e3f3

[FIX] payment_mollie: fix the module sequence Purpose of this commit to move payment_mollie module after payment_buckaroo module. So, In this commit add higher sequence number to payment_mollie module then payment_buckaroo module's sequence number. Taskid: 2645909 Closes: odoo#76555 X-original-commit: d0c7a4e39bd07da717f50af18713585391dadd76 Part-of: odoo/odoo#77006

view details

Bonis Modi

commit sha cb0b0a006c34aeff0487ecc9afe93123695aeb8e

[FIX] project: fix the project_id field invisible on sub-task form view Purpose of this commit is to hide the project_id field on form view of sub_task Taskid: 2645909 Closes: odoo#76555 X-original-commit: 403fbccfffcebb77b4c8bfdfcc48c4e08efe1da3 Part-of: odoo/odoo#77006

view details

Kartik Chavda

commit sha e1d18e7f5547b71624eb1b35f823f134ead2220e

[FIX] project_account, *: fix module category from project to services Purpose of this commit to remove project category and move project category's module to services categoty. So, In this commit change project category modules category to services category closes odoo/odoo#77006 Taskid: 2645909 Closes: odoo#76555 X-original-commit: b2b8594a5eec531e778c1182a47d98b5ab013d0b Related: odoo/enterprise#21080 Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

view details

Thibault Libioulle

commit sha 1455e34cd5e9723e4d85df401ba7116e1b1c452c

[FIX] project: remove default group by user This commit removes the default group by User for the Tasks Analysis report, which was active once one clicked on "Open Tasks" in the Project Update Kanban view. This commit also removes the default group by user in the graph view (which is induced by the field in the graph arch, through graph view init function). Issue : The graph view of report.project.task.user is not able to render the project_id>user_id groupby since the number of rows to display is to high. After considering improvements client-side (e.g. drop last groupby when there are too many datasets to render), we concluded that the case of report.project.task.user is rather isolated. The real issue is that this 'complex' two-level groupby is forced in the view itself, making it unusable on larger databases (e.g. next.odoo.com). On top of that, project_id and user_id are usually dependent dimensions (users are usually working in the same few projects). PR: #73299 task-2588087 closes odoo/odoo#77013 X-original-commit: 605b4e109afabaff0876ca92cecfce9a6c615977 Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>

view details

push time in a day

pull request commentodoo/odoo

[FIX] test_mail: fix activity tests

@robodoo r+

tde-banana-odoo

comment created time in a day

PR opened odoo/odoo

[FIX] test_mail: fix activity tests

Fix some activity tests: use real test models, try to avoid date issues by using freezegun.

Followup of odoo/odoo@a26e6e954c5e6c773f37e9239138a7b94ded821f and odoo/odoo@06dee038ddd0e2344c45d4f20e79c28fc78407de .

Task-2654840

+86 -64

0 comment

2 changed files

pr created time in a day

push eventodoo-dev/odoo

Thibault Delavallée

commit sha bd91a2a4befc5cc72313cec9cf725e3dd5081da6

[FIX] test_mail: fix activity tests Fix some activity tests: use real test models, try to avoid date issues by using freezegun. Followup of odoo/odoo@a26e6e954c5e6c773f37e9239138a7b94ded821f and odoo/odoo@06dee038ddd0e2344c45d4f20e79c28fc78407de . Task-2654840

view details

push time in a day

create barnchodoo-dev/odoo

branch : saas-14.5-fix-act-tde

created branch time in a day

Pull request review commentodoo/odoo

[FIX] website_event: fix the direction of event sub-menus

  	<t t-name="website.track_page"> 		<div role="separator" class="dropdown-divider"/>-		<a href="#" name="switch-track-page" class="dropdown-item" role="menuitem">+		<a name="switch-track-page" class="dropdown-item" role="menuitem">

Actually it was understood as a nasty comment but I understand what is behind :D . I always try to balance minimal diff in stable / refactoring in master (even 14.5, it is frozen even if we can make more changes). Here it seems it is not that much work to do cleanly indeed, so we will try the clean approach :) .

mish-odoo

comment created time in a day

PullRequestReviewEvent

pull request commentodoo/odoo

[FIX] website_event: correctly display 'Event Sub-menu' customize menu

@robodoo r+

mish-odoo

comment created time in a day

pull request commentodoo/odoo

[FIX] website_event: fix the direction of event sub-menus

@mish-odoo Could you give a try to @qsm-odoo and @sdegueldre proposal ? Using li instead of anchors.

Thanks !

mish-odoo

comment created time in a day

Pull request review commentodoo/odoo

[FIX] website_event: fix the direction of event sub-menus

  	<t t-name="website.track_page"> 		<div role="separator" class="dropdown-divider"/>-		<a href="#" name="switch-track-page" class="dropdown-item" role="menuitem">+		<a name="switch-track-page" class="dropdown-item" role="menuitem">

Thanks for your input.

mish-odoo

comment created time in a day

PullRequestReviewEvent

Pull request review commentodoo/odoo

Master time off accrual prorata wbr

  DAYS = ['sun', 'mon', 'tue', 'wed', 'thu', 'fri', 'sat'] MONTHS = ['jan', 'feb', 'mar', 'apr', 'may', 'jun', 'jul', 'aug', 'sep', 'oct', 'nov', 'dec']+# Used for displaying the days and reversing selection -> integer+DAY_SELECT_VALUES = [str(i) for i in range(1, 29)] + ['last']+# Integer to ordinal string, found of stackoverflow: https://stackoverflow.com/a/50992575+DAY_SELECT_DISPLAYS = ["%d%s" % (i, "tsnrhtdd" [(i / 10 % 10 != 1) * (i % 10 < 4) * i % 10::4]) for i in range(1, 29)] + ['last day']

I know people who master translations and language management for dates, isn't it @mart-e ?

Williambraecky

comment created time in a day

PullRequestReviewEvent

Pull request review commentodoo/odoo

[FIX] website_event: fix the direction of event sub-menus

  	<t t-name="website.track_page"> 		<div role="separator" class="dropdown-divider"/>-		<a href="#" name="switch-track-page" class="dropdown-item" role="menuitem">+		<a name="switch-track-page" class="dropdown-item" role="menuitem">

Remember we are talking about 14.5 (aka minimal diff). So it seems fix is ok according to @sdegueldre , waiting for a cleaning to schedule in master.

mish-odoo

comment created time in a day

PullRequestReviewEvent