This is driving me crazy. I spent the whole day and I still cannot figure out the issue I'm facing.

Our backend sends a json response that can contain different values for the same key every time.

Example of First variation:

{
  "title": "2",
  "profile_image": {
    "profile_image_id": "4581542",
    "sized": "media/up/2020/48/460e689e286ca46b1006b62269ee21a22b6bdabf2496506e34e5d07c5d42c20f_user_photo_160674563705555.sized.JPG",
    "sized_w": "556",
    "sized_h": "555",
    "thumb": "media/up/2020/48/460e689e286ca46b1006b62269ee21a22b6bdabf2496506e34e5d07c5d42c20f_user_photo_160674563705555.thumb.JPG",
    "thumb_w": "90",
    "thumb_h": "90"
  },
  "profile": {
    "title": "2",
    "first_name": "John",
    "last_name": "Doe",
    "user_online_status": false
  }
}

And below is an another variation of the same response. Notice the profile_image field is now an Array type and user_online_status can also be a string or a boolean.

{
  "title": "2",
  "profile_image": [
    
  ],
  "profile": {
    "title": "2",
    "first_name": "John",
    "last_name": "Doe",
    "user_online_status": "0"
  }
}

How can I parse such responses using Retrofit and Moshi without creating extra model classes? Can I use a custom adapter Maybe? Could you give me an example? I tried to make an adapter of my own but didn't managed to get far

class SkipEmptyProfileAdapter {
    

    @FromJson
    fun fromJson(reader: JsonReader): UserProfileDataResponse? {
        val moshi = Moshi.Builder().build()

        reader.beginObject()
        while (reader.hasNext()) {
            if (reader.nextName() == "profile_image") {
                Timber.i("PROFILE IMAGE")
                val pls = reader.peek()
                if (pls == JsonReader.Token.BEGIN_ARRAY)
                    return null
            }
        }
        reader.endObject()
        return null
    }

}

Can you help me out?

Stack Overflow is the place for questions like this, this is a forum for bugs in Moshi.

That being said, it looks like you're moving in the right direction. A custom type adapter and peek() is the right way to deal with that kind of garbage. I'd recommend continuing down that path and handling the other possible cases, and head to Stack Overflow if you end up stuck on a specific part.

This is driving me crazy. I spent the whole day and I still cannot figure out the issue I'm facing.

Our backend sends a json response that can contain different values for the same key every time.

Example of First variation:

{
  "title": "2",
  "profile_image": {
    "profile_image_id": "4581542",
    "sized": "media/up/2020/48/460e689e286ca46b1006b62269ee21a22b6bdabf2496506e34e5d07c5d42c20f_user_photo_160674563705555.sized.JPG",
    "sized_w": "556",
    "sized_h": "555",
    "thumb": "media/up/2020/48/460e689e286ca46b1006b62269ee21a22b6bdabf2496506e34e5d07c5d42c20f_user_photo_160674563705555.thumb.JPG",
    "thumb_w": "90",
    "thumb_h": "90"
  },
  "profile": {
    "title": "2",
    "first_name": "John",
    "last_name": "Doe",
    "user_online_status": false
  }
}

And below is an another variation of the same response. Notice the profile_image field is now an Array type and user_online_status can also be a string or a boolean.

{
  "title": "2",
  "profile_image": [
    
  ],
  "profile": {
    "title": "2",
    "first_name": "John",
    "last_name": "Doe",
    "user_online_status": "0"
  }
}

How can I parse such responses using Retrofit and Moshi without creating extra model classes? Can I use a custom adapter Maybe? Could you give me an example? I tried to make an adapter of my own but didn't managed to get far

class SkipEmptyProfileAdapter {
    

    @FromJson
    fun fromJson(reader: JsonReader): UserProfileDataResponse? {
        val moshi = Moshi.Builder().build()

        reader.beginObject()
        while (reader.hasNext()) {
            if (reader.nextName() == "profile_image") {
                Timber.i("PROFILE IMAGE")
                val pls = reader.peek()
                if (pls == JsonReader.Token.BEGIN_ARRAY)
                    return null
            }
        }
        reader.endObject()
        return null
    }

}

Can you help me out?

val isNullable = parameterElement.asType().asTypeName().isNullable

When I do, it always returns null

val isNullable = parameterElement.asType().asTypeName().isNullable

When I do, it always returns null

I like the AsyncDispatcher approach. I'm interested to play with it and see where complexities arise is a highly concurrent protocol like BitTorrent.

I don't think there's much need for accessing N files concurrently with less than N threads. Probably the best upside for async is an event-driven API like the above to avoid context switching. As with the sockets example, the events should be on big boundaries (entire file?!) and not per byte.

Something to think about -- although Linux specific, io_uring allows for asyncio on both sockets and files with the options to poll instead of making heavy kernel system calls. It's possible to perform I/O using io_uring with very few kernel to user space context switches.

@ZacSweers please help!

Haven't looked at the Gradle plugin implementation, but I wonder if this can be achieved by simply inheriting from the right Gradle task types, smth like Test. Will take a closer look.

As test suites grow, it would be handy to be able to pass filtering arguments to Paparazzi tasks, similar to Gradle's built-in test tasks (see Test filtering):

./gradlew views:recordPaparazziDebug --tests FooView

I am not able to repro. Is it possible that your proto file is added twice to the whole graph?

If you have a failing test, or a reproducing repo, that'd help.

Since ImmediateDispatcher is depth-first and somehow "preferable", we should offer a choice to use this dispatcher. And for now dispatcher in AsyncEventBus is always coded to legacyDispatcher while constructing(See AsyncEventBus).

Thanks for your feature request. At this point we are not actively developing EventBus. There are several more modern frameworks for event-driven or reactive programming, including RxJava among others.

This ticket is almost the same as #2986 but deals with the EventBus instead of the AsycEventBus object.

I am using the EventBus object not as global object (static or singleton) but on a single instance per user session. In this scenario, instantiating for each EventBus instance an instance of PerThreadQueuedDispatcher with all the ThreadLocal variables does not make much sense. It would be better to have the possibility to use ImmediateDispatcher.INSTANCE by making Dispatcher.immediate() public - as well as changing the package visibility of the class Dispatcher to public. Changing the package visible constructor EventBus(String,Executor,Dispatcher,SubscriberExceptionHandler) would enable much more flexibility.

Thanks for your feature request. At this point we are not actively developing EventBus. There are several more modern frameworks for event-driven or reactive programming, including RxJava among others.

This code has been reviewed and submitted internally. Feel free to discuss on the PR, and we can submit follow-up changes as necessary.

Commits:

<p> PUBLIC: Add missing Override annotations.

da5e9d98f43b039c64a62182614f74ca188cd2ce

Fixes #1016 Fixes #1018

Sample incorrectly generated code:

public expect open abstract class AbortSignal : EventTarget() {
  public open val aborted: Boolean?
}

Error: "Expected classes cannot initialize supertypes"

Sample of invalid generated code:

public open abstract external class AbortSignal : EventTarget() {
  public val aborted: Boolean?
}

@dave-r12 I have updated the description with a more detailed and similar configuration. But I also can include it here below.

We can not reproduce the issue, we tried different things but it was impossible so far. After few ideas I could only simulate the behaviour of the issue "corrupting" manually the cache files and that way I was able to get the same stack trace and error, but I couldn't reproduce the root cause and understand why the cache file was corrupted.

We are also happy to provide more detailed information with few production endpoints causing the issue in a private channel if needed.

We are currently using two Okhttp instances configured as follow:

val clientBuilder = OkHttpClient.Builder()

clientBuilder.protocols(listOf(Protocol.HTTP_1_1))

clientBuilder.addInterceptor { chain ->
    val originalRequest = chain.request()
    val requestWithUserAgent = originalRequest.newBuilder()
            .header("User-Agent", "Example/1.0.0 HTTPClient Android").build()
    chain.proceed(requestWithUserAgent)
}

val certificatePinner = CertificatePinner.Builder()
certificatePinner.add("*.example.com", "sha256/public-key-1")
clientBuilder.certificatePinner(certificatePinner.build())

val cacheDir = File(context.cacheDir, "new_caching_directory")
val cache = Cache(cacheDir, (16 * 1024 * 1024).toLong())
clientBuilder.cache(cache)

val okhttpClient = clientBuilder.build()

val loggingInterceptor = HttpLoggingInterceptor()
loggingInterceptor.level = HttpLoggingInterceptor.Level.NONE

val clientBuilder = OkHttpClient.Builder()
        .protocols(listOf(Protocol.HTTP_2, Protocol.HTTP_1_1))
        .addInterceptor(loggingInterceptor)

val certificatePinner = CertificatePinner.Builder()
certificatePinner.add("*.example2.com", "sha256/public-key-2")
clientBuilder.certificatePinner(certificatePinner.build())

val httpClient = clientBuilder.build()
httpClient.dispatcher.maxRequestsPerHost = 32
httpClient.dispatcher.maxRequests = 32

val cacheDir = File(context.cacheDir, "new_caching_directory_2")
val cache = Cache(cacheDir, (8 * 1024 * 1024).toLong())
httpClient.newBuilder().cache(cache).build()

This code has been reviewed and submitted internally. Feel free to discuss on the PR, and we can submit follow-up changes as necessary.

Commits:

<p> PUBLIC: Add missing Override annotations.

da5e9d98f43b039c64a62182614f74ca188cd2ce

Done :)

Fixes #820