profile
viewpoint
Samuel Walladge swalladge Australia https://swalladge.net Australian software engineer, web developer, Linux enthusiast, pythonista, vimmer.

insanum/sncli 316

Simplenote CLI

swalladge/antarctic-vim 8

A bleak, functional colorscheme with a splash of colour where needed.

kennib/ncss-api 3

Simple APIs for teaching at the National Computer Science School

swalladge/c-calculator 2

HIT365 assignment 2: calculator in C

kennib/Boomerang 1

Key/Value storage API for NCSS

kennib/necsus 1

An NCSS messaging client

swalladge/crisp-modified 1

modified version of the Crisp Ghost blog theme

swalladge/dotfiles-manager 1

experimental dotfiles manager in rust for PRT455

edx-olive/edx-platform 0

The Open edX platform, the software that powers edX!

pull request commentedx/course-discovery

[SE-3515] Handle JSON decoder error is api returns 404

@pkulkark :+1:

  • [x] I tested this: followed test instructions
  • [x] I read through the code
  • [ ] NA I checked for accessibility issues
  • [x] Includes documentation
pkulkark

comment created time in 2 hours

PR opened edx/blockstore

Fix `make stop` command

This was broken since the docker-compose filename now includes the PYTHON_VERSION variable. This fixes by using the same project names and docker compose file names as used in the other commands.

Test instructions:

Run make stop and verify that it completes successfully.

Reviewers:

  • [ ] TBD
  • [ ] edX reviewer TBD
+2 -1

0 comment

1 changed file

pr created time in 3 days

create barnchopen-craft/blockstore

branch : samuel/fix-makefile-cmd

created branch time in 3 days

delete branch edx-olive/edx-platform

delete branch : samuel/undo-cxx-visibility

delete time in 3 days

push eventedx-olive/edx-platform

Samuel Walladge

commit sha 9d5e4c79e8c63c8dab3f6f465a4a6a9c22999f77

Revert "hide ccx courses from catalog" This reverts commit b44713f2957d68dac257fcb99984d27164a74bf2. This is no longer required for client, and by reverting this, we reduce code drift from upstream.

view details

Samuel Walladge

commit sha 909f79ba13735f510c276bc2668457aeb479c23e

Merge pull request #38 from edx-olive/samuel/undo-cxx-visibility SE-3494 Revert "hide ccx courses from catalog"

view details

push time in 3 days

PR merged edx-olive/edx-platform

Reviewers
SE-3494 Revert "hide ccx courses from catalog"

This reverts commit b44713f2957d68dac257fcb99984d27164a74bf2.

This is no longer required for client, and by reverting this, we reduce code drift from upstream.

Test instructions:

  • verify that this reverts https://github.com/edx-olive/edx-platform/pull/6 exactly
  • deploy to stage and do some spot checks viewing courses you do and don't have access to (the code change was minor and clean, so it should be fine)

Reviewers:

  • [x] @Kelketek
+4 -96

3 comments

2 changed files

swalladge

pr closed time in 3 days

Pull request review commentedx/edx-platform

SE-977 assign cohort and course mode on bulk register students

 def test_account_creation_and_enrollment_with_csv_with_blank_lines(self, info_lo         """         csv_content = b"\ntest_student@example.com,test_student_1,tester1,USA\n\n"         uploaded_file = SimpleUploadedFile("temp.csv", csv_content)-        response = self.client.post(self.url, {'students_list': uploaded_file})+        response = self.client.post(self.url, {'students_list': uploaded_file, 'email-students': True})

Flagging that this may be a backwards incompatible api change. It does make it more consistent with the other batch api methods though.

swalladge

comment created time in 4 days

PullRequestReviewEvent

push eventopen-craft/edx-platform

Samuel Walladge

commit sha e922ca71ea39a2e485c9315fd68a89a04b6ed5fc

Add email-students to tests for csv batch enrol

view details

push time in 4 days

pull request commentjdm-contrib/jdm

DEV.to now has a delete account button

@tupaschoal fair enough. :) Apparently you can add the hacktoberfest-accepted label to individual PRs so only those PRs count, as an alternative to the hacktoberfest topic (if you'd like to try that instead of the blanket topic label) - according to the FAQ:

You can still contribute to any public GitHub repository and have it count towards your progress provided that your pull request is labeled with hacktoberfest-accepted.

swalladge

comment created time in 5 days

pull request commentjdm-contrib/jdm

DEV.to now has a delete account button

@tupaschoal would you mind adding the hacktoberfest-accepted label to this PR so it counts towards Hacktoberfest? Totally understand if you don't want to due to the possibility of attracting spam. :)

swalladge

comment created time in 5 days

pull request commentedx-olive/edx-platform

SE-3494 Revert "hide ccx courses from catalog"

Thanks @Kelketek

However I've noticed the build is failing. Do we know anything about that?

Yeah the tests are failing everywhere on this fork; we haven't had time or inclination to look into them unfortunately.

swalladge

comment created time in 5 days

delete branch open-craft/configuration

delete branch : samuel/oauth-retirement-vars-fix

delete time in 5 days

PR opened edx-olive/edx-platform

Reviewers
SE-3494 Revert "hide ccx courses from catalog"

This reverts commit b44713f2957d68dac257fcb99984d27164a74bf2.

This is no longer required for client, and by reverting this, we reduce code drift from upstream.

Test instructions:

  • verify that this reverts https://github.com/edx-olive/edx-platform/pull/6 exactly
  • deploy to stage and do some spot checks viewing courses you do and don't have access to (the code change was minor and clean, so it should be fine)

Reviewers:

  • [ ] @Kelketek
+4 -96

0 comment

2 changed files

pr created time in 6 days

create barnchedx-olive/edx-platform

branch : samuel/undo-cxx-visibility

created branch time in 6 days

push eventopen-craft/edx-platform

Ali-D-Akbar

commit sha 5ddc818fe4825bbda0f70a208ae67a7751d4b6f4

PROD-2112

view details

Ali-D-Akbar

commit sha cdd3fe53dc24728cb1c58f65967fa47b298fdb22

PROD-2113

view details

Ali-D-Akbar

commit sha cba81270e2154bb99ab154bab75d37feec32e41d

PROD-2120

view details

Ali-D-Akbar

commit sha e085de2230658d363992c338271e72a1c4773ead

PROD-2115

view details

Ali-D-Akbar

commit sha dbdecb150182c112777f941c278f964ba023382e

PROD-2121

view details

SaadYousaf

commit sha a0147c269b9b4e0e615f40f803f16818befa099b

PROD-2119

view details

SaadYousaf

commit sha c08006723a65ab30db597cf8a915d92f4378ed46

PROD-2124

view details

Agrendalath

commit sha 87997d0975eaceb545e1627f7c087bc6e0940858

[BB-2120] Add `%%COURSE_ID%%` keyword to HTML block Until now only `%%USER_ID%%` was supported. This adds a new keyword that can be used inside an HTML block.

view details

Matthew Piatetsky

commit sha 762060022062ab123ca5fab1e703cd7ab48c4164

Revert "Revert "[REV-774] Show content type gating upsell when a limited access learner tries to access a timed exam""

view details

Guruprasad Lakshmi Narayanan

commit sha ba5c5e0913e1286935364aa04a5c3e4a81412b5e

Fix the automatic enrollment issue for inactive user When a user registers an account and is enrolled in a course by the instructor before completing the email validation, the course shows up in the dashboard of the logged-in user. This change adds a check for the email validation before enrolling the user.

view details

Matthew Piatetsky

commit sha be2d534488006c47e730d0b725d7707cfc8b1ecf

Gate sequence if it is a timed exam and contains content type gated problems The previous attempt to implement this was bugged because it was not respecting manual exceptions to content type gating. This is fixed by checking has_access for each child problem of the sequence. REV-1510

view details

edX requirements bot

commit sha 5bcb288ef78dc70ed559c640dec9cafca1f0d6e7

Updating Python Requirements

view details

HammadAhmadWaqas

commit sha 215d0049309fd776750b84dfbc77847bfc8716cf

Handle Client Error for the API called in refund_order_voucher signal.

view details

Hammad Ahmad Waqas

commit sha fc1d7d2318e4a9a27e18c1f17611090c50f8f4f7

Merge pull request #25228 from edx/hammad/ENT-3523 ENT-3523 | Handle Client Error for the API called in refund_order_voucher signal.

view details

Aarif

commit sha 76e15a93946401fc66c0a015d3fd3412b01b3d19

Python Requirements Update (#25272)

view details

Ali Akbar

commit sha ba963363073a41034c8c09143beb98eee8933ba5

Merge pull request #204 from edx/sustaining/security-fixes-6 Sustaining security fixes 6

view details

edx-pipeline-bot

commit sha 506f5801089f5190682caec82938ee56b1c958f7

Merge pull request #25275 from edx/private_to_public_ba96336 Mergeback PR from private to public.

view details

muhammad-ammar

commit sha 28689b5003896b96c999dc3245e705f4e126dd9f

upgrade edx-enterprise ENT-3442

view details

Muhammad Ammar

commit sha e0de14bc56638b1e9826f536a7d81b158cfa932b

Merge pull request #25279 from edx/ammar/ent-3442-upgrade-edx-enterprise upgrade edx-enterprise

view details

Carla Duarte

commit sha 080f04c18ce1c002aaeb927216e4f34e876e9afd

AA-371: Progress Milestone Waffle Flags

view details

push time in 6 days

delete branch swalladge/jdm

delete branch : dev-update

delete time in 6 days

delete branch open-craft/ansible-playbooks

delete branch : samuel/tag-rabbit-relic-dep

delete time in 7 days

push eventopen-craft/ansible-playbooks

Samuel Walladge

commit sha eccfaeec4d151136edde9ff1e4d259d237df8848

Tag the newrelic_infra dependency This allows using the `rabbitqm-newrelic` tag to run all newrelic related tasks for rabbtimq hosts. Just for convenience.

view details

Samuel Walladge

commit sha 1e883d98bf55a1b85d7af466ed85c92a66976dac

Merge pull request #189 from open-craft/samuel/tag-rabbit-relic-dep SE-3328 Tag the newrelic_infra dependency

view details

push time in 7 days

PR merged open-craft/ansible-playbooks

SE-3328 Tag the newrelic_infra dependency

This allows using the rabbitmq-newrelic tag to run all newrelic related tasks for rabbtimq hosts. Just for convenience.

Test instructions:

  • run the playbook against a rabbitmq server with the rabbitmq-newrelic tag (in some test mode if possible), and verify that the dependency is run also.

Reviewers:

  • [x] @pomegranited
+2 -0

0 comment

1 changed file

swalladge

pr closed time in 7 days

PR opened open-craft/ansible-playbooks

Reviewers
SE-3328 Tag the newrelic_infra dependency

This allows using the rabbitmq-newrelic tag to run all newrelic related tasks for rabbtimq hosts. Just for convenience.

Test instructions:

  • run the playbook against a rabbitmq server with the rabbitmq-newrelic tag (in some test mode if possible), and verify that the dependency is run also.

Reviewers:

  • [ ] @pomegranited
+2 -0

0 comment

1 changed file

pr created time in 7 days

create barnchopen-craft/ansible-playbooks

branch : samuel/tag-rabbit-relic-dep

created branch time in 7 days

push eventopen-craft/ansible-playbooks

Samuel Walladge

commit sha 9ae7d6b757be23ceb674bc83678590f6f46dad3d

Add tasks for newrelic infra and rabbit integration This is so we can use the newrelic infra rabbitmq plugin to monitor rabbitmq queues, etc. To be used for alerting and debugging.

view details

Samuel Walladge

commit sha e29f8578dcf0fd1d02e66580aa7a5b40403c5377

Fix issues with rabbitmq deployment - random rabbitmq user and vhost is not used - specifying "rabbit@{{ RABBITMQ_HOSTNAME }}" was causing the vhost /test task to fail

view details

Samuel Walladge

commit sha 618a9a77ff3c6df6b75653d11272aad164032f4d

Merge pull request #187 from open-craft/samuel/newrelic-rabbit SE-3328 Add newrelic infra and rabbit integration

view details

push time in 10 days

PR merged open-craft/ansible-playbooks

SE-3328 Add newrelic infra and rabbit integration

This adds support for newrelic infrastructure plugin with the rabbitmq integration running on rabbitmq instances. It should allow us to collect metrics on rabbitmq, and use those metrics for alerting (for example, if queue lengths go through the roof).

It also fixes some issues with running the playbook.

Test instructions:

  • deploy rabbitmq and verify that it completes successfully
  • check newrelic and verify that it is receiving metrics from the rabbitmq instance
+86 -17

0 comment

8 changed files

swalladge

pr closed time in 10 days

push eventopen-craft/ansible-playbooks

Farhaan Bukhsh

commit sha eb8faa6e98b84a911ed5f2131c3926f68821876c

[BB-3036] Fix MySQL 5.6 deployment (#186) Fix MySQL 5.6 deployment Signed-off-by: Farhaan Bukhsh <farhaan@opencraft.com>

view details

Samuel Walladge

commit sha 9ae7d6b757be23ceb674bc83678590f6f46dad3d

Add tasks for newrelic infra and rabbit integration This is so we can use the newrelic infra rabbitmq plugin to monitor rabbitmq queues, etc. To be used for alerting and debugging.

view details

Samuel Walladge

commit sha e29f8578dcf0fd1d02e66580aa7a5b40403c5377

Fix issues with rabbitmq deployment - random rabbitmq user and vhost is not used - specifying "rabbit@{{ RABBITMQ_HOSTNAME }}" was causing the vhost /test task to fail

view details

push time in 10 days

delete branch open-craft/configuration

delete branch : samuel/fix-digicert-upstream

delete time in 10 days

push eventopen-craft/ansible-playbooks

Samuel Walladge

commit sha c9b2b1e0e6e99fd27c40ae702488c945f3391085

Fix issues with rabbitmq deployment - random rabbitmq user and vhost is not used - specifying "rabbit@{{ RABBITMQ_HOSTNAME }}" was causing the vhost /test task to fail

view details

push time in 11 days

Pull request review commentopen-craft/ansible-playbooks

SE-3328 Add newrelic infra and rabbit integration

+---+dependencies:+  - role: newrelic_infra

As discussed, we don't want to deal with upgrading rabbitmq, so the existing pinned versions can stay. :)

swalladge

comment created time in 11 days

PullRequestReviewEvent

PR opened jdm-contrib/jdm

DEV.to now has a delete account button

As in the title. :)

+1 -1

0 comment

1 changed file

pr created time in 11 days

create barnchswalladge/jdm

branch : dev-update

created branch time in 11 days

push eventopen-craft/ansible-playbooks

Samuel Walladge

commit sha 6a3b9101588ea568cf0ca603bd8a3f8f089d0650

use variable for port

view details

push time in 11 days

Pull request review commentopen-craft/ansible-playbooks

SE-3328 Add initial tasks for newrelic infra and rabbit integration

+---+dependencies:+  - role: newrelic_infra

That's part of the reason we're getting dependency issues on stage; I think we'll need to re-pin back... Will have a play and see how it goes.

swalladge

comment created time in 11 days

PullRequestReviewEvent

push eventopen-craft/ansible-playbooks

Samuel Walladge

commit sha c8704e1a32187551fd2e4ee03671b8d15b738822

Fixes for rabbitmq integration config

view details

push time in 12 days

PR closed edx/edx-ora2

Reviewers
SE-1321 add multiple files upload allowed option engineering review open-source-contribution

This PR adds an option to toggle between allowing multiple files uploaded and only allowing a single file. This is fully backwards compatible. Currently behaviour is to allow students to select an arbitrary number of files for the file upload response. Adding this option allows course authors to limit this to a single file upload.

For now, this is to be treated as a prototype. Hence no tests or updated translations yet.

JIRA tickets: OSPR-3768

Dependencies: None

Screenshots:

1564542275

Sandbox URL:

  • LMS: https://orapr1256.sandbox.opencraft.hosting/
  • Studio: https://studio.orapr1256.sandbox.opencraft.hosting/

Merge deadline: None

Testing instructions:

  1. create a new ora assessment on a course in studio
  2. in the settings, make sure the file response is required or optional
  3. below that in the settings, change "allow multiple files" to false (it must be true by default)
  4. save and publish the ora
  5. open the ora in the lms
  6. click the button to upload files and confirm that only one file can be selected (ctl+click on multiple files will select multiple files if enabled)
  7. select a single file and upload it. verify that it uploads successfully
  8. repeat uploading a file to verify that uploading a new file, replacing the old file, still works
  9. using the browser dev tools, inspect the upload file input and add the multiple attribute.
  10. attempt to upload multiple files by selecting multiple files, adding a description for each one, and clicking upload files
  11. verify that this is rejected server-side with an error message
  12. refresh the page and verify that only the single, previously successfully uploaded file is visible
  13. create a new ora assessment with a file response, but leaving "allow multiple files" as True
  14. attempt to upload multiple files on this new assessment and verify that this still works successfully

Author notes and concerns:

  • ~Need to decide which is better from a UX point of view: rejecting with an error message, or simply removing any existing files in upload_url before returning the url. Either way, this case shouldn't happen unless someone is messing with the html elements and specifically tries to submit multiple files.~ Left as a rejection with error message.
  • ~Need to add a note to the UI next to the file upload input for students to know whether multiple files are allowed or not.~ possibly ok

Reviewers

  • [x] @pomegranited
  • [ ] edX reviewer[s] TBD
+294 -9

26 comments

31 changed files

swalladge

pr closed time in 13 days

pull request commentedx/edx-ora2

SE-1321 add multiple files upload allowed option

@jansenk, thanks for creating the updated PR! Closing this in favour of https://github.com/edx/edx-ora2/pull/1516

swalladge

comment created time in 13 days

push eventopen-craft/ansible-playbooks

Samuel Walladge

commit sha 67ebc706e3ff084d2276a0e1d8e120b5a1ba07ca

fix typo

view details

push time in 14 days

PR opened open-craft/ansible-playbooks

Reviewers
SE-3328 Add initial tasks for newrelic infra and rabbit integration

WIP: currently testing on stage.

+63 -0

0 comment

7 changed files

pr created time in 14 days

create barnchopen-craft/ansible-playbooks

branch : samuel/newrelic-rabbit

created branch time in 14 days

startedRalim/ts100

started time in 16 days

pull request commentedx/edx-ora2

SE-1321 add multiple files upload allowed option

@jansenk , thanks, this is awesome!

if you're alright with it, I could also just directly merge edx:jkantor/uploadfiles-test (my 'resolution' branch.)

Yes, this would be great! Thank you. :)

swalladge

comment created time in 17 days

PullRequestReviewEvent

delete branch open-craft/edx-platform

delete branch : josh/SE-3472-file-uploads

delete time in 18 days

push eventopen-craft/edx-platform

Awais Jibran

commit sha 1962ef1cc258bcc924bc70014c009f76d6fa5254

Fix video handouts uploads.

view details

Samuel Walladge

commit sha 90590a21a5c4faf52ed4a857dab462b3d35c765a

Merge pull request #272 from open-craft/josh/SE-3472-file-uploads Cherry pick fix for Studio file upload issues

view details

push time in 18 days

PR merged open-craft/edx-platform

Cherry pick fix for Studio file upload issues

This cherry picks a fix from open-release/juniper.master to fix file upload issues on the studio.

When selecting a file for uploading to the Course Card image, or the Certificate Signatory Editor view, instead of showing the file it shows "[object HTMLInputElement]", and the file upload fails. This cherry picked fix from upstream fixes the issue.

JIRA tickets: Fixes SE-3472.

Screenshots: Without this fix after using the file selection dialog: Screenshot_2020-10-07 Schedule Details Settings Demonstration Course Studio

Testing instructions:

  1. Attempt to change Course Card Image in the studio to test the file upload dialog
  2. Ensure that it correctly shows the path and the upload works

Reviewers

  • [ ] (@swalladge )
+2 -2

1 comment

1 changed file

kaizoku

pr closed time in 18 days

pull request commentopen-craft/opencraft

SE-3310 Ensure prod instances email urgent on monitoring fail and alerts auto close once resolved

Merging because the integration test failures are unrelated.

swalladge

comment created time in 18 days

delete branch open-craft/opencraft

delete branch : samuel/monitoring-emails

delete time in 18 days

push eventopen-craft/opencraft

Samuel Walladge

commit sha 7c9e9a7662cf3077af5bcbcc4c693984d2eeb3e3

Ensure prod instances email urgent on monitoring fail Otherwise we only get paged on a provision failure; ping monitoring previously would only email the settings.ADMINS emails.

view details

Samuel Walladge

commit sha a2c3a509829e542040b157e73475a372fa61bb6a

Use sum instead of single value for NR alerts This should allow the alerts to be auto closed. With the original single_value setup, alerts would only be autoclosed if _every_ query returned at least 1 for a full 16 minutes. This is impossible, because ping monitors ping in only 5 minute intervals, and the range for a single query is 1 minute, so there will be at most 2 successive queries returning at least 1. By switching to sum, it has the same behaviour of opening an alert, but the auto close condition becomes 'at least 1 in the last 16 minutes', which is an easy condition to meet once the instance comes back online.

view details

Samuel Walladge

commit sha 2ab57ef162bd2621820f4f6fb5c04676b3207694

Merge pull request #651 from open-craft/samuel/monitoring-emails SE-3310 Ensure prod instances email urgent on monitoring fail and alerts auto close once resolved

view details

push time in 18 days

PR merged open-craft/opencraft

SE-3310 Ensure prod instances email urgent on monitoring fail and alerts auto close once resolved

Otherwise we only get paged on a provision failure; ping monitoring previously would only email the settings.ADMINS emails.

Test instructions:

  • register a new account, choose instance settings, and confirm your email
  • view the settings of the new instance
  • verify that additional_monitoring_emails has the PROD_APPSERVER_FAIL_EMAILS added
  • verify that the corresponding newrelic alert policy for the new instance has ADMINS and PROD_APPSERVER_FAIL_EMAILS set in the notification channels
  • do something to take the instance offline (change the dns records, stop the lms service, etc.)
  • verify that newrelic alerts open
  • put the instance back online
  • verify the newrelic alerts/incidents auto close after a few minutes.

Reviewers:

  • [x] @giovannicimolin
  • [ ] @lgp171188
+4 -2

0 comment

4 changed files

swalladge

pr closed time in 18 days

PullRequestReviewEvent

push eventopen-craft/edx-platform

Felipe Montoya

commit sha 72483a0f664484f61d8939238a328e2945f231d2

Merge pull request #24379 from eduNEXT/lmm/ratelimit [BD-6] Use PyPi release of django-ratelimit

view details

Dillon Dumesnil

commit sha b3b812186e4dcaabc224468918d0e351e614bb66

Merge pull request #24434 from edx/ddumesnil/complete-field-date-block Adding in missing field to the DateSummarySerializer

view details

Alex Dusenbery

commit sha 0e2b612c1fb4f3e385f3004801aa5b5ed0221eda

Update edx-enterprise to 3.3.18

view details

Mat Carter

commit sha b386f0a25e270d792354e2d2a56ac4b77b2d49d4

ensure anonymous_id is persisted for each team member in a team

view details

Mat Carter

commit sha 5a90bf7f4089b5babbbb50c89a403fb90713ed3f

EDUCATOR-5088 - updated test to ensure record is stored.

view details

Feanil Patel

commit sha 4ac2c5e92b34904d5a54f3e76993a3ac646e09bb

Correct logic on building marketing links. The logic used to has a special case for edge in the hostname which didn't really make sense. So instead we just check to see if the given url starts with http and if it does we return it directly. If it doesn't, then we try to convert it to a valid url and return that. If that fails we return . Add a new custom metric `unresolved_marketing_link` to track when we run into this scenario.

view details

Michael Terry

commit sha 6ff23be32027cf523d779fae9d4f8144361c650d

Bump edx-when to 1.2.9 This prevents seeing due dates for enrollments originally created too close to the course end to allow for finishing the course in time. AA-195

view details

edX requirements bot

commit sha 98e606d23b54943b7256da3b44debc98a201bda4

Updating Python Requirements

view details

adeelehsan

commit sha b26f26e993bfd5021bd8cc28966b080979aa1ce3

Get user email from request PROD-674

view details

Aarif

commit sha bf4ea104c060f4e3a981b382a0aec77e8a323551

Python Requirements Update (#24445)

view details

Justin Lapierre

commit sha bf4b87627b98dd4065d8036dd798ffec42a80aeb

Merge branch 'master' of github.com:edx/edx-platform into EDUCATOR-5080

view details

Michael Terry

commit sha 7a0ae455f70aada49df14dcbd4f9fb4d65183e51

Merge pull request #24442 from edx/mikix/update-when Bump edx-when to 1.2.9

view details

Justin Lapierre

commit sha 6efa2c8f942a6b04004d8062a063a2408b1b1f11

EDUCATOR-5080 - Removed repeat argument from test method

view details

adeelehsan

commit sha a26b9317db10b4b56c2990c577273f987d51f060

Merge pull request #24418 from edx/aehsan/prod-674/get_useremail_from_request_session Get user email from request

view details

Feanil Patel

commit sha 9bb9d655ec82d058bc1d1847720f0e11a8c6087a

Merge pull request #24438 from edx/feanil/fix_url_link_map_logic_archbom-1336 Correct logic on building marketing links.

view details

Tim McCormack

commit sha 87edb542b15085eca5dd84a5f13aa97a80e2f832

Delete flaky test according to process (#24441) https://openedx.atlassian.net/browse/CR-2425 for re-evaluating it

view details

Feanil Patel

commit sha 2e0e2ef80cd9a6b43617dbb974d07fddee8bd3d1

Revert "Python Requirements Update"

view details

Dillon Dumesnil

commit sha be346499da1faf1f78781d6fce08c00cf0742117

AA-219: Dates Tab behavior improvements This switches the Dates Tab to be an enrolled tab allowing only enrolled learners to view. Additionally, it will now redirect logged out learners to the login page if they hit the Dates Tab directly.

view details

SaadYousaf

commit sha 015aa98a386ca210e36c8aacd500ff01959fa8d8

PROD-1661

view details

SaadYousaf

commit sha 3cbfab378aa8061e9b2974eaa97406ef73a095f6

PROD-1663

view details

push time in 19 days

push eventopen-craft/opencraft

Piotr Surowiec

commit sha 27debc438fe9c3eb35738733427c308d6c371d98

Revert "[BB-2558] Temporarily set default `FORUM_MONGO_AUTH_MECH` to `MONGODB-CR` (#626)" (#655) This reverts commit 23ab8b2b5887fbcc0c6623928de049f740a000f3.

view details

Shimul Chowdhury

commit sha c90fe66556ce83073a6f5590a169cf389b0f09f4

[BB-3014] disable custom domain feature

view details

Josh

commit sha edc57c25ac899713cd9ed50634db801453088f0d

Merge branch 'shimulch/bb-3014-disable-custom-domain-feature' into master

view details

Gábor Boros

commit sha 9ac67382a85c4e7380b15a4caf8e5df02db08b60

Revert "[BB-3014] Disable the custom external domain feature in the Ocim frontend"

view details

Guruprasad

commit sha 991ef75344913b68b044c4c960c9ee219d9f7eb9

Merge pull request #658 from open-craft/revert-647-shimulch/bb-3014-disable-custom-domain-feature Revert "[BB-3014] Disable the custom external domain feature in the Ocim frontend"

view details

Shimul Chowdhury

commit sha 2adf770f010f7a0c3a7e89a6d2da73052a3d28cb

[BB-2164] Erase Ocim trial user data after X months (#653) erase Ocim trial user data scheduled task

view details

Samuel Walladge

commit sha 7c9e9a7662cf3077af5bcbcc4c693984d2eeb3e3

Ensure prod instances email urgent on monitoring fail Otherwise we only get paged on a provision failure; ping monitoring previously would only email the settings.ADMINS emails.

view details

Samuel Walladge

commit sha a2c3a509829e542040b157e73475a372fa61bb6a

Use sum instead of single value for NR alerts This should allow the alerts to be auto closed. With the original single_value setup, alerts would only be autoclosed if _every_ query returned at least 1 for a full 16 minutes. This is impossible, because ping monitors ping in only 5 minute intervals, and the range for a single query is 1 minute, so there will be at most 2 successive queries returning at least 1. By switching to sum, it has the same behaviour of opening an alert, but the auto close condition becomes 'at least 1 in the last 16 minutes', which is an easy condition to meet once the instance comes back online.

view details

push time in 19 days

Pull request review commentopen-craft/opencraft

SE-3310 Ensure prod instances email urgent on monitoring fail and alerts auto close once resolved

 def _provision_instance(sender, **kwargs):          if settings.PROD_APPSERVER_FAIL_EMAILS:             application.instance.provisioning_failure_notification_emails = settings.PROD_APPSERVER_FAIL_EMAILS+            application.instance.additional_monitoring_emails = settings.PROD_APPSERVER_FAIL_EMAILS

Also, provisioning_failure_notification_emails != additional_monitoring_emails, so I'm not sure what you're asking. :thinking:

swalladge

comment created time in 20 days

PullRequestReviewEvent

Pull request review commentopen-craft/opencraft

SE-3310 Ensure prod instances email urgent on monitoring fail and alerts auto close once resolved

 def _provision_instance(sender, **kwargs):          if settings.PROD_APPSERVER_FAIL_EMAILS:             application.instance.provisioning_failure_notification_emails = settings.PROD_APPSERVER_FAIL_EMAILS+            application.instance.additional_monitoring_emails = settings.PROD_APPSERVER_FAIL_EMAILS

@giovannicimolin according to the original requirements, yes we did need this change.

Doing this because we only want to auto set PROD_APPSERVER_FAIL_EMAILS for end user instances.

You can check SE-1832, but I believe the reason to move things to here, is that now they will be autoset up for new instances that are set up through the betatest registration process (our standard documented process for setting up client and maintained instances).

swalladge

comment created time in 20 days

PullRequestReviewEvent

push eventopen-craft/opencraft

Samuel Walladge

commit sha 28449656e98ca60742bbae4019c84c19b3a7fd0d

Use sum instead of single value for NR alerts This should allow the alerts to be auto closed. With the original single_value setup, alerts would only be autoclosed if _every_ query returned at least 1 for a full 16 minutes. This is impossible, because ping monitors ping in only 5 minute intervals, and the range for a single query is 1 minute, so there will be at most 2 successive queries returning at least 1. By switching to sum, it has the same behaviour of opening an alert, but the auto close condition becomes 'at least 1 in the last 16 minutes', which is an easy condition to meet once the instance comes back online.

view details

push time in 21 days

delete branch open-craft/configuration

delete branch : samuel/remove-v2

delete time in 21 days

PR closed edx/configuration

SE-3327 fix simple-theme build by removing lms-main-v2 / discussion-main templates open-source-contribution waiting on author

This was removed in edx-platform in https://github.com/edx/edx-platform/pull/24624

This should fix this error or equivalent:

sass.CompileError: b"Error: File to import not found or unreadable: lms/static/sass/lms-main-v2
    Parent style sheet: /edx/var/edxapp/themes/simple-theme/lms/static/sass/lms-main-v2.scss
    on line 1 of ../../../var/edxapp/themes/simple-theme/lms/static/sass/lms-main-v2.scss
    >> @import 'lms/static/sass/lms-main-v2';
       ^

JIRA tickets: OSPR-5019

Dependencies: None

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None"

Testing instructions:

  1. provision an instance using this branch and with the simple-theme role enabled
  2. verify that it completes successfully and that the theme is compiled and displays as expected

Author notes:

  • this is temporarily based on https://github.com/edx/configuration/pull/6047 for internal testing purposes. Will update soon.

Reviewers

  • [x] @bradenmacdonald
  • [ ] edX reviewer[s] TBD

Settings

+0 -5

7 comments

2 changed files

swalladge

pr closed time in 21 days

pull request commentedx/configuration

SE-3327 fix simple-theme build by removing lms-main-v2 / discussion-main templates

.... actually, this appears to have been added in https://github.com/edx/configuration/pull/5837, so closing as duplicate...

swalladge

comment created time in 21 days

pull request commentedx/configuration

SE-3327 fix simple-theme build by removing lms-main-v2 template

@bradenmacdonald , thanks for the review! I removed the cert validation changes, so the changes here are now only the theme changes. (cert validation changes are in https://github.com/edx/configuration/pull/6047 )

swalladge

comment created time in 21 days

pull request commentedx/configuration

SE-3327 fix simple-theme build by removing lms-main-v2 template

@natabene, this is ready for edX review. :)

swalladge

comment created time in 21 days

push eventopen-craft/configuration

Aarif

commit sha 40dbdf27f3d80a60272a6444f005c167b93f3f29

updated the enterprise-catalog config to deploy on python 3.8

view details

Luis Moreno

commit sha a119edf546645a57fe26515faaef864c8d61b16a

Create role to deploy MFE for native installations

view details

Luis Moreno

commit sha 6f8c1bd04a5b4e0191c6da4a0e9ba6c42a12a09e

Do not create a role for each MFE

view details

syedimranhassan

commit sha ac54c7bb824de29fc2ee5d031353e19a97105ce0

Update Mongo agent

view details

Syed Imran Hassan

commit sha c64803b8f5cab47e2298d05ce4b0eb2c9b48ff22

Merge pull request #6025 from edx/ihassan/ISRE-448_update_mongo_agent Update Mongo agent

view details

Fred Smith

commit sha e8aa4402a148af3115f71aec077f851650aff5eb

Merge pull request #6039 from eduNEXT/mfe/native_installation Create role to deploy MFE for native installations

view details

Bianca Severino

commit sha 9160aa6bdd21631448c660664fd4879546a5f6f7

Registrar image upgraded to use ubuntu 20.04

view details

Bianca Severino

commit sha c6de7fd8643fb8905373a7f3738af5183f257ae1

Merge pull request #6048 from edx/bseverino/registrar-os Registrar image upgraded to use ubuntu 20.04

view details

M. Zulqarnain

commit sha 37f979008bf5e86c212fae14e9fab30a775e0ba8

Update insights configuration to deploy with Python 3.8 (#5975)

view details

Aarif

commit sha 686b2fcc9fd3df177d6555ee10ebc7d02bdee88c

updated the analytics-api config to deploy on python 3.8 (#5910)

view details

nadeemshahzad

commit sha b0699cc25e47db9b9904e78452527b3197a24c5c

fix bionic common docker image

view details

Nadeem Shahzad

commit sha eabce782c761304774382f1c489cf1afd9ec5b0b

Merge pull request #6052 from edx/nadeem/PSRE-285 fix bionic common docker image (PSRE-285)

view details

syedimranhassan

commit sha 6346f9535de8cbd4e7ff810eb2ef2d5ba0a18711

Update build jenkins plugins

view details

Syed Imran Hassan

commit sha 659270d6807ca41362d8ff3ca98cccd3698063ec

Merge pull request #6054 from edx/ihassan/ISRE_555_plugins_update Update build jenkins plugins

view details

Brandon Baker

commit sha 3c0e7c7304f283d0b17f0eb513cb256bb2a4409f

Merge pull request #5912 from edx/BOM-1963 updated the enterprise-catalog config to deploy on python 3.8

view details

Troy Sankey

commit sha ce729d38e7bf598ca42a6e0d82d64a3ac28ae868

jq is required to be able to conveniently use aws sts assume-role Otherwise, you would need to parse the JSON output with sed or python. DENG-382

view details

Troy Sankey

commit sha 64de5028bbf9d88205bbc1bda52e3ad9d4650a9d

Merge pull request #6056 from edx/pwnage101/deng-382 jq is required to be able to conveniently use aws sts assume-role

view details

Rebecca Graber

commit sha 0a6a956d208e89eaf91694c869307d392cfe9842

WS-537 add prospectus prefix to prospectus variables in ansible

view details

Rebecca Graber

commit sha 84d1261c94ce57cb2a9de7c082ca5d2a6ea4b67b

Merge pull request #6057 from edx/rsgraber/WS-537-prospectus-sandbox WS-537 add prospectus prefix to prospectus variables in ansible

view details

Rebecca Graber

commit sha cbe0c0b11b53f00a571bb44b8a0876a07ed892d6

Revert "WS-537 add prospectus prefix to prospectus variables in ansible"

view details

push time in 21 days

push eventopen-craft/opencraft

Samuel Walladge

commit sha a51f380110d588ceaabe8814266f0d9a98727ee3

Ensure prod instances email urgent on monitoring fail Otherwise we only get paged on a provision failure; ping monitoring previously would only email the settings.ADMINS emails.

view details

push time in 24 days

PR opened open-craft/opencraft

Reviewers
SE-3310 Ensure prod instances email urgent on monitoring fail

Otherwise we only get paged on a provision failure; ping monitoring previously would only email the settings.ADMINS emails.

Test instructions:

  • register a new account, choose instance settings, and confirm your email
  • view the settings of the new instance
  • verify that additional_monitoring_emails has the PROD_APPSERVER_FAIL_EMAILS added
  • verify that the corresponding newrelic alert policy for the new instance has ADMINS and PROD_APPSERVER_FAIL_EMAILS set in the notification channels

Reviewers:

  • [ ] @giovannicimolin
  • [ ] @lgp171188
+1 -0

0 comment

1 changed file

pr created time in 24 days

create barnchopen-craft/opencraft

branch : samuel/monitoring-emails

created branch time in 24 days

pull request commentopen-craft/edx-simple-theme

SE-3327 Remove lms-main-v2 template override

@lgp171188 can we split off a juniper branch then? Better if master keeps up with the latest changes if things will start diverging.

swalladge

comment created time in 24 days

push eventopen-craft/edx-simple-theme

Samuel Walladge

commit sha 6fcbea39c2214fb3ccc9d443133deb4543ea5514

Remove lms-discussion-main template This was removed in https://github.com/edx/edx-platform/pull/24101

view details

push time in a month

push eventopen-craft/configuration

Samuel Walladge

commit sha ca8431466f7155687cb60922ae0655b9df2fcc19

Remove lms-discussion-main template This was removed from edx-platform in https://github.com/edx/edx-platform/pull/24101

view details

push time in a month

PR opened edx/configuration

WIP: SE-3327 fix simple-theme build by removing lms-main-v2 template

This was removed in edx-platform in https://github.com/edx/edx-platform/pull/24624

This should fix this error or equivalent:

sass.CompileError: b"Error: File to import not found or unreadable: lms/static/sass/lms-main-v2
    Parent style sheet: /edx/var/edxapp/themes/simple-theme/lms/static/sass/lms-main-v2.scss
    on line 1 of ../../../var/edxapp/themes/simple-theme/lms/static/sass/lms-main-v2.scss
    >> @import 'lms/static/sass/lms-main-v2';
       ^

JIRA tickets: TBD

Dependencies: None

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None"

Testing instructions:

  1. provision an instance using this branch and with the simple-theme role enabled
  2. verify that it completes successfully and that the theme is compiled and displays as expected

Reviewers

  • [ ] @bradenmacdonald
  • [ ] edX reviewer[s] TBD

Settings

+2 -5

0 comment

3 changed files

pr created time in a month

create barnchopen-craft/configuration

branch : samuel/remove-v2

created branch time in a month

PR opened open-craft/edx-simple-theme

Reviewers
Remove lms-main-v2 template override

This was removed in edx-platform in https://github.com/edx/edx-platform/pull/24624

This should fix this error:

sass.CompileError: b"Error: File to import not found or unreadable: lms/static/sass/lms-main-v2
    Parent style sheet: /edx/var/edxapp/themes/simple-theme/lms/static/sass/lms-main-v2.scss
    on line 1 of ../../../var/edxapp/themes/simple-theme/lms/static/sass/lms-main-v2.scss
    >> @import 'lms/static/sass/lms-main-v2';
       ^

Test instructions:

  • TBD

Reviewer:

  • [ ] @bradenmacdonald
+0 -3

0 comment

1 changed file

pr created time in a month

create barnchopen-craft/edx-simple-theme

branch : samuel/remove-v2

created branch time in a month

pull request commentopen-craft/opencraft

[SE-2869] Forbid registering domains/subdomains which would trick our DNS settings

@gabor-boros done, sorry I missed that.

gabor-boros

comment created time in a month

PullRequestReviewEvent

pull request commentopen-craft/opencraft

[SE-2869] Forbid registering domains/subdomains which would trick our DNS settings

@gabor-boros :+1: awesome work! Please squash your commits to one or more logical changesets, and we can merge. :)

  • [x] I tested this: followed test instructions, tested on stage
  • [x] I read through the code
  • [x] I checked for accessibility issues
  • [x] Includes documentation
  • [ ] NA I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository.
gabor-boros

comment created time in a month

Pull request review commentopen-craft/opencraft

[SE-2869] Forbid registering domains/subdomains which would trick our DNS settings

 def validate_external_domain(self, value):         """         Prevent users from registering with an external domain which was or currently in use.         """-        is_changed = self.instance and self.instance.external_domain == self.initial_data.get("external_domain")+        is_new_instance = self.instance is None+        is_changed = not is_new_instance and self.instance.external_domain == self.initial_data.get("external_domain")

Is checking equality correct here? self.instance.external_domain == self.initial_data.get("external_domain") Shouldn't it be checking if it's not equal (is_changed)?

gabor-boros

comment created time in a month

PullRequestReviewEvent

delete branch open-craft/configuration

delete branch : samuel/fix-digicert

delete time in a month

pull request commentopen-craft/configuration

SE-3327 Certificate validation for intermediate certificate download

No longer needed, since we aren't using use ocim-master any more.

swalladge

comment created time in a month

PR closed open-craft/configuration

Reviewers
SE-3327 Certificate validation for intermediate certificate download

(cherry picked from commit 5426d5dff98a88c74f267fcb94d1f3c248231140) - source: https://github.com/edx/configuration/pull/5852

Original author's description:

Ansible "validate_certs" for ´get_url´ function needs to be turned on for any servers reached via the public Internet. This was likely turned off due to using a faulty certificate delivery server which itself had her trust chain broken. Changed the url to a properly configured certificate distribution server.

Test instructions:

  • provision an instance on an ubuntu server
  • verify it successfully completes the download and update ca certificates steps (ie. the digicert correctly downloaded and update-ca-certificates is run.

Reviewers:

  • [ ] @bradenmacdonald
+2 -1

0 comment

2 changed files

swalladge

pr closed time in a month

PR opened edx/configuration

SE-3327 Validate certs, fix url for digicert ca download

This fixes a minor security issue where ssl certificate is not validated for the digicert ca certificates download task. It does this by using a url that has a certificate that is able to be validated on a base ubuntu image, and enables validate_certs on the ansible get_url task.

This is important, because without validating certs here, it's possible for undesired ca certificates to be added to the root trust if this playbook is run on an untrusted network.

JIRA tickets: TBD

Dependencies: None

Sandbox URL: TBD - sandbox is being provisioned.

Merge deadline: "None"

Testing instructions:

  1. provision an open edx instance using this branch of configuration, and the default value of common_digicert_base_url
  2. verify that the Download digicert intermediate Certificate task succeeds

Reviewers

  • [ ] @bradenmacdonald
  • [ ] edX reviewer[s] TBD

Settings


+2 -2

0 comment

2 changed files

pr created time in a month

push eventopen-craft/configuration

Samuel Walladge

commit sha 00eba5bb1b26e5aedbbeee614185eb95a413d953

Validate certs, fix url for digicert ca download This fixes a minor security issue where ssl certificate is not validated for the digicert ca certificates download task. It does this by using a url that has a certificate that is able to be validated on a base ubuntu image, and enables validate_certs on the ansible get_url task. This is important, because without validating certs here, it's possible for undesired ca certificates to be added to the root trust if this playbook is run on an untrusted network.

view details

push time in a month

create barnchopen-craft/configuration

branch : samuel/fix-digicert-upstream

created branch time in a month

delete branch open-craft/edx-platform

delete branch : samuel/fix-edxnotes-about-section-juniper

delete time in a month

push eventopen-craft/edx-platform

Samuel Walladge

commit sha dd176844cbc8fdf1c6debfd8d9e245fc2cec010e

Use original get_html for AboutBlock This is required to stop get_course_about_section html content from using the edxnotes version of get_html, which injects the edxnotes html into it. We don't want this injected into the html here, because these are snippets meant to be displayed in original form on the course about page.

view details

Samuel Walladge

commit sha 949abae3733b283ec456ef4cc82911e5c0d902bd

Merge pull request #258 from open-craft/samuel/fix-edxnotes-about-section-juniper SE-3243 Use original get_html for AboutBlock

view details

push time in a month

PR merged open-craft/edx-platform

SE-3243 Use original get_html for AboutBlock

This is required to stop get_course_about_section html content from using the edxnotes version of get_html, which injects the edxnotes html into it. We don't want this injected into the html here, because these are snippets meant to be displayed in original form on the course about page.

See https://github.com/edx/edx-platform/pull/24930 for more details and test instructions. This PR simply backports that to our juniper.3 release branch.

+18 -3

1 comment

1 changed file

swalladge

pr closed time in a month

PR opened open-craft/edx-platform

Reviewers
SE-3243 Use original get_html for AboutBlock

This is required to stop get_course_about_section html content from using the edxnotes version of get_html, which injects the edxnotes html into it. We don't want this injected into the html here, because these are snippets meant to be displayed in original form on the course about page.

See https://github.com/edx/edx-platform/pull/24930 for more details and test instructions. This PR simply backports that to our juniper.3 release branch.

+18 -3

0 comment

1 changed file

pr created time in a month

PR opened open-craft/configuration

SE-3336 Certificate validation for intermediate certificate download

(cherry picked from commit 5426d5dff98a88c74f267fcb94d1f3c248231140)

Original author's description:

Ansible "validate_certs" for ´get_url´ function needs to be turned on for any servers reached via the public Internet. This was likely turned off due to using a faulty certificate delivery server which itself had her trust chain broken. Changed the url to a properly configured certificate distribution server.

Test instructions:

  • provision an instance on an ubuntu server
  • verify it successfully completes the download and update ca certificates steps (ie. the digicert correctly downloaded and update-ca-certificates is run.

Reviewers:

  • [ ] @toxinu
+2 -1

0 comment

2 changed files

pr created time in a month

create barnchopen-craft/configuration

branch : samuel/fix-digicert

created branch time in a month

Pull request review commentopen-craft/opencraft

[SE-2869] Forbid registering domains/subdomains which would trick our DNS settings

 def add_dns_record(self, record):         result = client.execute()         return result +    def list_dns_records(self, record):

Nah that's fine - better to be consistent here. If we refactor things in the future it would be nice to define the types more clearly.

gabor-boros

comment created time in a month

PullRequestReviewEvent

PR closed open-craft/configuration

adding a single task for log-syncing

Configuration Pull Request

Make sure that the following steps are done before merging

  • [ ] A devops team member has commented with :+1:
  • [ ] are you adding any new default values that need to be overridden when this goes live?
    • [ ] Open a ticket (DEVOPS) to make sure that they have been added to secure vars.
    • [ ] Add an entry to the CHANGELOG.
+24 -0

5 comments

3 changed files

Metfriet

pr closed time in a month

pull request commentopen-craft/opencraft

Bump http-proxy from 1.18.0 to 1.18.1

@dependabot rebase

dependabot[bot]

comment created time in a month

pull request commentopen-craft/opencraft

Bump lodash from 4.17.15 to 4.17.20

@dependabot rebase

dependabot[bot]

comment created time in a month

pull request commentopen-craft/opencraft

Bump django from 2.2.10 to 2.2.13 in /cleanup_utils

@dependabot rebase

dependabot[bot]

comment created time in a month

pull request commentopen-craft/configuration

adding a single task for log-syncing

@lgp171188

Since there is nothing to merge in this PR, let us keep it open and close it after all the deployments have succeeded.

Did the deployments end up succeeding? Just checking if this PR can be closed.

Metfriet

comment created time in a month

Pull request review commentopen-craft/opencraft

[SE-2869] Forbid registering domains/subdomains which would trick our DNS settings

 def validate_user(self, value):         else:             return value +    def validate_external_domain(self, value) -> str:+        """+        Prevent users from registering with an external domain which was or currently in use.++        The validation reduces the risk of security issues when someone is trying to take over+        control of a client resource (domain) if they forget to restrict its access.+        """+        domain_data = tldextract.extract(value)+        domain = domain_data.registered_domain++        if domain == settings.DEFAULT_INSTANCE_BASE_DOMAIN:+            raise ValidationError('The domain "{domain}" is not allowed.'.format(+                domain=value+            ))++        self._validate_subdomain_not_contains_reserved_word(domain_data.subdomain)++        is_domain_used_for_beta_app = BetaTestApplication.objects.filter(+            external_domain__endswith=domain+        ).exists()++        if is_domain_used_for_beta_app:+            raise ValidationError('This domain is already taken.')++        is_taken = OpenEdXInstance.objects.filter(+            Q(external_lms_domain=domain)+            | Q(external_lms_preview_domain__endswith=domain)+            | Q(external_studio_domain__endswith=domain)+            | Q(external_discovery_domain__endswith=domain)+            | Q(external_ecommerce_domain__endswith=domain)+            # No need to check for subdomain, since it will match anyway+            | Q(extra_custom_domains__contains=domain)+        ).exists()++        if is_taken:+            raise ValidationError('This domain is already taken.')++        return value++    def validate_subdomain(self, value) -> str:+        """+        Prevent users from registering with a subdomain which is in use.++        The validation reduces the risk of security issues when someone is trying to take over+        control of a client resource (domain) if they forget to restrict its access.+        """+        truncated_subdomain = value.split(".")[0]+        self._validate_subdomain_not_contains_reserved_word(truncated_subdomain)++        # Although the validator on the model would catch the existence of+        # the beta application with the given subdomain, this way we can potentially+        # save an API request to Gandi for checking the existance of the DNS record.+        is_subdomain_used_for_beta_app = BetaTestApplication.objects.filter(+            subdomain=value+        ).exists()++        if is_subdomain_used_for_beta_app:+            raise ValidationError("This domain is already taken.")++        domains = set([+            settings.DEFAULT_INSTANCE_BASE_DOMAIN,+            settings.GANDI_DEFAULT_BASE_DOMAIN,+        ])++        for domain in domains:+            try:+                managed_domains = gandi_api.filter_dns_records(domain)

@gabor-boros oh something I just thought of - is this serializer also used for updates? If so, is this then going to fail validation if the domain name wasn't changed, because that domain name will now be in the dns records?

gabor-boros

comment created time in a month

more