profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/svbender/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.
Sven Bender svbender SAP SE Germany

RandomByte/revolving-blue-light-esp8266 0

Wiring up an old battery powered revolving blue light with an ESP8266 based Wemos D1 R2 microcontroller

svbender/dotfiles 0

My dotfiles

svbender/google-api-php-client 0

A PHP client library for accessing Google APIs

PullRequestReviewEvent
PullRequestReviewEvent

push eventSAP/ui5-builder

Sven Bender

commit sha 68d702e915fd95d8330946b14b976bfe63f6a9a0

[INTERNAL] Switch visitor-keys usage from estraverse to espree (#628) Use espree.VisitorKeys instead of those provided by estraverse since the ui5-builder is already using espree. The visitor-keys list from estraverse and espree are different and some unnecessary keys got removed from our list. Espree is using the "eslint-visitor-keys" library which may contain unexpected keys due to the used version range. Therefore the visitor-keys are checked against the available syntax. The visitor-keys were moved to the parseUtils module.

view details

push time in 2 months

delete branch SAP/ui5-builder

delete branch : visitorkeys-estraverse-to-espree

delete time in 2 months

PR merged SAP/ui5-builder

Reviewers
[INTERNAL] Switch visitor-keys usage from estraverse to espree

Use espree.VisitorKeys instead of those provided by estraverse since the ui5-builder is already using espree. The visitor-keys list from estraverse and espree are different and some unnecessary keys got removed from our list. Espree is using the "eslint-visitor-keys" library which may contain unexpected keys due to the used version range. Therefore the visitor-keys are checked against the available syntax. The visitor-keys were moved to the parseUtils module.

+18 -13

1 comment

4 changed files

svbender

pr closed time in 2 months

PR opened SAP/ui5-builder

[INTERNAL] Switch visitor-keys usage from estraverse to espree

Use espree.VisitorKeys instead of those provided by estraverse since the ui5-builder is already using espree. The visitor-keys list from estraverse and espree are different and some unnecessary keys got removed from our list. Espree is using the "eslint-visitor-keys" library which may contain unexpected keys due to the used version range. Therefore the visitor-keys are checked against the available syntax. The visitor-keys were moved to the parseUtils module.

+18 -13

0 comment

4 changed files

pr created time in 3 months

create barnchSAP/ui5-builder

branch : visitorkeys-estraverse-to-espree

created branch time in 3 months

issue commentSAP/ui5-tooling

UI5 deploy target shows info instead of warning

Hi and thanks for reaching out!

The custom task deploy-to-abap is part of the @sap/ux-ui5-tooling module which is not part of the UI5 Tooling project (our modules all start with @ui5/*). It is rather part of the SAP Fiori tools project, which is not open source as of today.

You can get in touch with the SAP Fiori tools team via the SAP Community Website: https://community.sap.com/topics/fiori-tools

Or by asking your questions on the extension's page: https://marketplace.visualstudio.com/items?itemName=SAPSE.sap-ux-fiori-tools-extension-pack&ssr=false#qna

You can also find related documentation here: https://help.sap.com/viewer/product/SAP_FIORI_tools/Latest/en-US

I'll close this issue as it is not related to this project.

ianquigley-sap

comment created time in 3 months

issue closedSAP/ui5-tooling

UI5 deploy target shows info instead of warning

<!-- Hey there 👋 Please have a look at our guidelines on reporting issues: https://github.com/SAP/ui5-tooling/blob/master/CONTRIBUTING.md#-reporting-issues

Please use this template and replace as many "{...}" and "unknown" as possible. Thank you 🧡 -->

Expected Behavior

Deploying with UI5 CLI when no navigation inbound is defined, should be displayed as a warning rather than info.

Current Behavior

An info message is displayed to the user when no inbound navigation is found during ABAP deployment.

Steps to Reproduce the Issue

<!-- Please provide detailed steps on how we can reproduce your issue. Depending on your issue, consider forking our sample app to reproduce it here: https://github.com/SAP/openui5-sample-app -->

  1. Generate an application with missing Fiori launchpad configuration (FLP)
  2. Deploy the application
  3. An info message is displayed as follows:

image

This previously was a warning message. Can it be reverted to a warning?

Context

  • UI5 Module Version (output of ui5 --version when using the CLI): @2.11.3
  • Node.js Version: 14.17.0
  • npm Version: 6.14.13
  • OS/Platform: Business Application Studio
  • Browser (if relevant): N/A
  • Other information regarding your environment (optional): nothing

Log Output / Stack Trace

<!-- When using the UI5 CLI, try adding the "--verbose" flag to get extended logging. Please remove or obfuscate any sensitive information shown in the log. -->

{...}

closed time in 3 months

ianquigley-sap

issue closedSAP/ui5-tooling

Can you use UI5 Tooling for doing the SAPUI5 Walkthrough

Hello,

For someone new to UI5 who wants to start learning and maybe start with the Walkthrough is it possible to use UI5 Tooling and VSCode?

I downloaded for example the code for Step 8 and tried npm install and then npm start which is doing ui5 serve, but I get the following error:

Error Message:
Could not find required manifest.json for project sap.m.tutorial.walkthrough.08: ENOENT: no such file or directory,

I was expecting this to not be a problem in Step 10 where there is a manifest.json but it throws the same error: image

Is it something wrong in the configuration or not possible?

Kind regards, Stefania

closed time in 3 months

stefania-santimbrean

issue commentSAP/ui5-tooling

Can you use UI5 Tooling for doing the SAPUI5 Walkthrough

Hi,

Thanks for reporting this issue. The samples are not correct in this case. This is not an issue with the ui5-tooling, therefore I have created an issue on openui5: https://github.com/SAP/openui5/issues/3292

If you want to proceed with the tutorial, try the following steps to fix it:

  1. The ui5-tooling requires a manifest.json file which is only introduced since step 10 of the walkthrough. Before this step you can add a manifest.json with the minimum requirements in the webapp folder:
{
  "sap.app":{
    "id":"sap.ui.demo.walkthrough",
    "type":"application"
  }
}
  1. The path to the webapp is wrong and needs to be changed in the ui5.yaml:
webapp:"./webapp/"

This webapp path is the default one which means you can also remove the resources: configuration: paths: ... part.

  1. The dependencies in the package.json aren't complete. The sap.m and sap.ui.core dependencies are missing. Add sap.m and sap.ui.core as shown below and run npm install again or directly install them:
"dependencies":{
"@openui5/sap.m":"^1",
"@openui5/sap.ui.core":"^1",
"@openui5/themelib_sap_fiori_3":"^1"
},

Best regards, Sven

stefania-santimbrean

comment created time in 3 months

issue openedSAP/openui5

Wrong tooling configuration and missing dependencies in UI5 Walkthrough tutorial samples

Hello,

This issue was taken from: https://github.com/SAP/ui5-tooling/issues/530

The dependencies and ui5-tooling configuration in the downloaded samples from the UI5 Walkthrough tutorial are not correct: https://sapui5.hana.ondemand.com/#/entity/sap.m.tutorial.walkthrough/sample/sap.m.tutorial.walkthrough.08 https://sapui5.hana.ondemand.com/#/entity/sap.m.tutorial.walkthrough/sample/sap.m.tutorial.walkthrough.10 Please also check the other steps, it is the same issue for all available steps.

Steps to reproduce:

  1. Download one of the examples (e.g. step 8 or 10) and extract it.
  2. Navigate into the folder and run npm install to install the dependencies.
  3. Run npm start to run ui5 serve.

The following error occurs:

Could not find required manifest.json for project sap.m.tutorial.walkthrough.08: ENOENT: no such file or directory, open '/someAbsolutePath/sap.m.tutorial.walkthrough.08/manifest.json'

If you fix the path in the ui5.yaml and a manifest.json file is available the dependencies to sap.ui.core and sap.m are still missing. You can check this in the browser when loading the served app.

Proposal to fix the issue:

  1. The ui5-tooling requires a manifest.json file which is only introduced since step 10 of the walkthrough. A possible fix would be adding a manifest.json with the minimum requirements as a dummy in the webapp folder:
{
    "sap.app": {
    "id":"sap.ui.demo.walkthrough",
    "type":"application"
  }
}
  1. The path to the webapp is wrong and needs to be changed in the ui5.yaml:
webapp:"./webapp/"

This webapp path is the default one which means you can also remove the resources: configuration: paths: ... part.

  1. The dependencies in the package.json aren't complete. The sap.m and sap.ui.core dependencies are missing. It should look something like this:
"dependencies":{
"@openui5/sap.m":"^1",
"@openui5/sap.ui.core":"^1",
"@openui5/themelib_sap_fiori_3":"^1"
},

Thanks and best regards Sven

created time in 3 months