profile
viewpoint
If you are wondering where the data of this site comes from, please visit https://api.github.com/users/sushmitharaos/events. GitMemory does not store any data, but only uses NGINX to cache data for a period of time. The idea behind GitMemory is simply to give users a better reading experience.

arathyjan/openmrs-module-webservices.rest 0

Provides RESTful web services for OpenMRS

mujir/openmrs-core 0

OpenMRS API and web application code

sushmitharaos/docblockr 0

DocBlockr is a package for Atom which is designed to make writing documentation faster and easier.

sushmitharaos/enketo-dristhi 0

Customized enketo-core to be used in hybrid Android app called Dristhi

sushmitharaos/giraffeMaker 0

Methods of object instantiation and inheritence in Javascript

sushmitharaos/javascript_koans 0

Koans to learn Javascript

push eventopenmrs/openmrs-contrib-android-client

Saurabh kumar

commit sha 5eb1712bc866b659991dbf03d3fdfd03c7ec857a

AC-920 : used viewBinding for Patient vitals package (#899)

view details

push time in 27 minutes

PR merged openmrs/openmrs-contrib-android-client

AC-920 : used viewBinding for Patient vitals package

<!--- Add a pull request title above in this format --> <!--- real example: 'AC-204 Applying MVP Model' --> <!--- 'AC-JiraIssueNumber JiraIssueTitle' -->

Description of what I changed

<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->

  1. used view Binding for all the resource elements.
  2. taken care of resource leaks.
  3. removed old hungarian notation from variable names.

Issue I worked on

<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it --> <!--- Just add the issue number at the end: --> JIRA Issue: https://issues.openmrs.org/browse/AC-920

Checklist: I completed these to help reviewers :)

<!--- Put an x in the box if you did the task --> <!--- If you forgot a task please follow the instructions below -->

  • [x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1). <!--- No? -> read here on how to squash multiple commits into one -->

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) <!--- No? -> write tests and add them to this commit git add . && git commit --amend-->

  • [x] All new and existing tests passed. <!--- No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. -->

  • [x] My pull request is based on the latest changes of the master branch. <!--- No? Unsure? -> execute command git pull --rebase upstream master -->

+28 -21

1 comment

1 changed file

LuGO0

pr closed time in 27 minutes

push eventopenmrs/openmrs-contrib-android-client

Saurabh kumar

commit sha b8eb01a0f5605f93313f99a1faeaca7601fa36e5

AC-914 : Used ViewBinding in Matching Patients package (#900)

view details

push time in 28 minutes

PR merged openmrs/openmrs-contrib-android-client

AC-914 : Used ViewBinding in Matching Patients package

<!--- Add a pull request title above in this format --> <!--- real example: 'AC-204 Applying MVP Model' --> <!--- 'AC-JiraIssueNumber JiraIssueTitle' -->

Description of what I changed

<!--- Describe your changes in detail --> <!--- It can simply be your commit message, which you must have -->

  1. Used viewBinding in activity as well as fragment in the matching patient package.
  2. made the binding instance local in activity to escape overring onDestroyView() function.

Issue I worked on

<!--- This project only accepts pull requests related to open issues --> <!--- Want a new feature or change? Discuss it in an issue first --> <!--- Found a bug? Point us to the issue/or create one so we can reproduce it --> <!--- Just add the issue number at the end: --> JIRA Issue: https://issues.openmrs.org/browse/AC-914

Checklist: I completed these to help reviewers :)

<!--- Put an x in the box if you did the task --> <!--- If you forgot a task please follow the instructions below -->

  • [x] My pull request only contains ONE single commit (the number above, next to the 'Commits' tab is 1). <!--- No? -> read here on how to squash multiple commits into one -->

  • [ ] I have added tests to cover my changes. (If you refactored existing code that was well tested you do not have to add tests) <!--- No? -> write tests and add them to this commit git add . && git commit --amend-->

  • [x] All new and existing tests passed. <!--- No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works. -->

  • [x] My pull request is based on the latest changes of the master branch. <!--- No? Unsure? -> execute command git pull --rebase upstream master -->

+45 -35

0 comment

2 changed files

LuGO0

pr closed time in 28 minutes

PullRequestEvent

PR closed openmrs/openmrs-distro-referenceapplication

RATEST-95:Failing Test: Edit Form Test

https://issues.openmrs.org/browse/RATEST-95 cc @k-joseph

+10 -7

4 comments

1 changed file

sherrif10

pr closed time in 5 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-93:Failing Test: Delete Form Test

 public void deleteFormTest() throws Exception {      @After     public void tearDown() throws Exception {+	if(headerPage !=null) {

Any reason for adding this

sherrif10

comment created time in 10 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyModulesAvailableOnHomePage() throws Exception {     }      @Test-    public void verifyClerkModulesAvailableOnHomePage() throws Exception {+    public void verifyClerkModulesAvailableOnHomePage() {         goToLoginPage().loginAsClerk();         homePage = new HomePage(page);-        assertPage(homePage);+        assertPage(homePage.waitForPage());         assertTrue(homePage.isActiveVisitsAppPresent());         assertTrue(homePage.isAppointmentSchedulingAppPresent());-        assertTrue(homePage.isRegisterPatientCustomizedForRefAppPresent());

Any reason for removing this

sherrif10

comment created time in 10 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyModulesAvailableOnHomePage() throws Exception {     }      @Test-    public void verifyClerkModulesAvailableOnHomePage() throws Exception {+    public void verifyClerkModulesAvailableOnHomePage() {         goToLoginPage().loginAsClerk();         homePage = new HomePage(page);-        assertPage(homePage);+        assertPage(homePage.waitForPage());         assertTrue(homePage.isActiveVisitsAppPresent());         assertTrue(homePage.isAppointmentSchedulingAppPresent());

Any reason for removing this

sherrif10

comment created time in 10 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyModulesAvailableOnHomePage() throws Exception {     }      @Test-    public void verifyClerkModulesAvailableOnHomePage() throws Exception {+    public void verifyClerkModulesAvailableOnHomePage() {         goToLoginPage().loginAsClerk();         homePage = new HomePage(page);-        assertPage(homePage);+        assertPage(homePage.waitForPage());         assertTrue(homePage.isActiveVisitsAppPresent());         assertTrue(homePage.isAppointmentSchedulingAppPresent());-        assertTrue(homePage.isRegisterPatientCustomizedForRefAppPresent());

Any reason for removing this

sherrif10

comment created time in 10 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

Add @Category(BuildTests.class) annotation before verifyClerkModulesAvailableOnHomePage() , verifyDoctorModulesAvailableOnHomePage(), verifyNurseModulesAvailableOnHomePage(), verifySysadminModulesAvailableOnHomePage()

sherrif10

comment created time in 10 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-95:Failing Test: Edit Form Test

You need to go through the logs and resolve them and then you can push the ticket to code review

sherrif10

comment created time in 10 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

RATEST-141: Fix find patient by name test

Waiting the page to load ensures that the entered patient identifier matches with the test created patient identifier. Otherwise without waiting the page to load, the comparison is made against the searched patient identifierwith any of the existing patient in the db server instanceinstead of thetest created patient

kdaud

comment created time in 10 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-140: Fix find patient record test

 public void deletePatient() throws Exception {         deletePatient(patient);     } -    @Ignore-    @Category(org.openmrs.reference.groups.BuildTests.class)-    public void testFindPatientRecord() throws InterruptedException {+    @Test+    @Category(BuildTests.class)+    public void findPatientRecordTest() {         FindPatientPage findPatientPage = homePage.goToFindPatientRecord();         findPatientPage.enterPatient(patient.identifier);

Waiting the page to load ensures that the patient identifier entered matches with the test created patient identifier. Otherwise without waiting the page to load, the comparison is made against the entered patient identifier with any of the existing patient instead of the test created patient

kdaud

comment created time in 12 hours

PR opened openmrs/openmrs-distro-referenceapplication

RATEST-141: Fix find patient by name test

Ticket ID: https://issues.openmrs.org/browse/RATEST-141

Description Fix find patient by name test

+8 -4

0 comment

1 changed file

pr created time in 12 hours

PR closed openmrs/openmrs-distro-referenceapplication

RATEST-141: Fix Find Patient By Name Test

Ticket ID: https://issues.openmrs.org/browse/RATEST-141

Description Fix Find Patient By Name

+8 -4

0 comment

1 changed file

kdaud

pr closed time in 12 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Ratest 153: Fix duplicate patient register test

 public void duplicateRegisterTest() throws InterruptedException, ParseException         sdf.applyPattern(NEW_FORMAT);         newBirthDate = sdf.format(date); -         String info = registrationPage.getSimilarPatientInfo();         assertThat(info, Matchers.is(patient.gender + ", " + newBirthDate + ", " + patient.address1 + " " + patient.address2 + " " + patient.city + patient.state + patient.country + patient.postalCode ));     } -

Get rid of these spaces

Have you had a look at the second commit that emphasizes quality assurance

kdaud

comment created time in 18 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Ratest 153: Fix duplicate patient register test

 public void duplicateRegisterTest() throws InterruptedException, ParseException         sdf.applyPattern(NEW_FORMAT);         newBirthDate = sdf.format(date); -         String info = registrationPage.getSimilarPatientInfo();         assertThat(info, Matchers.is(patient.gender + ", " + newBirthDate + ", " + patient.address1 + " " + patient.address2 + " " + patient.city + patient.state + patient.country + patient.postalCode ));     } -

Get rid of these spaces

kdaud

comment created time in 18 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyNurseModulesAvailableOnHomePage() throws Exception {     public void verifySysadminModulesAvailableOnHomePage() throws Exception {

True i aggree since adding a waitForPage handles that

sherrif10

comment created time in 19 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyNurseModulesAvailableOnHomePage() throws Exception {     public void verifySysadminModulesAvailableOnHomePage() throws Exception {

And herealso

sherrif10

comment created time in 20 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyDoctorModulesAvailableOnHomePage() throws Exception {     public void verifyNurseModulesAvailableOnHomePage() throws Exception {

Here as well

sherrif10

comment created time in 20 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyClerkModulesAvailableOnHomePage() throws Exception {     public void verifyDoctorModulesAvailableOnHomePage() throws Exception {

And here

sherrif10

comment created time in 20 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

 public void verifyModulesAvailableOnHomePage() throws Exception {     public void verifyClerkModulesAvailableOnHomePage() throws Exception {

Even here

sherrif10

comment created time in 20 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

Failing Test on firefox: LoginTest

     public void verifyModulesAvailableOnHomePage() throws Exception {

Remove the throws

sherrif10

comment created time in 20 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-135: Fix Add User Test

      private static final String URL = "/admin/index.htm"; -    private static final By MANAGE_USERS = By.cssSelector("#legacyui-manageUsers a");

The element does not exist ??

Lab report indicates clearly that the current property attribute for the element

kdaud

comment created time in 20 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-135: Fix Add User Test

      private static final String URL = "/admin/index.htm"; -    private static final By MANAGE_USERS = By.cssSelector("#legacyui-manageUsers a");

Investigation Lab report indicates clearly that the current property attribute for the element does not exist.

The element does not exist ??

kdaud

comment created time in 20 hours

pull request commentopenmrs/openmrs-distro-referenceapplication

MF-562: Overall Baseline Metadata for 3.0 Packaging

cc: @k-joseph @dkayiwa

alaboso

comment created time in 20 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-135: Fix Add User Test

      private static final String URL = "/admin/index.htm"; -    private static final By MANAGE_USERS = By.cssSelector("#legacyui-manageUsers a");

Any reason why changing to the defined full url

Investigation report indicates clearly that the current property attribute for the element does not exist. Apart from the suggested property, the element can also be retrieved via its id, xpath, linkText and others but in terms ofelementLoadTime, the suggested one takes less time to retrieve the element than any other attribute can do. Putting quality assurance in mind, the suggested property is given a priority

kdaud

comment created time in 20 hours

Pull request review commentopenmrs/openmrs-distro-referenceapplication

RATEST-145: Fix end visit test

 public void setUp() throws Exception {     }      @Test-    @Ignore     @Category(BuildTests.class)-    public void EndVisitTest() throws Exception {+    public void endVisitTest() {         FindPatientPage findPatientPage = homePage.goToFindPatientRecord();         findPatientPage.enterPatient(patient.identifier);         ClinicianFacingPatientDashboardPage clinicianFacingPatientDashboardPage = findPatientPage.clickOnFirstPatient();         PatientVisitsDashboardPage patientVisitsDashboardPage = clinicianFacingPatientDashboardPage.goToRecentVisits();         patientVisitsDashboardPage = patientVisitsDashboardPage.endVisit();-        assertNull(patientVisitsDashboardPage.getActiveVisit());

Have tested this by ignoring and it passed,

After a deep simulation with my virtual remote server on CI Vs Bamboo, I discovered that by just removing @ignore annotation, the test passes with CI But fails with Bamboo. Ideally I trust bamboo test result than CI report. Though the element that is consumed by getActiveVisit() method passes with startVist test when assertNotNull() is applied But the element becomes no longer attached to the DOM when assertNull() is applied. Different element looks ups (id(), xpath(), linkText()) have a similar case.

do you think this change is necessary

Its from the reason above that we rather use assertTrue() function since it achieves the same goal in this case

kdaud

comment created time in 21 hours

PR opened openmrs/openmrs-distro-referenceapplication

Ratest 153: Fix duplicate patient register test

Ticket ID: https://issues.openmrs.org/browse/RATEST-153

Description Fix duplicate patient register test

+3 -10

0 comment

1 changed file

pr created time in 21 hours